dlist: remove unneeded type argument from DLIST_ADD_END()
authorMichael Adam <obnox@samba.org>
Fri, 5 Feb 2016 10:32:18 +0000 (11:32 +0100)
committerJeremy Allison <jra@samba.org>
Sat, 6 Feb 2016 20:48:17 +0000 (21:48 +0100)
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
77 files changed:
ctdb/common/ctdb_io.c
ctdb/server/ctdb_call.c
ctdb/server/ctdb_daemon.c
ctdb/server/ctdb_lock.c
ctdb/server/ctdb_logging.c
lib/torture/torture.c
lib/util/dlinklist.h
lib/util/tests/dlinklist.c
libcli/cldap/cldap.c
libcli/nbt/nbtsocket.c
libcli/smb/smbXcli_base.c
source3/auth/auth.c
source3/auth/pampass.c
source3/lib/smbldap.c
source3/lib/unix_msg/unix_msg.c
source3/lib/util_ea.c
source3/libsmb/clidfs.c
source3/libsmb/clireadwrite.c
source3/modules/vfs_aio_pthread.c
source3/nmbd/nmbd_browserdb.c
source3/nmbd/nmbd_packets.c
source3/nmbd/nmbd_responserecordsdb.c
source3/nmbd/nmbd_serverlistdb.c
source3/param/loadparm.c
source3/printing/notify.c
source3/registry/regfio.c
source3/rpc_server/fss/srv_fss_agent.c
source3/rpc_server/fss/srv_fss_state.c
source3/smbd/blocking.c
source3/smbd/notify.c
source3/smbd/posix_acls.c
source3/smbd/process.c
source3/smbd/server.c
source3/smbd/smb2_server.c
source3/smbd/smbXsrv_session.c
source3/smbd/trans2.c
source3/winbindd/winbindd_util.c
source4/auth/ntlm/auth.c
source4/dns_server/dnsserver_common.c
source4/dsdb/common/util_trusts.c
source4/dsdb/kcc/kcc_drs_replica_info.c
source4/dsdb/repl/drepl_notify.c
source4/dsdb/repl/drepl_out_pull.c
source4/dsdb/repl/drepl_partitions.c
source4/dsdb/repl/replicated_objects.c
source4/dsdb/samdb/ldb_modules/descriptor.c
source4/dsdb/samdb/ldb_modules/linked_attributes.c
source4/dsdb/samdb/ldb_modules/secrets_tdb_sync.c
source4/dsdb/samdb/ldb_modules/update_keytab.c
source4/dsdb/schema/schema_query.c
source4/ldap_server/ldap_backend.c
source4/lib/http/http.c
source4/lib/socket/interface.c
source4/lib/stream/packet.c
source4/libcli/dgram/dgramsocket.c
source4/libcli/resolve/resolve.c
source4/librpc/rpc/dcerpc.c
source4/nbt_server/register.c
source4/nbt_server/wins/winsserver.c
source4/ntvfs/ntvfs_base.c
source4/ntvfs/posix/pvfs_notify.c
source4/rpc_server/common/reply.c
source4/rpc_server/dcerpc_server.c
source4/rpc_server/dnsserver/dcerpc_dnsserver.c
source4/rpc_server/dnsserver/dnsdb.c
source4/smb_server/smb2/receive.c
source4/smb_server/smb_server.h
source4/smbd/service.c
source4/torture/local/fsrvp_state.c
source4/torture/nbench/nbio.c
source4/torture/nbt/wins.c
source4/torture/ndr/ndr.c
source4/torture/rpc/spoolss_notify.c
source4/torture/smb2/smb2.c
source4/torture/util_smb.c
source4/torture/vfs/vfs.c
source4/wrepl_server/wrepl_server.c

index 24968b3ac91b4a91d73fbb7adaca0cb501abf7ba..894935e8859d4627485f391b3b99e6607cc50bea 100644 (file)
@@ -352,7 +352,7 @@ int ctdb_queue_send(struct ctdb_queue *queue, uint8_t *data, uint32_t length)
                TEVENT_FD_WRITEABLE(queue->fde);
        }
 
-       DLIST_ADD_END(queue->out_queue, pkt, NULL);
+       DLIST_ADD_END(queue->out_queue, pkt);
 
        queue->out_queue_length++;
 
index db9fb6aefc591d4005ffe9cd3535f21ee527f511..453b4561d54748900d6ab3ac76885045101818bd 100644 (file)
@@ -565,7 +565,7 @@ static int dmaster_defer_add(struct ctdb_db_context *ctdb_db,
        call->ctdb = ctdb_db->ctdb;
        call->hdr = talloc_steal(call, hdr);
 
-       DLIST_ADD_END(ddq->deferred_calls, call, NULL);
+       DLIST_ADD_END(ddq->deferred_calls, call);
 
        return 0;
 }
@@ -1911,7 +1911,7 @@ child_finished:
        set_close_on_exec(rc->fd[0]);
 
        /* This is an active revokechild child process */
-       DLIST_ADD_END(ctdb_db->revokechild_active, rc, NULL);
+       DLIST_ADD_END(ctdb_db->revokechild_active, rc);
 
        rc->fde = tevent_add_fd(ctdb->ev, rc, rc->fd[0], TEVENT_FD_READ,
                                revokechild_handler, (void *)rc);
index 36dcfad859021425dc60a3ffd9527eb4209f58f8..9a3369166db55590780c4a918950061324a338c6 100644 (file)
@@ -590,7 +590,7 @@ static int requeue_duplicate_fetch(struct ctdb_db_context *ctdb_db, struct ctdb_
        dfc->w->ctdb = ctdb_db->ctdb;
        dfc->w->client_id = client->client_id;
 
-       DLIST_ADD_END(dfq->deferred_calls, dfc, NULL);
+       DLIST_ADD_END(dfq->deferred_calls, dfc);
 
        return 0;
 }
index 78ba35c78a6d90f60bfec6eb232f081065ab6de0..7962e94801fb3a21d17a4363f2eb6814db0c36d8 100644 (file)
@@ -902,10 +902,10 @@ static void ctdb_lock_schedule(struct ctdb_context *ctdb)
        /* Move the context from pending to current */
        if (lock_ctx->type == LOCK_RECORD) {
                DLIST_REMOVE(lock_ctx->ctdb_db->lock_pending, lock_ctx);
-               DLIST_ADD_END(lock_ctx->ctdb_db->lock_current, lock_ctx, NULL);
+               DLIST_ADD_END(lock_ctx->ctdb_db->lock_current, lock_ctx);
        } else {
                DLIST_REMOVE(ctdb->lock_pending, lock_ctx);
-               DLIST_ADD_END(ctdb->lock_current, lock_ctx, NULL);
+               DLIST_ADD_END(ctdb->lock_current, lock_ctx);
        }
        CTDB_DECREMENT_STAT(lock_ctx->ctdb, locks.num_pending);
        CTDB_INCREMENT_STAT(lock_ctx->ctdb, locks.num_current);
@@ -975,9 +975,9 @@ static struct lock_request *ctdb_lock_internal(TALLOC_CTX *mem_ctx,
         * immediately, so keep them at the head of the pending queue.
         */
        if (lock_ctx->type == LOCK_RECORD) {
-               DLIST_ADD_END(ctdb_db->lock_pending, lock_ctx, NULL);
+               DLIST_ADD_END(ctdb_db->lock_pending, lock_ctx);
        } else {
-               DLIST_ADD_END(ctdb->lock_pending, lock_ctx, NULL);
+               DLIST_ADD_END(ctdb->lock_pending, lock_ctx);
        }
        CTDB_INCREMENT_STAT(ctdb, locks.num_pending);
        if (ctdb_db) {
index 29b1982e28af8b0874702820213ce6ce494c9855..1819ab7d98cdb8c94e9922bbd4fd9314e07b4627 100644 (file)
@@ -71,7 +71,7 @@ void ctdb_log_register_backend(const char *prefix, ctdb_log_setup_fn_t setup)
        b->prefix = prefix;
        b->setup = setup;
 
-       DLIST_ADD_END(log_state->backends, b, NULL);
+       DLIST_ADD_END(log_state->backends, b);
 }
 
 
index 78d8261d1a359f7ce7669ea8af8209f694451119..40807d92a62151c22e688df12de16377e34a3ed6 100644 (file)
@@ -277,7 +277,7 @@ struct torture_test *torture_tcase_add_test_const(struct torture_tcase *tcase,
        test->dangerous = false;
        test->data = data;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
@@ -296,7 +296,7 @@ bool torture_suite_init_tcase(struct torture_suite *suite,
        tcase->fixture_persistent = true;
        tcase->tests = NULL;
 
-       DLIST_ADD_END(suite->testcases, tcase, struct torture_tcase *);
+       DLIST_ADD_END(suite->testcases, tcase);
 
        return true;
 }
@@ -617,7 +617,7 @@ struct torture_tcase *torture_suite_add_simple_tcase_const(
        test->data = data;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return tcase;
 }
@@ -651,7 +651,7 @@ struct torture_tcase *torture_suite_add_simple_test(
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return tcase;
 }
@@ -665,7 +665,7 @@ bool torture_suite_add_suite(struct torture_suite *suite,
        if (child == NULL)
                return false;
 
-       DLIST_ADD_END(suite->children, child, struct torture_suite *);
+       DLIST_ADD_END(suite->children, child);
 
        /* FIXME: Check for duplicates and return false if the 
         * added suite already exists as a child */
@@ -716,7 +716,7 @@ struct torture_test *torture_tcase_add_simple_test_const(
        test->data = NULL;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
@@ -747,7 +747,7 @@ struct torture_test *torture_tcase_add_simple_test(struct torture_tcase *tcase,
        test->data = NULL;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
index 5520901739b2ee624b5f3a930d6bf8bb0d256058..316ba10ab7657816359906d892e2ef0f711261c9 100644 (file)
@@ -131,9 +131,8 @@ do { \
 
 /*
    add to the end of a list.
-   Note that 'type' is ignored
 */
-#define DLIST_ADD_END(list, p, type)                   \
+#define DLIST_ADD_END(list, p) \
 do { \
        if (!(list)) { \
                DLIST_ADD(list, p); \
@@ -156,7 +155,7 @@ do { \
 #define DLIST_DEMOTE(list, p, type)                    \
 do { \
        DLIST_REMOVE(list, p); \
-       DLIST_ADD_END(list, p, NULL);           \
+       DLIST_ADD_END(list, p); \
 } while (0)
 
 /*
index bef61d2cbdfa680e44aee8e0b5c6f69e922c330f..462f4a7137e398bad008fe4d4f1ccdcb08a26e75 100644 (file)
@@ -43,7 +43,7 @@ static bool torture_local_dlinklist_simple(struct torture_context *tctx)
        torture_comment(tctx, "add 5 elements at end\n");
        for (i=0; i<5; i++) {
                el = talloc(mem_ctx, struct listel);
-               DLIST_ADD_END(l1, el, NULL);
+               DLIST_ADD_END(l1, el);
        }
 
        torture_comment(tctx, "delete 3 from front\n");
@@ -57,7 +57,7 @@ static bool torture_local_dlinklist_simple(struct torture_context *tctx)
        for (i=0; i < 3; i++) {
                el = DLIST_TAIL(l1);
                DLIST_REMOVE(l1, el);
-               DLIST_ADD_END(l2, el, NULL);
+               DLIST_ADD_END(l2, el);
        }
 
        torture_comment(tctx, "count forward\n");
index dd9d40b0c363157a8ad62003f31ff21886d0dec9..c5977cc994a033cf0e20ed2aed6e4b1defedca7e 100644 (file)
@@ -675,7 +675,7 @@ struct tevent_req *cldap_search_send(TALLOC_CTX *mem_ctx,
        }
        tevent_req_set_callback(subreq, cldap_search_state_queue_done, req);
 
-       DLIST_ADD_END(cldap->searches.list, state, struct cldap_search_state *);
+       DLIST_ADD_END(cldap->searches.list, state);
 
        return req;
 
index 6c627398418e55722e00275601015a33e2a09e6c..dacacae9f50ec0ac53c99539ff1155117db2fbd0 100644 (file)
@@ -127,8 +127,7 @@ static void nbt_name_socket_timeout(struct tevent_context *ev, struct tevent_tim
                                           nbt_name_socket_timeout, req);
                if (req->state != NBT_REQUEST_SEND) {
                        req->state = NBT_REQUEST_SEND;
-                       DLIST_ADD_END(req->nbtsock->send_queue, req,
-                                     struct nbt_name_request *);
+                       DLIST_ADD_END(req->nbtsock->send_queue, req);
                }
                TEVENT_FD_WRITEABLE(req->nbtsock->fde);
                return;
@@ -418,7 +417,7 @@ struct nbt_name_request *nbt_name_request_send(struct nbt_name_socket *nbtsock,
                                       (ndr_push_flags_fn_t)ndr_push_nbt_name_packet);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) goto failed;
 
-       DLIST_ADD_END(nbtsock->send_queue, req, struct nbt_name_request *);
+       DLIST_ADD_END(nbtsock->send_queue, req);
 
        if (DEBUGLVL(10)) {
                DEBUG(10,("Queueing nbt packet to %s:%d\n",
@@ -469,7 +468,7 @@ _PUBLIC_ NTSTATUS nbt_name_reply_send(struct nbt_name_socket *nbtsock,
                return ndr_map_error2ntstatus(ndr_err);
        }
 
-       DLIST_ADD_END(nbtsock->send_queue, req, struct nbt_name_request *);
+       DLIST_ADD_END(nbtsock->send_queue, req);
 
        TEVENT_FD_WRITEABLE(nbtsock->fde);
 
index 5fc380e9daf88f2e626c23482e60d1be34b6c59c..ad6a254bc0c7b3abbfb201b75fcffa150f0c0e5d 100644 (file)
@@ -5264,7 +5264,7 @@ struct smbXcli_session *smbXcli_session_create(TALLOC_CTX *mem_ctx,
        }
        talloc_set_destructor(session, smbXcli_session_destructor);
 
-       DLIST_ADD_END(conn->sessions, session, struct smbXcli_session *);
+       DLIST_ADD_END(conn->sessions, session);
        session->conn = conn;
 
        memcpy(session->smb2_channel.preauth_sha512,
@@ -5294,7 +5294,7 @@ struct smbXcli_session *smbXcli_session_copy(TALLOC_CTX *mem_ctx,
        session->smb2_channel = src->smb2_channel;
        session->disconnect_expired = src->disconnect_expired;
 
-       DLIST_ADD_END(src->conn->sessions, session, struct smbXcli_session *);
+       DLIST_ADD_END(src->conn->sessions, session);
        talloc_set_destructor(session, smbXcli_session_destructor);
 
        return session;
@@ -5793,7 +5793,7 @@ NTSTATUS smb2cli_session_create_channel(TALLOC_CTX *mem_ctx,
        }
 
        talloc_set_destructor(session2, smbXcli_session_destructor);
-       DLIST_ADD_END(conn->sessions, session2, struct smbXcli_session *);
+       DLIST_ADD_END(conn->sessions, session2);
        session2->conn = conn;
 
        memcpy(session2->smb2_channel.preauth_sha512,
index 00261f725fa6a0c5c2ac08899730d88fbcc5de32..833eae9a7c210dfe15e9c31cf44ba88de79a55fd 100644 (file)
@@ -436,7 +436,7 @@ static NTSTATUS make_auth_context_text_list(TALLOC_CTX *mem_ctx,
 
        for (;*text_list; text_list++) { 
                if (load_auth_module(*auth_context, *text_list, &t)) {
-                   DLIST_ADD_END(list, t, auth_methods *);
+                   DLIST_ADD_END(list, t);
                }
        }
 
index 2a3195c8b427bcede8aa84b344c8b59023bdc228..1a82fe7f20347732904526b7431ea15f814aaeef 100644 (file)
@@ -237,7 +237,7 @@ static struct chat_struct *make_pw_chat(const char *p)
 
                ZERO_STRUCTP(t);
 
-               DLIST_ADD_END(list, t, struct chat_struct*);
+               DLIST_ADD_END(list, t);
 
                if (!next_token_talloc(frame, &p, &prompt, NULL)) {
                        break;
index 1560f65c07aafb10e226f82d797dea89bd8818f5..5a876e019e8b2cbdf43153b74f063a939ff0982e 100644 (file)
@@ -545,7 +545,7 @@ static void smbldap_store_state(LDAP *ld, struct smbldap_state *smbldap_state)
        t = SMB_XMALLOC_P(struct smbldap_state_lookup);
        ZERO_STRUCTP(t);
 
-       DLIST_ADD_END(smbldap_state_lookup_list, t, struct smbldap_state_lookup *);
+       DLIST_ADD_END(smbldap_state_lookup_list, t);
        t->ld = ld;
        t->smbldap_state = smbldap_state;
 }
index cb648ede97f9e6e77b6851ecb5efbd856901e37e..bcfef2852d9dc7c5578ad9f7e17c30f8e7ca3fcb 100644 (file)
@@ -495,7 +495,7 @@ static int queue_msg(struct unix_dgram_send_queue *q,
        msghdr_copy(hdr, msghdrlen, NULL, 0, iov, iovcnt,
                    fds_copy, num_fds);
 
-       DLIST_ADD_END(q->msgs, msg, struct unix_dgram_msg);
+       DLIST_ADD_END(q->msgs, msg);
        return 0;
 fail:
        close_fd_array(fds_copy, num_fds);
index e980e69ab4ca85fa64955c1d480854fdb847b6ef..136291bec9491bef296ec97c64cfeb16dfb5a4ba 100644 (file)
@@ -103,7 +103,7 @@ struct ea_list *read_nttrans_ea_list(TALLOC_CTX *ctx, const char *pdata, size_t
                        return NULL;
                }
 
-               DLIST_ADD_END(ea_list_head, eal, struct ea_list *);
+               DLIST_ADD_END(ea_list_head, eal);
                if (next_offset == 0) {
                        break;
                }
index d3b0580230bddbed28c2e741ab793698a177bdb4..d2a4c194f44986782c34de18ba334619df80f330 100644 (file)
@@ -329,7 +329,7 @@ static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx,
 
        /* Enter into the list. */
        if (referring_cli) {
-               DLIST_ADD_END(referring_cli, cli, struct cli_state *);
+               DLIST_ADD_END(referring_cli, cli);
        }
 
        if (referring_cli && referring_cli->requested_posix_capabilities) {
index 79bf416822af94d4986a31c7808721c8f7737ffd..35141540e6209b14e333534c29dde13397499bcf 100644 (file)
@@ -437,7 +437,7 @@ static void cli_pull_setup_chunks(struct tevent_req *req)
                state->next_offset += chunk->total_size;
                state->remaining -= chunk->total_size;
 
-               DLIST_ADD_END(state->chunks, chunk, NULL);
+               DLIST_ADD_END(state->chunks, chunk);
                state->num_chunks++;
                state->num_waiting++;
 
@@ -1250,7 +1250,7 @@ static void cli_push_setup_chunks(struct tevent_req *req)
                }
                state->next_offset += chunk->total_size;
 
-               DLIST_ADD_END(state->chunks, chunk, NULL);
+               DLIST_ADD_END(state->chunks, chunk);
                state->num_chunks++;
                state->num_waiting++;
 
index 10a3a23100b33626222f7d00cf93c527fe4def78..7037b633e5e19e653c80f93bc0972cbe37d5cf76 100644 (file)
@@ -341,7 +341,7 @@ static struct aio_open_private_data *create_private_open_data(const files_struct
        }
 
        talloc_set_destructor(opd, opd_destructor);
-       DLIST_ADD_END(open_pd_list, opd, struct aio_open_private_data *);
+       DLIST_ADD_END(open_pd_list, opd);
        return opd;
 }
 
index b36f5c7fc42b9943ca3f086724d47e7c57df924d..b883f569c196ae889eaf8ed6055ee59ccd2d24a6 100644 (file)
@@ -120,7 +120,7 @@ struct browse_cache_record *create_browser_in_lmb_cache( const char *work_name,
   
        browc->ip = ip;
  
-       DLIST_ADD_END(lmb_browserlist, browc, struct browse_cache_record *);
+       DLIST_ADD_END(lmb_browserlist, browc);
 
        DEBUG(3, ("nmbd_browserdb:create_browser_in_lmb_cache()\n"));
        DEBUGADD(3, ("  Added lmb cache entry for workgroup %s name %s IP %s "
index 9f5cc18039deffef07be794bf1194d0fa9e49030..b608354e7b1460e55aa08ef2d0653d2bd7c0c2d8 100644 (file)
@@ -1033,7 +1033,7 @@ void reply_netbios_packet(struct packet_struct *orig_packet,
 
 void queue_packet(struct packet_struct *packet)
 {
-       DLIST_ADD_END(packet_queue, packet, struct packet_struct *);
+       DLIST_ADD_END(packet_queue, packet);
 }
 
 /****************************************************************************
index bd188509868cc1440b764eb4d823b0ee5bf65b66..4753bbff75b8b026a27ef913ebedd85e5bc6a053 100644 (file)
@@ -37,7 +37,7 @@ static void add_response_record(struct subnet_record *subrec,
        DEBUG(4,("add_response_record: adding response record id:%hu to subnet %s. num_records:%d\n",
                rrec->response_id, subrec->subnet_name, num_response_packets));
 
-       DLIST_ADD_END(subrec->responselist, rrec, struct response_record *);
+       DLIST_ADD_END(subrec->responselist, rrec);
 }
 
 /***************************************************************************
index cd84bdf1d1e0d331061f7fc68d8df1cd4ee2761c..43471d69e45104ada396802da5c1cd15f1b3c7ec 100644 (file)
@@ -54,7 +54,7 @@ void remove_all_servers(struct work_record *work)
 static void add_server_to_workgroup(struct work_record *work,
                              struct server_record *servrec)
 {
-       DLIST_ADD_END(work->serverlist, servrec, struct server_record *);
+       DLIST_ADD_END(work->serverlist, servrec);
        work->subnet->work_changed = True;
 }
 
index fb92230ffbaf3861374b186fbb90c2c8f6cce683..7c3195bc3072acbf36b426f798aeadea3cac7445 100644 (file)
@@ -463,7 +463,7 @@ bool store_lp_set_cmdline(const char *pszParmName, const char *pszParmValue)
                return false;
        }
 
-       DLIST_ADD_END(stored_options, entry, struct lp_stored_option);
+       DLIST_ADD_END(stored_options, entry);
 
        return true;
 }
index 930e72b408a8c915f83c51eb416b83f6e1d53dca..d2c5f72fff574f00bccd1120bdaa8c399f18a0d1 100644 (file)
@@ -331,7 +331,7 @@ to notify_queue_head\n", msg->type, msg->field, msg->printer));
         * the messages are sent in the order they were received. JRA.
         */
 
-       DLIST_ADD_END(notify_queue_head, pnqueue, struct notify_queue *);
+       DLIST_ADD_END(notify_queue_head, pnqueue);
        num_messages++;
 
        if ((notify_event == NULL) && (ev != NULL)) {
index c895bc45a9ce77ad3cb39e9aa4c3ed4a0baf3b0f..9bb89ff11d479be9047e497bf56067dc7c0f1f72 100644 (file)
@@ -1852,7 +1852,7 @@ static int hashrec_cmp( REGF_HASH_REC *h1, REGF_HASH_REC *h2 )
                        nk->sec_desc->size      = ndr_size_security_descriptor(sec_desc, 0)
                                + sizeof(uint32_t);
 
-                       DLIST_ADD_END( file->sec_desc_list, nk->sec_desc, REGF_SK_REC *);
+                       DLIST_ADD_END( file->sec_desc_list, nk->sec_desc);
 
                        /* update the offsets for us and the previous sd in the list.
                           if this is the first record, then just set the next and prev
index 19578cc0c39a1d6ca5789f639c7360d3627231c0..68a51439c25c5628d1cc63be10810de2208e8cbe 100644 (file)
@@ -247,8 +247,7 @@ static NTSTATUS fss_prune_stale(struct messaging_context *msg_ctx,
                        while (sc_smap != NULL) {
                                struct fss_sc_smap *smap_next = sc_smap->next;
                                DLIST_REMOVE(sc->smaps, sc_smap);
-                               DLIST_ADD_END(prunable_sc_smaps, sc_smap,
-                                             struct fss_sc_smap *);
+                               DLIST_ADD_END(prunable_sc_smaps, sc_smap);
                                sc->smaps_count--;
                                sc_smap = smap_next;
                        }
@@ -668,7 +667,7 @@ uint32_t _fss_StartShadowCopySet(struct pipes_struct *p,
        }
        sc_set->state = FSS_SC_STARTED;
        sc_set->context = fss_global.cur_ctx;
-       DLIST_ADD_END(fss_global.sc_sets, sc_set, struct fss_sc_set *);
+       DLIST_ADD_END(fss_global.sc_sets, sc_set);
        fss_global.sc_sets_count++;
        DEBUG(6, ("%s: shadow-copy set %u added\n",
                  sc_set->id_str, fss_global.sc_sets_count));
@@ -864,10 +863,10 @@ uint32_t _fss_AddToShadowCopySet(struct pipes_struct *p,
        }
 
        /* add share map to shadow-copy */
-       DLIST_ADD_END(sc->smaps, sc_smap, struct fss_sc_smap *);
+       DLIST_ADD_END(sc->smaps, sc_smap);
        sc->smaps_count++;
        /* add shadow-copy to shadow-copy set */
-       DLIST_ADD_END(sc_set->scs, sc, struct fss_sc *);
+       DLIST_ADD_END(sc_set->scs, sc);
        sc_set->scs_count++;
        DEBUG(4, ("added volume %s to shadow copy set with GUID %s\n",
                  sc->volume_name, sc_set->id_str));
index 97604f3e8faa48ebd0654d5be8c7572239a1ab3f..0f2ef0e5e711f93c5ed20230ac4b2f062c1d34a3 100644 (file)
@@ -437,7 +437,7 @@ static int fss_state_retrieve_traverse(struct db_record *rec,
                if (!NT_STATUS_IS_OK(status)) {
                        return -1;
                }
-               DLIST_ADD_END(trv_state->smaps, smap, struct fss_sc_smap *);
+               DLIST_ADD_END(trv_state->smaps, smap);
                trv_state->smaps_count++;
        } else if (strstr((char *)key.dptr, FSS_DB_KEY_PFX_SC) != NULL) {
                struct fss_sc *sc;
@@ -446,7 +446,7 @@ static int fss_state_retrieve_traverse(struct db_record *rec,
                if (!NT_STATUS_IS_OK(status)) {
                        return -1;
                }
-               DLIST_ADD_END(trv_state->scs, sc, struct fss_sc *);
+               DLIST_ADD_END(trv_state->scs, sc);
                trv_state->scs_count++;
        } else if (strstr((char *)key.dptr, FSS_DB_KEY_PFX_SC_SET) != NULL) {
                struct fss_sc_set *sc_set;
@@ -455,7 +455,7 @@ static int fss_state_retrieve_traverse(struct db_record *rec,
                if (!NT_STATUS_IS_OK(status)) {
                        return -1;
                }
-               DLIST_ADD_END(trv_state->sc_sets, sc_set, struct fss_sc_set *);
+               DLIST_ADD_END(trv_state->sc_sets, sc_set);
                trv_state->sc_sets_count++;
        } else {
                /* global context and db vers */
@@ -487,7 +487,7 @@ static NTSTATUS fss_state_hierarchize_smaps(struct fss_traverse_state *trv_state
                talloc_steal(sc, smap);
                DLIST_REMOVE(trv_state->smaps, smap);
                trv_state->smaps_count--;
-               DLIST_ADD_END(sc->smaps, smap, struct fss_sc_smap *);
+               DLIST_ADD_END(sc->smaps, smap);
                smaps_moved++;
 
                /* last component of the tdb key path is the sc share name */
@@ -527,7 +527,7 @@ static NTSTATUS fss_state_hierarchize_scs(struct fss_traverse_state *trv_state,
                talloc_steal(sc_set, sc);
                DLIST_REMOVE(trv_state->scs, sc);
                trv_state->scs_count--;
-               DLIST_ADD_END(sc_set->scs, sc, struct fss_sc *);
+               DLIST_ADD_END(sc_set->scs, sc);
                scs_moved++;
 
                sc->sc_set = sc_set;
@@ -575,7 +575,7 @@ static NTSTATUS fss_state_hierarchize(struct fss_traverse_state *trv_state,
                /* sc_set mem already owned by trv_state->mem_ctx */
                DLIST_REMOVE(trv_state->sc_sets, sc_set);
                trv_state->sc_sets_count--;
-               DLIST_ADD_END(*sc_sets, sc_set, struct fss_sc_set *);
+               DLIST_ADD_END(*sc_sets, sc_set);
                i++;
 
                /* last component of the tdb key path is the sc_set GUID str */
index 4fd8e1da123892df9e84cf7c51e8a563b09ae4b1..1e3a596d11fb05299f4fab2770ebd79779a58156 100644 (file)
@@ -238,7 +238,7 @@ bool push_blocking_lock_request( struct byte_range_lock *br_lck,
        SMB_PERFCOUNT_DEFER_OP(&req->pcd, &req->pcd);
        blr->req = talloc_move(blr, &req);
 
-       DLIST_ADD_END(sconn->smb1.locks.blocking_lock_queue, blr, struct blocking_lock_record *);
+       DLIST_ADD_END(sconn->smb1.locks.blocking_lock_queue, blr);
        recalc_brl_timeout(sconn);
 
        /* Ensure we'll receive messages when this is unlocked. */
index 625726000233080d887679a7beae5a5c521a6072..d7382db69381a7a442fe55420c4a9869956686ac 100644 (file)
@@ -327,8 +327,7 @@ NTSTATUS change_notify_add_request(struct smb_request *req,
        request->reply_fn = reply_fn;
        request->backend_data = NULL;
 
-       DLIST_ADD_END(fsp->notify->requests, request,
-                     struct notify_change_request *);
+       DLIST_ADD_END(fsp->notify->requests, request);
 
        map->mid = request->req->mid;
        DLIST_ADD(sconn->smb1.notify_mid_maps, map);
index 5e39370ac91642add1ec66f3c3b79c494f875670..1f2380bf3dbc9b32c10a479352783539cb6c6dfd 100644 (file)
@@ -1688,7 +1688,7 @@ static bool add_current_ace_to_acl(files_struct *fsp, struct security_ace *psa,
                    (SEC_ACE_FLAG_OBJECT_INHERIT|SEC_ACE_FLAG_CONTAINER_INHERIT)) {
 
                        canon_ace *current_dir_ace = current_ace;
-                       DLIST_ADD_END(*dir_ace, current_ace, canon_ace *);
+                       DLIST_ADD_END(*dir_ace, current_ace);
 
                        /*
                         * Note if this was an allow ace. We can't process
@@ -1790,7 +1790,7 @@ static bool add_current_ace_to_acl(files_struct *fsp, struct security_ace *psa,
         */
 
        if (current_ace && !(psa->flags & SEC_ACE_FLAG_INHERIT_ONLY)) {
-               DLIST_ADD_END(*file_ace, current_ace, canon_ace *);
+               DLIST_ADD_END(*file_ace, current_ace);
 
                /*
                 * Note if this was an allow ace. We can't process
index ee88b58a0c8a644f1bcbc198819f691a0c21e4d3..25c6d0539bc2ddf89c1dc7618cc5f9960245ca5a 100644 (file)
@@ -750,8 +750,7 @@ static bool push_queued_message(struct smb_request *req,
        }
 #endif
 
-       DLIST_ADD_END(req->sconn->deferred_open_queue, msg,
-                     struct pending_message_list *);
+       DLIST_ADD_END(req->sconn->deferred_open_queue, msg);
 
        DEBUG(10,("push_message: pushed message length %u on "
                  "deferred_open_queue\n", (unsigned int)msg_len));
@@ -3873,7 +3872,7 @@ NTSTATUS smbd_add_connection(struct smbXsrv_client *client, int sock_fd,
        }
 
        /* for now we only have one connection */
-       DLIST_ADD_END(client->connections, xconn, NULL);
+       DLIST_ADD_END(client->connections, xconn);
        xconn->client = client;
        talloc_steal(client, xconn);
 
index 1dd4f898a51c56401598cc12a8204d72078b459c..42fcad6de1bea9fa4a027a8bd4f9f73479f26d26 100644 (file)
@@ -846,7 +846,7 @@ static bool smbd_open_one_socket(struct smbd_parent_context *parent,
        }
        tevent_fd_set_close_fn(s->fde, smbd_open_socket_close_fn);
 
-       DLIST_ADD_END(parent->sockets, s, struct smbd_open_socket *);
+       DLIST_ADD_END(parent->sockets, s);
 
        return true;
 }
index 58f933b3c0031c2744e7af96c731a022fbea7d48..ac922a104af3f4e0450d2390864a6d1d6c508b1e 100644 (file)
@@ -1050,7 +1050,7 @@ static NTSTATUS smbd_smb2_request_setup_out(struct smbd_smb2_request *req)
                return NT_STATUS_INVALID_PARAMETER_MIX;
        }
 
-       DLIST_ADD_END(xconn->smb2.requests, req, struct smbd_smb2_request *);
+       DLIST_ADD_END(xconn->smb2.requests, req);
 
        return NT_STATUS_OK;
 }
@@ -1304,7 +1304,7 @@ static NTSTATUS smb2_send_async_interim_response(const struct smbd_smb2_request
        nreq->queue_entry.mem_ctx = nreq;
        nreq->queue_entry.vector = nreq->out.vector;
        nreq->queue_entry.count = nreq->out.vector_count;
-       DLIST_ADD_END(xconn->smb2.send_queue, &nreq->queue_entry, NULL);
+       DLIST_ADD_END(xconn->smb2.send_queue, &nreq->queue_entry);
        xconn->smb2.send_queue_len++;
 
        status = smbd_smb2_flush_send_queue(xconn);
@@ -1691,7 +1691,7 @@ static void smbd_smb2_request_pending_timer(struct tevent_context *ev,
        state->queue_entry.mem_ctx = state;
        state->queue_entry.vector = state->vector;
        state->queue_entry.count = ARRAY_SIZE(state->vector);
-       DLIST_ADD_END(xconn->smb2.send_queue, &state->queue_entry, NULL);
+       DLIST_ADD_END(xconn->smb2.send_queue, &state->queue_entry);
        xconn->smb2.send_queue_len++;
 
        status = smbd_smb2_flush_send_queue(xconn);
@@ -2762,7 +2762,7 @@ static NTSTATUS smbd_smb2_request_reply(struct smbd_smb2_request *req)
        req->queue_entry.mem_ctx = req;
        req->queue_entry.vector = req->out.vector;
        req->queue_entry.count = req->out.vector_count;
-       DLIST_ADD_END(xconn->smb2.send_queue, &req->queue_entry, NULL);
+       DLIST_ADD_END(xconn->smb2.send_queue, &req->queue_entry);
        xconn->smb2.send_queue_len++;
 
        status = smbd_smb2_flush_send_queue(xconn);
@@ -3104,7 +3104,7 @@ static NTSTATUS smbd_smb2_send_break(struct smbXsrv_connection *xconn,
        state->queue_entry.mem_ctx = state;
        state->queue_entry.vector = state->vector;
        state->queue_entry.count = ARRAY_SIZE(state->vector);
-       DLIST_ADD_END(xconn->smb2.send_queue, &state->queue_entry, NULL);
+       DLIST_ADD_END(xconn->smb2.send_queue, &state->queue_entry);
        xconn->smb2.send_queue_len++;
 
        status = smbd_smb2_flush_send_queue(xconn);
index 9f8520a2725a27a9ade54e5ddcedab6d3d195c1a..732388bdbdb971b4f055d97183f263147862cd21 100644 (file)
@@ -1470,7 +1470,7 @@ NTSTATUS smbXsrv_session_create_auth(struct smbXsrv_session *session,
        }
 
        talloc_set_destructor(a, smbXsrv_session_auth0_destructor);
-       DLIST_ADD_END(session->pending_auth, a, NULL);
+       DLIST_ADD_END(session->pending_auth, a);
 
        *_a = a;
        return NT_STATUS_OK;
index 75be763e1a96e85cf7b3698b5f195f165c48b1d3..ab6e118838dc96267a7d7560756cd21880ea860f 100644 (file)
@@ -394,7 +394,7 @@ static NTSTATUS get_ea_list_from_file_path(TALLOC_CTX *mem_ctx, connection_struc
                          "= %u\n", (unsigned int)*pea_total_len, dos_ea_name,
                          (unsigned int)listp->ea.value.length));
 
-               DLIST_ADD_END(ea_list_head, listp, struct ea_list *);
+               DLIST_ADD_END(ea_list_head, listp);
 
        }
 
@@ -749,7 +749,7 @@ static struct ea_list *read_ea_name_list(TALLOC_CTX *ctx, const char *pdata, siz
                }
 
                offset += (namelen + 1); /* Go past the name + terminating zero. */
-               DLIST_ADD_END(ea_list_head, eal, struct ea_list *);
+               DLIST_ADD_END(ea_list_head, eal);
                DEBUG(10,("read_ea_name_list: read ea name %s\n", eal->ea.name));
        }
 
@@ -773,7 +773,7 @@ static struct ea_list *read_ea_list(TALLOC_CTX *ctx, const char *pdata, size_t d
                        return NULL;
                }
 
-               DLIST_ADD_END(ea_list_head, eal, struct ea_list *);
+               DLIST_ADD_END(ea_list_head, eal);
                offset += bytes_used;
        }
 
index 57ee40c052b8914662136cbe4bfac7cb2f6beec2..8139daadfd73ac064cf94e505c49bab741ecee33 100644 (file)
@@ -246,7 +246,7 @@ static struct winbindd_domain *add_trusted_domain(const char *domain_name, const
        }
 
        /* Link to domain list */
-       DLIST_ADD_END(_domain_list, domain, struct winbindd_domain *);
+       DLIST_ADD_END(_domain_list, domain);
 
        wcache_tdc_add_domain( domain );
 
index 4627c3d03ff9b93164e736ccbc559c1ef160b350..eeb23367e7ec3bdc4f752d16bb519293dd625de5 100644 (file)
@@ -575,7 +575,7 @@ _PUBLIC_ NTSTATUS auth_context_create_methods(TALLOC_CTX *mem_ctx, const char *
                }
                method->auth_ctx        = ctx;
                method->depth           = i;
-               DLIST_ADD_END(ctx->methods, method, struct auth_method_context *);
+               DLIST_ADD_END(ctx->methods, method);
        }
 
        ctx->check_ntlm_password = auth_check_password_wrapper;
index 19aa75aafd3731bc54792ea82aa5e5167f7fd81c..095f01a1a9edd4eb7b2d06a8b5e8d944e7737054 100644 (file)
@@ -509,7 +509,7 @@ NTSTATUS dns_common_zones(struct ldb_context *samdb,
                        talloc_free(z);
                        continue;
                }
-               DLIST_ADD_END(new_list, z, NULL);
+               DLIST_ADD_END(new_list, z);
        }
 
        *zones_ret = new_list;
index 73221ebc730c2684e8b833d2d4ab0d9d6958f692..0e69ba20b733f75d631cda95fa51aa51ca2fa87c 100644 (file)
@@ -2856,7 +2856,7 @@ NTSTATUS dsdb_trust_routing_table_load(struct ldb_context *sam_ctx,
                        return status;
                }
 
-               DLIST_ADD_END(table->domains, d, NULL);
+               DLIST_ADD_END(table->domains, d);
 
                if (d->tdo->trust_attributes & LSA_TRUST_ATTRIBUTE_FOREST_TRANSITIVE) {
                        struct ForestTrustInfo *fti = NULL;
index ef64f82cc0dcb8640e5c8b76206dc7e14911eed8..3f16de8cb6d59b89c21f129fc577c8e1fc979e98 100644 (file)
@@ -468,7 +468,7 @@ static WERROR get_ncs_list(TALLOC_CTX *mem_ctx,
                nc_list_elem = talloc_zero(mem_ctx, struct ncList);
                W_ERROR_HAVE_NO_MEMORY(nc_list_elem);
                nc_list_elem->dn = nc_dn;
-               DLIST_ADD_END(*nc_list, nc_list_elem, struct ncList*);
+               DLIST_ADD_END(*nc_list, nc_list_elem);
        } else {
                /* ncs := getNCs() from ldb database.
                 * getNCs() must return an array containing
index 3f2c8519dc77a909732aa7bcbb42270685cfb180..ee2e4c868751eafbfc456eaa84ac901bb0179f81 100644 (file)
@@ -323,7 +323,7 @@ static WERROR dreplsrv_schedule_notify_sync(struct dreplsrv_service *service,
        op->replica_flags = replica_flags;
        op->schedule_time = time(NULL);
 
-       DLIST_ADD_END(service->ops.notifies, op, struct dreplsrv_notify_operation *);
+       DLIST_ADD_END(service->ops.notifies, op);
        talloc_steal(service, op);
        return WERR_OK;
 }
index e64c91d29a00bae6884cc6c09c4a70d52c7ec1c8..2da2673862652e440745fee9d0a969783b340e91 100644 (file)
@@ -127,7 +127,7 @@ WERROR dreplsrv_schedule_partition_pull_source(struct dreplsrv_service *s,
        op->cb_data     = cb_data;
        op->schedule_time = time(NULL);
 
-       DLIST_ADD_END(s->ops.pending, op, struct dreplsrv_out_operation *);
+       DLIST_ADD_END(s->ops.pending, op);
 
        return WERR_OK;
 }
index c822ba997a84ed6a646093a3cf2b422e7d47f313..65b4843a5f375037055e97210543f5b628122f5c 100644 (file)
@@ -345,7 +345,7 @@ WERROR dreplsrv_out_connection_attach(struct dreplsrv_service *s,
                        return ntstatus_to_werror(nt_status);
                }
 
-               DLIST_ADD_END(s->connections, conn, struct dreplsrv_out_connection *);
+               DLIST_ADD_END(s->connections, conn);
 
                DEBUG(4,("dreplsrv_out_connection_attach(%s): create\n", hostname));
        } else {
@@ -425,7 +425,7 @@ static WERROR dreplsrv_partition_add_source_dsa(struct dreplsrv_service *s,
                }
        }
 
-       DLIST_ADD_END(*listp, source, struct dreplsrv_partition_source_dsa *);
+       DLIST_ADD_END(*listp, source);
        return WERR_OK;
 }
 
index e670bb59a84451c012629c6f46fc062df39dc8d8..e9225f586c0492965058843a9072b69e8ce6ed3e 100644 (file)
@@ -138,7 +138,7 @@ WERROR dsdb_repl_resolve_working_schema(struct ldb_context *ldb,
                }
 
                schema_list_item->obj = cur;
-               DLIST_ADD_END(schema_list, schema_list_item, struct schema_list);
+               DLIST_ADD_END(schema_list, schema_list_item);
        }
 
        /* resolve objects until all are resolved and in local schema */
index cc0a9c25ebbd40453251e9a384cd10c91646f05d..2baf4af352bbad72a949732aa7cb5aabbce71082 100644 (file)
@@ -1049,9 +1049,9 @@ static int descriptor_extended_sec_desc_propagation(struct ldb_module *module,
        }
 
        if (parent_change != NULL) {
-               DLIST_ADD_END(parent_change->children, c, NULL);
+               DLIST_ADD_END(parent_change->children, c);
        } else {
-               DLIST_ADD_END(descriptor_private->changes, c, NULL);
+               DLIST_ADD_END(descriptor_private->changes, c);
        }
 
        return ldb_module_done(req, NULL, NULL, LDB_SUCCESS);
index 63ccbde896b03cfaa745f0df7ed8e98058eea97c..8063162a0b808286cffc21c71c138d916557a34c 100644 (file)
@@ -219,7 +219,7 @@ static int la_store_op(struct la_context *ac,
 
        /* Do deletes before adds */
        if (op == LA_OP_ADD) {
-               DLIST_ADD_END(ac->ops, os, struct la_op_store *);
+               DLIST_ADD_END(ac->ops, os);
        } else {
                /* By adding to the head of the list, we do deletes before
                 * adds when processing a replace */
index 2cf262afa539d337159ae649def2955df93c2897..52c8aadebde1c08449e25e4f0ba4ebd2c802f4d9 100644 (file)
@@ -126,7 +126,7 @@ static int add_modified(struct ldb_module *module, struct ldb_dn *dn, bool do_de
        item->do_delete = do_delete;
        talloc_free(res);
 
-       DLIST_ADD_END(data->changed_dns, item, struct dn_list *);
+       DLIST_ADD_END(data->changed_dns, item);
        return LDB_SUCCESS;
 }
 
index 42c3fa8fea0f936cbb6ba16a3a5aea84756f8eb7..780eb81d9981871817469d54b7b5f3e7d2155419 100644 (file)
@@ -122,7 +122,7 @@ static int add_modified(struct ldb_module *module, struct ldb_dn *dn, bool do_de
        item->do_delete = do_delete;
        talloc_free(res);
 
-       DLIST_ADD_END(data->changed_dns, item, struct dn_list *);
+       DLIST_ADD_END(data->changed_dns, item);
        return LDB_SUCCESS;
 }
 
index 013878d1f1970167b4031987b44efa5a0e111e63..d448cdf5d9edec0e6eb65b7f132d1f6bb112e0b6 100644 (file)
@@ -530,7 +530,7 @@ int dsdb_sort_objectClass_attr(struct ldb_context *ldb,
 
                /* Don't add top to list, we will do that later */
                if (ldb_attr_cmp("top", current->objectclass->lDAPDisplayName) != 0) {
-                       DLIST_ADD_END(unsorted, current, struct class_list *);
+                       DLIST_ADD_END(unsorted, current);
                }
        }
 
@@ -538,7 +538,7 @@ int dsdb_sort_objectClass_attr(struct ldb_context *ldb,
        /* Add top here, to prevent duplicates */
        current = talloc(tmp_mem_ctx, struct class_list);
        current->objectclass = dsdb_class_by_lDAPDisplayName(schema, "top");
-       DLIST_ADD_END(sorted, current, struct class_list *);
+       DLIST_ADD_END(sorted, current);
 
        /* For each object: find parent chain */
        for (current = unsorted; current != NULL; current = current->next) {
@@ -554,7 +554,7 @@ int dsdb_sort_objectClass_attr(struct ldb_context *ldb,
 
                new_parent = talloc(tmp_mem_ctx, struct class_list);
                new_parent->objectclass = dsdb_class_by_lDAPDisplayName(schema, current->objectclass->subClassOf);
-               DLIST_ADD_END(unsorted, new_parent, struct class_list *);
+               DLIST_ADD_END(unsorted, new_parent);
        }
 
        /* For each object: order by hierarchy */
@@ -582,7 +582,7 @@ int dsdb_sort_objectClass_attr(struct ldb_context *ldb,
 
                if (current_lowest != NULL) {
                        DLIST_REMOVE(unsorted,current_lowest);
-                       DLIST_ADD_END(sorted,current_lowest, struct class_list *);
+                       DLIST_ADD_END(sorted,current_lowest);
                }
        }
 
index fd2b57936c5d6bd872b286246506662bd3d17de1..7efb7ed4521c13a3d706c338f55b52194a5219b5 100644 (file)
@@ -255,7 +255,7 @@ struct ldapsrv_reply *ldapsrv_init_reply(struct ldapsrv_call *call, uint8_t type
 
 void ldapsrv_queue_reply(struct ldapsrv_call *call, struct ldapsrv_reply *reply)
 {
-       DLIST_ADD_END(call->replies, reply, struct ldapsrv_reply *);
+       DLIST_ADD_END(call->replies, reply);
 }
 
 static NTSTATUS ldapsrv_unwilling(struct ldapsrv_call *call, int error)
index c3bd728a79b4c847ed256c805b18cc21e444b572..c6976ee243d67ed6ce7b735ed8c5f7d6ede242f2 100644 (file)
@@ -357,7 +357,7 @@ static int http_add_header_internal(TALLOC_CTX *mem_ctx,
        h = talloc(mem_ctx, struct http_header);
        h->key = talloc_strdup(h, key);
        h->value = talloc_strdup(h, value);
-       DLIST_ADD_END(*headers, h, NULL);
+       DLIST_ADD_END(*headers, h);
        tail = DLIST_TAIL(*headers);
        if (tail != h) {
                DEBUG(0, ("%s: Error adding header\n", __func__));
index 9b0d00e01b75a7ec8780e55cb6d12fae472fd4f3..963c0aac3dc84d1f79ff2755b3056198efa2fba7 100644 (file)
@@ -135,7 +135,7 @@ static void add_interface(TALLOC_CTX *mem_ctx, const struct iface_struct *ifs, s
           this needs to be a ADD_END, as some tests (such as the
           spoolss notify test) depend on the interfaces ordering
        */
-       DLIST_ADD_END(*interfaces, iface, NULL);
+       DLIST_ADD_END(*interfaces, iface);
 }
 
 /**
index b36d6507ef01ed07a9cc760aee1cbdba0b9e0bf7..b05036940342e2dd4df28f27664fd07e09ecab49 100644 (file)
@@ -541,7 +541,7 @@ _PUBLIC_ NTSTATUS packet_send_callback(struct packet_context *pc, DATA_BLOB blob
        el = talloc(pc, struct send_element);
        NT_STATUS_HAVE_NO_MEMORY(el);
 
-       DLIST_ADD_END(pc->send_queue, el, struct send_element *);
+       DLIST_ADD_END(pc->send_queue, el);
        el->blob = blob;
        el->nsent = 0;
        el->send_callback = send_callback;
index cd6d3e4c745bf5069cf8cac8566cd23cb645ac77..b6e7dd12c7c9d9dfe7b7ae7afea0df547f35e260 100644 (file)
@@ -231,7 +231,7 @@ NTSTATUS nbt_dgram_send(struct nbt_dgram_socket *dgmsock,
                goto failed;
        }
 
-       DLIST_ADD_END(dgmsock->send_queue, req, struct nbt_dgram_request *);
+       DLIST_ADD_END(dgmsock->send_queue, req);
 
        TEVENT_FD_WRITEABLE(dgmsock->fde);
 
index b5930aade1fd1d2bbb39f22487e09b524e26d0a4..139030090be14051f818fee69fb51f948f55abfd 100644 (file)
@@ -75,7 +75,7 @@ bool resolve_context_add_method(struct resolve_context *ctx, resolve_name_send_f
        method->send_fn = send_fn;
        method->recv_fn = recv_fn;
        method->privdata = userdata;
-       DLIST_ADD_END(ctx->methods, method, struct resolve_method *);
+       DLIST_ADD_END(ctx->methods, method);
        return true;
 }
 
index 6ce0d352f1d68f1be55ba135d343b07eec234fe4..33c370694a1d5ce9b44e42012ea55463ee93cc4d 100644 (file)
@@ -1245,7 +1245,7 @@ struct tevent_req *dcerpc_bind_send(TALLOC_CTX *mem_ctx,
        subreq->async.callback = dcerpc_bind_fail_handler;
        subreq->p = p;
        subreq->recv_handler = dcerpc_bind_recv_handler;
-       DLIST_ADD_END(p->conn->pending, subreq, struct rpc_request *);
+       DLIST_ADD_END(p->conn->pending, subreq);
        talloc_set_destructor(subreq, dcerpc_req_dequeue);
 
        status = dcerpc_send_request(p->conn, &blob, true);
@@ -1603,7 +1603,7 @@ static struct rpc_request *dcerpc_request_send(TALLOC_CTX *mem_ctx,
        req->request_data.length = stub_data->length;
        req->request_data.data = stub_data->data;
 
-       DLIST_ADD_END(p->conn->request_queue, req, struct rpc_request *);
+       DLIST_ADD_END(p->conn->request_queue, req);
        talloc_set_destructor(req, dcerpc_req_dequeue);
 
        dcerpc_schedule_io_trigger(p->conn);
@@ -2141,7 +2141,7 @@ struct tevent_req *dcerpc_alter_context_send(TALLOC_CTX *mem_ctx,
        subreq->async.callback = dcerpc_alter_context_fail_handler;
        subreq->p = p;
        subreq->recv_handler = dcerpc_alter_context_recv_handler;
-       DLIST_ADD_END(p->conn->pending, subreq, struct rpc_request *);
+       DLIST_ADD_END(p->conn->pending, subreq);
        talloc_set_destructor(subreq, dcerpc_req_dequeue);
 
        status = dcerpc_send_request(p->conn, &blob, true);
index 07f4e20e725fdba5c4642eabba9d624c61033e49..08caa11f8a82ca2dd4a4db66cc189205e7b8ff09 100644 (file)
@@ -199,7 +199,7 @@ static void nbtd_register_name_iface(struct nbtd_interface *iface,
        iname->registration_time = timeval_zero();
        iname->wins_server       = NULL;
 
-       DLIST_ADD_END(iface->names, iname, struct nbtd_iface_name *);
+       DLIST_ADD_END(iface->names, iname);
 
        if (nb_flags & NBT_NM_PERMANENT) {
                /* permanent names are not announced and are immediately active */
index a60d5bd27feeae72e4333e1a0f3a08b321b66554..98789c0496532905435db5a4b1f61a654eeaed67 100644 (file)
@@ -422,7 +422,7 @@ static void wins_register_wack(struct nbt_name_socket *nbtsock,
        s->io.in.addresses      = winsdb_addr_string_list(s, rec->addresses);
        if (s->io.in.addresses == NULL) goto failed;
 
-       DLIST_ADD_END(iface->wack_queue, s, struct nbtd_wins_wack_state *);
+       DLIST_ADD_END(iface->wack_queue, s);
 
        talloc_set_destructor(s, nbtd_wins_wack_state_destructor);
 
index 8058181f89df42236731cf787224864bb3e52f9e..d037a0ea377bb96df3900a7a6db65416bd906524 100644 (file)
@@ -190,7 +190,7 @@ NTSTATUS ntvfs_init_connection(TALLOC_CTX *mem_ctx, struct share_config *scfg, e
                        return NT_STATUS_INTERNAL_ERROR;
                }
                ntvfs->depth = i;
-               DLIST_ADD_END(ctx->modules, ntvfs, struct ntvfs_module_context *);
+               DLIST_ADD_END(ctx->modules, ntvfs);
        }
 
        if (!ctx->modules) {
index 316353f38f8c4ecad9615449ce3ab35f8bb27f4c..91a151bdb9f4147beb5ca83b6d38d19f16afda73 100644 (file)
@@ -278,7 +278,7 @@ NTSTATUS pvfs_notify(struct ntvfs_module_context *ntvfs,
        NT_STATUS_HAVE_NO_MEMORY(pending->req); 
        pending->info = info;
 
-       DLIST_ADD_END(f->notify_buffer->pending, pending, struct notify_pending *);
+       DLIST_ADD_END(f->notify_buffer->pending, pending);
 
        /* if the buffer is empty then start waiting */
        if (f->notify_buffer->num_changes == 0 && 
index 007b68083bf017da041ae0513306b6bfc83c6a3a..59c289cf79785d6821af1f22f75cf3e450bb5b4a 100644 (file)
@@ -67,13 +67,13 @@ static void dcesrv_call_set_list(struct dcesrv_call_state *call,
        case DCESRV_LIST_NONE:
                break;
        case DCESRV_LIST_CALL_LIST:
-               DLIST_ADD_END(call->conn->call_list, call, struct dcesrv_call_state *);
+               DLIST_ADD_END(call->conn->call_list, call);
                break;
        case DCESRV_LIST_FRAGMENTED_CALL_LIST:
-               DLIST_ADD_END(call->conn->incoming_fragmented_call_list, call, struct dcesrv_call_state *);
+               DLIST_ADD_END(call->conn->incoming_fragmented_call_list, call);
                break;
        case DCESRV_LIST_PENDING_CALL_LIST:
-               DLIST_ADD_END(call->conn->pending_call_list, call, struct dcesrv_call_state *);
+               DLIST_ADD_END(call->conn->pending_call_list, call);
                break;
        }
 }
@@ -130,7 +130,7 @@ NTSTATUS dcesrv_fault(struct dcesrv_call_state *call, uint32_t fault_code)
 
        dcerpc_set_frag_length(&rep->blob, rep->blob.length);
 
-       DLIST_ADD_END(call->replies, rep, struct data_blob_list_item *);
+       DLIST_ADD_END(call->replies, rep);
        dcesrv_call_set_list(call, DCESRV_LIST_CALL_LIST);
 
        if (call->conn->call_list && call->conn->call_list->replies) {
@@ -238,7 +238,7 @@ _PUBLIC_ NTSTATUS dcesrv_reply(struct dcesrv_call_state *call)
 
                dcerpc_set_frag_length(&rep->blob, rep->blob.length);
 
-               DLIST_ADD_END(call->replies, rep, struct data_blob_list_item *);
+               DLIST_ADD_END(call->replies, rep);
 
                stub.data += length;
                stub.length -= length;
index ad1e82d4f9b430e2c474c3cab7087387d4516a30..df0ffc882c29007b052da09161506baaeaeaa6ec 100644 (file)
@@ -439,13 +439,13 @@ static void dcesrv_call_set_list(struct dcesrv_call_state *call,
        case DCESRV_LIST_NONE:
                break;
        case DCESRV_LIST_CALL_LIST:
-               DLIST_ADD_END(call->conn->call_list, call, struct dcesrv_call_state *);
+               DLIST_ADD_END(call->conn->call_list, call);
                break;
        case DCESRV_LIST_FRAGMENTED_CALL_LIST:
-               DLIST_ADD_END(call->conn->incoming_fragmented_call_list, call, struct dcesrv_call_state *);
+               DLIST_ADD_END(call->conn->incoming_fragmented_call_list, call);
                break;
        case DCESRV_LIST_PENDING_CALL_LIST:
-               DLIST_ADD_END(call->conn->pending_call_list, call, struct dcesrv_call_state *);
+               DLIST_ADD_END(call->conn->pending_call_list, call);
                break;
        }
 }
@@ -486,7 +486,7 @@ static NTSTATUS dcesrv_bind_nak(struct dcesrv_call_state *call, uint32_t reason)
 
        dcerpc_set_frag_length(&rep->blob, rep->blob.length);
 
-       DLIST_ADD_END(call->replies, rep, struct data_blob_list_item *);
+       DLIST_ADD_END(call->replies, rep);
        dcesrv_call_set_list(call, DCESRV_LIST_CALL_LIST);
 
        if (call->conn->call_list && call->conn->call_list->replies) {
@@ -695,7 +695,7 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
 
        dcerpc_set_frag_length(&rep->blob, rep->blob.length);
 
-       DLIST_ADD_END(call->replies, rep, struct data_blob_list_item *);
+       DLIST_ADD_END(call->replies, rep);
        dcesrv_call_set_list(call, DCESRV_LIST_CALL_LIST);
 
        if (call->conn->call_list && call->conn->call_list->replies) {
@@ -860,7 +860,7 @@ static NTSTATUS dcesrv_alter_resp(struct dcesrv_call_state *call,
 
        dcerpc_set_frag_length(&rep->blob, rep->blob.length);
 
-       DLIST_ADD_END(call->replies, rep, struct data_blob_list_item *);
+       DLIST_ADD_END(call->replies, rep);
        dcesrv_call_set_list(call, DCESRV_LIST_CALL_LIST);
 
        if (call->conn->call_list && call->conn->call_list->replies) {
@@ -1393,7 +1393,7 @@ static void dcesrv_terminate_connection(struct dcesrv_connection *dce_conn, cons
        if (dce_conn->terminate == NULL) {
                dce_conn->terminate = "dcesrv: defered terminating connection - no memory";
        }
-       DLIST_ADD_END(dce_ctx->broken_connections, dce_conn, NULL);
+       DLIST_ADD_END(dce_ctx->broken_connections, dce_conn);
 }
 
 static void dcesrv_cleanup_broken_connections(struct dcesrv_context *dce_ctx)
index 3df7294737163e0bc273f290230aaa4f1e598c5a..a4b82e5b083e72a9db38830e652d315eff26af8f 100644 (file)
@@ -62,14 +62,14 @@ static void dnsserver_reload_zones(struct dnsserver_state *dsstate)
                                if (z->zoneinfo == NULL) {
                                        continue;
                                }
-                               DLIST_ADD_END(new_list, z, NULL);
+                               DLIST_ADD_END(new_list, z);
                                p->zones_count++;
                                dsstate->zones_count++;
                        } else {
                                /* Existing zone */
                                talloc_free(z);
                                DLIST_REMOVE(old_list, zmatch);
-                               DLIST_ADD_END(new_list, zmatch, NULL);
+                               DLIST_ADD_END(new_list, zmatch);
                        }
                        z = znext;
                }
@@ -146,7 +146,7 @@ static struct dnsserver_state *dnsserver_connect(struct dcesrv_call_state *dce_c
                                if (z->zoneinfo == NULL) {
                                        goto failed;
                                }
-                               DLIST_ADD_END(dsstate->zones, z, NULL);
+                               DLIST_ADD_END(dsstate->zones, z);
                                p->zones_count++;
                                dsstate->zones_count++;
                        } else {
index e567f5a4f805827f8254216a7b36cac41720b4f2..0a76030a017158e2555c058a47acfb843af17f51 100644 (file)
@@ -53,7 +53,7 @@ struct dnsserver_partition *dnsserver_db_enumerate_partitions(TALLOC_CTX *mem_ct
        p->dwDpFlags = DNS_DP_AUTOCREATED | DNS_DP_DOMAIN_DEFAULT | DNS_DP_ENLISTED;
        p->is_forest = false;
 
-       DLIST_ADD_END(partitions, p, NULL);
+       DLIST_ADD_END(partitions, p);
 
        /* Forest Partition */
        p = talloc_zero(mem_ctx, struct dnsserver_partition);
@@ -70,7 +70,7 @@ struct dnsserver_partition *dnsserver_db_enumerate_partitions(TALLOC_CTX *mem_ct
        p->dwDpFlags = DNS_DP_AUTOCREATED | DNS_DP_FOREST_DEFAULT | DNS_DP_ENLISTED;
        p->is_forest = true;
 
-       DLIST_ADD_END(partitions, p, NULL);
+       DLIST_ADD_END(partitions, p);
 
        return partitions;
 
@@ -136,7 +136,7 @@ struct dnsserver_zone *dnsserver_db_enumerate_zones(TALLOC_CTX *mem_ctx,
                }
                z->zone_dn = talloc_steal(z, res->msgs[i]->dn);
 
-               DLIST_ADD_END(zones, z, NULL);
+               DLIST_ADD_END(zones, z);
                DEBUG(2, ("dnsserver: Found DNS zone %s\n", z->name));
        }
 
index 9187310050ca74f21ec5cc63cae930ce71acc655..3e5dc4de173b43b0966825c26a292f17b581f584 100644 (file)
@@ -618,7 +618,7 @@ NTSTATUS smb2srv_queue_pending(struct smb2srv_request *req)
                return NT_STATUS_INSUFFICIENT_RESOURCES;
        }
 
-       DLIST_ADD_END(req->smb_conn->requests2.list, req, struct smb2srv_request *);
+       DLIST_ADD_END(req->smb_conn->requests2.list, req);
        req->pending_id = id;
 
        talloc_set_destructor(req, smb2srv_request_deny_destructor);
index ab555445a3371276ae5834c66a87609c1fe77450..40af4a64bb36fd95e4ec6951faa1d435376d1d84 100644 (file)
@@ -475,7 +475,7 @@ struct loadparm_context;
 #define SMBSRV_CALL_NTVFS_BACKEND(cmd) do { \
        req->ntvfs->async_states->status = cmd; \
        if (req->ntvfs->async_states->state & NTVFS_ASYNC_STATE_ASYNC) { \
-               DLIST_ADD_END(req->smb_conn->requests, req, struct smbsrv_request *); \
+               DLIST_ADD_END(req->smb_conn->requests, req); \
        } else { \
                req->ntvfs->async_states->send_fn(req->ntvfs); \
        } \
index 9cdbbc28f3a1066afa9bc94d5f0ea9287c1fada5..81ad3c5aabca45d196f7fccdfff7f7715c572dc1 100644 (file)
@@ -44,7 +44,7 @@ NTSTATUS register_server_service(const char *name,
        NT_STATUS_HAVE_NO_MEMORY(srv);
        srv->service_name = name;
        srv->task_init = task_init;
-       DLIST_ADD_END(registered_servers, srv, struct registered_server *);
+       DLIST_ADD_END(registered_servers, srv);
        return NT_STATUS_OK;
 }
 
index 3a08543b734b97030af438301999844f0c76d967..a806e64d881b46a4bb73a221443fb046f56f6f35 100644 (file)
@@ -298,12 +298,12 @@ static bool test_fsrvp_state_single(struct torture_context *tctx)
        ok = test_fsrvp_state_smap(tctx, sc, "base_share", "sc_share", &smap);
        torture_assert(tctx, ok, "failed to create smap");
 
-       DLIST_ADD_END(fss_gs.sc_sets, sc_set, struct fss_sc_set *);
+       DLIST_ADD_END(fss_gs.sc_sets, sc_set);
        fss_gs.sc_sets_count++;
-       DLIST_ADD_END(sc_set->scs, sc, struct fss_sc *);
+       DLIST_ADD_END(sc_set->scs, sc);
        sc_set->scs_count++;
        sc->sc_set = sc_set;
-       DLIST_ADD_END(sc->smaps, smap, struct fss_sc_smap *);
+       DLIST_ADD_END(sc->smaps, smap);
        sc->smaps_count++;
 
        status = fss_state_store(fss_gs.mem_ctx, fss_gs.sc_sets,
@@ -392,23 +392,23 @@ static bool test_fsrvp_state_multi(struct torture_context *tctx)
                                   &smap_abb);
        torture_assert(tctx, ok, "failed to create smap");
 
-       DLIST_ADD_END(fss_gs.sc_sets, sc_set_a, struct fss_sc_set *);
+       DLIST_ADD_END(fss_gs.sc_sets, sc_set_a);
        fss_gs.sc_sets_count++;
-       DLIST_ADD_END(fss_gs.sc_sets, sc_set_b, struct fss_sc_set *);
+       DLIST_ADD_END(fss_gs.sc_sets, sc_set_b);
        fss_gs.sc_sets_count++;
 
-       DLIST_ADD_END(sc_set_a->scs, sc_aa, struct fss_sc *);
+       DLIST_ADD_END(sc_set_a->scs, sc_aa);
        sc_set_a->scs_count++;
        sc_aa->sc_set = sc_set_a;
-       DLIST_ADD_END(sc_set_a->scs, sc_ab, struct fss_sc *);
+       DLIST_ADD_END(sc_set_a->scs, sc_ab);
        sc_set_a->scs_count++;
        sc_ab->sc_set = sc_set_a;
 
-       DLIST_ADD_END(sc_aa->smaps, smap_aaa, struct fss_sc_smap *);
+       DLIST_ADD_END(sc_aa->smaps, smap_aaa);
        sc_aa->smaps_count++;
-       DLIST_ADD_END(sc_ab->smaps, smap_aba, struct fss_sc_smap *);
+       DLIST_ADD_END(sc_ab->smaps, smap_aba);
        sc_ab->smaps_count++;
-       DLIST_ADD_END(sc_ab->smaps, smap_abb, struct fss_sc_smap *);
+       DLIST_ADD_END(sc_ab->smaps, smap_abb);
        sc_ab->smaps_count++;
 
        status = fss_state_store(fss_gs.mem_ctx, fss_gs.sc_sets,
index c9b369e86182e797111ed1651526994f16d22968..1de988e7a068398399fd1566c9401ff851e2d944 100644 (file)
@@ -521,7 +521,7 @@ static bool nb_do_createx(struct ftable *f,
                f = talloc (NULL, struct ftable);
                f->locks = NULL;
                nb_set_createx_params(f, fname, create_options, create_disposition, handle);
-               DLIST_ADD_END(ftable, f, struct ftable *);
+               DLIST_ADD_END(ftable, f);
        }
 
        f->handle = handle;
@@ -653,7 +653,7 @@ static bool nb_do_lockx(bool relock, int handle, off_t offset, int size, NTSTATU
                linfo = talloc (f, struct lock_info);
                linfo->offset = offset;
                linfo->size = size;
-               DLIST_ADD_END(f->locks, linfo, struct lock_info *);
+               DLIST_ADD_END(f->locks, linfo);
        }
 
        return true;
index d0ae9cd635e4173aa966c555884abe40b1b081a7..8c847b5ac50989801263b2aaea9c11de097d8851 100644 (file)
@@ -169,8 +169,7 @@ static bool nbt_test_wins_name(struct torture_context *tctx, const char *address
                                 * and not handle it as new request
                                 */
                                req->state = NBT_REQUEST_SEND;
-                               DLIST_ADD_END(nbtsock->send_queue, req,
-                                             struct nbt_name_request *);
+                               DLIST_ADD_END(nbtsock->send_queue, req);
                                TEVENT_FD_WRITEABLE(nbtsock->fde);
                                break;
                        }
index 4147c7dccfeb971e2f0d0adbe026db9cd62ae137..dac550e5accb2c3c89a193b5197621312582497d 100644 (file)
@@ -130,7 +130,7 @@ _PUBLIC_ struct torture_test *_torture_suite_add_ndr_pullpush_test(
        test->fn = check_fn;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
@@ -226,7 +226,7 @@ _PUBLIC_ struct torture_test *_torture_suite_add_ndr_pull_inout_test(
        test->fn = check_fn;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
index 930a599bc004a61314788cd0411e829b26c6bd6c..945e653af75731a30f437d4f3a0983e723cc9f01 100644 (file)
@@ -140,7 +140,7 @@ static NTSTATUS spoolss__op_dispatch(struct dcesrv_call_state *dce_call, TALLOC_
        rp->opnum = opnum;
        rp->r = talloc_reference(rp, r);
 
-       DLIST_ADD_END(received_packets, rp, struct received_packet *);
+       DLIST_ADD_END(received_packets, rp);
 
        switch (opnum) {
        case 58: {
index 0124cf1252b3ebb9d9635dca2124177151f6c8e5..90029c7ea43009fae0707136e2e57d4073bb689c 100644 (file)
@@ -74,7 +74,7 @@ struct torture_test *torture_suite_add_1smb2_test(struct torture_suite *suite,
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
@@ -138,7 +138,7 @@ struct torture_test *torture_suite_add_2smb2_test(struct torture_suite *suite,
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
index 0520f275a4cd88a8690748a7876a80c61d8d2538..32de7536d67200f9e64a785cb285b42f4b272b50 100644 (file)
@@ -783,7 +783,7 @@ _PUBLIC_ struct torture_test *torture_suite_add_smb_multi_test(
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 
@@ -834,7 +834,7 @@ _PUBLIC_ struct torture_test *torture_suite_add_2smb_test(
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 
@@ -878,7 +878,7 @@ _PUBLIC_ struct torture_test *torture_suite_add_1smb_test(
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
index 9b82387874825e4f1d50a6af855786c9a8cb461a..f3ce44743d6749f92b961b5434e9bb22c8fdf888 100644 (file)
@@ -94,7 +94,7 @@ struct torture_test *torture_suite_add_2ns_smb2_test(struct torture_suite *suite
        test->fn = run;
        test->dangerous = false;
 
-       DLIST_ADD_END(tcase->tests, test, struct torture_test *);
+       DLIST_ADD_END(tcase->tests, test);
 
        return test;
 }
index e28afc6fe5af996c8c7bf3c64023dacbe47477df..75a927aaac9b375c986724b2d2f1337af68b5c1e 100644 (file)
@@ -192,7 +192,7 @@ NTSTATUS wreplsrv_load_partners(struct wreplsrv_service *service)
                        partner->address = address;
                        talloc_steal(partner, partner->address);
 
-                       DLIST_ADD_END(service->partners, partner, struct wreplsrv_partner *);
+                       DLIST_ADD_END(service->partners, partner);
                }
 
                partner->name                   = ldb_msg_find_attr_as_string(res->msgs[i], "name", partner->address);
@@ -328,7 +328,7 @@ NTSTATUS wreplsrv_add_table(struct wreplsrv_service *service,
 
                cur->partner            = wreplsrv_find_partner(service, wins_owner);
 
-               DLIST_ADD_END(table, cur, struct wreplsrv_owner *);
+               DLIST_ADD_END(table, cur);
                *_table = table;
        }