metze/old/v3-2-winbind-ndr.git
11 years agoRemoved unused variable
jerry [Thu, 27 Sep 2007 23:33:35 +0000 (23:33 +0000)]
Removed unused variable

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25393 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix bug #4978 : Store DOS Attributes fails when copying folders.
jra [Thu, 27 Sep 2007 23:28:35 +0000 (23:28 +0000)]
Fix bug #4978 : Store DOS Attributes fails when copying folders.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25391 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix crash bug using DFS info struct uninitialized.
jra [Thu, 27 Sep 2007 22:55:11 +0000 (22:55 +0000)]
Fix crash bug using DFS info struct uninitialized.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25389 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove the groupdb:mapping parameter as discussed in the following thread:
jerry [Thu, 27 Sep 2007 20:12:40 +0000 (20:12 +0000)]
Remove the groupdb:mapping parameter as discussed in the following thread:
http://lists.samba.org/archive/samba-technical/2007-June/053747.html

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25380 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd a vim configuration example to highlight overly long lines.
obnox [Thu, 27 Sep 2007 19:20:37 +0000 (19:20 +0000)]
Add a vim configuration example to highlight overly long lines.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25378 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAllow to delete registry keys recursively without deleting the final key.
gd [Thu, 27 Sep 2007 01:26:19 +0000 (01:26 +0000)]
Allow to delete registry keys recursively without deleting the final key.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25370 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd "NT Authority\System" with Full Access to the default registry security
gd [Wed, 26 Sep 2007 21:46:43 +0000 (21:46 +0000)]
Add "NT Authority\System" with Full Access to the default registry security
descriptor.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25362 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoIP address parsing did not allow for fully expanded ipv6 addresses
sfrench [Wed, 26 Sep 2007 18:36:38 +0000 (18:36 +0000)]
IP address parsing did not allow for fully expanded ipv6 addresses
(which can be 12 bytes longer than we were allowing for).

Thanks to Dr. David Holder

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25355 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoWhen using ldap sasl wrapping with gssapi it's important to receive warnings
gd [Wed, 26 Sep 2007 01:02:52 +0000 (01:02 +0000)]
When using ldap sasl wrapping with gssapi it's important to receive warnings
for clock-skew errors.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25328 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoNormalize the path we return for 'msdfs proxy'
vlendec [Tue, 25 Sep 2007 23:26:05 +0000 (23:26 +0000)]
Normalize the path we return for 'msdfs proxy'

We now accept both \\server\tmp and \server\tmp. There are other places
where this might be necessary, but at least the functionality is a bit
easier now.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25327 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFree the context from the talloc_stackframe.
gd [Tue, 25 Sep 2007 22:43:42 +0000 (22:43 +0000)]
Free the context from the talloc_stackframe.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25326 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRename some defines.
gd [Tue, 25 Sep 2007 21:41:57 +0000 (21:41 +0000)]
Rename some defines.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25325 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix "msdfs proxy"
vlendec [Tue, 25 Sep 2007 21:41:39 +0000 (21:41 +0000)]
Fix "msdfs proxy"

Jeremy, please check!

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25324 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix the build
vlendec [Tue, 25 Sep 2007 21:32:49 +0000 (21:32 +0000)]
Fix the build

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25323 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoActivate raw-samba3rootdirfid
vlendec [Tue, 25 Sep 2007 16:42:53 +0000 (16:42 +0000)]
Activate raw-samba3rootdirfid

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25317 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd HKEY_CURRENT_USER to reg_hive_key().
gd [Tue, 25 Sep 2007 04:54:20 +0000 (04:54 +0000)]
Add HKEY_CURRENT_USER to reg_hive_key().

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25314 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agodd HKEY_CURRENT_USER to rpccli_winreg_Connect().
gd [Tue, 25 Sep 2007 04:52:15 +0000 (04:52 +0000)]
dd HKEY_CURRENT_USER to rpccli_winreg_Connect().

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25313 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoPatch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIX
vlendec [Mon, 24 Sep 2007 21:43:54 +0000 (21:43 +0000)]
Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIX
quotas.

Heinrich, I trust you on that, I don't even have compiled this :-)

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25311 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoVolker's fix for bug #4984 - samba4 torture test
jra [Mon, 24 Sep 2007 19:11:42 +0000 (19:11 +0000)]
Volker's fix for bug #4984 - samba4 torture test
to follow. Ensure we don't prepend "./" as a root
directory - this is an invalid pathname for unix_convert().
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25309 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoTidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
obnox [Fri, 21 Sep 2007 14:37:35 +0000 (14:37 +0000)]
Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
the maxeln parameter instead of sizeof(target_area) - 1 (or even
sizeof(fstring) - 1 in some places.

I hope these were really all there were.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25294 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoEliminate a handful of red bars and overly long lines I just
obnox [Fri, 21 Sep 2007 12:24:43 +0000 (12:24 +0000)]
Eliminate a handful of red bars and overly long lines I just
came across.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25287 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix one more caller of unistr2_to_ascii() that passed
obnox [Fri, 21 Sep 2007 11:58:25 +0000 (11:58 +0000)]
Fix one more caller of unistr2_to_ascii() that passed
in -1 for maxlen.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25286 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix some more callers of unistr2_to_ascii to use the size of
obnox [Fri, 21 Sep 2007 11:53:14 +0000 (11:53 +0000)]
Fix some more callers of unistr2_to_ascii to use the size of
destination instead of source as maxlen.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25285 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix a caller of unistr2_to_ascii():
obnox [Fri, 21 Sep 2007 10:46:09 +0000 (10:46 +0000)]
Fix a caller of unistr2_to_ascii():
The maxlen parameter should be set to the size of the
destination, not to the size of the soruce.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25281 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoBelt-and-braces approach to Volker's fix for RPC-SAMBA3-GETUSERNAME.
jra [Fri, 21 Sep 2007 10:32:57 +0000 (10:32 +0000)]
Belt-and-braces approach to Volker's fix for RPC-SAMBA3-GETUSERNAME.
If we promise dest is null terminated, ensure we do it even on
fast path exits.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25277 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agow2k3 (as PDC emulator) returns WERR_NO_SUCH_DOMAIN to netlogon_getanydcname()
metze [Fri, 21 Sep 2007 10:25:33 +0000 (10:25 +0000)]
w2k3 (as PDC emulator) returns WERR_NO_SUCH_DOMAIN to netlogon_getanydcname()
when called for it's own domain. So we should use netlogon_getdcname() which
returns WERR_OK:-)

gd: feel free to usage rpccli_netlogon_dsr_getdcname(), but please make sure
    the new WINBIND-STRUCT-GETDCNAME test is still passing.

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25275 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAttempt to fix RPC-SAMBA3-GETUSERNAME
vlendec [Fri, 21 Sep 2007 10:23:35 +0000 (10:23 +0000)]
Attempt to fix RPC-SAMBA3-GETUSERNAME

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25274 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agounistrX_to_ascii calls pull_ucs2 - ensure it's never
jra [Fri, 21 Sep 2007 09:58:36 +0000 (09:58 +0000)]
unistrX_to_ascii calls pull_ucs2 - ensure it's never
called with -1 (these calls were wrong anyway, target
was an fstring, not a pstring). Found by  Michael Adam <ma@sernet.de>,
now to check all other uses.
Michael - this version uses sizeof(target) not sizeof(fstring).
This way is more future proof.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25273 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix a bunch of callers of pull_ucs2 that passed -1 for dest_len.
obnox [Fri, 21 Sep 2007 09:52:28 +0000 (09:52 +0000)]
Fix a bunch of callers of pull_ucs2 that passed -1 for dest_len.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25272 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agofor internal domains we should not ask a remote DC.
metze [Fri, 21 Sep 2007 09:35:53 +0000 (09:35 +0000)]
for internal domains we should not ask a remote DC.

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25270 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoadd trusted domains always to the end of the list.
metze [Thu, 20 Sep 2007 18:37:34 +0000 (18:37 +0000)]
add trusted domains always to the end of the list.

Now BUILTIN is always the first domain followed
by the domain of our own SAM DB and the primary
domain (in member server mode).

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25260 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix a panic message and remove superfluous return after the call to smb_panic().
obnox [Thu, 20 Sep 2007 12:42:15 +0000 (12:42 +0000)]
Fix a panic message and remove superfluous return after the call to smb_panic().

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25258 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoWhen dumping eventlist, display full timestring.
gd [Thu, 20 Sep 2007 11:02:27 +0000 (11:02 +0000)]
When dumping eventlist, display full timestring.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25257 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd my C - Michael
obnox [Thu, 20 Sep 2007 09:15:26 +0000 (09:15 +0000)]
Add my C - Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25254 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agomove macro defines to the end of replace.h
metze [Thu, 20 Sep 2007 09:12:18 +0000 (09:12 +0000)]
move macro defines to the end of replace.h
and move the include location sys/param.h
before we redefine missing macros

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25252 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAccording to the build-farm all this defines are not needed
metze [Thu, 20 Sep 2007 06:52:30 +0000 (06:52 +0000)]
According to the build-farm all this defines are not needed
for HPUX large file support.

But it would be nice if someone could verify that.

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25248 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRename the rpccli_lsa_lookup_sids_all() function to rpccli_lsa_lookup_sids()
obnox [Wed, 19 Sep 2007 22:11:09 +0000 (22:11 +0000)]
Rename the rpccli_lsa_lookup_sids_all() function to rpccli_lsa_lookup_sids()
and remove the old rpccli_lsa_lookup_sids() function. The old function would
fail due to server limits when requesting to resolve too many sids at once
(20480 for W2k3). The new version passes the list of sids in hunks to the
server. It has up to now been used (and tested) in the winbindd_ads
lookup_groupmem() function, and I think the time has come to replace the actual
function with this correct version.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25247 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agorerun 'make idl'
metze [Wed, 19 Sep 2007 20:03:43 +0000 (20:03 +0000)]
rerun 'make idl'

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25245 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agosee what the build-farm says when we only use large file support
metze [Wed, 19 Sep 2007 19:45:51 +0000 (19:45 +0000)]
see what the build-farm says when we only use large file support
detection from libreplace...

It would be good if someone could test that on HPUX...

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25244 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoremove sequence_number out of WINBINDD_DOMAIN_INFO call
metze [Wed, 19 Sep 2007 19:05:54 +0000 (19:05 +0000)]
remove sequence_number out of WINBINDD_DOMAIN_INFO call
as this is always answered by the winbindd parent and will
most times return old sequence number values.

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25241 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agofix cut-n-paste bug in code with LIBUNWIND support
metze [Wed, 19 Sep 2007 19:01:20 +0000 (19:01 +0000)]
fix cut-n-paste bug in code with LIBUNWIND support

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25239 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoMake the error returns from the string functions
jra [Wed, 19 Sep 2007 17:52:06 +0000 (17:52 +0000)]
Make the error returns from the string functions
always consistent. Return -1 on error, and ensure
we check for this. In cases where the dest is already
specified and we've been asked to terminate with a
null, ensure we always do so even on error.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25238 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agomake it possible to alter WINBINDD_SOCKET_DIR via
metze [Wed, 19 Sep 2007 17:19:57 +0000 (17:19 +0000)]
make it possible to alter WINBINDD_SOCKET_DIR via
"winbindd:socket dir=/path/to/dir" for usage in make test

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25236 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agosync lib/replace with SAMBA_4_0
metze [Wed, 19 Sep 2007 14:57:20 +0000 (14:57 +0000)]
sync lib/replace with SAMBA_4_0

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25232 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agosync lib/talloc with SAMBA_4_0
metze [Wed, 19 Sep 2007 14:44:16 +0000 (14:44 +0000)]
sync lib/talloc with SAMBA_4_0

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25230 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoPatch from "Steven Danneman" <steven.danneman@isilon.com>:
metze [Wed, 19 Sep 2007 14:33:32 +0000 (14:33 +0000)]
Patch from "Steven Danneman" <steven.danneman@isilon.com>:

-
We ran across a bug joining our Samba server to a Win2K domain with LDAP
signing turned on.  Upon investigation I discovered that there is a bug
in Win2K server which returns a duplicated responseToken in the LDAP
bindResponse packet.  This blob is placed in the optional mechListMIC
field which is unsupported in both Win2K and Win2K3.  You can see RFC
2478 for the proper packet construction.  I've worked with metze on this
to confirm all these finding.

This patch properly parses then discards the mechListMIC field if it
exists in the packet, so we don't produce a malformed packet error,
causing LDAP signed joins to fail.  Also attached is a sniff of the
domain join, exposing Win2Ks bad behavior (packet 21).
-

(I've just changed the scope of the DATA_BLOB mechList)

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25227 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoGet rid of more red bars...
obnox [Wed, 19 Sep 2007 12:45:35 +0000 (12:45 +0000)]
Get rid of more red bars...

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25226 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd a debug message.
obnox [Wed, 19 Sep 2007 12:05:47 +0000 (12:05 +0000)]
Add a debug message.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25225 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix a potential segfault in lsa_lookupsids client code due to
obnox [Wed, 19 Sep 2007 12:03:02 +0000 (12:03 +0000)]
Fix a potential segfault in lsa_lookupsids client code due to
uninitialized data.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25224 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix behaviour of rpccli_lsa_lookupsids_all() when
obnox [Wed, 19 Sep 2007 11:01:44 +0000 (11:01 +0000)]
Fix behaviour of rpccli_lsa_lookupsids_all() when
rpccli_lsa_lookupsids_noalloc() returns an error for one hunk
of SIDs: free all allocated arrays and return the error code
returned by the hunk lookup.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25223 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix last assumptions that (size_t)-1 can be used
jra [Wed, 19 Sep 2007 09:40:40 +0000 (09:40 +0000)]
Fix last assumptions that (size_t)-1 can be used
as a special dest_len of sizeof(pstring).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25222 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFight those red bars...
obnox [Mon, 17 Sep 2007 21:04:10 +0000 (21:04 +0000)]
Fight those red bars...

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25201 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix a debug message.
obnox [Mon, 17 Sep 2007 20:01:47 +0000 (20:01 +0000)]
Fix a debug message.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25200 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove pstring from strdup_upper - make it the
jra [Mon, 17 Sep 2007 19:43:06 +0000 (19:43 +0000)]
Remove pstring from strdup_upper - make it the
same as talloc_strdup_upper.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25199 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoChange net_rpc_join_ok() to return NTSTATUS for better
obnox [Mon, 17 Sep 2007 15:34:22 +0000 (15:34 +0000)]
Change net_rpc_join_ok() to return NTSTATUS for better
error propagation.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25198 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoChange net_make_ipc_connection() and net_make_ipc_connection_ex() to
obnox [Mon, 17 Sep 2007 15:11:20 +0000 (15:11 +0000)]
Change net_make_ipc_connection() and net_make_ipc_connection_ex() to
return NTSTATUS to allow for better error propagation.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25197 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix issue with calling pull_uc2_*alloc with
jra [Mon, 17 Sep 2007 10:50:59 +0000 (10:50 +0000)]
Fix issue with calling pull_uc2_*alloc with
str_len == 0. We should just return 0 in this
case.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25195 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix some C++ warnings and an uninitialized variable
vlendec [Sat, 15 Sep 2007 20:24:35 +0000 (20:24 +0000)]
Fix some C++ warnings and an uninitialized variable

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25184 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agofix libunwind detection on x86 based hosts
metze [Sat, 15 Sep 2007 19:14:49 +0000 (19:14 +0000)]
fix libunwind detection on x86 based hosts
we need -lunwind-x86 not -lunwind-i686

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25179 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoif configured using --enable-socket-wrapper
metze [Sat, 15 Sep 2007 18:55:04 +0000 (18:55 +0000)]
if configured using --enable-socket-wrapper
allow overwritting the location of the WINBINDD_SOCKET_DIR
via an environment variable

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25177 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoUse the append_buffer version in a loop.
jra [Fri, 14 Sep 2007 22:27:27 +0000 (22:27 +0000)]
Use the append_buffer version in a loop.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25173 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove commented out code we will never enable.
jra [Fri, 14 Sep 2007 22:16:21 +0000 (22:16 +0000)]
Remove commented out code we will never enable.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25172 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoMore pstring removal.
jra [Fri, 14 Sep 2007 22:14:39 +0000 (22:14 +0000)]
More pstring removal.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25171 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove pstring limits from ms_fnmatch and module load.
jra [Fri, 14 Sep 2007 22:03:41 +0000 (22:03 +0000)]
Remove pstring limits from ms_fnmatch and module load.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25170 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix bug 4028
vlendec [Fri, 14 Sep 2007 18:31:33 +0000 (18:31 +0000)]
Fix bug 4028

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25169 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix breakage from mangling rewrite. Use the
jra [Fri, 14 Sep 2007 18:24:31 +0000 (18:24 +0000)]
Fix breakage from mangling rewrite. Use the
new name if unmangling succeeded, not if it
failed. Jerry - please re-test, this should
fix your bug.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25167 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoUse talloc_asprintf_append_buffer with an unmodified
jra [Fri, 14 Sep 2007 17:42:10 +0000 (17:42 +0000)]
Use talloc_asprintf_append_buffer with an unmodified
string.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25165 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd talloc_asprintf_append_buffer() and the docs for it.
jra [Fri, 14 Sep 2007 17:40:58 +0000 (17:40 +0000)]
Add talloc_asprintf_append_buffer() and the docs for it.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25164 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix wrong ctx passed to talloc_asprintf_append().
jra [Fri, 14 Sep 2007 16:50:54 +0000 (16:50 +0000)]
Fix wrong ctx passed to talloc_asprintf_append().
Found by Metze's code review (thanks Metze !).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25163 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRefactor further: add mapping functions between
obnox [Fri, 14 Sep 2007 16:12:38 +0000 (16:12 +0000)]
Refactor further: add mapping functions between
REGISTRY_VALUE and struct registry_value formats for
registry values. Lacking better naming, I called them
regval_hilvl_to_lolvl and regval_lolvl_to_hilvl for a
start. The might be useful elsewhere, so might be put
into another place later on.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25162 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoDon't panic if setgroups fails in non-root mode.
jpeach [Fri, 14 Sep 2007 15:08:07 +0000 (15:08 +0000)]
Don't panic if setgroups fails in non-root mode.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25161 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRefactor out and slightly clean up canonicalization of the registry value
obnox [Fri, 14 Sep 2007 14:20:46 +0000 (14:20 +0000)]
Refactor out and slightly clean up canonicalization of the registry value
from smbconf_store_values().

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25160 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoUpdate coding guiding wrt to primitive data types
jerry [Fri, 14 Sep 2007 12:06:34 +0000 (12:06 +0000)]
Update coding guiding wrt to primitive data types

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25156 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agomove winbindd code into winbindd/
metze [Fri, 14 Sep 2007 12:03:58 +0000 (12:03 +0000)]
move winbindd code into winbindd/

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25154 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agofix headers used in wbinfo.c
metze [Fri, 14 Sep 2007 11:56:10 +0000 (11:56 +0000)]
fix headers used in wbinfo.c

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25152 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agodon't recursivly call call dump_core()
metze [Fri, 14 Sep 2007 11:07:02 +0000 (11:07 +0000)]
don't recursivly call call dump_core()
as currently seen in 'make test' localy and in the farm

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25150 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdapt to coding conventions.
gd [Fri, 14 Sep 2007 08:21:20 +0000 (08:21 +0000)]
Adapt to coding conventions.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25148 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agorename winbindd_nss.h => winbind_struct_protocol.h
metze [Fri, 14 Sep 2007 08:06:03 +0000 (08:06 +0000)]
rename winbindd_nss.h => winbind_struct_protocol.h

as this header has nothing todo with winbindd nor nss
and it contains the definitions for the struct based
protocol

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25146 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agorename public functions from winbind_client.h
metze [Fri, 14 Sep 2007 07:07:59 +0000 (07:07 +0000)]
rename public functions from winbind_client.h

init_request => winbindd_init_request
free_response => winbindd_free_response
read_reply => winbindd_read_reply

write_sock => winbind_write_sock
read_sock => winbind_read_sock
close_sock => winbind_close_sock(void)

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25143 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoPanic if setting the group list fails while switching security
jpeach [Fri, 14 Sep 2007 04:17:17 +0000 (04:17 +0000)]
Panic if setting the group list fails while switching security
contexts. Patch from Tim Prouty <tim.prouty@isilon.com>.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25142 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoMore pstring removal.
jra [Fri, 14 Sep 2007 01:07:57 +0000 (01:07 +0000)]
More pstring removal.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25141 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoLess red bars to hurt my eyes...
obnox [Thu, 13 Sep 2007 22:41:04 +0000 (22:41 +0000)]
Less red bars to hurt my eyes...

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25140 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAvoid code duplication: let regval_ctr_copyvalue() call regval_ctr_addvalue().
obnox [Thu, 13 Sep 2007 22:36:10 +0000 (22:36 +0000)]
Avoid code duplication: let regval_ctr_copyvalue() call regval_ctr_addvalue().
This also corrects regval_ctr_copyvalue() in that it cannot create (invalid)
regval containers with dupliacte entries...

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25139 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoMore pstring elimination. Add a TALLOC_CTX parameter
jra [Thu, 13 Sep 2007 22:08:59 +0000 (22:08 +0000)]
More pstring elimination. Add a TALLOC_CTX parameter
to unix_convert().
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25138 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoWhen tallocing a string to uppercase remember the terminating
jra [Thu, 13 Sep 2007 17:25:57 +0000 (17:25 +0000)]
When tallocing a string to uppercase remember the terminating
'\0' in size calculations.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25136 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() which
gd [Thu, 13 Sep 2007 16:48:46 +0000 (16:48 +0000)]
Remove one END_PROFILE(SMBntcreateX) from call_nt_transact_create() which
appears to be a leftover. Should fix the build with profiling enabled.

Jeremy, please check.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25135 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix Bug #4968 and make dns updates work with heimdal as well (again,
gd [Thu, 13 Sep 2007 16:11:46 +0000 (16:11 +0000)]
Fix Bug #4968 and make dns updates work with heimdal as well (again,
gss_import_name() needs to follow the same logic as in the LDAP sasl wrapping
(see -r25133).

Tested with MIT 1.2.7, 1.3.6, 1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0,
1.0.1.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25134 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix sasl wrapping (for ldap sign&seal).
gd [Thu, 13 Sep 2007 15:59:46 +0000 (15:59 +0000)]
Fix sasl wrapping (for ldap sign&seal).

The gss_import_name() broke as we switched from the internal MIT OID
"gss_nt_krb5_principal" to "GSS_KRB5_NT_PRINCIPAL_NAME" and didn't switch from
passing the krb5_principal (or better: a pointer to that, see MIT's "*HORRIBLE*
bug") to pass the string principal directly.

Jerry, Jeremy, neither I could figure out the need of passing in a
krb5_principal at all nor could I reproduce the crash you were seeing.

I sucessfully tested the code (now importing a string) with MIT 1.2.7, 1.3.6,
1.4.3, 1.5.1, 1.6.1 and Heimdal 0.7.2, 1.0, 1.0.1.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25133 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agomake use only of base types which are provided by libreplace
metze [Thu, 13 Sep 2007 14:14:02 +0000 (14:14 +0000)]
make use only of base types which are provided by libreplace
in winbind client and nss/pam stuff

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25130 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years ago_XOPEN_SOURCE_EXTENDED and socklen_t are always provided by libreplace
metze [Thu, 13 Sep 2007 12:54:53 +0000 (12:54 +0000)]
_XOPEN_SOURCE_EXTENDED and socklen_t are always provided by libreplace

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25128 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoAdd ol-schema-migrate.pl to the repo.
idra [Thu, 13 Sep 2007 12:51:00 +0000 (12:51 +0000)]
Add ol-schema-migrate.pl to the repo.
This script is useful for migrating OpenLDAP schema files to FDS/RHDS
lidf schema files.

License kindly updated to GPLv3+ at our request.

Simo.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25127 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agocreate prototypes for 'bool ' functions
metze [Thu, 13 Sep 2007 12:25:28 +0000 (12:25 +0000)]
create prototypes for 'bool ' functions

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25125 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove pstring limits from much of our string handling function.
jra [Thu, 13 Sep 2007 01:10:01 +0000 (01:10 +0000)]
Remove pstring limits from much of our string handling function.
Still a few left (mainly the substitute ones).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25121 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoOne more warning.
jra [Thu, 13 Sep 2007 00:31:02 +0000 (00:31 +0000)]
One more warning.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25120 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix a couple of warnings.
jra [Thu, 13 Sep 2007 00:29:25 +0000 (00:29 +0000)]
Fix a couple of warnings.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25119 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoMore pstring elimination.
jra [Wed, 12 Sep 2007 23:50:21 +0000 (23:50 +0000)]
More pstring elimination.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25118 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoThe mega-patch Jerry was waiting for. Remove all pstrings from
jra [Wed, 12 Sep 2007 21:48:20 +0000 (21:48 +0000)]
The mega-patch Jerry was waiting for. Remove all pstrings from
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25117 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoFix talloc_asprintf_append to do the right thing with
jra [Wed, 12 Sep 2007 21:41:36 +0000 (21:41 +0000)]
Fix talloc_asprintf_append to do the right thing with
truncated strings.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25116 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoMove to talloced pathnames on most code paths.
jra [Tue, 11 Sep 2007 23:57:59 +0000 (23:57 +0000)]
Move to talloced pathnames on most code paths.
There are now ony 17 pstrings left in reply.c,
and these will be easy to remove (and I'll be
doing that shortly). Had to fix an interesting
bug in pull_ucs2_base_talloc() when a source
string is not null terminated :-).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25111 0c0555d6-39d7-0310-84fc-f1cc0bd64818

11 years agoRemove obsolete argument from ads_guess_service_principal().
gd [Tue, 11 Sep 2007 23:35:17 +0000 (23:35 +0000)]
Remove obsolete argument from ads_guess_service_principal().

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_2@25109 0c0555d6-39d7-0310-84fc-f1cc0bd64818