metze/old/v3-2-winbind-ndr.git
12 years agoUse existing escaping function pointed by James
idra [Sat, 16 Jun 2007 22:52:51 +0000 (22:52 +0000)]
Use existing escaping function pointed by James

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23527 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoI believe this patch is ok, got no reply of it being not ok.
idra [Sat, 16 Jun 2007 18:59:02 +0000 (18:59 +0000)]
I believe this patch is ok, got no reply of it being not ok.
This closes #4624 for me.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23525 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix bug 2319.
idra [Sat, 16 Jun 2007 18:54:13 +0000 (18:54 +0000)]
Fix bug 2319.
Got report this is all ok form a tester. Close a loong
standing bug preventing people to freely use any character
in their password when printing via cups were involved.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23524 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoGaa -- had renamed "name" to "path" and apparently not compiled after
vlendec [Sat, 16 Jun 2007 18:19:42 +0000 (18:19 +0000)]
Gaa -- had renamed "name" to "path" and apparently not compiled after
that....

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23523 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSave us a kilobyte stack space in a hot code path: I can't see a reason
vlendec [Sat, 16 Jun 2007 18:07:44 +0000 (18:07 +0000)]
Save us a kilobyte stack space in a hot code path: I can't see a reason
why check_path_syntax should not be able to run in-line. The destination
pointer either walks side by side with the source pointer or is
decremented. So as far as I can see s>=d is true throughout the whole
routine.

Jeremy, I'm checking this only into 3_0 for now. Please review and ack
or directly merge this to 3_0_26.

Thanks,

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23522 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRemove the silly assumption that string_replace requires a pstring.
vlendec [Sat, 16 Jun 2007 11:48:11 +0000 (11:48 +0000)]
Remove the silly assumption that string_replace requires a pstring.

Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!

While at it, remove the pstring limit for strhasupper and strhaslower.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23518 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoAfter Jeremy has given is ack on irc:
vlendec [Sat, 16 Jun 2007 10:02:51 +0000 (10:02 +0000)]
After Jeremy has given is ack on irc:

Change rename_internals to open the file/directory and then call
rename_internals_fsp. Two reasons: Remove code duplication and remove a
race condition. The race condition was due to the fact that in
can_rename the share mode check closed the file and then after that did
the rename.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23517 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
jra [Sat, 16 Jun 2007 01:04:22 +0000 (01:04 +0000)]
Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
- when cleaning up invalid locks make sure we mark the lck
struct as modified so it'll get saved back correctly (that
was the original intent).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23516 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoEnsure status isn't used uninitialized.
jra [Sat, 16 Jun 2007 00:54:58 +0000 (00:54 +0000)]
Ensure status isn't used uninitialized.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23515 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRemove unused function ads_get_dn_from_extended_dn().
jra [Sat, 16 Jun 2007 00:39:52 +0000 (00:39 +0000)]
Remove unused function ads_get_dn_from_extended_dn().
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23514 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix one more use of VALUE_PREFIX.
jra [Fri, 15 Jun 2007 23:52:01 +0000 (23:52 +0000)]
Fix one more use of VALUE_PREFIX.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23513 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix conflict in #define for SECDESC_PREFIX. Ensure all
jra [Fri, 15 Jun 2007 23:47:40 +0000 (23:47 +0000)]
Fix conflict in #define for SECDESC_PREFIX. Ensure all
reg #defines use "REG_" prefix. Michael - please check
gcc warnings on compiles.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23512 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoTidy calls to smb_panic by removing trailing newlines. Print the
jpeach [Fri, 15 Jun 2007 21:58:49 +0000 (21:58 +0000)]
Tidy calls to smb_panic by removing trailing newlines. Print the
failed expression in SMB_ASSERT.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23510 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoThis activates the global options from the registry in loadparm.
obnox [Fri, 15 Jun 2007 21:38:10 +0000 (21:38 +0000)]
This activates the global options from the registry in loadparm.
The global options are stored as values in the subkey "global"
of the SMBCONF registry key.

The activation is accomplished in smb.conf though a new special
semantic of the "include" parameter: "include = registry" triggers
the processing of the registry global options exactly at the
position of the include statement. Options read from the registry
take the same precedence as parameters loaded from a file via
include. Need to reload the registry globals is detected by
watching the tdb sequence number.

Registry shares are automatically activated when the registry
globals are processed.

So a "registry only" configuration can be realized by an
smb.conf that looks as follows:

================================
[global]
include = registry
================================

The global options and registry shares can be conveniently
edited with the "net conf" utility.

Caveat:

A possible pitfall consists in using "include = registry"
together with the "lock directory" directive in the registry.
This problem will be addressed in the next time.

Note on the code:

Processing of the registry options is accomplished by a function
process_registry_globals() in loadparm.c The current version is
only an interim solution: It is handcoded instead of using the
infrastructure of reg_api.c. The reason for this is that using
reg_api still has too large linker dependencies, bloating virtually
all targets by PASSDB_OBJ, SMBLDAP_OBJ, GROUPDB_OBJ and LDB stuff.
A version of process_registry_globals that uses reg_api is
included but commented out. The goal is to eventually refactor
and restructure the registry code so that one can use the reg_api
to access only the registry tdb and not link all the dynamic
backends with all their linking implications.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23509 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix sync_file() to return NTSTATUS and return this
jra [Fri, 15 Jun 2007 19:24:04 +0000 (19:24 +0000)]
Fix sync_file() to return NTSTATUS and return this
on failure in the write path.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23508 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSplit one general function normalize_dbkey from reg_db.c into util_reg.c
obnox [Fri, 15 Jun 2007 15:51:45 +0000 (15:51 +0000)]
Split one general function normalize_dbkey from reg_db.c into util_reg.c
(To be used in other place in subsequent commit.)

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23507 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoUse tdb_wrap_open (instead of usual tdb_open) in reg_db.
obnox [Fri, 15 Jun 2007 10:40:36 +0000 (10:40 +0000)]
Use tdb_wrap_open (instead of usual tdb_open) in reg_db.
This eliminates the need of maintaining reg_db's own
reference counter for the tdb. Maybe as a next step...

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23504 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years ago Restore exit-on-idle. Small refactoring for clarity. Exit if
jpeach [Thu, 14 Jun 2007 18:48:51 +0000 (18:48 +0000)]
Restore exit-on-idle.  Small refactoring for clarity. Exit if
    we are idle and we timed out waiting for something to do.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23502 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoMove notify_rename before rename_internals_fsp and call it from there.
vlendec [Thu, 14 Jun 2007 15:50:47 +0000 (15:50 +0000)]
Move notify_rename before rename_internals_fsp and call it from there.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23501 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoTwo changes to survive the now activated test for rename_internals_fsp:
vlendec [Thu, 14 Jun 2007 14:45:37 +0000 (14:45 +0000)]
Two changes to survive the now activated test for rename_internals_fsp:
With the target being open we have to return NT_STATUS_ACCESS_DENIED and
root_fid != 0 leads to NT_STATUS_INVALID_PARAMETER

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23500 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoDisable building of libaddns (no defined API) and
jerry [Thu, 14 Jun 2007 14:35:29 +0000 (14:35 +0000)]
Disable building of libaddns (no defined API) and
libmsrpc (unmaintained).

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23497 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix logic error in getgrnam_recv() that broke
jerry [Thu, 14 Jun 2007 14:12:53 +0000 (14:12 +0000)]
Fix logic error in getgrnam_recv() that broke
getgrnam() for machine and domain local groups.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23496 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoReplace literal occurrences of libsmb/errormap.o by $(ERRORMAP_OBJ).
obnox [Thu, 14 Jun 2007 13:26:31 +0000 (13:26 +0000)]
Replace literal occurrences of libsmb/errormap.o by $(ERRORMAP_OBJ).

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23495 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSynchronize some occurrences of BINARY_PREREQS and bin/.dummy.
obnox [Thu, 14 Jun 2007 13:12:32 +0000 (13:12 +0000)]
Synchronize some occurrences of BINARY_PREREQS and bin/.dummy.
Further reduce the diff between 3_0 and 3_0_26 by some reformatting
and rearrangements.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23494 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years ago(Re-)Add tdbtorture as a build target to 3_0_26.
obnox [Thu, 14 Jun 2007 12:29:04 +0000 (12:29 +0000)]
(Re-)Add tdbtorture as a build target to 3_0_26.
Add the tdbtorture test to the test script in 3_0 and 3_0_26.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23489 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoOk, this time with a hopefully successful make test in the right place:
vlendec [Thu, 14 Jun 2007 12:03:46 +0000 (12:03 +0000)]
Ok, this time with a hopefully successful make test in the right place:
Remove two local variables

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23486 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoThis checkin consists mostly of refactorings in preparation of the
obnox [Thu, 14 Jun 2007 11:29:35 +0000 (11:29 +0000)]
This checkin consists mostly of refactorings in preparation of the
activation of global registry options in loadparm.c, mainly to
extract functionality from net_conf.c to be made availabel elsewhere
and to minimize linker dependencies.

In detail:

* move functions registry_push/pull_value from lib/util_reg.c to new file
  lib/util_reg_api.c

* create a fake user token consisting of builtin administrators sid and
  se_disk_operators privilege by hand instead of using get_root_nt_token()
  to minimize linker deps for bin/net.

  + new function registry_create_admin_token() in new lib/util_reg_smbconf.c
  + move dup_nt_token from auth/token_util.c to new file lib/util_nttoken.c
  + adapt net_conf.c and Makefile.in accordingly.

* split lib/profiles.c into two parts: new file lib/profiles_basic.c
  takes all the low level mask manipulation and format conversion functions
  (se_priv, privset, luid). the privs array is completely hidden from
  profiles.c by adding some access-functions. some mask-functions are not
  static anymore.

  Generally, SID- and LUID-related stuff that has more dependencies
  is kept in lib/profiles.c

* Move initialization of regdb from net_conf.c into a function
  registry_init_regdb() in lib/util_reg_smbconf.c.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23485 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoWhen chasing AD referrals make sure to honor the base returned from the server.
gd [Thu, 14 Jun 2007 09:59:07 +0000 (09:59 +0000)]
When chasing AD referrals make sure to honor the base returned from the server.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23484 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRevert 23482, I must have run 'make test' in the wrong subdir.
vlendec [Thu, 14 Jun 2007 09:51:13 +0000 (09:51 +0000)]
Revert 23482, I must have run 'make test' in the wrong subdir.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23483 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSlightly simplify the rename code: Remove two local variables that are
vlendec [Thu, 14 Jun 2007 09:45:39 +0000 (09:45 +0000)]
Slightly simplify the rename code: Remove two local variables that are
not really needed.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23482 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix DEVELOPER_CFLAGS quoting.
jpeach [Thu, 14 Jun 2007 04:00:35 +0000 (04:00 +0000)]
Fix DEVELOPER_CFLAGS quoting.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23480 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoChange the handling of the developer CFLAGS so that they are always
jpeach [Thu, 14 Jun 2007 03:38:43 +0000 (03:38 +0000)]
Change the handling of the developer CFLAGS so that they are always

emited to the Makefile in the DEVELOPER_CFLAGS variable. This makes
it easy to turn developer mode on and off without waiting for
configure to run. The developer flags are only added to CFLAGS for
the --enable-developer and --enable-krb5developer cases.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23478 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoBuild farm fix: Use int rather than MIT's krb5_int32 when setting context flags.
jerry [Wed, 13 Jun 2007 21:59:39 +0000 (21:59 +0000)]
Build farm fix: Use int rather than MIT's krb5_int32 when setting context flags.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23477 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix the prototype for sys_broken_setgroups and log *BSD group list
jpeach [Wed, 13 Jun 2007 21:42:31 +0000 (21:42 +0000)]
Fix the prototype for sys_broken_setgroups and log *BSD group list
truncation a bit more verbosely.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23475 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoHere's a small patch that disables the libkrb5.so replay cache
jerry [Wed, 13 Jun 2007 20:49:20 +0000 (20:49 +0000)]
Here's a small patch that disables the libkrb5.so replay cache
when verifying a ticket from winbindd_pam.c.

I've found during multiple, fast, automated SSH logins (such
as from a cron script) that the replay cache in MIT's krb5
lib will occasionally fail the krb5_rd_req() as a replay attack.

There seems to be a small window during which the MIT krb5
libs could reproduce identical time stamps for ctime and cusec
in the authenticator since Unix systems only give back
milli-seconds rather than the micro-seconds needed by the
authenticator.  Checked against MIT 1.5.1.  Have not
researched how Heimdal does it.

My thinking is that if someone can spoof the KDC and TDS
services we are pretty hopeless anyways.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23474 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoadd missing default setting for 'winbind nss info' (merge from 3.0.26)
jerry [Wed, 13 Jun 2007 20:43:49 +0000 (20:43 +0000)]
add missing default setting for 'winbind nss info' (merge from  3.0.26)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23472 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoHere's a rough patch for expanding domain group membership
jerry [Wed, 13 Jun 2007 20:40:54 +0000 (20:40 +0000)]
Here's a rough patch for expanding domain group membership
in the winbindd_getgrnam() call.  Couple of comments:

* Adds "winbind expand groups" parameter which defines the
  max depth winbindd will expand group members.  The default
  is the current behavior of one level of expansion.
* The entire getrgnam() interface should be async.  I
  haven't done that.
* Refactors the domain users hack in fill_grent_mem() into
  its own function.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23471 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix supplementary group list truncation for *BSD. We need to pass
jpeach [Wed, 13 Jun 2007 20:40:50 +0000 (20:40 +0000)]
Fix supplementary group list truncation for *BSD. We need to pass
the correct group list length and only truncate to NGROUPS_MAX if
it is too long.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23470 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix a comment
vlendec [Wed, 13 Jun 2007 19:01:41 +0000 (19:01 +0000)]
Fix a comment

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23469 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoOpen registry.tdb with sequence number.
obnox [Wed, 13 Jun 2007 13:15:16 +0000 (13:15 +0000)]
Open registry.tdb with sequence number.
Add a function to retrieve the registry db sequence number.

This is in preparation of loadparm integration of registry global
smb.conf options: this will allow to detect changes in order to trigger reload.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23468 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoNext little simplification: In rename_internals it's a bit pointless to
vlendec [Wed, 13 Jun 2007 12:52:36 +0000 (12:52 +0000)]
Next little simplification: In rename_internals it's a bit pointless to
first ask for existence of a file when we do the open_file_ntcreate in
can_rename later on anyway. That also gets us the right error message in
case the file is not there automatically.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23467 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix RAW-NOTIFY: by using delete on close the notify is triggered deep
vlendec [Wed, 13 Jun 2007 11:32:46 +0000 (11:32 +0000)]
Fix RAW-NOTIFY: by using delete on close the notify is triggered deep
inside close_file() already.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23466 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoThere was this diff between reg_printing in 3_0 and 3_0_26:
obnox [Wed, 13 Jun 2007 11:04:31 +0000 (11:04 +0000)]
There was this diff between reg_printing in 3_0 and 3_0_26:
before writing to secdesc_buf->sd,
3_0 checked secdesc_buf->sd while 3_0_26 checked secdesc_buf->sd_size.

This patch makes both revisions check _both_ befor writing.

Jerry / Jeremy : please check if this is correct!

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23465 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRe-add whitespace to reduce diff between branches.
obnox [Wed, 13 Jun 2007 10:12:33 +0000 (10:12 +0000)]
Re-add whitespace to reduce diff between branches.
Sorry for the noise...

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23460 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRemove one superfluous cast.
obnox [Wed, 13 Jun 2007 10:07:05 +0000 (10:07 +0000)]
Remove one superfluous cast.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23459 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoCosmetic fix in debug output.
obnox [Wed, 13 Jun 2007 10:06:17 +0000 (10:06 +0000)]
Cosmetic fix in debug output.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23458 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoAfter Jeremy's ack:
vlendec [Wed, 13 Jun 2007 09:55:13 +0000 (09:55 +0000)]
After Jeremy's ack:

The attached patch removes a little race condition for
people with real kernel oplock support, and reduces some
code paths. It changes reply_unlink to open_file_ntcreate,
set_delete_on_close and close_file.

The race condition happens if we break the oplock in
can_delete via open_file_ntcreate, we close the file,
someone else gets a batch oplock and we try to unlink.

It reduces code paths by calling SMB_VFS_UNLINK in 2 fewer
places.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23457 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agomax_params_return is complete fiction when getting a changenotify
jra [Tue, 12 Jun 2007 19:59:38 +0000 (19:59 +0000)]
max_params_return is complete fiction when getting a changenotify
request. Ignore it. Should fix bug #4689 but more tests and
valgrinding will follow.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23450 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoDoh ! Don't call winbind_child_died() *before* the
jra [Tue, 12 Jun 2007 19:53:51 +0000 (19:53 +0000)]
Doh ! Don't call winbind_child_died() *before* the
kill call as that sets pid = 0 ! :-).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23448 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoAdd kill signal to child dead path. After talking
jra [Tue, 12 Jun 2007 19:47:33 +0000 (19:47 +0000)]
Add kill signal to child dead path. After talking
to Jerry add to 3.0.25b.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23447 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRestore Jeremy's original formatting, just fix the comment.
vlendec [Tue, 12 Jun 2007 19:19:35 +0000 (19:19 +0000)]
Restore Jeremy's original formatting, just fix the comment.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23446 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix suggested by Volker. Don't call rename_open_files
jra [Tue, 12 Jun 2007 18:14:16 +0000 (18:14 +0000)]
Fix suggested by Volker. Don't call rename_open_files
if the name wasn't changed.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23445 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoCoorect a comment.
obnox [Tue, 12 Jun 2007 12:35:24 +0000 (12:35 +0000)]
Coorect a comment.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23434 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoremove superfluous semicolon.
obnox [Tue, 12 Jun 2007 12:01:52 +0000 (12:01 +0000)]
remove superfluous semicolon.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23433 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRemove superfluous comment.
obnox [Tue, 12 Jun 2007 11:54:25 +0000 (11:54 +0000)]
Remove superfluous comment.
(A relict from regkey_open_internal days.)

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23432 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoOoops, sorry.
vlendec [Tue, 12 Jun 2007 10:18:26 +0000 (10:18 +0000)]
Ooops, sorry.

Revert an accidential checkin of r23410.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23429 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoCorrect a comment. The default timeout is not 1min, but 30s. While
vlendec [Tue, 12 Jun 2007 08:02:32 +0000 (08:02 +0000)]
Correct a comment. The default timeout is not 1min, but 30s. While
there, do some reformatting.

Jeremy, I think we should also kill the child. It might hang in
something (an fcntl lock for example) that the next child might run into
immediately again.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23426 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoVolker noticed this obvious fix for the wins server
jra [Tue, 12 Jun 2007 01:45:40 +0000 (01:45 +0000)]
Volker noticed this obvious fix for the wins server
code :-). Thanks Volker !
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23425 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoThanks to Jerry, we finally tracked down the :
jra [Mon, 11 Jun 2007 22:28:27 +0000 (22:28 +0000)]
Thanks to Jerry, we finally tracked down the :
winbindd: Exceeding 200 client connections, no idle connection found"
bug #3204. This fixes it in Jerry's testing !
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23424 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoUse the correct structure types in the NT_ACL operations. It's not
jpeach [Mon, 11 Jun 2007 20:56:17 +0000 (20:56 +0000)]
Use the correct structure types in the NT_ACL operations. It's not
clear to my why the catia module feels it's necessary to implement
these operations, but at least they're now the right type.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23423 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoWe were missing displayName and that was preventing us
idra [Mon, 11 Jun 2007 00:05:48 +0000 (00:05 +0000)]
We were missing displayName and that was preventing us
from successfully deleting an entry when "account" is
the STRUCTURAL objectclass used for users and machines.
"account" is used each time the user entry is in /etc/passwd
and we have only the samba attributes in ldap, as well
as for rfc2307(bis) standard based directories.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23411 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoMerge the core of the cluster code.
vlendec [Sun, 10 Jun 2007 17:02:09 +0000 (17:02 +0000)]
Merge the core of the cluster code.

I'm 100% certain I've forgotten to merge something, but the main code
should be in. It's mainly in dbwrap_ctdb.c, ctdbd_conn.c and
messages_ctdbd.c.

There should be no changes to the non-cluster case, it does survive make
test on my laptop.

It survives some very basic tests with ctdbd enables, I did not do the
full test suite for clusters yet.

Phew...

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23410 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRemove a bogus comment
vlendec [Sun, 10 Jun 2007 10:18:03 +0000 (10:18 +0000)]
Remove a bogus comment

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23408 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoWhile verifying a bug I found out that for some reason
idra [Sat, 9 Jun 2007 22:45:21 +0000 (22:45 +0000)]
While verifying a bug I found out that for some reason
the code to add a machine was different then the one used
to add a user, the old code led to the machine SID not being
built out correctly allocationg a new RID out of the passdb
but instead by using the old algorithmic method.
This may easily end up in creating duplicated SID when the
RID counter get close to the values built by the algorithmic method.

Simo.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23407 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoEvn if not strictly currently necessary do check for correct
idra [Sat, 9 Jun 2007 19:29:35 +0000 (19:29 +0000)]
Evn if not strictly currently necessary do check for correct
init also in idmap_nss and idmap_passdb for coherency and to
prevent errors in future if we change the init functions to
actually do something and not just return NT_STATUS_OK

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23406 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix wrong (and missing) action on error condition in ldap reply evaluation loop
idra [Sat, 9 Jun 2007 18:18:24 +0000 (18:18 +0000)]
Fix wrong (and missing) action on error condition in ldap reply evaluation loop
Fixes one of the segfaults in bug #4667

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23404 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoGot bitten by a talloc hierarchy. Make sure we alloc
jra [Sat, 9 Jun 2007 00:27:28 +0000 (00:27 +0000)]
Got bitten by a talloc hierarchy. Make sure we alloc
off the pipe ctx now ->names is part of the containing
struct.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23402 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix lsa crash bug #4683. The "names" enum struct
jra [Sat, 9 Jun 2007 00:13:07 +0000 (00:13 +0000)]
Fix lsa crash bug #4683. The "names" enum struct
in a lookup_sidX reply isn't optional - like the
lookup_sidX query it needs to be defined in the
struct.
All this will go away with PIDL (thank goodness....).
Jerry - I think this is a showstopper to be merged
for 3.0.25b.
I'll be watching the build farm to see if anything broke.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23400 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSupport membership of >16 groups on Darwin by making sure we opt in to the
jpeach [Sat, 9 Jun 2007 00:10:26 +0000 (00:10 +0000)]
Support membership of >16 groups on Darwin by making sure we opt in to the
dynamic group resolution mechanism when switching UNIX credentials.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23398 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoMake VFS callbacks static. Mark operations as OPAQUE because they
jpeach [Fri, 8 Jun 2007 23:08:41 +0000 (23:08 +0000)]
Make VFS callbacks static. Mark operations as OPAQUE because they
do not pass through.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23396 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSupport BSD group semantics by making sure that the effective GID is always
jpeach [Fri, 8 Jun 2007 22:25:55 +0000 (22:25 +0000)]
Support BSD group semantics by making sure that the effective GID is always
passed as the first GID when calling setgroups(2).

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23393 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoSecond part of the patch for Apple.
jra [Fri, 8 Jun 2007 19:58:32 +0000 (19:58 +0000)]
Second part of the patch for Apple.

Change the sequence :

gain_root();
sys_setgroups(ngroups, groups);
become_id(uid, gid);

to a function call :

set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *groups)

James - should be safe for you to create a Darwin-specific
version of this function now.

Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23391 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFirst part of the patch to make Apple's life easier.
jra [Fri, 8 Jun 2007 19:52:18 +0000 (19:52 +0000)]
First part of the patch to make Apple's life easier.
Doing this in two stages to make it very easy to
review. Context switching must look like :

gain_root();
sys_setgroups(ngroups, groups);
become_id(uid, gid);

Re-arrange order so these three calls are always
seen together.

Next will be to turn these into a function.

Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23390 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoDisabling ACL support on Darwin/Mac OS X for now.
obnox [Fri, 8 Jun 2007 14:37:29 +0000 (14:37 +0000)]
Disabling ACL support on Darwin/Mac OS X for now.

Current configure check detects posix ACL support
but compile of modules/vfs_posixacl.c fails due
to missing defines in sys/acl.h:
ACL_USER, ACL_USER_OBJ, ACL_GROUP, ACL_GROUP_OBJ, ACL_OTHER,
ACL_MASK, ACL_WRITE, ACL_READ

It has to be investigated, if this can be fixed within
the posixacl vfs module or if we need a darwinacl module.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23389 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years ago1. This unifies the POSIX ACL detection code:
obnox [Fri, 8 Jun 2007 12:32:13 +0000 (12:32 +0000)]
1. This unifies the POSIX ACL detection code:
Linux, FreeBSD and other (which?) ACL implementations
are now checked in the same block instead of in three
separate blocks. This was inspired by Timur Bakeyev
in Bug #4543. Since bugzilla is currently unavailable
this patch is probably slightly different from Timurs
original patch. This should finally fix Bug #4543.

2. The default of the --with-acl-support configure
option is changed to "auto" (which is actually the
same as "yes"). So configure tries to detect acl
support by default. This had been discussed with
Metze and others.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23387 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agonetr_getdcname returns WERROR not NTSTATUS.
gd [Fri, 8 Jun 2007 10:29:46 +0000 (10:29 +0000)]
netr_getdcname returns WERROR not NTSTATUS.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23380 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoWhitespace cosmetics, to reduce irritating diffs...
obnox [Fri, 8 Jun 2007 10:15:19 +0000 (10:15 +0000)]
Whitespace cosmetics, to reduce irritating diffs...

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23379 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoPatch from Bjoern Jacke <bjoern@j3e.de> to deal
jerry [Thu, 7 Jun 2007 13:35:39 +0000 (13:35 +0000)]
Patch from Bjoern Jacke <bjoern@j3e.de> to deal
with non-GNU implementations of tr in autogen.sh

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23377 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoMore warnings
vlendec [Thu, 7 Jun 2007 07:53:33 +0000 (07:53 +0000)]
More warnings

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23376 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix a 64-bit warning
vlendec [Thu, 7 Jun 2007 07:49:43 +0000 (07:49 +0000)]
Fix a 64-bit warning

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23375 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRemove restriction on string length for rpcclient commands.
jra [Thu, 7 Jun 2007 01:13:43 +0000 (01:13 +0000)]
Remove restriction on string length for rpcclient commands.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23372 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix the misleading comment I added - it really *should*
jra [Thu, 7 Jun 2007 00:14:06 +0000 (00:14 +0000)]
Fix the misleading comment I added - it really *should*
say "locks chain and returned record", not
"and returns record"
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23371 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoTraverse in tdb wasn't consistently using the
jra [Thu, 7 Jun 2007 00:00:45 +0000 (00:00 +0000)]
Traverse in tdb wasn't consistently using the
travlocks.lock_rw for lock read/write types, it
was sometimes using it (tdb_next_lock) and
sometimes explicitly using F_WRLCK instead.
Change this to consistently use travlocks.lock_rw
only.
I'm pretty sure about this fix (else I woudn't
be checking this in :-) but tridge and Volker
please review.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23370 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoMake "winbind:rpc only" a full blown parameter. Thanks to Karolin for
vlendec [Wed, 6 Jun 2007 13:02:24 +0000 (13:02 +0000)]
Make "winbind:rpc only" a full blown parameter. Thanks to Karolin for
the patch :-)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23368 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agocheck the "use mmap" option for ldb too
tridge [Wed, 6 Jun 2007 13:02:14 +0000 (13:02 +0000)]
check the "use mmap" option for ldb too

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23367 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoActivate rep_pread and rep_pwrite in lib/replace/replace.h.
obnox [Wed, 6 Jun 2007 09:27:43 +0000 (09:27 +0000)]
Activate rep_pread and rep_pwrite in lib/replace/replace.h.
This fixes the build on a SuSE 6.1. :-)
I guess this had been merely forgotten.

But beware: The implementations of rep_pread and rep_pwrite are
not thread safe.

Michael

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23363 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoRespect "use mmap" in tdb_wrap_open(). Tridge, you might want to merge
vlendec [Wed, 6 Jun 2007 07:46:38 +0000 (07:46 +0000)]
Respect "use mmap" in tdb_wrap_open(). Tridge, you might want to merge
this in your tree.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23362 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix bug #4537, fix from jens.nissen@gmx.net.
jra [Wed, 6 Jun 2007 00:42:10 +0000 (00:42 +0000)]
Fix bug #4537, fix from jens.nissen@gmx.net.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23359 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix from Justin Maggard <jmaggard@infrant.com> - ensure we don't
jra [Tue, 5 Jun 2007 23:35:39 +0000 (23:35 +0000)]
Fix from Justin Maggard <jmaggard@infrant.com> - ensure we don't
expire a password if it's explicitly set as ACB_PWNOTREQ.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23358 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agotimespec_current() was returning the wrong ns time
jra [Tue, 5 Jun 2007 19:17:05 +0000 (19:17 +0000)]
timespec_current() was returning the wrong ns time
(multiplying tv_sec, not tv_usec).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23357 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoWe missed to add the 'c' character to the list of valid ones for
idra [Tue, 5 Jun 2007 12:58:18 +0000 (12:58 +0000)]
We missed to add the 'c' character to the list of valid ones for
shell escaping.

I hate this kind of bugs more than how Jeremy hates off by ones :(

Simo.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23356 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix some more build warnings.
gd [Tue, 5 Jun 2007 10:49:05 +0000 (10:49 +0000)]
Fix some more build warnings.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23355 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix build warning.
gd [Tue, 5 Jun 2007 10:23:56 +0000 (10:23 +0000)]
Fix build warning.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23354 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoDon't generate stamp-h. AFAICT it is never used.
jpeach [Tue, 5 Jun 2007 06:10:09 +0000 (06:10 +0000)]
Don't generate stamp-h. AFAICT it is never used.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23352 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix from Steve Langasek <vorlon@debian.org> to
jra [Tue, 5 Jun 2007 01:59:37 +0000 (01:59 +0000)]
Fix from Steve Langasek <vorlon@debian.org> to
allow SIGTERM to cause nmbd to exit on awaiting
an interface to come up. Debian bug #168079
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23349 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix connection reporting on SIGUSR2 (noticed by
jra [Mon, 4 Jun 2007 23:51:19 +0000 (23:51 +0000)]
Fix connection reporting on SIGUSR2 (noticed by
Herb).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23348 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix Coverity 363. Dead code elimination.
jra [Mon, 4 Jun 2007 23:31:34 +0000 (23:31 +0000)]
Fix Coverity 363. Dead code elimination.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23347 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoFix offline caching with XP/Vista. It was an off-by-one
jra [Mon, 4 Jun 2007 22:29:23 +0000 (22:29 +0000)]
Fix offline caching with XP/Vista. It was an off-by-one
in storing the access mask. I shouldn't have made this
mistake. Damn. Fixes bug #4673.
Jeremy

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23346 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoStop Coverity from getting confused.
jra [Mon, 4 Jun 2007 19:58:11 +0000 (19:58 +0000)]
Stop Coverity from getting confused.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23345 0c0555d6-39d7-0310-84fc-f1cc0bd64818

12 years agoBetter error message
vlendec [Mon, 4 Jun 2007 19:50:30 +0000 (19:50 +0000)]
Better error message

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@23344 0c0555d6-39d7-0310-84fc-f1cc0bd64818