Fix build after removal of an extra safe_string.h
authorAlexander Bokovoy <ab@samba.org>
Thu, 1 Oct 2020 12:22:12 +0000 (15:22 +0300)
committerJeremy Allison <jra@samba.org>
Thu, 1 Oct 2020 22:45:29 +0000 (22:45 +0000)
commit234957a2e4408537c5722edf04dfe03dd31bd1b1
tree83a695221ede0ac96775a32389ba416cb1e71482
parent91dc9bb6594ae78fa5109719b66e4c644339e1b7
Fix build after removal of an extra safe_string.h

Move of strcasecmp redefine to lib/util/safe_string.h in
https://gitlab.com/samba-team/samba/-/merge_requests/1507 broke build on
Fedora 33 with GCC 10.2.1 for those compilation units that use
ldb_att_cmp().

The reason for that is that ldb_attr_cmp() defined as

   #define ldb_attr_cmp(a, b) strcasecmp(a, b)

because attribute names restricted to be ASCII by RFC2251 (LDAPv3 spec).

A solution is to add

   #undef strcasecmp

to all source code files which use ldb_attr_cmp().

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct  1 22:45:29 UTC 2020 on sn-devel-184
14 files changed:
lib/ldb-samba/ldb_matching_rules.c
source4/dsdb/common/util.c
source4/dsdb/pydsdb.c
source4/dsdb/samdb/ldb_modules/acl_read.c
source4/dsdb/samdb/ldb_modules/anr.c
source4/dsdb/samdb/ldb_modules/dns_notify.c
source4/dsdb/samdb/ldb_modules/objectclass.c
source4/dsdb/samdb/ldb_modules/objectclass_attrs.c
source4/dsdb/samdb/ldb_modules/operational.c
source4/dsdb/samdb/ldb_modules/password_hash.c
source4/dsdb/samdb/ldb_modules/util.c
source4/lib/registry/ldb.c
source4/rpc_server/drsuapi/dcesrv_drsuapi.c
source4/torture/drs/rpc/dssync.c