kamenim/samba-autobuild/.git
4 years agos4: Fix bad review I did in dom_sid_parse_length() code.
Jeremy Allison [Wed, 29 Apr 2015 00:20:42 +0000 (17:20 -0700)]
s4: Fix bad review I did in dom_sid_parse_length() code.

Volker, apologies for the mistake.

Spotted by Andrew Bartlett <abartlet@samba.org>

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Apr 29 08:20:23 CEST 2015 on sn-devel-104

4 years agotdb: version 1.3.5 tdb-1.3.5
Alexander Drozdov [Tue, 28 Apr 2015 07:31:43 +0000 (10:31 +0300)]
tdb: version 1.3.5

ABI change: tdb_chainlock_read_nonblock() has been added.

Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 29 00:05:29 CEST 2015 on sn-devel-104

4 years agotdb: introduce tdb_chainlock_read_nonblock(), a nonblock variant of tdb_chainlock_read()
Alexander Drozdov [Tue, 28 Apr 2015 04:42:43 +0000 (07:42 +0300)]
tdb: introduce tdb_chainlock_read_nonblock(), a nonblock variant of tdb_chainlock_read()

Signed-off-by: Alexander Drozdov <al.drozdov@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Remove server_id_str()
Volker Lendecke [Tue, 28 Apr 2015 11:30:58 +0000 (11:30 +0000)]
lib: Remove server_id_str()

Call server_id_str_buf instead

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Apr 28 20:48:01 CEST 2015 on sn-devel-104

4 years agolib: Simplify dom_sid_parse_length
Volker Lendecke [Fri, 2 Jan 2015 10:02:45 +0000 (11:02 +0100)]
lib: Simplify dom_sid_parse_length

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Fix a typo
Volker Lendecke [Tue, 28 Apr 2015 06:38:43 +0000 (08:38 +0200)]
lib: Fix a typo

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoFix the O3 developer build
Volker Lendecke [Sat, 14 Mar 2015 21:41:36 +0000 (22:41 +0100)]
Fix the O3 developer build

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agolib: Remove procid_str_static
Volker Lendecke [Thu, 23 Apr 2015 16:06:17 +0000 (18:06 +0200)]
lib: Remove procid_str_static

Replace all callers with direct calls to server_id_str_buf without
talloc_tos()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agovfs_gpfs: Fix ENODATA for getacl on .snapshot dirs
Ralph Wuerthner [Tue, 11 Nov 2014 13:27:34 +0000 (14:27 +0100)]
vfs_gpfs: Fix ENODATA for getacl on .snapshot dirs

Fall back to POSIX ACLs in this case.

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Apr 28 13:19:25 CEST 2015 on sn-devel-104

4 years agolib: Use isspace on unsigned char
Volker Lendecke [Sun, 26 Apr 2015 09:15:01 +0000 (11:15 +0200)]
lib: Use isspace on unsigned char

Signed-off-by: Volker Lendecke <vl@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11223
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Apr 27 23:54:27 CEST 2015 on sn-devel-104

4 years agoAdd set date to tdb manpages.
Jelmer Vernooij [Sun, 26 Apr 2015 10:13:05 +0000 (10:13 +0000)]
Add set date to tdb manpages.

This makes builds reproducible.

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reveiewed-by: Jeremy Allison <jra@samba.org>
4 years agoDrop unused and uninstalled SWIG wrapper for talloc.
Jelmer Vernooij [Sun, 26 Apr 2015 10:11:33 +0000 (10:11 +0000)]
Drop unused and uninstalled SWIG wrapper for talloc.

This file was also still incorrectly licensed under the GPLv3.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agopep8: Move to third_party/.
Jelmer Vernooij [Sat, 25 Apr 2015 15:34:13 +0000 (15:34 +0000)]
pep8: Move to third_party/.

Also, update to latest upstream version.

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoctdb-scripts: New configuration variable CTDB_NODE_ADDRESS
Martin Schwenke [Sun, 19 Apr 2015 23:53:23 +0000 (09:53 +1000)]
ctdb-scripts: New configuration variable CTDB_NODE_ADDRESS

Required when automatic address detection can not be used.  This can
be the case when running multiple ctdbd daemons/nodes on the same
physical host (usually for testing), using InfiniBand for the private
network or on Linux when sysctl net.ipv4.ip_nonlocal_bind=1.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Apr 27 06:10:08 CEST 2015 on sn-devel-104

4 years agoctdb-doc: Move --listen documentation from debugging options
Martin Schwenke [Sun, 19 Apr 2015 23:18:08 +0000 (09:18 +1000)]
ctdb-doc: Move --listen documentation from debugging options

There are valid real-world use cases.  Improve the documentation.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Simplify a command pipeline
Martin Schwenke [Sun, 19 Apr 2015 09:52:55 +0000 (19:52 +1000)]
ctdb-scripts: Simplify a command pipeline

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Replace uses of "ctdb pnn" with ctdb_get_pnn()
Martin Schwenke [Sun, 19 Apr 2015 09:45:41 +0000 (19:45 +1000)]
ctdb-scripts: Replace uses of "ctdb pnn" with ctdb_get_pnn()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: Changed uses of "ctdb xpnn" to ctdb_get_pnn()
Martin Schwenke [Sat, 18 Apr 2015 12:00:49 +0000 (22:00 +1000)]
ctdb-scripts: Changed uses of "ctdb xpnn" to ctdb_get_pnn()

"ctdb xpnn" does not work when sysctl net.ipv4.ip_nonlocal_bind=1,
since it determines the node by attempting to bind to each addres in
the nodes file.  The solution is to not use "ctdb xpnn".  After the
initial call, ctdb_get_pnn() will be more efficient that "ctdb xpnn".

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-tests: New function ctdb_set_pnn() to change PNN
Martin Schwenke [Sat, 18 Apr 2015 11:55:50 +0000 (21:55 +1000)]
ctdb-tests: New function ctdb_set_pnn() to change PNN

ctdb_get_pnn() incorrectly caches to the same file regardless of what
node is selected via FAKE_CTDB_PNN.

Instead, set the PNN using new function ctdb_get_pnn(), which also
makes CTDB_VARDIR point to a node-specific subdirectory.  This means
that ctdb_get_pnn() will correctly cache to the node-specific
directory.

Fake tickle and TDB files/directories used by the ctdb stub need to be
the same across all PNNs, so change these to use
$EVENTSCRIPTS_TESTS_VAR_DIR instead of node-specific $CTDB_VARDIR.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoctdb-scripts: New function ctdb_get_pnn() does cached retrieval of PNN
Martin Schwenke [Fri, 17 Apr 2015 10:44:15 +0000 (20:44 +1000)]
ctdb-scripts: New function ctdb_get_pnn() does cached retrieval of PNN

This avoids the expense of establishing a client connection to the
daemon just to get the PNN of the current node.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
4 years agoRevert "wafsamba: flags from enviroment are put before our own internal versions"
Ralph Boehme [Sat, 25 Apr 2015 01:38:48 +0000 (03:38 +0200)]
Revert "wafsamba: flags from enviroment are put before our own internal versions"

This reverts commit b2bb6aeb8057ac725f6ad12378344b201c3a3ba2.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sun Apr 26 18:40:39 CEST 2015 on sn-devel-104

4 years agos4: rpc: Refactor dcesrv_alter() function into setup and send steps.
Jeremy Allison [Fri, 24 Apr 2015 20:19:30 +0000 (13:19 -0700)]
s4: rpc: Refactor dcesrv_alter() function into setup and send steps.

Fixes bug:

https://bugzilla.samba.org/show_bug.cgi?id=11236

Based on code from Julien Kerihuel <j.kerihuel@openchange.org>

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Apr 25 02:43:22 CEST 2015 on sn-devel-104

4 years agosharesec: Use common parse_ace function
Christof Schmitt [Fri, 24 Apr 2015 17:00:19 +0000 (10:00 -0700)]
sharesec: Use common parse_ace function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosharesec: Print ACEs in similar format as expected in input
Christof Schmitt [Fri, 24 Apr 2015 16:51:28 +0000 (09:51 -0700)]
sharesec: Print ACEs in similar format as expected in input

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agoutil_sd: Make server conncection optional
Christof Schmitt [Fri, 24 Apr 2015 16:49:23 +0000 (09:49 -0700)]
util_sd: Make server conncection optional

If cli is not set, only attempt numeric conversions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcacls: Move sec_desc_print to common file
Christof Schmitt [Fri, 24 Apr 2015 16:28:02 +0000 (09:28 -0700)]
smbcacls: Move sec_desc_print to common file

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcacls: Move print_ace and parse_ace to common file
Christof Schmitt [Fri, 24 Apr 2015 16:22:14 +0000 (09:22 -0700)]
smbcacls: Move print_ace and parse_ace to common file

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcacls: Move StringToSid to common file
Christof Schmitt [Fri, 24 Apr 2015 16:15:13 +0000 (09:15 -0700)]
smbcacls: Move StringToSid to common file

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcacls: Move SidToString to common file
Christof Schmitt [Fri, 24 Apr 2015 15:37:13 +0000 (08:37 -0700)]
smbcacls: Move SidToString to common file

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcacls: Use defines for security flags
Christof Schmitt [Fri, 24 Apr 2015 15:51:32 +0000 (08:51 -0700)]
smbcacls: Use defines for security flags

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbcacls: Make 'numeric' a local variable
Christof Schmitt [Fri, 24 Apr 2015 15:31:41 +0000 (08:31 -0700)]
smbcacls: Make 'numeric' a local variable

This will allow moving code to a shared file without relying on a global
variable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11237

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agodocs: correctly depend on used xsl files and catalog for building manpages.t
Michael Adam [Thu, 23 Apr 2015 11:40:17 +0000 (13:40 +0200)]
docs: correctly depend on used xsl files and catalog for building manpages.t

So changes in (e.g.) our man.xsl will trigger a rebuild of the manpages.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Apr 24 15:39:31 CEST 2015 on sn-devel-104

4 years agos4-setup: Add saltPrincipal to secrets_dns.ldif
Andreas Schneider [Thu, 23 Apr 2015 16:35:51 +0000 (18:35 +0200)]
s4-setup: Add saltPrincipal to secrets_dns.ldif

This adds the correct salt principal to the secretsdb so that we
generate a valid keytab entries for AES and DES keys. The test doesn't
fails with Heimdal cause it always uses RC4 which doesn't have a salt.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlet <abartlet@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Apr 24 13:02:37 CEST 2015 on sn-devel-104

4 years agobuildtools: Use all of pyext_PATTERN in map_shlib_extension
Petr Viktorin [Wed, 12 Nov 2014 18:49:45 +0000 (19:49 +0100)]
buildtools: Use all of pyext_PATTERN in map_shlib_extension

In Python 3, C extension module filenames have an ABI tag;
the pyext_PATTERN is e.g. "%s.cpython-34m.so".
The build system was only using the last dot-separated element
of that extension (the ".so").

Use the whole extension when constructing the final filename.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Fri Apr 24 04:26:45 CEST 2015 on sn-devel-104

4 years agobuildtools: Honor LDVERSION when looking for Python library
Petr Viktorin [Wed, 12 Nov 2014 15:53:33 +0000 (16:53 +0100)]
buildtools: Honor LDVERSION when looking for Python library

Since Python 3.2, Python .so files are tagged for ABI compatibility,
so the library name is something like libpython3.4m.so (note the 'm').
This information is found in distutils.sysconfig.get_config_var('LDVERSION')

This fixes waf issue 1405 (https://code.google.com/p/waf/issues/detail?id=1405)

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agopytalloc: Add tests
Petr Viktorin [Thu, 5 Mar 2015 09:06:05 +0000 (10:06 +0100)]
pytalloc: Add tests

Add tests for pytalloc.

Since talloc objects can't be created from Python, a C extension
with helpers is added.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
4 years agowafsamba: Add install argument to SAMBA_PYTHON
Petr Viktorin [Fri, 6 Mar 2015 10:55:49 +0000 (11:55 +0100)]
wafsamba: Add install argument to SAMBA_PYTHON

This allows building Python modules that are only used for testing.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agopytalloc: Fix comparison of disparate types
Petr Viktorin [Fri, 6 Mar 2015 17:57:00 +0000 (18:57 +0100)]
pytalloc: Fix comparison of disparate types

When fed Python objects of different types, pytalloc_default_cmp
compared pointers to PyType objects that weren't part of an array,
resulting in undefined behavior.

This makes things a bit better (though it still casts ptrdiff_t to int).

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
4 years agodocs: overhaul the description of "smb encrypt" to include SMB3 encryption.
Michael Adam [Thu, 23 Apr 2015 08:38:15 +0000 (10:38 +0200)]
docs: overhaul the description of "smb encrypt" to include SMB3 encryption.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Apr 24 00:53:20 CEST 2015 on sn-devel-104

4 years agoMake sure we initialize conn to NULL, because a routine we call may give an error...
Richard Sharpe [Thu, 23 Apr 2015 19:36:28 +0000 (12:36 -0700)]
Make sure we initialize conn to NULL, because a routine we call may give an error and not touch conn, and then we get an error when trying to TALLOC_FREE it.

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agotorture: Add smb2.notify.rmdir
Volker Lendecke [Mon, 20 Apr 2015 10:44:07 +0000 (10:44 +0000)]
torture: Add smb2.notify.rmdir

We need to cancel a pending FileChangeNotify with DELETE_PENDING if the
directory watched is about to be deleted.

I know I just deleted a bool parameter, but to me torture is different :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 23 01:36:48 CEST 2015 on sn-devel-104

4 years agosmbd: Cancel pending notifies if the directory goes away
Volker Lendecke [Tue, 21 Apr 2015 08:16:16 +0000 (10:16 +0200)]
smbd: Cancel pending notifies if the directory goes away

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbd: Remove bool arg from set_delete_on_close_lck
Volker Lendecke [Tue, 21 Apr 2015 09:41:45 +0000 (11:41 +0200)]
smbd: Remove bool arg from set_delete_on_close_lck

We now have reset_delete_on_close_lck, this was called with "true"
everywhere now.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbd: Use reset_delete_on_close_lck directly
Volker Lendecke [Tue, 21 Apr 2015 09:38:32 +0000 (11:38 +0200)]
smbd: Use reset_delete_on_close_lck directly

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agosmbd: Introduce reset_delete_on_close_lck
Volker Lendecke [Tue, 21 Apr 2015 09:36:30 +0000 (11:36 +0200)]
smbd: Introduce reset_delete_on_close_lck

Boolean flags passed down make things more complex than necessary...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3:smbd: use smbd_reinit_after_fork
Ralph Boehme [Wed, 22 Apr 2015 10:00:10 +0000 (12:00 +0200)]
s3:smbd: use smbd_reinit_after_fork

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3:smbd: add wrapper around reinit_after_fork
Ralph Boehme [Wed, 22 Apr 2015 09:57:24 +0000 (11:57 +0200)]
s3:smbd: add wrapper around reinit_after_fork

smbd_reinit_after_fork is a simple wrapper around reinit_after_fork that
should be used after forking from the main smbd.

At the moment the only additional step it performs is resetting
am_parent to NULL.

A subsequent commit will make use of this function.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos4-torture: add one more test for witness_RegisterEx() and invalid sharenames.
Günther Deschner [Wed, 22 Apr 2015 11:56:35 +0000 (13:56 +0200)]
s4-torture: add one more test for witness_RegisterEx() and invalid sharenames.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Apr 22 20:21:18 CEST 2015 on sn-devel-104

4 years agos4-torture: fix invalid dereference of binding handle in mgmt test.
Günther Deschner [Tue, 21 Apr 2015 10:07:08 +0000 (12:07 +0200)]
s4-torture: fix invalid dereference of binding handle in mgmt test.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4-torture: do some additional length checks for the mgmt_inq_princ_name test.
Günther Deschner [Tue, 21 Apr 2015 09:18:30 +0000 (11:18 +0200)]
s4-torture: do some additional length checks for the mgmt_inq_princ_name test.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4-torture: use torture_assert() macros in mgmt test.
Günther Deschner [Mon, 20 Apr 2015 14:28:25 +0000 (16:28 +0200)]
s4-torture: use torture_assert() macros in mgmt test.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4-torture: use torture_comment instead of printf in mgmt test.
Günther Deschner [Mon, 20 Apr 2015 14:27:52 +0000 (16:27 +0200)]
s4-torture: use torture_comment instead of printf in mgmt test.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4-torture: pass down struct torture_context to some more calls in mgmt test.
Günther Deschner [Mon, 20 Apr 2015 13:41:44 +0000 (15:41 +0200)]
s4-torture: pass down struct torture_context to some more calls in mgmt test.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4-torture: use tctx torture_context argument consistently.
Günther Deschner [Mon, 20 Apr 2015 13:34:34 +0000 (15:34 +0200)]
s4-torture: use tctx torture_context argument consistently.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos4-torture: strip trailing whitespace.
Günther Deschner [Mon, 20 Apr 2015 13:35:14 +0000 (15:35 +0200)]
s4-torture: strip trailing whitespace.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoparam: remove two unused #defines
Michael Adam [Wed, 24 Sep 2014 08:30:17 +0000 (10:30 +0200)]
param: remove two unused #defines

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Wed Apr 22 16:37:12 CEST 2015 on sn-devel-104

4 years agos3:param: remove arg save_defaults from lp_load_with_registry_shares()
Michael Adam [Tue, 21 Apr 2015 13:24:42 +0000 (15:24 +0200)]
s3:param: remove arg save_defaults from lp_load_with_registry_shares()

This is only used in command line contexts, especially for testparm
which relies on safe defaults. The only changed use is in sharesec,
but it does not harm to also safe the defaults there.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: remove arg initialize_globals from lp_load_with_registry_shares()
Michael Adam [Tue, 21 Apr 2015 12:48:42 +0000 (14:48 +0200)]
s3:param: remove arg initialize_globals from lp_load_with_registry_shares()

This is only ever called in client context, and only called once.
So there is no point at all in requesting reinit_globals.
Set it to false.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: rename arg initialize_globals->reinit_globals in lp_load()
Michael Adam [Sat, 20 Sep 2014 02:49:10 +0000 (04:49 +0200)]
s3:param: rename arg initialize_globals->reinit_globals in lp_load()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: rename arg initialize_globals->reinit_globals in lp_load_ex()
Michael Adam [Sat, 20 Sep 2014 02:48:11 +0000 (04:48 +0200)]
s3:param: rename arg initialize_globals->reinit_globals in lp_load_ex()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: fix a comment
Michael Adam [Sat, 20 Sep 2014 02:46:41 +0000 (04:46 +0200)]
s3:param: fix a comment

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: use GLOBAL_SECTION_SNUM in lp_enforce_ad_dc_settings()
Michael Adam [Sat, 20 Sep 2014 02:45:45 +0000 (04:45 +0200)]
s3:param: use GLOBAL_SECTION_SNUM in lp_enforce_ad_dc_settings()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: factor lp_enforce_ad_dc_settings() out of lp_load_ex()
Michael Adam [Sat, 20 Sep 2014 02:42:40 +0000 (04:42 +0200)]
s3:param: factor lp_enforce_ad_dc_settings() out of lp_load_ex()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: in lp_load_initial_only(), make sure to save defaults.
Michael Adam [Wed, 6 Aug 2014 14:20:42 +0000 (16:20 +0200)]
s3:param: in lp_load_initial_only(), make sure to save defaults.

This is the initial loading of the config in the daemons (and some tools).
So we should save the defaults here. This should especially take into account
some dynamic defaults like log file and maybe some changed values
handed in via the command line.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: make lp_load() static
Michael Adam [Thu, 18 Sep 2014 02:19:10 +0000 (04:19 +0200)]
s3:param: make lp_load() static

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agovfstest: use lp_load_with_shares() in cmd_conf
Michael Adam [Thu, 18 Sep 2014 02:16:56 +0000 (04:16 +0200)]
vfstest: use lp_load_with_shares() in cmd_conf

Note this calls lp_load slightly differently.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: use lp_load_no_reinit() in lp_load_for_s4_ctx()
Michael Adam [Wed, 17 Sep 2014 22:29:28 +0000 (00:29 +0200)]
s3:param: use lp_load_no_reinit() in lp_load_for_s4_ctx()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: add lp_load_no_reinit()
Michael Adam [Wed, 17 Sep 2014 22:28:50 +0000 (00:28 +0200)]
s3:param: add lp_load_no_reinit()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:torture:msg: use lp_load()-wrapper lp_load_global()
Michael Adam [Tue, 9 Sep 2014 21:22:50 +0000 (23:22 +0200)]
s3:torture:msg: use lp_load()-wrapper lp_load_global()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos4:torture:libnetapi: use lp_load_global() instead of lp_load()
Michael Adam [Wed, 30 Jul 2014 22:42:01 +0000 (00:42 +0200)]
s4:torture:libnetapi: use lp_load_global() instead of lp_load()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: remove "add_ipc" parameter from lp_load_with_registry_shares().
Michael Adam [Wed, 30 Jul 2014 15:47:32 +0000 (17:47 +0200)]
s3:param: remove "add_ipc" parameter from lp_load_with_registry_shares().

This is not called from the server (which loads registry shares lazily),
so add_ipc is always false...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: remove "global_only" parameter from lp_load_with_registry_shares().
Michael Adam [Wed, 30 Jul 2014 15:30:22 +0000 (17:30 +0200)]
s3:param: remove "global_only" parameter from lp_load_with_registry_shares().

There is no point in choosing global_only when forcing to load
all shares from registry at the same time...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:auth: use lp_load_with_shares() in auth3_check_password()
Michael Adam [Wed, 30 Jul 2014 15:00:36 +0000 (17:00 +0200)]
s3:auth: use lp_load_with_shares() in auth3_check_password()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:auth: use lp_load_with_shares() in auth3_generate_session_info_pac()
Michael Adam [Wed, 30 Jul 2014 14:59:50 +0000 (16:59 +0200)]
s3:auth: use lp_load_with_shares() in auth3_generate_session_info_pac()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agonsswitch/wins: use lp_load_global() wrapper of lp_load().
Michael Adam [Wed, 30 Jul 2014 14:57:06 +0000 (16:57 +0200)]
nsswitch/wins: use lp_load_global() wrapper of lp_load().

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:smbd: use lp_load_with_shares() in reload_services().
Michael Adam [Wed, 30 Jul 2014 14:53:59 +0000 (16:53 +0200)]
s3:smbd: use lp_load_with_shares() in reload_services().

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: let lp_load_global_no_reinit() call lp_load() instead of lp_load_ex()
Michael Adam [Wed, 30 Jul 2014 14:52:06 +0000 (16:52 +0200)]
s3:param: let lp_load_global_no_reinit() call lp_load() instead of lp_load_ex()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: add wrapper lp_load_with_shares().
Michael Adam [Wed, 30 Jul 2014 14:50:48 +0000 (16:50 +0200)]
s3:param: add wrapper lp_load_with_shares().

Most common pattern with shares, including IPC,
but not forcing immediate loading of all registry shares.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:param: let lp_load_global() call lp_load(), not lp_load_ex().
Michael Adam [Wed, 30 Jul 2014 14:47:40 +0000 (16:47 +0200)]
s3:param: let lp_load_global() call lp_load(), not lp_load_ex().

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:lsasd: use lp_load() wrapper lp_load_global()
Michael Adam [Wed, 30 Jul 2014 14:43:05 +0000 (16:43 +0200)]
s3:lsasd: use lp_load() wrapper lp_load_global()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agos3:spoolss: use lp_load() wrapper lp_load_global().
Michael Adam [Wed, 30 Jul 2014 14:41:22 +0000 (16:41 +0200)]
s3:spoolss: use lp_load() wrapper lp_load_global().

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agoConvert all uses of uint8/16/32 to uint8/16/32_t in the libads code.
Richard Sharpe [Sat, 18 Apr 2015 15:40:14 +0000 (08:40 -0700)]
Convert all uses of uint8/16/32 to uint8/16/32_t in the libads code.

Signed-off-by: Richard Sharpe <rsharpe@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 22 06:22:29 CEST 2015 on sn-devel-104

4 years agosmbd: Save a few lines of C :-)
Volker Lendecke [Sat, 18 Apr 2015 09:28:36 +0000 (09:28 +0000)]
smbd: Save a few lines of C :-)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3-unix_msg: remove socket file after closing socket fd
Youzhong Yang [Mon, 20 Apr 2015 13:42:42 +0000 (09:42 -0400)]
s3-unix_msg: remove socket file after closing socket fd

This is needed on Solaris.

It fixes https://bugzilla.samba.org/show_bug.cgi?id=11217

Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Apr 22 03:43:30 CEST 2015 on sn-devel-104

4 years agos3:smbd: update comment to correctly reflect MS-SMB2
Ralph Boehme [Fri, 17 Apr 2015 07:12:59 +0000 (09:12 +0200)]
s3:smbd: update comment to correctly reflect MS-SMB2

Signed-off-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 22 01:04:02 CEST 2015 on sn-devel-104

4 years agos3:smbd: missing tevent_req_nterror
Ralph Boehme [Thu, 16 Apr 2015 20:28:25 +0000 (22:28 +0200)]
s3:smbd: missing tevent_req_nterror

The error code path in case fsp == NULL misses a call
tevent_req_nterror().

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
4 years agos3:lib: use talloc_get_type_abort
Ralph Boehme [Tue, 21 Apr 2015 16:58:09 +0000 (18:58 +0200)]
s3:lib: use talloc_get_type_abort

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Apr 21 22:14:07 CEST 2015 on sn-devel-104

4 years agolib: Fix CID 1107218 Resource leak
Volker Lendecke [Tue, 31 Mar 2015 19:24:45 +0000 (21:24 +0200)]
lib: Fix CID 1107218 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agotevent: Fix CID 1035381 Unchecked return value
Volker Lendecke [Tue, 31 Mar 2015 19:15:53 +0000 (21:15 +0200)]
tevent: Fix CID 1035381 Unchecked return value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agolib: Fix a few CIDs for Resource Leak
Volker Lendecke [Tue, 31 Mar 2015 07:34:54 +0000 (09:34 +0200)]
lib: Fix a few CIDs for Resource Leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoctdb: Fix the O3 developer build
Volker Lendecke [Tue, 21 Apr 2015 08:34:54 +0000 (10:34 +0200)]
ctdb: Fix the O3 developer build

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agoAdd refentryinfo date.
Jelmer Vernooij [Sat, 18 Apr 2015 21:18:48 +0000 (21:18 +0000)]
Add refentryinfo date.

This causes the talloc.3 build to be reproducible. We're trying to
make all builds in Debian reproducible - see
https://wiki.debian.org/ReproducibleBuilds/About for reasoning.

Change-Id: I9bd64d1783abfb33211cbc9dc9c2bbf6db047f3e
Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun Apr 19 03:05:53 CEST 2015 on sn-devel-104

4 years agolibads: Fix CID 1272956 Fixing wrong if condition
Anoop C S [Wed, 15 Apr 2015 11:04:35 +0000 (16:34 +0530)]
libads: Fix CID 1272956 Fixing wrong if condition

Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Apr 18 01:33:04 CEST 2015 on sn-devel-104

4 years agorpc_server/srvsvc: Fix CID 241162 Logically dead code
Anoop C S [Wed, 15 Apr 2015 10:26:42 +0000 (15:56 +0530)]
rpc_server/srvsvc: Fix CID 241162 Logically dead code

Signed-off-by: Anoop C S <achiraya@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
4 years agos3: locking: Add a memcache based lock cache.
Jeremy Allison [Wed, 15 Apr 2015 17:36:00 +0000 (10:36 -0700)]
s3: locking: Add a memcache based lock cache.

Based on an idea by Volker to optimize cpu usage when
parsing struct share_mode_data entries.

Add a 64-bit sequence number to the share mode entry,
and after the entry is stored back in the db, cache
the in-memory version using talloc reparenting into the
memcache. The memcache key used is the same struct file_id
used as the key into the locking db.

On read, check if the locking db version sequence number
matches the in-memory cache, and if so reparent the
memcache version back onto the required memory context.

Saves all the ndr decoding when multiple accesses to the
same lock entry happen in succession.

Design also improved by Metze and Ira.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Apr 17 22:38:34 CEST 2015 on sn-devel-104

4 years agolib: memcache. Add a new talloc cache type - SHARE_MODE_LOCK_CACHE.
Jeremy Allison [Thu, 2 Apr 2015 18:19:22 +0000 (11:19 -0700)]
lib: memcache. Add a new talloc cache type - SHARE_MODE_LOCK_CACHE.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
4 years agovfs_fruit: also map characters below 0x20
Björn Jacke [Wed, 15 Apr 2015 19:48:27 +0000 (21:48 +0200)]
vfs_fruit: also map characters below 0x20

we need to map 0x01-0x1F to 0xF001-0xF01F as 0x01-0x1F are win32 illegal
characters.

see https://support.microsoft.com/en-us/kb/kbview/117258

Even if the MS KB article writes "invalid ntfs characters" they are actually
not illegal in ntfs, just in the win32 API.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11221

Signed-off-by: Bjoern Jacke <bj@sernet.de>
Reviewed-by: Ralf Böhme <slow@samba.org>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri Apr 17 20:00:48 CEST 2015 on sn-devel-104

4 years agoctdb: Coverity fix for CID 1125630
Rajesh Joseph [Thu, 16 Apr 2015 06:25:53 +0000 (11:55 +0530)]
ctdb: Coverity fix for CID 1125630

Due to usage of CTDB_NO_MEMORY macro,
some of the resources are not freed in failure cases.

Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Apr 17 16:49:05 CEST 2015 on sn-devel-104

4 years agoctdb: Coverity fix for CID 1125625
Rajesh Joseph [Thu, 16 Apr 2015 06:55:28 +0000 (12:25 +0530)]
ctdb: Coverity fix for CID 1125625

Memory allocated by ctdb_sys_find_ifname is not
freed by the caller.

Signed-off-by: Rajesh Joseph <rjoseph@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
4 years agos3-passdb: fix memleak in pdb_default_get_trusted_domain().
Günther Deschner [Mon, 30 Mar 2015 10:32:20 +0000 (12:32 +0200)]
s3-passdb: fix memleak in pdb_default_get_trusted_domain().

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>