From 937b466266256d26d02cf8d48e72a26272fe8627 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 9 Sep 2008 16:18:27 +1000 Subject: [PATCH 1/1] Fix bug #5713 by correcting the generated schema. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This bug is entitled 'Schema patch breaks interoperability with Microsoft MMC consoles.', and it does so very spectacularly. The issue is that we would include an entry: objectClasses: ( 2.5.6.0 NAME 'top' SUP top ABSTRACT.. The MMC Active Directory Users and Computers snap in presumably objected to the 'loop' this would present. The fixed entry is: objectClasses: ( 2.5.6.0 NAME 'top' ABSTRACT Thanks to Matthias Dieter Wallnöfer for his persistance in getting me to look at this. Andrew Bartlett --- source/dsdb/schema/schema_description.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/dsdb/schema/schema_description.c b/source/dsdb/schema/schema_description.c index 9d93af9260a..d780fcf34f8 100644 --- a/source/dsdb/schema/schema_description.c +++ b/source/dsdb/schema/schema_description.c @@ -182,7 +182,7 @@ char *schema_class_description(TALLOC_CTX *mem_ctx, IF_NULL_FAIL_RET(schema_entry); } - if (subClassOf) { + if (subClassOf && strcasecmp(subClassOf, name) == 0) { schema_entry = talloc_asprintf_append(schema_entry, "SUP %s%s", subClassOf, seperator); IF_NULL_FAIL_RET(schema_entry); -- 2.34.1