From 840cdfa2fabbb48d2f18dc3cea65ff8123bf6ca9 Mon Sep 17 00:00:00 2001 From: Brad Hards Date: Tue, 24 Nov 2009 13:43:59 +1100 Subject: [PATCH 1/1] s4:param remove reference to private header from source4/param/param.h source4/param/param.h has a param.h is a public header (and parmlist isn't, even if the relative path could work), so I suggest making it a forward declaration in the header, and including parmlist.h in the implementation. (commit message included from e-mail by Andrew Bartlett) Signed-off-by: Andrew Bartlett --- source4/param/generic.c | 1 + source4/param/loadparm.c | 1 + source4/param/param.h | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/source4/param/generic.c b/source4/param/generic.c index 41d01de9d38..29b97bc09ed 100644 --- a/source4/param/generic.c +++ b/source4/param/generic.c @@ -18,6 +18,7 @@ #include "includes.h" #include "../lib/util/dlinklist.h" +#include "../lib/util/parmlist.h" #include "param/param.h" #include "param/loadparm.h" #include "system/filesys.h" diff --git a/source4/param/loadparm.c b/source4/param/loadparm.c index f2e4ace122c..d65c3f9b16f 100644 --- a/source4/param/loadparm.c +++ b/source4/param/loadparm.c @@ -61,6 +61,7 @@ #include "smb_server/smb_server.h" #include "libcli/raw/signing.h" #include "../lib/util/dlinklist.h" +#include "../lib/util/parmlist.h" #include "param/param.h" #include "param/loadparm.h" #include "libcli/raw/libcliraw.h" diff --git a/source4/param/param.h b/source4/param/param.h index 3ce5e93acf5..52224252a0a 100644 --- a/source4/param/param.h +++ b/source4/param/param.h @@ -20,7 +20,7 @@ #ifndef _PARAM_H /* _PARAM_H */ #define _PARAM_H -#include "../lib/util/parmlist.h" +struct parmlist_entry; struct param_context { struct param_section *sections; -- 2.34.1