Modified revamp of the libsmbclient interface.
authorDerrell Lipman <derrell.lipman@unwireduniverse.com>
Fri, 29 Feb 2008 18:34:35 +0000 (13:34 -0500)
committerKarolin Seeger <ks@sernet.de>
Tue, 4 Mar 2008 07:58:14 +0000 (08:58 +0100)
commit7bc53f57dcb1c3bb80cb20796ebfc743c22a76e3
treeee3b64b3d1c16c0339decb0a1ef05ee4d9632929
parent59292c0da8880afd7bac82f6a5bba009f3827ea0
Modified revamp of the libsmbclient interface.

Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach.  This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility.  I retain, here, the setter and getter functions which all new
code should use.  Older programs already compiled should continue to work
fine.  Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.

Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval.  I hope that this compromise is adequate.

Derrell
(cherry picked from commit 56429a3d60b2a48963342f6340b3c01469a892c6)
source/include/libsmb_internal.h
source/include/libsmbclient.h
source/libsmb/libsmb_cache.c
source/libsmb/libsmb_context.c
source/libsmb/libsmb_dir.c
source/libsmb/libsmb_file.c
source/libsmb/libsmb_path.c
source/libsmb/libsmb_printjob.c
source/libsmb/libsmb_server.c
source/libsmb/libsmb_stat.c
source/libsmb/libsmb_xattr.c