kai/samba.git
9 years agos4-krb5: Fix typos in comment.
Karolin Seeger [Fri, 9 Apr 2010 07:23:54 +0000 (09:23 +0200)]
s4-krb5: Fix typos in comment.

Karolin

9 years agoStop smb2 from calling into smb1 blocking lock request code.
Jeremy Allison [Fri, 9 Apr 2010 05:15:55 +0000 (22:15 -0700)]
Stop smb2 from calling into smb1 blocking lock request code.

Allocate a uint16_t internal SMB1 mid for an SMB2 request.
Add a back pointer from the faked up smb_request struct
to the smb2 request.

Getting ready to add restart code for blocking locks,
share mode violations and oplocks in SMB2.

Jeremy.

9 years agoSimplify call_trans2qfilepathinfo() and smbd_do_qfilepathinfo()
Jeremy Allison [Fri, 9 Apr 2010 04:24:23 +0000 (21:24 -0700)]
Simplify call_trans2qfilepathinfo() and smbd_do_qfilepathinfo()

Remove the bool ms_dfs_link parameter from smbd_do_qfilepathinfo.
It is not possible for this to be a DFS link. Remove the check_msdfs_link()
call from call_trans2qfilepathinfo() - the call to filename_convert()
above with a ucf_flags of zero *MUST* catch a DFS link and return
NT_STATUS_PATH_NOT_COVERED in this case, so the code below checking
for msdfs links is redundent. Don't add this to 3.5.x, as it's an
optimization but not needed to fix bug #7339 - MSDFS is non-functional in 3.5.x.

Jeremy.

9 years agoFix bug #7339 - MSDFS is non-functional in 3.5.x
Jeremy Allison [Fri, 9 Apr 2010 03:32:36 +0000 (20:32 -0700)]
Fix bug #7339 - MSDFS is non-functional in 3.5.x

In the refactoring around filename_convert, the split between the functions
resolve_dfspath() and resolve_dfspath_wcard() was lost, leaving us only with
resolve_dfspath_wcard().

Internally resolve_dfspath_wcard() calls dfs_redirect() only with a
"allow_wcards" flag of true, wheras the old resolve_dfspath() would call with a
value of false. The loss of this case causes dfs_redirect to always masquerade
DFS links as directories, even when they are being queried directly by a trans2
QPATHINFO call. We should only masquerade DFS links as directories when called
from a SMBsearch or trans2 findfirst/findnext - which was the intent of the
"allow_wcards" flag.

This patch adds back an allow_wcards bool parameter to
resolve_dfspath_wcard(). This bool is set from the state of the ucf_flags when
filename_convert() is called.

I will follow this up with a new smbclient-based torture test that will prevent
us from ever regressing our DFS support again.

Jeremy.

9 years agos4/torture: Suppress Valgrind warnings
Kamen Mazdrashki [Mon, 29 Mar 2010 21:13:46 +0000 (00:13 +0300)]
s4/torture: Suppress Valgrind warnings

This patch suppresses two Valgrind warnings of type
"xxx bytes in yy blocks are indirectly lost in loss record"

9 years agos4-winreg: add winreg_DeleteKeyEx stub.
Günther Deschner [Thu, 8 Apr 2010 22:11:57 +0000 (00:11 +0200)]
s4-winreg: add winreg_DeleteKeyEx stub.

Guenther

9 years agos3-winreg: add winreg_DeleteKeyEx stub.
Günther Deschner [Thu, 8 Apr 2010 22:11:41 +0000 (00:11 +0200)]
s3-winreg: add winreg_DeleteKeyEx stub.

Guenther

9 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 8 Apr 2010 22:11:00 +0000 (00:11 +0200)]
s3: re-run make samba3-idl.

Guenther

9 years agowinreg: add IDL for winreg_DeleteKeyEx.
Günther Deschner [Thu, 8 Apr 2010 22:10:07 +0000 (00:10 +0200)]
winreg: add IDL for winreg_DeleteKeyEx.

Guenther

9 years agos4:registry - "patchfile_preg.c" - assign a better type to the "i" counter variable
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 21:43:50 +0000 (23:43 +0200)]
s4:registry - "patchfile_preg.c" - assign a better type to the "i" counter variable

The "i" variable sums up "size" values which are of type "size_t". Therefore
also "i" itself should be from this type.

9 years agos4:registry - "patchfile_preg.c" - make a SIVAL statement nicer
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 21:42:23 +0000 (23:42 +0200)]
s4:registry - "patchfile_preg.c" - make a SIVAL statement nicer

9 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 8 Apr 2010 21:47:04 +0000 (23:47 +0200)]
s3: re-run make samba3-idl.

Guenther

9 years agowinreg: fill in some winreg IDL gaps.
Günther Deschner [Thu, 8 Apr 2010 21:46:15 +0000 (23:46 +0200)]
winreg: fill in some winreg IDL gaps.

Guenther

9 years agos4-net: Convert 'net time' to python.
Jelmer Vernooij [Thu, 8 Apr 2010 21:41:08 +0000 (23:41 +0200)]
s4-net: Convert 'net time' to python.

9 years agonet: Convert time command to python.
Jelmer Vernooij [Mon, 1 Mar 2010 21:33:01 +0000 (22:33 +0100)]
net: Convert time command to python.

9 years agos4-net: Use new Net() object in net export keytab.
Jelmer Vernooij [Thu, 8 Apr 2010 20:59:16 +0000 (22:59 +0200)]
s4-net: Use new Net() object in net export keytab.

9 years agopynet: Create a net class.
Jelmer Vernooij [Mon, 1 Mar 2010 21:23:45 +0000 (22:23 +0100)]
pynet: Create a net class.

9 years agos4-python: Fix formatting, use standard convention to call instance methods.
Jelmer Vernooij [Thu, 8 Apr 2010 21:18:17 +0000 (23:18 +0200)]
s4-python: Fix formatting, use standard convention to call instance methods.

9 years agos4-python: Cancel transaction properly in case of exceptions, fix formatting.
Jelmer Vernooij [Thu, 8 Apr 2010 20:14:50 +0000 (22:14 +0200)]
s4-python: Cancel transaction properly in case of exceptions, fix formatting.

9 years agos4-python: Move load_partition_usn to dsdb module.
Jelmer Vernooij [Thu, 8 Apr 2010 20:07:42 +0000 (22:07 +0200)]
s4-python: Move load_partition_usn to dsdb module.

9 years agos4-python: More cleanups.
Jelmer Vernooij [Thu, 8 Apr 2010 19:01:17 +0000 (21:01 +0200)]
s4-python: More cleanups.

9 years agos4-python: rename samba.glue to samba._glue to indicate it's private.
Jelmer Vernooij [Thu, 8 Apr 2010 18:34:40 +0000 (20:34 +0200)]
s4-python: rename samba.glue to samba._glue to indicate it's private.

9 years agos4-python: Fix formatting, import of FLG_NOSYNC.
Jelmer Vernooij [Thu, 8 Apr 2010 18:28:11 +0000 (20:28 +0200)]
s4-python: Fix formatting, import of FLG_NOSYNC.

9 years agos4-python: Simplify code, improve formatting.
Jelmer Vernooij [Thu, 8 Apr 2010 16:57:09 +0000 (18:57 +0200)]
s4-python: Simplify code, improve formatting.

9 years agos4-python: Remove obsolete and broken torture modules.
Jelmer Vernooij [Thu, 8 Apr 2010 16:53:14 +0000 (18:53 +0200)]
s4-python: Remove obsolete and broken torture modules.

The functionality of these modules is already present in a more current
form in other modules.

9 years agotestr: Use waf test runner.
Jelmer Vernooij [Thu, 8 Apr 2010 14:49:24 +0000 (16:49 +0200)]
testr: Use waf test runner.

9 years agoselftest: Add --filtered-subunit option.
Jelmer Vernooij [Thu, 8 Apr 2010 14:48:33 +0000 (16:48 +0200)]
selftest: Add --filtered-subunit option.

9 years agoselftest: Support --load-list option.
Jelmer Vernooij [Thu, 8 Apr 2010 14:16:15 +0000 (16:16 +0200)]
selftest: Support --load-list option.

9 years agos4-waf: Support --load-list option.
Jelmer Vernooij [Thu, 8 Apr 2010 13:24:33 +0000 (15:24 +0200)]
s4-waf: Support --load-list option.

9 years agos4-python: samdb: Default to using global schema.
Jelmer Vernooij [Thu, 8 Apr 2010 13:08:27 +0000 (15:08 +0200)]
s4-python: samdb: Default to using global schema.

9 years agos4:dsdb - Handle INVALID_DN_SYNTAX from OpenLDAP in dsdb_module_load_partition_usn().
Endi S. Dewata [Sun, 28 Mar 2010 02:46:27 +0000 (21:46 -0500)]
s4:dsdb - Handle INVALID_DN_SYNTAX from OpenLDAP in dsdb_module_load_partition_usn().

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agoUpdate waf build.
Jelmer Vernooij [Thu, 8 Apr 2010 20:46:02 +0000 (22:46 +0200)]
Update waf build.

9 years agoMigrate 'net export keytab' to python.
Jelmer Vernooij [Mon, 1 Mar 2010 19:43:19 +0000 (20:43 +0100)]
Migrate 'net export keytab' to python.

9 years agos3-lanman: use spoolss for api_RDosPrintJobDel().
Günther Deschner [Thu, 18 Mar 2010 18:19:28 +0000 (19:19 +0100)]
s3-lanman: use spoolss for api_RDosPrintJobDel().

Guenther

9 years agos3-lanman: use spoolss for api_WPrintQueueCtrl().
Günther Deschner [Thu, 18 Mar 2010 17:13:40 +0000 (18:13 +0100)]
s3-lanman: use spoolss for api_WPrintQueueCtrl().

Guenther

9 years agos3-registry: fix fill_in_printer_values() for datatype and printprocessor.
Günther Deschner [Thu, 8 Apr 2010 14:20:46 +0000 (16:20 +0200)]
s3-registry: fix fill_in_printer_values() for datatype and printprocessor.

It is wise and good to enforce RAW and winprint, but we need to be consistent
with spoolss (and enforce it there).

Found by torture test.

Guenther

9 years agos4-smbtorture: protect against full UNC paths in winreg printerinfo test.
Günther Deschner [Thu, 8 Apr 2010 14:09:36 +0000 (16:09 +0200)]
s4-smbtorture: protect against full UNC paths in winreg printerinfo test.

Guenther

9 years agos4:registry - "REGF backend" - don't ignore wrong-sized REG_DWORD/REG_DWORD_BIG_ENDIA...
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 13:19:07 +0000 (15:19 +0200)]
s4:registry - "REGF backend" - don't ignore wrong-sized REG_DWORD/REG_DWORD_BIG_ENDIAN values

9 years agos3: Remove the separate "child" argument from setup_domain_child()
Volker Lendecke [Wed, 7 Apr 2010 15:50:19 +0000 (17:50 +0200)]
s3: Remove the separate "child" argument from setup_domain_child()

9 years agos4-smbtorture: add PrinterInfo level 2 / winreg consistency test.
Günther Deschner [Thu, 8 Apr 2010 13:00:34 +0000 (15:00 +0200)]
s4-smbtorture: add PrinterInfo level 2 / winreg consistency test.

This compares PrinterInfo2 with contents of
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Print\Printers\printername and
HKLM\SYSTEM\CurrentControlSet\Control\Print\Printers\printername

Guenther

9 years agos4-smbtorture: minor cleanup, use data_blob_talloc_zero() in RPC-SPOOLSS.
Günther Deschner [Thu, 8 Apr 2010 09:56:27 +0000 (11:56 +0200)]
s4-smbtorture: minor cleanup, use data_blob_talloc_zero() in RPC-SPOOLSS.

Guenther

9 years agos4:WAF buildsystem - support out of "source4" directory builds
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 10:38:17 +0000 (12:38 +0200)]
s4:WAF buildsystem - support out of "source4" directory builds

Bug: https://bugzilla.samba.org/show_bug.cgi?id=4081

With this patch we are able to invoke s4 builds from the outside of the
"source4" directory (but the target remains the "source4/bin" path).

One constraint: all commands: "autogen-waf.sh", "configure", "make" have to be
run from the same directory!
Regarding "make": you have to run it using "make -C <source4 path> [targets]" if
the invoke directory is not "source4" itself.

9 years agobuild: we need this isinstance() check for distcheck
Andrew Tridgell [Thu, 8 Apr 2010 12:10:22 +0000 (22:10 +1000)]
build: we need this isinstance() check for distcheck

Jelmer, this works around a bug in waf distcheck that will be fixed
soon. We really need the isinstance() check for now.

9 years agobuild: the exceptions here are not useful
Andrew Tridgell [Thu, 8 Apr 2010 12:01:27 +0000 (22:01 +1000)]
build: the exceptions here are not useful

they just make the failure hard to spot

9 years agobuild: make the handling of relative paths a bit saner
Andrew Tridgell [Thu, 8 Apr 2010 11:46:20 +0000 (21:46 +1000)]
build: make the handling of relative paths a bit saner

This should fix a problem that Anatoliy has struck with the PIDL
rules. It also brings us much closer to a working build for a true out
of tree build (ie. with waf configure -b /tmp/build)

9 years agos3:winbindd: make "smbcontrol winbindd validate-cache" reliable again
Stefan Metzmacher [Thu, 8 Apr 2010 10:45:54 +0000 (12:45 +0200)]
s3:winbindd: make "smbcontrol winbindd validate-cache" reliable again

commit 73577205cf81644e7fe853eaf3e6459f7f443096
(s3:winbindd: fix problems with SIGCHLD handling (bug #7317))
broke this.

metze

9 years agos4:registry - "patchfile_preg.c" - fix the read operation of the data length on big...
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 10:25:34 +0000 (12:25 +0200)]
s4:registry - "patchfile_preg.c" - fix the read operation of the data length on big-endian platforms

9 years agos4:registry - "patchfile_preg.c" - use "sizeof(uint32_t)" for some size specifications
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 10:20:51 +0000 (12:20 +0200)]
s4:registry - "patchfile_preg.c" - use "sizeof(uint32_t)" for some size specifications

Looks nicer.

9 years agos4-net: Simplify SamDB connect code.
Jelmer Vernooij [Thu, 8 Apr 2010 10:19:51 +0000 (12:19 +0200)]
s4-net: Simplify SamDB connect code.

9 years agos4-python: Move set_global_schema to pydsdb.
Jelmer Vernooij [Thu, 8 Apr 2010 01:26:39 +0000 (03:26 +0200)]
s4-python: Move set_global_schema to pydsdb.

9 years agos4-waf: Add dist target.
Jelmer Vernooij [Wed, 7 Apr 2010 21:57:23 +0000 (23:57 +0200)]
s4-waf: Add dist target.

9 years agos3: Fix a typo
Volker Lendecke [Thu, 8 Apr 2010 08:40:40 +0000 (10:40 +0200)]
s3: Fix a typo

9 years agotsocket_bsd: Always use a real length for the sa_socklen, and keep it around
Andrew Bartlett [Wed, 7 Apr 2010 00:42:37 +0000 (10:42 +1000)]
tsocket_bsd: Always use a real length for the sa_socklen, and keep it around

The previous code assumed the OS would happily accept sizeof(struct
sockaddr_storage).  It seems some versions of Solaris do not like
this.

Andrew Bartlett

9 years agoRevert "socket-wrapper: not all systems have FIONREAD defined"
Stefan Metzmacher [Wed, 7 Apr 2010 13:21:32 +0000 (15:21 +0200)]
Revert "socket-wrapper: not all systems have FIONREAD defined"

This reverts commit 710aa773d54509de34404f9992c5058ddfa45f3b.

We rely on FIONREAD in a lot of other parts in the code,
so there's no need to have an ifdef for it in the socket_wrapper code.

On tru64 FIONREAD is defined in <sys/ioctl.h>
and we include <sys/ioctl.h> via "system/network.h".

Tridge: maybe a HAVE_SYS_IOCTL_H was missing at the time you tried
it on tru64?

If we find a platform that doesn't support it,
we need to bail out at configure time or
provide a replacement in libreplace.

metze

9 years agoStart to plumb smb2 into the oplock system. Calls dummy functions for now.
Jeremy Allison [Thu, 8 Apr 2010 02:00:44 +0000 (19:00 -0700)]
Start to plumb smb2 into the oplock system. Calls dummy functions for now.

Jeremy.

9 years agos4-smbtorture: minor typo in SetJob test in RPC-SPOOLSS.
Günther Deschner [Wed, 7 Apr 2010 21:40:17 +0000 (23:40 +0200)]
s4-smbtorture: minor typo in SetJob test in RPC-SPOOLSS.

Guenther

9 years agos3-spoolss: Fix an issue in _spoolss_DeleteForm.
Günther Deschner [Wed, 7 Apr 2010 21:36:48 +0000 (23:36 +0200)]
s3-spoolss: Fix an issue in _spoolss_DeleteForm.

Found by torture test.

Guenther

9 years agos3-spoolss: Fix some issues in _spoolss_AddForm.
Günther Deschner [Wed, 7 Apr 2010 21:36:15 +0000 (23:36 +0200)]
s3-spoolss: Fix some issues in _spoolss_AddForm.

Found by torture test.

Guenther

9 years agos3-spoolss: Fix potential memleak in _spoolss_AddForm and _spoolss_SetForm.
Günther Deschner [Wed, 7 Apr 2010 21:34:36 +0000 (23:34 +0200)]
s3-spoolss: Fix potential memleak in _spoolss_AddForm and _spoolss_SetForm.

Guenther

9 years agobuild: allow the waf build to work with python 3.0 and 3.1
Thomas Nagy [Wed, 7 Apr 2010 21:45:46 +0000 (07:45 +1000)]
build: allow the waf build to work with python 3.0 and 3.1

Python 3.x is a bit fussier about print statements and indentation.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
9 years agoLDB:sample_module - reintroduce accidentally removed "ldb_msg_add_fmt" statement
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 21:00:42 +0000 (23:00 +0200)]
LDB:sample_module - reintroduce accidentally removed "ldb_msg_add_fmt" statement

Obviously this is really needed by the "samba4.ldb" test.

9 years agos4-waf: Fix 'waf dist' app name.
Jelmer Vernooij [Wed, 7 Apr 2010 20:52:28 +0000 (22:52 +0200)]
s4-waf: Fix 'waf dist' app name.

9 years agoMove configure_check_unused script to root scriptdir, as it is useful
Jelmer Vernooij [Wed, 7 Apr 2010 20:17:34 +0000 (22:17 +0200)]
Move configure_check_unused script to root scriptdir, as it is useful
for both s3 and s4.

9 years agos4: Remove unused pkg-config replacement in perl.
Jelmer Vernooij [Wed, 7 Apr 2010 20:15:27 +0000 (22:15 +0200)]
s4: Remove unused pkg-config replacement in perl.

9 years agoupdate-external: Support updating dnspython.
Jelmer Vernooij [Wed, 7 Apr 2010 20:13:34 +0000 (22:13 +0200)]
update-external: Support updating dnspython.

9 years agos3: Fix bug 7327 -- Build fails while building without kerberos
Volker Lendecke [Wed, 7 Apr 2010 20:28:28 +0000 (22:28 +0200)]
s3: Fix bug 7327 -- Build fails while building without kerberos

libsmb/clikrb5.c has a dummy implementation for the non-kerberos case

9 years agoselftest: Display minutes and hours for duration.
Jelmer Vernooij [Wed, 7 Apr 2010 15:54:57 +0000 (17:54 +0200)]
selftest: Display minutes and hours for duration.

9 years agoLDB:python bindings - also empty LDB message elements should have a python representation
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 18:40:06 +0000 (20:40 +0200)]
LDB:python bindings - also empty LDB message elements should have a python representation

Bug found by ekacnet (see technical mailing list).

9 years agos4:registry - "regf backend" - fix it up regarding REG_DWORD/REG_DWORD_BIG_ENDIAN_VALUES
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 18:14:46 +0000 (20:14 +0200)]
s4:registry - "regf backend" - fix it up regarding REG_DWORD/REG_DWORD_BIG_ENDIAN_VALUES

This is needed to make it platform independently work (also on big endian
platforms as little endian).

Also add a size check before storing a DWORD.

9 years agos4:winbind/wb_server.c - fix indentation
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 16:54:42 +0000 (18:54 +0200)]
s4:winbind/wb_server.c - fix indentation

9 years agoTest using (-1) for tid and sessionid in compound related requests.
Jeremy Allison [Wed, 7 Apr 2010 17:33:02 +0000 (10:33 -0700)]
Test using (-1) for tid and sessionid in compound related requests.

Jeremy.

9 years agoOn compound requests, MS-SMB2 says clients MAY use 0xFFFFFFFF for compound tid and...
Jeremy Allison [Wed, 7 Apr 2010 17:32:01 +0000 (10:32 -0700)]
On compound requests, MS-SMB2 says clients MAY use 0xFFFFFFFF for compound tid and 0xFFFFFFFFFFFFFFFF for compound sessionid values. Cope with this.

Jeremy.

9 years agoDon't forget to initialize *p_creds_requested.
Jeremy Allison [Wed, 7 Apr 2010 17:31:43 +0000 (10:31 -0700)]
Don't forget to initialize *p_creds_requested.

Jeremy.

9 years agos4-samdb: Allow skipping global schema.
Jelmer Vernooij [Wed, 7 Apr 2010 10:11:12 +0000 (12:11 +0200)]
s4-samdb: Allow skipping global schema.

9 years agos4-provision: Proper handling of exceptions, use SamDB class but skip global schema.
Jelmer Vernooij [Wed, 7 Apr 2010 10:10:09 +0000 (12:10 +0200)]
s4-provision: Proper handling of exceptions, use SamDB class but skip global schema.

9 years agos4-python: Move samdb_ntds_objectGUID to pydsdb.
Jelmer Vernooij [Sun, 4 Apr 2010 01:30:03 +0000 (03:30 +0200)]
s4-python: Move samdb_ntds_objectGUID to pydsdb.

9 years agourgent_replication: Use standard comments rather than docstrings.
Jelmer Vernooij [Sun, 4 Apr 2010 01:08:05 +0000 (03:08 +0200)]
urgent_replication: Use standard comments rather than docstrings.

9 years agos3-spoolss: Added a winreg_getform1 function.
Andreas Schneider [Thu, 1 Apr 2010 10:45:58 +0000 (12:45 +0200)]
s3-spoolss: Added a winreg_getform1 function.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a winreg_setform1 function.
Andreas Schneider [Thu, 1 Apr 2010 09:51:59 +0000 (11:51 +0200)]
s3-spoolss: Added a winreg_setform1 function.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a winreg_deleteform1 function.
Andreas Schneider [Wed, 31 Mar 2010 13:31:21 +0000 (15:31 +0200)]
s3-spoolss: Added a winreg_deleteform1 function.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a winreg_addform1 function.
Andreas Schneider [Wed, 31 Mar 2010 11:04:04 +0000 (13:04 +0200)]
s3-spoolss: Added a winreg_addform1 function.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a winreg_enumforms1 function.
Andreas Schneider [Wed, 31 Mar 2010 11:03:09 +0000 (13:03 +0200)]
s3-spoolss: Added a winreg_enumforms1 function.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Fixed winreg_printer_openkey to be used in a more generic way.
Andreas Schneider [Tue, 30 Mar 2010 12:46:32 +0000 (14:46 +0200)]
s3-spoolss: Fixed winreg_printer_openkey to be used in a more generic way.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a delete_printer_key function using the winreg pipe.
Andreas Schneider [Tue, 6 Apr 2010 15:01:15 +0000 (17:01 +0200)]
s3-spoolss: Added a delete_printer_key function using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a enum_printer_key function using the winreg pipe.
Andreas Schneider [Wed, 17 Mar 2010 14:59:10 +0000 (15:59 +0100)]
s3-spoolss: Added a enum_printer_key function using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a delete_printer_dataex function using the winreg pipe.
Andreas Schneider [Mon, 15 Mar 2010 11:30:05 +0000 (12:30 +0100)]
s3-spoolss: Added a delete_printer_dataex function using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a enum_printer_dataex function using the winreg pipe.
Andreas Schneider [Fri, 12 Mar 2010 16:31:21 +0000 (17:31 +0100)]
s3-spoolss: Added a enum_printer_dataex function using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a get_printer_dataex function using the winreg pipe.
Andreas Schneider [Mon, 15 Mar 2010 11:27:51 +0000 (12:27 +0100)]
s3-spoolss: Added a get_printer_dataex function using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a set_printer_dataex function using the winreg pipe.
Andreas Schneider [Mon, 15 Mar 2010 11:24:59 +0000 (12:24 +0100)]
s3-spoolss: Added a set_printer_dataex function using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos3-spoolss: Added a function to open a regkey using the winreg pipe.
Andreas Schneider [Mon, 15 Mar 2010 11:24:40 +0000 (12:24 +0100)]
s3-spoolss: Added a function to open a regkey using the winreg pipe.

Signed-off-by: Günther Deschner <gd@samba.org>
9 years agos4:WHATSNEW4.txt - further updates and corrections
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 13:02:23 +0000 (15:02 +0200)]
s4:WHATSNEW4.txt - further updates and corrections

Some are inspired by ekacnet.

9 years agos4:pyregistry.c - fix indentation
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 12:33:09 +0000 (14:33 +0200)]
s4:pyregistry.c - fix indentation

9 years agos4:provision - add a comment which explains why "paths.dns_keytab" is stored without...
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 12:20:18 +0000 (14:20 +0200)]
s4:provision - add a comment which explains why "paths.dns_keytab" is stored without path reference

9 years agos4-smbtorture: test for invalid form flags in RPC-SPOOLSS.
Günther Deschner [Wed, 7 Apr 2010 12:56:07 +0000 (14:56 +0200)]
s4-smbtorture: test for invalid form flags in RPC-SPOOLSS.

Guenther

9 years agos3-rpcclient: allow to define server_unc in cmd_srvsvc_srv_query_info().
Günther Deschner [Wed, 7 Apr 2010 12:38:31 +0000 (14:38 +0200)]
s3-rpcclient: allow to define server_unc in cmd_srvsvc_srv_query_info().

Guenther

9 years agos4-smbtorture: test all types and also use a wellknown builtin form name in RPC-SPOOLSS.
Günther Deschner [Wed, 7 Apr 2010 12:37:30 +0000 (14:37 +0200)]
s4-smbtorture: test all types and also use a wellknown builtin form name in RPC-SPOOLSS.

Guenther

9 years agos3: add comment about what the FSCTL_QUERY_ALLOCATED_RANGES currently does
Björn Jacke [Wed, 7 Apr 2010 10:21:07 +0000 (12:21 +0200)]
s3: add comment about what the FSCTL_QUERY_ALLOCATED_RANGES currently does

9 years agos4-smbtorture: merge badname spoolss openprinter tests.
Günther Deschner [Tue, 6 Apr 2010 22:39:17 +0000 (00:39 +0200)]
s4-smbtorture: merge badname spoolss openprinter tests.

Guenther

9 years agos4-smbtorture: avoid passing down a full test_spoolss_context to directory
Günther Deschner [Tue, 6 Apr 2010 22:38:02 +0000 (00:38 +0200)]
s4-smbtorture: avoid passing down a full test_spoolss_context to directory
spoolss tests when not used.

Guenther

9 years agoEnsure we total up the correct number of creds requested in a compound request.
Jeremy Allison [Tue, 6 Apr 2010 23:31:26 +0000 (16:31 -0700)]
Ensure we total up the correct number of creds requested in a compound request.