7 years agowintest: Fix test-s3.py to use smbclient3 under the name smbclient
Andrew Bartlett [Tue, 5 Jun 2012 01:51:18 +0000 (11:51 +1000)]
wintest: Fix test-s3.py to use smbclient3 under the name smbclient

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jun  5 06:24:39 CEST 2012 on sn-devel-104

7 years agoWHATSNEW: mention FreeBSD getaddrinfo() issue
Andrew Bartlett [Tue, 5 Jun 2012 01:41:52 +0000 (11:41 +1000)]
WHATSNEW: mention FreeBSD getaddrinfo() issue

7 years agos3:build(autoconf): fix "no AC_LANG_SOURCE call detected" warnings
Martin Schwenke [Fri, 16 Dec 2011 01:43:34 +0000 (12:43 +1100)]
s3:build(autoconf): fix "no AC_LANG_SOURCE call detected" warnings

Autoconf 2.68 NEWS says:

   AC_RUN_IFELSE now warn if the first argument failed to use
   AC_LANG_SOURCE or AC_LANG_PROGRAM to generate the conftest file
   contents.  A new macro AC_LANG_DEFINES_PROVIDED exists if you have
   a compelling reason why you cannot use AC_LANG_SOURCE but must
   avoid the warning.

Signed-off-by: Martin Schwenke <martin@meltin.net>
7 years agoWHATSNEW: Mention trouble with DNS replication
Andrew Bartlett [Tue, 5 Jun 2012 01:15:21 +0000 (11:15 +1000)]
WHATSNEW: Mention trouble with DNS replication

7 years agoWHATSNEW: Note FreeBSD improvements
Andrew Bartlett [Tue, 5 Jun 2012 00:34:27 +0000 (10:34 +1000)]
WHATSNEW: Note FreeBSD improvements

7 years agos4-provision: Test for posix ACLs in the actual sysvol path
Andrew Bartlett [Mon, 4 Jun 2012 23:58:41 +0000 (09:58 +1000)]
s4-provision: Test for posix ACLs in the actual sysvol path

This avoids issues in the previous location where lp may not be initialised at this point
and instead simply waits until we have a known sysvol path, and test for ACL support

Andrew Bartlett

7 years agos4-provision: Place xattr.tdb in the actual state directory
Andrew Bartlett [Mon, 4 Jun 2012 23:56:53 +0000 (09:56 +1000)]
s4-provision: Place xattr.tdb in the actual state directory

This patch does two things: it fixes up the spelling of "state dir" to
"state directory" so that we actually find the smb.conf parameter, and
we move it to after we process the global settings in case this is
changed in the future.

Andrew Bartlett

7 years agoWHATSNEW: Update for beta1
Andrew Bartlett [Mon, 4 Jun 2012 23:21:15 +0000 (09:21 +1000)]
WHATSNEW: Update for beta1

7 years agoVERSION: prepare for beta1 by setting and parsing the beta version
Andrew Bartlett [Mon, 4 Jun 2012 23:07:44 +0000 (09:07 +1000)]
VERSION: prepare for beta1 by setting and parsing the beta version

7 years agoAdd '--use-ntvfs' option to 'samba-tool domain join'
Andriy Syrovenko [Mon, 4 Jun 2012 22:32:42 +0000 (01:32 +0300)]
Add '--use-ntvfs' option to 'samba-tool domain join'

7 years agos3-smbd: Remove support for protocols before LANMAN1
Andrew Bartlett [Wed, 30 May 2012 02:32:56 +0000 (12:32 +1000)]
s3-smbd: Remove support for protocols before LANMAN1

This falls out of the removal of security=share, because we now require that
a session setup has been performed before (essentially) all other operations.

Andrew Bartlett

7 years agoRemove Manifest. The information here was outdated
Andrew Bartlett [Mon, 28 May 2012 03:08:45 +0000 (13:08 +1000)]
Remove Manifest.  The information here was outdated

7 years agolibreplace: Add copyrights to ease tracking of this file in future
Andrew Bartlett [Mon, 4 Jun 2012 22:00:00 +0000 (08:00 +1000)]
libreplace: Add copyrights to ease tracking of this file in future

As GIT didn't realise this was a copy out of lib/system.c, this should
make it easier to track the copyright holders on this file.  Herb's
name wasn't on the original file, but was the only other author I
could find in the git logs.

I've added my copyright here too.

Andrew Bartlett

7 years agolibreplace: Remove autoconf build system
Andrew Bartlett [Sat, 2 Jun 2012 13:51:39 +0000 (23:51 +1000)]
libreplace: Remove autoconf build system

This leaves the parts required to build libreplace as a static lib for the autoconf build

Andrew Bartlett

7 years agoFix bug #8972 - Directory group write permission bit is set if unix extensions are...
Jeremy Allison [Tue, 5 Jun 2012 00:34:54 +0000 (17:34 -0700)]
Fix bug #8972 - Directory group write permission bit is set if unix extensions are enabled

We can't manipulate file_attributes if it's a posix call. I'll look
at adding a test for this asap.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jun  5 04:26:11 CEST 2012 on sn-devel-104

7 years agolibreplace: Ensure we link xattr.c on MacOS
Andrew Bartlett [Sun, 3 Jun 2012 22:47:03 +0000 (08:47 +1000)]
libreplace: Ensure we link xattr.c on MacOS

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jun  4 02:36:55 CEST 2012 on sn-devel-104

7 years agos3:libsmb: get rid of cli_smb_req_*,cli_smb_wct_ofs,cli_smb_chain_send
Luk Claes [Sat, 26 May 2012 09:58:34 +0000 (11:58 +0200)]
s3:libsmb: get rid of cli_smb_req_*,cli_smb_wct_ofs,cli_smb_chain_send

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Jun  3 23:37:02 CEST 2012 on sn-devel-104

7 years agos3:smbd: make conn_close_all() a void function
Stefan Metzmacher [Sun, 3 Jun 2012 14:09:23 +0000 (16:09 +0200)]
s3:smbd: make conn_close_all() a void function


7 years agoRevert "s3: Fix bug 8371"
Stefan Metzmacher [Sat, 26 May 2012 09:04:16 +0000 (11:04 +0200)]
Revert "s3: Fix bug 8371"

This reverts commit 2642f385887fbd3aecd4286a4d6223a21d981714.

This is not needed anymore, as 035342c11719d1daa647c0b2ae7cec27a969f83a
"Fix bug #8373 - Can't join XP Pro workstations to 3.6.1 DC." is
the more generic fix for the problem.


7 years agos3:smbd/close: call del_share_mode() directly before TALLOC_FREE(lck)
Stefan Metzmacher [Sat, 2 Jun 2012 12:06:29 +0000 (14:06 +0200)]
s3:smbd/close: call del_share_mode() directly before TALLOC_FREE(lck)


Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Jun  3 21:08:19 CEST 2012 on sn-devel-104

7 years agos3:smbd/close: remove unused goto out from close_directory()
Stefan Metzmacher [Sun, 3 Jun 2012 13:17:29 +0000 (15:17 +0200)]
s3:smbd/close: remove unused goto out from close_directory()


7 years agos3:smbd/close: do an early return in close_directory()
Stefan Metzmacher [Sat, 2 Jun 2012 12:04:52 +0000 (14:04 +0200)]
s3:smbd/close: do an early return in close_directory()


7 years agos3: Fix an assert to trigger in close_remove_share_mode
Stefan Metzmacher [Fri, 1 Jun 2012 14:29:51 +0000 (16:29 +0200)]
s3: Fix an assert to trigger in close_remove_share_mode

In case we have a left-over entry in the share mode entry array,
the SMB_ASSERT(got_tokens) is likely to kick in. It happens when
we are about to delete a file with initial delete on close. We don't
have a delete on close token set in the locking.tdb record. We see
the fsp->initial_delete_on_close set, add the delete_on_close token
to lck. Then "delete_file" is being set to true. Then later on we
do the notify_deferred_opens. This walks the list, also checking
for share_mode_stale_pid. We have already deleted our own share
mode entry, share_mode_stale_pid() sees the left-over entry. It not
also deletes that one but also the delete on close token. This leads
to a different view of "delete_file" a.k.a. "got_tokens" further
down in close_remove_share_mode, leading the SMB_ASSERT to fire.

This patch attempts to fix the issue by keeping around our own share
mode entry for almost the whole routine, preventing share_mode_stale_pid()
from removing the delete tokens.

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

7 years agos3: Do an early return in close_remove_share_mode
Volker Lendecke [Fri, 1 Jun 2012 14:42:29 +0000 (16:42 +0200)]
s3: Do an early return in close_remove_share_mode

Without "lck" we don't have much to clean up

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3: Make close_remove_share_mode a bit more readable
Volker Lendecke [Fri, 1 Jun 2012 14:13:22 +0000 (16:13 +0200)]
s3: Make close_remove_share_mode a bit more readable

by introducing a variable simplifying a boolean expression

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3: Simplify get_delete_on_close_token more
Volker Lendecke [Fri, 1 Jun 2012 13:52:14 +0000 (15:52 +0200)]
s3: Simplify get_delete_on_close_token more

All remaining callers actually want the token

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3: Simplify get_delete_on_close_token slightly
Volker Lendecke [Fri, 1 Jun 2012 13:50:39 +0000 (15:50 +0200)]
s3: Simplify get_delete_on_close_token slightly

Introduce find_delete_on_close_token. Thus is_delete_on_close_set
does not have to call get_delete_on_close_token anymore.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3: Slightly simplify close_remove_share_mode
Volker Lendecke [Fri, 1 Jun 2012 13:21:12 +0000 (15:21 +0200)]
s3: Slightly simplify close_remove_share_mode

Remove a level of indentation by more use of "continue;"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd/close: avoid procid_is_me()
Stefan Metzmacher [Sat, 2 Jun 2012 11:42:09 +0000 (13:42 +0200)]
s3:smbd/close: avoid procid_is_me()


7 years agos3:smbd/open: avoid procid_is_me()
Stefan Metzmacher [Sat, 2 Jun 2012 11:40:26 +0000 (13:40 +0200)]
s3:smbd/open: avoid procid_is_me()


7 years agos3:smbd/oplock: avoid procid_is_me()
Stefan Metzmacher [Sat, 2 Jun 2012 11:39:33 +0000 (13:39 +0200)]
s3:smbd/oplock: avoid procid_is_me()


7 years agobuild: Match autoconf build and disable ACLs on MacOS (darwin)
Andrew Bartlett [Sun, 3 Jun 2012 12:11:31 +0000 (22:11 +1000)]
build: Match autoconf build and disable ACLs on MacOS (darwin)

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun  3 16:03:59 CEST 2012 on sn-devel-104

7 years agolib/krb5_wrap: Remove unused smb_krb5_get_creds
Andrew Bartlett [Sun, 3 Jun 2012 08:58:31 +0000 (18:58 +1000)]
lib/krb5_wrap: Remove unused smb_krb5_get_creds

Found by callcatcher

This has been unsused since

commit 61f0b247633501d6bf4103ca8345048e537c043d
Author: G√ľnther Deschner <gd@samba.org>
Date:   Thu Nov 12 15:42:03 2009 +0100

    s3-kerberos: remove smb_krb5_get_tkt_from_creds().

    Now that cli_krb5_get_ticket() already handles S4U2SELF impersonation, remove
    smb_krb5_get_tkt_from_creds() which is not required anymore.


Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun  3 13:04:06 CEST 2012 on sn-devel-104

7 years agolibrepace: put #defines after #include "sys/xattr.h"
Andrew Bartlett [Sun, 3 Jun 2012 05:56:29 +0000 (15:56 +1000)]
librepace: put #defines after #include "sys/xattr.h"

This avoids redefining the system xattr functions, which should fix MacOS.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun  3 09:46:44 CEST 2012 on sn-devel-104

7 years agolib/replace: Undo change of 0 -> NULL
Andrew Bartlett [Sun, 3 Jun 2012 05:45:16 +0000 (15:45 +1000)]
lib/replace: Undo change of 0 -> NULL

This reverts part of e9d797e153ae95561dbb10b56a41281b2472f137 as
in the autoconf tests, NULL isn't available!

(it is available in waf, which caused confusion)

Andrew Bartlett

7 years agos3-libnetapi: Cope with popt versions without POPT_TABLEEND
Andrew Bartlett [Sun, 3 Jun 2012 05:30:15 +0000 (15:30 +1000)]
s3-libnetapi: Cope with popt versions without POPT_TABLEEND

7 years agolibreplace: Fix up MacOS xattr functions
Andrew Bartlett [Sun, 3 Jun 2012 01:32:55 +0000 (11:32 +1000)]
libreplace: Fix up MacOS xattr functions

We need undo the rep_ macro to call the real OS function.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun  3 06:21:21 CEST 2012 on sn-devel-104

7 years agos3-build: Remove finddead
Andrew Bartlett [Sun, 3 Jun 2012 01:13:29 +0000 (11:13 +1000)]
s3-build: Remove finddead

This won't work with the new tree structure, and we have the same
output at

Using the callcatcher framework.

Andrew Bartlett

7 years agolibreplace: Link libreplace against attr when required
Andrew Bartlett [Sat, 2 Jun 2012 23:08:55 +0000 (09:08 +1000)]
libreplace: Link libreplace against attr when required

The autoconf Samba build will return to over-linking with -lattr on
systems with both the XFS compat API and native xattrs.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun  3 03:56:05 CEST 2012 on sn-devel-104

7 years agolibreplace: Use true rather than True in xattr.c
Andrew Bartlett [Sat, 2 Jun 2012 22:14:00 +0000 (08:14 +1000)]
libreplace: Use true rather than True in xattr.c

This should fix the build on IRIX.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Jun  3 02:05:35 CEST 2012 on sn-devel-104

7 years agolibreplace: Fix build on MacOS where we have the same fn name but more arguments
Andrew Bartlett [Sat, 2 Jun 2012 11:25:09 +0000 (21:25 +1000)]
libreplace: Fix build on MacOS where we have the same fn name but more arguments

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun  2 15:52:51 CEST 2012 on sn-devel-104

7 years agolibreplace: Solaris needs system/dir.h for that xattr wrapper implementation
Andrew Bartlett [Sat, 2 Jun 2012 11:05:34 +0000 (21:05 +1000)]
libreplace: Solaris needs system/dir.h for that xattr wrapper implementation

7 years agobuild: Remove check for res_ninit (Revert "s3: Check for res_ninit")
Andrew Bartlett [Sat, 2 Jun 2012 04:09:09 +0000 (14:09 +1000)]
build: Remove check for res_ninit (Revert "s3: Check for res_ninit")

This reverts commit 4f6b1e8c81776cf1fa386574e60e54fe6b4fe82e because I
cannot find any use of this configure check, and it is one of the
differences between the WAF and autoconf builds.

Andrew Bartlett

7 years agobuild: Show extra configure results found by WAF as well
Andrew Bartlett [Sat, 2 Jun 2012 04:31:41 +0000 (14:31 +1000)]
build: Show extra configure results found by WAF as well

This may assist in debugging a difference in a configure test on the
build farm.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun  2 09:46:09 CEST 2012 on sn-devel-104

7 years agoccan: fix autoconf test for isblank()
Andrew Bartlett [Sat, 2 Jun 2012 04:15:42 +0000 (14:15 +1000)]
ccan: fix autoconf test for isblank()

The define in the C code is HAVE_ISBLANK

Andrew Bartlett

7 years agolibreplace: Add missing tests for HAVE_MREMAP and HAVE_SHARED_MMAP
Andrew Bartlett [Sat, 2 Jun 2012 04:13:14 +0000 (14:13 +1000)]
libreplace: Add missing tests for HAVE_MREMAP and HAVE_SHARED_MMAP

7 years agolibreplace: Fix autoconf build on platforms needing xattrs
Andrew Bartlett [Sat, 2 Jun 2012 03:08:32 +0000 (13:08 +1000)]
libreplace: Fix autoconf build on platforms needing xattrs

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun  2 07:23:32 CEST 2012 on sn-devel-104

7 years agobuild: Check correctly for sendfile (missing .h in header)
Andrew Bartlett [Sat, 2 Jun 2012 03:02:21 +0000 (13:02 +1000)]
build: Check correctly for sendfile (missing .h in header)

This will hopefully fix the build on SLES8, which does not support 64-bit sendfile.

Andrew Bartlett

7 years agolib/replace: Relicence xattr.c to LGPLv3
Andrew Bartlett [Fri, 1 Jun 2012 23:28:04 +0000 (09:28 +1000)]
lib/replace: Relicence xattr.c to LGPLv3

By the kind consent of the copyright holders.  (There wasn't any code from tridge
in the code brought in from source3/lib/system.c).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun  2 04:00:42 CEST 2012 on sn-devel-104

7 years agobuild: Always attempt to build posix ACLs
Andrew Bartlett [Fri, 1 Jun 2012 05:24:20 +0000 (15:24 +1000)]
build: Always attempt to build posix ACLs

These are on more systems than just linux.  If the configure test passes
then assume it is available.

Andrew Bartlett

7 years agolib/replace: Merge remaining xattr test details from lib/util
Andrew Bartlett [Fri, 1 Jun 2012 05:01:09 +0000 (15:01 +1000)]
lib/replace: Merge remaining xattr test details from lib/util

I prefer the longer XATTR_ADDITIONAL_OPTIONS define and the NULL
rather than 0 values in the getxattr test.

Andrew Bartlett

7 years agos4-xattr: Use libreplace xattr functions directly
Andrew Bartlett [Fri, 1 Jun 2012 03:41:46 +0000 (13:41 +1000)]
s4-xattr: Use libreplace xattr functions directly

7 years agolib/replace: xattr wrappers in lib/replace rather than source3/lib/system.c
Andrew Bartlett [Fri, 1 Jun 2012 03:29:38 +0000 (13:29 +1000)]
lib/replace: xattr wrappers in lib/replace rather than source3/lib/system.c

This also moves all the still-used configure tests etc.  The unused OSF API
is also removed at this time.

Andrew Bartlett

7 years agolib/replace: We cannot use strchr_m in lib/replace
Andrew Bartlett [Fri, 1 Jun 2012 04:07:42 +0000 (14:07 +1000)]
lib/replace: We cannot use strchr_m in lib/replace

In any case, it is always safe to search for . even in a multibyte string.

Andrew Bartlett

7 years agolib/replace: DEBUG is not acceptable here, as this may not be linked into Samba
Andrew Bartlett [Fri, 1 Jun 2012 04:05:10 +0000 (14:05 +1000)]
lib/replace: DEBUG is not acceptable here, as this may not be linked into Samba

7 years agolib/replace: Copy lib/system.c xattr wrappers to lib/replace
Andrew Bartlett [Fri, 1 Jun 2012 04:14:45 +0000 (14:14 +1000)]
lib/replace: Copy lib/system.c xattr wrappers to lib/replace

7 years agos3: Same fix as 8576256, this time for fgetxattr
Volker Lendecke [Fri, 1 Jun 2012 08:32:54 +0000 (10:32 +0200)]
s3: Same fix as 8576256, this time for fgetxattr

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jun  2 02:12:31 CEST 2012 on sn-devel-104

7 years agos3: Avoid a lot of calls to serverid_exists()
Volker Lendecke [Fri, 1 Jun 2012 13:15:07 +0000 (15:15 +0200)]
s3: Avoid a lot of calls to serverid_exists()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jun  1 18:58:30 CEST 2012 on sn-devel-104

7 years agoRevert "waf-mitkrb5: enable dcerpc_server library to support OpenChange client code"
Alexander Bokovoy [Fri, 1 Jun 2012 12:38:56 +0000 (15:38 +0300)]
Revert "waf-mitkrb5: enable dcerpc_server library to support OpenChange client code"

This reverts commit f8c447b1a48eaf12dcf70b92fd7525c4ad26c246.

After discussing with Julien (Openchange) and Metze, I decided to revert this code.
Instead I made a patch to Openchange which allows to build client side only.

Openchange server code requires working s4 member DC and --without-ad-dc build
does not provide working provisioning even if we enable dcerpc_server and end point mapper.

Autobuild-User: Alexander Bokovoy <ab@samba.org>
Autobuild-Date: Fri Jun  1 16:46:08 CEST 2012 on sn-devel-104

7 years agowaf: check for krb5_create_checksum and krb5_creds.flags for some Heimdal versions
Alexander Bokovoy [Thu, 31 May 2012 09:44:50 +0000 (12:44 +0300)]
waf: check for krb5_create_checksum and krb5_creds.flags for some Heimdal versions

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Jun  1 11:23:21 CEST 2012 on sn-devel-104

7 years agowaf-mitkrb5: enable dcerpc_server library to support OpenChange client code
Alexander Bokovoy [Thu, 31 May 2012 07:32:01 +0000 (10:32 +0300)]
waf-mitkrb5: enable dcerpc_server library to support OpenChange client code

Signed-off-by: Andreas Schneider <asn@samba.org>
7 years ago.gitignore: remove already-gone gen-8bit-gap.sh
Andrew Bartlett [Fri, 1 Jun 2012 00:38:55 +0000 (10:38 +1000)]
.gitignore: remove already-gone gen-8bit-gap.sh

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Jun  1 04:53:53 CEST 2012 on sn-devel-104

7 years agobuild: Add automatic compare of config.h files to recursive waf build
Andrew Bartlett [Thu, 31 May 2012 23:48:20 +0000 (09:48 +1000)]
build: Add automatic compare of config.h files to recursive waf build

This uses the fact that we have both build systems running at the same time.

The krb5 checks are skipped because we typically are comparing internal Heimdal
with the system krb5, so they do not make sense.

The required checks for krb5 are pretty well understood in any case, as
we have a limited set of supported libraries.

Andrew Bartlett

7 years agoRemove an unused variable.
Jeremy Allison [Thu, 31 May 2012 23:06:17 +0000 (16:06 -0700)]
Remove an unused variable.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jun  1 03:03:12 CEST 2012 on sn-devel-104

7 years agoForward port of Richard Sharpe's <realrichardsharpe@gmail.com> fix for bug #8970...
Jeremy Allison [Thu, 31 May 2012 22:06:58 +0000 (15:06 -0700)]
Forward port of Richard Sharpe's <realrichardsharpe@gmail.com> fix for bug #8970 - Possible memory leaks in the samba master process.

7 years agoWe are triggering the cleanup_timeout_fn() too often, on exiting when an smbd is...
Jeremy Allison [Thu, 31 May 2012 19:35:04 +0000 (12:35 -0700)]
We are triggering the cleanup_timeout_fn() too often, on exiting when an smbd is idle.

Calls to exit_server_cleanly() should be treated as a "clean" shutdown,
and not trigger the master smbd to call cleanup_timeout_fn.

7 years agos3:smbd: use server_messaging_context() instead of sconn->msg_ctx in exit_server_common()
Stefan Metzmacher [Thu, 31 May 2012 13:28:11 +0000 (15:28 +0200)]
s3:smbd: use server_messaging_context() instead of sconn->msg_ctx in exit_server_common()

sconn is not available in the parent anymore.

Thanks to Volker Lendecke <vl@samba.org> for finding this!


Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu May 31 18:08:06 CEST 2012 on sn-devel-104

7 years agos3:vfs_hpuxacl: remove unused file_find_fd() calls
Stefan Metzmacher [Thu, 31 May 2012 07:28:31 +0000 (09:28 +0200)]
s3:vfs_hpuxacl: remove unused file_find_fd() calls


7 years agowintest: use (renamed) smbclient4 tool as smbclient
Michael Adam [Wed, 30 May 2012 13:24:18 +0000 (15:24 +0200)]
wintest: use (renamed) smbclient4 tool as smbclient

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu May 31 13:23:34 CEST 2012 on sn-devel-104

7 years agowintest: introduce a variable to contain the (relative) path of smbclient
Michael Adam [Wed, 30 May 2012 13:22:52 +0000 (15:22 +0200)]
wintest: introduce a variable to contain the (relative) path of smbclient

7 years agos3: Fix some 64-bit warnings
Volker Lendecke [Wed, 30 May 2012 07:08:49 +0000 (09:08 +0200)]
s3: Fix some 64-bit warnings

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu May 31 10:06:56 CEST 2012 on sn-devel-104

7 years agobuild: rename build targets smbclient -> smbclient4 and smbclient3 -> smbclient
Michael Adam [Wed, 30 May 2012 11:10:57 +0000 (13:10 +0200)]
build: rename build targets smbclient -> smbclient4 and smbclient3 -> smbclient

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu May 31 06:36:55 CEST 2012 on sn-devel-104

7 years agos4:selftest: change the blackbox.samba_tool_demote test to use a binary mapping for...
Michael Adam [Wed, 30 May 2012 10:21:42 +0000 (12:21 +0200)]
s4:selftest: change the blackbox.samba_tool_demote test to use a binary mapping for smbclient

7 years agos4:selftest: change the blackbox.passwords test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:18:35 +0000 (12:18 +0200)]
s4:selftest: change the blackbox.passwords test to use a binary mapping for smbclient

7 years agos4:selftest: change the blackbox.pkinit test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:16:49 +0000 (12:16 +0200)]
s4:selftest: change the blackbox.pkinit test to use a binary mapping for smbclient

7 years agos4:selftest: change the blackbox.kinit test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:15:10 +0000 (12:15 +0200)]
s4:selftest: change the blackbox.kinit test to use a binary mapping for smbclient

7 years agos4:selftest: change the blackbox.export.keytab test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:09:25 +0000 (12:09 +0200)]
s4:selftest: change the blackbox.export.keytab test to use a binary mapping for smbclient

7 years agos4:selftest: change the blackbox.chgdcpass test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:07:18 +0000 (12:07 +0200)]
s4:selftest: change the blackbox.chgdcpass test to use a binary mapping for smbclient

7 years agos4:selftest: change the blackbox.samba_tool test to use a binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 10:04:30 +0000 (12:04 +0200)]
s4:selftest: change the blackbox.samba_tool test to use a binary mapping for smbclient

7 years agos4:selftets: change the blackbox.bogusdomain test to use binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 09:57:16 +0000 (11:57 +0200)]
s4:selftets: change the blackbox.bogusdomain test to use binary mapping for smbclient

7 years agos4:selftest: change the blackbox.smbclient test to use binary mapping for smbclient
Michael Adam [Wed, 30 May 2012 09:48:02 +0000 (11:48 +0200)]
s4:selftest: change the blackbox.smbclient test to use binary mapping for smbclient

7 years agos3:selftest: add a binary mapping for smbclient4
Michael Adam [Thu, 24 May 2012 23:40:58 +0000 (01:40 +0200)]
s3:selftest: add a binary mapping for smbclient4

7 years agoselftest: add a binary mapping for smbclient4
Michael Adam [Thu, 24 May 2012 23:40:32 +0000 (01:40 +0200)]
selftest: add a binary mapping for smbclient4

7 years agobuild: rename build targets nmblookup -> nmblookup4 and nmblookup3 -> nmblookup
Michael Adam [Wed, 30 May 2012 11:09:57 +0000 (13:09 +0200)]
build: rename build targets nmblookup -> nmblookup4 and nmblookup3 -> nmblookup

7 years agobuild: add a build suffix ("4") for s4-binaries
Michael Adam [Wed, 30 May 2012 11:01:18 +0000 (13:01 +0200)]
build: add a build suffix ("4") for s4-binaries

7 years agos4:selftest: determine nmblookup via binary mapping for blackbox test in tests.py
Michael Adam [Tue, 29 May 2012 14:35:18 +0000 (16:35 +0200)]
s4:selftest: determine nmblookup via binary mapping for blackbox test in tests.py

7 years agoselftest:Samba4: use the nmblookup4 binary mapping
Michael Adam [Thu, 24 May 2012 23:44:17 +0000 (01:44 +0200)]
selftest:Samba4: use the nmblookup4 binary mapping

7 years agos3:selftest: add a binary mapping for nmblookup4
Michael Adam [Thu, 24 May 2012 23:42:37 +0000 (01:42 +0200)]
s3:selftest: add a binary mapping for nmblookup4

7 years agoselftest: add a binary mapping for nmblookup4
Michael Adam [Thu, 24 May 2012 23:42:20 +0000 (01:42 +0200)]
selftest: add a binary mapping for nmblookup4

7 years agos3:selftest: improve strange linebreaks for blackbox tests in tests.py for readability
Michael Adam [Tue, 29 May 2012 11:59:14 +0000 (13:59 +0200)]
s3:selftest: improve strange linebreaks for blackbox tests in tests.py for readability

7 years agos3:selftest: introduce a variable for binpath('dbwrap_tool') in tests.py
Michael Adam [Tue, 29 May 2012 11:51:05 +0000 (13:51 +0200)]
s3:selftest: introduce a variable for binpath('dbwrap_tool') in tests.py

7 years agos3:selftest: introduce a variable for binpath('ntlm_auth3') in tests.py
Michael Adam [Tue, 29 May 2012 11:47:32 +0000 (13:47 +0200)]
s3:selftest: introduce a variable for binpath('ntlm_auth3') in tests.py

7 years agos3:selftest: introduce a variable for binpath('smbtorture3') in tests.py
Michael Adam [Tue, 29 May 2012 11:45:49 +0000 (13:45 +0200)]
s3:selftest: introduce a variable for binpath('smbtorture3') in tests.py

7 years agos3:selftest: introduce a variable for binpath('net') in tests.py
Michael Adam [Tue, 29 May 2012 11:44:03 +0000 (13:44 +0200)]
s3:selftest: introduce a variable for binpath('net') in tests.py

7 years agos3:selftest: introduce a variable for binpath('wbinfo') in tests.py
Michael Adam [Tue, 29 May 2012 10:18:19 +0000 (12:18 +0200)]
s3:selftest: introduce a variable for binpath('wbinfo') in tests.py

to remove explicit calls to binpath('wbinfo')

7 years agos3:selftest: introduce a variable for binpath('smbclient3') to test.py
Michael Adam [Tue, 29 May 2012 10:16:12 +0000 (12:16 +0200)]
s3:selftest: introduce a variable for binpath('smbclient3') to test.py

to remove manual calls to binpath("smbclient3")

7 years agos3:selftest: introduce a variable for binpath('nmblookup3') in tests.py
Michael Adam [Tue, 29 May 2012 10:10:16 +0000 (12:10 +0200)]
s3:selftest: introduce a variable for binpath('nmblookup3') in tests.py

7 years agos3:build: fix some spacing in wscript_build
Michael Adam [Fri, 18 May 2012 13:02:31 +0000 (15:02 +0200)]
s3:build: fix some spacing in wscript_build

7 years agoStop spamming the logs with "Could not remove pid XX from serverid.tdb" messages...
Jeremy Allison [Thu, 31 May 2012 00:12:10 +0000 (17:12 -0700)]
Stop spamming the logs with "Could not remove pid XX from serverid.tdb" messages and initiating the cleanup function on every process death.

We now have many sub-processes from smbd that don't serve SMB1/SMB2 requests and
don't register themselves in the serverid.tdb. Only initiate the cleanup
from processes that were explicitly in the child list.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May 31 04:44:09 CEST 2012 on sn-devel-104

7 years agolib/dbwrap: make it possible to delete/store the current record during traverse
Stefan Metzmacher [Wed, 30 May 2012 13:06:12 +0000 (15:06 +0200)]
lib/dbwrap: make it possible to delete/store the current record during traverse


Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu May 31 02:50:09 CEST 2012 on sn-devel-104