kai/samba.git
7 years agos4-smbtorture: add spoolss_OpenPrinterEx ndr test with full devmode.
Günther Deschner [Mon, 14 Nov 2011 17:23:01 +0000 (18:23 +0100)]
s4-smbtorture: add spoolss_OpenPrinterEx ndr test with full devmode.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Nov 14 20:21:48 CET 2011 on sn-devel-104

7 years agos3-modules: remove the last "init_module" traces.
Günther Deschner [Mon, 14 Nov 2011 15:29:57 +0000 (16:29 +0100)]
s3-modules: remove the last "init_module" traces.

Guenther

7 years agoFix default value for subunitrun --list.
Jelmer Vernooij [Mon, 14 Nov 2011 13:55:49 +0000 (14:55 +0100)]
Fix default value for subunitrun --list.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Nov 14 17:27:03 CET 2011 on sn-devel-104

7 years agoselftesthelpers: Revert perl changes, add comment on why the original code was necessary.
Jelmer Vernooij [Mon, 14 Nov 2011 12:47:50 +0000 (13:47 +0100)]
selftesthelpers: Revert perl changes, add comment on why the original code was necessary.

7 years agos4-tests: Use plansmbtorturesuite where possible.
Jelmer Vernooij [Mon, 14 Nov 2011 12:10:11 +0000 (13:10 +0100)]
s4-tests: Use plansmbtorturesuite where possible.

7 years agos4-tests: Remove unnecessary py suffix.
Jelmer Vernooij [Mon, 14 Nov 2011 00:54:43 +0000 (01:54 +0100)]
s4-tests: Remove unnecessary py suffix.

7 years agos4-tests: Allow listing tests run for iconv.
Jelmer Vernooij [Mon, 14 Nov 2011 00:54:26 +0000 (01:54 +0100)]
s4-tests: Allow listing tests run for iconv.

7 years agosubunitrun: Don't load smb.conf when just listing tests.
Jelmer Vernooij [Mon, 14 Nov 2011 00:13:36 +0000 (01:13 +0100)]
subunitrun: Don't load smb.conf when just listing tests.

7 years agoRemove broken code - these lines use undefined symbols.
Jelmer Vernooij [Sun, 13 Nov 2011 21:33:41 +0000 (22:33 +0100)]
Remove broken code - these lines use undefined symbols.

7 years agowaf: Fix uselib_store for system libsubunit.
Jelmer Vernooij [Sun, 13 Nov 2011 21:15:49 +0000 (22:15 +0100)]
waf: Fix uselib_store for system libsubunit.

7 years agoselftesthelpers: Cope with empty binary mappings list, simplify handling of perl.
Jelmer Vernooij [Sun, 13 Nov 2011 20:51:53 +0000 (21:51 +0100)]
selftesthelpers: Cope with empty binary mappings list, simplify handling of perl.

7 years agos4:selftest: samba4.urgent_replication.python needs to run as "dc:local"
Stefan Metzmacher [Mon, 14 Nov 2011 09:51:56 +0000 (10:51 +0100)]
s4:selftest: samba4.urgent_replication.python needs to run as "dc:local"

As it uses local files on the dc.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 14 15:48:33 CET 2011 on sn-devel-104

7 years agoselftest/selftesthelpers.py: construct a fullname with env in plantestsuite_idlist()
Stefan Metzmacher [Mon, 14 Nov 2011 13:10:17 +0000 (14:10 +0100)]
selftest/selftesthelpers.py: construct a fullname with env in plantestsuite_idlist()

Like we already do for plantestsuite_loadlist()

metze

7 years agoselftest: planpythontestsuite() should fill 'name' is it's None
Stefan Metzmacher [Mon, 14 Nov 2011 11:21:38 +0000 (12:21 +0100)]
selftest: planpythontestsuite() should fill 'name' is it's None

Otherwise make test shows tests with name "None".

metze

7 years agos3:smb2_flush: outbody only needs 4 bytes
Stefan Metzmacher [Thu, 10 Nov 2011 11:20:20 +0000 (12:20 +0100)]
s3:smb2_flush: outbody only needs 4 bytes

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 14 10:01:30 CET 2011 on sn-devel-104

7 years agoMove testr configuration to root.
Jelmer Vernooij [Sun, 13 Nov 2011 20:40:12 +0000 (21:40 +0100)]
Move testr configuration to root.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Nov 13 23:19:27 CET 2011 on sn-devel-104

7 years agowaf: Factor checking for undefined symbol flags out into separate method.
Jelmer Vernooij [Sun, 13 Nov 2011 17:01:09 +0000 (18:01 +0100)]
waf: Factor checking for undefined symbol flags out into separate method.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Nov 13 19:38:38 CET 2011 on sn-devel-104

7 years agowaf: Simplify handling of python modules.
Jelmer Vernooij [Sun, 13 Nov 2011 16:50:52 +0000 (17:50 +0100)]
waf: Simplify handling of python modules.

7 years agoRevert 9a5ae8edd6d006c078b3af8fdfd84677a63276b1.
Jelmer Vernooij [Sun, 13 Nov 2011 16:29:10 +0000 (17:29 +0100)]
Revert 9a5ae8edd6d006c078b3af8fdfd84677a63276b1.

7 years agopytdb: Shorter description which fits on a single line.
Jelmer Vernooij [Sun, 13 Nov 2011 16:20:57 +0000 (17:20 +0100)]
pytdb: Shorter description which fits on a single line.

7 years agotesttools: Import new upstream snapshot.
Jelmer Vernooij [Sun, 13 Nov 2011 16:18:10 +0000 (17:18 +0100)]
testtools: Import new upstream snapshot.

7 years agosubunit: Import new upstream snapshot.
Jelmer Vernooij [Sun, 13 Nov 2011 16:17:54 +0000 (17:17 +0100)]
subunit: Import new upstream snapshot.

7 years agowafsamba: Support allow_undefined_symbols in SAMBA_SUBSYSTEM.
Jelmer Vernooij [Sat, 12 Nov 2011 19:24:35 +0000 (20:24 +0100)]
wafsamba: Support allow_undefined_symbols in SAMBA_SUBSYSTEM.

7 years agowafsambaa: Support libraries that don't have the same name as their pkg-config file.
Jelmer Vernooij [Sat, 12 Nov 2011 15:56:01 +0000 (16:56 +0100)]
wafsambaa: Support libraries that don't have the same name as their pkg-config file.

7 years agoldb: Only check for pkg-config file when checking for system ldb.
Jelmer Vernooij [Sat, 12 Nov 2011 15:36:39 +0000 (16:36 +0100)]
ldb: Only check for pkg-config file when checking for system ldb.

7 years agotevent: Only check for pkg-config file when checking for system tevent.
Jelmer Vernooij [Sat, 12 Nov 2011 15:36:28 +0000 (16:36 +0100)]
tevent: Only check for pkg-config file when checking for system tevent.

7 years agotdb: Only check for pkg-config file when checking for system tdb.
Jelmer Vernooij [Sat, 12 Nov 2011 15:36:18 +0000 (16:36 +0100)]
tdb: Only check for pkg-config file when checking for system tdb.

7 years agotalloc: Only check for pkg-config file when checking for system talloc.
Jelmer Vernooij [Sat, 12 Nov 2011 15:36:07 +0000 (16:36 +0100)]
talloc: Only check for pkg-config file when checking for system talloc.

7 years agosubunit: Only check for pkg-config file and use proper pkg-config file name.
Jelmer Vernooij [Sat, 12 Nov 2011 15:35:48 +0000 (16:35 +0100)]
subunit: Only check for pkg-config file and use proper pkg-config file name.

7 years agowafsamba: add CHECK_BUNDLED_SYSTEM_PKG function.
Jelmer Vernooij [Sat, 12 Nov 2011 15:35:11 +0000 (16:35 +0100)]
wafsamba: add CHECK_BUNDLED_SYSTEM_PKG function.

7 years agotevent: Only build pytevent if the system doesn't provide it.
Jelmer Vernooij [Sat, 12 Nov 2011 15:14:33 +0000 (16:14 +0100)]
tevent: Only build pytevent if the system doesn't provide it.

7 years agoldb: Use pyembed rather than pyext for ldb-util library.
Jelmer Vernooij [Sat, 12 Nov 2011 14:51:16 +0000 (15:51 +0100)]
ldb: Use pyembed rather than pyext for ldb-util library.

7 years agotevent: remove unnecessary enablement.
Jelmer Vernooij [Sat, 12 Nov 2011 14:50:54 +0000 (15:50 +0100)]
tevent: remove unnecessary enablement.

7 years agopytalloc-util: Don't mark as python extension, use pyembed instead.
Jelmer Vernooij [Sat, 12 Nov 2011 14:38:45 +0000 (15:38 +0100)]
pytalloc-util: Don't mark as python extension, use pyembed instead.

7 years agowaf: Don't link python modules against libpython2.x, consistent with other Python...
Jelmer Vernooij [Sat, 12 Nov 2011 04:20:10 +0000 (05:20 +0100)]
waf: Don't link python modules against libpython2.x, consistent with other Python modules.

Rather, rely just on waf's pyext feature. This fixes a warning from dh_python2.

7 years agoupgrade: use logger.warning.
Jelmer Vernooij [Fri, 11 Nov 2011 17:32:55 +0000 (18:32 +0100)]
upgrade: use logger.warning.

7 years agosamba-tool: allow dbcheck to correct the originating_change_time of the deleted objec...
Matthieu Patou [Sun, 13 Nov 2011 13:09:24 +0000 (14:09 +0100)]
samba-tool: allow dbcheck to correct the originating_change_time of the deleted object container

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Nov 13 15:47:53 CET 2011 on sn-devel-104

7 years agos4-dsdb: initialize correctly the value of originating_change_time for the Deleted...
Matthieu Patou [Sun, 13 Nov 2011 13:08:32 +0000 (14:08 +0100)]
s4-dsdb: initialize correctly the value of originating_change_time for the Deleted Object Container

7 years agos4-drs: check if we have a domain level >= 2k8r2 as before the isRecycled do not...
Matthieu Patou [Wed, 5 Oct 2011 14:23:37 +0000 (16:23 +0200)]
s4-drs: check if we have a domain level >= 2k8r2 as before the isRecycled do not exists and so is always False

Having a false value cause the link on removed attribute to be always
returned which is what we try to avoid.

7 years agosamba-tool: dbcheck avoid problems with deleted objects
Matthieu Patou [Sun, 13 Nov 2011 12:15:47 +0000 (13:15 +0100)]
samba-tool: dbcheck avoid problems with deleted objects

We have to search for deleted objects as well as the previous search
might have been done with the show_deleted control. If not samba-tool
fails with no such DN error while fetching the object.

7 years agos4: Simple test script to create lots of contacts to stress the LDB
Matthieu Patou [Fri, 11 Nov 2011 18:01:54 +0000 (19:01 +0100)]
s4: Simple test script to create lots of contacts to stress the LDB

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri Nov 11 22:02:53 CET 2011 on sn-devel-104

7 years agos4-librpc: do not limit to the first IP when trying to do a rpc connection
Matthieu Patou [Thu, 10 Nov 2011 19:59:09 +0000 (20:59 +0100)]
s4-librpc: do not limit to the first IP when trying to do a rpc connection

The function continue_ip_resolve_name was calling resolve_name_recv which returns
only the first IP for a given hostname.
Instead we use resolve_name_multiple_recv which returns all the IP for a given
hostname. This kind of problem can occur if a host has more than 1 IP but is listenning
only on 1.

7 years agos4-socket: allow connect_multi_next_socket to try all the IP for a given host
Matthieu Patou [Thu, 10 Nov 2011 14:36:22 +0000 (15:36 +0100)]
s4-socket: allow connect_multi_next_socket to try all the IP for a given host

This fix an incorrect behavior which was that if a host has 2 IP but
was listening on only 1 (and the second one) connect_multi_next_socket
was not able to connect because it used only the first result.

7 years agopy_passdb: Cannot steal an item pointer from an array
Amitay Isaacs [Fri, 11 Nov 2011 04:29:35 +0000 (15:29 +1100)]
py_passdb: Cannot steal an item pointer from an array

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Nov 11 12:04:33 CET 2011 on sn-devel-104

7 years agopolicy/tests: Fix import of TestCase.
Jelmer Vernooij [Thu, 10 Nov 2011 22:33:47 +0000 (23:33 +0100)]
policy/tests: Fix import of TestCase.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Nov 11 01:10:49 CET 2011 on sn-devel-104

7 years agoselftesthelper: Fix argument order.
Jelmer Vernooij [Thu, 10 Nov 2011 22:33:31 +0000 (23:33 +0100)]
selftesthelper: Fix argument order.

7 years agoselftest: Make planoldpythontestsuite arguments consistent with planpythontestsuite.
Jelmer Vernooij [Thu, 10 Nov 2011 20:50:38 +0000 (21:50 +0100)]
selftest: Make planoldpythontestsuite arguments consistent with planpythontestsuite.

7 years agoselftesthelpers: Fix syntax error.
Jelmer Vernooij [Thu, 10 Nov 2011 19:44:59 +0000 (20:44 +0100)]
selftesthelpers: Fix syntax error.

7 years agoselftest: Simplify calling of python tests.
Jelmer Vernooij [Thu, 10 Nov 2011 19:39:34 +0000 (20:39 +0100)]
selftest: Simplify calling of python tests.

7 years agoselftest: Allow passing arbitrary number of additional python path values.
Jelmer Vernooij [Thu, 10 Nov 2011 19:24:17 +0000 (20:24 +0100)]
selftest: Allow passing arbitrary number of additional python path values.

7 years agoldb: Re-apply pyldb fixes from Tridge and Amity, using unittest rather
Jelmer Vernooij [Thu, 10 Nov 2011 19:20:00 +0000 (20:20 +0100)]
ldb: Re-apply pyldb fixes from Tridge and Amity, using unittest rather
than samba.tests.

7 years agosubunitrun: Add notes about subunitrun being deprecated.
Jelmer Vernooij [Thu, 10 Nov 2011 13:03:29 +0000 (14:03 +0100)]
subunitrun: Add notes about subunitrun being deprecated.

7 years agoselftest: re-implement directory option for planpythontestsuite.
Jelmer Vernooij [Thu, 10 Nov 2011 12:59:21 +0000 (13:59 +0100)]
selftest: re-implement directory option for planpythontestsuite.

7 years agoRevert "test: added directory option to planpythontestsuite()"
Jelmer Vernooij [Thu, 10 Nov 2011 12:46:01 +0000 (13:46 +0100)]
Revert "test: added directory option to planpythontestsuite()"

This reverts commit b0be72d5080aed3da3f33a45b72f88e90fbe3d13.

I'll add an alternative that uses subunit.run.

7 years agoRevert "test: added -D option to subunitrun"
Jelmer Vernooij [Thu, 10 Nov 2011 12:43:43 +0000 (13:43 +0100)]
Revert "test: added -D option to subunitrun"

This reverts commit ac0bba2ea18e2e9ac578a333a3b260951e4c976e.

"python -m subunit.run" is the preferred way of running tests to
generate subunit. I also don't want to move too far away from
the standard test running infrastructure for python so that
other test runners (nosetests, trial, tribunal, ...) can be used with
Samba code.

7 years agoRevert "pyldb: fixed ldb API test"
Jelmer Vernooij [Thu, 10 Nov 2011 12:40:03 +0000 (13:40 +0100)]
Revert "pyldb: fixed ldb API test"

This reverts commit 333248f08c83cc5b18f8e7e84cb19d79a8309d6e.

This commit made the pyldb tests depend on the Samba testsuite.

7 years agolibcli/cldap/cldap.c - remove outdated comment
Matthias Dieter Wallnöfer [Thu, 10 Nov 2011 16:13:29 +0000 (17:13 +0100)]
libcli/cldap/cldap.c - remove outdated comment

Reviewed-by: metze
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 10 20:32:08 CET 2011 on sn-devel-104

7 years agos3: server_id.pid has turned 64 (bits, that is)
Volker Lendecke [Thu, 10 Nov 2011 16:17:20 +0000 (17:17 +0100)]
s3: server_id.pid has turned 64 (bits, that is)

Fix ctdb_processes_exist protocol. The socket expects pid_t which is 32 bits on
32 bit machines.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 10 18:57:01 CET 2011 on sn-devel-104

7 years agos3: Avoid a race with the async echo handler
Volker Lendecke [Thu, 10 Nov 2011 08:39:23 +0000 (09:39 +0100)]
s3: Avoid a race with the async echo handler

We can not read from the echo handler socket when we have the main socket
locked. This leads to the echo responder to lock up sitting in the fcntl lock
while the parent wants to read the remainder of a large packet.

7 years agolibcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)
Stefan Metzmacher [Thu, 10 Nov 2011 13:43:55 +0000 (14:43 +0100)]
libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)

After a calling any wrapper of tevent_req_notify_callback(),
e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(),
a function has to return immediately otherwise it is very likely to
crash, unless in calls tevent_req_defer_callback() before.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104

7 years agos4:finddcs_cldap: debug the correct server address instead of NULL
Stefan Metzmacher [Thu, 10 Nov 2011 12:18:20 +0000 (13:18 +0100)]
s4:finddcs_cldap: debug the correct server address instead of NULL

metze

7 years agos3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)
Stefan Metzmacher [Wed, 9 Nov 2011 15:04:09 +0000 (16:04 +0100)]
s3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)

This fixes a crash bug that is triggered, when a client has more than
256 directory handles with searches.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 14:08:14 CET 2011 on sn-devel-104

7 years agos3:smbd: fully construct the dptr before allocating a dnum in the bitmap
Stefan Metzmacher [Wed, 9 Nov 2011 14:59:22 +0000 (15:59 +0100)]
s3:smbd: fully construct the dptr before allocating a dnum in the bitmap

metze

7 years agos3:smbd: avoid string_set() in dir.c
Stefan Metzmacher [Thu, 10 Nov 2011 09:39:34 +0000 (10:39 +0100)]
s3:smbd: avoid string_set() in dir.c

And do some more error checks.

metze

7 years agoFix -Wunused-but-set-variable compiler warnings in tevent_signal.c
Martin Schwenke [Wed, 9 Nov 2011 23:46:10 +0000 (10:46 +1100)]
Fix -Wunused-but-set-variable compiler warnings in tevent_signal.c

The results of some read(2) and write(2) calls are assigned into a
variable that is never used.  Presumably this used to avoid compiler
warnings or similar.

However, from (approximately) GCC 4.6 this produces some warnings:

  [ 609/3910] Compiling lib/tevent/tevent_signal.c
  ../lib/tevent/tevent_signal.c: In function ‘tevent_common_signal_handler’:
  ../lib/tevent/tevent_signal.c:85:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
  ../lib/tevent/tevent_signal.c: In function ‘signal_pipe_handler’:
  ../lib/tevent/tevent_signal.c:183:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]

The simplest thing to do is remove the variables and cast the function
return to void.  There is already a comment above each call.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos4: samba-tool time --help documentation improvements
Theresa Halloran [Thu, 10 Nov 2011 01:16:33 +0000 (20:16 -0500)]
s4: samba-tool time --help documentation improvements

Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 10 06:04:22 CET 2011 on sn-devel-104

7 years agos4: samba-tool group --help documentation improvements
Theresa Halloran [Wed, 9 Nov 2011 21:33:37 +0000 (16:33 -0500)]
s4: samba-tool group --help documentation improvements

Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: fixed several tests to use samba.tests
Andrew Tridgell [Wed, 9 Nov 2011 02:28:02 +0000 (13:28 +1100)]
test: fixed several tests to use samba.tests

this fixes error checking. Test failures were not being detected
otherwise

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agosamba-tool: print samaccountname in samba-tool user list
Andrew Tridgell [Wed, 9 Nov 2011 02:27:20 +0000 (13:27 +1100)]
samba-tool: print samaccountname in samba-tool user list

this is the attribute the admin needs for other commands

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: use planpythontestsuite() for ldb.python test
Andrew Tridgell [Wed, 9 Nov 2011 02:10:49 +0000 (13:10 +1100)]
test: use planpythontestsuite() for ldb.python test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: added directory option to planpythontestsuite()
Andrew Tridgell [Wed, 9 Nov 2011 02:10:24 +0000 (13:10 +1100)]
test: added directory option to planpythontestsuite()

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: added -D option to subunitrun
Andrew Tridgell [Wed, 9 Nov 2011 02:10:00 +0000 (13:10 +1100)]
test: added -D option to subunitrun

this allows for:

 subunitrun -D lib/ldb/tests/python api

which makes this easier for developers

7 years agopyldb: fixed ldb API test
Andrew Tridgell [Wed, 9 Nov 2011 02:09:08 +0000 (13:09 +1100)]
pyldb: fixed ldb API test

it was failing previously, but the failure wasn't being noticed

7 years agobuild: only run symbol checking if running all tests
Andrew Tridgell [Wed, 9 Nov 2011 02:08:37 +0000 (13:08 +1100)]
build: only run symbol checking if running all tests

this makes it much faster to run 1 test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agopyldb: enhanced get() method on msg object
Andrew Tridgell [Wed, 9 Nov 2011 02:07:53 +0000 (13:07 +1100)]
pyldb: enhanced get() method on msg object

get() now takes a default value and an idx, allowing for much easier
usage

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agosamba-tool: Added new "user disable" command
Giampaolo Lauria [Tue, 8 Nov 2011 19:59:19 +0000 (14:59 -0500)]
samba-tool: Added new "user disable" command

7 years agosamba-tool: Added "user list" command
Giampaolo Lauria [Tue, 8 Nov 2011 16:51:42 +0000 (11:51 -0500)]
samba-tool: Added "user list" command

7 years agosamba-tool: Change internal argument name in domain machinepassword
Giampaolo Lauria [Mon, 7 Nov 2011 18:39:07 +0000 (13:39 -0500)]
samba-tool: Change internal argument name in domain machinepassword

7 years agosamba-tool: Fix domain machinepassword secret db search
Giampaolo Lauria [Tue, 1 Nov 2011 19:28:54 +0000 (15:28 -0400)]
samba-tool: Fix domain machinepassword secret db search

pair programmed with Jelmer Vernooij
Add search to include secrets.ldb

7 years agosamba-tool: Fix domain machinepassword name search
Giampaolo Lauria [Tue, 1 Nov 2011 19:25:31 +0000 (15:25 -0400)]
samba-tool: Fix domain machinepassword name search

Append '$' to name provided by user to search for a machine account
when necessary

7 years agos4-test: improved error checking in samba-tool time test
Andrew Tridgell [Mon, 7 Nov 2011 04:24:01 +0000 (15:24 +1100)]
s4-test: improved error checking in samba-tool time test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agos4-socket: detect NULL server in socket connection code
Andrew Tridgell [Mon, 7 Nov 2011 04:19:09 +0000 (15:19 +1100)]
s4-socket: detect NULL server in socket connection code

return NT_STATUS_NOT_FOUND instead of a segfault

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: enable time and user samba-tool tests
Sean Dague [Wed, 2 Nov 2011 14:02:47 +0000 (10:02 -0400)]
test: enable time and user samba-tool tests

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: add samba-tool user tests
Sean Dague [Wed, 2 Nov 2011 14:02:29 +0000 (10:02 -0400)]
test: add samba-tool user tests

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: Add samba-tool time tests
Sean Dague [Wed, 2 Nov 2011 14:02:09 +0000 (10:02 -0400)]
test: Add samba-tool time tests

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: add directory and base class for samba-tool tests
Sean Dague [Wed, 2 Nov 2011 14:01:42 +0000 (10:01 -0400)]
test: add directory and base class for samba-tool tests

this allows for more sophisticated testing of samba-tool

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agos4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installations
Andrew Bartlett [Thu, 3 Nov 2011 21:45:49 +0000 (08:45 +1100)]
s4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installations

This servicePrincipalName is incorrect (windows does not use that
servicePrincipalName, as it targets the server it is updating, not the
root of the DNS tree), and now that we have multiple DNS backends that
use the internal database, it is quite incorrect (as it cannot exist
on more than one account).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 10 01:11:46 CET 2011 on sn-devel-104

7 years agos3-py_passdb Ensure that group mapping list input is initailised
Andrew Bartlett [Tue, 8 Nov 2011 21:15:31 +0000 (08:15 +1100)]
s3-py_passdb Ensure that group mapping list input is initailised

This may help to ensure we consistantly crash on an incorrect de-reference.

Andrew Bartlett

7 years agos3-passdb Initialise the correct level of pointer dereference
Andrew Bartlett [Tue, 8 Nov 2011 21:11:32 +0000 (08:11 +1100)]
s3-passdb Initialise the correct level of pointer dereference

*pp_rmap may be NULL or un-initialised data.

This was introduced by 995d1567265be178b4e45f79ea4562a7041ffa52.

Andrew Bartlett

7 years agos4:join.py - fix up "DsAddEntry" against Windows Server 2000
Matthias Dieter Wallnöfer [Wed, 9 Nov 2011 08:32:55 +0000 (09:32 +0100)]
s4:join.py - fix up "DsAddEntry" against Windows Server 2000

It is important to consider the result level regarding error
information. Windows 2000 seems to send us back v2, all other
implementations v3. Consider post "Joining W2k AD domain"

Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov  9 23:37:08 CET 2011 on sn-devel-104

7 years agodocs: Make clear to use the workgroup name not the realm.
Andreas Schneider [Wed, 9 Nov 2011 18:08:16 +0000 (19:08 +0100)]
docs: Make clear to use the workgroup name not the realm.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 21:17:09 CET 2011 on sn-devel-104

7 years agos4: Install samba-tool and samba_kcc to bin/ rather than sbin/.
Jelmer Vernooij [Mon, 7 Nov 2011 13:58:10 +0000 (14:58 +0100)]
s4: Install samba-tool and samba_kcc to bin/ rather than sbin/.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov  9 19:43:07 CET 2011 on sn-devel-104

7 years agosamba_kcc: Remove unnecessary return statements.
Jelmer Vernooij [Mon, 7 Nov 2011 01:04:52 +0000 (02:04 +0100)]
samba_kcc: Remove unnecessary return statements.

7 years agoutil/time: Make some functions explicitly public.
Jelmer Vernooij [Thu, 3 Nov 2011 16:22:40 +0000 (17:22 +0100)]
util/time: Make some functions explicitly public.

7 years agoutil/time: Remove unnecessary _PUBLIC_ - that's implicit for things in header files.
Jelmer Vernooij [Thu, 3 Nov 2011 13:34:08 +0000 (14:34 +0100)]
util/time: Remove unnecessary _PUBLIC_ - that's implicit for things in header files.

7 years agos3:registry: prevent unnecessary transactions in regdb_init
Michael Adam [Wed, 9 Nov 2011 10:14:38 +0000 (11:14 +0100)]
s3:registry: prevent unnecessary transactions in regdb_init

Skip the transaction for the upgrade code, if the database
is already at code-level.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  9 15:06:59 CET 2011 on sn-devel-104

7 years agos3: Use autotools to set the winbind socket directory.
Andreas Schneider [Wed, 9 Nov 2011 10:33:47 +0000 (11:33 +0100)]
s3: Use autotools to set the winbind socket directory.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 13:31:27 CET 2011 on sn-devel-104

7 years agos3:smb2_server: grant credits in async interim responses (bug #8357)
Stefan Metzmacher [Tue, 8 Nov 2011 16:50:43 +0000 (17:50 +0100)]
s3:smb2_server: grant credits in async interim responses (bug #8357)

The first fix for bug #8357 intruduced a regression, so that we no
longer grant credits for real async interim responses with
STATUS_PENDING.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 11:56:29 CET 2011 on sn-devel-104

7 years agos3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)
Stefan Metzmacher [Wed, 9 Nov 2011 07:09:17 +0000 (08:09 +0100)]
s3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)

Otherwise we may get unexpected results.

This is a fix that was missing in commit 95595dd93fd04999fcf56ecaab7c29b064d021f8
(s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326))

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 10:13:32 CET 2011 on sn-devel-104

7 years agos4-provision: Create ldap records for DNS partitions similar to windows
Amitay Isaacs [Tue, 20 Sep 2011 07:33:20 +0000 (17:33 +1000)]
s4-provision: Create ldap records for DNS partitions similar to windows

this allows easy comparison between windows and samba ldap trees

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Nov  9 08:27:46 CET 2011 on sn-devel-104