Andrew Tridgell [Thu, 25 Sep 2008 00:58:15 +0000 (17:58 -0700)]
empty access mask is only denied on SMB2
Andrew Tridgell [Thu, 25 Sep 2008 00:45:48 +0000 (17:45 -0700)]
we should terminate the connection on a bad negprot packet size
Andrew Tridgell [Thu, 25 Sep 2008 00:41:36 +0000 (17:41 -0700)]
for use in python we need to use global_loadparm
Andrew Tridgell [Thu, 25 Sep 2008 00:36:24 +0000 (17:36 -0700)]
- add reserved field in basic_information level
- use INVALID_PARAMETER for info length mismatch to match windows
behaviour
- added parsing of LINK_INFORMATION level
Andrew Tridgell [Thu, 25 Sep 2008 00:34:58 +0000 (17:34 -0700)]
record highest seq number in SMB2 to check for seqnum going backwards
Andrew Tridgell [Thu, 25 Sep 2008 00:34:35 +0000 (17:34 -0700)]
log stream termination
Andrew Tridgell [Thu, 25 Sep 2008 00:34:04 +0000 (17:34 -0700)]
cope with body_size zero in SMB2 receive
Andrew Tridgell [Thu, 25 Sep 2008 00:33:15 +0000 (17:33 -0700)]
check for a 0 byte in the buffer in SMB2 read
Andrew Tridgell [Thu, 25 Sep 2008 00:32:47 +0000 (17:32 -0700)]
the offset is 16 bits in SMB2 fileinfo
Andrew Tridgell [Thu, 25 Sep 2008 00:31:57 +0000 (17:31 -0700)]
zero access mask should give ACCESS_DENIED
Andrew Tridgell [Thu, 25 Sep 2008 00:28:58 +0000 (17:28 -0700)]
- SMB2 uses INVALID_PARAMETER not BUFFER_TOO_SMALL for buffer size
errors
- added a s32o16 buffer function
Andrew Tridgell [Thu, 25 Sep 2008 00:26:42 +0000 (17:26 -0700)]
- use the current dialect first, for servers that only look at the
first dialect
- allow override of SMB2 port in client code
Andrew Tridgell [Thu, 25 Sep 2008 00:20:28 +0000 (17:20 -0700)]
added the structure for LINK_INFORMATION setfileinfo call
Andrew Tridgell [Thu, 25 Sep 2008 00:19:36 +0000 (17:19 -0700)]
be friendlier in smb2_deltree to some of the SMB2 implementations that
don't handle SEC_FLAG_MAXIMUM_ALLOWED
Andrew Tridgell [Thu, 25 Sep 2008 00:18:29 +0000 (17:18 -0700)]
check error code for zero desired_access in SMB2 create
Andrew Tridgell [Thu, 25 Sep 2008 00:17:41 +0000 (17:17 -0700)]
fixed setpathinfo in gentest to not zero the filename/handle
Andrew Tridgell [Wed, 24 Sep 2008 22:40:55 +0000 (15:40 -0700)]
fixed uninitialised variable bug
Andrew Tridgell [Wed, 24 Sep 2008 18:28:58 +0000 (11:28 -0700)]
support NT_STATUS_XX:NT_STATUS_YY syntax in ignore files
Andrew Tridgell [Wed, 24 Sep 2008 15:58:16 +0000 (08:58 -0700)]
fixed error code for bad keepalive
Andrew Tridgell [Wed, 24 Sep 2008 03:01:06 +0000 (20:01 -0700)]
stricter checking of SMB2 echo body (per the spec)
thanks to the bluearc test suite
Jim McDonough [Thu, 25 Sep 2008 00:47:03 +0000 (20:47 -0400)]
Fix the new vfs_smb_traffic_analyzer build for static links
Simo Sorce [Wed, 24 Sep 2008 23:22:39 +0000 (19:22 -0400)]
Temporary build fix for the merged build
Holger Hetterich [Wed, 24 Sep 2008 23:01:00 +0000 (19:01 -0400)]
SMB traffic analyzer vfs module from Holger Hetterich <hhetter@novell.com>
Used to gather data to feed to a database for live and historical
analysis of usage per user, per share, etc.
Helper apps to read the data still to come. This one still needs to be
made ipv6 enabled (connection is made to the helper app).
Jelmer Vernooij [Wed, 24 Sep 2008 21:59:59 +0000 (23:59 +0200)]
Revert LDB return code patches from Matthias.
Jeremy Allison [Wed, 24 Sep 2008 21:28:18 +0000 (14:28 -0700)]
Fix bug #5790 samba returns STATUS_OBJECT_NAME_NOT_FOUND on set file disposition.
We were checking that fd != -1 in file_find_di_XXX calls which is no longer
needed due to a change in internal semantics.
Jeremy.
Stefan Metzmacher [Wed, 24 Sep 2008 20:49:05 +0000 (22:49 +0200)]
build: fix the libcryptosrcdir for the merged build
metze
Stefan Metzmacher [Tue, 23 Sep 2008 08:34:06 +0000 (10:34 +0200)]
s3:configure: add -L./bin also for the merged build
metze
Jelmer Vernooij [Wed, 24 Sep 2008 18:14:17 +0000 (20:14 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Karolin Seeger [Wed, 24 Sep 2008 16:53:21 +0000 (09:53 -0700)]
printing: Rename new parameter "cups timeout" to "cups connection timeout".
Karolin
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:37:33 +0000 (17:37 +0200)]
Cosmetic corrections for the KERBEROS library
This commit applies some cosmetic corrections for the KERBEROS library.
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 13:34:58 +0000 (15:34 +0200)]
Kerberos cosmetic changes: Revert a part of the patch
Reverts a part of the patch because it changes the function of the code (suggested by Jelmer).
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:37:33 +0000 (17:37 +0200)]
Cosmetic corrections for the KERBEROS library
This commit applies some cosmetic corrections for the KERBEROS library.
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:36:52 +0000 (17:36 +0200)]
Cosmetic corrections for the LDB library
This commit applies some cosmetic corrections for the LDB library.
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:36:14 +0000 (17:36 +0200)]
Cosmetic corrections for the LDB backend modules
This commit applies some cosmetic corrections for the LDB backend modules.
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:06:13 +0000 (17:06 +0200)]
Cosmetic corrections for the DSDB module
This commit applies some cosmetic corrections for the DSDB (Directory Server Database).
Jelmer Vernooij [Wed, 24 Sep 2008 17:27:09 +0000 (19:27 +0200)]
Use loadparm since it's required by some modules.
Jelmer Vernooij [Wed, 24 Sep 2008 16:49:58 +0000 (18:49 +0200)]
Add separate header file for arcfour.
Jelmer Vernooij [Wed, 24 Sep 2008 14:46:02 +0000 (16:46 +0200)]
Use common crc32 implementation.
Jelmer Vernooij [Wed, 24 Sep 2008 14:11:13 +0000 (16:11 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into crypto
Jelmer Vernooij [Wed, 24 Sep 2008 14:10:53 +0000 (16:10 +0200)]
Fix include paths.
Jelmer Vernooij [Wed, 24 Sep 2008 14:10:34 +0000 (16:10 +0200)]
Clean .o files in lib/ and libcli/ too.
Jelmer Vernooij [Wed, 24 Sep 2008 13:44:34 +0000 (15:44 +0200)]
Use shared copy of hmac5 implementation.
Jelmer Vernooij [Wed, 24 Sep 2008 13:37:15 +0000 (15:37 +0200)]
Use common md4 implementation.
Jelmer Vernooij [Wed, 24 Sep 2008 13:34:30 +0000 (15:34 +0200)]
Use common MD5.
Jelmer Vernooij [Wed, 24 Sep 2008 13:30:23 +0000 (15:30 +0200)]
Move source4/lib/crypto to lib/crypto.
Simo Sorce [Wed, 24 Sep 2008 05:37:16 +0000 (01:37 -0400)]
Fix nasty bug that would come up only if a client connection to a remote
ldap server suddenly dies.
We were creating a wrong talloc hierarchy, so the event.fde was not
freed automatically as expected. This in turn made the event system call
the ldap io handlers with a null packet structure, causing a segfault.
Fix also the ordering in ldap_connection_dead()
Thanks to Metze for the huge help in tracking down this one.
Simo Sorce [Wed, 24 Sep 2008 05:34:10 +0000 (01:34 -0400)]
Fix python test, we can't check only the first member, because the order
is not guaranteed
Jelmer Vernooij [Wed, 24 Sep 2008 02:41:30 +0000 (04:41 +0200)]
Use new binary name in merged build.
Jelmer Vernooij [Wed, 24 Sep 2008 02:34:54 +0000 (04:34 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Stefan Metzmacher [Wed, 24 Sep 2008 01:59:53 +0000 (03:59 +0200)]
s4:libcli/smb_composite: we only check the signature when the server return OK
We need to manually free the request, otherwise the timeout handler is
triggered later.
metze
Günther Deschner [Wed, 24 Sep 2008 01:51:25 +0000 (03:51 +0200)]
libcli: add nbt_proto.h that is no longer autogenerated.
Guenther
Günther Deschner [Wed, 24 Sep 2008 00:44:34 +0000 (02:44 +0200)]
s3: fix idmap_adex.
Guenther
Günther Deschner [Tue, 23 Sep 2008 23:16:10 +0000 (01:16 +0200)]
libcli: add some basic debugging functions for netlogon helper.
Guenther
Günther Deschner [Tue, 23 Sep 2008 20:21:52 +0000 (22:21 +0200)]
s3-nbt: use the new generated nbt.
Guenther
Günther Deschner [Tue, 23 Sep 2008 20:16:15 +0000 (22:16 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 23 Sep 2008 20:15:38 +0000 (22:15 +0200)]
s3-nbt: full merge of s4 nbt idl.
Guenther
Günther Deschner [Wed, 24 Sep 2008 00:25:34 +0000 (02:25 +0200)]
s3: fix merged_build.
Guenther
Jelmer Vernooij [Wed, 24 Sep 2008 01:16:15 +0000 (03:16 +0200)]
Rename smbd -> samba.
This reverts commit
05ea5e23cf4e70de0bd658b1c5c0ead133967091.
Conflicts:
source4/smbd/server.c
Karolin Seeger [Tue, 23 Sep 2008 23:54:05 +0000 (16:54 -0700)]
printing: Add new parameter "cups timeout".
The default timeout for connections to CUPS servers is set
to 5 minutes in the CUPS libraries. The smbd hangs on startup
until the timeout is reached if the CUPS server is unreachable.
This parameter makes the timeout configurable. The default value
is set to 30 seconds.
Karolin
Günther Deschner [Tue, 23 Sep 2008 23:40:13 +0000 (01:40 +0200)]
s3: fix make everything.
Guenther
Jeremy Allison [Tue, 23 Sep 2008 23:39:57 +0000 (16:39 -0700)]
Fix winbindd crash in an unusual failure mode. Bug #5737. Based on original patch from shargagan@novell.com
Jeremy.
Günther Deschner [Tue, 23 Sep 2008 23:13:51 +0000 (01:13 +0200)]
libcli: add autogenerated libcli netlogon helper protos.
Guenther
Günther Deschner [Tue, 23 Sep 2008 23:11:38 +0000 (01:11 +0200)]
s4: remove autogeneration of libcli/netlogon protos.
we do need to have them around for samba3.
Guenther
Simo Sorce [Tue, 23 Sep 2008 18:30:06 +0000 (14:30 -0400)]
Merge ldb_search() and ldb_search_exp_fmt() into a simgle function.
The previous ldb_search() interface made it way too easy to leak results,
and being able to use a printf-like expression turns to be really useful.
Jeremy Allison [Tue, 23 Sep 2008 22:05:45 +0000 (15:05 -0700)]
Fix bug #5783 FindFirst fails where search pattern == mangled filename.
That was an old and subtle bug.
Jeremy.
Günther Deschner [Tue, 23 Sep 2008 21:41:39 +0000 (23:41 +0200)]
pam_winbind: attempt to fix build issue on solaris, bug #5784
Guenther
Günther Deschner [Tue, 23 Sep 2008 18:43:41 +0000 (20:43 +0200)]
s3-ndr: add stub smb_iconv_convenience to some ndr_ functions.
Guenther
Günther Deschner [Tue, 23 Sep 2008 18:59:30 +0000 (20:59 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 23 Sep 2008 19:00:09 +0000 (21:00 +0200)]
pidl: fix samba3 server wrt to samba4 ndr_pull_init_blob protype.
this is in preparation for the final nbt merge.
Guenther
Günther Deschner [Tue, 23 Sep 2008 19:08:25 +0000 (21:08 +0200)]
s3: fix NETLOGON_NT_VERSION version flags.
Guenther
Günther Deschner [Tue, 23 Sep 2008 19:07:56 +0000 (21:07 +0200)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Tue, 23 Sep 2008 20:35:16 +0000 (22:35 +0200)]
s3-nbt: start merging from samba4 idl.
Guenther
Günther Deschner [Tue, 23 Sep 2008 21:14:40 +0000 (23:14 +0200)]
s4-nbt: use moved libcli netlogon helpers.
Guenther
Günther Deschner [Tue, 23 Sep 2008 20:48:57 +0000 (22:48 +0200)]
s4-libcli: move nbt/netlogon helper functions up one level.
Guenther
Günther Deschner [Tue, 23 Sep 2008 20:24:46 +0000 (22:24 +0200)]
s3-build: let ctags/etags start from the toplevel dir.
Guenther
Volker Lendecke [Tue, 23 Sep 2008 20:44:21 +0000 (22:44 +0200)]
S3 puts smb.conf and lmhosts in lib/, s4 into etc/
Stefan Metzmacher [Tue, 23 Sep 2008 19:06:41 +0000 (21:06 +0200)]
s4:lib/charset: add missing prototype of talloc_strdup_upper()
metze
Andrew Tridgell [Tue, 23 Sep 2008 18:17:43 +0000 (11:17 -0700)]
fixed problem with ACLs with an empty DACL list
Andrew Tridgell [Tue, 23 Sep 2008 18:15:46 +0000 (11:15 -0700)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Stefan Metzmacher [Tue, 9 Sep 2008 19:15:54 +0000 (21:15 +0200)]
selftest: run smb signing tests as part of make quicktest
metze
Stefan Metzmacher [Tue, 9 Sep 2008 19:10:08 +0000 (21:10 +0200)]
selftest: test some smb signing combinations against the member server
metze
Stefan Metzmacher [Tue, 23 Sep 2008 00:30:15 +0000 (02:30 +0200)]
s4:smb_server: remove the bogus smbsrv_signing_restart()
Real signing always starts with seqnumber 2, and once signing
is on the session key never change anymore for the complete
smb connection.
metze
Stefan Metzmacher [Tue, 9 Sep 2008 16:02:07 +0000 (18:02 +0200)]
libcli/smb_composite: for spnego session setups check the smb signature manually
We need to start signing when we got NT_STATUS_OK from the server
and manually check the signature of the servers response.
This is needed as the response might be signed with the krb5 acceptor subkey,
which comes within the server response.
With NTLMSSP this happens for the session setup:
request1 => BSRSPYL seqnum: 0
response1 => BSRSPYL seqnum: 0
request2 => BSRSPYL seqnum: 0
response2 => <SIGNATURE> seqnum: 1
and with krb5:
request1 => BSRSPYL seqnum: 0
response1 => <SIGNATURE> seqnum: 1
metze
Stefan Metzmacher [Tue, 23 Sep 2008 00:29:20 +0000 (02:29 +0200)]
libcli/raw: real signing starts at seqnumber 2
metze
Stefan Metzmacher [Tue, 9 Sep 2008 15:56:11 +0000 (17:56 +0200)]
libcli/raw: in SMB_SIGNING_ENGINE_BSRSPYL state it's ok to accept any signature
Even if signing is mandatory.
With NTLMSSP this happens for the session setup:
request1 => BSRSPYL
response1 => BSRSPYL
request2 => BSRSPYL
response2 => <SIGNATURE>
and with krb5:
request1 => BSRSPYL
response1 => <SIGNATURE>
metze
Stefan Metzmacher [Tue, 9 Sep 2008 15:54:13 +0000 (17:54 +0200)]
libcli/raw: give the caller the chance to do the signing checks on its own.
metze
Stefan Metzmacher [Tue, 9 Sep 2008 15:50:30 +0000 (17:50 +0200)]
libcli/raw: give the caller the chance to prevent the talloc_free(req) in the _recv functions
metze
Stefan Metzmacher [Thu, 11 Sep 2008 04:47:06 +0000 (06:47 +0200)]
gensec_krb5: only give away the session key, when the authentication is done
metze
Stefan Metzmacher [Thu, 11 Sep 2008 04:46:43 +0000 (06:46 +0200)]
gensec_gssapi: only give away the session key, when the authentication is done
metze
Stefan Metzmacher [Thu, 11 Sep 2008 04:40:26 +0000 (06:40 +0200)]
ntlmssp: only give away the session key, when the authentication is done
metze
Stefan Metzmacher [Tue, 23 Sep 2008 00:14:26 +0000 (02:14 +0200)]
RPC-PAC: loop in gensec_update() untill the server side is ready
metze
Günther Deschner [Tue, 23 Sep 2008 08:04:17 +0000 (10:04 +0200)]
s3-nbt: remove old samba3 libcli/nbt copy.
Guenther
Michael Adam [Sun, 21 Sep 2008 00:07:43 +0000 (02:07 +0200)]
[s3]winbindd_group: don't list the domain twice when expanding internal aliases
Before this, "getent group builtin\\administrators" expanded
domain group members in the form DOMAIN\domain\user.
Michael
Michael Adam [Sun, 21 Sep 2008 00:06:44 +0000 (02:06 +0200)]
[s3]winbindd_group: sanely handle NULL domain in add_member().
Michael
Michael Adam [Mon, 22 Sep 2008 08:39:37 +0000 (10:39 +0200)]
[s3]winbindd_ads: honour "winbind use default domain" in lookup_groupmem().
This fixes the output of "getent group" when "winbind use default domain = yes"
with security = ads.
Michael
Michael Adam [Sat, 20 Sep 2008 23:20:32 +0000 (01:20 +0200)]
[s3]winbindd_rpc: add domain prefix to username in lookup_groupmem().
This makes the output of "getent group" of a domain group show the
domain prefix with "security = domain".
Michael
Michael Adam [Mon, 22 Sep 2008 08:37:11 +0000 (10:37 +0200)]
[s3]winbindd_util: add fill_domain_username_talloc().
A talloc version of fill_domain_username().
Michael
Michael Adam [Mon, 22 Sep 2008 08:36:32 +0000 (10:36 +0200)]
[s3]winbindd_util: add prototype for fill_domain_username_talloc().
A talloc version of fill_domain_username().
Michael
Michael Adam [Mon, 22 Sep 2008 12:51:51 +0000 (14:51 +0200)]
[s3]winbindd: fix a comment typo
Michael
Michael Adam [Mon, 22 Sep 2008 08:34:57 +0000 (10:34 +0200)]
[s3]winbind_util: fix an implicit cast compile warning.
Michael