kai/samba.git
22 years agoAdding first cut of the new Red Hat Linux packaging tools.
John Terpstra [Fri, 21 Aug 1998 14:20:38 +0000 (14:20 +0000)]
Adding first cut of the new Red Hat Linux packaging tools.
Note: It is intended to extend this so that the release
process produces all the packaging scripts, templates, etc.
that may be needed.
(This used to be commit 6e196841c618044d33da45d3de5371004a58e4c6)

22 years agoadded new smb.conf option "panic action". see my samba-technical
Andrew Tridgell [Fri, 21 Aug 1998 11:37:40 +0000 (11:37 +0000)]
added new smb.conf option "panic action". see my samba-technical
explanation.
(This used to be commit c6899df44c34088a4d2bf1edc840320b0ba7e32e)

22 years agouse ZERO_STRUCT() to initialise lots of structures.
Andrew Tridgell [Fri, 21 Aug 1998 09:44:30 +0000 (09:44 +0000)]
use ZERO_STRUCT() to initialise lots of structures.

Luke, you need to do something similar in the rest of the rpc code.
Have fun!
(This used to be commit bdd8aaa544780898e20189195d4019b9beb4445c)

22 years agoadded a macro ZERO_STRUCT() which is useful for initialising
Andrew Tridgell [Fri, 21 Aug 1998 09:43:21 +0000 (09:43 +0000)]
added a macro ZERO_STRUCT() which is useful for initialising
structures declared on the stack.
(This used to be commit f323af8fce54cd5d51c848aa7ea7be4dd3538f2e)

22 years agoSubmitting the smbtar changes to the main branch as well.
Richard Sharpe [Fri, 21 Aug 1998 09:01:30 +0000 (09:01 +0000)]
Submitting the smbtar changes to the main branch as well.

Regards
Richard Sharpe
(This used to be commit 749ec1e0a79c5836bba0fc0213576ed79ef761d5)

22 years agoFix "make clean" to also delete SPROGS.
John Terpstra [Fri, 21 Aug 1998 08:21:08 +0000 (08:21 +0000)]
Fix "make clean" to also delete SPROGS.
(This used to be commit 268cbede0fd909da1cb5bbc964244456f32006a6)

22 years agoand get the message right ...
Andrew Tridgell [Fri, 21 Aug 1998 07:29:42 +0000 (07:29 +0000)]
and get the message right ...
(This used to be commit 0d641d0cebfbd8cc6015d2361e088ce0410c5d20)

22 years agosilly me.
Andrew Tridgell [Fri, 21 Aug 1998 07:25:57 +0000 (07:25 +0000)]
silly me.

perms on lock dir should be 755 not 644.
(This used to be commit 930a4292e95947d20696b7ce08bbb936442fe327)

22 years agofixed a bug in trans2_qfilepathinfo() where we used the length of the
Andrew Tridgell [Fri, 21 Aug 1998 05:58:57 +0000 (05:58 +0000)]
fixed a bug in trans2_qfilepathinfo() where we used the length of the
basename of a file but the whole file name. silly error.
(This used to be commit 6e00de7a1d3d5f9fa9bcc40db119fcb8602165c9)

22 years agoFixes for the problem in blocking locks with file_fsp returning the
Jeremy Allison [Fri, 21 Aug 1998 01:30:29 +0000 (01:30 +0000)]
Fixes for the problem in blocking locks with file_fsp returning the
chain_fsp on close (if you don't know what this means, consider yourself
lucky - this one took a day to track down :-).
Jeremy.
(This used to be commit 193cb5382464173e99a538867a266d793f0ceab5)

22 years agoTurning on blocking locking code. NB. Blocking lock requests that are not
Jeremy Allison [Thu, 20 Aug 1998 19:28:37 +0000 (19:28 +0000)]
Turning on blocking locking code. NB. Blocking lock requests that are not
the head of an SMB request (ie. are part of a chain) will not be queued -
this will be fixed when we move to the new chain code. In practice, this
doesn't seem to cause much of a problem (in my admittedly limited testing)
bug a debug level zero message will be placed in the log when this
happens to help determine how real the problem is.

smbd/locking.c: New debug messages.
smbd/blocking.c: New blocking code - handles SMBlock, SMBlockread and SMBlockingX
smbd/chgpasswd.c: Fix for master fd leak.
smbd/files.c: Tidyup comment.
smbd/nttrans.c: Added fnum to debug message.
smbd/process.c: Made chain_reply() use construct_reply_common(). Added blocking
                lock queue processing into idle loop.
smbd/reply.c: Added queue pushes for SMBlock, SMBlockread and SMBlockingX.
Jeremy.
(This used to be commit e1dd03ecda0bc6d7eaa31070c83774bb5679fd1b)

22 years agotestparm now prints a warning if the lock directory doesn't have 0644
Andrew Tridgell [Thu, 20 Aug 1998 03:11:46 +0000 (03:11 +0000)]
testparm now prints a warning if the lock directory doesn't have 0644
permissions.
(This used to be commit 10303a78d4b12a03166db89202759cd745c516c5)

22 years agoadded a test for a working setresuid
Andrew Tridgell [Wed, 19 Aug 1998 15:01:03 +0000 (15:01 +0000)]
added a test for a working setresuid
(This used to be commit dbe333b590ef004ccbd31a14ad161d73139b2486)

22 years agoBlocking lock code split out...
Jeremy Allison [Wed, 19 Aug 1998 01:49:57 +0000 (01:49 +0000)]
Blocking lock code split out...
Jeremy.
(This used to be commit 9cdb148ef56dc8f74891f5c6e9cae10142bd4c6e)

22 years agoMakefile.in: Moved blocking lock code into smbd/blocking.c for link purposes.
Jeremy Allison [Wed, 19 Aug 1998 01:49:34 +0000 (01:49 +0000)]
Makefile.in: Moved blocking lock code into smbd/blocking.c for link purposes.
include/includes.h: Added nterr.h.
locking/locking.c: Moved blocking lock code into smbd/blocking.c for link purposes.
smbd/close.c: Added blocking lock removal to file close.
smbd/filename.c: Tidied up unix_convert() so I could read it (:-) in preparation
                 for the stat_cache code.
smbd/nttrans.c: Added WRITE_ATTRIBUTES check.
smbd/reply.c: Fixed multibyte char problem in wildcard mask.
Jeremy.
(This used to be commit 148eaba3dadb1d0bd3ac3ef53da3d9811636e89a)

22 years agosmbd/nttrans.c: Fixed bug in split off pipe code.
Jeremy Allison [Mon, 17 Aug 1998 23:39:59 +0000 (23:39 +0000)]
smbd/nttrans.c: Fixed bug in split off pipe code.
locking/locking.c: More blocking lock changes.
Jeremy.
(This used to be commit 2ca4fc95a4227645f1009a057d46b58508846a92)

22 years agoFixed bug introduced by the recent changes where the chain_fnum
Jeremy Allison [Mon, 17 Aug 1998 22:59:53 +0000 (22:59 +0000)]
Fixed bug introduced by the recent changes where the chain_fnum
could be overwritten in oplock processing code.
Jeremy.
(This used to be commit 908a583b48e37c5e869216f4dc92d4a587ff1238)

22 years agoremoved some of the rough edges from the splitup
Andrew Tridgell [Mon, 17 Aug 1998 14:11:44 +0000 (14:11 +0000)]
removed some of the rough edges from the splitup
(This used to be commit 722312c326d54849e2552327fcd88ac77257ad2c)

22 years agomove soem variables from server.c that don't belong there.
Andrew Tridgell [Mon, 17 Aug 1998 13:44:05 +0000 (13:44 +0000)]
move soem variables from server.c that don't belong there.
(This used to be commit f92475aa3cb3ade576c39c02c7996c949c42082a)

22 years agothis completes the splitup of server.c.
Andrew Tridgell [Mon, 17 Aug 1998 13:11:34 +0000 (13:11 +0000)]
this completes the splitup of server.c.

the splitup was done with an axe, not a scalpel, so there are some
rough edges. I mostly wanted to get the general form right with fine
tuning of what goes where to come later. Still, this is better than
what we had before where server.c was a general repository for
anything that didn't fit elsewhere.
(This used to be commit a6d194886a4a5f7507fa37289ff96c1be56f14a6)

22 years agomore splitting of server.c
Andrew Tridgell [Mon, 17 Aug 1998 07:40:06 +0000 (07:40 +0000)]
more splitting of server.c

created dosmode.c and filename.c
(This used to be commit 534a90ca44641417c21f6ed6d4b94b1de60f808d)

22 years agonow that we have no global arrays we can start to split up the monster
Andrew Tridgell [Mon, 17 Aug 1998 07:15:54 +0000 (07:15 +0000)]
now that we have no global arrays we can start to split up the monster
server.c without breaking things.

this splits off netprot.c and fileio.c for negprot and read/write/seek
handling respectively.
(This used to be commit b3d7014643ec9f2eef6e6f598f5b9db1fe2f930d)

22 years agoadded some optimisation for the case where the number of open files is
Andrew Tridgell [Mon, 17 Aug 1998 06:47:53 +0000 (06:47 +0000)]
added some optimisation for the case where the number of open files is
very large. files.c now promotes a files_struct to the top of the list
if it is used when it is more than 10 elements from the top.

also moved common linked list code for the 5 sets of linked lists that
I've created over the past few days into dlinklist.h (I've explained
to Chris why I didn't use the ubiqx code)
(This used to be commit 1eb9ae2996b5a243a147f485e7e353d54f820852)

22 years agoreduced the memory footprint a bit by changing some large static int
Andrew Tridgell [Mon, 17 Aug 1998 06:14:52 +0000 (06:14 +0000)]
reduced the memory footprint a bit by changing some large static int
arrays to uchar
(This used to be commit 01b642a3793a1bea0517370a9a64945fd86ddf02)

22 years agomoved connection_struct handling code into smbd/conn.c and changed it
Andrew Tridgell [Mon, 17 Aug 1998 06:13:32 +0000 (06:13 +0000)]
moved connection_struct handling code into smbd/conn.c and changed it
to a linked list with bitmap format.
(This used to be commit b7aaab1b6b2d2f72b2bb7c11f5c7bf081a6093d9)

22 years agoconverted the policy code to use a linked list and bitmap. This saves
Andrew Tridgell [Mon, 17 Aug 1998 04:54:06 +0000 (04:54 +0000)]
converted the policy code to use a linked list and bitmap. This saves
us a bit of memory.
(This used to be commit 27da84b90df1f32e0d07acad04c72065b2005470)

22 years agomuch cleaner chain pointer handling for both files and pipes.
Andrew Tridgell [Mon, 17 Aug 1998 03:52:05 +0000 (03:52 +0000)]
much cleaner chain pointer handling for both files and pipes.

the chain pointer is now stored as a static and is set whenever a
handle is created or extracted. This also makes the code less error
prone.
(This used to be commit 068a862982bea726e8d7b1b4065d510b9840a272)

22 years agosome cleanups from the conversion of Pipes[] to a linked list. I also
Andrew Tridgell [Mon, 17 Aug 1998 03:06:20 +0000 (03:06 +0000)]
some cleanups from the conversion of Pipes[] to a linked list. I also
removed most cases where a pnum is used and substituted a pipes_struct*.

in files.c I added a offset of 0x1000 to all file handles on the
wire. This makes it much less likely that bad parsing will give us the
wrong field.
(This used to be commit 8bc2627ff28d340db65bfa017daca2dc291d5ef7)

22 years agoI think it is pretty much decided that the next major version will be
Andrew Tridgell [Sun, 16 Aug 1998 13:02:35 +0000 (13:02 +0000)]
I think it is pretty much decided that the next major version will be
2.0, so I've updated version.h to reflect this. I've put in
"2.0.0-prealpha".
(This used to be commit f1c67a00b8603bf1a9e6bef680c0d563727ba108)

22 years ago- some tidying up in files.c
Andrew Tridgell [Sun, 16 Aug 1998 06:20:18 +0000 (06:20 +0000)]
- some tidying up in files.c

- handle null fsp in DEBUG() at end of reply_ntcreate_and_X(). Jeremy,
  can you fix this properly?

- get snum right in print queue code in ipc.c (it was broken by my
  connections_struct changes).
(This used to be commit b3dd3785751db2d5d0a80ffac9c3df01c9909891)

22 years agofixed some bugs in the locking_slow code caused by the recent changes.
Andrew Tridgell [Sun, 16 Aug 1998 05:23:54 +0000 (05:23 +0000)]
fixed some bugs in the locking_slow code caused by the recent changes.

also fixed a couple of %s/%d bugs in locking slow that have been there
for a while but are now revealed by the gcc printf argument testing.
(This used to be commit 16228c185a7844a243db538aa1e5729e62a8bc4a)

22 years agoadded include of sys/resource.h
Andrew Tridgell [Sun, 16 Aug 1998 05:22:01 +0000 (05:22 +0000)]
added include of sys/resource.h
(This used to be commit bf136b4fa8aeadcea8f65610148d46d093aba2cc)

22 years agogot rid of the Files[] array completely (previously I'd just made it
Andrew Tridgell [Sun, 16 Aug 1998 04:08:47 +0000 (04:08 +0000)]
got rid of the Files[] array completely (previously I'd just made it
private to files.c)

It now is a doubly linked list with a bitmap for allocated file
numbers. Similarly for the fd_ptr code. I also changed the default
maximum number of open files to 4096. The static cost is 1 bit per
file.

It all seems to work, and it passes the "does Sue scream" test, but if
you see weird behaviour then please investigate. With the volume of
new code that has gone in there are bound to be one or two bugs
lurking.

note that you must do a "make clean" before building this as many data
structures have changed in size.
(This used to be commit 79755ce97004b787d7e83a8d18fc4c7c003b7231)

22 years agoserver.c: fixed a bug in close_file() with the new files.c handling code
Andrew Tridgell [Sun, 16 Aug 1998 03:04:06 +0000 (03:04 +0000)]
server.c: fixed a bug in close_file() with the new files.c handling code
bitmap.c: added bitmap hanlding code in preparation for increasing the
          default max open files to several thousand
(This used to be commit f573a65b67e7a57586fec57845598e49b157ee0a)

22 years agochanged find_free_file() to file_new().
Andrew Tridgell [Sun, 16 Aug 1998 02:32:55 +0000 (02:32 +0000)]
changed find_free_file() to file_new().
(This used to be commit 3daee29636dcb2d99a0e7c08179a098befae00dc)

22 years agothis checkin gets rid of the global Files[] array and makes it local
Andrew Tridgell [Sat, 15 Aug 1998 07:27:34 +0000 (07:27 +0000)]
this checkin gets rid of the global Files[] array and makes it local
in files.c

it should now be faily easy to expand the default MAX_OPEN_FILES to
many thousands.
(This used to be commit b088c804f98908eb02f05ab2f2e8a61691a0a582)

22 years agouse user instead of this_user to prevent global shadowing
Andrew Tridgell [Sat, 15 Aug 1998 03:31:57 +0000 (03:31 +0000)]
use user instead of this_user to prevent global shadowing
(This used to be commit 76e523907c2ee51031341c3cef9e9f6b5b2d9dc4)

22 years agosome more dummy files to ignore
Andrew Tridgell [Sat, 15 Aug 1998 03:28:30 +0000 (03:28 +0000)]
some more dummy files to ignore
(This used to be commit 571b522bec5bb8ffa4f726c695b57fa2fc04ee01)

22 years agomoved the printing related files to a separate printing/ directory.
Andrew Tridgell [Sat, 15 Aug 1998 03:26:52 +0000 (03:26 +0000)]
moved the printing related files to a separate printing/ directory.
(This used to be commit d933a47be6fa7b5f161179fa11244aaba1051160)

22 years agoconfigure: Changes for extra headers.
Jeremy Allison [Sat, 15 Aug 1998 01:19:26 +0000 (01:19 +0000)]
configure: Changes for extra headers.
configure.in: Source for header changes.
client/clitar.c: Fixed isXXX macros & debugs for gcc pedantic compile.
include/config.h.in: Added MEMSET, BZERO, MEMORY, RPCSVC_YPCLNT, STRINGS headers.
include/includes.h: Headers for the above.
include/smb.h: Made SIGNAL_CAST POSIX by default void (*)(int).
lib/access.c: Fixed isXXX macros & debugs for gcc pedantic compile.
lib/charset.c: Fixed isXXX macros & debugs for gcc pedantic compile.
lib/debug.c: Fixed signal functs.
lib/kanji.c: Fixed isXXX macros & debugs for gcc pedantic compile.
lib/smbrun.c: Fixed isXXX macros & debugs for gcc pedantic compile.
lib/util.c: Fixed isXXX macros & debugs for gcc pedantic compile.
libsmb/namequery.c: Fixed isXXX macros & debugs for gcc pedantic compile.
locking/shmem.c: Fixed isXXX macros & debugs for gcc pedantic compile.
locking/shmem_sysv.c: Fixed error messages in sysV stuff.
nmbd/asyncdns.c: Fixed signal functs.
nmbd/nmbd.c: Fixed isXXX macros & debugs for gcc pedantic compile.
passdb/passdb.c: Fixed isXXX macros & debugs for gcc pedantic compile.
passdb/smbpassfile.c: Fixed isXXX macros & debugs for gcc pedantic compile.
smbd/chgpasswd.c: Fixed isXXX macros & debugs for gcc pedantic compile.
smbd/ipc.c: Fixed isXXX macros & debugs for gcc pedantic compile.
smbd/nttrans.c: Fixed fsp code path.
smbd/password.c: fixed HAVE_YP_GET_DEFAULT_DOMAIN problem.
smbd/printing.c: Fixed isXXX macros & debugs for gcc pedantic compile.
smbd/reply.c: Fixed isXXX macros & debugs for gcc pedantic compile.
smbd/server.c: Fixed isXXX macros & debugs for gcc pedantic compile.
smbd/trans2.c: Fixed core dump bug.
smbd/uid.c: Fixed isXXX macros & debugs for gcc pedantic compile.
Jeremy.
(This used to be commit 1b9cbcd02e575dc0a95fa589f720df30a4acc46b)

22 years agothis is the bug change to using connection_struct* instead of cnum.
Andrew Tridgell [Fri, 14 Aug 1998 17:38:29 +0000 (17:38 +0000)]
this is the bug change to using connection_struct* instead of cnum.
Connections[] is now a local array in server.c

I might have broken something with this change. In particular the
oplock code is suspect and some .dll files aren't being oplocked when
I expected them to be. I'll look at it after I've got some sleep.
(This used to be commit c7ee025ead4a85b6fa44a832047b878451845fb6)

22 years agoremove an unused variable
Andrew Tridgell [Fri, 14 Aug 1998 06:26:31 +0000 (06:26 +0000)]
remove an unused variable
(This used to be commit 6f9228b01131d0fad464971297393ccb8a15703f)

22 years agodefine INADDR_NONE if not already defined
Andrew Tridgell [Fri, 14 Aug 1998 06:25:26 +0000 (06:25 +0000)]
define INADDR_NONE if not already defined
(This used to be commit 7446540017e29827900981cab5ae3a2f9f7b3ce6)

22 years agoMakefile.in: Changed so that make proto will work with ldap & nisplus.
Jeremy Allison [Fri, 14 Aug 1998 02:02:40 +0000 (02:02 +0000)]
Makefile.in: Changed so that make proto will work with ldap & nisplus.
locking/locking.c: Made #ifdef'ed out functions static for Make proto.
lib/util.c: Re-instated old mask_match code for UNIX filesystem checks
            only. Client calls use the new mask_match code. Changed the
            name of the old function to unix_mask_match.
Jeremy.
(This used to be commit b68e756ff57622c6c74f28031d4be964d7b1c9bc)

22 years agoAdded the '--with-netatalk' option to turn Netatalk support on at
John Blair [Thu, 13 Aug 1998 19:00:04 +0000 (19:00 +0000)]
Added the '--with-netatalk' option to turn Netatalk support on at
compile-time.
(This used to be commit 2ba4b66a74cfe736cf2a64ba99b1ab3d83878fc6)

22 years agoAdded the APPLEDOUBLE macro for the name of the directory containing
John Blair [Thu, 13 Aug 1998 18:56:09 +0000 (18:56 +0000)]
Added the APPLEDOUBLE macro for the name of the directory containing
a file's Macintosh resource fork (normally .AppleDouble under Netatalk).
(This used to be commit 1313451f2161f69d33e7f1d41a1bf5615f61014c)

22 years agoUh... I'm checking stuff in. Jeremy will by *so* pleased :)
John Blair [Thu, 13 Aug 1998 18:46:35 +0000 (18:46 +0000)]
Uh... I'm checking stuff in.  Jeremy will by *so* pleased :)

netatalk.c contains the meat of the code required to move Macintosh resource
forks around when Windows users manipulate files created by a mac.  This
allows for greater integration between netatalk and Samba, but is, of course,
potentially a recipe for disaster.  All the netatalk related code is insulated
by #ifdefs from the standard build.
(This used to be commit 05a5243d841cecd128e29379eab2a2784262ccc7)

22 years agomove smbd/print_svid.o from SMBD_OBJ1 to PARAM_OBJ so that nmbd, swat, etc.
Herb Lewis [Thu, 13 Aug 1998 17:38:26 +0000 (17:38 +0000)]
move smbd/print_svid.o from SMBD_OBJ1 to PARAM_OBJ so that nmbd, swat, etc.
will link when SYSV is defined. We may want to restructure this later and
move this to param instead of smbd ???
(This used to be commit 3eff609b7a44c668ec866a2c978fcbe89a282935)

22 years agoreturn to old behaviour of dumping ALL parameters
Herb Lewis [Thu, 13 Aug 1998 16:32:20 +0000 (16:32 +0000)]
return to old behaviour of dumping ALL parameters
(This used to be commit aa5648ce833a13b202e4d3e5304494c3bab6855f)

22 years agoHAVE_STATVFS should be STAT_STAVFS (caused printing to break on IRIX).
Jeremy Allison [Thu, 13 Aug 1998 16:20:37 +0000 (16:20 +0000)]
HAVE_STATVFS should be STAT_STAVFS (caused printing to break on IRIX).
Jeremy.
(This used to be commit 83c54b01ba6c891a0587a80aa083594ddda9a680)

22 years agoMore blocking lock code - still #ifdef'ed out - under development.
Jeremy Allison [Thu, 13 Aug 1998 02:10:45 +0000 (02:10 +0000)]
More blocking lock code - still #ifdef'ed out - under development.
Jeremy.
(This used to be commit c9695bdf2e22c3081841f116af37340308d447aa)

22 years agoDebug output formatting change. I'm trying to combine log lines that
Christopher R. Hertel [Thu, 13 Aug 1998 00:01:02 +0000 (00:01 +0000)]
Debug output formatting change.  I'm trying to combine log lines that
really should be together.  Chris -)-----
(This used to be commit 8880fc58fa61edfd5a83cc75ef627b430b8a4437)

22 years agoChanged a call to fflush(dbg) to dbgflush().
Christopher R. Hertel [Wed, 12 Aug 1998 15:27:13 +0000 (15:27 +0000)]
Changed a call to fflush(dbg) to dbgflush().
(This used to be commit c626828471cf3d63dd74a4dd52b234f0aebd3fe5)

22 years agoI've added a dbgflush() function to debug.c. Calling this will cause the
Christopher R. Hertel [Wed, 12 Aug 1998 14:51:17 +0000 (14:51 +0000)]
I've added a dbgflush() function to debug.c.  Calling this will cause the
debug format buffer to be written out (and reset).  fflush() is also called
to force the issue.  I replaced the call to fflush() in client.c with a
call to dbgflush(), which seems to have fixed the problem that Andrew was
working on (i.e., that the prompt was not displayed when using smbclient).

Chris -)-----
(This used to be commit a97460869fe1448be5132fdab586d30872d21a69)

22 years agofixed the nested comment - Jeremy, do you want that unbecome_user() or
Andrew Tridgell [Wed, 12 Aug 1998 10:09:41 +0000 (10:09 +0000)]
fixed the nested comment - Jeremy, do you want that unbecome_user() or
not?
(This used to be commit 638ee7d265982ca95ae7f49e2a84431bdf147c21)

22 years agoinclude/smb.h: Removed dir_ptr. Not needed.
Jeremy Allison [Tue, 11 Aug 1998 23:28:35 +0000 (23:28 +0000)]
include/smb.h: Removed dir_ptr. Not needed.
locking/locking.c: First cut a blocking lock code. #ifdef'ed out for now.
locking/locking_shm.c: Removed dir_ptr. Not needed.
smbd/nttrans.c: More work on ChangeNotify - return is not an error and needs
                to be handled as a nttrans with zero params. Removed dir_ptr. Not needed.
smbd/reply.c:
smbd/server.c:
smbd/trans2.c: Removed dir_ptr. Not needed.

Hmmm. At the moment smbclient is broken - doesn't issue prompt correctly.
This needs looking at.

Jeremy.
(This used to be commit ddfbcc05815621d3c463f92faed047f126412342)

22 years agoQuick fix for a small problem. If you run 'nmbd -?' you'd get the usage
Christopher R. Hertel [Tue, 11 Aug 1998 21:25:55 +0000 (21:25 +0000)]
Quick fix for a small problem.  If you run 'nmbd -?' you'd get the usage
message *but the daemon would start anyway*.  I've added a call to exit()
in the default: case of the option processing loop.

Chris -)-----
(This used to be commit c69727bd29c0bf1cded0db84602e791304691e2e)

22 years agoI've come up with a different scheme for doing the DEBUG() and DEBUGADD()
Christopher R. Hertel [Tue, 11 Aug 1998 18:56:03 +0000 (18:56 +0000)]
I've come up with a different scheme for doing the DEBUG() and DEBUGADD()
macros that meets the RVALUE requirement and doesn't use the (a?b:c) format
that Andrew called "ugly".  I've added the new macros but kept the old
macros within a #if 0..#else..#endif block in case I've missed somthing.

Basically, I've used

  (void)( (a) && (b) )

or

  (void)( (a) && (b) && (c) )

instead of

  ( (a) ? (void)(b) : (void)(c) )

or similar.  I have this compiled and running now.

Here's the diff:

$ cvs diff smb.h
Enter passphrase for RSA key 'crh@Ruby':
Index: smb.h
===================================================================
RCS file: /data/cvs/samba/source/include/smb.h,v
retrieving revision 1.172
diff -r1.172 smb.h
143a144,145
> #if 0
>
150a153,164
>
> #else
>
> #define DEBUG( level, body ) \
>   (void)( (DEBUGLEVEL >= (level)) \
>        && (dbghdr( level, FILE_MACRO, FUNCTION_MACRO, (__LINE__) )) \
>        && (dbgtext body) )
>
> #define DEBUGADD( level, body ) \
>   (void)( (DEBUGLEVEL >= (level)) && (dbgtext body) )
>
> #endif

Chris -)-----
(This used to be commit 53b433e6ab9fd69a02016ee4f2a3f756640ea565)

22 years agoCleaned up some lint warnings (functions with return values that were
Christopher R. Hertel [Tue, 11 Aug 1998 18:07:18 +0000 (18:07 +0000)]
Cleaned up some lint warnings (functions with return values that were
ignored).
(This used to be commit 8fedcfc48da2741722b867bbb056a078901e7431)

22 years agostrip out extra spaces from smbclient output that were added recently
Herb Lewis [Tue, 11 Aug 1998 17:34:00 +0000 (17:34 +0000)]
strip out extra spaces from smbclient output that were added recently
(This used to be commit 5f5562ff601b69c3f7629fa57ddd621e201c5806)

22 years agoRemoved a stray semicolon in the DEBUGADD() macro.
Christopher R. Hertel [Tue, 11 Aug 1998 15:54:15 +0000 (15:54 +0000)]
Removed a stray semicolon in the DEBUGADD() macro.
(This used to be commit efa67d6b2b6d4a1e007dba5f2f5da5aff723fe59)

22 years agoI've added a test for lp_loaded() so that timestamps *will* be output
Christopher R. Hertel [Tue, 11 Aug 1998 15:47:26 +0000 (15:47 +0000)]
I've added a test for lp_loaded() so that timestamps *will* be output
before the config file has been loaded.  Otherwise the default is no
timestamp.

Chris -)-----
(This used to be commit fd7eaed59efbe2ce6998d5902e70d79f533b3372)

22 years agofixed a nasty bug in debug.c
Andrew Tridgell [Tue, 11 Aug 1998 14:09:05 +0000 (14:09 +0000)]
fixed a nasty bug in debug.c

Debug1() was being called like this:

      Debug1( format_bufr );

but if format_bufr contains any %s or other % arguments (such as when
processing a smb.conf file containing % macros) then smbd dies a
horrible death.

The quick fix is to use:

Debug1( "%s", format_bufr);
(This used to be commit 5ae04012819ae3e63102d6875088ef00c27492b4)

22 years agomake sure that a fault cannot occur twice. The new Debug1() code is
Andrew Tridgell [Tue, 11 Aug 1998 13:55:16 +0000 (13:55 +0000)]
make sure that a fault cannot occur twice. The new Debug1() code is
causing seg faults on my machine and because the fault code calls
DEBUG() it is looping!

now to find the bug in the Debug1() code ...
(This used to be commit 83122bae2253221f085118c6e7e914982656bd64)

22 years agoMakefile.in: Added CHECK target back in (at Herb's request). Added
Jeremy Allison [Tue, 11 Aug 1998 02:13:01 +0000 (02:13 +0000)]
Makefile.in: Added CHECK target back in (at Herb's request). Added
             manpath in (although we don't currently use it).
client/client.c: Added John Blair's fixes for "put -".
include/nterr.h: Added NT_STATUS_NOTIFY_ENUM_DIR error code.
smbd/nttrans.c: Added in devious fix for one-shot NT change notify bug.
Jeremy.
(This used to be commit 4ac3091e57e9ab234b3c051333ba521a92defa99)

22 years agoupdate for new directory structure
Herb Lewis [Mon, 10 Aug 1998 22:36:11 +0000 (22:36 +0000)]
update for new directory structure
(This used to be commit 5fc8b4a1d5d973028396b667daaa119d21f0c0f0)

22 years agoMakefile.in: Fixed make clean bug with CVS directory in bin/.
Jeremy Allison [Mon, 10 Aug 1998 20:12:53 +0000 (20:12 +0000)]
Makefile.in: Fixed make clean bug with CVS directory in bin/.
include/smb.h: Fixed bugs in Debug macro's with SGI compiler.
smbd/trans2.c: Fixed bug reported by Zoltan Palmai <ZSPA@chevron.com>
               PR#8903 where get_lanman2_dir_entry() could return a
               mangled name as a resume key and call_trans2findnext()
               wasn't doing the same.
Jeremy.
(This used to be commit 9d010e721c27af1d9498fd1e147993ba8ac8b41e)

22 years agomoved access.c into lib/ from smbd/ as it is needed by testparm. I
Andrew Tridgell [Mon, 10 Aug 1998 07:29:57 +0000 (07:29 +0000)]
moved access.c into lib/ from smbd/ as it is needed by testparm. I
modified it not to need any smbd specific structures and instead pass
things from smbd.
(This used to be commit 162141d3b3fcf53fbc6a1f18702df85c2b7f1781)

22 years agosplit the system password checking routines out of smbd/password.c and
Andrew Tridgell [Mon, 10 Aug 1998 07:04:53 +0000 (07:04 +0000)]
split the system password checking routines out of smbd/password.c and
into passdb/pass_check.c. This means SWAT no longer needs to link to
smbd/password.c
(This used to be commit 90d93889d722670cbb517017531264630af759bf)

22 years agomoved username.c into lib/ so we no longer $(PASSDB_OBJ) in most
Andrew Tridgell [Mon, 10 Aug 1998 05:22:10 +0000 (05:22 +0000)]
moved username.c into lib/ so we no longer $(PASSDB_OBJ) in most
utilities
(This used to be commit 745d38bfe7a989a602d14b8a04757893ae40ba8e)

22 years agosmbtorture now compiles
Andrew Tridgell [Mon, 10 Aug 1998 02:01:18 +0000 (02:01 +0000)]
smbtorture now compiles
(This used to be commit 12c8028eb45d3e274e3496da1a2e4f6d18c117fd)

22 years agofixed the installation scripts for the new layout
Andrew Tridgell [Mon, 10 Aug 1998 01:55:42 +0000 (01:55 +0000)]
fixed the installation scripts for the new layout
(This used to be commit 60cdb83f3f6dfd7755e46254662245a82a8ef498)

22 years agothe rest of the binaries now compile and link
Andrew Tridgell [Mon, 10 Aug 1998 01:25:32 +0000 (01:25 +0000)]
the rest of the binaries now compile and link
(This used to be commit 7fecc3d5a2fb641237f24a3f39c6556fde648a8a)

22 years agoa few more things compile.
Andrew Tridgell [Sun, 9 Aug 1998 14:58:51 +0000 (14:58 +0000)]
a few more things compile.

I'll do the rest tomorrow.
(This used to be commit b92ce41c54fa187bce3287257996f7a3e9c9b9ff)

22 years agoswat compiles, with some even uglier hacks. we really have to do
Andrew Tridgell [Sun, 9 Aug 1998 14:37:32 +0000 (14:37 +0000)]
swat compiles, with some even uglier hacks. we really have to do
something about our dependencies between seemingly unrelated code.
(This used to be commit 3ecfd271de5e6f7b4868800e7c06d51ed69278fd)

22 years agonmbd compiles and links. I had to do some ugly stuff, putting files in
Andrew Tridgell [Sun, 9 Aug 1998 14:20:02 +0000 (14:20 +0000)]
nmbd compiles and links. I had to do some ugly stuff, putting files in
illogical places. Once I get everything compiled these will need to be
revisited, but at least the new Makefile.in makes it really obvious
what is out of place.
(This used to be commit beef5341fc313249bf1117deccb9c21c510c4697)

22 years agoclose to having nmbd linking (just a bit of repository hacking to go)
Andrew Tridgell [Sun, 9 Aug 1998 14:08:42 +0000 (14:08 +0000)]
close to having nmbd linking (just a bit of repository hacking to go)
(This used to be commit 34dd9b79457ab01637e0d7374d33cafe2f859c99)

22 years agothis gets smbd compiling and linking correctly with the new layout.
Andrew Tridgell [Sun, 9 Aug 1998 13:25:34 +0000 (13:25 +0000)]
this gets smbd compiling and linking correctly with the new layout.
(This used to be commit d08fa39cec5c71a9034dbf4241fc7e195f1bbaa5)

22 years agoremoved the if statements from the DEBUG() macro definitions.
Andrew Tridgell [Sun, 9 Aug 1998 13:12:09 +0000 (13:12 +0000)]
removed the if statements from the DEBUG() macro definitions.

Chris, you should never put if statements in macros, use the ugly
(a?b:c) form instead, otherwise you can produce incorrect code when
you have things like:

if (foo)
   DEBUG((blah));
else
   DEBUG((blooh));
(This used to be commit ab912448c1ff2487b6a313574d72f389baa65e6d)

22 years agoanother dummy file
Andrew Tridgell [Sun, 9 Aug 1998 12:09:48 +0000 (12:09 +0000)]
another dummy file
(This used to be commit 251213898077a11d71b208434c65748f922d7e9a)

22 years agoadded ignore rules for the dummy files
Andrew Tridgell [Sun, 9 Aug 1998 11:25:49 +0000 (11:25 +0000)]
added ignore rules for the dummy files
(This used to be commit 687f76a17d6d3ebd33b4d9a848deef56f3c1f56a)

22 years agothese dummy files are needed for autoconf processing
Andrew Tridgell [Sun, 9 Aug 1998 11:24:15 +0000 (11:24 +0000)]
these dummy files are needed for autoconf processing
(This used to be commit be762dc3de6c1ef768790522dfe93007a61ce5d7)

22 years agothe autoconf scripts are now converted to the new directory structure
Andrew Tridgell [Sun, 9 Aug 1998 11:23:13 +0000 (11:23 +0000)]
the autoconf scripts are now converted to the new directory structure

now the Makefile .....
(This used to be commit 4fae7f129e46930960831af0da28496f9766f6ae)

22 years agonew directory structure in configure.in
Andrew Tridgell [Sun, 9 Aug 1998 11:14:23 +0000 (11:14 +0000)]
new directory structure in configure.in
(This used to be commit 7067261760516c01c2dd4fa7f0a717e9c48e1554)

22 years agowe have to have the test for -lsocket before the test for some
Andrew Tridgell [Sat, 8 Aug 1998 05:25:04 +0000 (05:25 +0000)]
we have to have the test for -lsocket before the test for some
functions (notably innetgr) to ensure we don't replace them if they
are in -lsocket
(This used to be commit d1212048903fff8725e501001ac84b019c21b939)

22 years agoadded --with-nisplus-home option
Andrew Tridgell [Sat, 8 Aug 1998 01:15:14 +0000 (01:15 +0000)]
added --with-nisplus-home option
(This used to be commit 70000c21909a154344b489e8aa18a5868ff52865)

22 years agoforgot to remove -nostrip option for packaging. Makes inst package too big.
Herb Lewis [Fri, 7 Aug 1998 19:01:59 +0000 (19:01 +0000)]
forgot to remove -nostrip option for packaging. Makes inst package too big.
(This used to be commit 8bf365a54a5aedbd1b2aa373aa6b26a9708d7156)

22 years agoadd startswat.sh to automate starting swat with inetd
Herb Lewis [Fri, 7 Aug 1998 18:56:12 +0000 (18:56 +0000)]
add startswat.sh to automate starting swat with inetd
update make scripts to use new autoconfigure setup
(This used to be commit 737a58c1568fd76afe32a78895ee09b1543a595d)

22 years agoFixed memory leak when freeing ChangeNotify structures.
Jeremy Allison [Wed, 5 Aug 1998 22:17:51 +0000 (22:17 +0000)]
Fixed memory leak when freeing ChangeNotify structures.
Jeremy.
(This used to be commit 996c5ac97a8d1443bc8abc59b9a10ff3aeb77389)

22 years agonttrans.c: Fix change_notify. Queue processing code wasn't changing to
Jeremy Allison [Tue, 4 Aug 1998 23:45:34 +0000 (23:45 +0000)]
nttrans.c: Fix change_notify. Queue processing code wasn't changing to
           the correct directory before doing the stat. Doh !
uid.c: Fix for performance in security=share mode. Invalid vuid meant
       that in security=share mode Samba was always doing the become_user/
       undebome_user pairs for *every* smb. This code fixes it, but tridge
       should review for security implications.
Jeremy.
(This used to be commit c3663379fdcec487feea2e5d848ee012ee6c6baf)

22 years agoloadparm.c: Added "debug timestamp" synonym for Chris.
Jeremy Allison [Tue, 4 Aug 1998 01:01:26 +0000 (01:01 +0000)]
loadparm.c: Added "debug timestamp" synonym for Chris.
nttrans.c: Moved common code into function in server.c
           Removed left over debug level 0.
server.c: Moved common code into function in server.c
Jeremy.
(This used to be commit 34ef55b7228155cef40cbdfcdc1fe623c1037bd6)

22 years agoMore formatting changes. Mostly converted some DEBUG() calls to DEBUGADD()
Christopher R. Hertel [Mon, 3 Aug 1998 22:10:53 +0000 (22:10 +0000)]
More formatting changes.  Mostly converted some DEBUG() calls to DEBUGADD()
so that we wouldn't get too many timestamps.

Chris -)-----
(This used to be commit 3e7e5fad378cf144927d9f2ffc82f80e150d44ab)

22 years agoFirst implementation of ChangeNotify - this version only checks
Jeremy Allison [Mon, 3 Aug 1998 19:07:55 +0000 (19:07 +0000)]
First implementation of ChangeNotify - this version only checks
for changes in the directory modify timestamps. A better version
will look at the requested client flags, and create a hash that
represents the current state of the directory, and check against
this instead.
debug.c: Added lp_timestamp_logs() function.
loadparm.c: Added "change notify timeout" in seconds (default 60)
- this is the scan rate for a directory.
            Added ""timestamp logs" boolean - default True. Turns
off log timestamps (so I can read them :-).
nttrans.c: ChangeNotify implementation.
server.c: ChangeNotify implementation.
shmem_sysv.c: Added exits on shmem errors (without them smbd can
              core dump if some calls fail).
smb.h: Added ChangeNotify flags for future use.
util.c: Tidied up typedef.
Jeremy.
(This used to be commit a0748c3f53974483680ebe2ea4f556ece8d7fa43)

22 years agoOne more minor change to the format of a DEBUG message. I broke up a
Christopher R. Hertel [Mon, 3 Aug 1998 18:33:49 +0000 (18:33 +0000)]
One more minor change to the format of a DEBUG message.  I broke up a
very long output line in become_domain_master_query_success().
Chris -)-----
(This used to be commit 9b5d431661c55056c31bedf9ef3900f27e1c5292)

22 years agoI finished removing timestring() calls from DEBUG() messages. Also went
Christopher R. Hertel [Mon, 3 Aug 1998 18:13:13 +0000 (18:13 +0000)]
I finished removing timestring() calls from DEBUG() messages.  Also went
through and changed some DEBUG() calls to DEBUGADD() to combine output
under a single timestamp.  There were too many timestamps.

Note that Jeremy has told me that he's working on adding a config parameter
to turn timestamps off.  Cool.

Chris -)-----
(This used to be commit 247dbc9a24987035a47f1ba4fa143b1e2c050e92)

22 years agoFixing clitar.c so that tar to stdout works correctly.
Richard Sharpe [Mon, 3 Aug 1998 10:35:00 +0000 (10:35 +0000)]
Fixing clitar.c so that tar to stdout works correctly.

Replaced printfs with DEBUG(0. Tested ... Works.

Hope I didn't disturb the autoconf code ... It feels
great to be able to run configure for Samba at long last!

Regards
Richard Sharpe
(This used to be commit b968aa31ba15742a9eadc010e03781583feb6455)

22 years agoThis is the remaining set of changes needed to replace the changes lost
Christopher R. Hertel [Mon, 3 Aug 1998 03:50:07 +0000 (03:50 +0000)]
This is the remaining set of changes needed to replace the changes lost
when Andrew and I were both working with util.c.  I really don't know
how I lost the autoconfigure changes (honest, I *did* run frequent
updates).

Chris -)-----
(This used to be commit bedefc2066ac86199b29ccd7f65ad5f1d8a899c4)

22 years agoI have fixed some of the autoconfigure problems. I'm studying the diffs
Christopher R. Hertel [Mon, 3 Aug 1998 03:22:42 +0000 (03:22 +0000)]
I have fixed some of the autoconfigure problems.  I'm studying the diffs
for the rest.  I've found that only debug.h seems to be out of sync (i.e.,
util.c itself appears to be okay).

Chris -)-----
(This used to be commit b41cdbffb7233f73ac15526f7b5499658256cd82)

22 years agoAs per a Andrew's message, I went through and removed the timestring()
Christopher R. Hertel [Fri, 31 Jul 1998 22:39:15 +0000 (22:39 +0000)]
As per a Andrew's message, I went through and removed the timestring()
timestamps from several DEBUG messages.  The timestamps are redundant now
that DEBUG() provides them automatically.

There are still a few more files to do, but I've got to get home for dinner.

Chris -)-----
(This used to be commit 60286ccecaa6028d687e6406755016455e3b3a26)

22 years agoDebugging functions are now in their own module.
Christopher R. Hertel [Fri, 31 Jul 1998 20:17:36 +0000 (20:17 +0000)]
Debugging functions are now in their own module.

Chris -)-----
(This used to be commit 2c6dc2779647bbc0c27a102632882e617ef7643e)