Volker Lendecke [Sat, 12 Jun 2010 10:39:21 +0000 (12:39 +0200)]
s3: Fix a typo
Volker Lendecke [Sat, 12 Jun 2010 10:39:00 +0000 (12:39 +0200)]
s3: Remove smbd_server_conn from reply_sesssetup_and_X_spnego
Volker Lendecke [Sat, 12 Jun 2010 10:38:29 +0000 (12:38 +0200)]
s3: Remove smbd_server_conn from reply_spnego_auth
Volker Lendecke [Sat, 12 Jun 2010 10:38:09 +0000 (12:38 +0200)]
s3: Remove smbd_server_conn from reply_spnego_negotiate
Volker Lendecke [Sat, 12 Jun 2010 10:37:49 +0000 (12:37 +0200)]
s3: Remove smbd_server_conn from reply_spnego_ntlmssp
Volker Lendecke [Sat, 12 Jun 2010 10:37:31 +0000 (12:37 +0200)]
s3: Remove smbd_server_conn from reply_spnego_kerberos
Volker Lendecke [Sat, 12 Jun 2010 10:30:04 +0000 (12:30 +0200)]
s3: Explicitly pass sconn to the api_ functions
Volker Lendecke [Sat, 12 Jun 2010 10:21:20 +0000 (12:21 +0200)]
s3: Remove smbd_server_conn from send_trans_reply
Volker Lendecke [Sat, 12 Jun 2010 10:10:37 +0000 (12:10 +0200)]
s3: Remove smbd_server_conn from reply_findclose
Volker Lendecke [Sat, 12 Jun 2010 10:10:07 +0000 (12:10 +0200)]
s3: Remove smbd_server_conn from call_trans2setfsinfo
Volker Lendecke [Sat, 12 Jun 2010 10:08:12 +0000 (12:08 +0200)]
s3: Remove smbd_server_conn from smbd_do_qfsinfo
Volker Lendecke [Sat, 12 Jun 2010 10:06:14 +0000 (12:06 +0200)]
s3: Remove smbd_server_conn from call_trans2findnext
Volker Lendecke [Sat, 12 Jun 2010 10:05:37 +0000 (12:05 +0200)]
s3: Remove smbd_server_conn from call_trans2findfirst
Volker Lendecke [Sat, 12 Jun 2010 10:05:12 +0000 (12:05 +0200)]
s3: Remove smbd_server_conn from send_trans2_replies
Volker Lendecke [Sat, 12 Jun 2010 10:02:47 +0000 (12:02 +0200)]
s3: Remove smbd_server_conn from register_existing_vuid
Volker Lendecke [Sat, 12 Jun 2010 09:55:42 +0000 (11:55 +0200)]
s3: Explicitly pass sconn to is_valid_writeX_buffer
Volker Lendecke [Sat, 12 Jun 2010 09:53:25 +0000 (11:53 +0200)]
s3: Explicitly pass sconn to reply_readbraw_error
Volker Lendecke [Sat, 12 Jun 2010 09:50:56 +0000 (11:50 +0200)]
s3: Pass sconn explicitly to reply_special
Volker Lendecke [Sat, 12 Jun 2010 09:49:02 +0000 (11:49 +0200)]
s3: Remove smbd_server_conn from smbd_do_locking
Volker Lendecke [Sat, 12 Jun 2010 09:48:06 +0000 (11:48 +0200)]
s3: Remove smbd_server_conn from reply_rmdir
Volker Lendecke [Sat, 12 Jun 2010 09:47:33 +0000 (11:47 +0200)]
s3: Remove smbd_server_conn from reply_writebraw
Volker Lendecke [Sat, 12 Jun 2010 09:46:29 +0000 (11:46 +0200)]
s3: Remove smbd_server_conn from reply_read_and_X
Volker Lendecke [Sat, 12 Jun 2010 09:45:24 +0000 (11:45 +0200)]
s3: Remove smbd_server_conn from send_file_readX
Volker Lendecke [Sat, 12 Jun 2010 09:44:41 +0000 (11:44 +0200)]
s3: Remove smbd_server_conn from reply_read
Volker Lendecke [Sat, 12 Jun 2010 09:44:14 +0000 (11:44 +0200)]
s3: Remove smbd_server_conn from reply_lockread
Volker Lendecke [Sat, 12 Jun 2010 09:43:53 +0000 (11:43 +0200)]
s3: Remove smbd_server_conn from reply_readbraw
Volker Lendecke [Sat, 12 Jun 2010 09:42:40 +0000 (11:42 +0200)]
s3: Remove smbd_server_conn from reply_send_file_readbraw
Volker Lendecke [Sat, 12 Jun 2010 09:42:06 +0000 (11:42 +0200)]
s3: Remove smbd_server_conn from reply_ulogoffX
Volker Lendecke [Sat, 12 Jun 2010 09:41:40 +0000 (11:41 +0200)]
s3: Remove smbd_server_conn from reply_fclose
Volker Lendecke [Sat, 12 Jun 2010 09:41:22 +0000 (11:41 +0200)]
s3: Remove smbd_server_conn from reply_search
Volker Lendecke [Sat, 12 Jun 2010 09:41:00 +0000 (11:41 +0200)]
s3: Remove smbd_server_conn from reply_tcon_and_X
Volker Lendecke [Sat, 12 Jun 2010 09:40:37 +0000 (11:40 +0200)]
s3: Remove smbd_server_conn from reply_tcon
Volker Lendecke [Sat, 12 Jun 2010 09:39:03 +0000 (11:39 +0200)]
s3: Remove smbd_server_conn from make_connection_snum
Volker Lendecke [Sat, 12 Jun 2010 09:34:38 +0000 (11:34 +0200)]
s3: Remove smbd_server_conn from change_to_user
Volker Lendecke [Sat, 12 Jun 2010 09:29:26 +0000 (11:29 +0200)]
s3: Remove smbd_server_conn from reply_ntcancel
Volker Lendecke [Sat, 12 Jun 2010 09:29:12 +0000 (11:29 +0200)]
s3: Remove smbd_server_conn from send_nt_replies
Volker Lendecke [Sat, 12 Jun 2010 09:26:51 +0000 (11:26 +0200)]
s3: Remove smbd_server_conn from reply_smb2002
Volker Lendecke [Sat, 12 Jun 2010 09:25:41 +0000 (11:25 +0200)]
s3: Explicitly pass sconn to negprot_spnego()
Volker Lendecke [Sat, 12 Jun 2010 09:19:21 +0000 (11:19 +0200)]
s3: Remove some global references to smbd_server_conn
Volker Lendecke [Sat, 12 Jun 2010 11:08:31 +0000 (13:08 +0200)]
s3: Remove sconn arg from smbd_notify_cancel_by_smbreq
Volker Lendecke [Sat, 12 Jun 2010 10:54:02 +0000 (12:54 +0200)]
s3: Initialize smb_request->sconn in smbd_smb2_fake_smb_request
Volker Lendecke [Sat, 12 Jun 2010 09:06:24 +0000 (11:06 +0200)]
s3: Use "sconn" argument in smbd_[un]lock_socket_internal
Metze, please check!
Volker Lendecke [Sat, 12 Jun 2010 09:01:27 +0000 (11:01 +0200)]
s3: Pass sconn to init_smb_request()
Volker Lendecke [Sat, 12 Jun 2010 09:01:10 +0000 (11:01 +0200)]
s3: Add "smbd_server_connection" to smb_request
Volker Lendecke [Sat, 12 Jun 2010 08:28:42 +0000 (10:28 +0200)]
s3: Fix some nonempty lines
Andrew Bartlett [Sat, 12 Jun 2010 01:03:36 +0000 (11:03 +1000)]
s4:dsdb Allow calling dsdb_convert_object_ex() directly
This will allow the libnet_vampire code to manually convert individual
schema objects.
Andrew Bartlett
Andrew Bartlett [Thu, 10 Jun 2010 11:34:48 +0000 (21:34 +1000)]
s4:dsdb Add debug
Andrew Bartlett [Thu, 10 Jun 2010 11:29:57 +0000 (21:29 +1000)]
s4:dsdb Simplfy match of objectclass in dsdb_schema_set_el_from_ldb_msg
There is no need to do a full ldb_match_msg() for a simple case
insensitive string.
Andrew Bartlett
Andrew Bartlett [Wed, 9 Jun 2010 22:58:44 +0000 (08:58 +1000)]
s4:provision Allow both additional and override prefixmaps in Schema
The idea here is to allow some callers to specify a new prefixMap that
will override the values loaded from the prefixMap.txt.
Andrew Bartlett
Andrew Bartlett [Wed, 9 Jun 2010 22:51:30 +0000 (08:51 +1000)]
s4:dsdb Allow a binary prefix map to be specified in the LDIF
This allows it to be specified in either binary or as a string.
Andrew Bartlett
Andrew Bartlett [Wed, 9 Jun 2010 22:27:59 +0000 (08:27 +1000)]
s4:dsdb Provide a function to convert from DRS prefix maps to the LDB prefixmap
This allows us to push a prefixmap directly into the schema we
generate in the provision code.
Andrew Bartlett
Andrew Bartlett [Wed, 9 Jun 2010 22:25:49 +0000 (08:25 +1000)]
s4:dsdb Add more debugs to help track down failures to parse the prefixmap
Andrew Bartlett [Wed, 9 Jun 2010 10:21:19 +0000 (20:21 +1000)]
s4:dsdb Put back the reference and set_attributes in dsdb_reference_schema
I'm not sure why I removed these in
fe3e1af901c970f738bee92baac5d7d4f5736e17
Andrew Bartlett
Olaf Flebbe [Tue, 25 May 2010 11:22:56 +0000 (13:22 +0200)]
check if LD_AS_NEEDED breaks linking with libreadline fixes #7209
Signed-off-by: Simo Sorce <idra@samba.org>
Kamen Mazdrashki [Fri, 11 Jun 2010 13:02:10 +0000 (16:02 +0300)]
s4/test-libnet: Re-align code a bit - more readable this way IMO
Kamen Mazdrashki [Fri, 11 Jun 2010 12:44:34 +0000 (15:44 +0300)]
s4/test-libnet: Refactor test_group_create() a little to:
- Close unused policy handle for created group
- re-align code - it is more readable this way IMHO
Kamen Mazdrashki [Fri, 11 Jun 2010 12:37:12 +0000 (15:37 +0300)]
s4/test-libnet: Refactor test_user_create() little bit to:
- fix a flaw that user RID is not returned in case
user is recreated
- close unused policy handle to created user
- do not take into account the result from
test_samr_close_handle - we don't case
Kamen Mazdrashki [Fri, 11 Jun 2010 12:30:09 +0000 (15:30 +0300)]
s4/test-libnet: add few comments for utility functions
Kamen Mazdrashki [Fri, 11 Jun 2010 12:11:01 +0000 (15:11 +0300)]
s4/test-libnet: Move LSA close handle function to a common location
Kamen Mazdrashki [Fri, 11 Jun 2010 12:01:07 +0000 (15:01 +0300)]
s4/test-libnet: remove unused code
Pre-connecting SAMR and LSA pipes is implemented in
test_libnet_context_init() function
Kamen Mazdrashki [Fri, 11 Jun 2010 11:59:57 +0000 (14:59 +0300)]
s4/test-libnet: Fix compile-time warning
Nadezhda Ivanova [Fri, 11 Jun 2010 14:22:21 +0000 (17:22 +0300)]
Adjusted ACL tests to use encripted connection.
This way we get rid of the conditional if.Samba checks, because users are
successfully created and enabled.
Günther Deschner [Fri, 11 Jun 2010 13:05:36 +0000 (15:05 +0200)]
s3-auth: Fix valgrind warning (unitialized var) in samu_to_SamInfo3().
Guenther
s3:auth do not fail if there are 0 group sids
Signed-off-by: Günther Deschner <gd@samba.org>
Olaf Flebbe [Fri, 11 Jun 2010 11:52:23 +0000 (13:52 +0200)]
configure.in prevent generation of file "shlib.so"
Simo Sorce [Fri, 11 Jun 2010 12:25:27 +0000 (08:25 -0400)]
s3:auth fix samu->info3 conversion
Some pdb_get_ functions where missing because of previous mis-patching
Volker Lendecke [Tue, 8 Jun 2010 12:33:05 +0000 (14:33 +0200)]
s3: Fix starving the echo responder
When both the echo responder and the 445 socket want to send stuff to the
worker smbd, the select loop is not fair. It always chooses the smaller file
descriptor to work on. This can mean that on a busy system the echo responder
never gets around to feed its stuff to the parent.
This fix chooses the async echo responder socket when both the 445 and the echo
responder socket are readable.
Yes, it is a very hackish fix which is required *now* I think. The proper fix
would be to either assign priorities to fd's in tevent, or the from my point of
view better fix would be to make tevent kindof round-robin.
Round-robin would mean that whenever a fd has been dealt with, it is taken off
the list of interested sockets, and only if no other socket is active, all of
the ones waiting are put back. This is a bit like EPOLL_ONESHOT, which I would
like to use for this in the epoll case. Although, I need to do some research if
maybe epoll already guarantees round-robin, I did not find anything in the docs
yet.
Volker
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 08:19:19 +0000 (10:19 +0200)]
s4:rootdse LDB module - use LDB result constants
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 08:04:50 +0000 (10:04 +0200)]
s4:passwords.py - set the "dSHeuristics"
As per Nadia's request and abartlet's suggestion the test now also sets the
"dSHeuristics" attribute properly to be able to perform the tests also against
Windows without further configuration.
The code has the neat feature that it undoes the change and resets the
behaviour as it was before.
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 08:04:19 +0000 (10:04 +0200)]
s4:passwords.py - use "self" before "enable_account" to make really sure which LDB connection should be used
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 07:19:02 +0000 (09:19 +0200)]
s4:ldap.py - check how the directory server behaves when the 'distinguishedName' attribute wasn't set correctly
(On add operations the server does completely ignore it and uses the "header"
DN)
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 07:17:08 +0000 (09:17 +0200)]
s4:ldap.py - check if the "name" of an entry was really ignored
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 06:52:12 +0000 (08:52 +0200)]
ldb:ldb_sqlite3 backend - remove a warning which has already been resolved
Matthias Dieter Wallnöfer [Fri, 11 Jun 2010 06:50:36 +0000 (08:50 +0200)]
ldb:ldb_sqlite3 backend - remove checks which are now done elsewhere
(In SAMBA LDB modules)
Jelmer Vernooij [Thu, 10 Jun 2010 23:47:45 +0000 (01:47 +0200)]
Add missing stub functions.
Jelmer Vernooij [Thu, 10 Jun 2010 21:12:53 +0000 (23:12 +0200)]
s4-python: Fix formatting.
Simo Sorce [Mon, 7 Jun 2010 21:38:01 +0000 (17:38 -0400)]
s3:rpc improve handles memory hierarchy and use better name.
While there also cleanup the code a bit.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Tue, 8 Jun 2010 10:26:15 +0000 (12:26 +0200)]
s4-smbtorture: rework internals of RPC-SPOOLSS-ACCESS testsuite.
Guenther
Kamen Mazdrashki [Thu, 10 Jun 2010 15:23:06 +0000 (18:23 +0300)]
s4/test: use test_libnet_context_init() function to create libnet_context
This way we ensure that LIBNET call will be issued against
the DC we are testing against
Kamen Mazdrashki [Thu, 10 Jun 2010 15:21:44 +0000 (18:21 +0300)]
s4/test: fix SEGFAULT in test_group_create when rid is NULL
Caller of this function may not need group RID and
in such case it passes NULL for rid parameter
Kamen Mazdrashki [Thu, 10 Jun 2010 10:12:08 +0000 (13:12 +0300)]
s4/test-libnet: Helper func to initialize libnet_context
and create rpc connections to SAMR and LSA pipes.
This function should be used in cases where we need
'deterministic' connection to the DC we are testing against.
The problem is that most of the test follow the pattern:
1. Connect to server supplied on command line
2. Create user/group through connection in 1.
3. Use 'fresh' libnet_context to query/alter the object in
step 2.
In singe-DC environment this work well. But in multiple-DC
environment libnet may connect to another DC (step 3), not
the one we use in step 1 and 2. This leads to false error -
object created in step 2 is not found on DC we are querying
in step 3.
Kamen Mazdrashki [Wed, 9 Jun 2010 23:02:06 +0000 (02:02 +0300)]
s4/test: Call test_user_cleanup with original RDN for the user
'name' var is changed during the test execution and should
contain samAccountName for the user, while test_user_cleanup()
expects account RDN to be passed
Kamen Mazdrashki [Wed, 9 Jun 2010 22:59:51 +0000 (01:59 +0300)]
s4/test: Fix incorrect NTSTATUS comparison
In case group already exists, we should get NT_STATUS_GROUP_EXISTS.
Kamen Mazdrashki [Tue, 8 Jun 2010 15:03:00 +0000 (18:03 +0300)]
s4/test: remove create/delete group implementation in API-CREATEGROUP test
We already have common implementation for create/delete
group in libnet/utils.c
Kamen Mazdrashki [Tue, 8 Jun 2010 12:44:00 +0000 (15:44 +0300)]
s4/test: Remove duplicated test_opendomain() functionality
We already have a nice common test_domain_open()
function in libnet/util.c
Kamen Mazdrashki [Mon, 7 Jun 2010 15:44:14 +0000 (18:44 +0300)]
s4/test: libnet_user tests should use common test_user_cleanup
implementation instead of not-so-informative test_cleanup()
Kamen Mazdrashki [Mon, 7 Jun 2010 15:33:35 +0000 (18:33 +0300)]
s4/test: Refactor test_user_cleanup to be more robust
We always call this function with user's account RDN
while samr_LookupNames() searches for samAccountName.
Kamen Mazdrashki [Mon, 7 Jun 2010 14:51:26 +0000 (17:51 +0300)]
s4/test: remove duplicated comment
Andreas Schneider [Thu, 10 Jun 2010 15:48:39 +0000 (11:48 -0400)]
s3:misc make use of server_[event/messaging]_context directly
Untangle these functions from smbd specific dependencies so they can be freely
used in multiple servers.
Simo Sorce [Thu, 10 Jun 2010 15:55:27 +0000 (11:55 -0400)]
s3:winbindd use common server context functions
Simo Sorce [Thu, 10 Jun 2010 15:54:00 +0000 (11:54 -0400)]
s3:lib make server contexts generic
Pair-programmed-with: Andreas Schneider <asn@samba.org>
Jeremy Allison [Thu, 10 Jun 2010 21:28:55 +0000 (14:28 -0700)]
Fix the build in the non WITH_AIO case (sorry).
Björn Jacke [Thu, 10 Jun 2010 21:15:19 +0000 (23:15 +0200)]
s3: readd h_errno struct member but rename it
as pointed out by metze this is a structure of fixed size, which should not be
changed.
Rusty Russell [Thu, 10 Jun 2010 20:27:51 +0000 (13:27 -0700)]
Since idtree assigns sequentially, it rarely reaches high numbers.
But such numbers can be forced with idr_get_new_above(), and that
reveals two bugs:
1) Crash in sub_remove() caused by pa array being too short.
2) Shift by more than 32 in _idr_find(), which is undefined, causing
the "outside the current tree" optimization to misfire and return NULL.
Jeremy Allison [Thu, 10 Jun 2010 20:20:37 +0000 (13:20 -0700)]
Implement AIO in SMB2. Doesn't allow cancel calls yet (to be added).
Jeremy.
Jeremy Allison [Thu, 10 Jun 2010 20:19:25 +0000 (13:19 -0700)]
Ensure we correctly setup req->subreq before testing for async. Stops crashes when
XX_send functions set async to stop interim replies being sent.
Jeremy.
Jeremy Allison [Thu, 10 Jun 2010 20:17:35 +0000 (13:17 -0700)]
Don't use the autofree context for the globals. This causes child smbd's forked
by modules to crash due to destructors being called (found when using the vfs_aio_fork
module with smb2).
Jeremy.
Simo Sorce [Thu, 10 Jun 2010 18:56:03 +0000 (14:56 -0400)]
s3:cleaunp reformatting for readability
Simo Sorce [Thu, 10 Jun 2010 18:36:19 +0000 (14:36 -0400)]
s3:cleanup remove trailing spaces
Björn Jacke [Thu, 10 Jun 2010 15:19:16 +0000 (17:19 +0200)]
s3: fix build on HP-UX
this struct member h_errno is not used in the HP-UX code paths, it was just
there because Solaris has it, too. As h_errno is a function call macro on HP-UX
when thread support is enabled we run into trouble here. Just commenting it out
should be okay as we don't use it anyway.
Matthias Dieter Wallnöfer [Thu, 10 Jun 2010 14:18:41 +0000 (16:18 +0200)]
s4:ldap.py - add testcase which demonstrates the reset of the "primaryGroupID"