Andrew Bartlett [Thu, 16 Jan 2003 02:02:23 +0000 (02:02 +0000)]
Fix a signed/unsigned warning.
John Terpstra [Thu, 16 Jan 2003 00:33:17 +0000 (00:33 +0000)]
More notes added.
Jeremy Allison [Thu, 16 Jan 2003 00:27:30 +0000 (00:27 +0000)]
Add mutex protection around auth calls.
Jeremy.
Jeremy Allison [Thu, 16 Jan 2003 00:27:27 +0000 (00:27 +0000)]
Add mutex protection around auth calls.
Jeremy.
Tim Potter [Wed, 15 Jan 2003 23:32:47 +0000 (23:32 +0000)]
Merge of holding pattern stuff from HEAD.
Gerald Carter [Wed, 15 Jan 2003 23:11:57 +0000 (23:11 +0000)]
s/WIFSIGNALLED/WIFSIGNALED/g
Gerald Carter [Wed, 15 Jan 2003 23:11:45 +0000 (23:11 +0000)]
s/WIFSIGNALLED/WIFSIGNALED/g
Gerald Carter [Wed, 15 Jan 2003 22:52:54 +0000 (22:52 +0000)]
missed a file
Gerald Carter [Wed, 15 Jan 2003 22:37:28 +0000 (22:37 +0000)]
do not use RCS variables in file
Gerald Carter [Wed, 15 Jan 2003 22:37:16 +0000 (22:37 +0000)]
do not use RCS variables in file
Gerald Carter [Wed, 15 Jan 2003 22:29:27 +0000 (22:29 +0000)]
syncing docs with HEAD
Tim Potter [Wed, 15 Jan 2003 22:20:16 +0000 (22:20 +0000)]
Remove debugging stmt.
Gerald Carter [Wed, 15 Jan 2003 22:19:03 +0000 (22:19 +0000)]
add ntlogon directory and files from 3.0
Tim Potter [Wed, 15 Jan 2003 22:18:33 +0000 (22:18 +0000)]
Sync up compiler warning fixes.
Tim Potter [Wed, 15 Jan 2003 22:15:07 +0000 (22:15 +0000)]
Removed level 0 DEBUG leftover from testing.
John Terpstra [Wed, 15 Jan 2003 21:46:25 +0000 (21:46 +0000)]
and another comment.
John Terpstra [Wed, 15 Jan 2003 21:42:18 +0000 (21:42 +0000)]
dded further comment.
Richard Sharpe [Wed, 15 Jan 2003 21:35:36 +0000 (21:35 +0000)]
Remove a wayward file.
John Terpstra [Wed, 15 Jan 2003 21:26:07 +0000 (21:26 +0000)]
Adding Win2K profile info.
John Terpstra [Wed, 15 Jan 2003 20:46:13 +0000 (20:46 +0000)]
Adding more notes.
Andrew Bartlett [Wed, 15 Jan 2003 20:39:33 +0000 (20:39 +0000)]
Missed auth_ntlmssp.c in last night's checkin. Also keep track of the current
challenge in the NTLMSSP context.
Andrew Bartlett
John Terpstra [Wed, 15 Jan 2003 20:08:25 +0000 (20:08 +0000)]
Added note about Win2Pro RK.
Gerald Carter [Wed, 15 Jan 2003 19:08:23 +0000 (19:08 +0000)]
playing janitor for tpot; remove holding pattern
Gerald Carter [Wed, 15 Jan 2003 19:00:44 +0000 (19:00 +0000)]
remove torture tools on make clean
Gerald Carter [Wed, 15 Jan 2003 18:57:41 +0000 (18:57 +0000)]
*lots of small merges form HEAD
*sync up configure.in
*don't build torture tools in make all
*make sure to remove torture tools as part of make clean
Gerald Carter [Wed, 15 Jan 2003 18:31:46 +0000 (18:31 +0000)]
small merges from SAMBA_3_0; mostly typos, renames, etc...
Gerald Carter [Wed, 15 Jan 2003 17:40:09 +0000 (17:40 +0000)]
sync up ignored files from HEAD
Gerald Carter [Wed, 15 Jan 2003 17:39:47 +0000 (17:39 +0000)]
winbindd merges from HEAD
Gerald Carter [Wed, 15 Jan 2003 17:22:48 +0000 (17:22 +0000)]
merging some rpcclient and net functionality from HEAD
Herb Lewis [Wed, 15 Jan 2003 16:44:35 +0000 (16:44 +0000)]
initialize acct_ctrl before using it
remove ldap_msgfree(result); as result is unitialized at this point
Herb Lewis [Wed, 15 Jan 2003 16:41:29 +0000 (16:41 +0000)]
initialize acct_ctrl variable before it is used
remove ldap_msgfree(result); as result is unitialized at this point
Gerald Carter [Wed, 15 Jan 2003 16:32:06 +0000 (16:32 +0000)]
more unused files
Gerald Carter [Wed, 15 Jan 2003 16:29:38 +0000 (16:29 +0000)]
remving more unused files
Gerald Carter [Wed, 15 Jan 2003 16:10:57 +0000 (16:10 +0000)]
[merge]
* removed unused variable from rpcclient code
* added container option to net command (patch from SuSE)
* Makefile patch for examples/VFS from SuSE
John Terpstra [Wed, 15 Jan 2003 16:07:24 +0000 (16:07 +0000)]
First set of Profile Manipulation Notes.
Gerald Carter [Wed, 15 Jan 2003 16:07:14 +0000 (16:07 +0000)]
* removed unused variable from rpcclient code
* added container option to net command (patch from SuSE)
* Makefile patch for examples/VFS from SuSE
Gerald Carter [Wed, 15 Jan 2003 14:52:23 +0000 (14:52 +0000)]
removing unused files from release branch
cvs2svn Import User [Wed, 15 Jan 2003 12:52:39 +0000 (12:52 +0000)]
This commit was manufactured by cvs2svn to create branch 'SAMBA_3_0'.
Andrew Bartlett [Wed, 15 Jan 2003 12:52:38 +0000 (12:52 +0000)]
Refactor the NTLMSSP code again - this time we use function pointers to
eliminate the dependency on the auth subsystem. The next step is to add
the required code to 'ntlm_auth', for export to Squid etc.
Andrew Bartlett
Andrew Bartlett [Wed, 15 Jan 2003 12:48:06 +0000 (12:48 +0000)]
Doing a malloc(strlen(s)) then a pstrpcp(y, s) is just silly, make it a strdup
instead.
Andrew Bartlett
Andrew Tridgell [Wed, 15 Jan 2003 07:40:40 +0000 (07:40 +0000)]
added cli_lsa_enum_account_rights() call. Note that this is in
principal similar to the existing cli_lsa_enum_privsaccount() call,
except that cli_lsa_enum_account_rights() doesn't require a call to
open_account first. There is also the minor matter that
cli_lsa_enum_account_rights() works whereas
cli_lsa_enum_privsaccount() doesn't!
this call can be used to find what privileges an account or group
has. This is a first step towards proper privileges support in Samba.
Andrew Bartlett [Wed, 15 Jan 2003 05:56:12 +0000 (05:56 +0000)]
Fix warnings by getting the function into a shape the autoprototyper will
read, and add a static.
Andrew Bartlett
Andrew Bartlett [Wed, 15 Jan 2003 05:55:22 +0000 (05:55 +0000)]
Crash fixes:
- fix a crash when a second NTLMSSP session tried to free the first
- fix a crash due to some NULL pointers in the Add Printer Wizard (or read
printer code too it appears). As far as I can tell it's just that the
GUID just might not exist.
Andrew Bartlett
Martin Pool [Wed, 15 Jan 2003 05:27:33 +0000 (05:27 +0000)]
One more from waitpid() audit: Correctly interpret waitstatus when a
child fails. Possibly this was causing smbmount to exit(0) when it
really should have indicated a failure.
Martin Pool [Wed, 15 Jan 2003 05:23:40 +0000 (05:23 +0000)]
Run autoheader
Martin Pool [Wed, 15 Jan 2003 05:00:04 +0000 (05:00 +0000)]
Fix bug where the existence of config.cache would cause functions like
yp_get_default_domain to be misdetected.
According to the autoconf manual we need to check for libraries before
looking for functions in them.
Herb Lewis [Wed, 15 Jan 2003 01:07:09 +0000 (01:07 +0000)]
IRIX uses libns_winbind.so instead of libnss_winbind.so
Herb Lewis [Wed, 15 Jan 2003 01:05:35 +0000 (01:05 +0000)]
IRIX uses libns_winbind.so instead of libnss_winbind.so
Gerald Carter [Tue, 14 Jan 2003 23:55:14 +0000 (23:55 +0000)]
[merge] removing unused variable and unused file
Gerald Carter [Tue, 14 Jan 2003 23:52:42 +0000 (23:52 +0000)]
removing unused variable and unused file
Andrew Bartlett [Tue, 14 Jan 2003 23:45:14 +0000 (23:45 +0000)]
Fix some debug lines, and add a bit more info to help track down ldap
connectivity problems.
Andrew Bartlett
Gerald Carter [Tue, 14 Jan 2003 16:03:27 +0000 (16:03 +0000)]
merge: disable [u|g]idPool objects
Gerald Carter [Tue, 14 Jan 2003 15:52:45 +0000 (15:52 +0000)]
make -i flag work lik eit did in 2.2
Gerald Carter [Tue, 14 Jan 2003 15:52:14 +0000 (15:52 +0000)]
make -i flag work lik eit did in 2.2
Andrew Bartlett [Tue, 14 Jan 2003 10:47:56 +0000 (10:47 +0000)]
Merge from HEAD - patch by metze to fill in 'workgroup' etc in testparm output,
and probably SWAT too..
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 10:39:32 +0000 (10:39 +0000)]
Merge from HEAD:
Keep all the const warnings in one place, by adding a utility function to
make the TDB_DATA.
Andrew Bartlett [Tue, 14 Jan 2003 08:53:59 +0000 (08:53 +0000)]
Merge from HEAD:
- fstring/pstring mixups
- the detection code that found them (disabled)
- a bit of whitespace
- a static
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 08:26:54 +0000 (08:26 +0000)]
Merge from HEAD:
- remove useless #else
- signed/unsigned fixes
- use an fstring for LM hash buffer.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 07:49:15 +0000 (07:49 +0000)]
Merge from HEAD - eliminated unused arguments.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 07:26:12 +0000 (07:26 +0000)]
Merge indirection, signed/unsigned and uninitialiased-value fixes from HEAD.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 06:53:35 +0000 (06:53 +0000)]
Commit my (disabled) fstring/pstring mixup detection code.
We need to fix some 'overmalloc' cases before it can be enabled by default.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jan 2003 06:46:14 +0000 (06:46 +0000)]
The last of the fstring/pstring mixups, and an extra 'static'.
Andrew Bartlett [Tue, 14 Jan 2003 06:36:40 +0000 (06:36 +0000)]
A couple more pstcpy/fstrcpy mixups - doing an fstrcpy into a pstring is
harmless, but breaks my automated check.
Tim Potter [Tue, 14 Jan 2003 05:25:08 +0000 (05:25 +0000)]
Added comment about a SMB_ASSERT()
Tim Potter [Tue, 14 Jan 2003 05:08:42 +0000 (05:08 +0000)]
Remove wrapper function _get_trust_account_password() as it doesn't
seem to do anything useful anymore other than call
secrets_fetch_trust_account_password().
Tim Potter [Tue, 14 Jan 2003 04:04:13 +0000 (04:04 +0000)]
Added a comment in case anyone is thinking of doing a SMB_ASSERT in winbindd.
Andrew Tridgell [Tue, 14 Jan 2003 03:02:18 +0000 (03:02 +0000)]
merge alt_name patch from head
Andrew Tridgell [Tue, 14 Jan 2003 02:51:37 +0000 (02:51 +0000)]
query_alt_name takes a forced unicode string in win2000. It is not
null terminated.
Thanks to Metze for finding this.
Andrew Tridgell [Tue, 14 Jan 2003 00:39:18 +0000 (00:39 +0000)]
clearer debug message when the user is already in the ldap db
Andrew Tridgell [Tue, 14 Jan 2003 00:35:38 +0000 (00:35 +0000)]
add help text for 'net ads lookup'
Jeremy Allison [Mon, 13 Jan 2003 23:15:14 +0000 (23:15 +0000)]
Don't touch data after a free.
Jeremy.
Jeremy Allison [Mon, 13 Jan 2003 23:07:28 +0000 (23:07 +0000)]
Missing indirect in final free.
Jeremy.
Jeremy Allison [Mon, 13 Jan 2003 23:07:26 +0000 (23:07 +0000)]
Merge of indirection fixes from HEAD.
Jeremy
Andrew Bartlett [Mon, 13 Jan 2003 21:49:49 +0000 (21:49 +0000)]
Always initialise this variable - and don't set the 'must change now' if it was
last changed at '0'.
We need to actually change this password sometime...
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 21:48:52 +0000 (21:48 +0000)]
Fix typo, and the build.
Richard Sharpe [Mon, 13 Jan 2003 20:37:46 +0000 (20:37 +0000)]
More janitorial duties. Pulling these in from samba-head.
Richard Sharpe [Mon, 13 Jan 2003 20:30:28 +0000 (20:30 +0000)]
Make sure that those cleanups actually went in.
Richard Sharpe [Mon, 13 Jan 2003 20:04:40 +0000 (20:04 +0000)]
Now that I am running config.developer, I decided to get rif of some warnings:
1. reboot in parse_reg and cli_reg was shadowing a definition on FreeBSD
4.3 from system includes.
2. Added a bit of const to places.
3. Made sure internal functions were declared where needed.
Andrew Bartlett [Mon, 13 Jan 2003 13:11:36 +0000 (13:11 +0000)]
Patch from metze to add what he feels is the correct semantics for a Domain
Controller. As we have had a number of attempts at this over the last little
while, I need to get my test rig going, and give this whole area a poke...
Meanwhile, if you want to use this, just adjust your 'auth methods' line to use
samstrict_dc...
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 13:03:25 +0000 (13:03 +0000)]
Patch from metze to to make testparm show values for 'workgroup', 'netbios
name' and 'netbios scope'. Probably has a similar effect on SWAT.
Also adds '-V' to testparm.
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 12:54:59 +0000 (12:54 +0000)]
Patch from ab, to make findsmb omit -r most of the time.
(original mail follows)
--
From: Alexander Bokovoy <a.bokovoy@sam-solutions.net>
Greetings!
I propose to make an optional argument '-r' for findsmb utility to pass
'-r' option to nmblookup optionally and default to omit it. The reason is
to have findsmb working more user-friendly in contemporary office
environments where Windows 95/98 boxes are rare and also to allow usage of
the utility under non-priviledged accounts when Windows95/98 boxes are in
minority or even absent in network neighbourhood.
An attached patch provides this change for HEAD together with
documentation changes.
--
/ Alexander Bokovoy
Andrew Bartlett [Mon, 13 Jan 2003 12:48:37 +0000 (12:48 +0000)]
Updates to our NTLMSSP code:
This tries to extract our server-side code out of sessetup.c, and into a more
general lib. I hope this is only a temporay resting place - I indend to
refactor it again into an auth-subsystem independent lib, using callbacks.
Move some of our our NTLMSSP #defines into a new file, and add two that I found
in the COMsource docs - we seem to have a double-up, but I've verified from
traces that the NTLMSSP_TARGET_TYPE_{DOMAIN,SERVER} is real.
This code also copes with ASCII clients - not that we will ever see any here,
but I hope to use this for HTTP, were we can get them. Win2k authenticates
fine under forced ASCII, btw.
Tested with Win2k, NTLMv2 and Samba's smbclient.
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 12:42:20 +0000 (12:42 +0000)]
Accessing data after it's been free()ed really is a no-no...
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 12:21:07 +0000 (12:21 +0000)]
Fix to debian bug #171071 - we had the wrong dereference on the pointer to be
Realloc()ed, causing it to fail.
Big thanks to Sandor Sonfeld <sonf@linuxmail.org> for the debug, stack and
valgrind traces!
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 08:53:54 +0000 (08:53 +0000)]
Don't force the DOS password into a 14 char space, as this would imply null
termination - the password will not be null terminated before hashing if
len >= 14.
related to debian bug #157432
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jan 2003 08:09:32 +0000 (08:09 +0000)]
Ensure we do not pass uninitialised data to the kernel. (Picked up by
valgrind).
Andrew Bartlett
Martin Pool [Mon, 13 Jan 2003 04:57:21 +0000 (04:57 +0000)]
Fix typo in comment.
Tim Potter [Mon, 13 Jan 2003 03:45:31 +0000 (03:45 +0000)]
Merge ... remove "winbindd holding pattern" from appliance. It's a bit
simpler as the rescanning of trusted domains helps us out a bit.
Andrew Bartlett [Sun, 12 Jan 2003 12:23:37 +0000 (12:23 +0000)]
Keep all the const warnings in one place, by adding a utility function to
make the TDB_DATA.
Andrew Bartlett
Andrew Bartlett [Sun, 12 Jan 2003 11:31:03 +0000 (11:31 +0000)]
Oops, this is the change to use an fstring for the incoming service buffer -
the commit to reply.c just matches a pstrcpy for the pstring. (harmless, fixes
it for the automated test).
Andrew Bartlett
Andrew Bartlett [Sun, 12 Jan 2003 11:29:02 +0000 (11:29 +0000)]
Make the 'service' in make_connection() use an fstrcpy(), and an fstring,
becouse that is what it's input (reply_tcon_and_x) uses, and becouse we really
don't want supprises for service names.
Also remove a legacy #define, in favor of the lp_ equiv.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:33:00 +0000 (12:33 +0000)]
While the usage is most bisarre, this fixes up another fstring/pstring mixup.
(In this case, an fstrcpy() into a pstring, ie harmless).
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:24:19 +0000 (12:24 +0000)]
Use size_t for the counter vars, to match the type they are assigned from
(signed/unsigned mixup).
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:18:57 +0000 (12:18 +0000)]
A couple more fstring/pstring issues - and move from sizeof(fstring) to
sizeof(var) in slprintf statements, so as to ensure we don't get mixups there.
Also remove fstrcpy() into a variable that is about to be printed into anyway.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:13:03 +0000 (12:13 +0000)]
Remove an unused paramter for our old LM-only password change code, and fix a
(harmless) fstring/pstring mixup.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 12:04:14 +0000 (12:04 +0000)]
Fix a number of client-side fstring/pstring mixups.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 03:29:31 +0000 (03:29 +0000)]
Patch from Nik Conwell <nik@bu.edu>. Don't reference free()ed data when trying
to figure out if we have got our ticket yet.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 03:25:31 +0000 (03:25 +0000)]
Return the 'freindly' NT error message if at all possible.
Andrew Bartlett
Andrew Bartlett [Sat, 11 Jan 2003 03:23:16 +0000 (03:23 +0000)]
No point having this for both parts of the 'if' statement.
Andrew Bartlett
Gerald Carter [Sat, 11 Jan 2003 02:38:36 +0000 (02:38 +0000)]
[merge] make sure to update print queue cache during timeout_processing() to send notify events; CR 1491