20 years agoTest for reloading smb.conf after SIGHUP. Needs to be run as root.
Tim Potter [Mon, 24 Jul 2000 06:18:21 +0000 (06:18 +0000)]
Test for reloading smb.conf after SIGHUP.  Needs to be run as root.
(This used to be commit db54e72d2f67b07d42bff16c64fbadf0d031e365)

20 years agoFixed open handle code in printers - 3 functions were always being done
Jeremy Allison [Sat, 22 Jul 2000 00:48:29 +0000 (00:48 +0000)]
Fixed open handle code in printers - 3 functions were always being done
in order - moved them into open_printer_hnd().
Added saving of comment field.
(This used to be commit a0ee774fe92e5d0bc84d1d6729e8c538c67e8aba)

20 years agomake proto
Gerald Carter [Fri, 21 Jul 2000 20:10:52 +0000 (20:10 +0000)]
make proto
(This used to be commit e4af400ed6580c04bcaf3a28fe8aeaa0cdbd4dcf)

20 years ago* Added EnumPorts()
Gerald Carter [Fri, 21 Jul 2000 20:03:18 +0000 (20:03 +0000)]
* Added EnumPorts()
* Fixed an off-by-one bug noticed by JF in GetPrinterDriverDirectory()

(This used to be commit a9522f560da64045d928dabedeacdef0a6c3db51)

20 years agoAdded EnumPorts() and fixed up some problems
Gerald Carter [Fri, 21 Jul 2000 20:01:20 +0000 (20:01 +0000)]
Added EnumPorts() and fixed up some problems
with the other spoolss client calls.

Also cleaned up output for 'help' command.

(This used to be commit a0e8a55c279af50c1f770c7b913262094b9b593a)

20 years agoAdded EnumPorts() and fixed up some problems
Gerald Carter [Fri, 21 Jul 2000 19:59:51 +0000 (19:59 +0000)]
Added EnumPorts() and fixed up some problems
with the other spoolss client calls.

Also cleaned up output for 'help' command.

(This used to be commit 56ce247977c05ef37888c2572e679c44346e5568)

20 years agoAdded functions for enumerating ports on remote print server.
Gerald Carter [Fri, 21 Jul 2000 19:58:24 +0000 (19:58 +0000)]
Added functions for enumerating ports on remote print server.

Tim,  You should also look at new_smb_io_printer_info_2()
and see if the change from NULL to &i regarding the secdesc is ok.

(This used to be commit a2205c6646aa677090908a4e1532ed8590adc0e0)

20 years agomake proto
Gerald Carter [Thu, 20 Jul 2000 13:52:02 +0000 (13:52 +0000)]
make proto
(This used to be commit 1246728eb9013948d17ad44263501d1e1bb49e8f)

20 years agoreadded util_list.c (just to the RPCCLIENT_OBJ). I need to split
Gerald Carter [Thu, 20 Jul 2000 13:39:51 +0000 (13:39 +0000)]
readded util_list.c (just to the RPCCLIENT_OBJ).  I need to split
the file up i think.  Later.

(This used to be commit ed54a9f4d154ac56330b23255108447036cbd192)

20 years agoFixed unitilized secdesc pointer which was causing spoolgetprinter
Gerald Carter [Thu, 20 Jul 2000 13:38:48 +0000 (13:38 +0000)]
Fixed unitilized secdesc pointer which was causing spoolgetprinter
rpcclient command to fail on shared printers.

(This used to be commit c8abc31187dbfe6076277896b029fa11443e43bd)

20 years agoModified the patch to look in the tdb *first* - thus allowing legacy text
Jeremy Allison [Wed, 19 Jul 2000 23:47:10 +0000 (23:47 +0000)]
Modified the patch to look in the tdb *first* - thus allowing legacy text
filed to be ignored when an upload is done.
Modified to code to goto err on problems, simplifies it.
(This used to be commit 9157a6ab2646c035a731d53aa3be010488ccf51a)

20 years agoCode from John Reilly <jreilly@hp.com> to add tdb lookups into the Win95
Jeremy Allison [Wed, 19 Jul 2000 20:11:11 +0000 (20:11 +0000)]
Code from John Reilly <jreilly@hp.com> to add tdb lookups into the Win95
printer driver download if looking for the default driver files fail.
(This used to be commit 1192d867c4e863471f9bc12afceb68a23ba2142e)

20 years agoInstead of handing back a string (which might be a DNS name or an IP
Christopher R. Hertel [Wed, 19 Jul 2000 05:32:43 +0000 (05:32 +0000)]
Instead of handing back a string (which might be a DNS name or an IP
string), the wins_srv module now hands back a struct in_addr when it's
called.  It caches the IP address once it has been looked up.  The IP
is cleared (and must be looked up again) if the 'wins server' parameter
is reread, or if the node is marked 'dead'.  A dead node will not be
re-tried for 10 minutes (per a #define in wins_srv.c).

As it was, the code was reading the WINS server name or IP directly from
lp_wins_server.  That's okay, except that if the value was expressed as
a name, then a DNS lookup would be done every time the client wanted to
talk to the server.

I still need to work out the implications of failover regarding the
'unicast subnet' list.

Chris -)-----
(This used to be commit 73aa188320fd3bf10b5dfc057323f40aff2c13bd)

20 years agoFirst cut toward adding WINS server failover.
Christopher R. Hertel [Wed, 19 Jul 2000 01:21:30 +0000 (01:21 +0000)]
First cut toward adding WINS server failover.

*Note: failover doesn't actually work yet!*  It's just that the code I'm
adding provides all of the pieces necessary.

I do have one big question.  Something that I'll have to ask Jeremy, I'm
thinkin'.  In nmbd/nmbd_subnetdb.c the IP of the WINS server is used to
set up the Unicast subnet.

...so what happens if the WINS server changes?

My guess is either:
  a) nothing.
  b) I'd have to change the unicast subnet entry whenever the WINS server


BTW, the lp_wins_server() function no longer returns the WINS server name
or IP.  It returns the list of WINS servers entered in smb.conf.  To get
the currently 'live' WINS server, use the wins_srv() function.

Fun, eh?

Chris -)-----
(This used to be commit cc08bdc74f4cd111fdc582ee7babef47ed8a950d)

20 years agoRemoved the sanity check on the WINS SERVER parameter because it simply
Christopher R. Hertel [Tue, 18 Jul 2000 20:15:15 +0000 (20:15 +0000)]
Removed the sanity check on the WINS SERVER parameter because it simply
checked to see that only one server was listed.  As I am working on an
enhancement that allows multiple servers to be listed...this was a bit
contrary.  ;)
(This used to be commit 1b718f67675e52520f193a8c71c110246e70723f)

20 years agorpc_parse/parse_prs.c: Removed extraneous ()'s.
Jeremy Allison [Tue, 18 Jul 2000 19:25:32 +0000 (19:25 +0000)]
rpc_parse/parse_prs.c: Removed extraneous ()'s.
rpc_parse/parse_spoolss.c: Fixed the security descriptor marshalling in a INFO_2 struct.
for some reason SD's should be done inline after the info2, not
as the last buffer marshall.
rpc_server/srv_spoolss_nt.c: Removed extraneous ()'s.
(This used to be commit f038a24e9f624fdb04cd52769d45783248ce8a38)

20 years agoremove util_list from LIB_OBJS since it broke smbd build
Gerald Carter [Tue, 18 Jul 2000 19:05:50 +0000 (19:05 +0000)]
remove util_list from LIB_OBJS since it broke smbd build
(undefined references in link).  This is a quick fix.
I'll resolve things later.

Sorry everyone.

(This used to be commit ea64f2525d649c0952af52c2ba21a3bac57b322e)

20 years agoAdded lib/util_list.[c|o] to Makefile.in
Gerald Carter [Tue, 18 Jul 2000 05:19:29 +0000 (05:19 +0000)]
Added lib/util_list.[c|o] to Makefile.in

(This used to be commit 94967b31bbc913d9b45274d9eed846f871b66b6f)

20 years agoFixed some more client SPOOLSS functions. The following
Gerald Carter [Tue, 18 Jul 2000 05:16:30 +0000 (05:16 +0000)]
Fixed some more client SPOOLSS functions.  The following
functions work now:

  - spoolenum
  - spoolopen
  - spoolgetprinter
  - spoolgetprinterdriver

Items todo:

  - track down memory bug with spoolenumdata
  - fix spoolgetprinterdriverdir
  - fix spoolgetdata
  - fix display_job_info_ctr in spooljobs

All part of the ongoing rpcclient work.

Also included a new generic list ADT.  Cleaner and simplier
than the stuff in util_array.c i think (but then that's why I wrote it).

(This used to be commit 381aba2c9a63faa53728f0520ac316478bc7a1c3)

20 years agofixed a bug (my own) in create_ntc_from_cli_state()
Gerald Carter [Tue, 18 Jul 2000 05:13:44 +0000 (05:13 +0000)]
fixed a bug (my own) in create_ntc_from_cli_state()

(This used to be commit f7bc6df3befb8d0981dbd96f353039a5913321d7)

20 years agoI really didn't like the way generic arrays (lists) were
Gerald Carter [Tue, 18 Jul 2000 05:12:49 +0000 (05:12 +0000)]
I really didn't like the way generic arrays (lists) were
implemented in util_array.c so I wrote a smaller (and simplier

I would like to replace the use of util_array.c functions
in the rest of the source tree if no one objects.
This will be an interface change, but not really a difference
in the functionality provided.

(This used to be commit 0863ce3a31e4c76c8356850ac128f6d96ea54917)

20 years agograb functions that return RPC_HND_NODE (declared
Gerald Carter [Tue, 18 Jul 2000 05:10:26 +0000 (05:10 +0000)]
grab functions that return RPC_HND_NODE (declared
in include/util_list.h)

-- jerry
(This used to be commit ccebd70df2c096de1b183ae072c2c720e2277c6f)

20 years agoFixed some more client SPOOLSS functions. The following
Gerald Carter [Tue, 18 Jul 2000 05:07:28 +0000 (05:07 +0000)]
Fixed some more client SPOOLSS functions.  The following
functions work now:

  - spoolenum
  - spoolopen
  - spoolgetprinter
  - spoolgetprinterdriver

Items todo:

  - track down memory bug with spoolenumdata
  - fix spoolgetprinterdriverdir
  - fix spoolgetdata
  - fix display_job_info_ctr in spooljobs

All part of the rpcclient work.

Jeremy, this check includes emthods for associating
POLICY_HNDs and client states.  See the RpcHndList_...()
function calls (implemented in lib/util_list.c)

(This used to be commit 84349394a988213724ca138e9692b3bc44fa0cb8)

20 years agoFixed some more SPOOLSS functions. The following
Gerald Carter [Tue, 18 Jul 2000 05:02:16 +0000 (05:02 +0000)]
Fixed some more SPOOLSS functions.  The following
functions work now:

  - spoolenum
  - spoolopen
  - spoolgetprinter
  - spoolgetprinterdriver

Items todo:

  - track down memory bug with spoolenumdata
  - fix spoolgetprinterdriverdir
  - fix spoolgetdata
  - fix display_job_info_ctr in spooljobs

(This used to be commit 15b35912713557119aba5d0cd59605997d6b5ee9)

20 years agoMissing var.
Tim Potter [Mon, 17 Jul 2000 06:04:23 +0000 (06:04 +0000)]
Missing var.
(This used to be commit 5c1c5622269c54dca89eb178ca25981ab7928e75)

20 years agoReverted changes from rpcclient merge - contains memory leak!
Tim Potter [Mon, 17 Jul 2000 05:40:48 +0000 (05:40 +0000)]
Reverted changes from rpcclient merge - contains memory leak!
(This used to be commit dea06ad7a554089a7394cdcb6bf5a766e8e8a6c3)

20 years agoFree security descriptor after access check in update_printer_sec()
Tim Potter [Mon, 17 Jul 2000 05:38:26 +0000 (05:38 +0000)]
Free security descriptor after access check in update_printer_sec()
(This used to be commit bc5f9c00be5b8c2f6d258f0c95ed3b4fc0201b87)

20 years agoInitialise current time to time(NULL) in add_a_printer_2()
Tim Potter [Mon, 17 Jul 2000 05:37:16 +0000 (05:37 +0000)]
Initialise current time to time(NULL) in add_a_printer_2()

Added get and free security old descriptor in nt_printing_setsec() after
access checking was moved up to rpc level.
(This used to be commit a5b7cafc87e14ca3f28dcfc1ed6bcc6f47e79639)

20 years agomake proto
Tim Potter [Mon, 17 Jul 2000 03:13:06 +0000 (03:13 +0000)]
make proto
(This used to be commit df0ef98d7ed41899ce97d20163ab49081347ae83)

20 years agomake proto
Tim Potter [Mon, 17 Jul 2000 02:43:12 +0000 (02:43 +0000)]
make proto
(This used to be commit 4443a8b6e698a6572152e575c41dfb760b9888a9)

20 years agoAllow job owner to delete own print job.
Tim Potter [Mon, 17 Jul 2000 02:42:25 +0000 (02:42 +0000)]
Allow job owner to delete own print job.
(This used to be commit 90b1857c81627e587a7395ee2bdb51b26ea46512)

20 years agoMoved access check for nt_printing_setsec() up into rpc function.
Tim Potter [Mon, 17 Jul 2000 02:41:38 +0000 (02:41 +0000)]
Moved access check for nt_printing_setsec() up into rpc function.

Use sid + rid instead of lp_workgroup()/Administrator for printer owner sid
as per JF's advice.

Default printer owner is either the administrator of the pdc workgroup or
Everyone depending on whether winbindd is running.  Still the subject of
some debate...

Renamed se_access_check() parameters.
(This used to be commit e92e161a813ac0793897ffe3d33b01054912d4c7)

20 years agoRenamed arguments to se_access_check()
Tim Potter [Mon, 17 Jul 2000 02:38:43 +0000 (02:38 +0000)]
Renamed arguments to se_access_check()
(This used to be commit 714b50b47dab46f5cdde49d7c200b353c2e0398a)

20 years agoRenamed a parameter in init_request() function.
Tim Potter [Mon, 17 Jul 2000 02:37:11 +0000 (02:37 +0000)]
Renamed a parameter in init_request() function.

Initialise response structure correctly.
(This used to be commit 587c8e58fdd79dce47fb59ce702596ea58c8b4a6)

20 years agoAdded some debugs.
Tim Potter [Mon, 17 Jul 2000 02:36:19 +0000 (02:36 +0000)]
Added some debugs.

Changed interface to se_access_check to take a user struct instead of each
bit as a separate parameter.
(This used to be commit ff7938310d0636b165b03a2b0a15e51494b2459f)

20 years agoI committed this change to the cliffs archive a while back and have heard
Christopher R. Hertel [Sat, 15 Jul 2000 20:57:24 +0000 (20:57 +0000)]
I committed this change to the cliffs archive a while back and have heard
no complaints.  ;)

Basically, instead of ignoring single-line C-style comments in IDL source
files this change allows token.awk to ignore both single- and multi-line
C-style comments.

Chris -)-----
(This used to be commit 34f69f09f840b8990b718e8585785e2a6ad7c314)

20 years agoLots of changes but no real progress in functionality.
Gerald Carter [Sat, 15 Jul 2000 08:37:17 +0000 (08:37 +0000)]
Lots of changes but no real progress in functionality.
more changes to remove the ncarpc_l_* stuff.

Fixed some cut and paste errors from TNG

There are very subtle bugs in this code.  I'll work on simplifying
them in round two or three.

(This used to be commit f8509356178deb7e78836d1f5aceb96677ac738b)

20 years agoreverted a some previous additions.
Gerald Carter [Sat, 15 Jul 2000 08:33:43 +0000 (08:33 +0000)]
reverted a some previous additions.
Removed msrpc_local struct

(This used to be commit b2317babb557f5bce390c7162c9936f5d46f4da3)

20 years agoa few changes to Makefile.in to clean up dependencies for rpcclient
Gerald Carter [Fri, 14 Jul 2000 17:04:57 +0000 (17:04 +0000)]
a few changes to Makefile.in to clean up dependencies for rpcclient

(This used to be commit 9206d593603af959700794d252da8d07082012ef)

20 years agoMore functions merged from TNG for rpcclient. They don't all work
Gerald Carter [Fri, 14 Jul 2000 17:04:04 +0000 (17:04 +0000)]
More functions merged from TNG for rpcclient.  They don't all work
currently as I have to do something about the policy handle caching

(This used to be commit 233b074f490b3b01f3a462284aa8117536df0082)

20 years agocleaned up access to prs_struct variables. Replaced all calls
Gerald Carter [Fri, 14 Jul 2000 17:01:49 +0000 (17:01 +0000)]
cleaned up access to prs_struct variables.  Replaced all calls

prs_free_data() => prs_mem_free
prs_realloc_data => prs_grow

(This used to be commit 3d00e969df1800dadbb91fd8c410e9ce87188551)

20 years agoremoved references to loopback RPC connections.
Gerald Carter [Fri, 14 Jul 2000 16:59:41 +0000 (16:59 +0000)]
removed references to loopback RPC connections.
added a few more kfunctions from TNG for rpcclient

(This used to be commit 549d1d262115aeb2cd4d3f0122a5771be17752bb)

20 years agoremoved prs_data(), prs_free_data(), and prs_realloc_data()
Gerald Carter [Fri, 14 Jul 2000 16:58:03 +0000 (16:58 +0000)]
removed prs_data(), prs_free_data(), and prs_realloc_data()
as these were unneeded and replaced by the real functions
already in HEAD.

Added a few more functions to parse_spoolss.c to help with the
rpcclient merge from TNG.
(This used to be commit 3bc9af4c1dbdb664970541f6091982ffccc87b31)

20 years agoFixed a bug in cmd_interp.c where if user%pass was entered on
Gerald Carter [Fri, 14 Jul 2000 16:54:07 +0000 (16:54 +0000)]
Fixed a bug in cmd_interp.c where if user%pass was entered on
the command line, the password would still be cached in memory
in plain text for the lifetime of the rpcclient command line session.

removed loopback connection functions from msrpc-client.c since
we don't support that in the server code now anyways.  simplify,
simplify, ...

(This used to be commit 8599e1bc394b1caee2483ec72d439a34d3f30629)

20 years agomake proto
Gerald Carter [Fri, 14 Jul 2000 16:31:06 +0000 (16:31 +0000)]
make proto
and a few changes to ntdomain for rpcclient printing functions

(This used to be commit eb3f545f54eabb8b2b9a735808ebf49808ea85eb)

20 years agoadding more spoolss command into rpcclient. They don't all work
Gerald Carter [Fri, 14 Jul 2000 16:29:22 +0000 (16:29 +0000)]
adding more spoolss command into rpcclient.  They don't all work
currently.  More to come later.

(This used to be commit 0faf21662db5b24b7fd57736ea53772e3baca5df)

20 years agoDon't return winbind groups or users when responding to samr_enum_dom_users
Tim Potter [Thu, 13 Jul 2000 04:33:25 +0000 (04:33 +0000)]
Don't return winbind groups or users when responding to samr_enum_dom_users
and samr_enum_dom_aliases commands.  Unfortunately the algorithm for
determining winbind groups from normal groups is simply to check for the
presence of the lp_winbind_separator() character.  )-:
(This used to be commit 363a9c45bf0a7d3266ccdf4eeb0b9f5e3d38389f)

20 years agoUninitialised variables.
Tim Potter [Thu, 13 Jul 2000 01:21:21 +0000 (01:21 +0000)]
Uninitialised variables.
(This used to be commit a895868912a24589de3a904ca537cf3367a645bf)

20 years agowe are now sure the printer_info_2 timestamp is updated everytime
Jean-François Micouleau [Wed, 12 Jul 2000 16:11:33 +0000 (16:11 +0000)]
we are now sure the printer_info_2 timestamp is updated everytime

(This used to be commit 08b41bab177affac088c981d7c620728e8e6e9b0)

20 years ago- The printers are indexed by the sharename in both get_a_printer() and
Jean-François Micouleau [Wed, 12 Jul 2000 14:10:40 +0000 (14:10 +0000)]
- The printers are indexed by the sharename in both get_a_printer() and
add_a_printer() now.

- correctly unpack the private part of a devmode and remove a memleak

- correctly retrieve the pair(value,data) for getprinterdata

- handle null devicemode in printer_info_2

I still have some bugs but I'm not crashing anymore NT4SP6 d/c build :-)

(This used to be commit 493f7d11acf753ba24c88e6cbb73d86a8595a66a)

20 years agoAn improved version of the Negative Query Response fix. The earlier fix
Christopher R. Hertel [Wed, 12 Jul 2000 04:25:12 +0000 (04:25 +0000)]
An improved version of the Negative Query Response fix.  The earlier fix
only did a short-cut on an rcode of 3, which is 'name not found'.  This
does a short-cut on any non-zero rcode.  It also puts out a DEBUG message
(if DEBUGLEVEL is >= 3) detailing the error.

Chris -)-----
(This used to be commit d8656304d51844335e72babe852673f2dececfdc)

20 years agoTypo. It said "DEGUG" in the comments. I dunno how to degug, or gug for
Christopher R. Hertel [Wed, 12 Jul 2000 03:51:06 +0000 (03:51 +0000)]
Typo.  It said "DEGUG" in the comments.  I dunno how to degug, or gug for
that matter.  crh
(This used to be commit 6ee63ecfa5f9c984f51c15597a50e085ab722e87)

20 years ago#ifndef RPCCLIENT_TEST
Gerald Carter [Tue, 11 Jul 2000 16:28:59 +0000 (16:28 +0000)]
use old prs_unistr()
use new prs_unistr() which handles UNMARSHALL
#endif /* RPCCLIENT_TEST */

(This used to be commit fb0e1fb9e31db135eeb8e949a7ad0826906ba1ff)

20 years agoAllow name lookup to fail and fall back to using the "Everyone" SID
Jeremy Allison [Tue, 11 Jul 2000 01:05:24 +0000 (01:05 +0000)]
Allow name lookup to fail and fall back to using the "Everyone" SID
as SD owner. Allows smbd to work without winbindd running.
Check for security implications !
(This used to be commit 9bd64da1e26a1b4a2df2b0537feb604a40762bb1)

20 years agoAdd local fallback for name lookup if no winbindd running...
Jeremy Allison [Tue, 11 Jul 2000 01:04:09 +0000 (01:04 +0000)]
Add local fallback for name lookup if no winbindd running...
(This used to be commit d85deb9e4e9c9784006292d3cb5a6b7b408ff972)

20 years agoEnsure correct driver paths are returned in INFO_2 struct.
Jeremy Allison [Mon, 10 Jul 2000 22:30:13 +0000 (22:30 +0000)]
Ensure correct driver paths are returned in INFO_2 struct.
(This used to be commit 7a95c289cd0b4615d2a5aa8a148c767b57460ffa)

20 years agomake proto
Gerald Carter [Mon, 10 Jul 2000 19:58:18 +0000 (19:58 +0000)]
make proto
(This used to be commit ae85cc43fec26be6184e863569a94cab0afc425a)

20 years agospoolenum commend (when compiled with the new prs_unistr())
Gerald Carter [Mon, 10 Jul 2000 19:57:30 +0000 (19:57 +0000)]
spoolenum commend (when compiled with the new prs_unistr())
now works.   :-)

(This used to be commit 588aadb29fbb7cc0e81ac19f95e97101a64dbd8e)

20 years agoFixed a bug in parsing the command line.
Gerald Carter [Mon, 10 Jul 2000 19:56:15 +0000 (19:56 +0000)]
Fixed a bug in parsing the command line.

(This used to be commit ebcb7473c6b62266c30e276d02186d8e50a5629a)

20 years agoincluded a a new prs_unistr(). Is currently #if'd out (denoted
Gerald Carter [Mon, 10 Jul 2000 19:55:39 +0000 (19:55 +0000)]
included a a new prs_unistr().  Is currently #if'd out (denoted
by RPCCLIENT_TEST) in order to not break anything in the smbd
code (and to give time to review it).  Originally written by JF.
In effect, this checkin makes no changes to parse_prs.c at all.

(This used to be commit 4f431ea1f5d1d3b868d0bb56a299070e608c2512)

20 years agoAdded wbinfo and .libs
Tim Potter [Mon, 10 Jul 2000 06:42:47 +0000 (06:42 +0000)]
Added wbinfo and .libs
(This used to be commit da67a5099ebfb68172c1c419103665f571e82157)

20 years agoFixes for various compile warnings on Solaris 8.
Tim Potter [Mon, 10 Jul 2000 06:41:04 +0000 (06:41 +0000)]
Fixes for various compile warnings on Solaris 8.
(This used to be commit 898a483cdab1ed7d8ff902c0dc0e0620440ae4cd)

20 years agoMoved winbind client functions from various odd locations to
Tim Potter [Mon, 10 Jul 2000 05:40:43 +0000 (05:40 +0000)]
Moved winbind client functions from various odd locations to

Merge of nsswitch/common.c rename to nsswitch/wb_common.c from TNG.
(This used to be commit f866c18f6be65db67d9d2a6c0b42e1af3b421e6c)

20 years agomake proto
Tim Potter [Mon, 10 Jul 2000 05:17:01 +0000 (05:17 +0000)]
make proto
(This used to be commit 5f355a24430dcb260de52e8a0ca21e80cae53089)

20 years agoRe-instated lanman printing security checks (oops).
Tim Potter [Mon, 10 Jul 2000 05:08:21 +0000 (05:08 +0000)]
Re-instated lanman printing security checks (oops).

A user can now pause, resume or delete their own job even if they don't
have the Manage Documents privilege.

Added call to se_access_check() for changing printer properties.  The Full
Access privilege is required for the user to perform this.

Several uninitialised variables and memory leaks plugged.

Modified default ACL created on new printers to be Everyone / Print instead
of Everyone / Full Access.  This required some random stuffing around with
the value of the revision field to correspond with the ACL that NT produces
when setting the same permission on the printer.

Fixed dodgy function call in printing/printfsp.c
(This used to be commit 2abce4dcfa351051df6e5f789b34fa99c9b81c22)

20 years agoSpelling fixes.
Tim Potter [Mon, 10 Jul 2000 04:57:09 +0000 (04:57 +0000)]
Spelling fixes.
(This used to be commit c1d242f1dd5b6addbe5d2df22e4759f6682fd9ef)

20 years agoFix for passing NULL pointer as an array parameter in
Tim Potter [Mon, 10 Jul 2000 04:56:30 +0000 (04:56 +0000)]
Fix for passing NULL pointer as an array parameter in
(This used to be commit 3ee111bff78826a5ee419554d4ef2b2b2d3ae7aa)

20 years agoAdded some useful debugging stuff.
Tim Potter [Mon, 10 Jul 2000 04:54:09 +0000 (04:54 +0000)]
Added some useful debugging stuff.

Fixes for se_access_check() when you are the owner of the object.
(This used to be commit 1478198b709b26d0007a8ff0586c34fc6f37a9d2)

20 years agoQuick change to short-circuit WINS queries if the WINS server returns a
Christopher R. Hertel [Sun, 9 Jul 2000 02:10:24 +0000 (02:10 +0000)]
Quick change to short-circuit WINS queries if the WINS server returns a
Negative Name Query Response.  We should't wait through the timeouts and
retry twice if we've been told "No Such Entry".
(This used to be commit 2bbd16903db02aacb729d1ad140056b180e2a776)

20 years agoJust a few changes due to bringing some partial files back
Gerald Carter [Fri, 7 Jul 2000 06:24:16 +0000 (06:24 +0000)]
Just a few changes due to bringing some partial files back
from TNG to HEAD.

(This used to be commit ddef41c13484f488657ea36a510b52cefc7c8643)

20 years agoMore rpcclient merge issues:
Gerald Carter [Fri, 7 Jul 2000 06:20:46 +0000 (06:20 +0000)]
More rpcclient merge issues:

        * fixes some readline bugs from the merge
        * first attempt at commands (spoolenum almost works)
        * no changes to existing functions in HEAD; only additions
          of new functions.  I'll weed out what I can as I go.

(This used to be commit 61d2aad5dc2b212b11c981f1eca47efa627e9fc8)

20 years agoMore rpcclient merge issues:
Gerald Carter [Fri, 7 Jul 2000 06:18:00 +0000 (06:18 +0000)]
More rpcclient merge issues:

* fixes some readline bugs from the merge
* first attempt at commands (spoolenum almost works)
* no changes to existing functions in HEAD; only additions
  of new functions.  I'll weed out what I can as I go.

(This used to be commit 12e2a21e1bc4c6fa02606d21cea4cb5a8b4d41a9)

20 years agoprinting/nt_printing.c: (From JF) use the driver name - already given to us.
Jeremy Allison [Thu, 6 Jul 2000 23:31:46 +0000 (23:31 +0000)]
printing/nt_printing.c: (From JF) use the driver name - already given to us.
printing/printing.c: priority needs to be 1 not zero (found by checked build).
rpc_server/srv_spoolss_nt.c: Log invalid handle access, also print out if this is a different
pid handle. This will help track down client access after a connection
is closed.
(This used to be commit 4ff949228c40b6abb2008df8db985562ac2895d2)

20 years agose_access_check() tests.
Tim Potter [Thu, 6 Jul 2000 07:12:13 +0000 (07:12 +0000)]
se_access_check() tests.
(This used to be commit bba912cad8dfcef3dbc1db020304ab29fd71d5cb)

20 years agoDon't check NT permissions when printing from lanman.
Tim Potter [Thu, 6 Jul 2000 07:10:32 +0000 (07:10 +0000)]
Don't check NT permissions when printing from lanman.
(This used to be commit e84607eedf3be454f8f709c70cafc5ded4ea951d)

20 years agoImplemented NT printer descriptor checking. Yay!
Tim Potter [Thu, 6 Jul 2000 07:06:05 +0000 (07:06 +0000)]
Implemented NT printer descriptor checking.  Yay!

User details are passed into the printing back end from the spoolss code.
For each print operation these details are checked using the
se_access_check() function using information from the winbind daemon.

Fixed bug in nt_printing_setsec() where the user and group SIDs were
trashed if the permissions were changed from NT.  It is necessary to merge
these sids from the previous value of the security descriptor before
storing it in the tdb.
(This used to be commit 8d42661d424d80e1048d08b5cad3281643231d62)

20 years agoMoved authenticated pipe user details into a current_user struct.
Tim Potter [Thu, 6 Jul 2000 07:01:37 +0000 (07:01 +0000)]
Moved authenticated pipe user details into a current_user struct.
(This used to be commit 3c4a5f624bfa69eb81d998530d9227e158edd109)

20 years agoMoved printer ACE mask values from nt_printing.h to rpc_spoolss.h
Tim Potter [Thu, 6 Jul 2000 07:00:24 +0000 (07:00 +0000)]
Moved printer ACE mask values from nt_printing.h to rpc_spoolss.h
(This used to be commit 9245af1ea18babae09a92af634428a63ec55438e)

20 years agoInclude nss.h if present or define enough values to allow client access to
Tim Potter [Thu, 6 Jul 2000 06:59:27 +0000 (06:59 +0000)]
Include nss.h if present or define enough values to allow client access to
(This used to be commit 669bd8dc1ab4690cf21310fe0310f1716e4a0197)

20 years agoRewrite of se_access_check() function. Added comments and fixed a bunch of
Tim Potter [Thu, 6 Jul 2000 06:57:22 +0000 (06:57 +0000)]
Rewrite of se_access_check() function.  Added comments and fixed a bunch of
bugs.  I think there is a problem though with the permissions granted when
SEC_RIGHTS_MAXIMUM_ALLOWED is passed as the permissions requested.
(This used to be commit 27d821913c87dddd44a0690f4b191c9d2445817e)

20 years agoPass either an authenticated pipe or SMB user in a current_user struct down
Tim Potter [Thu, 6 Jul 2000 06:53:47 +0000 (06:53 +0000)]
Pass either an authenticated pipe or SMB user in a current_user struct down
to the printing back end functions.
(This used to be commit a2751a269e05d5e46d4b22d6082a5898cdb4526f)

20 years agoPass pipes_struct rather than vuid down to startdocprinter, setprinter and
Tim Potter [Thu, 6 Jul 2000 06:51:55 +0000 (06:51 +0000)]
Pass pipes_struct rather than vuid down to startdocprinter, setprinter and
setjob spoolss server commands.
(This used to be commit f35745137451f769a0723cb0665ba0b9d4801ad8)

20 years agoAdded global_sid_NULL S-1-0-0 to list of global sids.
Tim Potter [Thu, 6 Jul 2000 06:48:54 +0000 (06:48 +0000)]
Added global_sid_NULL S-1-0-0 to list of global sids.
(This used to be commit f49905e74c6e3891b5816b136fd1d0d77c392e2f)

20 years agoMake prototypes for functions returning an enum nss_status.
Tim Potter [Thu, 6 Jul 2000 06:48:01 +0000 (06:48 +0000)]
Make prototypes for functions returning an enum nss_status.
(This used to be commit dac9c934ac3932fb9870417e8f712a880dd25e45)

20 years agoChanged checking for WINBINDD_OK return value instead of NSS_STATUS_SUCCESS
Tim Potter [Thu, 6 Jul 2000 06:47:38 +0000 (06:47 +0000)]
Changed checking for WINBINDD_OK return value instead of NSS_STATUS_SUCCESS
when looking up sids from winbindd.
(This used to be commit 79fb877bf13ba462ad0a878d8975f8b5183e3ea3)

20 years agoMoved lib/util_seaccess.o from LIB_OBJ to SMBD1_OBJ as it is only used by
Tim Potter [Thu, 6 Jul 2000 06:43:30 +0000 (06:43 +0000)]
Moved lib/util_seaccess.o from LIB_OBJ to SMBD1_OBJ as it is only used by
(This used to be commit 539c32fa423bee9be34eeda96fad5398f7cf982b)

20 years agonew protos
Andrew Tridgell [Thu, 6 Jul 2000 03:54:22 +0000 (03:54 +0000)]
new protos
(This used to be commit bd323fa503b1ad7ab9ca35b2f93774541b02e8e3)

20 years agothe smbw sample prog
Andrew Tridgell [Thu, 6 Jul 2000 03:54:07 +0000 (03:54 +0000)]
the smbw sample prog
(This used to be commit 0afcc0d3368472ed4b49167dc4b7d907b0ccdc25)

20 years agodon't need shmem any more
Andrew Tridgell [Thu, 6 Jul 2000 03:53:49 +0000 (03:53 +0000)]
don't need shmem any more
(This used to be commit a81371a4fd6f7972b054bea90428d1d2fd6d1d22)

20 years agowrote a little sample smbw program
Andrew Tridgell [Thu, 6 Jul 2000 03:52:47 +0000 (03:52 +0000)]
wrote a little sample smbw program
build using "make bin/smbw_sample"

this is to show people how to use smbw
(This used to be commit 7d7ceaa9219ba88075cac23eb42b163903537c70)

20 years agoadded -L option
Andrew Tridgell [Thu, 6 Jul 2000 03:39:11 +0000 (03:39 +0000)]
added -L option
(This used to be commit ae80ca637cd4de6d18f995a4b6e1e1e21ab63581)

20 years agogot smbw to compile again on Linux
Andrew Tridgell [Thu, 6 Jul 2000 02:28:44 +0000 (02:28 +0000)]
got smbw to compile again on Linux
(This used to be commit 614fd4119ce5aa37acd03321dc6ef263ae16bdc5)

20 years agoBracked unbracketed macro arguments while looking for another bug.
Tim Potter [Thu, 6 Jul 2000 01:30:41 +0000 (01:30 +0000)]
Bracked unbracketed macro arguments while looking for another bug.
(This used to be commit 873774e36dfc877727133a86fbc2c2ddc2d563cd)

20 years agoMerge of wbinfo program from TNG.
Tim Potter [Wed, 5 Jul 2000 11:24:26 +0000 (11:24 +0000)]
Merge of wbinfo program from TNG.
(This used to be commit 659e4d88ff9dbf1fa9cd8904470c4a8d02d8674b)

20 years agothe dummy field in driver_info_6 is before the driver version and not
Jean-François Micouleau [Tue, 4 Jul 2000 22:51:05 +0000 (22:51 +0000)]
the dummy field in driver_info_6 is before the driver version and not

I don't know who broke all that code, but I'm  ******** (censured)

(This used to be commit 1fae158529ca0d1cb01ff422638418ce0dbd8dbf)

20 years agodriver_info_6 had a prs_align() that should not have been there.
Jean-François Micouleau [Tue, 4 Jul 2000 21:58:45 +0000 (21:58 +0000)]
driver_info_6 had a prs_align() that should not have been there.

(This used to be commit a882dd225e464b300cedb52eb43f57f3a56c5b31)

20 years agoSome more sec_ctx changes. Modified some fields in the pipe_struct
Tim Potter [Mon, 3 Jul 2000 06:52:31 +0000 (06:52 +0000)]
Some more sec_ctx changes.  Modified some fields in the pipe_struct
structure so authenticated pipe users can have their unix groups set when
become_authenticated_pipe_user() is called.
(This used to be commit 55c9bf124dc661df43bfe582ef14b1297aeaf0fa)

20 years agofirst pass at merging rpcclient from TNG to HEAD. You can get a
Gerald Carter [Mon, 3 Jul 2000 04:29:17 +0000 (04:29 +0000)]
first pass at merging rpcclient from TNG to HEAD.  You can get a
semi-connection and a rpcclient prompt, but no functionality there yet.
Will be a few more days on that.

I need to clean this up a little.  Will work on that some more.

(This used to be commit 1b305cb3421eef575cc19bacf1fcc57537d7ea75)

20 years agofirst pass at merging rpcclient from TNG to HEAD. You can get a
Gerald Carter [Mon, 3 Jul 2000 04:28:29 +0000 (04:28 +0000)]
first pass at merging rpcclient from TNG to HEAD.  You can get a
semi-connection and a rpcclient prompt, but no functionality there yet.
Will be a few more days on that.

(This used to be commit 269051aa0c52728278a1d290148564f11cf7f189)

20 years agofirst pass at merging rpcclient from TNG to HEAD. You can get a
Gerald Carter [Mon, 3 Jul 2000 04:26:37 +0000 (04:26 +0000)]
first pass at merging rpcclient from TNG to HEAD.  You can get a
semi-connection and a rpcclient prompt, but no functionality there yet.
Will be a few more days on that.

The changes to the header files were minor.  A few struct's and a few
additional fields to existing ones.  No deletions.  **minimal change
necessary** :-)  Well, maybe not minimal, but I tried.

All other programs compile, link and run ok from what I can tell so
I don;t think I broke anything.

(This used to be commit cd7f0b0b91afd3331c0607ba2fcb3ccdd41ecebf)