9 years agos4-build: make LIBSAMBA-NET a private library
Andrew Tridgell [Thu, 21 Oct 2010 00:28:58 +0000 (11:28 +1100)]
s4-build: make LIBSAMBA-NET a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf-build: create a NDR_SAMBA grouping library
Andrew Tridgell [Thu, 21 Oct 2010 00:28:27 +0000 (11:28 +1100)]
waf-build: create a NDR_SAMBA grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf-build: create a samba_sockets grouping library
Andrew Tridgell [Thu, 21 Oct 2010 00:28:05 +0000 (11:28 +1100)]
waf-build: create a samba_sockets grouping library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-waf: removed dependencies on missing subsystems
Andrew Tridgell [Thu, 21 Oct 2010 00:25:59 +0000 (11:25 +1100)]
s4-waf: removed dependencies on missing subsystems

these were left over from the old config.mk system

9 years agowaf: replace the is_bundled option with private_library
Andrew Tridgell [Thu, 21 Oct 2010 00:22:36 +0000 (11:22 +1100)]
waf: replace the is_bundled option with private_library

'private_library' better captures what we are trying to get at when we
bundle a library

9 years agowaf: added the concept of a grouping_library
Andrew Tridgell [Thu, 21 Oct 2010 00:19:09 +0000 (11:19 +1100)]
waf: added the concept of a grouping_library

a grouping library is one which 'groups' a set of subsystems. This
means that if a target depends on a subsystem that is within a
grouping library then that dependency is replaced with a dependency on
the grouping library.

This gives us a powerful method to avoid duplicated object files
between libraries.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-build: fixed some formatting
Andrew Tridgell [Wed, 20 Oct 2010 21:59:06 +0000 (08:59 +1100)]
s4-build: fixed some formatting

indentation was far too deep

9 years agobuild: subunit and popt need to be marked as private libraries
Andrew Tridgell [Wed, 20 Oct 2010 21:58:35 +0000 (08:58 +1100)]
build: subunit and popt need to be marked as private libraries

they have no vnum

9 years agowaf: cope with libraries with a specified version number
Andrew Tridgell [Wed, 20 Oct 2010 21:54:36 +0000 (08:54 +1100)]
waf: cope with libraries with a specified version number

this fixes a problem with libnss_winbind.so.2. Thanks to Jelmer for
spotting this.

9 years agos4-libcli: make LIBCLI_LDAP a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:30:55 +0000 (08:30 +1100)]
s4-libcli: make LIBCLI_LDAP a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-auth: make auth a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:30:39 +0000 (08:30 +1100)]
s4-auth: make auth a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoreplace: make libreplace a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:30:15 +0000 (08:30 +1100)]
replace: make libreplace a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-ndr: make NDR_TABLE a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:29:24 +0000 (08:29 +1100)]
s4-ndr: make NDR_TABLE a private library

this greatly reduces the size of ndrdump, and saves us a fair bit of

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agolibcli: make LIBCLI_NBT a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:28:35 +0000 (08:28 +1100)]
libcli: make LIBCLI_NBT a private library

9 years agowrapper: make socket_wrapper, uid_wrapper and nss_wrapper private libs
Andrew Tridgell [Wed, 20 Oct 2010 21:28:12 +0000 (08:28 +1100)]
wrapper: make socket_wrapper, uid_wrapper and nss_wrapper private libs

this prevents double instantiation

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf: re-work the module alias code
Andrew Tridgell [Wed, 20 Oct 2010 21:27:07 +0000 (08:27 +1100)]
waf: re-work the module alias code

we now create a base library, and then create the alias modules as
wrappers around that base. That prevents double instantiation of any
object files in the modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-dsdb: make SAMDB_COMMON into a private library
Andrew Tridgell [Wed, 20 Oct 2010 07:19:55 +0000 (18:19 +1100)]
s4-dsdb: make SAMDB_COMMON into a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agolibcli: make the LIBSECURITY subsystem into a private library
Andrew Tridgell [Wed, 20 Oct 2010 07:19:31 +0000 (18:19 +1100)]
libcli: make the LIBSECURITY subsystem into a private library

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf: fixed expansion of direct_objects and direct_libs
Andrew Tridgell [Wed, 20 Oct 2010 07:17:52 +0000 (18:17 +1100)]
waf: fixed expansion of direct_objects and direct_libs

these do not need to be expanded in break_dependency_loops()

9 years agowaf: allows libraries to be marked as private_library=True
Andrew Tridgell [Wed, 20 Oct 2010 07:17:13 +0000 (18:17 +1100)]
waf: allows libraries to be marked as private_library=True

this is for libraries where we make no promises about the API, but
where we wish it to be a library to allow our binaries to use common

These libraries always get the project suffix added to the library
name, to ensure we are in a separate namespace

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf: rework expand_subsystem_deps()
Andrew Tridgell [Wed, 20 Oct 2010 07:11:31 +0000 (18:11 +1100)]
waf: rework expand_subsystem_deps()

make the variable names a lot clearer, and restrict the expansion of
subsystem deps to object style subsystems and modules. If a subsystem
or a module is built as a library then we don't need to expand the
dependencies across that boundary

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf: added --show-deps and --show-duplicates
Andrew Tridgell [Wed, 20 Oct 2010 07:09:45 +0000 (18:09 +1100)]
waf: added --show-deps and --show-duplicates

these options make it easier to examine our depenency tree, by showing
any objects linked into more than one library, and by showing the
dependency tree for a chosen target

9 years agoldb:ldb_modules.c - if we don't find the associated dynamic object then please close...
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 06:51:46 +0000 (08:51 +0200)]
ldb:ldb_modules.c - if we don't find the associated dynamic object then please close the handle

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 21 07:52:44 UTC 2010 on sn-devel-104

9 years agoldb:ldb_tdb/ldb_cache.c - remove a superflous "talloc_free"
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 07:03:31 +0000 (09:03 +0200)]
ldb:ldb_tdb/ldb_cache.c - remove a superflous "talloc_free"

Didn't realise that this is already called by "ltdb_attributes_unload".

9 years agoldb:ldb_tdb/ldb_cache.c - in this function we don't use LDB return codes
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 06:45:06 +0000 (08:45 +0200)]
ldb:ldb_tdb/ldb_cache.c - in this function we don't use LDB return codes

9 years agos4:lib/util/charset/iconv.c - remove a distinction which can never happen
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 17:55:28 +0000 (19:55 +0200)]
s4:lib/util/charset/iconv.c - remove a distinction which can never happen

"ret->cd_direct" is never set before. It is set in the "if" upperwards but
then the function is terminated with "return".

9 years agoNow we have SeSystemSecurity, remove the source3-only #ifdef.
Jeremy Allison [Thu, 21 Oct 2010 00:51:13 +0000 (17:51 -0700)]
Now we have SeSystemSecurity, remove the source3-only #ifdef.


Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 21 01:35:00 UTC 2010 on sn-devel-104

9 years agoAdd code to implement SeSecurityPrivilege in net rpc rights, and in the
Jeremy Allison [Wed, 20 Oct 2010 23:31:18 +0000 (16:31 -0700)]
Add code to implement SeSecurityPrivilege in net rpc rights, and in the
open and get/set NT security descriptor code.


Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 21 00:15:57 UTC 2010 on sn-devel-104

9 years agopytalloc: use talloc_unlink() to free py_talloc objects
Kamen Mazdrashki [Fri, 8 Oct 2010 01:21:07 +0000 (04:21 +0300)]
pytalloc: use talloc_unlink() to free py_talloc objects

Those type of objects are referenced every time we assign
them to other py_talloc objects, which leads to runtime
warnings that we are trying to free an object with references

Wrap talloc_unlink() in SMB_ASSERT() to ensure we catch possible failure

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Oct 20 21:37:06 UTC 2010 on sn-devel-104

9 years agotalloc: make header C++ safe
Simo Sorce [Wed, 20 Oct 2010 17:09:57 +0000 (13:09 -0400)]
talloc: make header C++ safe

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Oct 20 18:15:09 UTC 2010 on sn-devel-104

9 years agosmbtorture: Fix typo in status message.
James Peach [Wed, 20 Oct 2010 17:07:33 +0000 (10:07 -0700)]
smbtorture: Fix typo in status message.

9 years agos3: Make "unpack_pjob" static
Volker Lendecke [Mon, 18 Oct 2010 07:48:30 +0000 (09:48 +0200)]
s3: Make "unpack_pjob" static

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct 20 16:51:04 UTC 2010 on sn-devel-104

9 years agos3: Use any_nt_status_not_ok in winbind
Volker Lendecke [Mon, 18 Oct 2010 08:10:43 +0000 (10:10 +0200)]
s3: Use any_nt_status_not_ok in winbind

9 years agos3: Add any_nt_status_not_ok
Volker Lendecke [Mon, 18 Oct 2010 08:09:57 +0000 (10:09 +0200)]
s3: Add any_nt_status_not_ok

This helps avoid quite a bit of repetitive code when looking at dcerpc_xx_recv

9 years agos3: Don't use talloc_autofree_context in map_file
Volker Lendecke [Sat, 9 Oct 2010 08:12:06 +0000 (10:12 +0200)]
s3: Don't use talloc_autofree_context in map_file

9 years agouid_wrapper: The gid wrapper does not require a destructor
Volker Lendecke [Sat, 9 Oct 2010 07:44:43 +0000 (09:44 +0200)]
uid_wrapper: The gid wrapper does not require a destructor

Don't use talloc_autofree_context

9 years agoMake getpwnam_alloc() static to lib/username.c, and ensure all username lookups go
Jeremy Allison [Wed, 20 Oct 2010 15:16:23 +0000 (08:16 -0700)]
Make getpwnam_alloc() static to lib/username.c, and ensure all username lookups go
through Get_Pwnam_alloc(), which is the correct wrapper function. We were using
it *some* of the time anyway, so this just makes us properly consistent.


Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 20 16:02:12 UTC 2010 on sn-devel-104

9 years agonsstest: no need for two copies of the same tool.
Günther Deschner [Wed, 20 Oct 2010 12:52:30 +0000 (14:52 +0200)]
nsstest: no need for two copies of the same tool.


Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 20 15:05:34 UTC 2010 on sn-devel-104

9 years agos3-waf: more registry cleanup.
Günther Deschner [Wed, 20 Oct 2010 00:17:41 +0000 (02:17 +0200)]
s3-waf: more registry cleanup.


9 years agos3-waf: convert LIBSMBCONF into a subsystem.
Günther Deschner [Tue, 19 Oct 2010 23:54:12 +0000 (01:54 +0200)]
s3-waf: convert LIBSMBCONF into a subsystem.


9 years agos3-waf: move RPC_CLIENT_SCHANNEL into a subsystem.
Günther Deschner [Fri, 8 Oct 2010 11:17:21 +0000 (13:17 +0200)]
s3-waf: move RPC_CLIENT_SCHANNEL into a subsystem.


9 years agos4-schema_init: Print more info about syntax we fail to recognize
Kamen Mazdrashki [Wed, 20 Oct 2010 10:43:00 +0000 (13:43 +0300)]
s4-schema_init: Print more info about syntax we fail to recognize

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Oct 20 13:54:01 UTC 2010 on sn-devel-104

9 years agoasn1_tests.c: Make test data static const
Kamen Mazdrashki [Mon, 18 Oct 2010 00:50:20 +0000 (03:50 +0300)]
asn1_tests.c: Make test data static const

9 years agolib/util/asn1.c: comment spelling
Kamen Mazdrashki [Mon, 18 Oct 2010 00:49:21 +0000 (03:49 +0300)]
lib/util/asn1.c: comment spelling

9 years agoldb:ldb_index.c - fix some memory leaks
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 12:27:04 +0000 (14:27 +0200)]
ldb:ldb_index.c - fix some memory leaks

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Oct 20 13:11:49 UTC 2010 on sn-devel-104

9 years agoldb:ldb_index.c - let "ldb_module_oom" generate the return code
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 12:26:37 +0000 (14:26 +0200)]
ldb:ldb_index.c - let "ldb_module_oom" generate the return code

9 years agoldb:ldb_cache.c - fix memory contexts and memory leaks
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 12:08:53 +0000 (14:08 +0200)]
ldb:ldb_cache.c - fix memory contexts and memory leaks

9 years agoldb:ldb_tdb submodule - use "ldb_msg_new" where appropriate
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 11:53:14 +0000 (13:53 +0200)]
ldb:ldb_tdb submodule - use "ldb_msg_new" where appropriate

It is saver than a manual "talloc".

9 years agoldb:ldb_pack.c - remove superflous "message->elements = NULL"
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 11:47:48 +0000 (13:47 +0200)]
ldb:ldb_pack.c - remove superflous "message->elements = NULL"

It's already marked at this at the beginning of the call.

9 years agolibcli/security/access_check.c - fix a memory leak
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 11:40:19 +0000 (13:40 +0200)]
libcli/security/access_check.c - fix a memory leak

9 years agos3: Add some DEBUG
Volker Lendecke [Tue, 19 Oct 2010 06:59:14 +0000 (08:59 +0200)]
s3: Add some DEBUG

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct 20 11:58:20 UTC 2010 on sn-devel-104

9 years agos3: Cope with EINTR in smbd_[un]lock_socket
Volker Lendecke [Tue, 19 Oct 2010 06:53:21 +0000 (08:53 +0200)]
s3: Cope with EINTR in smbd_[un]lock_socket

9 years agolibcli/ldap Don't try and encode a control with a NULL OID
Andrew Bartlett [Wed, 20 Oct 2010 03:27:57 +0000 (14:27 +1100)]
libcli/ldap Don't try and encode a control with a NULL OID

ctrl->oid is set to NULL by the Samba4 rootDSE module when removing
controls that should not be exposed over LDAP (to avoid a realloc).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Oct 20 04:13:44 UTC 2010 on sn-devel-104

9 years agoautobuild: create an autobuild.pid file
Andrew Tridgell [Tue, 19 Oct 2010 22:44:03 +0000 (09:44 +1100)]
autobuild: create an autobuild.pid file

this will allow us to avoid an error email when you resubmit and there
is an existing autobuild.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 19 23:36:05 UTC 2010 on sn-devel-104

9 years agos4-mailslot: fixed handling of random collision in temporary mailslot names
Andrew Tridgell [Tue, 19 Oct 2010 22:14:40 +0000 (09:14 +1100)]
s4-mailslot: fixed handling of random collision in temporary mailslot names

we could get occasional failures in the samba4.nbt.dgram test if we
happened to get a collision in the random mailslot names.

Thanks to Jeremy for spotting this! (his autobuild failed)

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoFix shadow warning for "access" variable.
Jeremy Allison [Tue, 19 Oct 2010 20:32:53 +0000 (13:32 -0700)]
Fix shadow warning for "access" variable.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Oct 19 22:53:38 UTC 2010 on sn-devel-104

9 years agoAdd deadtime detection for SMB2. Correctly update lastused timestamp across all activ...
Jeremy Allison [Tue, 19 Oct 2010 18:11:56 +0000 (11:11 -0700)]
Add deadtime detection for SMB2. Correctly update lastused timestamp across all active tcons. Should fix dfree cache not updating bug.

9 years agoAdd SMB2 paths to smbd/conn.c. Except for conn_idle_all(), to be cleaned up next.
Jeremy Allison [Tue, 19 Oct 2010 17:12:42 +0000 (10:12 -0700)]
Add SMB2 paths to smbd/conn.c. Except for conn_idle_all(), to be cleaned up next.

9 years agoCopyright/whitespace/comment cleanup in preparation for adding SMB2 paths.
Jeremy Allison [Tue, 19 Oct 2010 17:04:27 +0000 (10:04 -0700)]
Copyright/whitespace/comment cleanup in preparation for adding SMB2 paths.

9 years agoMove tcons.num_open from smb1 to sconn->num_tcons_open as this is needed for SMB2...
Jeremy Allison [Tue, 19 Oct 2010 20:25:51 +0000 (13:25 -0700)]
Move tcons.num_open from smb1 to sconn->num_tcons_open as this is needed for SMB2 also.

9 years agos3-waf Use LIBSECRUITY subsystem from the common wscript_build
Andrew Bartlett [Tue, 19 Oct 2010 20:52:14 +0000 (07:52 +1100)]
s3-waf Use LIBSECRUITY subsystem from the common wscript_build

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 19 22:06:51 UTC 2010 on sn-devel-104

9 years agos3-waf: all subsystems complete now, no need for this loop anymore.
Günther Deschner [Tue, 19 Oct 2010 14:07:45 +0000 (16:07 +0200)]
s3-waf: all subsystems complete now, no need for this loop anymore.

Kai, please check.


Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct 19 17:10:24 UTC 2010 on sn-devel-104

9 years agos3-waf: convert rpc into a subsystem.
Günther Deschner [Tue, 28 Sep 2010 16:55:55 +0000 (18:55 +0200)]
s3-waf: convert rpc into a subsystem.


9 years agos4:nbt_server - fix a LDB counter type
Matthias Dieter Wallnöfer [Tue, 19 Oct 2010 13:05:01 +0000 (15:05 +0200)]
s4:nbt_server - fix a LDB counter type

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Oct 19 14:05:13 UTC 2010 on sn-devel-104

9 years agos4-dsdb Reset the error string after 'expected' errors.
Andrew Bartlett [Tue, 19 Oct 2010 11:30:26 +0000 (22:30 +1100)]
s4-dsdb Reset the error string after 'expected' errors.

This helps ensure that we don't get confusing error strings in the
logs on other error cases.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 19 12:16:07 UTC 2010 on sn-devel-104

9 years agos4-dsdb Add module to send only 'simple' DNs to OpenLDAP backends
Andrew Bartlett [Tue, 19 Oct 2010 11:29:04 +0000 (22:29 +1100)]
s4-dsdb Add module to send only 'simple' DNs to OpenLDAP backends

If we send the full extended DN, then we risk standards-complient LDAP
servers rejecting it as invalid.  Only the DN portion is needed to
resolve the record in any case, and any SID or GUID componenets have
already been evaluated into the DN.

Andrew Bartlett

9 years agos4-dsdb Allow LDB_ERR_INVALID_DN_SYNTAX in dsdb_load_partition_usn
Andrew Bartlett [Tue, 19 Oct 2010 11:27:54 +0000 (22:27 +1100)]
s4-dsdb Allow LDB_ERR_INVALID_DN_SYNTAX in dsdb_load_partition_usn

This will happen on an OpenLDAP backend, because @ records are invalid in LDAP.

We don't have these sequence numbers in this case.

Andrew Bartlett

9 years agos4-auth Add DEBUG() for invalid DNs and errors expanding user groups.
Andrew Bartlett [Tue, 19 Oct 2010 09:20:43 +0000 (20:20 +1100)]
s4-auth Add DEBUG() for invalid DNs and errors expanding user groups.

Against the OpenLDAP backend, I currently get failures.  This makes it
possible to debug those failures.

Andrew Bartlett

9 years agoldb:"ldb_schema_attribute_by_name_internal" - support the whole unsigned int range
Matthias Dieter Wallnöfer [Tue, 19 Oct 2010 09:30:24 +0000 (11:30 +0200)]
ldb:"ldb_schema_attribute_by_name_internal" - support the whole unsigned int range

Commit 8556602b048e825b35df314d6865f997823ec2bb wasn't quite right - it only
restored the functionality on the positive integer range.

This one however should now really support the whole unsigned range.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Oct 19 10:52:08 UTC 2010 on sn-devel-104

9 years agos4:dsdb/schema/schema_init.c - remove a duplicated "talloc_free"
Matthias Dieter Wallnöfer [Tue, 19 Oct 2010 09:46:34 +0000 (11:46 +0200)]
s4:dsdb/schema/schema_init.c - remove a duplicated "talloc_free"

9 years agos4:samdb.py - remove a pointless comment
Matthias Dieter Wallnöfer [Tue, 19 Oct 2010 08:57:12 +0000 (10:57 +0200)]
s4:samdb.py - remove a pointless comment

We are only looking for the default DN - but the method name already tells
us this.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Oct 19 10:03:12 UTC 2010 on sn-devel-104

9 years agos4:samdb.py - use a more standard way to get to the domain realm/dns name
Matthias Dieter Wallnöfer [Tue, 19 Oct 2010 08:56:07 +0000 (10:56 +0200)]
s4:samdb.py - use a more standard way to get to the domain realm/dns name

We do always use the canonical name as a base if we don't have it around yet.

9 years agoAddition of userPrincipalName attribute when new account is created
Lukasz Zalewski [Sat, 16 Oct 2010 18:51:09 +0000 (19:51 +0100)]
Addition of userPrincipalName attribute when new account is created

9 years agos4-gensec Don't give more to sasl_encode() than it will permit
Andrew Bartlett [Tue, 19 Oct 2010 06:12:35 +0000 (17:12 +1100)]
s4-gensec Don't give more to sasl_encode() than it will permit

We need to ask the library how much data to pass in at any time.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Oct 19 08:37:45 UTC 2010 on sn-devel-104

9 years agos4-gensec Don't upgrade all DIGEST-MD5 connections to seal
Andrew Bartlett [Tue, 19 Oct 2010 04:12:20 +0000 (15:12 +1100)]
s4-gensec Don't upgrade all DIGEST-MD5 connections to seal

The issue here is that when props.max_ssf = UINT_MAX was always set,
as was the maxbufsize, and the connection would always be upgraded,
regardless of the callers wishes.

Andrew Bartlett

9 years agos4-provisionbackend Allow a fixed URI to be specified for LDAP backend
Andrew Bartlett [Mon, 18 Oct 2010 23:38:10 +0000 (10:38 +1100)]
s4-provisionbackend Allow a fixed URI to be specified for LDAP backend

This is added to make the 'existing' LDAP backend class more useful,
and to allow debuging of our OpenLDAP backend class with wireshark, by
forcing the traffic over loopback TCP, which is much easier to sniff.

Andrew Bartlett

9 years agos4-provision Remove serverdn parameter from Schema()
Andrew Bartlett [Mon, 18 Oct 2010 22:12:57 +0000 (09:12 +1100)]
s4-provision Remove serverdn parameter from Schema()

We don't need to know the server DN here any more, and it
makes no sense for many callers.

Andrew Bartlett

9 years agos4-dsdb: register the DCPROMO_OID control with the rootdse
Andrew Tridgell [Tue, 19 Oct 2010 03:53:14 +0000 (14:53 +1100)]
s4-dsdb: register the DCPROMO_OID control with the rootdse

this is needed to allow it over ldap

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 19 04:44:23 UTC 2010 on sn-devel-104

9 years agoselftest: terminate selftest if we can't setup the environment
Andrew Tridgell [Tue, 19 Oct 2010 03:49:17 +0000 (14:49 +1100)]
selftest: terminate selftest if we can't setup the environment

9 years agos4-ldb: increase minor version for 2 new functions
Andrew Tridgell [Tue, 19 Oct 2010 00:47:22 +0000 (11:47 +1100)]
s4-ldb: increase minor version for 2 new functions

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Oct 19 01:27:44 UTC 2010 on sn-devel-104

9 years agos4-ldap: mark all ldap:// requests as untrusted
Andrew Tridgell [Tue, 19 Oct 2010 00:22:12 +0000 (11:22 +1100)]
s4-ldap: mark all ldap:// requests as untrusted

this allows the rootdse module to filter unregistered controls

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-dsdb: filter unregistered controls in the rootdse module
Andrew Tridgell [Tue, 19 Oct 2010 00:21:45 +0000 (11:21 +1100)]
s4-dsdb: filter unregistered controls in the rootdse module

if we get an unregistered control in the rootdse module, and the
request comes from an untrusted source (eg. ldap://) then we need to:

 1) filter the control out if it is marked non-critical

 2) give an error if it is marked critical

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-ldb: cope with NULL oid in controls
Andrew Tridgell [Tue, 19 Oct 2010 00:20:14 +0000 (11:20 +1100)]
s4-ldb: cope with NULL oid in controls

the ldap server will mark a control with a NULL oid in order to remove
it. This prevents a O(n^2) cost in control handling.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-ldb: added --relax cmdline option
Andrew Tridgell [Tue, 19 Oct 2010 00:19:20 +0000 (11:19 +1100)]
s4-ldb: added --relax cmdline option

this adds the relax control

9 years agos4-ldb: added ldb_req_mark_untrusted() and ldb_req_is_untrusted()
Andrew Tridgell [Tue, 19 Oct 2010 00:17:53 +0000 (11:17 +1100)]
s4-ldb: added ldb_req_mark_untrusted() and ldb_req_is_untrusted()

these will be used to determine if a ldb request comes from an
untrusted source. We want requests over ldap:// to be marked untrusted
so we can reject unregistered controls

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agowaf: put -Wl,-no-undefined only in the linker flags, not when compiling C
Andrew Tridgell [Mon, 18 Oct 2010 04:17:56 +0000 (15:17 +1100)]
waf: put -Wl,-no-undefined only in the linker flags, not when compiling C

9 years agowaf: don't save deps on install
Andrew Tridgell [Sun, 17 Oct 2010 11:34:17 +0000 (22:34 +1100)]
waf: don't save deps on install

this prevents an install triggering a new check of the project rules
on the next build

9 years agowaf: automap shared library names from .so to the right extension
Andrew Tridgell [Sun, 17 Oct 2010 10:58:22 +0000 (21:58 +1100)]
waf: automap shared library names from .so to the right extension

this should help with MacOSX .dylib libraries

9 years agoreadline: fixed the test for history_list()
Andrew Tridgell [Sat, 16 Oct 2010 08:54:05 +0000 (19:54 +1100)]
readline: fixed the test for history_list()

9 years agoreplace: cope with systems that have fdatasync(), but don't have the prototype
Andrew Tridgell [Sat, 16 Oct 2010 08:53:17 +0000 (19:53 +1100)]
replace: cope with systems that have fdatasync(), but don't have the prototype

this is needed for MacOSX 10.4.1

9 years agos4:ldap_server - use error code constant
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 19:22:37 +0000 (21:22 +0200)]
s4:ldap_server - use error code constant

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Oct 18 20:32:40 UTC 2010 on sn-devel-104

9 years agoldb: always return PROTOCOL_ERROR if an operation is unsupported
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 19:21:45 +0000 (21:21 +0200)]
ldb: always return PROTOCOL_ERROR if an operation is unsupported

That's exactly the behaviour of various LDAP servers.

9 years agoselftest: use full path for selftest.pl instead of relative paths
Matthieu Patou [Mon, 18 Oct 2010 18:23:00 +0000 (22:23 +0400)]
selftest: use full path for selftest.pl instead of relative paths

FindBin on solaris8 with perl 5.04 has problem to get the path of the
called script if the script is called with a relative path.

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Mon Oct 18 19:50:03 UTC 2010 on sn-devel-104

9 years agoselftest: correct the import of Time::HighRes
Matthieu Patou [Mon, 18 Oct 2010 16:21:12 +0000 (20:21 +0400)]
selftest: correct the import of Time::HighRes

The "use" is always evaluated first even if enclosed into a if. So
on plateform without Time::Hires (ie. sun8 in the build farm). This
leads to an error.

Instead we use the synthax require Module + Module->import("function")

9 years agoldb:"ldb_schema_attribute_by_name_internal" - switch back to 32bit counters
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:19:00 +0000 (20:19 +0200)]
ldb:"ldb_schema_attribute_by_name_internal" - switch back to 32bit counters

Use the signed counter for the binary search but use an unsigned one for
accessing the entry.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Oct 18 19:01:31 UTC 2010 on sn-devel-104

9 years agoldb:ldb_tdb.c - fix up counter variables
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:10:17 +0000 (20:10 +0200)]
ldb:ldb_tdb.c - fix up counter variables

"find_element" returns an "int" since there is also the possibility that a
certain element doesn't exist - then "-1" is returned. But beside this
exception treat all other return values as unsigned.

9 years agoldb:ldb_tdb.c - improve the error outputs
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 18:07:49 +0000 (20:07 +0200)]
ldb:ldb_tdb.c - improve the error outputs

- Fix indentation
- Include always the failing DN
- Reorder the outputs to make them consistent

9 years agos4:"util_ldb" - remove some really unused dependancies
Matthias Dieter Wallnöfer [Mon, 18 Oct 2010 17:24:43 +0000 (19:24 +0200)]
s4:"util_ldb" - remove some really unused dependancies

9 years agolibcli/nbt: we don't need LIBCLI_COMPOSITE anymore
Stefan Metzmacher [Mon, 11 Oct 2010 20:29:30 +0000 (22:29 +0200)]
libcli/nbt: we don't need LIBCLI_COMPOSITE anymore


Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct 18 16:18:32 UTC 2010 on sn-devel-104

9 years agolibcli/nbt: convert nbt_name_register_bcast_send/recv to tevent_req
Stefan Metzmacher [Mon, 11 Oct 2010 19:18:15 +0000 (21:18 +0200)]
libcli/nbt: convert nbt_name_register_bcast_send/recv to tevent_req