kai/samba.git
10 years agos3-spoolss: Fix GetPrinter level 101.
Günther Deschner [Mon, 23 Nov 2009 15:54:34 +0000 (16:54 +0100)]
s3-spoolss: Fix GetPrinter level 101.

Guenther

10 years agoRevert "s3: Make the implicit reference to Protocol in mask_match() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:34:07 +0000 (16:34 +0100)]
Revert "s3: Make the implicit reference to Protocol in mask_match() explicit"

This reverts commit e23d8a3d1f558a7e98ef2afd71e1d15c5b3a71bc.

10 years agoRevert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:34:00 +0000 (16:34 +0100)]
Revert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"

This reverts commit 1e22899d268ae5a089f941a204413c07ee64fc78.

10 years agoRevert "s3: Make the implicit reference to Protocol in is_in_path() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:33:53 +0000 (16:33 +0100)]
Revert "s3: Make the implicit reference to Protocol in is_in_path() explicit"

This reverts commit f7b4151a64d8c6851e62255a7139fd00a5fc63a3.

10 years agoRevert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:33:45 +0000 (16:33 +0100)]
Revert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"

This reverts commit 6a149022976fe6a5579ec9afc7a4d2dcb44dc8af.

10 years agoRevert "s3: Move the global variable Protocol to struct smbd_server_connection"
Volker Lendecke [Mon, 23 Nov 2009 15:33:26 +0000 (16:33 +0100)]
Revert "s3: Move the global variable Protocol to struct smbd_server_connection"

This reverts commit c85a4c9ba4a7de65a7850f6f9708df66bd24deea.

10 years agos4:ldap.py - Add a check for the generated "schemaIDGUID"
Matthias Dieter Wallnöfer [Mon, 23 Nov 2009 15:20:07 +0000 (16:20 +0100)]
s4:ldap.py - Add a check for the generated "schemaIDGUID"

I've forgotten to add this when checking in the reworked SAMLDB module

10 years agos3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever
Volker Lendecke [Mon, 23 Nov 2009 12:58:23 +0000 (13:58 +0100)]
s3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever

10 years agos3: Move a variable declaration to its only use
Volker Lendecke [Mon, 23 Nov 2009 10:54:19 +0000 (11:54 +0100)]
s3: Move a variable declaration to its only use

10 years agos4:dsdb Move module configuration from each ldb into samba_dsdb.c
Andrew Bartlett [Mon, 23 Nov 2009 09:30:35 +0000 (20:30 +1100)]
s4:dsdb Move module configuration from each ldb into samba_dsdb.c

This makes getting the module order correct, the obligation of Samba4
developers, and not system administrators.  In particular, once an ldb
is updated to use only the 'samba_dsdb' module, no further changes to the
ldb should be required when upgrading to later Samba4 versions.

(thanks to metze for the suggestion of samba_dsdb as a long-term
stable name for the module)

Andrew Bartlett

10 years agos4:provision Simplify the module list
Andrew Bartlett [Fri, 20 Nov 2009 01:16:33 +0000 (12:16 +1100)]
s4:provision Simplify the module list

This makes the member server much more like the DC, the objectGUID
module replaces the repl_meta_data module.

We also generally rework the construction of the list, building a full
list in python, and then transforming it into a string, rather than
playing string concatonation games

Andrew Bartlett

10 years agos4/schema(tort): Refactor DSDB-SYNTAX test for better performance
Kamen Mazdrashki [Sun, 22 Nov 2009 20:21:12 +0000 (22:21 +0200)]
s4/schema(tort): Refactor DSDB-SYNTAX test for better performance

Test was implemented as a test fixture so that setup/teardown
occurs only once.
This should impact test performace as long as provision_get_schema()
is a slow function (especially when debugging)

10 years agos4/schema: Handle Object(OR-Name) syntax in extended_dn_out module
Kamen Mazdrashki [Sun, 22 Nov 2009 15:48:32 +0000 (17:48 +0200)]
s4/schema: Handle Object(OR-Name) syntax in extended_dn_out module

Windows displays attribute values with Object(OR-Name) syntax
in plain DN format when queried through LDAP.
Hence, we need to post-process such values specially
in extended_dn_out.c module so they are always shown as plain DN,
no matter what controls are passed for search request.

10 years agos4/schema: Object(OR-Name) syntax handling for DRS calls
Kamen Mazdrashki [Sun, 22 Nov 2009 12:41:25 +0000 (14:41 +0200)]
s4/schema: Object(OR-Name) syntax handling for DRS calls

OR-Name syntax through DRS calls looks like DN-Binary syntax

10 years agos4/schema(tort): Inject authOrig attribute into schema loaded for tests
Kamen Mazdrashki [Fri, 20 Nov 2009 01:07:41 +0000 (03:07 +0200)]
s4/schema(tort): Inject authOrig attribute into schema loaded for tests

10 years agos4/schema(tort): Add test for Object(OR-Name) syntax
Kamen Mazdrashki [Sun, 22 Nov 2009 12:46:09 +0000 (14:46 +0200)]
s4/schema(tort): Add test for Object(OR-Name) syntax

10 years agos4/schema(tort): Test LDB_SYNTAX_DN with extended_dn in [GUID;SID;DN] form
Kamen Mazdrashki [Fri, 20 Nov 2009 01:15:38 +0000 (03:15 +0200)]
s4/schema(tort): Test LDB_SYNTAX_DN with extended_dn in [GUID;SID;DN] form

10 years agos4/drs(tort): DSSYNC test to print what is different in drs_msg also
Kamen Mazdrashki [Mon, 16 Nov 2009 21:49:51 +0000 (23:49 +0200)]
s4/drs(tort): DSSYNC test to print what is different in drs_msg also

10 years agos4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.
Günther Deschner [Mon, 23 Nov 2009 12:35:32 +0000 (13:35 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.

Guenther

10 years agos3-printing: remove duplicate code while cleaning up driver structs.
Günther Deschner [Mon, 23 Nov 2009 11:57:46 +0000 (12:57 +0100)]
s3-printing: remove duplicate code while cleaning up driver structs.

Guenther

10 years agos3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.
Günther Deschner [Wed, 18 Nov 2009 14:39:52 +0000 (15:39 +0100)]
s3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.

Guenther

10 years agos3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.
Günther Deschner [Tue, 17 Nov 2009 11:55:45 +0000 (12:55 +0100)]
s3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.

Guenther

10 years agos3-printing: use spoolss types and structs while getting and deleting drivers.
Günther Deschner [Tue, 17 Nov 2009 11:54:02 +0000 (12:54 +0100)]
s3-printing: use spoolss types and structs while getting and deleting drivers.

Guenther

10 years agos3-printing: use spoolss types and structs while adding drivers.
Günther Deschner [Mon, 16 Nov 2009 14:52:31 +0000 (15:52 +0100)]
s3-printing: use spoolss types and structs while adding drivers.

Guenther

10 years agos4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.
Günther Deschner [Fri, 20 Nov 2009 15:33:29 +0000 (16:33 +0100)]
s4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.

Guenther

10 years agos3-spoolss: fix spoolss_EnumPrinterKey client and server code.
Günther Deschner [Fri, 20 Nov 2009 15:34:00 +0000 (16:34 +0100)]
s3-spoolss: fix spoolss_EnumPrinterKey client and server code.

Guenther

10 years agospoolss: fix spoolss_EnumPrinterKey IDL.
Günther Deschner [Fri, 20 Nov 2009 11:57:13 +0000 (12:57 +0100)]
spoolss: fix spoolss_EnumPrinterKey IDL.

Guenther

10 years agos3: Fix bug 6338 -- net rpc trustdom list always display "none"
Volker Lendecke [Sun, 22 Nov 2009 21:38:45 +0000 (22:38 +0100)]
s3: Fix bug 6338 -- net rpc trustdom list always display "none"

10 years agos4:netlogon RPC - Remove trailing whitespace
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 14:54:16 +0000 (15:54 +0100)]
s4:netlogon RPC - Remove trailing whitespace

10 years agos4:netlogon RPC - Fix up the error handling
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 14:51:18 +0000 (15:51 +0100)]
s4:netlogon RPC - Fix up the error handling

10 years agos4:netlogon RPC - Fix up a comment
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 14:50:36 +0000 (15:50 +0100)]
s4:netlogon RPC - Fix up a comment

Now we have Windows 7 released so don't refer to a beta anymore.

10 years agoFixed incorrect indentation.
Nadezhda Ivanova [Sun, 22 Nov 2009 11:36:35 +0000 (13:36 +0200)]
Fixed incorrect indentation.

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 21 Nov 2009 21:52:12 +0000 (22:52 +0100)]
s3: Fix some nonempty blank lines

10 years agos3: Remove a struct typedef
Volker Lendecke [Sat, 21 Nov 2009 20:36:01 +0000 (21:36 +0100)]
s3: Remove a struct typedef

10 years agos3: Make alloc_sub_basic() static
Volker Lendecke [Sat, 21 Nov 2009 19:23:35 +0000 (20:23 +0100)]
s3: Make alloc_sub_basic() static

10 years agos3: Move the global variable Protocol to struct smbd_server_connection
Volker Lendecke [Sat, 21 Nov 2009 18:57:41 +0000 (19:57 +0100)]
s3: Move the global variable Protocol to struct smbd_server_connection

10 years agos3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:37:27 +0000 (19:37 +0100)]
s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit

10 years agos3: Make the implicit reference to Protocol in is_in_path() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:26:25 +0000 (19:26 +0100)]
s3: Make the implicit reference to Protocol in is_in_path() explicit

10 years agos3: Make the implicit reference to Protocol in mask_match_list() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:04:34 +0000 (19:04 +0100)]
s3: Make the implicit reference to Protocol in mask_match_list() explicit

10 years agos3: Make the implicit reference to Protocol in mask_match() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:04:34 +0000 (19:04 +0100)]
s3: Make the implicit reference to Protocol in mask_match() explicit

10 years agomount.cifs: Fix a const error
Volker Lendecke [Sat, 21 Nov 2009 18:03:45 +0000 (19:03 +0100)]
mount.cifs: Fix a const error

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 21 Nov 2009 15:17:16 +0000 (16:17 +0100)]
s3: Fix some nonempty blank lines

10 years agos3: Avoid two calls to strcmp()
Volker Lendecke [Sat, 21 Nov 2009 15:15:16 +0000 (16:15 +0100)]
s3: Avoid two calls to strcmp()

10 years agos3: Fix a bool/enum mismatch
Volker Lendecke [Sat, 21 Nov 2009 15:10:52 +0000 (16:10 +0100)]
s3: Fix a bool/enum mismatch

10 years agos4:lsa RPC - Fix type of variable "atype"
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:49:56 +0000 (19:49 +0100)]
s4:lsa RPC - Fix type of variable "atype"

This is an unsigned 32bit integer.

10 years agos4:samr RPC - Use more LDB constants
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:25:42 +0000 (19:25 +0100)]
s4:samr RPC - Use more LDB constants

10 years agos4:lsa RPC - Use more LDB constants
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:46:25 +0000 (19:46 +0100)]
s4:lsa RPC - Use more LDB constants

And fix an obvious bug (call of "samdb_msg_add_delete")

10 years agoImplemented LDAP_SERVER_SD_FLAGS_OID on search requests.
Nadezhda Ivanova [Sat, 21 Nov 2009 16:40:51 +0000 (18:40 +0200)]
Implemented LDAP_SERVER_SD_FLAGS_OID on search requests.

10 years agos4:torture/smb2/oplock - Remove unneeded "status" redeclarations
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:33:04 +0000 (17:33 +0100)]
s4:torture/smb2/oplock - Remove unneeded "status" redeclarations

10 years agos4:torture/smb2/notify - Rename nested "fname" variable to prevent warnings
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:32:07 +0000 (17:32 +0100)]
s4:torture/smb2/notify - Rename nested "fname" variable to prevent warnings

10 years agos4:torture/raw/unlink - Remove unused variable and label
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:23:31 +0000 (17:23 +0100)]
s4:torture/raw/unlink - Remove unused variable and label

10 years agos4:torture/rpc/netlogon - Fix uninitialised variable
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:22:07 +0000 (17:22 +0100)]
s4:torture/rpc/netlogon - Fix uninitialised variable

10 years agos3: Convert cli_get_fs_attr_info to the async API
Volker Lendecke [Sat, 21 Nov 2009 12:46:52 +0000 (13:46 +0100)]
s3: Convert cli_get_fs_attr_info to the async API

10 years agos3: Tune if-conditions in a very hot codepath
Volker Lendecke [Sun, 15 Nov 2009 21:22:38 +0000 (22:22 +0100)]
s3: Tune if-conditions in a very hot codepath

This looks innocent, but it is visible in a netbench run.  Due to boolean
short-circuiting we don't have to execute the conditions on the right-hand side
of the &&. So putting the less likely condition left gains a bit.

10 years agos3: Remove a pointless memset
Volker Lendecke [Mon, 16 Nov 2009 07:54:55 +0000 (08:54 +0100)]
s3: Remove a pointless memset

We are assigning the complete structure now (we used to assign individual
fields), so this is obsolete.

10 years agos3: Cache brlock.tdb entries for the fast read&write strict locking code path
Volker Lendecke [Mon, 16 Nov 2009 08:40:47 +0000 (09:40 +0100)]
s3: Cache brlock.tdb entries for the fast read&write strict locking code path

For a netbench run this gains around 2% user-space CPU, fetching a 100MB file
takes around 4% less.

10 years agos4:WINREG RPC server - Cosmetic
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 07:53:22 +0000 (08:53 +0100)]
s4:WINREG RPC server - Cosmetic

10 years agontlm_auth: use data_blob_talloc() to allocate session key
Kai Blin [Wed, 18 Nov 2009 10:26:57 +0000 (11:26 +0100)]
ntlm_auth: use data_blob_talloc() to allocate session key

Thanks to Shibu Piriyath <shibunair80@ymail.com> for spotting the issue.

10 years agoFix logic bug where high bits tests was being
Jeremy Allison [Sat, 21 Nov 2009 01:23:20 +0000 (17:23 -0800)]
Fix logic bug where high bits tests was being
done on both Windows and POSIX mkdirs instead of
only on Windows mkdir (as intended). The variable
"file_attributes" had already had FILE_FLAG_POSIX_SEMANTICS
removed above in the function if it had already been set.
Jeremy.

10 years agos3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)
Michael Adam [Fri, 20 Nov 2009 23:14:29 +0000 (00:14 +0100)]
s3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)

Michael

10 years agos3:fix endianness bug in dbwrap_change_uint32_atomic() (bug #6901)
Michael Adam [Fri, 20 Nov 2009 23:08:38 +0000 (00:08 +0100)]
s3:fix endianness bug in dbwrap_change_uint32_atomic() (bug #6901)

Michael

10 years agocharset/tests/iconv - Remove the "const" from "ptr_in" to prevent "discard_const_p...
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 17:03:57 +0000 (19:03 +0200)]
charset/tests/iconv - Remove the "const" from "ptr_in" to prevent "discard_const_p" use

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb tools: Mostly cosmetic adaptions
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 17:02:02 +0000 (19:02 +0200)]
tdb tools: Mostly cosmetic adaptions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agoutil/strlist: Fix up "const" warnings in the string list and test code
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 17:06:29 +0000 (19:06 +0200)]
util/strlist: Fix up "const" warnings in the string list and test code

This work I did using suggestions by Jelmer.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agos3-build: delete more object files for "make clean".
Günther Deschner [Fri, 20 Nov 2009 11:54:19 +0000 (12:54 +0100)]
s3-build: delete more object files for "make clean".

Guenther

10 years agoCosmetic patch - fixed case of attribute name.
Nadezhda Ivanova [Fri, 20 Nov 2009 12:55:31 +0000 (14:55 +0200)]
Cosmetic patch - fixed case of attribute name.

10 years agos4:min_versions: require ldb 0.9.9
Stefan Metzmacher [Fri, 20 Nov 2009 11:54:49 +0000 (12:54 +0100)]
s4:min_versions: require ldb 0.9.9

metze

10 years agos4:lib/ldb: change version to 0.9.9 after some critical index fixes
Stefan Metzmacher [Fri, 20 Nov 2009 11:53:56 +0000 (12:53 +0100)]
s4:lib/ldb: change version to 0.9.9 after some critical index fixes

metze

10 years agolibrpc: rerun "make idl"
Stefan Metzmacher [Fri, 20 Nov 2009 11:37:03 +0000 (12:37 +0100)]
librpc: rerun "make idl"

metze

10 years agoRevert "Work around ndr_unpack failing on structures with relative pointers."
Stefan Metzmacher [Fri, 20 Nov 2009 11:19:35 +0000 (12:19 +0100)]
Revert "Work around ndr_unpack failing on structures with relative pointers."

This reverts commit c2cdb4ad5c9398ef0d3310613107999f8d33c7ce.

It's not needed anymore.

metze

10 years agopidl:NDR/Parser.pm: update ndr_pull->relative_highest_offset after handling relative...
Stefan Metzmacher [Fri, 20 Nov 2009 11:11:41 +0000 (12:11 +0100)]
pidl:NDR/Parser.pm: update ndr_pull->relative_highest_offset after handling relative pointers

metze

10 years agolibrpc/ndr: remember the highest offset we parsed with relative pointer buffers
Stefan Metzmacher [Fri, 20 Nov 2009 10:34:53 +0000 (11:34 +0100)]
librpc/ndr: remember the highest offset we parsed with relative pointer buffers

ndr_*_pull_blob_all() will now work if relative pointers are used.

metze

10 years agos3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init
Michael Adam [Fri, 20 Nov 2009 11:44:43 +0000 (12:44 +0100)]
s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init

When idmap backend is specified as
idmap backend = ldap:"ldap://server1 ldap://server2"
then currently "ldap://server1 ldap://server2" was passed to
ldap_initialize including the quotes, leading to an ldap error.

Michael

10 years agos3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init
Michael Adam [Fri, 20 Nov 2009 11:38:44 +0000 (12:38 +0100)]
s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init

When idmap alloc backend is specified as
idmap alloc backend = ldap:"ldap://server1 ldap://server2"
then currently "ldap://server1 ldap://server2" was passed to
ldap_initialize including the quotes, leading to an ldap error.

Michael

10 years agoImplementation of LDAP_SERVER_SD_FLAGS_OID on modify requests.
Nadezhda Ivanova [Fri, 20 Nov 2009 11:25:13 +0000 (13:25 +0200)]
Implementation of LDAP_SERVER_SD_FLAGS_OID on modify requests.

10 years agoSome changes to allow processing of ldap controls on modify requests.
Nadezhda Ivanova [Fri, 20 Nov 2009 11:22:38 +0000 (13:22 +0200)]
Some changes to allow processing of ldap controls on modify requests.

ldap_backend used to filter out ldap controls on modify. Also, modified
python binding for ldap_modify to allow writing tests for such controls.

10 years agos4:ntvfs/posix/pvfs_acl - Remove unused variable "token"
Matthias Dieter Wallnöfer [Fri, 20 Nov 2009 11:03:06 +0000 (12:03 +0100)]
s4:ntvfs/posix/pvfs_acl - Remove unused variable "token"

10 years agotdb: change version to 1.2.0 after adding TDB_*ALLOW_NESTING save-diskspace-tags/tdb-1.2.0
Stefan Metzmacher [Thu, 19 Nov 2009 08:49:03 +0000 (09:49 +0100)]
tdb: change version to 1.2.0 after adding TDB_*ALLOW_NESTING

metze

10 years agotdb: add TDB_DISALLOW_NESTING and make TDB_ALLOW_NESTING the default behavior
Stefan Metzmacher [Thu, 19 Nov 2009 08:34:05 +0000 (09:34 +0100)]
tdb: add TDB_DISALLOW_NESTING and make TDB_ALLOW_NESTING the default behavior

We need to keep TDB_ALLOW_NESTING as default behavior,
so that existing code continues to work.

However we may change the default together with a major version
number change in future.

metze

10 years agoNew attempt at TDB transaction nesting allow/disallow.
Ronnie Sahlberg [Mon, 25 May 2009 07:04:42 +0000 (17:04 +1000)]
New attempt at TDB transaction nesting allow/disallow.

Make the default be that transaction is not allowed and any attempt to create a nested transaction will fail with TDB_ERR_NESTING.

If an application can cope with transaction nesting and the implicit
semantics of tdb_transaction_commit(), it can enable transaction nesting
by using the TDB_ALLOW_NESTING flag.
(cherry picked from ctdb commit 3e49e41c21eb8c53084aa8cc7fd3557bdd8eb7b6)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
10 years agotdb: always set tdb->tracefd to -1 to be safe on goto fail
Stefan Metzmacher [Thu, 19 Nov 2009 08:38:48 +0000 (09:38 +0100)]
tdb: always set tdb->tracefd to -1 to be safe on goto fail

metze

10 years agos4-dsdb: some more attribuutes that we should only give if asked for
Andrew Tridgell [Fri, 20 Nov 2009 04:19:35 +0000 (15:19 +1100)]
s4-dsdb: some more attribuutes that we should only give if asked for

10 years agos4-drs: we need to specifically ask for ntSecurityDescriptor
Andrew Tridgell [Fri, 20 Nov 2009 03:57:04 +0000 (14:57 +1100)]
s4-drs: we need to specifically ask for ntSecurityDescriptor

ntSecurityDescriptor is no longer included by default

10 years agos4-ldb: added a warning about ldb_msg_add_dn
Andrew Tridgell [Thu, 19 Nov 2009 18:03:59 +0000 (16:03 -0200)]
s4-ldb: added a warning about ldb_msg_add_dn

ldb_msg_add_dn does not copy the dn linearized string

10 years agoadded new function "ldb_msg_add_dn"
Crístian Deives [Thu, 19 Nov 2009 18:03:59 +0000 (16:03 -0200)]
added new function "ldb_msg_add_dn"

a helper function to a DN element to an ldb_msg using ldb_msg_add_string.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-dsdb: removed attributes that should not be displayed by default
Andrew Tridgell [Fri, 20 Nov 2009 03:19:18 +0000 (14:19 +1100)]
s4-dsdb: removed attributes that should not be displayed by default

Some attributes (like ntSecurityDescriptor) are stored in our db, but
should only be displayed if asked for. This also applied to parentGUID
from old installs, which is now generated.

10 years agos4-drs: Removes stored parentGUID's creation and renaming
Fernando J V da Silva [Thu, 19 Nov 2009 18:35:38 +0000 (15:35 -0300)]
s4-drs: Removes stored parentGUID's creation and renaming

parentGUID is now created on demand in operational.c

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-drs: Synchronous Implementation of generated parentGUID
Fernando J V da Silva [Thu, 19 Nov 2009 18:37:45 +0000 (15:37 -0300)]
s4-drs: Synchronous Implementation of generated parentGUID

This generated parentGUID on demand, rather than getting it from the
database

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-drs: Utility functions to deal with GUID
Fernando J V da Silva [Thu, 19 Nov 2009 18:28:37 +0000 (15:28 -0300)]
s4-drs: Utility functions to deal with GUID

dsdb_find_parentguid_by_dn() returns the parentGUID for a given DN
dsdb_msg_add_guid() adds a GUID value to a given message (either
objectGUID or parentGUID).

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agoldb:ldb_tdb backend/indexes - Outside API
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 09:44:56 +0000 (10:44 +0100)]
ldb:ldb_tdb backend/indexes - Outside API

- The outside API contains "DN" string arguments: Bad. Since in this way we
  fully rely on the outside calls regarding the right DN format. Solution: Use
  always a "struct ldb_dn" entry. Since this one is interchangeable and we can
  handle it in our preferred way.

10 years agoldb:ldb_tdb backend/indexes - DN comparison
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 09:44:56 +0000 (10:44 +0100)]
ldb:ldb_tdb backend/indexes - DN comparison

- DN comparison: The function doesn't seem that efficient. I "upgraded" it a bit
  to be more powerful (added a second length check and do both before the string
  comparison)

10 years agos4-dsdb: make sure mod_usn list is zeroed on each transaction
Andrew Tridgell [Fri, 20 Nov 2009 01:09:24 +0000 (12:09 +1100)]
s4-dsdb: make sure mod_usn list is zeroed on each transaction

10 years agos4-ldb: added a double-rename test
Andrew Tridgell [Fri, 20 Nov 2009 00:47:54 +0000 (11:47 +1100)]
s4-ldb: added a double-rename test

This tests the fix for double rename/add and indexing

10 years agos4-ldb: when -v is specified, show progress of ldbadd/ldbmodify
Andrew Tridgell [Fri, 20 Nov 2009 00:34:24 +0000 (11:34 +1100)]
s4-ldb: when -v is specified, show progress of ldbadd/ldbmodify

This is useful for speed tests with large numbers of records.

10 years agos4-ldb: make ldb tools line buffered
Andrew Tridgell [Fri, 20 Nov 2009 00:33:43 +0000 (11:33 +1100)]
s4-ldb: make ldb tools line buffered

this prevents output being buffered when redirected to a file. Useful
for larger ldb command line operations

10 years agos4-ldb: fixed an issue in rename/modify indexing
Andrew Tridgell [Wed, 18 Nov 2009 10:56:24 +0000 (21:56 +1100)]
s4-ldb: fixed an issue in rename/modify indexing

When we rename or modify a record, we need to update the indexes at
the same time. It is important that we use the DN of the actual
message that is stored in the database to do this, not the DN that was
passed in by the user. If the two differ in case then the index
records needs to use the 'real' record DN, as index handling is
currently case sensitive.

10 years agos4-ldb: allow ldap.py test suite to run directly against a file
Andrew Tridgell [Wed, 18 Nov 2009 02:27:50 +0000 (13:27 +1100)]
s4-ldb: allow ldap.py test suite to run directly against a file

This makes it much easier to debug (as you can break in the ldb
modules by running gdb on /usr/bin/python)

10 years agoPC Oota Edits.
John H Terpstra [Thu, 19 Nov 2009 21:41:59 +0000 (15:41 -0600)]
PC Oota Edits.

10 years agos3: Avoid races to change the machine password in winbind
Volker Lendecke [Thu, 19 Nov 2009 16:22:27 +0000 (17:22 +0100)]
s3: Avoid races to change the machine password in winbind

The machine password handler has code to deal with every node in the cluster
trying to change the machine password at the same time. However, it is not very
nice to the DC if everyone tries this simultaneously. This adds a random 0-255
second offset to our timed event. When this fires a bit later than strictly
calculated, someone else might have stepped in and have already changed it. The
timed event handler will handle this gracefully, it won't even try to do it
again.

10 years agos3: Protect against flooding the DC with pwchange requests
Volker Lendecke [Thu, 19 Nov 2009 16:20:47 +0000 (17:20 +0100)]
s3: Protect against flooding the DC with pwchange requests

When there is a temporary problem changing passwords we flooded the DC with
pwchange requests. This gives the DC a 60-second break to recover.