9 years agos3: Call sid_check_is_domain instead of dom_sid_equal
Volker Lendecke [Thu, 18 Nov 2010 14:20:38 +0000 (15:20 +0100)]
s3: Call sid_check_is_domain instead of dom_sid_equal

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 18 15:32:32 UTC 2010 on sn-devel-104

9 years agos3: Make winbind recover from a signing error
Volker Lendecke [Thu, 18 Nov 2010 12:28:47 +0000 (13:28 +0100)]
s3: Make winbind recover from a signing error

When winbind sees a signing error on the smb connection to a DC (for whatever
reason, our bug, network glitch, etc) it should recover properly. The "old"
code in clientgen.c just closed the socket in this case. This is the right
thing to do, this connection is spoiled anyway. The new, async code did not do
this so far, which led to the code in winbindd_cm.c not detect that we need to

9 years agos3/vfs_tsmsm: remove unneeded cast to off_t
Björn Jacke [Wed, 17 Nov 2010 16:52:06 +0000 (17:52 +0100)]
s3/vfs_tsmsm: remove unneeded cast to off_t

"off_t" is wrong on 32 bit systems anyhow ...

Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Nov 18 14:47:59 UTC 2010 on sn-devel-104

9 years agos3/vfs_tsmsm: fix debug output for large files
Björn Jacke [Wed, 17 Nov 2010 16:45:01 +0000 (17:45 +0100)]
s3/vfs_tsmsm: fix debug output for large files

9 years agoldb: error out when modules are not found
Simo Sorce [Thu, 18 Nov 2010 13:01:15 +0000 (08:01 -0500)]
ldb: error out when modules are not found

We shouldn't proceed without all required modules, it could cause damage to the
ldb if operations are performed w/o the needed modules.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Nov 18 14:02:34 UTC 2010 on sn-devel-104

9 years agos4-tests: Descriptor tests should use the existing samdb domain_dn method instead...
Nadezhda Ivanova [Thu, 18 Nov 2010 11:17:00 +0000 (13:17 +0200)]
s4-tests: Descriptor tests should use the existing samdb domain_dn method instead of defining a new one

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Thu Nov 18 12:52:48 UTC 2010 on sn-devel-104

9 years agos4-tests: Acl tests should use the existing samdb domain_dn method instead of definin...
Nadezhda Ivanova [Thu, 18 Nov 2010 11:13:35 +0000 (13:13 +0200)]
s4-tests: Acl tests should use the existing samdb domain_dn method instead of defining a new one

9 years agoldb:skel.c - don't introduce trailing whitespaces by a module template
Matthias Dieter Wallnöfer [Thu, 18 Nov 2010 11:20:56 +0000 (12:20 +0100)]
ldb:skel.c - don't introduce trailing whitespaces by a module template

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 18 12:08:30 UTC 2010 on sn-devel-104

9 years agos4:password_hash LDB module - remove unused headers
Matthias Dieter Wallnöfer [Thu, 18 Nov 2010 11:20:10 +0000 (12:20 +0100)]
s4:password_hash LDB module - remove unused headers

9 years agos4:repl_meta_data LDB module - allow also special DNs to be renamed correctly
Matthias Dieter Wallnöfer [Thu, 18 Nov 2010 09:44:52 +0000 (10:44 +0100)]
s4:repl_meta_data LDB module - allow also special DNs to be renamed correctly

Do always escape RDN values - this fixes bug #7794

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 18 10:43:40 UTC 2010 on sn-devel-104

9 years agos4:api.py - DN tests - test a bit more special DNs and merge the comparison tests
Matthias Dieter Wallnöfer [Thu, 18 Nov 2010 08:22:07 +0000 (09:22 +0100)]
s4:api.py - DN tests - test a bit more special DNs and merge the comparison tests

9 years agoldb:ldb_dn_explode - point out that on error cases "data" is implicitly free'd
Matthias Dieter Wallnöfer [Thu, 18 Nov 2010 07:57:00 +0000 (08:57 +0100)]
ldb:ldb_dn_explode - point out that on error cases "data" is implicitly free'd

9 years agos4-test: added greater control over tests to run
Andrew Tridgell [Thu, 18 Nov 2010 03:43:53 +0000 (14:43 +1100)]
s4-test: added greater control over tests to run

now supports --list to list tests, and --skip to skip the named tests

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 18 04:29:24 UTC 2010 on sn-devel-104

9 years agos4-test: rename scripting/devel/howto to scripting/devel/wintest
Andrew Tridgell [Wed, 17 Nov 2010 23:57:28 +0000 (10:57 +1100)]
s4-test: rename scripting/devel/howto to scripting/devel/wintest

this won't just be for the howto anymore

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 18 00:45:18 UTC 2010 on sn-devel-104

9 years agos4-wintest: added wintest.py library
Andrew Tridgell [Wed, 17 Nov 2010 23:56:05 +0000 (10:56 +1100)]
s4-wintest: added wintest.py library

converted test-howto.py to use the wintest library.

The idea is for us to create other tests that test lots of different
interactions with windows

9 years agos3: Fix a missing return value
Volker Lendecke [Wed, 17 Nov 2010 19:54:41 +0000 (20:54 +0100)]
s3: Fix a missing return value

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov 17 20:40:18 UTC 2010 on sn-devel-104

9 years agos3-spoolss: make sure members of "BUILTIN\Print Operators" can open printers
Günther Deschner [Mon, 15 Nov 2010 11:22:52 +0000 (12:22 +0100)]
s3-spoolss: make sure members of "BUILTIN\Print Operators" can open printers
with admin privileges.


Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 17 15:05:02 UTC 2010 on sn-devel-104

9 years agos3-spoolss: add debug statement for access denied cases in OpenPrinterEx path.
Günther Deschner [Mon, 15 Nov 2010 10:19:23 +0000 (11:19 +0100)]
s3-spoolss: add debug statement for access denied cases in OpenPrinterEx path.


9 years agos3-rpcclient: exit early in cmd_spoolss_enum_data() when there is a failure.
Günther Deschner [Thu, 11 Nov 2010 12:26:10 +0000 (13:26 +0100)]
s3-rpcclient: exit early in cmd_spoolss_enum_data() when there is a failure.


9 years agos4-repl: removed the syncall_workaround code
Andrew Tridgell [Wed, 17 Nov 2010 12:48:23 +0000 (23:48 +1100)]
s4-repl: removed the syncall_workaround code

this isn't needed any more

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov 17 13:41:51 UTC 2010 on sn-devel-104

9 years agos4-repl: save the result of the last replication in repsFrom/repsTo
Andrew Tridgell [Wed, 17 Nov 2010 12:13:32 +0000 (23:13 +1100)]
s4-repl: save the result of the last replication in repsFrom/repsTo

when a replication fails, we should add the failure to repsFrom
when a notify fails, we need to save it to repsTo

this ensures showrepl always shows the latest status

9 years agos4-repl: ensure we don't starve pending replication ops
Andrew Tridgell [Wed, 17 Nov 2010 12:12:10 +0000 (23:12 +1100)]
s4-repl: ensure we don't starve pending replication ops

when there was a continuous sequence of notify ops, we could leave the
replication ops starving. This ensures we run whichever was queued

9 years agos4-kcc: fixed result_last_attempt in showrepl
Andrew Tridgell [Wed, 17 Nov 2010 12:11:12 +0000 (23:11 +1100)]
s4-kcc: fixed result_last_attempt in showrepl

9 years agos4-doserr: telling our users to "see Windows help" doesn't seem right
Andrew Tridgell [Wed, 17 Nov 2010 12:10:48 +0000 (23:10 +1100)]
s4-doserr: telling our users to "see Windows help" doesn't seem right

9 years agos4-provision: don't test for xattrs if posix:eadb is set
Andrew Tridgell [Wed, 17 Nov 2010 10:50:06 +0000 (21:50 +1100)]
s4-provision: don't test for xattrs if posix:eadb is set

when it is set in smb.conf or on the command line, obey the setting
and don't try to test for system xattr support

9 years agos4-provision: setup posix:eadb using lp.set()
Andrew Tridgell [Wed, 17 Nov 2010 10:49:19 +0000 (21:49 +1100)]
s4-provision: setup posix:eadb using lp.set()

this allows it to override a setting made during the automatic testing
of xattr support

9 years agodeveloper: only do the C++ reserved name checking on Linux
Andrew Tridgell [Wed, 17 Nov 2010 09:36:37 +0000 (20:36 +1100)]
developer: only do the C++ reserved name checking on Linux

this prevents us breaking the solaris build, but will still mean we
prevent C++ vars in our code

9 years agos4-provision: don't try to autodetect xattr is posix:eadb is set
Andrew Tridgell [Wed, 17 Nov 2010 09:15:42 +0000 (20:15 +1100)]
s4-provision: don't try to autodetect xattr is posix:eadb is set

when posix:eadb is set then we know we should be using an eadb

9 years agos4-heimdal: ask for non-atomic heimdal
Andrew Tridgell [Tue, 16 Nov 2010 03:54:09 +0000 (22:54 -0500)]
s4-heimdal: ask for non-atomic heimdal

this allows us to build with compilers other than gcc

9 years agoheimdal: added HEIM_BASE_NON_ATOMIC option
Andrew Tridgell [Tue, 16 Nov 2010 03:53:13 +0000 (22:53 -0500)]
heimdal: added HEIM_BASE_NON_ATOMIC option

This allows heimdal to build without gcc, by not using atomic
operations. We don't need heimdal to be atomic in Samba.

9 years agos4-test: updates to test-howto.py
Andrew Tridgell [Wed, 17 Nov 2010 07:29:04 +0000 (18:29 +1100)]
s4-test: updates to test-howto.py

- handle clock skew using "net time" on windows after we open the
  telnet connection
- allow checking for result lists in order
- replicate all partitions after vampiring so we don't need
  to wait for periodic replication
- use a krb5 ccache in the prefix for kinit based tests

The complete test suite now passes on my system, taking just over 13
minutes to complete

9 years agos4-heimdal: implement KERB_AP_ERR_TYPE_SKEW_RECOVERY
Andrew Tridgell [Wed, 17 Nov 2010 06:33:31 +0000 (17:33 +1100)]
s4-heimdal: implement KERB_AP_ERR_TYPE_SKEW_RECOVERY

this e_data field in a kerberos error packet tells windows to do clock
skew recovery.


Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-gensec: zero the gssapi_state
Andrew Tridgell [Wed, 17 Nov 2010 06:09:24 +0000 (17:09 +1100)]
s4-gensec: zero the gssapi_state

this fixes a use of the target_principal before initialisation

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-provision: use the command line lp in provision
Andrew Tridgell [Wed, 17 Nov 2010 01:54:41 +0000 (12:54 +1100)]
s4-provision: use the command line lp in provision

this ensures that provision options are stored in the generated

9 years agos4-provision: add log messages about IP lookup
Andrew Tridgell [Wed, 17 Nov 2010 01:54:13 +0000 (12:54 +1100)]
s4-provision: add log messages about IP lookup

the IPv6 lookup can be very slow if a DNS server in the search list is
unavailable. It's good to let the user know what its doing.

9 years agos4-dns: catch more expections in samba_dnsupdate
Andrew Tridgell [Wed, 17 Nov 2010 01:33:02 +0000 (12:33 +1100)]
s4-dns: catch more expections in samba_dnsupdate

9 years agos3: Remove a reference to "winbindd_cli_state" from append_auth_data
Volker Lendecke [Tue, 16 Nov 2010 16:58:10 +0000 (17:58 +0100)]
s3: Remove a reference to "winbindd_cli_state" from append_auth_data

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov 17 12:02:34 UTC 2010 on sn-devel-104

9 years agos3: Remove a reference to "winbindd_cli_state" from append_info3_as_txt
Volker Lendecke [Tue, 16 Nov 2010 16:56:21 +0000 (17:56 +0100)]
s3: Remove a reference to "winbindd_cli_state" from append_info3_as_txt

9 years agos3: Remove a reference to "winbindd_cli_state" from append_afs_token
Volker Lendecke [Tue, 16 Nov 2010 16:52:31 +0000 (17:52 +0100)]
s3: Remove a reference to "winbindd_cli_state" from append_afs_token

9 years agos3: Remove a reference to "winbindd_cli_state" from append_info3_as_ndr
Volker Lendecke [Tue, 16 Nov 2010 16:50:16 +0000 (17:50 +0100)]
s3: Remove a reference to "winbindd_cli_state" from append_info3_as_ndr

9 years agos3: Remove a reference to "winbindd_cli_state" from append_unix_username
Volker Lendecke [Tue, 16 Nov 2010 16:44:08 +0000 (17:44 +0100)]
s3: Remove a reference to "winbindd_cli_state" from append_unix_username

9 years agos3: Remove a reference to "winbindd_cli_state" from append_auth_data
Volker Lendecke [Tue, 16 Nov 2010 16:07:33 +0000 (17:07 +0100)]
s3: Remove a reference to "winbindd_cli_state" from append_auth_data

9 years ago"bool ? true : false" is a bit pointless
Volker Lendecke [Tue, 16 Nov 2010 15:22:32 +0000 (16:22 +0100)]
"bool ? true : false" is a bit pointless

9 years agos3: Move parse_sidlist to the only calling file
Volker Lendecke [Tue, 16 Nov 2010 15:11:14 +0000 (16:11 +0100)]
s3: Move parse_sidlist to the only calling file

9 years agos3: Remove some unused code
Volker Lendecke [Tue, 16 Nov 2010 15:09:04 +0000 (16:09 +0100)]
s3: Remove some unused code

9 years agoldb:ldb_dn.c - ldb_dn_explode - free also the extended components on error cases
Matthias Dieter Wallnöfer [Wed, 17 Nov 2010 07:58:21 +0000 (08:58 +0100)]
ldb:ldb_dn.c - ldb_dn_explode - free also the extended components on error cases

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov 17 08:45:53 UTC 2010 on sn-devel-104

9 years agotevent: Fix docstring, tevent_req_is_in_progress does not destroy private data
Kai Blin [Wed, 17 Nov 2010 06:07:08 +0000 (07:07 +0100)]
tevent: Fix docstring, tevent_req_is_in_progress does not destroy private data

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Nov 17 07:23:51 UTC 2010 on sn-devel-104

9 years agos4-test: added testing of w2k3 DC join to test-howto.py
Andrew Tridgell [Wed, 17 Nov 2010 00:29:50 +0000 (11:29 +1100)]
s4-test: added testing of w2k3 DC join to test-howto.py

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Nov 17 01:16:19 UTC 2010 on sn-devel-104

9 years agos4-join: fixed join to w2k3
Andrew Tridgell [Wed, 17 Nov 2010 00:10:45 +0000 (11:10 +1100)]
s4-join: fixed join to w2k3

w2k3 does need msDS-Behavior-Version

9 years agos4-join: show a reasonable error on DsAddEntry() failing
Andrew Tridgell [Wed, 17 Nov 2010 00:09:59 +0000 (11:09 +1100)]
s4-join: show a reasonable error on DsAddEntry() failing

DsAddEntry() gives errors in a reply container

9 years agos4-join: enable NDR printing at debug levels >= 5
Andrew Tridgell [Wed, 17 Nov 2010 00:08:59 +0000 (11:08 +1100)]
s4-join: enable NDR printing at debug levels >= 5

this is handy for debugging joins

9 years agos4-loadparm: set debuglevel and logfile in tables
Andrew Tridgell [Wed, 17 Nov 2010 00:07:12 +0000 (11:07 +1100)]
s4-loadparm: set debuglevel and logfile in tables

this allows the debug level and logfile to be queried from python
using lp.get(). Otheriwse they are set only in the globals, and not in
the tables.

9 years agos4-loadparm: fixed a memory leak in handle_realm()
Andrew Tridgell [Wed, 17 Nov 2010 00:06:33 +0000 (11:06 +1100)]
s4-loadparm: fixed a memory leak in handle_realm()

we need to free the lowercase and uppercase varients

9 years agos4-kdc Rework supported encryption type logic to match Microsoft
Andrew Bartlett [Tue, 16 Nov 2010 10:01:22 +0000 (21:01 +1100)]
s4-kdc Rework supported encryption type logic to match Microsoft

Thanks to Hongwei Sun for the clear description of the algorithim
involved.  Importantly, it isn't possible to remove encryption types
from the list, only to add them over the defaults (DES and
arcfour-hmac-md5, and additional AES for DCs and RODCs).

This changes the behaviour for entries with
msDS-supportedEncryptionTypes: 0, which Angelos Oikonomopoulos
reported finding set by ADUC when attempting to store cleartext

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Nov 16 21:24:43 UTC 2010 on sn-devel-104

9 years agos4:acl LDB module - use also here "dsdb_find_nc_root" to implement the NC-specific...
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 13:22:27 +0000 (14:22 +0100)]
s4:acl LDB module - use also here "dsdb_find_nc_root" to implement the NC-specific checks

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Nov 16 15:12:13 UTC 2010 on sn-devel-104

9 years agos4:descriptor LDB module - also "get_default_ag" should make use of "dsdb_find_nc_root"
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 12:17:32 +0000 (13:17 +0100)]
s4:descriptor LDB module - also "get_default_ag" should make use of "dsdb_find_nc_root"

9 years agos4:descriptor LDB module - handle the NCs in a more generic way by using "dsdb_find_n...
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 12:12:02 +0000 (13:12 +0100)]
s4:descriptor LDB module - handle the NCs in a more generic way by using "dsdb_find_nc_root"

9 years agos4:"dsdb_find_nc_root" - let it work also when the "namingContexts" attribute isn...
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 14:20:04 +0000 (15:20 +0100)]
s4:"dsdb_find_nc_root" - let it work also when the "namingContexts" attribute isn't available yet

This is needed on provisioning when the modules aren't set up yet.

9 years agos4:descriptor LDB module - make more clear that special control entries never should...
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 12:25:34 +0000 (13:25 +0100)]
s4:descriptor LDB module - make more clear that special control entries never should be handled by modules

9 years agos4:objectclass LDB module - the "olddn" is the special DN for rename requests
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 12:22:05 +0000 (13:22 +0100)]
s4:objectclass LDB module - the "olddn" is the special DN for rename requests

9 years agos4-schema_load: Don't clean in_transaction flag until transaction is really finished
Kamen Mazdrashki [Thu, 11 Nov 2010 21:25:35 +0000 (23:25 +0200)]
s4-schema_load: Don't clean in_transaction flag until transaction is really finished

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Nov 16 11:00:35 UTC 2010 on sn-devel-104

9 years agos4:subtree_rename LDB module - make use of "dsdb_find_nc_root"
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 07:34:52 +0000 (08:34 +0100)]
s4:subtree_rename LDB module - make use of "dsdb_find_nc_root"

This is exactly what's needed there.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Nov 16 08:42:07 UTC 2010 on sn-devel-104

9 years agos4:objectclass LDB module - free "nc_root" after name context comparisons
Matthias Dieter Wallnöfer [Tue, 16 Nov 2010 07:34:27 +0000 (08:34 +0100)]
s4:objectclass LDB module - free "nc_root" after name context comparisons

9 years agos4-test: fixes for test-howto.py
Andrew Tridgell [Tue, 16 Nov 2010 07:14:11 +0000 (18:14 +1100)]
s4-test: fixes for test-howto.py

this fixes some timing issues, plus ensures we test both with and
without kerberos

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Nov 16 07:58:55 UTC 2010 on sn-devel-104

9 years agos4-spoolss: fixed warning in call to torture_warning()
Andrew Tridgell [Tue, 16 Nov 2010 04:14:43 +0000 (15:14 +1100)]
s4-spoolss: fixed warning in call to torture_warning()

9 years agos4-eventlog: fixed dcerpc handle return
Andrew Tridgell [Tue, 16 Nov 2010 04:14:18 +0000 (15:14 +1100)]
s4-eventlog: fixed dcerpc handle return

9 years agosamba-tool Add test for --store-plaintext
Andrew Bartlett [Tue, 16 Nov 2010 05:43:05 +0000 (16:43 +1100)]
samba-tool Add test for --store-plaintext

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Nov 16 06:29:04 UTC 2010 on sn-devel-104

9 years agoUpdate dcerpc_server.pc library name to match reality.
Brad Hards [Tue, 16 Nov 2010 05:42:50 +0000 (16:42 +1100)]
Update dcerpc_server.pc library name to match reality.

9 years agosamba-tool pwsettings Allow setting 'store cleartext'
Andrew Bartlett [Tue, 16 Nov 2010 05:32:55 +0000 (16:32 +1100)]
samba-tool pwsettings Allow setting 'store cleartext'

This allows the 'store cleartext' password policy flag to be (un)set.

Andrew Bartlett

9 years agos4-ldif_handlers Add handler for printing supplementalCredentials
Andrew Bartlett [Tue, 16 Nov 2010 05:32:27 +0000 (16:32 +1100)]
s4-ldif_handlers Add handler for printing supplementalCredentials

9 years agos4-test_kinit Add tests for lowercase realm combinations
Andrew Bartlett [Tue, 16 Nov 2010 05:01:19 +0000 (16:01 +1100)]
s4-test_kinit Add tests for lowercase realm combinations

This tests that the handling of lowercase realms works in our KDC and

Andrew Bartlett

9 years agoheimdal Build ticket with the canonical server name
Andrew Bartlett [Tue, 16 Nov 2010 04:05:33 +0000 (15:05 +1100)]
heimdal Build ticket with the canonical server name

We need to use the name that the HDB entry returned, otherwise we
will not canonicalise the reply as requested.

Andrew Bartlett

9 years agos4-kdc Fix the realm handling again, this time pay attention to the flags
Andrew Bartlett [Tue, 16 Nov 2010 03:16:31 +0000 (14:16 +1100)]
s4-kdc Fix the realm handling again, this time pay attention to the flags

The KDC sets different flags for the AS-REQ (this is client-depenent)
and the TGS-REQ to determine if the realm should be forced to the
canonical value.  If we do this always, or do this never, we get into
trouble, so it's much better to honour the flags we are given.

Andrew Bartlett

9 years agos4-kdc use 'flags' to only create the 'admin data' elements when requested
Andrew Bartlett [Tue, 16 Nov 2010 03:12:17 +0000 (14:12 +1100)]
s4-kdc use 'flags' to only create the 'admin data' elements when requested

This avoids setting these values when the caller simply does not care

Andrew Bartlett

9 years agos4-kdc Add 'flags' parameter to db fetch calls
Andrew Bartlett [Tue, 16 Nov 2010 03:07:18 +0000 (14:07 +1100)]
s4-kdc Add 'flags' parameter to db fetch calls

This will allow these calls to honour the flags passed in from the KDC

Andrew Bartlett

9 years agowaf: added --git-local-changes configure option
Andrew Tridgell [Tue, 16 Nov 2010 01:05:14 +0000 (12:05 +1100)]
waf: added --git-local-changes configure option

if you use --git-local-changes then the version number that waf
extracts from git will have a '+' on the end if you have local
changes, as determined by running 'git diff'.

This used to be the default, but unfortunately it is far too slow on
some systems. On a NFS build system I was using the first line of
configure took about 2 minutes.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Nov 16 01:51:54 UTC 2010 on sn-devel-104

9 years agos4-kdc Don't regenerate the PAC for cross-realm tickets
Andrew Bartlett [Mon, 15 Nov 2010 22:33:05 +0000 (09:33 +1100)]
s4-kdc Don't regenerate the PAC for cross-realm tickets

We should never get a cross-realm ticket that was not issued by a full
DC, but if someone claims to have such a thing, reject it rather than
segfaulting on the NULL client pointer.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Nov 15 23:59:34 UTC 2010 on sn-devel-104

9 years agos4-kdc Don't always regenerate the PAC
Andrew Bartlett [Mon, 15 Nov 2010 22:30:55 +0000 (09:30 +1100)]
s4-kdc Don't always regenerate the PAC

The PAC was being regenerated on all normal DCs, because they don't
have a msDS-SecondaryKrbTgtNumber attribute.  Instead we need to check
if it's set and not equal to our RODC number, allowing RODCs to trust
the full DCs and itself, but not other RODCs.

Andrew Bartlett

9 years agoheimdal Fetch the client before the PAC check, but after obtaining krbtgt_out
Andrew Bartlett [Mon, 15 Nov 2010 22:29:18 +0000 (09:29 +1100)]
heimdal Fetch the client before the PAC check, but after obtaining krbtgt_out

By checking the client principal here, we compare the realm based on
the normalised realm, but do so early enough to validate the PAC (and
regenerate it if required).

Andrew Bartlett

9 years agos4-gensec Indicate if GENSEC is in client or server mode in the debug
Andrew Bartlett [Mon, 15 Nov 2010 22:28:21 +0000 (09:28 +1100)]
s4-gensec Indicate if GENSEC is in client or server mode in the debug

9 years agos4:heimdal - fix the return code of a non-void function
Matthias Dieter Wallnöfer [Mon, 15 Nov 2010 21:42:22 +0000 (22:42 +0100)]
s4:heimdal - fix the return code of a non-void function

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov 15 23:14:57 UTC 2010 on sn-devel-104

9 years agos4:torture/basic/base.c - fix output warnings regarding "time_t"
Matthias Dieter Wallnöfer [Mon, 15 Nov 2010 21:38:09 +0000 (22:38 +0100)]
s4:torture/basic/base.c - fix output warnings regarding "time_t"

"time_t" is generally "long int".

9 years agos4:objectclass LDB module - improve the default name context checking on modifications
Matthias Dieter Wallnöfer [Mon, 15 Nov 2010 21:30:16 +0000 (22:30 +0100)]
s4:objectclass LDB module - improve the default name context checking on modifications

Pointed out by abartlet

9 years agos4-join: not all versions of w2003 have msDS-SupportedEncryptionTypes
Andrew Tridgell [Mon, 15 Nov 2010 20:41:54 +0000 (07:41 +1100)]
s4-join: not all versions of w2003 have msDS-SupportedEncryptionTypes

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 15 22:28:16 UTC 2010 on sn-devel-104

9 years agos4-devel: a script to test the Samba4 HOWTO
Andrew Tridgell [Mon, 15 Nov 2010 11:57:00 +0000 (22:57 +1100)]
s4-devel: a script to test the Samba4 HOWTO

This provides a script that allows testing of most of the steps of the
Samba4 HOWTO. The big difference between this and 'make test' is that
it test against windows, using pexpect to control windows boxes via

The info about VMs and other parameters are in separate conf
files. I've included a sample config file that I use on my laptop.

9 years agonet: Add and fix some German translation
André Hentschel [Sun, 14 Nov 2010 22:09:03 +0000 (23:09 +0100)]
net: Add and fix some German translation

typo spotted by Michael Wood

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Mon Nov 15 21:44:39 UTC 2010 on sn-devel-104

9 years agos4:objectclass LDB module - implement the "objectClass" change restrictions on Window...
Matthias Dieter Wallnöfer [Mon, 15 Nov 2010 12:00:58 +0000 (13:00 +0100)]
s4:objectclass LDB module - implement the "objectClass" change restrictions on Windows 2000 forest function level

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov 15 13:10:05 UTC 2010 on sn-devel-104

9 years agoheimdal_base: Fix include path so heim_threads.h can be found.
Jelmer Vernooij [Mon, 15 Nov 2010 11:42:14 +0000 (12:42 +0100)]
heimdal_base: Fix include path so heim_threads.h can be found.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Nov 15 12:26:53 UTC 2010 on sn-devel-104

9 years agosmb_server: Build as shared module.
Jelmer Vernooij [Mon, 15 Nov 2010 11:41:58 +0000 (12:41 +0100)]
smb_server: Build as shared module.

9 years agoheimdal_base: Add missing dependency on replace.
Jelmer Vernooij [Mon, 15 Nov 2010 11:24:45 +0000 (12:24 +0100)]
heimdal_base: Add missing dependency on replace.

9 years agonbtd: Build service as shared module.
Jelmer Vernooij [Mon, 15 Nov 2010 11:23:46 +0000 (12:23 +0100)]
nbtd: Build service as shared module.

9 years agowaf: fixed configure again on RHEL5
Andrew Tridgell [Mon, 15 Nov 2010 10:45:42 +0000 (21:45 +1100)]
waf: fixed configure again on RHEL5

the fancier cmd_output() broke git versioning

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov 15 11:33:41 UTC 2010 on sn-devel-104

9 years agos4-dns: added --fail-immediately option to samba_dnsupdate
Andrew Tridgell [Mon, 15 Nov 2010 08:09:14 +0000 (19:09 +1100)]
s4-dns: added --fail-immediately option to samba_dnsupdate

this is useful for manual testing

9 years agos4-dns: fixed registration of multiple IPs in samba_dnsupdate
Andrew Tridgell [Sun, 14 Nov 2010 23:54:50 +0000 (10:54 +1100)]
s4-dns: fixed registration of multiple IPs in samba_dnsupdate

bitten by python object references again!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoheimdal Fix handling of backwards cross-realm detection for Samba4
Andrew Bartlett [Mon, 15 Nov 2010 07:43:51 +0000 (18:43 +1100)]
heimdal Fix handling of backwards cross-realm detection for Samba4

Samba4 may modify the case of the realm in a returned entry, but will no longer modify the case of the prinicipal components.

The easy way to keep this test passing is to consider also what we
need to do to get the krbtgt account for the PAC signing - and to use
krbtgt/<this>/@REALM component to fetch the real krbtgt, and to use
that resutl for realm comparion.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Nov 15 08:47:44 UTC 2010 on sn-devel-104

9 years agos4-kdc Fix realm handling in our KDC
Andrew Bartlett [Mon, 15 Nov 2010 02:30:03 +0000 (13:30 +1100)]
s4-kdc Fix realm handling in our KDC

we should reset the realm part of the principal, but not the lowercase
realm embedded in the 'krbtgt/realm@REALM'.

Andrew Bartlett

9 years agos4: Build ldap and samba3_smb services as shared modules.
Jelmer Vernooij [Mon, 15 Nov 2010 02:19:44 +0000 (03:19 +0100)]
s4: Build ldap and samba3_smb services as shared modules.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Nov 15 03:04:41 UTC 2010 on sn-devel-104

9 years agocldap: Build as shared module.
Jelmer Vernooij [Mon, 15 Nov 2010 02:14:16 +0000 (03:14 +0100)]
cldap: Build as shared module.

9 years agokdc: Build as shared module by default.
Jelmer Vernooij [Sun, 14 Nov 2010 23:46:12 +0000 (00:46 +0100)]
kdc: Build as shared module by default.

9 years agoauth/ntlm: Use name consistent with other service names.
Jelmer Vernooij [Sun, 14 Nov 2010 23:45:48 +0000 (00:45 +0100)]
auth/ntlm: Use name consistent with other service names.