kai/samba.git
13 years agomake parametic options case insensitive
Andrew Tridgell [Wed, 25 Jun 2008 11:27:17 +0000 (21:27 +1000)]
make parametic options case insensitive

This is needed as some options are uppercased internally in Samba, such as the idmap config option
Without this change it is not possible to set these options via net conf which lowercases options
(This used to be commit c10aad9f136b7c2ef4809fd8558013ab2ee40cf6)

13 years agonetapi: add NetUserChangePassword() example code.
Günther Deschner [Tue, 24 Jun 2008 22:47:17 +0000 (00:47 +0200)]
netapi: add NetUserChangePassword() example code.

Guenther
(This used to be commit ac5aaf29004584d0f1821689eb985d837cda1aa1)

13 years agonetapi: add NetUserChangePassword() to public headers.
Günther Deschner [Tue, 24 Jun 2008 22:47:41 +0000 (00:47 +0200)]
netapi: add NetUserChangePassword() to public headers.

Guenther
(This used to be commit 5d06891238d7dddedeb6fe2aca677c765b90c74a)

13 years agonetapi: add NetUserChangePassword skeleton.
Günther Deschner [Tue, 24 Jun 2008 22:32:02 +0000 (00:32 +0200)]
netapi: add NetUserChangePassword skeleton.

Guenther
(This used to be commit f4ce6887103d0f50bf9a91251e2aceb77674604f)

13 years agore-run make idl.
Günther Deschner [Tue, 24 Jun 2008 22:29:25 +0000 (00:29 +0200)]
re-run make idl.

Guenther
(This used to be commit 397d305e90e90f475b6de0efac7dd9630d698efd)

13 years agonetapi: add NetUserChangePassword() to IDL.
Günther Deschner [Tue, 24 Jun 2008 22:29:06 +0000 (00:29 +0200)]
netapi: add NetUserChangePassword() to IDL.

Guenther
(This used to be commit 7020a5bd6e90c178085bb8d04325ac5ba83b4c3d)

13 years agorpc_client: let cli_get_session_key() return talloced session key.
Günther Deschner [Tue, 24 Jun 2008 22:21:37 +0000 (00:21 +0200)]
rpc_client: let cli_get_session_key() return talloced session key.

Thanks, Volker, for pointing this out.

Guenther
(This used to be commit b47899195e0c190445953243fe80da4e92994dd1)

13 years agoFix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy Allison [Wed, 25 Jun 2008 01:01:59 +0000 (18:01 -0700)]
Fix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy.
(This used to be commit a07fe72538e8e724b9736d5a85cc590864c5cab2)

13 years agoFix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account...
Jeremy Allison [Tue, 24 Jun 2008 23:37:15 +0000 (16:37 -0700)]
Fix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account logon.
Jeremy.
(This used to be commit 10da498a2349bf5944183adf5a9284eafa2b8b74)

13 years agonet_vampire: add basic libnet_dssync() infrastructure.
Günther Deschner [Mon, 23 Jun 2008 21:13:21 +0000 (23:13 +0200)]
net_vampire: add basic libnet_dssync() infrastructure.

Guenther
(This used to be commit 9486e532da602da587769d4ff8a1a2825e541a30)

13 years agorpc_client: add cli_get_session_key().
Günther Deschner [Tue, 10 Jun 2008 19:35:34 +0000 (21:35 +0200)]
rpc_client: add cli_get_session_key().

Guenther
(This used to be commit 93b56755f739889da3a67b18a6430b14306d84f7)

13 years agonet: add basic support for sealed RPC connections (using NET_FLAGS_SEAL).
Günther Deschner [Tue, 24 Jun 2008 08:34:16 +0000 (10:34 +0200)]
net: add basic support for sealed RPC connections (using NET_FLAGS_SEAL).

Guenther
(This used to be commit 7541a0103ad22000e94ffc6d057ffd5d33d1a930)

13 years agocrypto: add decrypt_drsuapi_blob from samba4.
Günther Deschner [Mon, 23 Jun 2008 14:02:04 +0000 (16:02 +0200)]
crypto: add decrypt_drsuapi_blob from samba4.

Guenther
(This used to be commit 3b6352a60e6683963af1641786f9c230d49ebfb5)

13 years agore-run make idl.
Günther Deschner [Tue, 24 Jun 2008 18:57:17 +0000 (20:57 +0200)]
re-run make idl.

Guenther
(This used to be commit 05d6f2e00cf5a7ad3d8a38149e9b9b1e408a666c)

13 years agodrsuapi: add some more attribute IDs.
Günther Deschner [Tue, 24 Jun 2008 18:57:03 +0000 (20:57 +0200)]
drsuapi: add some more attribute IDs.

Guenther
(This used to be commit fce7a195f1e299b3427a992027de68151784f586)

13 years agonet_vampire: add code to vampire a SAM database to a keytab file.
Günther Deschner [Wed, 18 Jun 2008 10:52:00 +0000 (12:52 +0200)]
net_vampire: add code to vampire a SAM database to a keytab file.

Guenther
(This used to be commit ee6e422c0e035aa4779fa718bb6f142827cc2de0)

13 years agonet_vampire: add username/password to samsync_context.
Günther Deschner [Tue, 24 Jun 2008 10:30:34 +0000 (12:30 +0200)]
net_vampire: add username/password to samsync_context.

Guenther
(This used to be commit e884304206b512a1ffc70b7a4da8db3c6dfd4f11)

13 years agolibads: use ads_connect_user_creds in some places.
Günther Deschner [Tue, 24 Jun 2008 11:06:38 +0000 (13:06 +0200)]
libads: use ads_connect_user_creds in some places.

Guenther
(This used to be commit ebf31203e7cf22e32b986c536279688b17a65d22)

13 years agolibads: add ads_connect_user_creds() that won't overwrite given user creds.
Günther Deschner [Tue, 24 Jun 2008 11:02:03 +0000 (13:02 +0200)]
libads: add ads_connect_user_creds() that won't overwrite given user creds.

Guenther
(This used to be commit 026018c9f1ed0680b3ca5b26dd6b8dc466e27e0d)

13 years agolibads: add ADS_AUTH_USER_CREDS to avoid magic overwriting of usernames.
Günther Deschner [Tue, 24 Jun 2008 10:11:06 +0000 (12:11 +0200)]
libads: add ADS_AUTH_USER_CREDS to avoid magic overwriting of usernames.

Guenther
(This used to be commit b5aaf5aa0f280f69e05b613271c96473a79b812e)

13 years agokerberos: add smb_krb5_keytab_name().
Günther Deschner [Wed, 18 Jun 2008 10:48:35 +0000 (12:48 +0200)]
kerberos: add smb_krb5_keytab_name().

Guenther
(This used to be commit c273ce8798062d1b55100411f3e92a01bdbf611c)

13 years agokerberos: make smb_krb5_kt_add_entry public, allow to pass keys without salting them.
Günther Deschner [Wed, 18 Jun 2008 10:45:57 +0000 (12:45 +0200)]
kerberos: make smb_krb5_kt_add_entry public, allow to pass keys without salting them.

Guenther
(This used to be commit 7c4da23be1105dc224033b21eb486e7fcdc7d9c5)

13 years agonet ads: Fix typos.
Karolin Seeger [Tue, 24 Jun 2008 13:55:30 +0000 (15:55 +0200)]
net ads: Fix typos.

Karolin
(This used to be commit 63c1a5146e25e05678d2bef95286add5c95a5f38)

13 years agorpc_client: Avoid warning in builds without krb5 headers.
Karolin Seeger [Tue, 24 Jun 2008 13:53:23 +0000 (15:53 +0200)]
rpc_client: Avoid warning in builds without krb5 headers.

warning: ‘cli_auth_kerberos_data_destructor’ defined but not used

Karolin
(This used to be commit b5f9176b6ca8c137d5c065abed943fa437b5531f)

13 years agoRemove "conn" from pipes_struct
Volker Lendecke [Mon, 23 Jun 2008 06:38:27 +0000 (08:38 +0200)]
Remove "conn" from pipes_struct

For spoolss, we need the client's IP address
(This used to be commit 64a4dfaa826cf9319ef3f5c65023352bf8af539e)

13 years agoCorrect calculation of "remark" in srv_srvsvc_nt.c
Volker Lendecke [Mon, 23 Jun 2008 06:33:04 +0000 (08:33 +0200)]
Correct calculation of "remark" in srv_srvsvc_nt.c

Very likely the client is not interested in the values for the IPC$ share :-)
(This used to be commit 40ca5764cf4310769c002b8cb6041fe2af4e6d0b)

13 years agoMove the responsibility to keep the cwd from srv_dfs_nt to msdfs.c
Volker Lendecke [Sun, 22 Jun 2008 20:19:10 +0000 (22:19 +0200)]
Move the responsibility to keep the cwd from srv_dfs_nt to msdfs.c
(This used to be commit 7db382588ac90fe250b72cf4cd07afb39fcae7c0)

13 years agore-run make idl.
Günther Deschner [Wed, 18 Jun 2008 10:42:27 +0000 (12:42 +0200)]
re-run make idl.

Guenther
(This used to be commit cd3a69e153d3ffb128e09871b44826041deff15a)

13 years agodrsuapi: fill in some more drsuapi_DsAttributeIds.
Günther Deschner [Wed, 18 Jun 2008 10:42:11 +0000 (12:42 +0200)]
drsuapi: fill in some more drsuapi_DsAttributeIds.

Guenther
(This used to be commit 7974c2c8afe2ed295d8da4daa45ba5b7cb0a7584)

13 years agonet_vampire: more libnet_samsync restructuring.
Günther Deschner [Mon, 23 Jun 2008 15:29:01 +0000 (17:29 +0200)]
net_vampire: more libnet_samsync restructuring.

Guenther
(This used to be commit 3bcda522f025aff249678a8a086218679fc19c6b)

13 years agonet_vampire: prepend libnet_ to the public samsync functions.
Günther Deschner [Mon, 23 Jun 2008 15:03:53 +0000 (17:03 +0200)]
net_vampire: prepend libnet_ to the public samsync functions.

Guenther
(This used to be commit f020c947cfb1482176af8827ed9c361d7c21e26f)

13 years agonet_vampire: move out display routines to one file.
Günther Deschner [Tue, 17 Jun 2008 19:53:01 +0000 (21:53 +0200)]
net_vampire: move out display routines to one file.

Guenther
(This used to be commit 64b48a07e714d7eb97dd49c11d9ca62951d79524)

13 years agonet_vampire: move out passdb routines to one file.
Günther Deschner [Tue, 17 Jun 2008 19:44:30 +0000 (21:44 +0200)]
net_vampire: move out passdb routines to one file.

Guenther
(This used to be commit 74d431270d9b4cc1524f79fa2ad743420afef417)

13 years agonet_vampire: fix included header.
Günther Deschner [Tue, 17 Jun 2008 19:42:27 +0000 (21:42 +0200)]
net_vampire: fix included header.

Guenther
(This used to be commit 1dbe6ea8607549649f69e1b63cc427efe67e0778)

13 years agonet_vampire: display more deltas while doing samdump.
Günther Deschner [Tue, 17 Jun 2008 19:32:12 +0000 (21:32 +0200)]
net_vampire: display more deltas while doing samdump.

Guenther
(This used to be commit 43579907c3cbd5a4c07fe1f8da13c9a2a7db3f32)

13 years agonet_vampire: move pull_netr_AcctLockStr() to libnet.
Günther Deschner [Tue, 17 Jun 2008 19:22:06 +0000 (21:22 +0200)]
net_vampire: move pull_netr_AcctLockStr() to libnet.

Guenther
(This used to be commit 8ec64a96e43d2e55e81f725fe693178ecdc65e88)

13 years agotime: move uint64s_nt_time_to_unix_abs() to lib/time.c
Günther Deschner [Mon, 16 Jun 2008 11:36:53 +0000 (13:36 +0200)]
time: move uint64s_nt_time_to_unix_abs() to lib/time.c

Guenther
(This used to be commit 58f54f180f0a942776455ab6e813628422493dac)

13 years agoAdd documentation for kerberos support in libsmbclient.
Andreas Schneider [Mon, 23 Jun 2008 14:29:40 +0000 (16:29 +0200)]
Add documentation for kerberos support in libsmbclient.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(This used to be commit fa803ce183376c938f92b0f31a7d89d522fd309f)

13 years agoAdd krb5 support for the testbrowse example.
Andreas Schneider [Mon, 23 Jun 2008 09:00:20 +0000 (11:00 +0200)]
Add krb5 support for the testbrowse example.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
(This used to be commit 84b1ea39a4f27ebcf06a2bafed78396c7353df0e)

13 years agolibsmbconf: add "includes" to the forbidden_valnames[].
Michael Adam [Mon, 23 Jun 2008 09:11:08 +0000 (11:11 +0200)]
libsmbconf: add "includes" to the forbidden_valnames[].

This removes the warning messages 'Unknown parameter encountered: "includes"'.

Michael
(This used to be commit b20019ceaaf4a8964792f6ba37f50f91b6847e7f)

13 years agolibsmbconf: fastpaths first in smbconf_reg_valname_valid().
Michael Adam [Mon, 23 Jun 2008 09:09:38 +0000 (11:09 +0200)]
libsmbconf: fastpaths first in smbconf_reg_valname_valid().

Before dropping into lp_parameter_is_valid().

Michael
(This used to be commit 59beb7acd777a4c224dce90fbbff7a137d2b89c1)

13 years agoSamba3 HOWTO: Remove trailing whitespaces.
Karolin Seeger [Mon, 23 Jun 2008 08:15:53 +0000 (10:15 +0200)]
Samba3 HOWTO: Remove trailing whitespaces.

Karolin
(cherry picked from commit c7a9c903acbba9c70211e6f3c25964533bbc1622)
(cherry picked from commit 62e485eebd8a40b5692caa79bb3ed6108f0b835b)
(This used to be commit f4933b1fac811f9a2f2a35f195d83b8ec6199590)

13 years agoman pages: Correct version in man winbindd again.
Karolin Seeger [Mon, 23 Jun 2008 08:28:09 +0000 (10:28 +0200)]
man pages: Correct version in man winbindd again.

Karolin
(cherry picked from commit ef44968276bfde2fdd3370e2558fb469357414be)
(cherry picked from commit 9fd1d784cf6044c5c03cf7ab0f2373e08df64295)
(This used to be commit 7e09a1f1c22b4323be910504f77626dda47b5225)

13 years agoFixed publishing date info.
John H Terpstra [Wed, 28 May 2008 16:02:26 +0000 (11:02 -0500)]
Fixed publishing date info.
(cherry picked from commit b96c9d54cfd29ec87d59655839a4136977a98032)
(cherry picked from commit e4d03d3aede0cd611283a041eafdcd1e836aad33)
(This used to be commit 1df1e9fd8cee84391e62e4acd259cb5be9b3d834)

13 years agoAdded TDB File documentation requested by some users.
John H Terpstra [Wed, 28 May 2008 16:00:49 +0000 (11:00 -0500)]
Added TDB File documentation requested by some users.
(cherry picked from commit 5035311af639336fdc51fa9829e984ff281216f9)
(cherry picked from commit a7531f4964ac8f861a41e9fa446e5a3aa69eaaa2)
(This used to be commit e5c2665ef8cb44f1ef1ec16d21358e5f37b81d6b)

13 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:02:08 +0000 (13:02 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 3a8ea6be389bedbcdb5668664d862768c026f669)
(cherry picked from commit 8522db2075f8c9e869c6224f2852ce355bba987d)
(This used to be commit 09fa3c61d96e218885c9d661ab4855b9c872233f)

13 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:00:01 +0000 (13:00 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use libnss_wins.so.
(cherry picked from commit 2a953d6ba252e5ba4e28b7fae5979e7c47fe9bd0)
(cherry picked from commit 59bb2b0c9a6397bb0202055d7b00dce30d7bf03b)
(This used to be commit 5144c1b2d6891ecf5d21a0b3982276bdbcf27960)

13 years agoinit_shared_module -> init_samba_module
Volker Lendecke [Mon, 23 Jun 2008 05:14:46 +0000 (07:14 +0200)]
init_shared_module -> init_samba_module
(This used to be commit 9b174871a87677f7dfbd897a80e526f203906bea)

13 years agoRemove the "exists" parameter from create_msdfs_link
Volker Lendecke [Sun, 22 Jun 2008 18:33:28 +0000 (20:33 +0200)]
Remove the "exists" parameter from create_msdfs_link

Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of
a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in
3.2. I only check it into 3.3 as I would like you to look at it first.

Thanks,

Volker
(This used to be commit f58b098a4172949018e84c4d0c722d6eb9bba514)

13 years agoCheck for sec_initial_uid() instead of uid==0 in dfs management
Volker Lendecke [Sun, 22 Jun 2008 18:27:20 +0000 (20:27 +0200)]
Check for sec_initial_uid() instead of uid==0 in dfs management
(This used to be commit 948607f16112f6529f3a54cd6bbe978e8a600bc8)

13 years agoReduce memory usage in form_junctions() a little bit
Volker Lendecke [Sun, 22 Jun 2008 09:28:57 +0000 (11:28 +0200)]
Reduce memory usage in form_junctions() a little bit
(This used to be commit d031e6d8cabe2dd0b29e90d173d45843e145176a)

13 years agoFix an abort in junction_to_local_path
Volker Lendecke [Sun, 22 Jun 2008 16:36:37 +0000 (18:36 +0200)]
Fix an abort in junction_to_local_path
(This used to be commit 587bd636cb70d09600111ced040adaa55af35d0f)

13 years agoFix a crash in _dfs_Enum
Volker Lendecke [Sun, 22 Jun 2008 11:06:35 +0000 (13:06 +0200)]
Fix a crash in _dfs_Enum
(cherry picked from commit 4a996476297963d4cb300b4d45c23e83a493c339)
(This used to be commit 86cae83a7db87063ecd6e58eaa15f11441c45040)

13 years agoFix an uninitialized variable access in callers of parse_msdfs_symlink
Volker Lendecke [Sun, 22 Jun 2008 10:50:30 +0000 (12:50 +0200)]
Fix an uninitialized variable access in callers of parse_msdfs_symlink

At least form_junctions() does not initialize refcount, and I don't see it in
get_referred_path(). For the latters, the callers might initialize it. But even
if they did, I think parse_msdfs_symlink() should unconditionally return the
number of referrals it found. I don't think it makes sense to count them up
from somewhere else.
(This used to be commit 73172113484a2c6c9af014f59e84707716c61a7d)

13 years agoFix a double-closedir() in form_junctions()
Volker Lendecke [Sat, 21 Jun 2008 14:39:05 +0000 (16:39 +0200)]
Fix a double-closedir() in form_junctions()
(This used to be commit 1d7ad0dea7ebf7a46af6e695797e5132264307d6)

13 years agoAttempt to fix the darwin build
Volker Lendecke [Sat, 21 Jun 2008 14:15:02 +0000 (16:15 +0200)]
Attempt to fix the darwin build
(This used to be commit c919f5146990fa4b1b0cde79d55e5e3008b94e3f)

13 years agoUse "init_shared_module" instead of "init_module" for initializing .so's
Volker Lendecke [Fri, 20 Jun 2008 12:30:02 +0000 (14:30 +0200)]
Use "init_shared_module" instead of "init_module" for initializing .so's
(This used to be commit 0c2fd687b25e32d446ef799927db6933bc61223d)

13 years agoMake pipes_struct its own talloc ctx
Volker Lendecke [Fri, 20 Jun 2008 14:22:49 +0000 (16:22 +0200)]
Make pipes_struct its own talloc ctx
(This used to be commit 829b1ad4697f2f1ea008377d591456722dccd025)

13 years agoFix a SAFE_FREE/TALLOC_FREE mixup
Volker Lendecke [Fri, 20 Jun 2008 14:22:32 +0000 (16:22 +0200)]
Fix a SAFE_FREE/TALLOC_FREE mixup
(This used to be commit b39852f51313059899630ba63509fee904ba3613)

13 years agonet: Don't crash on invalid command line options.
Kai Blin [Fri, 20 Jun 2008 22:07:21 +0000 (00:07 +0200)]
net: Don't crash on invalid command line options.

This backs out the workaround Jerry added in
4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd.
Thanks for the catch.
(This used to be commit 20e0bb4800938863cb0aac1a19473748132043fc)

13 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.
(This used to be commit 8c87a4319cc83f55fb105cae81a8efbc3fb5b98b)

13 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:49:14 +0000 (12:49 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.
(This used to be commit 96325ff44dc404a68d4ebd423cf78210ec3ff902)

13 years agonet: Fix crash when specifying invalid options on the command line
root [Thu, 19 Jun 2008 17:14:32 +0000 (12:14 -0500)]
net: Fix crash when specifying invalid options on the command line
(This used to be commit 4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd)

13 years agoRemove current_user references from nttrans.c
Volker Lendecke [Thu, 19 Jun 2008 16:48:10 +0000 (18:48 +0200)]
Remove current_user references from nttrans.c
(This used to be commit 5f8a5e68ea166fbeda3af6e5ec381ec09d06f0f6)

13 years agoRemove current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:46:57 +0000 (18:46 +0200)]
Remove current_user references from trans2.c

This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.
(This used to be commit 5595cdf837edb82db69a3e57bcf3108be7feeeb8)

13 years agoRemove some current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:36:54 +0000 (18:36 +0200)]
Remove some current_user references from trans2.c
(This used to be commit 4c31cc0b62f532eafdc44398b29b773ad8cb0646)

13 years agoRemove reference to current_user from reply.c
Volker Lendecke [Thu, 19 Jun 2008 16:21:41 +0000 (18:21 +0200)]
Remove reference to current_user from reply.c
(This used to be commit e895e44cc7d675d128430fb53c138e5e8736e59f)

13 years agoWrap the unix token info in a unix_user_token in auth_serversupplied_info
Volker Lendecke [Thu, 19 Jun 2008 14:54:12 +0000 (16:54 +0200)]
Wrap the unix token info in a unix_user_token in auth_serversupplied_info

No functional change, this is a preparation for more current_user ref removal
(This used to be commit dcaedf345e62ab74ea87f0a3fa1e3199c75c5445)

13 years agoRemove the "current_user" arg from fsp_belongs_conn
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from fsp_belongs_conn

fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.
(This used to be commit 64e9372ab997739d46669c0cc4a4c6edb11d5e64)

13 years agoRemove the "current_user" arg from check_fsp
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from check_fsp

check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.
(This used to be commit 8d364c4c3311b406847158fc37e9208d298cf8ba)

13 years agoloadparm: use the return value of the special handlers in lp_load().
Michael Adam [Thu, 19 Jun 2008 15:21:04 +0000 (17:21 +0200)]
loadparm: use the return value of the special handlers in lp_load().

Up to now, the bool return value was silently ignored.

Michael
(This used to be commit c65d425fec964bc0b8778b596615a8bcce0378aa)

13 years agoloadparm: don't treat a missing include file as an error in handle_include().
Michael Adam [Thu, 19 Jun 2008 15:20:22 +0000 (17:20 +0200)]
loadparm: don't treat a missing include file as an error in handle_include().

Michael
(This used to be commit a8ef8870beb91fcd2745aa59de6c59b49ea00e39)

13 years agotestsuite: enable the testparm_s3 tests.
Michael Adam [Thu, 19 Jun 2008 15:19:21 +0000 (17:19 +0200)]
testsuite: enable the testparm_s3 tests.

Michael
(This used to be commit 0f5c13e5735990f4325f98156a7dc410276372fe)

13 years agotestsuite: add a testparm_s3 test script.
Michael Adam [Thu, 19 Jun 2008 15:14:39 +0000 (17:14 +0200)]
testsuite: add a testparm_s3 test script.

This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(This used to be commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)

13 years agotestsuite: update introductory comment to test_net_regsistry.sh
Michael Adam [Thu, 19 Jun 2008 11:52:49 +0000 (13:52 +0200)]
testsuite: update introductory comment to test_net_regsistry.sh

This is now used to test rpc and local access depending on
command line parameters.

Michael
(This used to be commit 73c17b630317b5019e5d5f2b989b8de081a73e07)

13 years agoRemove current_user_info reference from vfs_recycle.c
Volker Lendecke [Thu, 19 Jun 2008 13:48:05 +0000 (15:48 +0200)]
Remove current_user_info reference from vfs_recycle.c
(This used to be commit fdc03c0a5ba0da4fbc4610880e06150c11d4c737)

13 years agoRemove current_user_info reference from vfs_fake_perms.c
Volker Lendecke [Thu, 19 Jun 2008 13:46:44 +0000 (15:46 +0200)]
Remove current_user_info reference from vfs_fake_perms.c
(This used to be commit a227181e8d2ed0824a323a3d4b4cfda5e438f8ce)

13 years agoRemove current_user_info reference from vfs_expand_msdfs.c
Volker Lendecke [Thu, 19 Jun 2008 13:44:15 +0000 (15:44 +0200)]
Remove current_user_info reference from vfs_expand_msdfs.c
(This used to be commit 05a66980a9b5a7c6222ceb038d819d23fd172186)

13 years agocurrent_user is not used in vfs_aixacl2.c
Volker Lendecke [Thu, 19 Jun 2008 13:43:52 +0000 (15:43 +0200)]
current_user is not used in vfs_aixacl2.c
(This used to be commit 407136abdf45ad832382dba44e1c9a3b4f253f09)

13 years agoRWX on a file does not imply DELETE access
Volker Lendecke [Tue, 17 Jun 2008 14:22:43 +0000 (16:22 +0200)]
RWX on a file does not imply DELETE access

Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.
(This used to be commit 51b5364c2afb3a18df4bec2bc1624760ccc01676)

13 years agoFix checks in can_delete_file_in_directory()
Volker Lendecke [Thu, 19 Jun 2008 12:53:46 +0000 (14:53 +0200)]
Fix checks in can_delete_file_in_directory()

With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
(This used to be commit daa9b056645a45edfb3a70e3536011ebe5678970)

13 years agoRemove some code
Volker Lendecke [Thu, 19 Jun 2008 10:03:31 +0000 (12:03 +0200)]
Remove some code

Did not measure it, but I think a single write is better than a read and a
conditional branch
(This used to be commit abe1bed665ad8d1dbf9177dcbb9344b25df9594c)

13 years agoFix typo
Volker Lendecke [Thu, 19 Jun 2008 09:59:55 +0000 (11:59 +0200)]
Fix typo
(This used to be commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)

13 years agoFix the build on FreeBSD 4.6.2
Volker Lendecke [Thu, 19 Jun 2008 07:50:34 +0000 (09:50 +0200)]
Fix the build on FreeBSD 4.6.2
(This used to be commit 4f50cb63e9b565ae0747127baa651a1a1874298b)

13 years agoFix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy Allison [Wed, 18 Jun 2008 19:56:36 +0000 (12:56 -0700)]
Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.
(This used to be commit 8b26afdcddc75d3b9a97309757a97314b406cb59)

13 years agoRemove prototype of unimplemented smbc_chown() function.
Derrell Lipman [Wed, 18 Jun 2008 15:00:46 +0000 (11:00 -0400)]
Remove prototype of unimplemented smbc_chown() function.
(This used to be commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)

13 years agoRevert "Fix a memleak in svcctl_init_keys()"
Volker Lendecke [Wed, 18 Jun 2008 14:30:37 +0000 (16:30 +0200)]
Revert "Fix a memleak in svcctl_init_keys()"

This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)
(This used to be commit b1e8e5d173cdaa3fb9c1fb1d9aacf8e665bc5d61)

13 years agoFix Bug #5548 (segfauls in handle_include with %m macro expansion).
Michael Adam [Wed, 18 Jun 2008 12:50:53 +0000 (14:50 +0200)]
Fix Bug #5548 (segfauls in handle_include with %m macro expansion).

In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(This used to be commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)

13 years agofile_access: add a function header comment for can_access_file_acl().
Michael Adam [Tue, 17 Jun 2008 22:06:46 +0000 (00:06 +0200)]
file_access: add a function header comment for can_access_file_acl().

Michael
(This used to be commit 7d5fb873bde0a84de522650945effeaf602c759e)

13 years agosmbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
Michael Adam [Tue, 17 Jun 2008 22:02:28 +0000 (00:02 +0200)]
smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()

This is not needed anymore since user_can_access_file_acl() ist used.

Michael
(This used to be commit 3c349f773a52e3de693d3bb79f5060c9f1e01e41)

13 years agofile_access: remove unneeded stat buf parameter from can_access_file_acl().
Michael Adam [Tue, 17 Jun 2008 21:58:49 +0000 (23:58 +0200)]
file_access: remove unneeded stat buf parameter from can_access_file_acl().

This is a security descriptor level function only.

Michael
(This used to be commit 5931540fa1681f026fed42df387d17e43c493c47)

13 years agonet sam: fix typo in comment
Michael Adam [Tue, 17 Jun 2008 21:57:26 +0000 (23:57 +0200)]
net sam: fix typo in comment

Michael
(This used to be commit b9f6904044889328ded229b7ff04d31218f4fef8)

13 years agonet sam: fix typo in debug message.
Michael Adam [Tue, 17 Jun 2008 21:56:42 +0000 (23:56 +0200)]
net sam: fix typo in debug message.

Michael
(This used to be commit 6d7f64c3481d3aa7ec6b0d468f3d6218f62cd92e)

13 years agotestsuite: give admin rights to testuser only for the "net rpc registry" test.
Michael Adam [Tue, 17 Jun 2008 21:54:15 +0000 (23:54 +0200)]
testsuite: give admin rights to testuser only for the "net rpc registry" test.

Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(This used to be commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)

13 years agotestsuite: don't give the testuser administrative rights globally.
Michael Adam [Tue, 17 Jun 2008 21:51:23 +0000 (23:51 +0200)]
testsuite: don't give the testuser administrative rights globally.

It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(This used to be commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)

13 years agoFix a brown paper bag segfault in clitar
Volker Lendecke [Tue, 17 Jun 2008 19:08:56 +0000 (21:08 +0200)]
Fix a brown paper bag segfault in clitar

Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)
(This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)

13 years agorpcclient: add more generic internal dscracknames call.
Günther Deschner [Wed, 11 Jun 2008 08:12:29 +0000 (10:12 +0200)]
rpcclient: add more generic internal dscracknames call.

Guenther
(This used to be commit 2351b0845ca78707901daca6a6d0425959c6f28e)

13 years agonetapi: use NetUserEnum filter in example code.
Günther Deschner [Mon, 9 Jun 2008 09:02:27 +0000 (11:02 +0200)]
netapi: use NetUserEnum filter in example code.

Guenther
(This used to be commit ad105177686da823ef9cce1c1bedaf0f84a49b8c)

13 years agonetapi: add NetUserEnum filter constants to public headers.
Günther Deschner [Tue, 17 Jun 2008 11:13:10 +0000 (13:13 +0200)]
netapi: add NetUserEnum filter constants to public headers.

Guenther
(This used to be commit 32a66131eb56e1c66b89e348141047c6b98cf35e)

13 years agonetapi: implement NetUserEnum filters.
Günther Deschner [Mon, 9 Jun 2008 09:01:59 +0000 (11:01 +0200)]
netapi: implement NetUserEnum filters.

Guenther
(This used to be commit 0bd69df7704789888eba2a07aba505dce037c4eb)