kai/samba.git
15 years agobuild: add more structuring comments to Makefile.in
Michael Adam [Sun, 6 Jul 2008 10:51:04 +0000 (12:51 +0200)]
build: add more structuring comments to Makefile.in

for several shared libs and shared modules section

Michael
(This used to be commit 53cc6a3225c0c7baea4d8ea04eefc61283650434)

15 years agobuild: add structuring comments for libraries and libtalloc section.
Michael Adam [Sun, 6 Jul 2008 10:39:24 +0000 (12:39 +0200)]
build: add structuring comments for libraries and libtalloc section.

Michael
(This used to be commit 3de000890447dd15962fbd6a9b1b3504b9bd1175)

15 years agobuild: fix installlibtalloc to not install symlink if the library is not there
Michael Adam [Mon, 7 Jul 2008 14:16:28 +0000 (16:16 +0200)]
build: fix installlibtalloc to not install symlink if the library is not there

Michael
(This used to be commit 52ccb52c8e42e748fcc05337849945ddc30d5efa)

15 years agobuild: move libtalloc related targets together.
Michael Adam [Sun, 6 Jul 2008 00:52:09 +0000 (02:52 +0200)]
build: move libtalloc related targets together.

Michael
(This used to be commit 01b1e642d72ecccac5277b5f071aab8f6df04c0d)

15 years agobuild: add a cleanlibtalloc target.
Michael Adam [Sun, 6 Jul 2008 00:48:39 +0000 (02:48 +0200)]
build: add a cleanlibtalloc target.

Michael
(This used to be commit 5d3c6c3c1c08747c521292ef09648ad528c2dca9)

15 years agobuild: add an uninstalllibtalloc target
Michael Adam [Sun, 6 Jul 2008 00:40:19 +0000 (02:40 +0200)]
build: add an uninstalllibtalloc target

Michael
(This used to be commit 4b6ef6202cd9b6e1e8949c43d0c45c04d4b97438)

15 years agobuild: fix creation of link libtalloc.so on some systems.
Michael Adam [Sun, 6 Jul 2008 00:32:09 +0000 (02:32 +0200)]
build: fix creation of link libtalloc.so on some systems.

ln -s -f seem to be unknown on some solaris versions (e.g.).
so if there is an old libtalloc.so around, this will fail.
use rm -f prior to creating the link to circumvent this.

Michael
(This used to be commit d913b1e7316e84c1430f9d577f49d3c3e4e7719b)

15 years agobuild: fix the installlibtalloc target to install SONAME and \.so versions of shared...
Michael Adam [Sun, 6 Jul 2008 00:30:38 +0000 (02:30 +0200)]
build: fix the installlibtalloc target to install SONAME and \.so versions of shared lib.

Michael
(This used to be commit 49919889892f258cc669b08417e7569e8f5efaf4)

15 years agobuild: fix creation of talloc shared lib.
Michael Adam [Sun, 6 Jul 2008 00:29:02 +0000 (02:29 +0200)]
build: fix creation of talloc shared lib.

link the libtalloc.so.1 file and create libtalloc.so as a link

Michael
(This used to be commit 946537e6bec904d4a7937eeb6085dfac19c3e2b5)

15 years agobuild: add ability to use library files of the form NAME.so.VERSION to create version...
Michael Adam [Sun, 6 Jul 2008 00:26:57 +0000 (02:26 +0200)]
build: add ability to use library files of the form NAME.so.VERSION to create version script name.

Michael
(This used to be commit b8d13f8773f61863b71bfc9df468f0018b0db0d1)

15 years agoAllow authentication and memory credential refresh after password change from gdm...
Jeremy Allison [Mon, 7 Jul 2008 18:26:16 +0000 (11:26 -0700)]
Allow authentication and memory credential refresh after password change from gdm/xdm. Patch from boyang <boyang@novell.com>.
Jeremy.
(This used to be commit 8cfc6afc7b4a6af9aea5f5a7cb5af7e3218c2d75)

15 years agoClean up winbindd_group.c too
Simo Sorce [Sun, 6 Jul 2008 16:55:07 +0000 (12:55 -0400)]
Clean up winbindd_group.c too
(This used to be commit 50a347f5503ebed0fcc7b9de60f8368677585bb1)

15 years agoClean up the rest of the file too
Simo Sorce [Sun, 6 Jul 2008 16:27:34 +0000 (12:27 -0400)]
Clean up the rest of the file too
(This used to be commit f6c92c4759096f839e3854a1e9eea56e6eecad4d)

15 years agoMore clean up, indentation and trailing space removal
Simo Sorce [Sun, 6 Jul 2008 16:17:22 +0000 (12:17 -0400)]
More clean up, indentation and trailing space removal
(This used to be commit d17d401603c1c26a5fd5eca5ece245790445e6d4)

15 years agoMake code more readable, fix indentation and traling spaces.
Simo Sorce [Sun, 6 Jul 2008 16:03:35 +0000 (12:03 -0400)]
Make code more readable, fix indentation and traling spaces.
(This used to be commit e19e12d5cbba28ccf682eaf0ff26909bd7e8e6c6)

15 years agoTiny logic simplification -- remove an else branch
Volker Lendecke [Thu, 3 Jul 2008 21:34:28 +0000 (23:34 +0200)]
Tiny logic simplification -- remove an else branch
(This used to be commit 01c8c7bbf6163d5c7733db0d8ecbccfe7e4fec7d)

15 years agoMake use of ADD_TO_ARRAY
Volker Lendecke [Thu, 3 Jul 2008 21:29:49 +0000 (23:29 +0200)]
Make use of ADD_TO_ARRAY
(This used to be commit 81f334bd6da601a040f754c46705cfa2fd4f8c45)

15 years agoConvert idmap_cache to gencache
Volker Lendecke [Thu, 3 Jul 2008 21:12:22 +0000 (23:12 +0200)]
Convert idmap_cache to gencache
(This used to be commit 0bf0434f22b0ea46fda3ccc4dd612adbc88dd4f2)

15 years agoAdd SMB_VFS_OP_RECVFILE to get it in sync with vfs.h
Lars Müller [Fri, 4 Jul 2008 12:51:01 +0000 (14:51 +0200)]
Add SMB_VFS_OP_RECVFILE to get it in sync with vfs.h

Fix "vfs_full_audit.c: name table not in sync with vfs.h" panic reported
by Franz Sirl.
(This used to be commit 72b96b75a4a1b523540a24fb758b1965ad66009b)

15 years agoSlightly increase the default idmap cache time
Volker Lendecke [Thu, 3 Jul 2008 19:03:58 +0000 (21:03 +0200)]
Slightly increase the default idmap cache time
(This used to be commit 448836d44d0468a74b962ba3c0b7d51de236374f)

15 years agoIDMAP_READ_CACHE_DATA_FMT_TEMPLATE is unused, remove it
Volker Lendecke [Thu, 3 Jul 2008 18:39:22 +0000 (20:39 +0200)]
IDMAP_READ_CACHE_DATA_FMT_TEMPLATE is unused, remove it
(This used to be commit 2396d5d5d2f453f097f8ce77b640ad7e1d7e7c4c)

15 years agoSimplify idmap_cache_set() a bit
Volker Lendecke [Thu, 3 Jul 2008 02:59:36 +0000 (04:59 +0200)]
Simplify idmap_cache_set() a bit

sid_check_is_in_unix_* will only give true if it is of the corresponding type,
so the check if the struct idmap actually represents a user or group is
unnecessary.
(This used to be commit 55b976ba93462c6885e8d89edd13c32fb5529944)

15 years agoSimplify idmap_cache_build_[s]idkey a bit
Volker Lendecke [Thu, 3 Jul 2008 02:57:30 +0000 (04:57 +0200)]
Simplify idmap_cache_build_[s]idkey a bit
(This used to be commit 80932c0266ef73b8d0462c078a053444fff47f32)

15 years agoPatch from SATOH Fumiyasu <fumiyas@osstech.co.jp> for bug #5202. Re-activate "acl...
Jeremy Allison [Thu, 3 Jul 2008 17:24:12 +0000 (10:24 -0700)]
Patch from SATOH Fumiyasu <fumiyas@osstech.co.jp> for bug #5202. Re-activate "acl group control"
parameter and make it only apply to owning group. Also added man page fix.
Jeremy.
(This used to be commit e98e080bad2c8b9f038a8f2dffcfeba1d5f392ce)

15 years agoRemove an unused variable
Volker Lendecke [Thu, 3 Jul 2008 14:44:13 +0000 (16:44 +0200)]
Remove an unused variable
(This used to be commit 454cb852e06fa3d8bdd0eebb3ebdb24b3d74ecd0)

15 years agoRemove gencache_[un]lock_entry
Volker Lendecke [Thu, 3 Jul 2008 14:24:27 +0000 (16:24 +0200)]
Remove gencache_[un]lock_entry

Günther agreed that it might be unnecessary in dsgetdcname_cache_store() :-)
(This used to be commit 7a5a575ffe5196caecedc93970a25abfbe6f8059)

15 years agoReturn timed out entries from gencache_get if timeout param != NULL
Volker Lendecke [Thu, 3 Jul 2008 13:58:37 +0000 (15:58 +0200)]
Return timed out entries from gencache_get if timeout param != NULL

net cache get was the only one interested in the timeout. That single caller
can take care of the timeout itself then.

With this API change idmap_cache.c can be converted to gencache.
(This used to be commit 2954b2be563149380e1fae7fe088b98d6cbd42e7)

15 years agoPass NULL to gencache_get when we are not interested in the timeout value
Volker Lendecke [Thu, 3 Jul 2008 13:15:57 +0000 (15:15 +0200)]
Pass NULL to gencache_get when we are not interested in the timeout value
(This used to be commit 16062dfc3dcc8f1ca0024a3ae21effb889c7ffc0)

15 years agoFix indentation
Volker Lendecke [Thu, 3 Jul 2008 13:14:01 +0000 (15:14 +0200)]
Fix indentation
(This used to be commit c4e6de9e34e1ff76552ce6d4e72b343fb5f33306)

15 years agonetapi: fix doxygen warning.
Günther Deschner [Wed, 2 Jul 2008 11:09:23 +0000 (13:09 +0200)]
netapi: fix doxygen warning.

Guenther
(This used to be commit cfd59383d680e41a885e546842b0eb8585123acb)

15 years agolibnetjoin: fix Bug #5570.
Günther Deschner [Thu, 3 Jul 2008 10:01:36 +0000 (12:01 +0200)]
libnetjoin: fix Bug #5570.

Thanks to Atte Peltomäki.

Guenther
(This used to be commit 144d374ad9dd981430a82369ceaa2783e6dae90a)

15 years agoFix build warning.
Günther Deschner [Thu, 3 Jul 2008 09:09:32 +0000 (11:09 +0200)]
Fix build warning.

Thanks to Thorkil Olesen.

Guenther
(This used to be commit 3130aa63fd64c08c1d8be8338d6490aeb12c234a)

15 years agoDon't scream, better explain a bit in comments
Volker Lendecke [Thu, 3 Jul 2008 00:32:18 +0000 (02:32 +0200)]
Don't scream, better explain a bit in comments
(This used to be commit dcc39ed00453a075b23daece2844ca4817bfbfaf)

15 years agoMake use of sid_check_is_in_unix_users/groups
Volker Lendecke [Thu, 3 Jul 2008 00:26:43 +0000 (02:26 +0200)]
Make use of sid_check_is_in_unix_users/groups

Don't replicate code unnecessarily
(This used to be commit cd8e63b2b45402091d6d328b3c6ca593fc19ac92)

15 years agoRemove worrying warning message when safe_strcpy tries to copy a pseaudo interface
Jeremy Allison [Wed, 2 Jul 2008 23:31:16 +0000 (16:31 -0700)]
Remove worrying warning message when safe_strcpy tries to copy a pseaudo interface
name that's too long. Reported by James Kosin <JKosin@intcomgrp.com>.
Jeremy.
(This used to be commit 3a7542fd495223c3a504571a52e2d00551fea0e2)

15 years agoCanonicalize servername in the printer functions to remove leading '\\' characters...
Jeremy Allison [Wed, 2 Jul 2008 23:11:59 +0000 (16:11 -0700)]
Canonicalize servername in the printer functions to remove leading '\\' characters. Ensure we always return consistent names.
Jeremy.
(This used to be commit fc2178b04743d2f94be7b489b793fc67826557ac)

15 years agoFix bug #5578, reported by sendel2000@hotbox.ru. Bad (non-Samba) use of strlcat gives...
Jeremy Allison [Wed, 2 Jul 2008 18:57:13 +0000 (11:57 -0700)]
Fix bug #5578, reported by sendel2000@hotbox.ru. Bad (non-Samba) use of strlcat gives error.
Jeremy.
(This used to be commit d7c82997bdcf1acd7ac104efa0ad05e0b94935ea)

15 years agoEnsure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
Jeremy Allison [Wed, 2 Jul 2008 17:51:45 +0000 (10:51 -0700)]
Ensure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
Reported by hongbing Zhang <hongbing.zhang@gmail.com>.
Jeremy.
(This used to be commit ade27d8baa03816b6f5f480096dfb90f3e231e6a)

15 years agoFix typo
Volker Lendecke [Wed, 2 Jul 2008 13:13:14 +0000 (15:13 +0200)]
Fix typo
(This used to be commit fe79c8a5b726754703626ca0bff57074274c98c7)

15 years agoTiny logic simplification: Remove an unnecessary else branch
Volker Lendecke [Wed, 2 Jul 2008 13:13:01 +0000 (15:13 +0200)]
Tiny logic simplification: Remove an unnecessary else branch
(This used to be commit 6009ae329375b1c40e3d00df977ddccc8b5cc176)

15 years agoFix nonempty whitespace only lines
Volker Lendecke [Wed, 2 Jul 2008 13:04:46 +0000 (15:04 +0200)]
Fix nonempty whitespace only lines
(This used to be commit cc77db2acbc35cea58576f1e28c7a760a5e31609)

15 years agofix typos
Volker Lendecke [Wed, 2 Jul 2008 12:53:57 +0000 (14:53 +0200)]
fix typos
(This used to be commit e0957c6f4b1e81c27fda1de7fb7cbc9c585f5ac9)

15 years agoFix nonempty whitespace only lines
Volker Lendecke [Wed, 2 Jul 2008 12:06:49 +0000 (14:06 +0200)]
Fix nonempty whitespace only lines
(This used to be commit 0da9d0d0f9662d8bd2f370f764d5a875e11b3068)

15 years agoFix indentation
Volker Lendecke [Wed, 2 Jul 2008 12:06:09 +0000 (14:06 +0200)]
Fix indentation
(This used to be commit 954556b527aa652f9a46f0d48834e92befb3c5f9)

15 years agoFix a debug msg, this was probably a leftover from gencache
Volker Lendecke [Wed, 2 Jul 2008 12:04:52 +0000 (14:04 +0200)]
Fix a debug msg, this was probably a leftover from gencache
(This used to be commit daa171552dc00d9602a05ba199c9a3ff24c802f5)

15 years agoFix typo
Volker Lendecke [Wed, 2 Jul 2008 12:03:25 +0000 (14:03 +0200)]
Fix typo
(This used to be commit fe58926283b51910d8587e32bb11aa681b9a27d3)

15 years agoMake idmap_init() static
Volker Lendecke [Wed, 2 Jul 2008 11:33:25 +0000 (13:33 +0200)]
Make idmap_init() static

This is called only from idmap_alloc_init, which feels kindof weird.

Digging deeper in the code...
(This used to be commit c8d1bbfddce41cd6bf37dd0a622ef3437a24b492)

15 years agoFix two memory leaks in an error path in idmap.c
Volker Lendecke [Wed, 2 Jul 2008 10:22:15 +0000 (12:22 +0200)]
Fix two memory leaks in an error path in idmap.c
(This used to be commit 7cec389e19323e99b6b6258e539be9d1fd65810f)

15 years agoMSG_DEBUG now forwarded to all the winbindd children by parent.
Darshan Purandare [Tue, 1 Jul 2008 18:37:13 +0000 (11:37 -0700)]
MSG_DEBUG now forwarded to all the winbindd children by parent.

smbcontrol winbindd debug level would only set the debug level of the
parent winbindd process and not the child processes. This patch adds
the functionality of broadcasting the debug message to all winbindd
children. Now the debug level message is propagated to all the winbindd
processes that includes parent and children.
(This used to be commit cfbcfc3ffe74f28ec874a6bf1ab93f55f405b6e6)

15 years agoJim Brown <jim.brown@miami.edu> was right, this needs to be a signed int or
Jeremy Allison [Tue, 1 Jul 2008 22:51:54 +0000 (15:51 -0700)]
Jim Brown <jim.brown@miami.edu> was right, this needs to be a signed int or
the loop never terminates.
Jeremy.
(This used to be commit 80e547665d104a6db376ff4c48bcc01dfd3513ee)

15 years agoTwo more fixes from Jim Brown <jim.brown@miami.edu> for SGI compiler warnings.
Jeremy Allison [Tue, 1 Jul 2008 22:39:41 +0000 (15:39 -0700)]
Two more fixes from Jim Brown <jim.brown@miami.edu> for SGI compiler warnings.
Jeremy.
(This used to be commit d85cbdbe296ec6de5bdbd66a90ca41345f55c837)

15 years agoFix problem noticed by Jim Brown <jim.brown@miami.edu>. When reverse searching decrem...
Jeremy Allison [Tue, 1 Jul 2008 22:28:13 +0000 (15:28 -0700)]
Fix problem noticed by Jim Brown <jim.brown@miami.edu>. When reverse searching decrement index,
not increment. Michael please check !
Jeremy.
(This used to be commit d89f9d404f478fc9887bb6e67ce28a61464bcf93)

15 years agoRevert "winbind cache: Don't create SN cache entries during name-to-sid queries."
Karolin Seeger [Tue, 1 Jul 2008 08:34:22 +0000 (10:34 +0200)]
Revert "winbind cache: Don't create SN cache entries during name-to-sid queries."

This reverts commit b58e4f6b3d73294d8448c0dff4341183c52e5b7c.

Details can be found on the samba-technical mailing list.

Karolin
(This used to be commit 534a445df450c681be7da2c9dd65f7294f942b08)

15 years agonet_vampire: add code to vampire to a Kerberos keytab file using DRSUAPI.
Günther Deschner [Fri, 27 Jun 2008 13:36:19 +0000 (15:36 +0200)]
net_vampire: add code to vampire to a Kerberos keytab file using DRSUAPI.

Guenther
(This used to be commit 0ef420c3a478a8adce7483f14b45e9995bfa5e5d)

15 years agonet_vampire: keep keytab context and flush keytab only after the last query.
Günther Deschner [Fri, 27 Jun 2008 13:54:01 +0000 (15:54 +0200)]
net_vampire: keep keytab context and flush keytab only after the last query.

Guenther
(This used to be commit 48efe7dbce1cde6689f94fafe2d7756f673bc050)

15 years agoFix from Atte Peltomäki - atte.peltomaki@f-secure.com to correctly check
Jeremy Allison [Mon, 30 Jun 2008 16:20:05 +0000 (09:20 -0700)]
Fix from Atte Peltomäki - atte.peltomaki@f-secure.com to correctly check
error code in winbindd group expansion.
Jeremy.
(This used to be commit e321377174f579ba57a70f260f4d4bc234a07439)

15 years agokerberos: allow to keep entries with old kvno's while creating keytab.
Günther Deschner [Mon, 30 Jun 2008 08:32:15 +0000 (10:32 +0200)]
kerberos: allow to keep entries with old kvno's while creating keytab.

Guenther
(This used to be commit 6194244bd9fcc1fb736f3d91433f107270cac1c9)

15 years agokerberos: rename smb_krb5_kt_add_entry to smb_krb5_kt_add_entry_ext.
Günther Deschner [Mon, 30 Jun 2008 08:29:15 +0000 (10:29 +0200)]
kerberos: rename smb_krb5_kt_add_entry to smb_krb5_kt_add_entry_ext.

Guenther
(This used to be commit 48600a0019d70d22574cf08e8fe19d44cc332a0f)

15 years agoFix a file descriptor leak in add_port_hook
Volker Lendecke [Sat, 28 Jun 2008 14:09:34 +0000 (16:09 +0200)]
Fix a file descriptor leak in add_port_hook

This was probably cut&paste from add_printer_hook which further down has the
unconditional close(fd). In add_port_hook() we're not interested in the output
of 'addport command', so don't create the out fd.
(cherry picked from commit 0c5ca2127ac6e3c71e369242376d27429c3aee5e)
(This used to be commit 9fe09398b79ae7c5e78182112a8cd2c9b5f99ad3)

15 years agoReturn NULL in sitename_fetch() if gencache_init() fails. Not false
Gerald W. Carter [Sat, 28 Jun 2008 13:35:07 +0000 (09:35 -0400)]
Return NULL in sitename_fetch() if gencache_init() fails.  Not false
(This used to be commit 8704c2ab37479236788c0a99465d73643d3d555a)

15 years agoLet send_trans_reply work on only the inbuf
Volker Lendecke [Wed, 2 Apr 2008 13:55:10 +0000 (15:55 +0200)]
Let send_trans_reply work on only the inbuf

It does not really need the whole smb_request
(This used to be commit d3facf4cbdb2915168e91d64c2d8320f67524df8)

15 years agoFactor out create_outbuf, creating an outbuf just given an inbuf
Volker Lendecke [Wed, 2 Apr 2008 13:34:29 +0000 (15:34 +0200)]
Factor out create_outbuf, creating an outbuf just given an inbuf
(This used to be commit 50427cbf6345d3f671e9ea321089c4b4244df972)

15 years agoFix the build
Volker Lendecke [Sat, 28 Jun 2008 08:38:33 +0000 (10:38 +0200)]
Fix the build
(This used to be commit 242077f714c738642edd125449ab5c89748bcecd)

15 years agoFix bug #5568 net rpc trustdom add broken !
Jeremy Allison [Sat, 28 Jun 2008 00:26:41 +0000 (17:26 -0700)]
Fix bug #5568 net rpc trustdom add broken !
net rpc trustdom add was broken. The default 10second timeout can be too short
to create an account on a Samba DC (calling out to a script), error message
reporting was poor, and more importantly the new marshalling code for
user_info23 was broken (maps onto a user_info21 but doesn't clear the
user_info23 struct before marshalling, leaving an uninitialized size field -
give "alloc failure").
Jeremy.
(This used to be commit e072b3667e590ba6dd1d9a47fb616a53753fa83e)

15 years agoFix usage message for net rpc trustdom add.
Jeremy Allison [Fri, 27 Jun 2008 22:28:45 +0000 (15:28 -0700)]
Fix usage message for net rpc trustdom add.
Jeremy.
(This used to be commit 20e59faf6efce01887cd01f0cafb197cc2f4742e)

15 years agoDo not segfault if corepath is not set up properly
Volker Lendecke [Fri, 13 Jun 2008 09:56:40 +0000 (11:56 +0200)]
Do not segfault if corepath is not set up properly
(This used to be commit 41d1b9541ccb802f01f12038b3b81853b3b7c32d)

15 years agolibads: Add API call to connect to a global catalog server.
Gerald W. Carter [Fri, 27 Jun 2008 14:22:39 +0000 (10:22 -0400)]
libads: Add API call to connect to a global catalog server.

Extends ads_connect() to a new call ads_connect_gc() which connects on port
3268 rather than port 389.  Also makes ads_try_connect() static and
only used internally to ldap.c
(This used to be commit f4c37dbe2c986fb7bfe510cdff3b4a9fbc06d079)

15 years agoFix warnings on SuSE 9.0.
Karolin Seeger [Fri, 27 Jun 2008 13:51:35 +0000 (15:51 +0200)]
Fix warnings on SuSE 9.0.

The macros "[un]likely" are already defined on SuSE 9.0.
Patch from Volker.
(This used to be commit 30d181c92463aecd6e649330d3645d86d5a17e43)

15 years agoRevert "build: add symbol versioning when we build with gnu ld"
Karolin Seeger [Mon, 9 Jun 2008 06:39:12 +0000 (08:39 +0200)]
Revert "build: add symbol versioning when we build with gnu ld"

This reverts commit cb5492978b6b157f529806afb2f5fc6202888129.

For more information, please have a look at the discussion on
samba-technical starting with [1].

[1] http://lists.samba.org/archive/samba-technical/2008-June/059511.html

Karolin
(cherry picked from commit 1e5aeb96f92fef8056ec9010e125f4d0d31dd90e)
(This used to be commit d06baf0e744d779b836783f61ec97d3a6d380eb5)

15 years agoFix two IBM checker warnings
Volker Lendecke [Fri, 27 Jun 2008 09:22:23 +0000 (11:22 +0200)]
Fix two IBM checker warnings

Steve, please check!

Thanks,

Volker
(This used to be commit 5222b8db3fb692e5071bfd1b41849a8eb0a17995)

15 years agoFix an "invalid operation involving NULL pointer" found by the IBM checker
Volker Lendecke [Fri, 27 Jun 2008 09:19:26 +0000 (11:19 +0200)]
Fix an "invalid operation involving NULL pointer" found by the IBM checker

Jerry, please check!

Volker
(This used to be commit eb6096a2d488d64cfa86e01be2a97e14e5773fe3)

15 years agoRemove a strlen check that will never kick in
Volker Lendecke [Fri, 27 Jun 2008 09:13:07 +0000 (11:13 +0200)]
Remove a strlen check that will never kick in

strlen(str)<2 will be caught by the explicit tests for str[0] and str[1] in the
lines above this.

Jerry, please check!

Volker
(This used to be commit 44a9e5b713c25ff2cc7215635a516f25359b045b)

15 years agoFix the non-LDAP, non-krb5 build, fix gcc -O3 warnings.
Jeremy Allison [Fri, 27 Jun 2008 02:46:18 +0000 (19:46 -0700)]
Fix the non-LDAP, non-krb5 build, fix gcc -O3 warnings.
Jeremy.
(This used to be commit 9e2ab30d3cf6950fc79152b2169e7aeae8d6a366)

15 years agolibnet_dssync: add last_query flag to processing routine.
Günther Deschner [Thu, 26 Jun 2008 23:41:26 +0000 (01:41 +0200)]
libnet_dssync: add last_query flag to processing routine.

Guenther
(This used to be commit 22bdee7fe0cdcd95e0bade70cacb095e0b348abf)

15 years agolibnet_dssync: add output filename and dns_domain_name to dssync struct.
Günther Deschner [Thu, 26 Jun 2008 21:24:25 +0000 (23:24 +0200)]
libnet_dssync: add output filename and dns_domain_name to dssync struct.

Guenther
(This used to be commit c16e1820f86f105853aa855eda322ba6cbff3a84)

15 years agonet_vampire: use bool for last_query information in samsync.
Günther Deschner [Thu, 26 Jun 2008 22:46:38 +0000 (00:46 +0200)]
net_vampire: use bool for last_query information in samsync.

Guenther
(This used to be commit fa1976e23a33bd3fab17c3f6ab5573ee1fdf9e31)

15 years agonet_vampire: separate keytab code from samsync code.
Günther Deschner [Thu, 26 Jun 2008 19:48:41 +0000 (21:48 +0200)]
net_vampire: separate keytab code from samsync code.

Guenther
(This used to be commit 69d8442bf3248f97ad23def424901d7fa87bfe48)

15 years agoFrom Steve Danneman @ Isilon.
Jeremy Allison [Thu, 26 Jun 2008 21:02:39 +0000 (14:02 -0700)]
From Steve Danneman @ Isilon.

Attached is the companion patch to
(037b9689d9042a398cb91e4628a82fcdfa913c21), which
made handling of WINBINDD_LIST_GROUPS asynchronous.

Because most all of the list_groups code was reusable, I abstracted it,
and implemented both list_groups and list_users on top of it.

On my large test domain a "wbinfo -u" call went from 70 seconds to 30
seconds with this patch.  Plus, the parent process is no longer blocked
from receiving new requests during that time.

Steven Danneman | Software Development Engineer
Isilon Systems    P +1-206-315-7500     F +1-206-315-7501
www.isilon.com
(This used to be commit 5188f2861137ff06d5399561d55d7d00c3a08644)

15 years agoFix return of uninitialized variable.
Jeremy Allison [Thu, 26 Jun 2008 20:19:40 +0000 (13:19 -0700)]
Fix return of uninitialized variable.
Jeremy.
(This used to be commit 384052f546af8c1c6848c03cad4f2ba618ba7209)

15 years agolibnet_dssync: pass down drsuapi_DsReplicaOIDMapping_Ctr to callback.
Günther Deschner [Thu, 26 Jun 2008 13:10:00 +0000 (15:10 +0200)]
libnet_dssync: pass down drsuapi_DsReplicaOIDMapping_Ctr to callback.

Guenther
(This used to be commit cbff970facae295650742d12768f23c7f67380a6)

15 years agolibnet_dssync: always decrypt attributes before passing them to the processing routine.
Günther Deschner [Thu, 26 Jun 2008 13:06:58 +0000 (15:06 +0200)]
libnet_dssync: always decrypt attributes before passing them to the processing routine.

Guenther
(This used to be commit 6eedd167e77969e2ab7d5abe7311de62fc413d17)

15 years agoFix valgrind errors in _spoolss_addprinterdriver
Volker Lendecke [Thu, 26 Jun 2008 14:51:45 +0000 (16:51 +0200)]
Fix valgrind errors in _spoolss_addprinterdriver

Jerry, this was dropped as part of your SVN r15309 (037f9f83). Can you please
check?

Thanks,

Volker
(cherry picked from commit 5aa2411f0b3720b790439359a2dadb23008e936e)
(This used to be commit 8e7effd58f7790d6e71e38c990f6cb05456e47e1)

15 years agoFix a segfault in rpcclient adddriver
Volker Lendecke [Thu, 26 Jun 2008 13:32:27 +0000 (15:32 +0200)]
Fix a segfault in rpcclient adddriver
(cherry picked from commit d4b5a9d67389578f531527b339f6feead62f082d)
(This used to be commit 8573032877317fe1f5c69e9ced5b19a33d8aefb0)

15 years agoFix a debug message
Volker Lendecke [Thu, 26 Jun 2008 11:32:11 +0000 (13:32 +0200)]
Fix a debug message
(This used to be commit 8dd94d448bc5ad067024c56c6ef498bc88a396b2)

15 years agoremove unused extern current_user from nt_printing.c
Volker Lendecke [Tue, 24 Jun 2008 15:04:02 +0000 (17:04 +0200)]
remove unused extern current_user from nt_printing.c
(This used to be commit b34283adeffaa6e481c57926709ea80d48733ef0)

15 years agoRemove current_user reference from printfsp.c
Volker Lendecke [Tue, 24 Jun 2008 14:58:29 +0000 (16:58 +0200)]
Remove current_user reference from printfsp.c
(This used to be commit 510f45d01a19ce1c226755ac42a328241098b2e0)

15 years agoremove unused extern current_user from lanman.c
Volker Lendecke [Tue, 24 Jun 2008 14:58:12 +0000 (16:58 +0200)]
remove unused extern current_user from lanman.c
(This used to be commit e2009c0b8dc229faf98ce189d2a906e58d3e1e63)

15 years agoChange print_access_check to take auth_serversupplied_info instead of current_user
Volker Lendecke [Tue, 24 Jun 2008 14:03:28 +0000 (16:03 +0200)]
Change print_access_check to take auth_serversupplied_info instead of current_user

Reason: This is the main user of p->current_user which I would like to remove
(This used to be commit fd43059b3dfa8cdac9814de1c76f963ba5de9bcb)

15 years agoRemove p->vuid
Volker Lendecke [Tue, 24 Jun 2008 13:24:08 +0000 (15:24 +0200)]
Remove p->vuid

The users can use p->server_info.

Now pipes_struct is decoupled from the SMB transport.
(This used to be commit d4cf5a131919530317cd457006b4df5af2c69fa7)

15 years agoRemove a check on p->vuid in _netr_LogonSamLogon/off
Volker Lendecke [Tue, 24 Jun 2008 13:21:46 +0000 (15:21 +0200)]
Remove a check on p->vuid in _netr_LogonSamLogon/off

This is in preparation of removing p->vuid completely. I don't think this check
here makes any sort of sense, it only proves that the user having done the
session setup on its way to the schannel bind (ususally anonymous) did not do a
logoff in between. But this would have been caught way before this in
reply_pipe_write_and_X.
(This used to be commit fbc00460f8deaa57bfbf16b12d29acec56578b63)

15 years agoNow that we have p->server_info, use p->server_info->user_session_key
Volker Lendecke [Tue, 24 Jun 2008 12:33:31 +0000 (14:33 +0200)]
Now that we have p->server_info, use p->server_info->user_session_key
(This used to be commit aefad64e3a5c86d2f988d47e6215ed2085b8fc47)

15 years agoFix typo
Volker Lendecke [Tue, 24 Jun 2008 12:25:23 +0000 (14:25 +0200)]
Fix typo
(This used to be commit 41d2daeaa5a87da82a0debc4c9cfe14976215bd8)

15 years agoAdd server_info to pipes_struct
Volker Lendecke [Tue, 24 Jun 2008 12:18:55 +0000 (14:18 +0200)]
Add server_info to pipes_struct
(This used to be commit d621867bb8767e1c4236d28dd9294a61db6cbb10)

15 years agoctdbd_connect: bump debug level to 1 for "connect failed" message.
Michael Adam [Tue, 24 Jun 2008 13:09:37 +0000 (15:09 +0200)]
ctdbd_connect: bump debug level to 1 for "connect failed" message.

Leave level 0 message for higher level callers.

Michael
(This used to be commit fee770e5d080b0513418e61e469f2824a1d771ec)

15 years agomessages: bump debug level to 1 for "messaging_ctdb_init failed".
Michael Adam [Tue, 24 Jun 2008 13:08:21 +0000 (15:08 +0200)]
messages: bump debug level to 1 for "messaging_ctdb_init failed".

Leave level 0 messages to higher level callers.

Michael
(This used to be commit 7bbf29137bf051044cbf0db8d9fe564a7c9d7a29)

15 years agonmbd: untangle logic in nmbd_messaging_context() slightly.
Michael Adam [Tue, 24 Jun 2008 10:46:13 +0000 (12:46 +0200)]
nmbd: untangle logic in nmbd_messaging_context() slightly.

Michael
(This used to be commit 3baf9eb6a2cc6a4a153303b457d3a7067948495e)

15 years agonmbd: don't panic if messaging_init() fails - return NULL instead.
Michael Adam [Tue, 24 Jun 2008 10:44:50 +0000 (12:44 +0200)]
nmbd: don't panic if messaging_init() fails - return NULL instead.

Michael
(This used to be commit e6a403209c29bd2ec2242d654ad45276de02cb44)

15 years agowinbind: remove duplicate debug message for failing messaging_init().
Michael Adam [Tue, 24 Jun 2008 10:34:49 +0000 (12:34 +0200)]
winbind: remove duplicate debug message for failing messaging_init().

Leave the message inside winbind_messaging_context() for now.
There might be callers, where this debug message could prove useful...

Michael
(This used to be commit e9177ec56a8fe596d6fcfc4a95df87e39f757818)

15 years agowinbind: untangle logic in winbind_messaging_context() slightly.
Michael Adam [Tue, 24 Jun 2008 10:30:38 +0000 (12:30 +0200)]
winbind: untangle logic in winbind_messaging_context() slightly.

Michael
(This used to be commit e710a9b73ea2fd176de7093125bc5f3f3f3a9404)

15 years agowinbindd: don't panic if messaging_init() fails - return NULL instead.
Michael Adam [Tue, 24 Jun 2008 10:29:05 +0000 (12:29 +0200)]
winbindd: don't panic if messaging_init() fails - return NULL instead.

Leave appropriate handling to the callers.

Michael
(This used to be commit 3e0c24323af5f10fa68ae8aad552b7346536c908)