Michael Adam [Wed, 12 Oct 2011 10:03:42 +0000 (12:03 +0200)]
s3:dbwrap_ctdb: fix check for skipping the __db_sequence_number__ in traverse
Brown paperbag. This omitted the "== 0" hand hence skipped all keys of the
same length as __db_sequence_number__ but different from it...
Jelmer Vernooij [Wed, 12 Oct 2011 18:12:26 +0000 (20:12 +0200)]
samba.upgrade: Use list comprehension.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Oct 12 22:44:40 CEST 2011 on sn-devel-104
Volodymyr Khomenko [Wed, 12 Oct 2011 16:57:57 +0000 (09:57 -0700)]
Fix bug #8515 - Empty CIFS share can be blocked for other clients by deleting it via empty path (DELETE_PENDING until the last client)
Disallow "." in can_set_delete_on_close().
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 12 21:07:27 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 12 Oct 2011 16:43:18 +0000 (09:43 -0700)]
Fix bug #8521 - winbindd cache timeout expiry test was reversed
Found and fix reported by Micha Lenk <micha@lenk.info>. Thanks !
Simo Sorce [Mon, 26 Sep 2011 21:55:47 +0000 (17:55 -0400)]
s3-group-mapping: Remove fstrings from GROUP_MAP.
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 12 19:28:12 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 12 Oct 2011 09:48:55 +0000 (11:48 +0200)]
s3-dbwrap_ctdb: fix the build.
Michael, please check.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 12 15:25:56 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 12 Oct 2011 09:17:57 +0000 (11:17 +0200)]
s3-groupdb: split out groupdb/mapping_tdb.h.
Guenther
Andreas Schneider [Tue, 11 Oct 2011 14:41:24 +0000 (16:41 +0200)]
selftest: Fix plugin_s4_dc configuration.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 12 13:50:10 CEST 2011 on sn-devel-104
Kai Blin [Wed, 12 Oct 2011 06:17:02 +0000 (08:17 +0200)]
s3 waf: Use upper case uselib_store parameter, otherwise the following checks won't find it
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Oct 12 09:49:50 CEST 2011 on sn-devel-104
Gregor Beck [Fri, 23 Sep 2011 09:58:35 +0000 (11:58 +0200)]
s3:dbwrap: remove m_all marshall buffer from ctdb transaction.
it was only used by ctdb_replay_transaction and was a actually write only
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Oct 12 05:20:36 CEST 2011 on sn-devel-104
Gregor Beck [Thu, 22 Sep 2011 11:58:24 +0000 (13:58 +0200)]
s3:dbwrap: traverse records created within this transaction.
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Fri, 30 Sep 2011 13:42:31 +0000 (15:42 +0200)]
s3:registry: improve regdb_create_subkey_internal() to always complete incomlete keys
Originally, this function did not create the key's subkey list record if only
the record was listed in the subkeylist of its parent key. Now this is fixed.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Gregor Beck [Tue, 14 Jun 2011 11:19:59 +0000 (13:19 +0200)]
s3:smbcacls fix leaking talloc stackframce on tcon failure
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 14 Jun 2011 11:56:22 +0000 (13:56 +0200)]
s3:smbcacls fix possible SEGFAULT
sddl_encode returns NULL on failure
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Thu, 9 Jun 2011 13:29:32 +0000 (15:29 +0200)]
s3:smbcacls add option domain-sid
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Thu, 9 Jun 2011 12:32:27 +0000 (14:32 +0200)]
s3:smbcacls get_domain_sid for sddl parsing/formating from lsarpc
get_global_sid panics if we are not root and may give the wrong answer anyway.
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 7 Jun 2011 08:54:16 +0000 (10:54 +0200)]
s3:smbcacls pretty print acl control field
Signed-off-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Wed, 12 Oct 2011 00:00:08 +0000 (17:00 -0700)]
Add new contributing FAQ announcing acceptance of corporate (C).
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 12 03:46:41 CEST 2011 on sn-devel-104
Jelmer Vernooij [Tue, 11 Oct 2011 21:56:15 +0000 (23:56 +0200)]
samba.getopt: Allow --kerberos=auto, and fix exception name if an unknown
value is specified.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Oct 12 02:12:21 CEST 2011 on sn-devel-104
Jelmer Vernooij [Tue, 11 Oct 2011 21:53:59 +0000 (23:53 +0200)]
s4/param: Expose lpcfg_smb_ports and lpcfg_socket_options, which are both required by winexe.
Jelmer Vernooij [Tue, 11 Oct 2011 21:51:37 +0000 (23:51 +0200)]
param: Expose lpcfg_smb_ports, required by winexe.
Günther Deschner [Tue, 11 Oct 2011 17:20:05 +0000 (19:20 +0200)]
s3-waf: make sure we build example vfs modules with --enable-developer.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct 11 21:22:55 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 11 Oct 2011 13:20:42 +0000 (15:20 +0200)]
s3-waf: fix configure check for HAVE_LINUX_READAHEAD.
Guenther
Günther Deschner [Tue, 11 Oct 2011 13:18:08 +0000 (15:18 +0200)]
s3-waf: fix configure check for HAVE_LINUX_FALLOCATE64.
Guenther
Günther Deschner [Tue, 11 Oct 2011 13:17:28 +0000 (15:17 +0200)]
s3-waf: fix configure check for HAVE_LINUX_FALLOCATE.
Guenther
Günther Deschner [Tue, 11 Oct 2011 13:03:01 +0000 (15:03 +0200)]
s3-waf: fix configure check for HAVE_POSIX_FADVISE.
Guenther
Jeremy Allison [Tue, 11 Oct 2011 16:18:46 +0000 (09:18 -0700)]
Fix the VFS for fsctl.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Oct 11 19:49:22 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 11 Oct 2011 13:38:43 +0000 (15:38 +0200)]
lib/param: fix typo _SAMBA_BUILD => _SAMBA_BUILD_ causing segfaults
If lpcfg_dns_update_command() returns NULL 'samba' segfaults on startup.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 11 17:25:19 CEST 2011 on sn-devel-104
Stefan Metzmacher [Tue, 11 Oct 2011 13:32:36 +0000 (15:32 +0200)]
script/autobuild.py: split 'samba3' 'make -j 4 everything' into multiple steps
Calling 'waf configure' while compiling .c files makes it very hard to
find compile errors. We do 'make -j 4 bin/smbtorture4' before 'make -j 4 everything'.
metze
Michael Adam [Thu, 6 Oct 2011 19:29:04 +0000 (21:29 +0200)]
s3:dbwrap: change dbwrap_store_uint32() to NTSTATUS return type
for consistency and better error propagation
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Oct 11 15:51:00 CEST 2011 on sn-devel-104
Michael Adam [Thu, 6 Oct 2011 19:24:07 +0000 (21:24 +0200)]
s3:dbwrap: change dbwrap_store_int32() to NTSTATUS return type
for consistency and better error propagation
Michael Adam [Thu, 6 Oct 2011 19:07:27 +0000 (21:07 +0200)]
s3:dbwrap: change dbwrap_fetch_uint32() to NTSTATUS return type (instead of bool)
for consistency and better error propagation
Michael Adam [Thu, 6 Oct 2011 18:34:55 +0000 (20:34 +0200)]
s3:dbwrap: convert dbwrap_fetch_int32() to NTSTATUS return code
Return the int32 value retrieved from the db by reference.
Before this, return value "-1" was used as a error indication,
but it could also be a valid value from the database.
Michael Adam [Thu, 6 Oct 2011 18:28:39 +0000 (20:28 +0200)]
s3:idmap_tdb2: fix hwm-handling to use uint32 consistently
The initialization code user int32, later writes used uint32...
Michael Adam [Thu, 6 Oct 2011 18:19:41 +0000 (20:19 +0200)]
s3:idmap_tdb: fix hwm-handling to use uint32 consistently
The initialization code user int32, later writes used uint32...
Michael Adam [Thu, 6 Oct 2011 18:00:17 +0000 (20:00 +0200)]
s3:passdb:account_pol: use dbwrap_fetch_uint32, not dbwrap_fetch_int32 for the DB version
This is also stored as uint32_t.
Michael Adam [Thu, 6 Oct 2011 17:22:51 +0000 (19:22 +0200)]
s3:idmap_autorid: make a debug message more precise
Michael Adam [Thu, 6 Oct 2011 17:17:25 +0000 (19:17 +0200)]
s3:idmap_autorid: untangle function from check and log status in idmap_autorid_db_init()
Michael Adam [Wed, 24 Aug 2011 12:53:42 +0000 (14:53 +0200)]
s3:dbwrap: move definitions of db_record and db_contect structs to dbwrap_private.h
The API and callers now only need the forward declarations.
Michael Adam [Thu, 25 Aug 2011 08:59:06 +0000 (10:59 +0200)]
s3:torture: convert torture.c to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 23:22:43 +0000 (01:22 +0200)]
s3:locking: convert posix.c to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:28:12 +0000 (11:28 +0200)]
s3:locking: convert locking.c to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:53:58 +0000 (10:53 +0200)]
s3:locking: convert brlock to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:47:46 +0000 (15:47 +0200)]
s3:messages: convert to use only dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:18:49 +0000 (11:18 +0200)]
s3:groupdb: convert mapping_tdb.c to use dbwrap wrapper functions only
Michael Adam [Wed, 24 Aug 2011 22:49:17 +0000 (00:49 +0200)]
s3:rpc_server: convert srvsvc to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 23:35:16 +0000 (01:35 +0200)]
s3:smbd: convert notify db to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:46:42 +0000 (00:46 +0200)]
s3:smbd: convert session.c to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:42:10 +0000 (00:42 +0200)]
s3:smbd: convert connections.c to use only dbrwap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:01:44 +0000 (00:01 +0200)]
s3:conn_tdb: convert connections tdb to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:40:09 +0000 (15:40 +0200)]
s3:vfs: convert the acl_tdb module to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:36:31 +0000 (15:36 +0200)]
s3:vfs: convert nfs4_acls sidmap db code to use dbwrap_wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 13:32:59 +0000 (15:32 +0200)]
s3:vfs: change the xattr_tdb module to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:49:59 +0000 (11:49 +0200)]
s3:printing: convert printer_list to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:30:15 +0000 (00:30 +0200)]
s3:secrets: convert to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:38:51 +0000 (00:38 +0200)]
s3:passdb: convert account_pol to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 22:36:05 +0000 (00:36 +0200)]
s3:passdb: convert machine_sid to use dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:58:15 +0000 (10:58 +0200)]
s3:passdb: convert pdb_tdb to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs
Michael Adam [Wed, 24 Aug 2011 13:27:00 +0000 (15:27 +0200)]
s3:net: convert net idmap check to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:47:48 +0000 (11:47 +0200)]
s3:net: convert net idmap to use only dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:45:31 +0000 (11:45 +0200)]
s3:idmap: convert idmap_tdb to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Thu, 25 Aug 2011 08:50:01 +0000 (10:50 +0200)]
s3:libnet: convert libnet_dssync_passdb to only use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:24:09 +0000 (11:24 +0200)]
s3:privileges: convert privileges.c to use dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:21:31 +0000 (11:21 +0200)]
s3:g_lock: convert to use only dbwrap wrapper functions.
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 09:40:50 +0000 (11:40 +0200)]
s3:registry: convert reg_backend_db to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs
Michael Adam [Wed, 17 Aug 2011 08:50:31 +0000 (10:50 +0200)]
s3:talloc_dict: change to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:46:22 +0000 (10:46 +0200)]
s3:sharesec: convert sharesec.c to use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs
Michael Adam [Wed, 24 Aug 2011 22:08:36 +0000 (00:08 +0200)]
s3:sessionid: convert to using dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:33:58 +0000 (10:33 +0200)]
s3:sessionid: use dbwrap_travers_read() in sessionid_travers_read()
This also changes the return code of sessionid_traverse_read() to NTSTATUS.
It also uses traverse_read instead of traverse.
Michael Adam [Wed, 17 Aug 2011 08:20:46 +0000 (10:20 +0200)]
s3:sessionid: use dbwrap_travers() in sessionid_traverse()
This also changes sessionid_traverse to NTSTATUS return type.
Michael Adam [Thu, 25 Aug 2011 08:39:53 +0000 (10:39 +0200)]
s3:net: convert net serverid to only use dbwrap wrapper functions
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 24 Aug 2011 20:28:40 +0000 (22:28 +0200)]
s3:serverid: convert to using dbwrap wrapper functions only
Avoid direct use of the db_record and db_context structs.
Michael Adam [Wed, 17 Aug 2011 08:10:45 +0000 (10:10 +0200)]
s3:net: fix the exit code of net serverid wipe
Michael Adam [Wed, 17 Aug 2011 08:09:57 +0000 (10:09 +0200)]
s3:net: fix the exit code of net serverid list
Michael Adam [Wed, 17 Aug 2011 08:08:31 +0000 (10:08 +0200)]
s3:serverid: use dbwrap_traverse_read() in serverid_traverse_read()
This also fixes the return value: originally the int return value
of traverse_read which is a count of the records traversed or negative
upon failure, was simply casted into a bool return value.
Michael Adam [Wed, 17 Aug 2011 08:06:07 +0000 (10:06 +0200)]
s3:serverid: use dbwrap_traverse() in serverid_traverse()
This also fixes the return value: Originally, the int returned
by the traverse method, which is the count of the traverse was
casted into a bool return value.
Michael Adam [Fri, 19 Aug 2011 08:55:22 +0000 (10:55 +0200)]
s3:dbwrap_torture: convert to using wrapper functions only
Michael Adam [Wed, 17 Aug 2011 09:42:45 +0000 (11:42 +0200)]
s3:dbwrap_tool: convert to using wrapper functions only
Michael Adam [Tue, 23 Aug 2011 23:01:38 +0000 (01:01 +0200)]
s3:dbwrap: convert dbwrap_util.c to use dbwrap wrapper functions
Michael Adam [Wed, 24 Aug 2011 11:15:48 +0000 (13:15 +0200)]
s3:dbwrap: use dbwrap_fetch_bystring() in dbwrap_fetch_[u]int32()
Michael Adam [Wed, 24 Aug 2011 11:08:13 +0000 (13:08 +0200)]
s3:dbwrap: convert dbwrap_fetch(), dbwrap_fetch_bystring() and dbwrap_fetch_bystring_upper() to NTSTATUS
Michael Adam [Fri, 19 Aug 2011 08:53:29 +0000 (10:53 +0200)]
s3:dbwrap: add dbwrap_fetch_locked(), a wrapper for db->fetch_locked
Michael Adam [Fri, 19 Aug 2011 08:52:57 +0000 (10:52 +0200)]
s3:dbwrap: add dbwrap_record_delete(), a wrapper for record->delete_rec
Michael Adam [Fri, 19 Aug 2011 08:51:27 +0000 (10:51 +0200)]
s3:dbwrap: add dbwrap_record_store(), a wrapper for record->store
Michael Adam [Fri, 19 Aug 2011 08:50:20 +0000 (10:50 +0200)]
s3:dbwrap: add get-functions for db_record key, value and private_data
Michael Adam [Thu, 18 Aug 2011 12:09:56 +0000 (14:09 +0200)]
s3:dbwrap: add wrapper function dbwrap_get_seqnum()
Michael Adam [Wed, 17 Aug 2011 20:51:12 +0000 (22:51 +0200)]
s3:dbwrap: add wrappers for transactions start/cancel/commit
Michael Adam [Wed, 17 Aug 2011 20:43:01 +0000 (22:43 +0200)]
s3:dbwrap: add wrapper dbwrap_get_flags()
Gregor Beck [Wed, 17 Aug 2011 09:44:12 +0000 (11:44 +0200)]
s3:dbwrap: fix db_rbt_traverse() to return the record count on success
this makes it consistent with documented behaviour of tdb_traverse()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 16 Aug 2011 12:55:30 +0000 (14:55 +0200)]
s3:dbwrap: add specific dbwrap_wipe() implementation to dbwrap_rbt
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 16 Aug 2011 12:43:29 +0000 (14:43 +0200)]
s3:dbwrap: add specific dbwrap_wipe() implementation to dbwrap_tdb
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 17 Aug 2011 12:42:50 +0000 (14:42 +0200)]
s3:dbwrap: add a comment
Gregor Beck [Tue, 16 Aug 2011 12:39:19 +0000 (14:39 +0200)]
s3:dbwrap: add function dbwrap_wipe()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 13:06:05 +0000 (15:06 +0200)]
s3:dbwrap: add specific dbwrap_parse_record() implementation to dbwrap_rbt
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:43:59 +0000 (13:43 +0200)]
s3:dbwrap: implement dbwrap_fallback_exists() with dbwrap_parse_record()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:42:39 +0000 (13:42 +0200)]
s3:dbwrap: allow NULL parser for dbwrap_parse_record()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:41:12 +0000 (13:41 +0200)]
s3:dbwrap: dbwrap_parse_record() should always return -1 on "not found"
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 5 Jul 2011 11:10:30 +0000 (13:10 +0200)]
s3:dbwrap: add function dbwrap_parse_record()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 4 Jul 2011 08:22:46 +0000 (10:22 +0200)]
s3:dbwrap: add specific dbwrap_exists() implementation to dbwrap_rbt
Gregor Beck [Mon, 4 Jul 2011 07:54:31 +0000 (09:54 +0200)]
s3:dbwrap: factor out db_rpt_search_internal()
Signed-off-by: Michael Adam <obnox@samba.org>