Günther Deschner [Wed, 7 May 2008 19:06:23 +0000 (21:06 +0200)]
dsgetdcname: simply call ourself with DS_FORCE_REDISCOVERY after cache expiry.
Guenther
Günther Deschner [Wed, 7 May 2008 19:04:10 +0000 (21:04 +0200)]
dsgetdcname: be more paranoid about the existance of an ip_address.
Guenther
Günther Deschner [Wed, 7 May 2008 19:02:50 +0000 (21:02 +0200)]
dsgetdcname: remove invalid assumption in discover_dc_dns().
Guenther
Günther Deschner [Wed, 7 May 2008 16:57:43 +0000 (18:57 +0200)]
dsgetdcname: mailslot replies are identical to the cldap ones, use cldap everywhere.
Guenther
Günther Deschner [Wed, 7 May 2008 16:55:45 +0000 (18:55 +0200)]
dsgetdcname: wait a little longer for mailslot replies.
Guenther
Günther Deschner [Wed, 7 May 2008 16:39:24 +0000 (18:39 +0200)]
dsgetdcname: map additional flags to nt_version.
Guenther
Günther Deschner [Wed, 7 May 2008 16:38:37 +0000 (18:38 +0200)]
dsgetdcname: use make_dc_info_from_cldap_reply() for cldap replies.
Guenther
Günther Deschner [Wed, 7 May 2008 16:36:03 +0000 (18:36 +0200)]
dsgetdcname: add make_dc_info_from_cldap_reply().
Guenther
Günther Deschner [Wed, 7 May 2008 14:49:39 +0000 (16:49 +0200)]
dsgetdcname: add get_cldap_reply_server_flags().
Guenther
Günther Deschner [Wed, 7 May 2008 13:49:09 +0000 (15:49 +0200)]
cldap: let ads_cldap_netlogon() return all possible cldap replies.
Guenther
Günther Deschner [Wed, 7 May 2008 13:21:41 +0000 (15:21 +0200)]
dsgetdcname: add pull_mailslot_cldap_reply().
Guenther
Günther Deschner [Wed, 7 May 2008 12:38:35 +0000 (14:38 +0200)]
dsgetdcname: add map_ds_flags_to_nt_version.
Guenther
Jeremy Allison [Fri, 9 May 2008 05:07:35 +0000 (22:07 -0700)]
Fix bug #5452 - smbclient put always creates zero length
files. Thanks to Kai Engert <kengert@redhat.com> for
reporting.
Jeremy.
Jeremy Allison [Fri, 9 May 2008 01:09:07 +0000 (18:09 -0700)]
Yay ! Remove a VFS entry. Removed the set_nt_acl() call,
this can only be done via fset_nt_acl() using an open
file/directory handle. I'd like to do the same with
get_nt_acl() but am concerned about efficiency
problems with "hide unreadable/hide unwritable" when
doing a directory listing (this would mean opening
every file in the dir on list).
Moving closer to rationalizing the ACL model and
maybe moving the POSIX calls into a posix_acl VFS
module rather than having them as first class citizens
of the VFS.
Jeremy.
Michael Adam [Thu, 8 May 2008 16:08:41 +0000 (18:08 +0200)]
registry: add removal of secdesc of a key to regdb_store_keys().
Michael
Michael Adam [Thu, 8 May 2008 16:05:58 +0000 (18:05 +0200)]
registry: add comments to removing lists in regdb_store_keys().
Michael
Michael Adam [Thu, 8 May 2008 15:59:32 +0000 (17:59 +0200)]
registry: change order of deleting value and subkey lists in store_keys().
Next step in the plan to make store_keys safer without transactions.
Michael
Michael Adam [Thu, 8 May 2008 14:55:14 +0000 (16:55 +0200)]
registry: adapt comment to first step in regdb_store_keys().
Michael
Michael Adam [Thu, 8 May 2008 14:32:51 +0000 (16:32 +0200)]
registry: adapt comment of last step in regdb_store_keys().
adding number (3) ....
Michael
Michael Adam [Thu, 8 May 2008 12:33:02 +0000 (14:33 +0200)]
registry: regdb_store_keys: move storing the subkey list down after removing values.
Michael
Michael Adam [Tue, 6 May 2008 08:06:34 +0000 (10:06 +0200)]
registry: add comment explaining workflow to make store_keys safe w/o transactions
/*
* Make the store operation as safe as possible without transactions:
*
* (1) For each subkey removed from ctr compared with old_subkeys:
*
* (a) First delete the value db entry.
*
* (b) Next delete the secdesc db record.
*
* (c) Then delete the subkey list entry.
*
* (2) Now write the list of subkeys of the parent key,
* deleting removed entries and adding new ones.
*
* (3) Finally create the subkey list entries for the added keys.
*
* This way if we crash half-way in between deleting the subkeys
* and storing the parent's list of subkeys, no old data can pop up
* out of the blue when re-adding keys later on.
*/
The workflow is going to be modified to meet this agendain the next commits.
Michael
Michael Adam [Wed, 7 May 2008 12:01:49 +0000 (14:01 +0200)]
registry: check for existence of non base key in regdb_store_keys() before proceeding.
Michael
Michael Adam [Wed, 7 May 2008 22:34:35 +0000 (00:34 +0200)]
registry: add a function regdb_key_is_base_key() to check whether is composite.
This partly duplicates code from regdb_key_exists(). Maybe refactor later.
Michael
Michael Adam [Wed, 7 May 2008 11:50:01 +0000 (13:50 +0200)]
registry: check for existence of key in regdb_set_secdesc() before proceeding.
Michael
Michael Adam [Wed, 7 May 2008 11:48:28 +0000 (13:48 +0200)]
registry: check for existence of key in regdb_get_secdesc() before proceeding.
Michael
Michael Adam [Wed, 7 May 2008 11:45:02 +0000 (13:45 +0200)]
registry: check for existence of key in regdb_store_values() before proceeding.
Michael
Michael Adam [Wed, 7 May 2008 11:42:48 +0000 (13:42 +0200)]
registry: check for existence of key in regdb_fetch_keys() before proceeding.
Michael
Michael Adam [Wed, 7 May 2008 11:27:56 +0000 (13:27 +0200)]
registry: check for existence of key in regdb_fetch_values() first.
This uses the new semantics for existence of a key.
Michael
Michael Adam [Wed, 7 May 2008 11:26:13 +0000 (13:26 +0200)]
registry: free talloc context on error path in regdb_fetch_values().
Michael
Michael Adam [Tue, 6 May 2008 08:05:20 +0000 (10:05 +0200)]
registry: Implement new semantics for existence of registry key in tdb.
Existence of a key is defined as follows:
* If the key is a base key (without separator), the key exists
iff the corresponding entry exist in the registry tdb.
* If the key is not a base key, the key exists, iff it exists
in the list of subkeys of it's parent keyname's tdb entry.
Michael
Michael Adam [Tue, 6 May 2008 20:20:49 +0000 (22:20 +0200)]
registry: make normalize_reg_path() strip leading and trailing '/' chars.
Michael
Michael Adam [Tue, 6 May 2008 15:15:50 +0000 (17:15 +0200)]
registry: free temporary data in regdb_fetch_key_internal().
Michael
Michael Adam [Tue, 6 May 2008 15:09:57 +0000 (17:09 +0200)]
registry: change order of arguments of regdb_fetch_key_internal()
list talloc context first.
Michael
Günther Deschner [Wed, 7 May 2008 19:01:46 +0000 (21:01 +0200)]
gencache: add some const.
Guenther
Günther Deschner [Wed, 7 May 2008 19:01:29 +0000 (21:01 +0200)]
re-run make idl.
Guenther
Günther Deschner [Wed, 7 May 2008 19:01:09 +0000 (21:01 +0200)]
IDL: make nbt_cldap_netlogon_29 public.
Guenther
Günther Deschner [Wed, 7 May 2008 23:07:10 +0000 (01:07 +0200)]
netdomjoin-gui: before prompting for creds, ask dsgetdcname for a dc.
Guenther
Volker Lendecke [Tue, 6 May 2008 15:37:00 +0000 (17:37 +0200)]
Rename server_info->was_mapped to server_info->nss_token
"nss_token" from my point of view much better reflects what this flag actually
represents
Volker Lendecke [Tue, 6 May 2008 13:16:45 +0000 (15:16 +0200)]
Use talloc_tos() for a temporary getpwnam_alloc in make_connection_snum
Volker Lendecke [Wed, 7 May 2008 12:20:15 +0000 (14:20 +0200)]
Use talloc_stackframe() in find_forced_group
Günther Deschner [Wed, 7 May 2008 12:11:27 +0000 (14:11 +0200)]
re-run make idl.
Guenther
Günther Deschner [Wed, 7 May 2008 12:10:34 +0000 (14:10 +0200)]
IDL: add missing case 14 and 15 to nbt_cldap_netlogon union.
Guenther
Günther Deschner [Wed, 7 May 2008 12:09:41 +0000 (14:09 +0200)]
dsgetdcname: remove invalid assumptions when using DNS for the DC query.
Guenther
Günther Deschner [Tue, 6 May 2008 15:09:44 +0000 (17:09 +0200)]
netapi: add -f switch for DsGetDCName() example and be more verbose on output.
Guenther
Günther Deschner [Tue, 6 May 2008 15:02:31 +0000 (17:02 +0200)]
wins: fix null pointer crash in nss_wins module.
Guenther
Jeremy Allison [Tue, 6 May 2008 22:44:39 +0000 (15:44 -0700)]
Enable tests for splice on Linux. Add a static (vl, I hate this)
so we can detect broken Linux recvfile splice and correctly fall
back.
Jeremy.
Michael Adam [Tue, 6 May 2008 21:43:37 +0000 (23:43 +0200)]
testsuite: allow selection of posix_s3 subtests by env var POSIX_SUBTESTS.
This allows for calling e.g.
TESTS=posix_s3 POSIX_SUBTESTS="RPC-SAMBA3-GETUSERNAME" make test
Michael
Volker Lendecke [Tue, 6 May 2008 13:41:20 +0000 (15:41 +0200)]
Fix a memleak introduced after refactoring "struct user_struct"
Volker Lendecke [Tue, 6 May 2008 13:06:12 +0000 (15:06 +0200)]
Fix a memleak in construct_printer_info_7()
Also fix a "ignoring asprintf result" warning
Volker Lendecke [Tue, 6 May 2008 12:16:06 +0000 (14:16 +0200)]
Remove some unused code
Volker Lendecke [Tue, 6 May 2008 11:53:45 +0000 (13:53 +0200)]
Fix a panic in the [ug]id2sid valgrind bug fix
Always, always run "make test" before pushing stuff :-)
Stefan Metzmacher [Tue, 6 May 2008 10:38:55 +0000 (12:38 +0200)]
libreplace: check how portable utimes() and futimes() are
metze
(cherry picked from commit
8798ce3c744025b94973784dcb44d099427ef190)
Michael Adam [Tue, 6 May 2008 10:09:59 +0000 (12:09 +0200)]
testsuite: make structuring output of net_s3 tests stand out more.
say "RUNNING SUBTESTS ..." instead of "Running ... tests"
Michael
Michael Adam [Tue, 6 May 2008 10:08:27 +0000 (12:08 +0200)]
testsuite: make diagnostic output more appropriate in tests_all.sh
Say "RUNNING TESTS ..." instead of "RUNNING SUBTESTS ..."
Michael
Michael Adam [Fri, 4 Apr 2008 16:29:44 +0000 (18:29 +0200)]
testsuite: give the testuser administrative rights in selftest.sh
(by adding him to builtin\administrators)
Michael
Michael Adam [Tue, 6 May 2008 10:01:49 +0000 (12:01 +0200)]
testsuite: run the net rpc registry tests from the net_s3 tests.
Michael
Michael Adam [Fri, 4 Apr 2008 16:26:34 +0000 (18:26 +0200)]
testsuite: add the ability to test "net rpc registry" with the net_registry tests
by specifying a parameter "rpc" on the commandline.
Michael
Michael Adam [Tue, 6 May 2008 09:43:27 +0000 (11:43 +0200)]
testsuite: adapt informative message to say "Running _local_ registry tests".
The plan is to also test remote registry with "net rpc registry".
Michael
Michael Adam [Tue, 6 May 2008 09:40:05 +0000 (11:40 +0200)]
testsuite: use domain==workgroup in wbinfo tests now that we are PDC.
Previously domain==netbios name was the right thing to use.
Michael
Kai Blin [Fri, 2 May 2008 23:50:20 +0000 (01:50 +0200)]
tests: Add a net_misc test.
Kai Blin [Mon, 5 May 2008 13:26:11 +0000 (15:26 +0200)]
selftest: Advertise as PDC and time server during make test
Kai Blin [Fri, 2 May 2008 23:45:33 +0000 (01:45 +0200)]
selftest: Use TESTS env var to specify tests to run like Samba4 does.
Kai Blin [Fri, 2 May 2008 23:50:47 +0000 (01:50 +0200)]
gitignore: Add *.swp files, *.patch files and export/libtdb.symb
Volker Lendecke [Sat, 3 May 2008 00:41:10 +0000 (02:41 +0200)]
Fix a valgrind bug in the new [ug]id2sid cache
When we're given a SID, it is not always padded with zeros. Only look at the
initialized parts in the SID.
Günther Deschner [Tue, 6 May 2008 07:48:16 +0000 (09:48 +0200)]
build: fix the build w/o ldap.
Guenther
Günther Deschner [Mon, 5 May 2008 16:04:41 +0000 (18:04 +0200)]
mailslot/cldap: use nt_version bits in queries.
Guenther
Günther Deschner [Mon, 5 May 2008 15:22:49 +0000 (17:22 +0200)]
dsgetdcname: use correct dc name for name cache store.
Guenther
Jeremy Allison [Mon, 5 May 2008 23:29:21 +0000 (16:29 -0700)]
Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
Jeremy Allison [Mon, 5 May 2008 23:24:52 +0000 (16:24 -0700)]
Try and fix bug #5095, "Manage Documents privilege is not functional".
Should map the created sd to printer jobs, not printer.
Jerry please test and I'll add to 3.2 if it passes. Thanks,
Jeremy.
Volker Lendecke [Mon, 5 May 2008 20:53:09 +0000 (22:53 +0200)]
Remove unused dir_status_struct
Volker Lendecke [Mon, 5 May 2008 15:24:17 +0000 (17:24 +0200)]
Fix a C++ warning
Volker Lendecke [Wed, 30 Apr 2008 15:42:39 +0000 (17:42 +0200)]
Remove "userdom_struct user" from "struct user_struct"
Volker Lendecke [Sat, 3 May 2008 07:52:24 +0000 (09:52 +0200)]
Fix a typo
Volker Lendecke [Wed, 30 Apr 2008 15:06:45 +0000 (17:06 +0200)]
Remove unused set_current_user_guest()
Volker Lendecke [Wed, 30 Apr 2008 10:58:40 +0000 (12:58 +0200)]
Fix typo
Volker Lendecke [Wed, 30 Apr 2008 12:26:16 +0000 (14:26 +0200)]
Remove "session_key" from "struct user_struct"
This one took a bit -- I hope I covered all data paths
Volker Lendecke [Tue, 29 Apr 2008 11:45:58 +0000 (13:45 +0200)]
Remove "guest" from "struct user_struct"
Volker Lendecke [Tue, 29 Apr 2008 11:43:10 +0000 (13:43 +0200)]
Remove the unix token info from "struct user_struct"
Volker Lendecke [Tue, 29 Apr 2008 11:35:00 +0000 (13:35 +0200)]
Remove "nt_user_token" from "struct user_struct"
Volker Lendecke [Tue, 29 Apr 2008 11:28:40 +0000 (13:28 +0200)]
Remove "logon_script" from "struct user_struct"
Volker Lendecke [Tue, 29 Apr 2008 11:23:47 +0000 (13:23 +0200)]
Remove unix_homedir from struct user_struct
This makes pdb_get_unix_homedir unused. I wonder if that was ever really used...
Volker Lendecke [Tue, 29 Apr 2008 10:47:55 +0000 (12:47 +0200)]
Remove "homedir" from "struct user_struct"
Volker Lendecke [Mon, 28 Apr 2008 17:42:11 +0000 (19:42 +0200)]
pipes_struct->pipe_user_name is unused, remove it
Volker Lendecke [Mon, 28 Apr 2008 11:35:44 +0000 (13:35 +0200)]
Make the namelist arg to set_namearray const
Günther Deschner [Mon, 5 May 2008 14:58:24 +0000 (16:58 +0200)]
Fix client authentication with -P switch in client tools (Bug 5435).
Guenther
Volker Lendecke [Mon, 5 May 2008 13:06:39 +0000 (15:06 +0200)]
Revert "Fix allocation of conn->vuid_cache entries"
This reverts commit
50c891d3dfb75c9f607f7ad2a578aa3ba5d91988.
There's more to this code -- sorry for the spam
Volker Lendecke [Mon, 5 May 2008 13:06:30 +0000 (15:06 +0200)]
Revert "Second half of
50c891d3: Correctly clear the vuid cache"
This reverts commit
0aea404b0a83736ba2884cc7cf00cd797aab1f56.
Volker Lendecke [Mon, 5 May 2008 12:53:49 +0000 (14:53 +0200)]
Second half of
50c891d3: Correctly clear the vuid cache
Volker Lendecke [Mon, 5 May 2008 12:43:57 +0000 (14:43 +0200)]
Fix allocation of conn->vuid_cache entries
With the old code, if more than VUID_CACHE_SIZE elements were used all new
entries ended up in slot 0. With this checkin we do cycle.
Jeremy, please revert if the old behaviour was intentional
Volker Lendecke [Mon, 5 May 2008 10:45:12 +0000 (12:45 +0200)]
Fix dfs_Enum: In form_junctions, correctly check for malloc failure
Karolin Seeger [Sun, 4 May 2008 04:48:31 +0000 (06:48 +0200)]
Developer's Guide: Fix typos.
Karolin
Volker Lendecke [Mon, 28 Apr 2008 08:31:49 +0000 (10:31 +0200)]
Remove connection_struct->mem_ctx, connection_struct is its own parent
Volker Lendecke [Mon, 5 May 2008 09:15:59 +0000 (11:15 +0200)]
Fix two uninitialized variable warnings
Jeremy Allison [Sat, 3 May 2008 00:22:10 +0000 (17:22 -0700)]
Remove the "stat_open()" function, flag, and all associated code. It was only
being (correctly) used in the can_read/can_write checks for hide unreadable/unwritable
and this is more properly done using the functions in smbd/file_access.c.
Preparing to do NT access checks on all file access.
Jeremy.
Jeremy Allison [Fri, 2 May 2008 19:54:53 +0000 (12:54 -0700)]
Rename inherit_access_acl() -> inherit_access_posix_acl() to make use clear.
Jeremy.
Jeremy Allison [Fri, 2 May 2008 17:09:00 +0000 (10:09 -0700)]
Move directory_has_default_acl() to file_access.c, belongs
there as it no longer uses explicit POSIX ACL calls.
Jeremy.
Jeremy Allison [Fri, 2 May 2008 00:01:37 +0000 (17:01 -0700)]
Start to ensure we use the NT ACL interface, keep the POSIX
ACL interface inside the VFS modules. Will help when moving
to storing NT ACLs.
Jeremy.
Jeremy Allison [Thu, 1 May 2008 15:48:52 +0000 (08:48 -0700)]
Tidyup to ensure '\n' is treated identically in all
cases.
Jeremy.
Jeremy Allison [Thu, 1 May 2008 15:39:16 +0000 (08:39 -0700)]
Fix bug #5434 found by Ted Percival <ted@midg3t.net>.
Introduced by me in the strlcpy cleanup. Ensure the
loaded password doesn't contain the '\n' at the end.
Jeremy.
Günther Deschner [Wed, 30 Apr 2008 16:47:40 +0000 (18:47 +0200)]
ntlmssp: replace UNKNOWN_02000000 with NTLMSSP_NEGOTIATE_VERSION.
Guenther