9 years agocreate-tarball: Make it more comfortable to use the --copy-docs option.
Karolin Seeger [Thu, 26 Nov 2009 10:18:39 +0000 (11:18 +0100)]
create-tarball: Make it more comfortable to use the --copy-docs option.

Now you can directly specify the 'make release' output dir without any


9 years agos4:ldap.py - add a test for the enhanced operational attributes check
Matthias Dieter Wallnöfer [Thu, 26 Nov 2009 08:51:56 +0000 (09:51 +0100)]
s4:ldap.py - add a test for the enhanced operational attributes check

(Deny creation of entries with operational attributes specified)

9 years agos4:objectclass LDB module - Prevent write operations on constructed attributes
Matthias Dieter Wallnöfer [Thu, 26 Nov 2009 09:54:20 +0000 (10:54 +0100)]
s4:objectclass LDB module - Prevent write operations on constructed attributes

9 years agos4:operational LDB module - Don't do the write checks here
Matthias Dieter Wallnöfer [Thu, 26 Nov 2009 09:21:44 +0000 (10:21 +0100)]
s4:operational LDB module - Don't do the write checks here

Let this perform the schema in the "objectclass" module.

9 years agos3-kerberos: next step to resolve Bug #6929: build with recent heimdal.
Günther Deschner [Thu, 26 Nov 2009 09:15:45 +0000 (10:15 +0100)]
s3-kerberos: next step to resolve Bug #6929: build with recent heimdal.

Based on patch from Allan <allan@archlinux.org>.

Also should fix the FreeBSD build on the buildfarm.


9 years agos4-smbtorture: refactor RPC-SAMR-LARGE-DC test a little more.
Günther Deschner [Thu, 26 Nov 2009 00:25:56 +0000 (01:25 +0100)]
s4-smbtorture: refactor RPC-SAMR-LARGE-DC test a little more.


9 years agos4-smbtorture: add torture_samr_context to carry some RPC-SAMR-X specifics.
Günther Deschner [Wed, 25 Nov 2009 23:32:47 +0000 (00:32 +0100)]
s4-smbtorture: add torture_samr_context to carry some RPC-SAMR-X specifics.


9 years agoFix warnings with talloc_asprintf.
Jeremy Allison [Wed, 25 Nov 2009 22:47:36 +0000 (14:47 -0800)]
Fix warnings with talloc_asprintf.

9 years agoMake us pass RAW-CHKPATH with a case sensitive share.
Jeremy Allison [Wed, 25 Nov 2009 21:17:56 +0000 (13:17 -0800)]
Make us pass RAW-CHKPATH with a case sensitive share.
I know Volker will look at this closely so here's the explaination :-).
Originally on a case-sensitive share we simply did a stat (or lstat)
call and returned success of fail based on the result. However this
failed to take account of incoming paths with a wildcard (which must
always fail, and with different error messages depending on whether
the wildcard is the last component or in the path). Also it failed
to take account of a stat fail with ENOENT due to a missing component
of the path as the last component (which is ok as it could be a new
file)  or if the ENOENT was due to the missing component within
the path (not the last component) - which must return the correct
error. What this means is that with "case sensitive = yes" we do
one more talloc call (to get the parent directory) and one more
stat call (on the parent directory) in the case where the stat
call fails. I think this is an acceptable overhead to enable
case sensitive shares to return the correct error messages for
applications. Volker please examine carefully :-).

9 years agoAdd RAW-CHKPATH test with case-sensitive share.
Jeremy Allison [Wed, 25 Nov 2009 21:17:38 +0000 (13:17 -0800)]
Add RAW-CHKPATH test with case-sensitive share.

9 years agos3-build: try to fix QNX build ("delay" is defined in lib headers).
Günther Deschner [Wed, 25 Nov 2009 21:03:19 +0000 (22:03 +0100)]
s3-build: try to fix QNX build ("delay" is defined in lib headers).


9 years agos4/torture: port SMBv1 RAW-LOCK tests to SMBv2
Steven Danneman [Thu, 19 Nov 2009 00:35:03 +0000 (16:35 -0800)]
s4/torture: port SMBv1 RAW-LOCK tests to SMBv2

RAW-LOCK ported as:

RAW-PIDHIGH -> removed, no longer relevant
RAW-CHANGETYPE -> removed, no longer relevant

BASE-LOCK ported as:

BASE-LOCK-LOCK1 -> SMB2-LOCK-ERRORCODE, timeout is no longer relevant
BASE-LOCK-LOCK6 -> SMB2-LOCK-CANCEL, change_locktype no longer relevant

9 years agos4/libcli: rename previously reserved field in SMB2 LOCK struct
Steven Danneman [Thu, 19 Nov 2009 01:51:35 +0000 (17:51 -0800)]
s4/libcli: rename previously reserved field in SMB2 LOCK struct

The lock.in.reserved field has been renamed lock_sequence in the
SMB 2.1 dialect.  See MS-SMB 2.2.26.

9 years agos4/libcli: Initialize client PID for SMB2 connections
Steven Danneman [Thu, 19 Nov 2009 00:35:16 +0000 (16:35 -0800)]
s4/libcli: Initialize client PID for SMB2 connections

Set the SMB pid to the Unix pid of the client process.

9 years agos3-registry: fix REG_MULTI_SZ handling in registry_push_value.
Günther Deschner [Wed, 25 Nov 2009 20:34:55 +0000 (21:34 +0100)]
s3-registry: fix REG_MULTI_SZ handling in registry_push_value.

Catched by smbconftort test on the buildfarm.


9 years agos3-kerberos: add check for prerequisite krb5/krb5.h header while checking for krb5...
Günther Deschner [Wed, 25 Nov 2009 20:33:48 +0000 (21:33 +0100)]
s3-kerberos: add check for prerequisite krb5/krb5.h header while checking for krb5/locate_plugin.h.

(Needed for new Heimdal versions).


9 years agoFix bug 6892 - When a chown operation is issued via Windows Explorer, all ACLS are...
Jeremy Allison [Wed, 25 Nov 2009 18:20:38 +0000 (10:20 -0800)]
Fix bug 6892 - When a chown operation is issued via Windows Explorer, all ACLS are wiped out.
Merges existing DACLs when a ACL set operation comes in with only owner or group values set.

9 years agoFix crash due to uninitialized pointer (not a problem in 3.4.x or below).
Jeremy Allison [Wed, 25 Nov 2009 17:58:45 +0000 (09:58 -0800)]
Fix crash due to uninitialized pointer (not a problem in 3.4.x or below).

9 years agonsswitch: fix compile of winbind_krb5_locator with recent Heimdal versions.
Günther Deschner [Wed, 25 Nov 2009 14:21:54 +0000 (15:21 +0100)]
nsswitch: fix compile of winbind_krb5_locator with recent Heimdal versions.


9 years agocifs.upcall: 2nd part of fix for Bug #6868: support building with Heimdal we well...
Günther Deschner [Wed, 25 Nov 2009 14:06:19 +0000 (15:06 +0100)]
cifs.upcall: 2nd part of fix for Bug #6868: support building with Heimdal we well as with MIT.


9 years agos3 selftest: Add RAW-SFILEINFO-END-OF-FILE to selftest
Tim Prouty [Wed, 25 Nov 2009 16:15:31 +0000 (08:15 -0800)]
s3 selftest: Add RAW-SFILEINFO-END-OF-FILE to selftest

9 years agos3 setfileinfo: Open with FILE_WRITE_DATA when setting the file size
Tim Prouty [Wed, 25 Nov 2009 00:48:16 +0000 (16:48 -0800)]
s3 setfileinfo: Open with FILE_WRITE_DATA when setting the file size

This matches what is outlined here:

This is also inline with how winXP/win7 handle this.  See
RAW-SFILEINFO-END-OF-FILE* in smbtorture4.

9 years agos4 torture: Change RAW-OPLOCK to use the documented version of SET_END_OF_FILE_INFO
Tim Prouty [Wed, 25 Nov 2009 16:03:36 +0000 (08:03 -0800)]
s4 torture: Change RAW-OPLOCK to use the documented version of SET_END_OF_FILE_INFO

The passtrhough version of SET_END_OF_FILE_INFO is tested in

Additionally, the first opener is changed to use SHARE_WRITE for the
share mode since SET_END_OF_FILE_INFO actually writes data to the file
via truncating/extending.

9 years agos4 torture: Allow onefs to be checked like samba3 and samba4
Tim Prouty [Wed, 25 Nov 2009 16:17:13 +0000 (08:17 -0800)]
s4 torture: Allow onefs to be checked like samba3 and samba4

This is needed for the new RAW-SFILEINFO-END-OF-FILE test to
differentiate what appears to be a windows bug.

9 years agos4 torture: Add two new setfileinfo tests
Tim Prouty [Wed, 25 Nov 2009 00:29:19 +0000 (16:29 -0800)]
s4 torture: Add two new setfileinfo tests

These tests expose a potential bug in winXP, win7, and likely others.
There is also a bug in samba where share modes aren't being enforced
where they should.

For more details see:

9 years agos4 torture: Split up the torture suite setup for RAW-SFILEINFO
Tim Prouty [Wed, 25 Nov 2009 00:25:02 +0000 (16:25 -0800)]
s4 torture: Split up the torture suite setup for RAW-SFILEINFO

A side effect of this change is that RAW-SFILEINFO now runs the whole
suite instead of just the first test.  I changed the name of the first
test to RAW-SFILEINFO-BASE and changed all of the selftest scripts
that call it.

9 years agoThe start of a WHATSNEW for Samba4 alpha9
Andrew Bartlett [Wed, 25 Nov 2009 08:17:50 +0000 (19:17 +1100)]
The start of a WHATSNEW for Samba4 alpha9

If you think what you did is missing, please edit.  Release of alpha9
will be this week.

Andrew Bartlett

9 years agos4:dsdb Make samba_dsdb easier to use in upgrades - assume default values
Andrew Bartlett [Wed, 25 Nov 2009 07:49:42 +0000 (18:49 +1100)]
s4:dsdb Make samba_dsdb easier to use in upgrades - assume default values

9 years agos4: update valgrind suppressions for use on build farm
Andrew Bartlett [Wed, 25 Nov 2009 06:48:29 +0000 (17:48 +1100)]
s4: update valgrind suppressions for use on build farm

9 years agolibcli: allow ntstatus.h to be used by openchange
Andrew Tridgell [Wed, 25 Nov 2009 04:30:20 +0000 (15:30 +1100)]
libcli: allow ntstatus.h to be used by openchange

apparently ntstatus.h is used by openchange, but they don't include
replace.h. This makes that possible again.

9 years agos4:upgradeschema.py Update to reflect recent change in provision
Matthieu Patou [Tue, 24 Nov 2009 15:52:36 +0000 (18:52 +0300)]
s4:upgradeschema.py Update to reflect recent change in provision

- define which modules we want to use when loading the ldb
- move partition in sam.ldb.d dir

Changes have been suggested by Andrew Bartlett.

(commit message clarified by Andrew Bartlett)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4:upgradeschema.py Cleanup
Matthieu Patou [Tue, 24 Nov 2009 14:02:59 +0000 (17:02 +0300)]
s4:upgradeschema.py Cleanup

- remove some useless comments
- remove hardcoded paths

(commit message clarified by Andrew Bartlett)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agoRemove call into reduce_name if case sensitive. This allows us to pass
Jeremy Allison [Wed, 25 Nov 2009 00:40:08 +0000 (16:40 -0800)]
Remove call into reduce_name if case sensitive. This allows us to pass
RAW-CHKPATH when case sensitive = yes, but isn't the correct way to do
it. I'm testing a larger patch to smbd/filename.c that should fix this
correctly, and will add a torture test to ensure RAW-CHKPATH is run against
a case sensitive share once this is done.

9 years agos4:installmisc - install also the new "domainlevel" tool from the setup dir
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 21:24:00 +0000 (22:24 +0100)]
s4:installmisc - install also the new "domainlevel" tool from the setup dir

9 years agos4: Check SUN compiler and remove "-fullwarn" when using it
Brian Lu [Tue, 24 Nov 2009 21:10:22 +0000 (22:10 +0100)]
s4: Check SUN compiler and remove "-fullwarn" when using it

This option is only supported by "gcc".
For details consider https://bugzilla.samba.org/show_bug.cgi?id=6905

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agoAllow us to pass RAW-CHKPATH with FILE_FLAG_POSIX_SEMANTICS set or with
Jeremy Allison [Tue, 24 Nov 2009 22:05:56 +0000 (14:05 -0800)]
Allow us to pass RAW-CHKPATH with FILE_FLAG_POSIX_SEMANTICS set or with
wide links = no.

9 years agoFix make test. Only do POSIX case conversion if FILE_FLAG_POSIX_SEMANTICS set. Doh !
Jeremy Allison [Tue, 24 Nov 2009 21:02:34 +0000 (13:02 -0800)]
Fix make test. Only do POSIX case conversion if FILE_FLAG_POSIX_SEMANTICS set. Doh !

9 years agoRevert "s4-netlogon: always set the dNSHostName in GetDomainInfo"
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 19:30:07 +0000 (20:30 +0100)]
Revert "s4-netlogon: always set the dNSHostName in GetDomainInfo"

This reverts commit 87b6f2e863c6e117643ab6704e50167e849b69cc.

This was the cause of the breakage of the "LogonGetDomainInfo" testsuite. I
think my behaviour is more correct to Windows Server since the test works
against it (at least release 2003 R2).

One problem I discovered is that freshly joined workstations don't get their
DNS name into the directory. Therefore I think also another part (maybe another
RPC call) is able to do this.

9 years agos4:ldap.py - fix the schema update test on Windows Server
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 18:44:18 +0000 (19:44 +0100)]
s4:ldap.py - fix the schema update test on Windows Server

Apparently Windows Server (2003) doesn't like the comma delimiter here. I got
always error 16 ("LDB_NO_SUCH_ATTRIBUTE"). With this change the test works

9 years agos4:libnet_become_dc - fix typo
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 18:17:08 +0000 (19:17 +0100)]
s4:libnet_become_dc - fix typo

9 years agos3: Always try SamLogonEx
Volker Lendecke [Tue, 24 Nov 2009 15:51:30 +0000 (16:51 +0100)]
s3: Always try SamLogonEx

Required for cluster systems working in a Samba domain. With NT4 this won't
work, but real NT4 DCs should not be around in environments that pay big bucks
for a cluster... And if they are, they can always install a Samba DC trusting
that NT4 domain.

9 years agos3-spoolss: re-arrange driver info level fillup functions.
Günther Deschner [Mon, 23 Nov 2009 14:31:58 +0000 (15:31 +0100)]
s3-spoolss: re-arrange driver info level fillup functions.


9 years agos3-spoolss: fixes for _spoolss_EnumPrinterKey client and server.
Günther Deschner [Tue, 24 Nov 2009 14:22:04 +0000 (15:22 +0100)]
s3-spoolss: fixes for _spoolss_EnumPrinterKey client and server.

Thanks Metze for review!


9 years agos3-registry: use push_reg_multi_sz() in registry_push_value().
Günther Deschner [Tue, 24 Nov 2009 14:26:32 +0000 (15:26 +0100)]
s3-registry: use push_reg_multi_sz() in registry_push_value().


9 years agos3-registry: remove reg_pull_multi_sz().
Günther Deschner [Tue, 24 Nov 2009 14:26:08 +0000 (15:26 +0100)]
s3-registry: remove reg_pull_multi_sz().


9 years agos3:torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:59:09 +0000 (10:59 +0100)]
s3:torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer


9 years agos3:torture/nbio: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:41:40 +0000 (10:41 +0100)]
s3:torture/nbio: use timeval_current/timeval_elapsed instead of start_timer/end_timer


9 years agos3:dbwrap_torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:36:52 +0000 (10:36 +0100)]
s3:dbwrap_torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer


9 years agoRAW-PING-PONG: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:18:37 +0000 (10:18 +0100)]
RAW-PING-PONG: use timeval_current/timeval_elapsed instead of start_timer/end_timer


9 years agos3:fix the merged build of bin/smbtorture4
Michael Adam [Tue, 24 Nov 2009 10:43:56 +0000 (11:43 +0100)]
s3:fix the merged build of bin/smbtorture4


9 years agodocs: Fix Bug 6922: Add Registry patchfile for Win7 domain join.
Günther Deschner [Tue, 24 Nov 2009 10:36:14 +0000 (11:36 +0100)]
docs: Fix Bug 6922: Add Registry patchfile for Win7 domain join.

Patchfile from SATOH Fumiyasu <fumiyas@osstech.co.jp>.



9 years agoRestore NtCreateX case handling with FILE_FLAG_POSIX_SEMANTICS to the way
Jeremy Allison [Tue, 24 Nov 2009 05:06:54 +0000 (21:06 -0800)]
Restore NtCreateX case handling with FILE_FLAG_POSIX_SEMANTICS to the way
it worked in 3.3.x and 3.2.x. UCF_POSIX_PATHNAMES may no longer be needed,
as lp_posix_pathnames() being set isn't the same as case handling from
NtCreateX (lp_posix_pathnames() changes the STAT calls to LSTAT, not
the case semantics).

9 years agos4:param remove reference to private header from source4/param/param.h
Brad Hards [Tue, 24 Nov 2009 02:43:59 +0000 (13:43 +1100)]
s4:param remove reference to private header from source4/param/param.h

source4/param/param.h has a

param.h is a public header (and parmlist isn't, even if the relative path
could work), so I suggest making it a forward declaration in the header, and
including parmlist.h in the implementation.

(commit message included from e-mail by Andrew Bartlett)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4: Fix missing TLS dir when targetdir is not the default one
Matthieu Patou [Sun, 22 Nov 2009 17:51:24 +0000 (20:51 +0300)]
s4: Fix missing TLS dir when targetdir is not the default one

9 years agoRemove unused code.
Jeremy Allison [Tue, 24 Nov 2009 02:00:36 +0000 (18:00 -0800)]
Remove unused code.

9 years agoheimdal Fix invalid format string
Andrew Bartlett [Tue, 24 Nov 2009 00:38:41 +0000 (11:38 +1100)]
heimdal Fix invalid format string

9 years agos4:dsdb Handle LDAP backends correctly with new samba_dsdb system
Andrew Bartlett [Tue, 24 Nov 2009 00:36:34 +0000 (11:36 +1100)]
s4:dsdb Handle LDAP backends correctly with new samba_dsdb system

The original code had the wrong module names, and use strcasecmp()

Andrew Bartlett

9 years agos4:provision Move exceptions into a new file
Andrew Bartlett [Tue, 24 Nov 2009 00:09:30 +0000 (11:09 +1100)]
s4:provision Move exceptions into a new file

This allows provisionbackend and provision to both raise ProvisionException

9 years agos4:provision Don't bother with a template for the LDAP backend startup script.
Andrew Bartlett [Tue, 24 Nov 2009 00:00:12 +0000 (11:00 +1100)]
s4:provision Don't bother with a template for the LDAP backend startup script.

9 years agos4:provision Move secrets.ldb over to .c file module lists, like sam.ldb
Andrew Bartlett [Mon, 23 Nov 2009 23:36:28 +0000 (10:36 +1100)]
s4:provision Move secrets.ldb over to .c file module lists, like sam.ldb

9 years agos4:ldap.py - activate test for operational attributes
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 13:59:21 +0000 (14:59 +0100)]
s4:ldap.py - activate test for operational attributes

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4:operational LDB module - Prevent the modification of operational attributes
Andrew Bartlett [Mon, 23 Nov 2009 23:22:10 +0000 (10:22 +1100)]
s4:operational LDB module - Prevent the modification of operational attributes

(merged by Andrew Bartlett)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
9 years agos4:ldap.py Add tests for subSchemaSubEntry
Andrew Bartlett [Mon, 23 Nov 2009 23:18:33 +0000 (10:18 +1100)]
s4:ldap.py Add tests for subSchemaSubEntry

9 years agos4:dsdb Use new helper function to obtain CN=Aggregate schema DN in schema_data
Andrew Bartlett [Mon, 23 Nov 2009 23:18:02 +0000 (10:18 +1100)]
s4:dsdb Use new helper function to obtain CN=Aggregate schema DN in schema_data

9 years agos4:dsdb Return the subSchemaSubEntry operational attribute on every object
Andrew Bartlett [Mon, 23 Nov 2009 23:17:18 +0000 (10:17 +1100)]
s4:dsdb Return the subSchemaSubEntry operational attribute on every object

9 years agos4:dsdb Add function to return the CN=Aggregate schema DN
Andrew Bartlett [Mon, 23 Nov 2009 23:16:56 +0000 (10:16 +1100)]
s4:dsdb Add function to return the CN=Aggregate schema DN

9 years agos4:provision Remove 'operational' from secrets.ldb module list
Andrew Bartlett [Mon, 23 Nov 2009 23:15:28 +0000 (10:15 +1100)]
s4:provision Remove 'operational' from secrets.ldb module list

9 years agoProper fix for #6898 - Samba duplicates file content on appending. Pointed out by...
Jeremy Allison [Mon, 23 Nov 2009 23:01:34 +0000 (15:01 -0800)]
Proper fix for #6898 - Samba duplicates file content on appending. Pointed out by Volker.Restores the pathname handling for FILE_FLAG_POSIX_SEMANTICS but still prevents the O_APPEND problems. Jeremy.

9 years agos3: add dbwrap_torture - a tool to stress test tdb transactions through dbwrap
Michael Adam [Fri, 20 Nov 2009 23:48:40 +0000 (00:48 +0100)]
s3: add dbwrap_torture - a tool to stress test tdb transactions through dbwrap

This can be used to also test tdb transactions on clustered installations
throught ctdb. The test is modeled after the ctdb_transaction.c test program
from the ctdb source code. It runs transactions in a tight loop on a test
database called "transactions.tdb" (by default), increasing a counter in each
iteration. In a clustered environment, a counter is maintained for each node.


9 years agos3:torture: move the torture-specific headers to new torture/torture.h
Michael Adam [Fri, 20 Nov 2009 16:47:21 +0000 (17:47 +0100)]
s3:torture: move the torture-specific headers to new torture/torture.h


9 years agos3:idmap_ldap: fix indentation: tab/space mixup
Michael Adam [Fri, 20 Nov 2009 14:03:59 +0000 (15:03 +0100)]
s3:idmap_ldap: fix indentation: tab/space mixup


9 years agoFix bug #6898 - Samba duplicates file content on appending
Jeremy Allison [Mon, 23 Nov 2009 18:09:47 +0000 (10:09 -0800)]
Fix bug #6898 - Samba duplicates file content on appending
Clients using a Windows open call should not be able to set

9 years agos3-spoolss: Fix GetPrinter level 101.
Günther Deschner [Mon, 23 Nov 2009 15:54:34 +0000 (16:54 +0100)]
s3-spoolss: Fix GetPrinter level 101.


9 years agoRevert "s3: Make the implicit reference to Protocol in mask_match() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:34:07 +0000 (16:34 +0100)]
Revert "s3: Make the implicit reference to Protocol in mask_match() explicit"

This reverts commit e23d8a3d1f558a7e98ef2afd71e1d15c5b3a71bc.

9 years agoRevert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:34:00 +0000 (16:34 +0100)]
Revert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"

This reverts commit 1e22899d268ae5a089f941a204413c07ee64fc78.

9 years agoRevert "s3: Make the implicit reference to Protocol in is_in_path() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:33:53 +0000 (16:33 +0100)]
Revert "s3: Make the implicit reference to Protocol in is_in_path() explicit"

This reverts commit f7b4151a64d8c6851e62255a7139fd00a5fc63a3.

9 years agoRevert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:33:45 +0000 (16:33 +0100)]
Revert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"

This reverts commit 6a149022976fe6a5579ec9afc7a4d2dcb44dc8af.

9 years agoRevert "s3: Move the global variable Protocol to struct smbd_server_connection"
Volker Lendecke [Mon, 23 Nov 2009 15:33:26 +0000 (16:33 +0100)]
Revert "s3: Move the global variable Protocol to struct smbd_server_connection"

This reverts commit c85a4c9ba4a7de65a7850f6f9708df66bd24deea.

9 years agos4:ldap.py - Add a check for the generated "schemaIDGUID"
Matthias Dieter Wallnöfer [Mon, 23 Nov 2009 15:20:07 +0000 (16:20 +0100)]
s4:ldap.py - Add a check for the generated "schemaIDGUID"

I've forgotten to add this when checking in the reworked SAMLDB module

9 years agos3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever
Volker Lendecke [Mon, 23 Nov 2009 12:58:23 +0000 (13:58 +0100)]
s3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever

9 years agos3: Move a variable declaration to its only use
Volker Lendecke [Mon, 23 Nov 2009 10:54:19 +0000 (11:54 +0100)]
s3: Move a variable declaration to its only use

9 years agos4:dsdb Move module configuration from each ldb into samba_dsdb.c
Andrew Bartlett [Mon, 23 Nov 2009 09:30:35 +0000 (20:30 +1100)]
s4:dsdb Move module configuration from each ldb into samba_dsdb.c

This makes getting the module order correct, the obligation of Samba4
developers, and not system administrators.  In particular, once an ldb
is updated to use only the 'samba_dsdb' module, no further changes to the
ldb should be required when upgrading to later Samba4 versions.

(thanks to metze for the suggestion of samba_dsdb as a long-term
stable name for the module)

Andrew Bartlett

9 years agos4:provision Simplify the module list
Andrew Bartlett [Fri, 20 Nov 2009 01:16:33 +0000 (12:16 +1100)]
s4:provision Simplify the module list

This makes the member server much more like the DC, the objectGUID
module replaces the repl_meta_data module.

We also generally rework the construction of the list, building a full
list in python, and then transforming it into a string, rather than
playing string concatonation games

Andrew Bartlett

9 years agos4/schema(tort): Refactor DSDB-SYNTAX test for better performance
Kamen Mazdrashki [Sun, 22 Nov 2009 20:21:12 +0000 (22:21 +0200)]
s4/schema(tort): Refactor DSDB-SYNTAX test for better performance

Test was implemented as a test fixture so that setup/teardown
occurs only once.
This should impact test performace as long as provision_get_schema()
is a slow function (especially when debugging)

9 years agos4/schema: Handle Object(OR-Name) syntax in extended_dn_out module
Kamen Mazdrashki [Sun, 22 Nov 2009 15:48:32 +0000 (17:48 +0200)]
s4/schema: Handle Object(OR-Name) syntax in extended_dn_out module

Windows displays attribute values with Object(OR-Name) syntax
in plain DN format when queried through LDAP.
Hence, we need to post-process such values specially
in extended_dn_out.c module so they are always shown as plain DN,
no matter what controls are passed for search request.

9 years agos4/schema: Object(OR-Name) syntax handling for DRS calls
Kamen Mazdrashki [Sun, 22 Nov 2009 12:41:25 +0000 (14:41 +0200)]
s4/schema: Object(OR-Name) syntax handling for DRS calls

OR-Name syntax through DRS calls looks like DN-Binary syntax

9 years agos4/schema(tort): Inject authOrig attribute into schema loaded for tests
Kamen Mazdrashki [Fri, 20 Nov 2009 01:07:41 +0000 (03:07 +0200)]
s4/schema(tort): Inject authOrig attribute into schema loaded for tests

9 years agos4/schema(tort): Add test for Object(OR-Name) syntax
Kamen Mazdrashki [Sun, 22 Nov 2009 12:46:09 +0000 (14:46 +0200)]
s4/schema(tort): Add test for Object(OR-Name) syntax

9 years agos4/schema(tort): Test LDB_SYNTAX_DN with extended_dn in [GUID;SID;DN] form
Kamen Mazdrashki [Fri, 20 Nov 2009 01:15:38 +0000 (03:15 +0200)]
s4/schema(tort): Test LDB_SYNTAX_DN with extended_dn in [GUID;SID;DN] form

9 years agos4/drs(tort): DSSYNC test to print what is different in drs_msg also
Kamen Mazdrashki [Mon, 16 Nov 2009 21:49:51 +0000 (23:49 +0200)]
s4/drs(tort): DSSYNC test to print what is different in drs_msg also

9 years agos4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.
Günther Deschner [Mon, 23 Nov 2009 12:35:32 +0000 (13:35 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.


9 years agos3-printing: remove duplicate code while cleaning up driver structs.
Günther Deschner [Mon, 23 Nov 2009 11:57:46 +0000 (12:57 +0100)]
s3-printing: remove duplicate code while cleaning up driver structs.


9 years agos3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.
Günther Deschner [Wed, 18 Nov 2009 14:39:52 +0000 (15:39 +0100)]
s3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.


9 years agos3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.
Günther Deschner [Tue, 17 Nov 2009 11:55:45 +0000 (12:55 +0100)]
s3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.


9 years agos3-printing: use spoolss types and structs while getting and deleting drivers.
Günther Deschner [Tue, 17 Nov 2009 11:54:02 +0000 (12:54 +0100)]
s3-printing: use spoolss types and structs while getting and deleting drivers.


9 years agos3-printing: use spoolss types and structs while adding drivers.
Günther Deschner [Mon, 16 Nov 2009 14:52:31 +0000 (15:52 +0100)]
s3-printing: use spoolss types and structs while adding drivers.


9 years agos4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.
Günther Deschner [Fri, 20 Nov 2009 15:33:29 +0000 (16:33 +0100)]
s4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.


9 years agos3-spoolss: fix spoolss_EnumPrinterKey client and server code.
Günther Deschner [Fri, 20 Nov 2009 15:34:00 +0000 (16:34 +0100)]
s3-spoolss: fix spoolss_EnumPrinterKey client and server code.


9 years agospoolss: fix spoolss_EnumPrinterKey IDL.
Günther Deschner [Fri, 20 Nov 2009 11:57:13 +0000 (12:57 +0100)]
spoolss: fix spoolss_EnumPrinterKey IDL.


9 years agos3: Fix bug 6338 -- net rpc trustdom list always display "none"
Volker Lendecke [Sun, 22 Nov 2009 21:38:45 +0000 (22:38 +0100)]
s3: Fix bug 6338 -- net rpc trustdom list always display "none"