kai/samba.git
12 years agos3:torture: add SMB2-NEGPROT test
Stefan Metzmacher [Tue, 30 Aug 2011 16:50:35 +0000 (18:50 +0200)]
s3:torture: add SMB2-NEGPROT test

metze

12 years agos3:smb2cli: remove unused smb2cli_negprot()
Stefan Metzmacher [Sat, 17 Sep 2011 22:11:54 +0000 (00:11 +0200)]
s3:smb2cli: remove unused smb2cli_negprot()

metze

12 years agos3:SMB2-BASIC: use smbXcli_negprot() directly
Stefan Metzmacher [Tue, 30 Aug 2011 09:38:26 +0000 (11:38 +0200)]
s3:SMB2-BASIC: use smbXcli_negprot() directly

metze

12 years agos3:smb2cli: pass struct smbXcli_conn directly to smb2cli_req_create/_send()
Stefan Metzmacher [Wed, 7 Sep 2011 16:44:21 +0000 (18:44 +0200)]
s3:smb2cli: pass struct smbXcli_conn directly to smb2cli_req_create/_send()

metze

12 years agos3:libsmb: implement cli_state based functions on top of smbXcli_conn/smbXcli_req
Stefan Metzmacher [Thu, 22 Sep 2011 19:09:00 +0000 (21:09 +0200)]
s3:libsmb: implement cli_state based functions on top of smbXcli_conn/smbXcli_req

metze

12 years agosmbXcli: add smb2cli_req_set_notify_async()
Stefan Metzmacher [Thu, 27 Oct 2011 15:20:27 +0000 (17:20 +0200)]
smbXcli: add smb2cli_req_set_notify_async()

That can be used if the caller wants to be notified if
the async interim response arrives.

metze

12 years agosmbXcli: add support for tevent_req_cancel() on smbXcli_req
Stefan Metzmacher [Sat, 24 Sep 2011 04:06:46 +0000 (06:06 +0200)]
smbXcli: add support for tevent_req_cancel() on smbXcli_req

metze

12 years agosmbXcli: fix smb signing for SMBntcancel
Stefan Metzmacher [Fri, 18 Nov 2011 08:24:11 +0000 (09:24 +0100)]
smbXcli: fix smb signing for SMBntcancel

metze

12 years agosmbXcli: add smb2cli_session_create_channel()
Stefan Metzmacher [Mon, 19 Sep 2011 17:05:20 +0000 (19:05 +0200)]
smbXcli: add smb2cli_session_create_channel()

This makes it possible to implement SMB 2.22 Multi-Channel
for testing.

metze

12 years agos3:smb2cli: add forward declaration for struct cli_state
Stefan Metzmacher [Thu, 22 Sep 2011 20:16:51 +0000 (22:16 +0200)]
s3:smb2cli: add forward declaration for struct cli_state

metze

12 years agos3:smb2cli: make smb2cli_session_setup_send/recv non-static
Stefan Metzmacher [Mon, 19 Sep 2011 03:37:34 +0000 (05:37 +0200)]
s3:smb2cli: make smb2cli_session_setup_send/recv non-static

metze

12 years agos3:smb2cli: make use of smbXcli_session and setup the session key for SMB2 signing
Stefan Metzmacher [Sat, 3 Sep 2011 08:18:17 +0000 (10:18 +0200)]
s3:smb2cli: make use of smbXcli_session and setup the session key for SMB2 signing

metze

12 years agosmbXcli: add support for smb2 signing
Stefan Metzmacher [Sat, 3 Sep 2011 08:18:32 +0000 (10:18 +0200)]
smbXcli: add support for smb2 signing

metze

12 years agosmbXcli: add smbXcli_session infrastructure
Stefan Metzmacher [Sat, 3 Sep 2011 08:18:17 +0000 (10:18 +0200)]
smbXcli: add smbXcli_session infrastructure

metze

12 years agos3:smb2cli: implement smb2cli_negprot() on top of smbXcli_negprot()
Stefan Metzmacher [Fri, 16 Sep 2011 15:26:22 +0000 (17:26 +0200)]
s3:smb2cli: implement smb2cli_negprot() on top of smbXcli_negprot()

metze

12 years agosmbXcli: add support for PROTOCOL_SMB2_22 in smbXcli_negprot()
Stefan Metzmacher [Fri, 16 Sep 2011 14:12:50 +0000 (16:12 +0200)]
smbXcli: add support for PROTOCOL_SMB2_22 in smbXcli_negprot()

metze

12 years agosmbXcli: add support for SMB2 multi-credit requests
Stefan Metzmacher [Tue, 6 Sep 2011 15:52:02 +0000 (17:52 +0200)]
smbXcli: add support for SMB2 multi-credit requests

metze

12 years agosmbXcli: add support for 2.??? negprot and PROTOCOL_SMB2_10
Stefan Metzmacher [Tue, 30 Aug 2011 09:04:46 +0000 (11:04 +0200)]
smbXcli: add support for 2.??? negprot and PROTOCOL_SMB2_10

metze

12 years agosmbXcli: pass client_guid to smbXcli_conn_create()
Stefan Metzmacher [Thu, 15 Sep 2011 11:21:42 +0000 (13:21 +0200)]
smbXcli: pass client_guid to smbXcli_conn_create()

metze

12 years agosmbXcli: add smbXcli_negprot_*
Stefan Metzmacher [Thu, 15 Sep 2011 11:12:43 +0000 (13:12 +0200)]
smbXcli: add smbXcli_negprot_*

This supports negotiation of any SMB1 or SMB2 dialect.

metze

12 years agosmbXcli: add helper functions to access the negotiated features
Stefan Metzmacher [Thu, 15 Sep 2011 12:02:49 +0000 (14:02 +0200)]
smbXcli: add helper functions to access the negotiated features

metze

12 years agosmbXcli: also notify chained requests about broken connections
Stefan Metzmacher [Fri, 18 Nov 2011 09:30:33 +0000 (10:30 +0100)]
smbXcli: also notify chained requests about broken connections

metze

12 years agosmbXcli: simplify smb1cli_req_chain_submit()
Stefan Metzmacher [Fri, 18 Nov 2011 09:28:40 +0000 (10:28 +0100)]
smbXcli: simplify smb1cli_req_chain_submit()

We should hang everything on the first request in the chain,
as that's the one that gets added to the pending array.

metze

12 years agosmbXcli: remove unused smb1cli_have_andx_command()
Stefan Metzmacher [Wed, 16 Nov 2011 10:38:24 +0000 (11:38 +0100)]
smbXcli: remove unused smb1cli_have_andx_command()

metze

12 years agosmbXcli: reorder smb1cli_conn_dispatch_incoming() to avoid too much nesting
Stefan Metzmacher [Mon, 21 Nov 2011 12:08:58 +0000 (13:08 +0100)]
smbXcli: reorder smb1cli_conn_dispatch_incoming() to avoid too much nesting

metze

12 years agosmbXcli: rework smb1cli_req_recv() to expose an iov with 3 elements
Stefan Metzmacher [Wed, 16 Nov 2011 10:37:05 +0000 (11:37 +0100)]
smbXcli: rework smb1cli_req_recv() to expose an iov with 3 elements

Each smb1cli_req has 3 iov elements
[SMB HDR, SMB Parameter Block, SMB Data Block].

The 'inbuf' is still exposed if the caller requires it
(until we fix all legacy callers).

The can now pass an array of expected [status,wct] combinations,
instead of just one expected min_wct.

metze

12 years agosmbXcli: use smb1cli_inbuf_parse_chain() and remember more details per chain response
Stefan Metzmacher [Wed, 16 Nov 2011 10:35:50 +0000 (11:35 +0100)]
smbXcli: use smb1cli_inbuf_parse_chain() and remember more details per chain response

metze

12 years agosmbXcli: add smb1cli_inbuf_parse_chain()
Stefan Metzmacher [Wed, 16 Nov 2011 10:20:15 +0000 (11:20 +0100)]
smbXcli: add smb1cli_inbuf_parse_chain()

metze

12 years agosmbXcli: pass hdr to smb1cli_pull_raw_error()
Stefan Metzmacher [Wed, 16 Nov 2011 10:14:16 +0000 (11:14 +0100)]
smbXcli: pass hdr to smb1cli_pull_raw_error()

metze

12 years agosmbXcli: add state->smb1.recv_{cmd,status,iov}
Stefan Metzmacher [Wed, 16 Nov 2011 10:11:18 +0000 (11:11 +0100)]
smbXcli: add state->smb1.recv_{cmd,status,iov}

In the following commits we will need to remember a few more things.

metze

12 years agosmbXcli: split out a smb1cli_req_flags() function
Stefan Metzmacher [Wed, 7 Sep 2011 17:07:51 +0000 (19:07 +0200)]
smbXcli: split out a smb1cli_req_flags() function

metze

12 years agosmbXcli: set message id to UINT64_MAX for BREAK in smb2cli_req_create()
Stefan Metzmacher [Thu, 22 Sep 2011 19:24:42 +0000 (21:24 +0200)]
smbXcli: set message id to UINT64_MAX for BREAK in smb2cli_req_create()

This way the caller can register an oplock handler.

Note that smb2cli_req_compound_submit() will overwrite this
if a request is send over the wire.

metze

12 years agos3:smb2cli: replace smb2cli_base.c code with the more generic smbXcli_base.c code
Stefan Metzmacher [Thu, 15 Sep 2011 10:46:59 +0000 (12:46 +0200)]
s3:smb2cli: replace smb2cli_base.c code with the more generic smbXcli_base.c code

metze

12 years agosmbXcli: rework smb2cli_req to smbXcli_conn/smbXcli_req
Stefan Metzmacher [Thu, 15 Sep 2011 10:23:05 +0000 (12:23 +0200)]
smbXcli: rework smb2cli_req to smbXcli_conn/smbXcli_req

metze

12 years agolibcli/smb: copy smb2cli_req_* code to smbXcli_base.c
Stefan Metzmacher [Thu, 15 Sep 2011 09:47:11 +0000 (11:47 +0200)]
libcli/smb: copy smb2cli_req_* code to smbXcli_base.c

metze

12 years agosmbXcli: rework smbXcli_base.c to use smbXcli_conn/smbXcli_req
Stefan Metzmacher [Thu, 11 Aug 2011 11:29:59 +0000 (13:29 +0200)]
smbXcli: rework smbXcli_base.c to use smbXcli_conn/smbXcli_req

This splits the low level smb code from 'struct cli_state'
and makes it much more generic and useful for testing.

metze

12 years agosmbXcli: cp source3/libsmb/async_smb.c libcli/smb/smbXcli_base.c
Stefan Metzmacher [Mon, 18 Jul 2011 12:35:03 +0000 (14:35 +0200)]
smbXcli: cp source3/libsmb/async_smb.c libcli/smb/smbXcli_base.c

metze

12 years agosecurity: add local authority well-known SIDs
Christian Ambach [Thu, 1 Sep 2011 14:09:01 +0000 (16:09 +0200)]
security: add local authority well-known SIDs

add the S-1-2 well-known SID family

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu Nov 24 19:01:08 CET 2011 on sn-devel-104

12 years agos3:smb2 report access_based_dir_enum in tcon reply
Christian Ambach [Thu, 24 Nov 2011 13:42:21 +0000 (14:42 +0100)]
s3:smb2 report access_based_dir_enum in tcon reply

let the client know when hide unreadable or hide unwriteable files
is set for a share

12 years agos3:smb2 do not set allow_namespace_caching flag for a share
Christian Ambach [Thu, 24 Nov 2011 12:49:17 +0000 (13:49 +0100)]
s3:smb2 do not set allow_namespace_caching flag for a share

this matches Win7/2002R2 behavior and clients also must ignore
this flag when set (MS-SMB 2.2.10), so we should not set it at all

12 years agos3:vfs:gpfs remove non-working code
Christian Ambach [Thu, 24 Nov 2011 15:57:58 +0000 (16:57 +0100)]
s3:vfs:gpfs remove non-working code

when development of vfs_gpfs was started a long time ago it was
considered a good idea to have it compileable even if GPFS is not
around and then the module would complain in the logs that libgpfs
is not there

Nowadays this does not work any more as the code contains GPFS
specific types that need the GPFS header files.

Instead of making it compile again by adding GPFS typedefs, this
removes the whole approach. Other VFS modules also do not even
compile when necessary headers are not around, so do the same for
the GPFS module code.

12 years agos3:vfs:gpfs fix some compiler warnings
Christian Ambach [Thu, 24 Nov 2011 14:58:36 +0000 (15:58 +0100)]
s3:vfs:gpfs fix some compiler warnings

12 years agos3:vfs:gpfs convert syncio parameter
Christian Ambach [Thu, 24 Nov 2011 12:39:01 +0000 (13:39 +0100)]
s3:vfs:gpfs convert syncio parameter

convert syncio parameter to be stored in the VFS handle data
this removes the need to go through lp_parm_bool() on each open

12 years agos4 dns: Test QCLASS_NONE query
Kai Blin [Thu, 24 Nov 2011 11:14:55 +0000 (12:14 +0100)]
s4 dns: Test QCLASS_NONE query

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Thu Nov 24 14:10:45 CET 2011 on sn-devel-104

12 years agos4 dns: Test QTYPE_ALL query
Kai Blin [Thu, 24 Nov 2011 11:11:26 +0000 (12:11 +0100)]
s4 dns: Test QTYPE_ALL query

12 years agos4 dns: Check more of the returned values for the A query
Kai Blin [Thu, 24 Nov 2011 11:10:40 +0000 (12:10 +0100)]
s4 dns: Check more of the returned values for the A query

12 years agos4 dns: Move dns_transaction_udp to other helper functions
Kai Blin [Thu, 24 Nov 2011 11:09:58 +0000 (12:09 +0100)]
s4 dns: Move dns_transaction_udp to other helper functions

12 years agopidl:Samba4/NDR/Parser: don't generate code for [ignore] pointers
Stefan Metzmacher [Wed, 23 Nov 2011 14:23:48 +0000 (15:23 +0100)]
pidl:Samba4/NDR/Parser: don't generate code for [ignore] pointers

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 24 12:31:04 CET 2011 on sn-devel-104

12 years agoRemove unused variable.
Jeremy Allison [Wed, 23 Nov 2011 21:42:09 +0000 (13:42 -0800)]
Remove unused variable.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Nov 24 00:17:41 CET 2011 on sn-devel-104

12 years agoFix uninitialized variable frees on error paths.
Jeremy Allison [Wed, 23 Nov 2011 19:59:53 +0000 (11:59 -0800)]
Fix uninitialized variable frees on error paths.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Nov 23 22:38:13 CET 2011 on sn-devel-104

12 years agos3: Fix a valgrind error
Volker Lendecke [Wed, 23 Nov 2011 16:43:35 +0000 (17:43 +0100)]
s3: Fix a valgrind error

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov 23 19:17:20 CET 2011 on sn-devel-104

12 years agos3: Move server_info_struct to nmbd
Volker Lendecke [Wed, 23 Nov 2011 15:14:10 +0000 (16:14 +0100)]
s3: Move server_info_struct to nmbd

That's the only place where it's used.

12 years agos3: Replace delete_token_list by an array
Volker Lendecke [Mon, 21 Nov 2011 16:12:00 +0000 (17:12 +0100)]
s3: Replace delete_token_list by an array

This will make it easier to convert locking.tdb to IDL, and I don't think there
will be enough entries to justify a linked list over an array.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov 23 09:02:12 CET 2011 on sn-devel-104

12 years agoEnsure we don't free uninitialized variables.
Jeremy Allison [Tue, 22 Nov 2011 23:53:26 +0000 (15:53 -0800)]
Ensure we don't free uninitialized variables.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Nov 23 02:27:53 CET 2011 on sn-devel-104

12 years agoRemove the setting of the inherited ACL on new files/directories. This is
Jeremy Allison [Tue, 22 Nov 2011 20:33:54 +0000 (12:33 -0800)]
Remove the setting of the inherited ACL on new files/directories. This is
now done correctly in the main codepath. The vfs_acl_XXXX modules are
now thin shims that simply store/retrieve ACLs as they should be.

12 years agoMove setting the inherited ACL into the main open code path. Next will
Jeremy Allison [Tue, 22 Nov 2011 20:33:27 +0000 (12:33 -0800)]
Move setting the inherited ACL into the main open code path. Next will
remove it from the ACL modules.

12 years agoMove the "set SD" code into provided SD and "inherit acls" branches.
Jeremy Allison [Tue, 22 Nov 2011 19:53:51 +0000 (11:53 -0800)]
Move the "set SD" code into provided SD and "inherit acls" branches.

12 years agoOnly add the SD if it's not a new stream file.
Jeremy Allison [Tue, 22 Nov 2011 18:37:56 +0000 (10:37 -0800)]
Only add the SD if it's not a new stream file.

12 years agoMove the add security descriptor code to *after* all the other meta-data is
Jeremy Allison [Tue, 22 Nov 2011 18:28:52 +0000 (10:28 -0800)]
Move the add security descriptor code to *after* all the other meta-data is
updated. We may be adding an SD that restricts our own access.

12 years agos3: Fix wb_next_pwent_fill_done
Volker Lendecke [Tue, 22 Nov 2011 16:37:07 +0000 (17:37 +0100)]
s3: Fix wb_next_pwent_fill_done

Within a callback routine it is not possible to call tevent_req_post

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov 22 19:17:30 CET 2011 on sn-devel-104

12 years agos3 libaddns: Prevent a crash when dns_create_update fails
Kai Blin [Tue, 22 Nov 2011 10:26:04 +0000 (11:26 +0100)]
s3 libaddns: Prevent a crash when dns_create_update fails

When dns_create_update() fails, it does not initialize *req, and then TALLOC_FREE(req) in the
error handling crashes if we're lucky.
Instead of going into the generic error handling, treat the failure in dns_create_update() like
dns_create_update_request() and just pass on the error.

Thanks to Harry Mason for reporting this issue.

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Tue Nov 22 14:29:07 CET 2011 on sn-devel-104

12 years agos4-dns: added --no-credentials option to samba_dnsupdate
Andrew Tridgell [Tue, 22 Nov 2011 03:58:29 +0000 (14:58 +1100)]
s4-dns: added --no-credentials option to samba_dnsupdate

this is for a user who is doing DNS updates via key files rather than
GSSAPI. This allows the update to go through without a kerberos error

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Nov 22 06:34:59 CET 2011 on sn-devel-104

12 years agoFix a bunch of "warning: variable ‘XXXX’ set but not used [-Wunused-but-set-variable...
Jeremy Allison [Mon, 21 Nov 2011 21:06:00 +0000 (13:06 -0800)]
Fix a bunch of "warning: variable ‘XXXX’ set but not used [-Wunused-but-set-variable]" warnings from the new gcc.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Nov 21 23:39:08 CET 2011 on sn-devel-104

12 years agos3:winbindd_cm: close sockfd on error in cm_prepare_connection()
Stefan Metzmacher [Mon, 21 Nov 2011 17:03:44 +0000 (18:03 +0100)]
s3:winbindd_cm: close sockfd on error in cm_prepare_connection()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 21 19:58:58 CET 2011 on sn-devel-104

12 years agos3:libsmb: close fd on error in cli_connect_nb()
Stefan Metzmacher [Mon, 21 Nov 2011 17:03:07 +0000 (18:03 +0100)]
s3:libsmb: close fd on error in cli_connect_nb()

metze

12 years agolibrpc: install drsuapi and drsblobs headers.
Günther Deschner [Mon, 21 Nov 2011 12:13:11 +0000 (13:13 +0100)]
librpc: install drsuapi and drsblobs headers.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Nov 21 17:24:28 CET 2011 on sn-devel-104

12 years agos3-waf: remove version from libpdb.so for now.
Günther Deschner [Mon, 21 Nov 2011 11:55:04 +0000 (12:55 +0100)]
s3-waf: remove version from libpdb.so for now.

Guenther

12 years agos4-smbtorture: add ndr test for nbt_netlogon_packet to avoid future regressions.
Günther Deschner [Fri, 18 Nov 2011 14:38:02 +0000 (15:38 +0100)]
s4-smbtorture: add ndr test for nbt_netlogon_packet to avoid future regressions.

Guys, we really should make sure to always add ndr tests like this whenever we
change some sensitive libndr or handmarshalling bits.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Sun Nov 20 23:10:39 CET 2011 on sn-devel-104

12 years agos3:smb2_negprot: add support for SMB2_22
Stefan Metzmacher [Sat, 19 Nov 2011 13:02:22 +0000 (14:02 +0100)]
s3:smb2_negprot: add support for SMB2_22

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Nov 20 16:46:45 CET 2011 on sn-devel-104

12 years agolib/param: add "SMB2_22" to enum_protocol
Stefan Metzmacher [Sat, 19 Nov 2011 13:01:25 +0000 (14:01 +0100)]
lib/param: add "SMB2_22" to enum_protocol

metze

12 years agos4-dsdb: Modify the repl_meta_data behavior to allow Metadata change on attribute...
Matthieu Patou [Fri, 18 Nov 2011 23:37:27 +0000 (00:37 +0100)]
s4-dsdb: Modify the repl_meta_data behavior to allow Metadata change on attribute interSiteTopologyGenerator even if the value didn't change

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sat Nov 19 16:47:53 CET 2011 on sn-devel-104

12 years agosocket_wrapper/py_socket_wrapper.c - include Python 2.4 compatiblity code
Matthias Dieter Wallnöfer [Sat, 19 Nov 2011 11:59:01 +0000 (12:59 +0100)]
socket_wrapper/py_socket_wrapper.c - include Python 2.4 compatiblity code

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Nov 19 14:53:43 CET 2011 on sn-devel-104

12 years agoRemove rawmemchr calls - found by Ira Cooper. These are glibc-specific calls, makes...
Jeremy Allison [Fri, 18 Nov 2011 21:13:02 +0000 (13:13 -0800)]
Remove rawmemchr calls - found by Ira Cooper. These are glibc-specific calls, makes us completely non-portable.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 18 23:50:50 CET 2011 on sn-devel-104

12 years agos3/packaging: Fix rpm build issues on RHEL4.
Karolin Seeger [Thu, 17 Nov 2011 20:23:09 +0000 (21:23 +0100)]
s3/packaging: Fix rpm build issues on RHEL4.

Second part of a fix for bug #7705 (RHEL samba.spec broken - and fix).
Based on patches of Jason Haar and Daniël van Eeden. Thanks a lot!

Karolin

Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Fri Nov 18 22:13:06 CET 2011 on sn-devel-104

12 years agos3:libsmb: verify num_setup for SMBnttrans in cli_pull_trans()
Stefan Metzmacher [Fri, 18 Nov 2011 12:20:43 +0000 (13:20 +0100)]
s3:libsmb: verify num_setup for SMBnttrans in cli_pull_trans()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov 18 15:13:52 CET 2011 on sn-devel-104

12 years agos3:libsmb: fix compiler warning in cli_pull_trans()
Stefan Metzmacher [Fri, 18 Nov 2011 12:19:19 +0000 (13:19 +0100)]
s3:libsmb: fix compiler warning in cli_pull_trans()

metze

12 years agos3:libsmb: only align unicode pipe_name (bug #8586)
Stefan Metzmacher [Fri, 18 Nov 2011 07:40:18 +0000 (08:40 +0100)]
s3:libsmb: only align unicode pipe_name (bug #8586)

metze

12 years agos3: Fix bug 8371
Volker Lendecke [Thu, 17 Nov 2011 21:36:22 +0000 (22:36 +0100)]
s3: Fix bug 8371

ndr_set_flag or's in the given flag (ALIGN4). At this point, ndr->flags
contains NOALIGN, which will persist. In ndr_push_DATA_BLOB NOALIGN overrides
everything else, so that the ALIGN4 is not respected.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Nov 18 09:33:37 CET 2011 on sn-devel-104

12 years agos3-py-passdb: Fix handling of uninitialized gid values
Amitay Isaacs [Fri, 18 Nov 2011 03:35:56 +0000 (14:35 +1100)]
s3-py-passdb: Fix handling of uninitialized gid values

Uninitialized gid value is set to -1 and return as such from python
passdb api.

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Nov 18 06:18:33 CET 2011 on sn-devel-104

12 years agodsdb: Fix the password expiry calculation
Amitay Isaacs [Thu, 17 Nov 2011 23:34:44 +0000 (10:34 +1100)]
dsdb: Fix the password expiry calculation

As per Section 3.1.1.4.5.26 [MS-ADTS.pdf], password is expired if

  pwdLastSet = null, or
  pwdLastSet = 0, or
  (maxPwdAge != 0x8000000000000000 and (ST - pwdLastSet) > maxPwdAge)

12 years agos3-passdb_test: Policy values are converted to signed integer
Amitay Isaacs [Thu, 17 Nov 2011 22:55:38 +0000 (09:55 +1100)]
s3-passdb_test: Policy values are converted to signed integer

No need to check value for 0xffffffff (4294967295).

12 years agos4-s3-upgrade: Add --verbose option to print extra details
Amitay Isaacs [Thu, 17 Nov 2011 07:51:14 +0000 (18:51 +1100)]
s4-s3-upgrade: Add --verbose option to print extra details

12 years agos4-auth log details about any token we fail to convert to a unix token
Andrew Bartlett [Thu, 17 Nov 2011 07:24:24 +0000 (18:24 +1100)]
s4-auth log details about any token we fail to convert to a unix token

Now that entries are being added into the idmap DB from Samba3, and
may be UID or GID but not BOTH, failures are more likely.

Andrew Bartlett

12 years agos4-s3-upgrade: Fix idmap types ID_TYPE_UID/ID_TYPE_GID instead of UID/GID
Amitay Isaacs [Thu, 17 Nov 2011 05:08:16 +0000 (16:08 +1100)]
s4-s3-upgrade: Fix idmap types ID_TYPE_UID/ID_TYPE_GID instead of UID/GID

12 years agosamba-tool: Fix the domain account policy max_pwd_age calculation
Amitay Isaacs [Wed, 16 Nov 2011 22:34:57 +0000 (09:34 +1100)]
samba-tool: Fix the domain account policy max_pwd_age calculation

Windows sets maxPwdAge to -0x8000000000000000 when maximum password
age is set to 0 days.

12 years agos4-s3-upgrade: Fix the minimum and maximum password age calculation
Amitay Isaacs [Wed, 16 Nov 2011 01:59:52 +0000 (12:59 +1100)]
s4-s3-upgrade: Fix the minimum and maximum password age calculation

Windows sets maxPwdAge to -0x8000000000000000 when maximum password age
is set to 0 days.

12 years agos4-s3-upgrade now look for -1 as the special 'not set' value
Andrew Bartlett [Wed, 16 Nov 2011 05:51:06 +0000 (16:51 +1100)]
s4-s3-upgrade now look for -1 as the special 'not set' value

this is possible because we know the py_passdb will always set -1
here, not passing though 0xFFFFFFFF.

Andrew Bartlett

12 years agos3/packaging: Fix rpm build issues on RHEL.
Karolin Seeger [Thu, 17 Nov 2011 20:02:30 +0000 (21:02 +0100)]
s3/packaging: Fix rpm build issues on RHEL.

Fix bug #7705 (RHEL samba.spec broken - and fix).
Based on patches of Jason Haar and Daniël van Eeden. Thanks a lot!

Karolin

Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Thu Nov 17 23:05:28 CET 2011 on sn-devel-104

12 years agos4 dns: Reduce test output noise by upping log level for dns_name_packet logging
Kai Blin [Tue, 15 Nov 2011 07:38:27 +0000 (08:38 +0100)]
s4 dns: Reduce test output noise by upping log level for dns_name_packet logging

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Thu Nov 17 20:10:05 CET 2011 on sn-devel-104

12 years agos4 dns: Add a first test case
Kai Blin [Thu, 10 Nov 2011 23:32:09 +0000 (00:32 +0100)]
s4 dns: Add a first test case

12 years agos4 dns: Turn on internal DNS server during testing
Kai Blin [Mon, 7 Nov 2011 23:34:01 +0000 (00:34 +0100)]
s4 dns: Turn on internal DNS server during testing

12 years agosocket_wrapper: Added python interface to socket_wrapper
Amitay Isaacs [Fri, 14 Oct 2011 06:24:16 +0000 (17:24 +1100)]
socket_wrapper: Added python interface to socket_wrapper

The socket_wrapper does not support setting blocking flag or
timeouts on the sockets.

To use socket module in python, use

from samba import socket

Signed-off-by: Kai Blin <kai@samba.org>
12 years agosamba.tests.dsdb: Import TestCase from samba.tests.
Jelmer Vernooij [Thu, 17 Nov 2011 01:31:13 +0000 (02:31 +0100)]
samba.tests.dsdb: Import TestCase from samba.tests.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Nov 17 08:36:17 CET 2011 on sn-devel-104

12 years agosamba.tests: Make sure testtools is available before importing it.
Jelmer Vernooij [Thu, 17 Nov 2011 01:30:38 +0000 (02:30 +0100)]
samba.tests: Make sure testtools is available before importing it.

12 years agoImprove configure.in so it can be used outside the Samba source tree.
Richard Sharpe [Mon, 14 Nov 2011 15:47:38 +0000 (07:47 -0800)]
Improve configure.in so it can be used outside the Samba source tree.

Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Thu Nov 17 07:00:38 CET 2011 on sn-devel-104

12 years agoldb: Add handy macros for reporting error inside ldb module
Amitay Isaacs [Tue, 15 Nov 2011 01:34:40 +0000 (12:34 +1100)]
ldb: Add handy macros for reporting error inside ldb module

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Thu Nov 17 05:24:46 CET 2011 on sn-devel-104

12 years agos4-dsdb: Remove unsed variable
Amitay Isaacs [Mon, 14 Nov 2011 06:34:17 +0000 (17:34 +1100)]
s4-dsdb: Remove unsed variable

12 years agos3-smbldap: move ldap_open_with_timeout out of smb_ldap.h to ads where it lives.
Günther Deschner [Wed, 16 Nov 2011 23:55:04 +0000 (00:55 +0100)]
s3-smbldap: move ldap_open_with_timeout out of smb_ldap.h to ads where it lives.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Nov 17 03:47:53 CET 2011 on sn-devel-104

12 years agos3-smbldap: remove duplicate LDAP_OPT_SUCCESS define.
Günther Deschner [Wed, 16 Nov 2011 23:44:41 +0000 (00:44 +0100)]
s3-smbldap: remove duplicate LDAP_OPT_SUCCESS define.

Guenther

12 years agos3-winbindd: no need to globally include ldap headers in winbindd.
Günther Deschner [Wed, 16 Nov 2011 21:53:24 +0000 (22:53 +0100)]
s3-winbindd: no need to globally include ldap headers in winbindd.

Guenther