Gerald Carter [Mon, 27 Jun 2005 03:40:03 +0000 (03:40 +0000)]
r7938: * move the hardcoded registry value names from _reg_query_value()
to a thin layer in fetch_reg_values(). Not entirely efficient
seeing as the the dynamic value paths are stored in an unsorted
array but it is one strequal() per path. If this was really big
it should be worked into the reghook_cache().
Gerald Carter [Sat, 25 Jun 2005 17:31:40 +0000 (17:31 +0000)]
r7908: * change REGISTRY_HOOK api to use const (fix compiler warning
in init_registry_data()
* Add means of storing registry values in registry.tdb
* add builtin_registry_values[] array for REG_DWORD and REG_SZ
values needed during startup
* Finish up RegDeleteValue() and RegSetValue()
* Finish up regdb_store_reg_values() and regdb_fetch_reg_values()
I can now create and retrieve values using regedit.exe on Win2k.
bin/net -S rain -U% rpc registry enumerate 'hklm\software\samba'
Valuename = Version
Type = REG_SZ
Data = 3.0.20
Next is to do the virtual writes in reg_printing.c and I'll be
done with Print Migrator (yeah! finally)
Volker Lendecke [Sat, 25 Jun 2005 13:06:23 +0000 (13:06 +0000)]
r7904: Fix a memleak in vfs_afsacl
Volker Lendecke [Sat, 25 Jun 2005 10:13:07 +0000 (10:13 +0000)]
r7903: Attempt to fix the AIX build
Volker Lendecke [Sat, 25 Jun 2005 09:07:42 +0000 (09:07 +0000)]
r7902: Fix the build
Jeremy Allison [Sat, 25 Jun 2005 03:03:44 +0000 (03:03 +0000)]
r7893: Add in the extra parameters to opendir() to fix the large directory/insane app
problem. Rev vfs version. Doesn't change the normal codepath.
Jeremy.
Gerald Carter [Fri, 24 Jun 2005 22:34:40 +0000 (22:34 +0000)]
r7890: * add Reg[SG]etKeySec() server stubs
* merge a compile warning fix from trunk to SAMBA_3_0
Jeremy Allison [Fri, 24 Jun 2005 21:43:36 +0000 (21:43 +0000)]
r7888: Fix use of "protected".
Jeremy.
Gerald Carter [Fri, 24 Jun 2005 21:40:56 +0000 (21:40 +0000)]
r7887: 3.0.20pre2-SVN
Jeremy Allison [Fri, 24 Jun 2005 21:18:20 +0000 (21:18 +0000)]
r7886: Fix building with pam_smbpass.
Jeremy.
Jeremy Allison [Fri, 24 Jun 2005 20:25:18 +0000 (20:25 +0000)]
r7882: Looks like a large patch - but what it actually does is make Samba
safe for using our headers and linking with C++ modules. Stops us
from using C++ reserved keywords in our code.
Jeremy
Gerald Carter [Fri, 24 Jun 2005 15:49:02 +0000 (15:49 +0000)]
r7880: fix a typo and memleak on failures cases (patch from marcin)
Gerald Carter [Fri, 24 Jun 2005 15:13:25 +0000 (15:13 +0000)]
r7879: fix compile issue caused by not statoc value for intializing cpp macros
Gerald Carter [Fri, 24 Jun 2005 14:55:09 +0000 (14:55 +0000)]
r7878: mostly just a rename of REG_INFO to REG_QUERY_VALUE for better clarity
Volker Lendecke [Fri, 24 Jun 2005 14:25:18 +0000 (14:25 +0000)]
r7877: Attempt to fix a smb_panic reported by Pavel Rochnyack.
Volker
Günther Deschner [Fri, 24 Jun 2005 14:15:31 +0000 (14:15 +0000)]
r7876: Now that we have "net rpc share migrate security" completly remove the
share-acl from "net rpc share migrate shares".
God, how ugly does this syntax get.
Guenther
Jeremy Allison [Thu, 23 Jun 2005 23:23:16 +0000 (23:23 +0000)]
r7852: Correct fix from Lars for the argv issue.
Jeremy.
Jeremy Allison [Thu, 23 Jun 2005 22:20:37 +0000 (22:20 +0000)]
r7849: Dodgy fix - we shouldn't be assuming argc++ points to a valid argv.
Jeremy.
Jeremy Allison [Thu, 23 Jun 2005 17:00:11 +0000 (17:00 +0000)]
r7846: Fix from bugzilla@kevinjamieson.com Kevin Jamieson - typo
in checking for .. in statcache. Bugid #2819.
Jeremy.
Jeremy Allison [Wed, 22 Jun 2005 21:20:41 +0000 (21:20 +0000)]
r7842: With the patch I sent Steve yesterday this gives us complete POSIX pathnames.
ie. files containing : and \ can be accessed from Linux.
Jeremy.
Gerald Carter [Wed, 22 Jun 2005 20:33:30 +0000 (20:33 +0000)]
r7839: remove C++ style comment
Gerald Carter [Wed, 22 Jun 2005 18:03:38 +0000 (18:03 +0000)]
r7838: lie about the printer status when doing the queryvalue() registry call. Note that if you migrate a printer to a Windows server, the win spooler will remove any printers that have an invalid status value in the registry
Volker Lendecke [Wed, 22 Jun 2005 14:16:10 +0000 (14:16 +0000)]
r7836: Fix the bug where users show up as trusting domains.
Volker
Volker Lendecke [Wed, 22 Jun 2005 07:00:26 +0000 (07:00 +0000)]
r7835: Add the forgotten GPL header. This source code file is distributed with Samba
and interfaces to the Linux kernel (both GPL programs), so it was always our
(Paal-Kr. Engstad and Volker Lendecke) intent that this program is covered by
the GPL.
Volker
Gerald Carter [Wed, 22 Jun 2005 03:05:54 +0000 (03:05 +0000)]
r7830: fix directory typo with testprns manpage
Gerald Carter [Wed, 22 Jun 2005 02:51:22 +0000 (02:51 +0000)]
r7829: fix unitialized printer status field that was breaking migration of print queues
Gerald Carter [Tue, 21 Jun 2005 22:46:34 +0000 (22:46 +0000)]
r7825: Fedora packaging fixes after docs change
Gerald Carter [Tue, 21 Jun 2005 22:13:58 +0000 (22:13 +0000)]
r7822: fixing specfiles after removing testprns
Jeremy Allison [Tue, 21 Jun 2005 21:26:29 +0000 (21:26 +0000)]
r7821: Don't check permissions for setting POSIX pathname request.
Jeremy.
Derrell Lipman [Tue, 21 Jun 2005 20:34:24 +0000 (20:34 +0000)]
r7817: Eliminate use of ctime_r() in libsmbclient DEBUG statement. It seems that
ctime_r() takes different parameters on Solaris than it does on Linux, and
it's easier to just eliminate the use of it than to write a configure test.
Günther Deschner [Tue, 21 Jun 2005 11:27:17 +0000 (11:27 +0000)]
r7807: Allow to touch mtime in vfs-recycle with
recycle:touch_mtime = true
Guenther
Jeremy Allison [Tue, 21 Jun 2005 05:27:02 +0000 (05:27 +0000)]
r7798: CIFSFS client assumes wcnt == 10 for successful trans2 reply.
Jeremy.
Jeremy Allison [Tue, 21 Jun 2005 05:18:09 +0000 (05:18 +0000)]
r7796: Prepare for client setting capabilities to select posix pathnames on
the wire. Jerry do not merge this please. New SMB_SET_FS_INFO - level
0x200 as was discussed on the mailing list.
Jeremy.
Gerald Carter [Mon, 20 Jun 2005 22:13:19 +0000 (22:13 +0000)]
r7789: fix overparanoid assert() call when checking spolss buffer pointers
Tim Potter [Mon, 20 Jun 2005 21:20:47 +0000 (21:20 +0000)]
r7788: Update install swat message to reflect the fact that swat/README
no longer exists. Bugzilla #2808.
Jeremy Allison [Mon, 20 Jun 2005 19:36:12 +0000 (19:36 +0000)]
r7787: Fix from Fernando Schapachnik <fernando@mecon.gov.ar> to add logon hours
support for the Postgres backend.
Jeremy.
Volker Lendecke [Mon, 20 Jun 2005 13:42:29 +0000 (13:42 +0000)]
r7785: This looks much larger than it is. It changes the top-level functions of the
parent winbind not to return winbindd_result. This is to hopefully fix all the
problems where a result has been scheduled for write twice.
The problematic ones have been the functions that might have been delayed as
well as under other circumstances immediately gets answered from the cache.
Now a request needs to be explicitly replied to with a request_error() or
request_ok().
Volker
Volker Lendecke [Sat, 18 Jun 2005 16:47:27 +0000 (16:47 +0000)]
r7730: Some merges
Volker Lendecke [Sat, 18 Jun 2005 09:27:40 +0000 (09:27 +0000)]
r7718: Remove some unused code
Jeremy Allison [Sat, 18 Jun 2005 04:23:06 +0000 (04:23 +0000)]
r7708: Hint from Luke Howard (thanks Luke). Ensure the schannel authenticator is 8
byte aligned, just like the NTLMSSP ones. Trying to fix 64-bit Windows domain
logon.
Jeremy.
Richard Sharpe [Fri, 17 Jun 2005 21:52:58 +0000 (21:52 +0000)]
r7703: Fix the problem with MAP_PRIVATE not updating the file.
Jeremy Allison [Fri, 17 Jun 2005 20:32:33 +0000 (20:32 +0000)]
r7701: Patch from James Peach | jpeach@sgi.com to make wrepld use new
talloc interfaces.
Jeremy.
Gerald Carter [Fri, 17 Jun 2005 18:57:37 +0000 (18:57 +0000)]
r7698: * clean upserver frontend for RegDeleteKey()
* implement RegDeleteKey() for reg_db backend
Jeremy Allison [Fri, 17 Jun 2005 18:05:46 +0000 (18:05 +0000)]
r7696: Don't try and be clever and read an 8 byte int and 3 pad bytes
as a uint32 - you'll just get it wrong (as I did :-).
Second attempt to fix the Apple client issues.
Jeremy.
Jeremy Allison [Fri, 17 Jun 2005 15:54:10 +0000 (15:54 +0000)]
r7693: Fix from James Peach @ SGI for null pointer ACL free.
Jeremy.
Gerald Carter [Fri, 17 Jun 2005 15:53:01 +0000 (15:53 +0000)]
r7692: start versioning the registry.tdb file since it can be modified now
Gerald Carter [Fri, 17 Jun 2005 15:35:31 +0000 (15:35 +0000)]
r7691: * add .gdbinit to the svn:ignore files
* start adding write support to the Samba registry
Flesh out the server implementations of
RegCreateKey(), RegSetValue(), RegDeleteKey() and RegDeleteValue()
I can create a new key using regedit.exe now but the 'New Key #1'
key cannot be deleted yet.
Gerald Carter [Fri, 17 Jun 2005 01:57:18 +0000 (01:57 +0000)]
r7664: add access check hooks to _reg_open_entry which are passed off
to the reg_XXX backend. If the backend does not define
a regkey_access_check() function, we default to using the
standard registry_access_check()
Jeremy Allison [Fri, 17 Jun 2005 01:02:11 +0000 (01:02 +0000)]
r7662: Allow someone with SeTakeOwnershipPrivilege to chown the user
of a file to themself.
Jeremy.
Gerald Carter [Thu, 16 Jun 2005 20:59:39 +0000 (20:59 +0000)]
r7649: * fix compile breakage (sorry, should have done a make clean before the
last checking).
* rename unknown field in REG_GETVERSION
* add server stubs for RegDeleteKey() and RegDeleteValue()
Gerald Carter [Thu, 16 Jun 2005 20:45:55 +0000 (20:45 +0000)]
r7648: adding REGISTRY_HOOK->reg_access_check() for authprization checks on RegOpenKey(); passing it off to the backend code for a given path
Gerald Carter [Thu, 16 Jun 2005 20:29:15 +0000 (20:29 +0000)]
r7647: add access checks to the top level hive open calls; will need to pass the open request through the backend access check for the subkey open calls
Gerald Carter [Thu, 16 Jun 2005 20:04:16 +0000 (20:04 +0000)]
r7645: adding server stubs for RegCreateKey() and RegSetValue()
Jeremy Allison [Thu, 16 Jun 2005 16:39:49 +0000 (16:39 +0000)]
r7640: Fix based on work from "Shlomi Yaakobovich" <Shlomi@exanet.com> to catch
loops in corrupted tdb files.
Jeremy.
Günther Deschner [Thu, 16 Jun 2005 12:17:07 +0000 (12:17 +0000)]
r7636: Docu for "net rpc share migrate security" is now valid.
Guenther
Günther Deschner [Thu, 16 Jun 2005 09:36:53 +0000 (09:36 +0000)]
r7632: Cleanup "net share migrate"-code.
* Allow to copy share security descriptors to already existing shares
separatly.
* Added abstraction function to enum all or a single share info
Guenther
Gerald Carter [Thu, 16 Jun 2005 00:46:43 +0000 (00:46 +0000)]
r7624: * removed unmatched tdb_lock_by_string() call (should fix build farm issues)
* comment out services.tdb code until I finish rewriting it
Gerald Carter [Wed, 15 Jun 2005 19:28:14 +0000 (19:28 +0000)]
r7620: when adding a new printer driver, we should copy the files
(not move) to the W32X86/{2,3}/ directory. Printmig.exe
copies the driver files for all drivers to print$/W32X86
and the calls AddPrinterDriver() for each driver. If we
move the file, then adding a driver which shares a file with
a previous driver will fail.
I can now restore drivers in bulk to a Samba 3 server.
Jeremy Allison [Wed, 15 Jun 2005 18:49:43 +0000 (18:49 +0000)]
r7618: Typo...
Jeremy.
Jeremy Allison [Wed, 15 Jun 2005 18:37:34 +0000 (18:37 +0000)]
r7617: Fix for bug #2801 - delete veto files was broken with the new
large directory code.
Jeremy.
Gerald Carter [Wed, 15 Jun 2005 17:03:34 +0000 (17:03 +0000)]
r7614: convert move_driver_to_download_area() to return WERROR in order to provide better error messages to clients when a AddPrinterDriver[Ex]() call fails
Gerald Carter [Wed, 15 Jun 2005 16:32:12 +0000 (16:32 +0000)]
r7613: small changes to _svcctl_open_service() and create_open_service_handle() to prevent invalid service names from being accepted; printmig.exe now migrates drivers successfully
Gerald Carter [Wed, 15 Jun 2005 15:18:18 +0000 (15:18 +0000)]
r7610: can successfully stop and start the 'spooler' service by setting the state for the 'disable spoolss' parameter in memory for an individual smbd
Lars Müller [Wed, 15 Jun 2005 14:24:11 +0000 (14:24 +0000)]
r7609: Move top level dir handling in from of the loop. This makes the code
much straither.
copy_top_level_perms() is jra's work.
I modified the copy_top_level_perms() function to use the copy_clistate.
And I don't forget trunk.
Lars
Günther Deschner [Wed, 15 Jun 2005 13:01:19 +0000 (13:01 +0000)]
r7607: Some minor fixes (typos, const)
Guenther
Günther Deschner [Wed, 15 Jun 2005 12:43:36 +0000 (12:43 +0000)]
r7606: add WERR_NET_NAME_NOT_FOUND. This is what windows returns when
trying to manipulate non-existing shares.
Guenther
Gerald Carter [Wed, 15 Jun 2005 03:10:36 +0000 (03:10 +0000)]
r7603: * fix a bug in the SERVICE_ALL_ACCESS security mask
* add calls to start and stop a service (to be filled
in by the backend routines in services/svc_*.c
Gerald Carter [Wed, 15 Jun 2005 00:54:43 +0000 (00:54 +0000)]
r7595: start trying to split out the svcctl functions into separate files for better maintenance; add SERVICE_CONTROL_OPS for spoolss service
Jeremy Allison [Wed, 15 Jun 2005 00:22:59 +0000 (00:22 +0000)]
r7591: Don't call getpeeraddr on a disconnected socket.
Jeremy.
Gerald Carter [Tue, 14 Jun 2005 20:50:37 +0000 (20:50 +0000)]
r7584: cleanup the default printer security descriptor
Gerald Carter [Tue, 14 Jun 2005 20:11:59 +0000 (20:11 +0000)]
r7583: * more rearranging and renaming of functions
* add access checks to _svcctl_XXX() calls based on
the access granted on the handle
Gerald Carter [Tue, 14 Jun 2005 19:04:39 +0000 (19:04 +0000)]
r7581: fix bad merge
Gerald Carter [Tue, 14 Jun 2005 18:38:15 +0000 (18:38 +0000)]
r7578: use global well known DOM_SID objects when possible
Gerald Carter [Tue, 14 Jun 2005 18:31:06 +0000 (18:31 +0000)]
r7577: switching to macro for IS_DC
Gerald Carter [Tue, 14 Jun 2005 18:08:39 +0000 (18:08 +0000)]
r7576: implement access checks for open_scm and open_service
according to default security descriptor described in MSDN.
no one can get in to due to the permissions, but i'll fix
that next.
Gerald Carter [Tue, 14 Jun 2005 15:40:51 +0000 (15:40 +0000)]
r7573: you can't make an omlette without break a few eggs....start reworking the svcctl code
Gerald Carter [Tue, 14 Jun 2005 03:17:31 +0000 (03:17 +0000)]
r7563: svcctl patches from Marcin; have cleaned up formating and am checking the code in to snapshot it before I start changing more things
Jeremy Allison [Mon, 13 Jun 2005 22:26:08 +0000 (22:26 +0000)]
r7554: Refactor very messy code in util_sock.c Remove write_socket_data/read_socket_data
as they do nothing that write_socket/read_socket don't do. Add a more useful
error message when read_socket/write_socket error out on the main client fd
for a process (ie. try and list the IP of the client that errored).
Jeremy.
Jeremy Allison [Mon, 13 Jun 2005 20:42:21 +0000 (20:42 +0000)]
r7550: Steal the correct error return for invalid TID on NTcreateX from Samba4
(thanks tridge !).
Jeremy.
Gerald Carter [Mon, 13 Jun 2005 19:53:09 +0000 (19:53 +0000)]
r7547: removing unused fields in the REGISTRY_KEY structure associated with open handles
Jeremy Allison [Mon, 13 Jun 2005 18:45:17 +0000 (18:45 +0000)]
r7544: Fix for bug #2196 from Denis Sbragion <d.sbragion@infotecna.it>.
Allow absolute path (system wide) recycle bin.
Jeremy.
Jeremy Allison [Mon, 13 Jun 2005 17:41:52 +0000 (17:41 +0000)]
r7542: Patch from Renaud Duhaut <rd@duhaut.com> for a parameter
"directory_mode" when creating recycle directories.
Bug #1040.
Jeremy.
Jeremy Allison [Mon, 13 Jun 2005 16:49:57 +0000 (16:49 +0000)]
r7541: Patch from core@road-star.jp for bug #2792. Ensure the shadow copy
module hooks seekdir, telldir, rewinddir to match updated large
directory code.
Jeremy.
Günther Deschner [Mon, 13 Jun 2005 14:39:40 +0000 (14:39 +0000)]
r7537: Print passwords in display charset.
Guenther
Günther Deschner [Mon, 13 Jun 2005 13:16:55 +0000 (13:16 +0000)]
r7534: Add missing cli_srvsvc_net_share_set_info-function and
rpcclient-testers.
Needed in preparation of share-ACL migration in net.
Guenther
Günther Deschner [Mon, 13 Jun 2005 11:18:00 +0000 (11:18 +0000)]
r7532: compile fix.
Guenther
Günther Deschner [Mon, 13 Jun 2005 09:33:09 +0000 (09:33 +0000)]
r7529: Apply some const, remove unused variable.
Guenther
Lars Müller [Sun, 12 Jun 2005 21:18:16 +0000 (21:18 +0000)]
r7512: Fix net share migrate files to also migrate the ACLs of the top level
dir of a share. Till now we excluded '.' and '..' in general. For the
fix the information about top or lower level dir is stored in the
copy_clistate. src and dst share are now also part of this struct and
we only pass a pointer to the struct to the functions.
This bug was found by Bill Calero of Novell. Thanks Bill!
With this checkin no new functionality was added. But the copy_clistate
already knows about a mode. Later beside the migrate an additional
report mode will be added.
This changes are coordinated with Günther <gd>.
Lars
Lars Müller [Sun, 12 Jun 2005 16:00:29 +0000 (16:00 +0000)]
r7511: Add three new command line switches to testparm:
--show-all-parameters
Enumerates all available parameters, grouped in to sections
[local] and [global] by the class of the parameter. Each line
is formated name=type[,enum values],flags
--parameter-name
Display the setting of the named parameter. The global section
is assumed if no other is set with --section-name
--section-name
Limit the view of testparm to the named section. Use 'global'
to only view the settings of the global section.
This fixes bug #2767.
Lars
Jeremy Allison [Fri, 10 Jun 2005 23:13:25 +0000 (23:13 +0000)]
r7474: A *foul* and *disgusting* hack to ensure that, at the very lowest
level, . and .. are the first two entries returned when reading a
directory. This also means we can't seek to these offsets, but we
will never be doing that anyway (as far as I can think). The reason
we have to do this is that the NT4 explorer will happily display a
folder marked ".." as a clickable folder (and probably would display
"." as a clickable folder too) if these are not in positions zero
and one of the returned file list. W2K seems to have fixed this but
there are too many older systems out there... Never mind, more for
the "Undocumented CIFS talk", coming to a CIFS2005 conference near
you soon.... :-).
Jeremy.
Gerald Carter [Fri, 10 Jun 2005 22:03:33 +0000 (22:03 +0000)]
r7472: fix smbpasswd user password change (still worked by bad error messages) due to trying to strdup a NULL pointer
Gerald Carter [Fri, 10 Jun 2005 18:34:36 +0000 (18:34 +0000)]
r7470: fix block size caculation error when request size > 4096 bytes
Gerald Carter [Fri, 10 Jun 2005 03:26:39 +0000 (03:26 +0000)]
r7454: couple of winbindd fixes
* make sure to use our domain as the account name in the net_req_auth2()
request when running on a Samba DC
* make sure to lookup the correct domain (not default to ours) when getting an async
getpwnam() call
Jeremy Allison [Fri, 10 Jun 2005 00:31:59 +0000 (00:31 +0000)]
r7452: Set sparse flag if needed. Based on code from jpeach@sgi.com.
Fixes bug #2774.
Jeremy.
Gerald Carter [Thu, 9 Jun 2005 18:45:56 +0000 (18:45 +0000)]
r7450: fix my bone head mistake with ntlm authentcation and 'map to guest = bad uid'; make sure the authentication suceeds
Jeremy Allison [Thu, 9 Jun 2005 18:15:23 +0000 (18:15 +0000)]
r7447: Sync up a little between HEAD and 3.0 in preparation for moving
the AIO code across.
Jeremy.
Gerald Carter [Thu, 9 Jun 2005 15:20:11 +0000 (15:20 +0000)]
r7440: * merge registry server changes from trunk (so far) for more
printmig.exe work
* merge the sys_select_signal(char c) change from trunk
in order to keeo the winbind code in sync
Volker Lendecke [Thu, 9 Jun 2005 07:45:29 +0000 (07:45 +0000)]
r7423: Fix the build on sol10
Gerald Carter [Wed, 8 Jun 2005 22:10:34 +0000 (22:10 +0000)]
r7415: * big change -- volker's new async winbindd from trunk
Jeremy Allison [Wed, 8 Jun 2005 20:52:42 +0000 (20:52 +0000)]
r7412: Now we're not memset'ing ensure we're valgrind clean.
Jeremy.