Stefan Metzmacher [Fri, 7 Nov 2008 15:45:37 +0000 (16:45 +0100)]
s4: security.idl: split of dom_sid stuff into dom_sid.idl
This prepares having a shared security.idl file
metze
Jeremy Allison [Fri, 7 Nov 2008 07:29:20 +0000 (23:29 -0800)]
If we didn't inherit any ACE's the ACE pointer should be NULL.
Jeremy.
Jeremy Allison [Fri, 7 Nov 2008 04:48:13 +0000 (20:48 -0800)]
Make us clean under valgrind --leak-check=full by using talloc_autofree_context() instead of NULL.
Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting
to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should
be deleted when their parent context is deleted, so freeing them at some arbitrary point later
will be a double-free.
Jeremy.
Herb Lewis [Fri, 7 Nov 2008 04:40:20 +0000 (20:40 -0800)]
Convert to use VFS layer.
Jeremy Allison [Fri, 7 Nov 2008 02:53:00 +0000 (18:53 -0800)]
Add wrapper str_list_make_v3() to replace the old S3 behavior of
str_list_make(). From Dan Sledz <dan.sledz@isilon.com>:
In samba 3.2 passing NULL or an empty string returned NULL.
In master, it now returns a list of length 1 with the first string set
to NULL (an empty list).
Jeremy.
Günther Deschner [Thu, 6 Nov 2008 22:25:11 +0000 (23:25 +0100)]
s4-test: skip netr_DatabaseRedo test.
Guenther
Volker Lendecke [Sun, 26 Oct 2008 17:56:29 +0000 (18:56 +0100)]
For proxied named pipes, connect to np/<pipe_name> and send auth info
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 29 Oct 2008 11:20:02 +0000 (12:20 +0100)]
s3: build ndr_named_pipe_auth.c
metze
Stefan Metzmacher [Thu, 6 Nov 2008 09:19:20 +0000 (10:19 +0100)]
s3: rpc: let serverinfo_to_SamInfo3() work with no pipe_session_key
metze
Stefan Metzmacher [Sat, 17 May 2008 00:39:57 +0000 (02:39 +0200)]
s4: rpc_server: listen on named_pipes
metze
Stefan Metzmacher [Fri, 16 May 2008 23:52:47 +0000 (01:52 +0200)]
s4: smbd: implement stream_socket_named_pipe()
For now implement just a very simple protocol
to negotiate the transport session info.
We may need to pass more info later,
e.g. client ip or name...
metze
Stefan Metzmacher [Wed, 29 Oct 2008 11:05:10 +0000 (12:05 +0100)]
librpc/idl: Add named_pipe_auth.idl to Samba4
metze
Jeff Layton [Thu, 6 Nov 2008 20:07:07 +0000 (15:07 -0500)]
mount.cifs: use lock/unlock_mtab scheme from util-linux-ng mount prog
The util-linux-ng sources have a good, but rather complex scheme for
locking the mtab before updating it. Mount helpers need to follow the
same scheme. Advisory locking only works if everyone is using the same
locking scheme.
Copy the routines we need from util-linux-ng into a separate source file
and then have mount.cifs and umount.cifs link in this object.
The long term goal is to have these routines in a separate helper
library (libmount). Mount helpers can then dynamically link in that lib.
Until that happens, this should serve as a suitable stopgap solution.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Günther Deschner [Thu, 30 Oct 2008 09:54:59 +0000 (10:54 +0100)]
s4-smbtorture: add test for netr_DatabaseRedo.
Guenther
Günther Deschner [Fri, 31 Oct 2008 09:00:28 +0000 (10:00 +0100)]
s3-rpcclient: add database_redo command.
Guenther
Günther Deschner [Fri, 31 Oct 2008 09:05:10 +0000 (10:05 +0100)]
s3-build: rerun make samba3-idl.
Guenther
Günther Deschner [Thu, 6 Nov 2008 15:50:39 +0000 (16:50 +0100)]
netlogon: use 8bit SamDatabaseID and DeltaEnum in netr_ChangeLogEntry.
Guenther
Günther Deschner [Thu, 6 Nov 2008 15:47:38 +0000 (16:47 +0100)]
netlogon: add 8bit varients of netr_SamDatabaseID8Bit and netr_DeltaEnum.
Guenther
Günther Deschner [Tue, 4 Nov 2008 10:35:48 +0000 (11:35 +0100)]
netlogon-idl: use netr_ChangeLogEntry subcontext in netr_DatabaseRedo.
Guenther
Günther Deschner [Tue, 4 Nov 2008 10:34:35 +0000 (11:34 +0100)]
netlogon-idl: add netr_ChangeLogObject union.
Guenther
Günther Deschner [Mon, 3 Nov 2008 12:38:20 +0000 (13:38 +0100)]
netlogon-idl: add netr_ChangeLogFlags.
Guenther
Günther Deschner [Thu, 30 Oct 2008 09:54:25 +0000 (10:54 +0100)]
netlogon-idl: add netr_ChangeLogEntry.
Guenther
Jeremy Allison [Thu, 6 Nov 2008 14:42:04 +0000 (06:42 -0800)]
Fix bug #5825 - Account locking out doesnt work with an LDAP backend.Based on a problem found by Boyang. Only the pdb_nds backend implements login attempts so this was broken for tdbsam and ldap.
Jeremy.
Günther Deschner [Thu, 6 Nov 2008 11:53:00 +0000 (12:53 +0100)]
s3-dsgetdcname: fix reply generation (forgot to map nt1 to nt5ex).
Guenther
Günther Deschner [Thu, 6 Nov 2008 12:31:27 +0000 (13:31 +0100)]
doserr: add WERR_NO_TRUST_SAM_ACCOUNT.
Guenther
Jeremy Allison [Thu, 6 Nov 2008 09:58:56 +0000 (01:58 -0800)]
Start factoring out the inheritance differences.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 09:45:40 +0000 (01:45 -0800)]
Final fix to make us pass NULL SD test in RAW-ACLs. Not sure if this is 100% right. Only inheritance left to fix.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 09:40:21 +0000 (01:40 -0800)]
Don't call FSET_NT_ACL on file create if there's no SD to set. Leave the default ACL in place.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 09:01:01 +0000 (01:01 -0800)]
Only one more issue with NULL ACL test left to solve.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 08:50:56 +0000 (00:50 -0800)]
Fix crash in module, get more of the NULL acl test right.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 03:11:40 +0000 (19:11 -0800)]
Add reference to bug #4308 to remind me to add regression test to smbtorture.
Jeremy.
Günther Deschner [Wed, 5 Nov 2008 14:10:52 +0000 (15:10 +0100)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 5 Nov 2008 01:03:16 +0000 (02:03 +0100)]
s3-samr-idl: fix samr_QueryUserInfo2.
Guenther
Günther Deschner [Wed, 5 Nov 2008 01:02:50 +0000 (02:02 +0100)]
s3-samr-idl: fix samr_ValidatePassword.
Guenther
Volker Lendecke [Wed, 5 Nov 2008 09:48:43 +0000 (10:48 +0100)]
Fix the build
Volker Lendecke [Tue, 4 Nov 2008 20:51:17 +0000 (21:51 +0100)]
Fix a const warning
Volker Lendecke [Tue, 4 Nov 2008 17:05:17 +0000 (18:05 +0100)]
Convert blocking.c to store a smb_request instead of just inbuf
Volker Lendecke [Tue, 4 Nov 2008 15:57:31 +0000 (16:57 +0100)]
Simplify logic of cancel_pending_lock_requests_by_fid()
The only caller of this function is locking_close_file(). This checks itself if
brl_lock != NULL. The additional check is not necessary here.
Volker Lendecke [Tue, 4 Nov 2008 13:35:44 +0000 (14:35 +0100)]
Slightly simplify logic in process_lockingX()
The "else" is pointless here, we did a "return True" in the if branch.
Volker Lendecke [Tue, 4 Nov 2008 13:33:20 +0000 (14:33 +0100)]
Slightly simplify logic in remove_pending_lock_requests_by_mid()
Use "continue" for (SVAL(blr->inbuf,smb_mid) != mid)
Volker Lendecke [Tue, 4 Nov 2008 13:29:33 +0000 (14:29 +0100)]
Slightly simplify logic in cancel_pending_lock_requests_by_fid()
Use a "continue" for (blr->fsp->fnum != fsp->fnum)
Volker Lendecke [Tue, 4 Nov 2008 12:25:07 +0000 (13:25 +0100)]
Convert blocking.c to use talloc
Volker Lendecke [Mon, 3 Nov 2008 20:56:02 +0000 (21:56 +0100)]
Rewrite aio.c to keep the whole smb_request structure, not just the inbuf
Volker Lendecke [Mon, 3 Nov 2008 20:55:05 +0000 (21:55 +0100)]
Make "inbuf" a talloc child of "smb_request" for normal smb requests
This is necessary if we want to keep the whole smb_request for deferred ops.
The explicit settings of req->inbuf will be removed once all those deferring
operations are converted to store the whole request and not just the inbuf.
Volker Lendecke [Mon, 3 Nov 2008 19:16:09 +0000 (20:16 +0100)]
Add construct_reply_common_req wrapper
The goal is to remove the remaining direct calls to construct_reply_common.
Volker Lendecke [Mon, 3 Nov 2008 19:07:11 +0000 (20:07 +0100)]
Fix nonempty blank lines
Volker Lendecke [Mon, 3 Nov 2008 18:59:11 +0000 (19:59 +0100)]
Use talloc for struct aio_extra
Joe Smith [Tue, 4 Nov 2008 19:31:04 +0000 (20:31 +0100)]
Fixed typo in source/utils/net_rap.c
Günther Deschner [Tue, 4 Nov 2008 13:34:23 +0000 (14:34 +0100)]
s3-libnet_samsync: print new line in display output.
Guenther
Günther Deschner [Tue, 4 Nov 2008 18:37:55 +0000 (19:37 +0100)]
s4-smbtorture: fix some obvious copy-paste errors.
Guenther
Volker Lendecke [Tue, 4 Nov 2008 09:51:08 +0000 (10:51 +0100)]
Ignore 3.0 style invalid group mappings during upgrade to ldb
Jeremy Allison [Tue, 4 Nov 2008 09:34:08 +0000 (01:34 -0800)]
Pass all of RAW-ACLS except for inheritence. Working on that next.
Jeremy.
Volker Lendecke [Mon, 3 Nov 2008 14:25:02 +0000 (15:25 +0100)]
Trigger (and fix) a bug in Samba3 making smbd an infinite data source
A deferred open directly followed by a ulogoffX makes smbd3 send an infinite
stream of ERRinvuid replies :-(
Jeremy Allison [Tue, 4 Nov 2008 07:54:05 +0000 (23:54 -0800)]
Be more verbose about a directory ACL error.
Jeremy.
Jeremy Allison [Tue, 4 Nov 2008 07:18:43 +0000 (23:18 -0800)]
Pass the directory versions of the RAW-ACL (still not inheritance). Refactor some common code between open_file_ntcreate() and open_directory().
Jeremy.
Jeremy Allison [Tue, 4 Nov 2008 06:42:53 +0000 (22:42 -0800)]
Pass all the non-inherited S4 RAW-ACL tests.
Jeremy.
Andrew Bartlett [Tue, 4 Nov 2008 04:48:10 +0000 (15:48 +1100)]
Use ldb_dn_from_ldb_val() to create a DN in the SAMR server
The previous code incorrectly cast an ldb_val into a char *.
Andrew Bartlett
Andrew Bartlett [Tue, 28 Oct 2008 10:07:52 +0000 (21:07 +1100)]
Re-add support for supporting the PAC over domain trusts.
(This was not entered in lorikeet-heimdal.diff, so missed by metze's import).
Andrew Bartlett
Andrew Bartlett [Mon, 27 Oct 2008 08:48:19 +0000 (19:48 +1100)]
Give a better error when ldb_dn_from_ldb_val fails
Andrew Bartlett [Mon, 27 Oct 2008 02:32:23 +0000 (13:32 +1100)]
Use ldb_dn_from_ldb_val to avoid possible over-run of the value.
The ldb_val is length-limited, and while normally NULL terminated,
this avoids the chance that this particular value might not be, as
well as avoiding a cast.
Andrew Bartlett
Andrew Bartlett [Mon, 27 Oct 2008 02:11:28 +0000 (13:11 +1100)]
Fix use of wrong union arm in linked_attributes module
This bug occours frequenetly in ldb users because the union so happens
to be layed out that this works. However, it is still incorrect
usage...
Andrew Bartlett
Günther Deschner [Tue, 4 Nov 2008 01:46:41 +0000 (02:46 +0100)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 30 Oct 2008 08:29:17 +0000 (09:29 +0100)]
netlogon: fix IDL for netr_DatabaseRedo.
Guenther
Tim Prouty [Mon, 3 Nov 2008 20:36:34 +0000 (12:36 -0800)]
s3: fix a few "shadows a global declaration" warnings
Stefan Metzmacher [Mon, 3 Nov 2008 16:31:32 +0000 (17:31 +0100)]
s3: proto.h: add missing sys_[g|s]et_quota_vfs() prototypes
metze
Stefan Metzmacher [Mon, 3 Nov 2008 13:29:49 +0000 (14:29 +0100)]
s4:torture: PROVISION isn't used by all tests
We should not pollute all torture object files with
EXT_LIB_PYTHON_CFLAGS
metze
Stefan Metzmacher [Mon, 3 Nov 2008 13:27:54 +0000 (14:27 +0100)]
s4:torture: fix names of defines
metze
Volker Lendecke [Mon, 3 Nov 2008 16:56:55 +0000 (17:56 +0100)]
Fix nonempty blank lines
Volker Lendecke [Mon, 3 Nov 2008 16:49:38 +0000 (17:49 +0100)]
Make a comment match its function definition
Jelmer Vernooij [Sun, 2 Nov 2008 23:15:27 +0000 (00:15 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Sun, 2 Nov 2008 23:14:26 +0000 (00:14 +0100)]
Fix memory leak.
Jelmer Vernooij [Sun, 2 Nov 2008 22:58:49 +0000 (23:58 +0100)]
Fix the build.
Volker Lendecke [Sun, 2 Nov 2008 21:33:20 +0000 (22:33 +0100)]
Remove some inbuf references by adding "cmd" to smb_request
Volker Lendecke [Sun, 2 Nov 2008 21:20:48 +0000 (22:20 +0100)]
Remove the inbuf reference from map_checkpath_error()
Volker Lendecke [Sun, 2 Nov 2008 21:09:51 +0000 (22:09 +0100)]
Remove a direct inbuf reference in reply_negprot
Michael Adam [Thu, 30 Oct 2008 15:38:07 +0000 (16:38 +0100)]
[s3]winbindd: speed up fill_grent_mem (i.e. winbindd_getgrent) a lot.
With large groups, getgrent ran into timeouts because after each
single user that was added to the expanded group list, the list
was sorted and made unique.
Now the list is sorted just once after all members have been added.
Michael
Volker Lendecke [Sun, 2 Nov 2008 20:52:16 +0000 (21:52 +0100)]
Make a [un]become_root wrap a bit tighter
Sooner or later this would bite us.
Volker Lendecke [Sun, 2 Nov 2008 20:24:28 +0000 (21:24 +0100)]
Pass smb_request to send_trans_reply to match with send_[nt]trans[2]_reply
Jelmer Vernooij [Sun, 2 Nov 2008 18:33:34 +0000 (19:33 +0100)]
Remove global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 18:32:50 +0000 (19:32 +0100)]
Remove last instance of global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 18:28:17 +0000 (19:28 +0100)]
Remove use of global_loadparm for disabled gensec backends.
Jelmer Vernooij [Sun, 2 Nov 2008 17:28:06 +0000 (18:28 +0100)]
Remove global_loadparm stub in Samba 3 as it's no longer used.
Jelmer Vernooij [Sun, 2 Nov 2008 17:27:24 +0000 (18:27 +0100)]
Remove another use of global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 17:14:53 +0000 (18:14 +0100)]
Use standard heimdal function for finding interfaces - libreplace provides support for the underlying functions now.
Jelmer Vernooij [Sun, 2 Nov 2008 17:13:19 +0000 (18:13 +0100)]
Remove unused include of param/param.h.
Volker Lendecke [Sun, 2 Nov 2008 16:38:41 +0000 (17:38 +0100)]
Use "vwv" in trans parsing
Jelmer Vernooij [Sun, 2 Nov 2008 16:39:41 +0000 (17:39 +0100)]
Samba3: Remove more configure tests already done by libreplace.
Jelmer Vernooij [Sun, 2 Nov 2008 16:29:39 +0000 (17:29 +0100)]
Remove MIN, MAX, slprintf, vslprintf defines already provided by libreplace.
Jelmer Vernooij [Sun, 2 Nov 2008 16:21:46 +0000 (17:21 +0100)]
Use environment variable rather than loadparm parameter when testing
nonblocking sockets.
Jelmer Vernooij [Sun, 2 Nov 2008 16:11:20 +0000 (17:11 +0100)]
Remove use of global_loadparm when comparing nt status error - use
global variable instead.
Jelmer Vernooij [Sun, 2 Nov 2008 16:04:22 +0000 (17:04 +0100)]
Remove use of global_loadparm during initialization of gensec.
Volker Lendecke [Sun, 2 Nov 2008 11:20:47 +0000 (12:20 +0100)]
Remove a bunch of direct inbuf references by adding "vwv" to smb_request
Jelmer Vernooij [Sun, 2 Nov 2008 15:50:11 +0000 (16:50 +0100)]
Remove use of global loadparm in python modules.
Jelmer Vernooij [Sun, 2 Nov 2008 15:48:48 +0000 (16:48 +0100)]
Add utility function for getting the default loadparm context from a python module.
Jelmer Vernooij [Sun, 2 Nov 2008 15:46:32 +0000 (16:46 +0100)]
Move check of SMB_CONF_PATH to loadparm code.
Jelmer Vernooij [Sun, 2 Nov 2008 15:38:27 +0000 (16:38 +0100)]
Add *test4 rules to merged build Makefile, to allow running the Samba 4 tests against Samba 4. (doesn't work yet).
Jelmer Vernooij [Sun, 2 Nov 2008 15:20:00 +0000 (16:20 +0100)]
Remove use of global_loadparm for SMB2 client connections.
Jelmer Vernooij [Sun, 2 Nov 2008 15:07:28 +0000 (16:07 +0100)]
Remove another use of global_loadparm.
Eventually, we should move some of these parameters into a separate
struct (perhaps into smb_transport_options?), to avoid the long lists of
parameters.
Volker Lendecke [Sun, 2 Nov 2008 09:28:00 +0000 (10:28 +0100)]
Fix bug 5860: safe_strcpy gives a nasty error message for overlong strings
Thanks to Robert Dahlem <Robert.Dahlem@gmx.net> for reporting this!
Volker Lendecke [Sun, 2 Nov 2008 08:40:30 +0000 (09:40 +0100)]
Remove an unused variable