18 years agoRefactor the NTLMSSP code again - this time we use function pointers to
Andrew Bartlett [Wed, 15 Jan 2003 12:52:38 +0000 (12:52 +0000)]
Refactor the NTLMSSP code again - this time we use function pointers to
eliminate the dependency on the auth subsystem.  The next step is to add
the required code to 'ntlm_auth', for export to Squid etc.

Andrew Bartlett
(This used to be commit 9e48ab86da40e4c1cafa70c04fb9ebdcce23dfab)

18 years agoDoing a malloc(strlen(s)) then a pstrpcp(y, s) is just silly, make it a strdup
Andrew Bartlett [Wed, 15 Jan 2003 12:48:06 +0000 (12:48 +0000)]
Doing a malloc(strlen(s)) then a pstrpcp(y, s) is just silly, make it a strdup

Andrew Bartlett
(This used to be commit c781e34d274f4185ec932cc59029d3f9a65e47c4)

18 years agoadded cli_lsa_enum_account_rights() call. Note that this is in
Andrew Tridgell [Wed, 15 Jan 2003 07:40:40 +0000 (07:40 +0000)]
added cli_lsa_enum_account_rights() call. Note that this is in
principal similar to the existing cli_lsa_enum_privsaccount() call,
except that cli_lsa_enum_account_rights() doesn't require a call to
open_account first. There is also the minor matter that
cli_lsa_enum_account_rights() works whereas
cli_lsa_enum_privsaccount() doesn't!

this call can be used to find what privileges an account or group
has. This is a first step towards proper privileges support in Samba.
(This used to be commit 65bac11d716f873dcdbda528313c33634c26a072)

18 years agoFix warnings by getting the function into a shape the autoprototyper will
Andrew Bartlett [Wed, 15 Jan 2003 05:56:12 +0000 (05:56 +0000)]
Fix warnings by getting the function into a shape the autoprototyper will
read, and add a static.

Andrew Bartlett
(This used to be commit 919889de78fc3c7bc5dfebcc180385f2f3d7a564)

18 years agoCrash fixes:
Andrew Bartlett [Wed, 15 Jan 2003 05:55:22 +0000 (05:55 +0000)]
Crash fixes:
 - fix a crash when a second NTLMSSP session tried to free the first
 - fix a crash due to some NULL pointers in the Add Printer Wizard (or read
   printer code too it appears).  As far as I can tell it's just that the
   GUID just might not exist.

Andrew Bartlett
(This used to be commit 51b1413056b0d001076ff47a755eb35baa2d9e6d)

18 years agoOne more from waitpid() audit: Correctly interpret waitstatus when a
Martin Pool [Wed, 15 Jan 2003 05:27:33 +0000 (05:27 +0000)]
One more from waitpid() audit: Correctly interpret waitstatus when a
child fails.  Possibly this was causing smbmount to exit(0) when it
really should have indicated a failure.
(This used to be commit 1e33083fe66dfc1e168ffeb2f9d87953534a2d5d)

18 years agoRun autoheader
Martin Pool [Wed, 15 Jan 2003 05:23:40 +0000 (05:23 +0000)]
Run autoheader
(This used to be commit 82e4bb598c9fc26eaa090687d0daa6505fa0d550)

18 years agoFix bug where the existence of config.cache would cause functions like
Martin Pool [Wed, 15 Jan 2003 05:00:04 +0000 (05:00 +0000)]
Fix bug where the existence of config.cache would cause functions like
yp_get_default_domain to be misdetected.

According to the autoconf manual we need to check for libraries before
looking for functions in them.
(This used to be commit 468c487df42c6fc25d1862f36995b3d9a78902ff)

18 years agoIRIX uses libns_winbind.so instead of libnss_winbind.so
Herb Lewis [Wed, 15 Jan 2003 01:05:35 +0000 (01:05 +0000)]
IRIX uses libns_winbind.so instead of libnss_winbind.so
(This used to be commit 50adb8cc1074e9bedac365a92db96c5f01f30223)

18 years ago[merge] removing unused variable and unused file
Gerald Carter [Tue, 14 Jan 2003 23:55:14 +0000 (23:55 +0000)]
[merge] removing unused variable and unused file
(This used to be commit 099e844571975eecde7aea342c64d3f768110e03)

18 years agoFix some debug lines, and add a bit more info to help track down ldap
Andrew Bartlett [Tue, 14 Jan 2003 23:45:14 +0000 (23:45 +0000)]
Fix some debug lines, and add a bit more info to help track down ldap
connectivity problems.

Andrew Bartlett
(This used to be commit 68de9a59203ed9778f11b78f233dc437b9dab55d)

18 years agomerge: disable [u|g]idPool objects
Gerald Carter [Tue, 14 Jan 2003 16:03:27 +0000 (16:03 +0000)]
merge: disable [u|g]idPool objects
(This used to be commit 4c98700e54f3cc617eb578758695fd4dbd690f82)

18 years agomake -i flag work lik eit did in 2.2
Gerald Carter [Tue, 14 Jan 2003 15:52:45 +0000 (15:52 +0000)]
make -i flag work lik eit did in 2.2
(This used to be commit 54b054c1edd44096c7158993a886f915d7a07493)

18 years agoCommit my (disabled) fstring/pstring mixup detection code.
Andrew Bartlett [Tue, 14 Jan 2003 06:53:35 +0000 (06:53 +0000)]
Commit my (disabled) fstring/pstring mixup detection code.

We need to fix some 'overmalloc' cases before it can be enabled by default.

Andrew Bartlett
(This used to be commit 2c2c52a18be1bd0a5ae1f4a48b1d9e18f4887dda)

18 years agoThe last of the fstring/pstring mixups, and an extra 'static'.
Andrew Bartlett [Tue, 14 Jan 2003 06:46:14 +0000 (06:46 +0000)]
The last of the fstring/pstring mixups, and an extra 'static'.
(This used to be commit b328b67fd8fd605636ed58ffd33cf5be3d480672)

18 years agoA couple more pstcpy/fstrcpy mixups - doing an fstrcpy into a pstring is
Andrew Bartlett [Tue, 14 Jan 2003 06:36:40 +0000 (06:36 +0000)]
A couple more pstcpy/fstrcpy mixups - doing an fstrcpy into a pstring is
harmless, but breaks my automated check.
(This used to be commit e5d2b1f6c3c0883054f4e0eab2cac958706a790d)

18 years agoAdded comment about a SMB_ASSERT()
Tim Potter [Tue, 14 Jan 2003 05:25:08 +0000 (05:25 +0000)]
Added comment about a SMB_ASSERT()
(This used to be commit 056bdfbce73bbd7ddaa198d18e596b94b2224d3d)

18 years agoRemove wrapper function _get_trust_account_password() as it doesn't
Tim Potter [Tue, 14 Jan 2003 05:08:42 +0000 (05:08 +0000)]
Remove wrapper function _get_trust_account_password() as it doesn't
seem to do anything useful anymore other than call
(This used to be commit 7b0c03cbf1376f82b0bb5f4cf86e2db3b0bc1dec)

18 years agoAdded a comment in case anyone is thinking of doing a SMB_ASSERT in winbindd.
Tim Potter [Tue, 14 Jan 2003 04:04:13 +0000 (04:04 +0000)]
Added a comment in case anyone is thinking of doing a SMB_ASSERT in winbindd.
(This used to be commit c64e2308bae31d48171685b3b67b8cace1b003b5)

18 years agoquery_alt_name takes a forced unicode string in win2000. It is not
Andrew Tridgell [Tue, 14 Jan 2003 02:51:37 +0000 (02:51 +0000)]
query_alt_name takes a forced unicode string in win2000. It is not
null terminated.

Thanks to Metze for finding this.
(This used to be commit e4ce26332b8f876e25ff9baf06d4767a473e2676)

18 years agoclearer debug message when the user is already in the ldap db
Andrew Tridgell [Tue, 14 Jan 2003 00:39:18 +0000 (00:39 +0000)]
clearer debug message when the user is already in the ldap db
(This used to be commit 31894ba0e5847eb934688598cd8d65bead23c58b)

18 years agoadd help text for 'net ads lookup'
Andrew Tridgell [Tue, 14 Jan 2003 00:35:38 +0000 (00:35 +0000)]
add help text for 'net ads lookup'
(This used to be commit 2a642a1169a3c09988daa9623dcb4f21b0a2ad1f)

18 years agoMissing indirect in final free.
Jeremy Allison [Mon, 13 Jan 2003 23:07:28 +0000 (23:07 +0000)]
Missing indirect in final free.
(This used to be commit faf443e5198e270f1a60d7a0939074efca750a94)

18 years agoAlways initialise this variable - and don't set the 'must change now' if it was
Andrew Bartlett [Mon, 13 Jan 2003 21:49:49 +0000 (21:49 +0000)]
Always initialise this variable - and don't set the 'must change now' if it was
last changed at '0'.

We need to actually change this password sometime...

Andrew Bartlett
(This used to be commit 740bf439d2d1512127c873cf0e57697161d6566b)

18 years agoFix typo, and the build.
Andrew Bartlett [Mon, 13 Jan 2003 21:48:52 +0000 (21:48 +0000)]
Fix typo, and the build.
(This used to be commit d7452e73b511ceaebfaed66c18e7c61cbe0289d2)

18 years agoMake sure that those cleanups actually went in.
Richard Sharpe [Mon, 13 Jan 2003 20:30:28 +0000 (20:30 +0000)]
Make sure that those cleanups actually went in.
(This used to be commit 9a38e378115a1c36d0cd7c41f4c5767c23b4eb3f)

18 years agoPatch from metze to add what he feels is the correct semantics for a Domain
Andrew Bartlett [Mon, 13 Jan 2003 13:11:36 +0000 (13:11 +0000)]
Patch from metze to add what he feels is the correct semantics for a Domain
Controller.  As we have had a number of attempts at this over the last little
while, I need to get my test rig going, and give this whole area a poke...

Meanwhile, if you want to use this, just adjust your 'auth methods' line to use

Andrew Bartlett
(This used to be commit 18e598ec24493026008fcfe486057555b8832108)

18 years agoPatch from metze to to make testparm show values for 'workgroup', 'netbios
Andrew Bartlett [Mon, 13 Jan 2003 13:03:25 +0000 (13:03 +0000)]
Patch from metze to to make testparm show values for 'workgroup', 'netbios
name' and 'netbios scope'.  Probably has a similar effect on SWAT.

Also adds '-V' to testparm.

Andrew Bartlett
(This used to be commit 71f4d8efd36351ddb2180103c160a6d737da62b1)

18 years agoPatch from ab, to make findsmb omit -r most of the time.
Andrew Bartlett [Mon, 13 Jan 2003 12:54:59 +0000 (12:54 +0000)]
Patch from ab, to make findsmb omit -r most of the time.

(original mail follows)
From: Alexander Bokovoy <a.bokovoy@sam-solutions.net>

I propose to make an optional argument '-r' for findsmb utility to pass
'-r' option to nmblookup optionally and default to omit it. The reason is
to have findsmb working more user-friendly in contemporary office
environments where Windows 95/98 boxes are rare and also to allow usage of
the utility under non-priviledged accounts when Windows95/98 boxes are in
minority or even absent in network neighbourhood.

An attached patch provides this change for HEAD together with
documentation changes.

/ Alexander Bokovoy
(This used to be commit d0bebea521e12fb9cef66feecd969216607ef63d)

18 years agoUpdates to our NTLMSSP code:
Andrew Bartlett [Mon, 13 Jan 2003 12:48:37 +0000 (12:48 +0000)]
Updates to our NTLMSSP code:

This tries to extract our server-side code out of sessetup.c, and into a more
general lib.  I hope this is only a temporay resting place - I indend to
refactor it again into an auth-subsystem independent lib, using callbacks.

Move some of our our NTLMSSP #defines into a new file, and add two that I found
in the COMsource docs - we seem to have a double-up, but I've verified from
traces that the NTLMSSP_TARGET_TYPE_{DOMAIN,SERVER} is real.

This code also copes with ASCII clients - not that we will ever see any here,
but I hope to use this for HTTP, were we can get them.  Win2k authenticates
fine under forced ASCII, btw.

Tested with Win2k, NTLMv2 and Samba's smbclient.

Andrew Bartlett
(This used to be commit b6641badcbb2fb3bfec9d00a6466318203ea33e1)

18 years agoAccessing data after it's been free()ed really is a no-no...
Andrew Bartlett [Mon, 13 Jan 2003 12:42:20 +0000 (12:42 +0000)]
Accessing data after it's been free()ed really is a no-no...

Andrew Bartlett
(This used to be commit 6e821285a4aacfc0031957b88ddbec73d7e1dc11)

18 years agoFix to debian bug #171071 - we had the wrong dereference on the pointer to be
Andrew Bartlett [Mon, 13 Jan 2003 12:21:07 +0000 (12:21 +0000)]
Fix to debian bug #171071 - we had the wrong dereference on the pointer to be
Realloc()ed, causing it to fail.

Big thanks to Sandor Sonfeld <sonf@linuxmail.org> for the debug, stack and
valgrind traces!

Andrew Bartlett
(This used to be commit 7abca6d281da6388899f78e3440d7ce37bf2094e)

18 years agoDon't force the DOS password into a 14 char space, as this would imply null
Andrew Bartlett [Mon, 13 Jan 2003 08:53:54 +0000 (08:53 +0000)]
Don't force the DOS password into a 14 char space, as this would imply null
termination - the password will not be null terminated before hashing if
len >= 14.

related to debian bug #157432

Andrew Bartlett
(This used to be commit c6535836f2e48903aa89a18c11cbb37576fb4a20)

18 years agoEnsure we do not pass uninitialised data to the kernel. (Picked up by
Andrew Bartlett [Mon, 13 Jan 2003 08:09:32 +0000 (08:09 +0000)]
Ensure we do not pass uninitialised data to the kernel.  (Picked up by

Andrew Bartlett
(This used to be commit f8d9880c5f5321f4dba6b42896419412284c3e7b)

18 years agoFix typo in comment.
Martin Pool [Mon, 13 Jan 2003 04:57:21 +0000 (04:57 +0000)]
Fix typo in comment.
(This used to be commit 26660f939f0e0650d54631bf8243b22f32b64132)

18 years agoMerge of remove "winbindd holding pattern" from appliance. It's a bit
Tim Potter [Mon, 13 Jan 2003 03:45:31 +0000 (03:45 +0000)]
Merge ... remove "winbindd holding pattern" from appliance.  It's a bit
simpler as the rescanning of trusted domains helps us out a bit.
(This used to be commit 089729c02cb2088e85f0e7f8ec79afb58fe98be7)

18 years agoKeep all the const warnings in one place, by adding a utility function to
Andrew Bartlett [Sun, 12 Jan 2003 12:23:37 +0000 (12:23 +0000)]
Keep all the const warnings in one place, by adding a utility function to
make the TDB_DATA.

Andrew Bartlett
(This used to be commit f087fe546fd0c943dec022c657f849803f4b807e)

18 years agoOops, this is the change to use an fstring for the incoming service buffer -
Andrew Bartlett [Sun, 12 Jan 2003 11:31:03 +0000 (11:31 +0000)]
Oops, this is the change to use an fstring for the incoming service buffer -
the commit to reply.c just matches a pstrcpy for the pstring.  (harmless, fixes
it for the automated test).

Andrew Bartlett
(This used to be commit ef9c7586ac152304cacaf2c16115adc2bccefc22)

18 years agoMake the 'service' in make_connection() use an fstrcpy(), and an fstring,
Andrew Bartlett [Sun, 12 Jan 2003 11:29:02 +0000 (11:29 +0000)]
Make the 'service' in make_connection() use an fstrcpy(), and an fstring,
becouse that is what it's input (reply_tcon_and_x) uses, and becouse we really
don't want supprises for service names.

Also remove a legacy #define, in favor of the lp_ equiv.

Andrew Bartlett
(This used to be commit 7854a439ac601d3c23703b115cd5a8d4257c7717)

18 years agoWhile the usage is most bisarre, this fixes up another fstring/pstring mixup.
Andrew Bartlett [Sat, 11 Jan 2003 12:33:00 +0000 (12:33 +0000)]
While the usage is most bisarre, this fixes up another fstring/pstring mixup.
(In this case, an fstrcpy() into a pstring, ie harmless).

Andrew Bartlett
(This used to be commit 7b92d26d479dbc0923484967936511cfc645c5f4)

18 years agoUse size_t for the counter vars, to match the type they are assigned from
Andrew Bartlett [Sat, 11 Jan 2003 12:24:19 +0000 (12:24 +0000)]
Use size_t for the counter vars, to match the type they are assigned from
(signed/unsigned mixup).

Andrew Bartlett
(This used to be commit f42cf0783fa3aeddc4992021df9ee6f3b1aa58f3)

18 years agoA couple more fstring/pstring issues - and move from sizeof(fstring) to
Andrew Bartlett [Sat, 11 Jan 2003 12:18:57 +0000 (12:18 +0000)]
A couple more fstring/pstring issues - and move from sizeof(fstring) to
sizeof(var) in slprintf statements, so as to ensure we don't get mixups there.

Also remove fstrcpy() into a variable that is about to be printed into anyway.

Andrew Bartlett
(This used to be commit 9b761237321d475c324a3995fe6f0922550ae995)

18 years agoRemove an unused paramter for our old LM-only password change code, and fix a
Andrew Bartlett [Sat, 11 Jan 2003 12:13:03 +0000 (12:13 +0000)]
Remove an unused paramter for our old LM-only password change code, and fix a
(harmless) fstring/pstring mixup.

Andrew Bartlett
(This used to be commit 5ff5f540ccc2ee2c9859213b84598baa400f57a5)

18 years agoFix a number of client-side fstring/pstring mixups.
Andrew Bartlett [Sat, 11 Jan 2003 12:04:14 +0000 (12:04 +0000)]
Fix a number of client-side fstring/pstring mixups.

Andrew Bartlett
(This used to be commit fe1cc779d5ea77e87dbc0e2edf7c34a354fee6e0)

18 years agoPatch from Nik Conwell <nik@bu.edu>. Don't reference free()ed data when trying
Andrew Bartlett [Sat, 11 Jan 2003 03:29:31 +0000 (03:29 +0000)]
Patch from Nik Conwell <nik@bu.edu>.  Don't reference free()ed data when trying
to figure out if we have got our ticket yet.

Andrew Bartlett
(This used to be commit a66ced2cf69145c0a5be5ed91ac306db50c313d1)

18 years agoReturn the 'freindly' NT error message if at all possible.
Andrew Bartlett [Sat, 11 Jan 2003 03:25:31 +0000 (03:25 +0000)]
Return the 'freindly' NT error message if at all possible.

Andrew Bartlett
(This used to be commit 90d05176534cfd97ed3827bddfeb3a0cb7f22683)

18 years agoNo point having this for both parts of the 'if' statement.
Andrew Bartlett [Sat, 11 Jan 2003 03:23:16 +0000 (03:23 +0000)]
No point having this for both parts of the 'if' statement.

Andrew Bartlett
(This used to be commit 3b2e5f68cd4e1ff07dbd0032f521b3ba6e53746a)

18 years agotypo from merge
Gerald Carter [Sat, 11 Jan 2003 02:36:13 +0000 (02:36 +0000)]
typo from merge
(This used to be commit 1f33b4acb32c5461b9249d3786ea5fc6898e5f18)

18 years agofix tdb_append() prototype
Gerald Carter [Sat, 11 Jan 2003 02:30:34 +0000 (02:30 +0000)]
fix tdb_append() prototype
(This used to be commit df6e4559922bb55b53f587ca917110a045e222d7)

18 years ago[merge] make sure to updatre print queue cache during timeout_processing() to send...
Gerald Carter [Sat, 11 Jan 2003 02:29:23 +0000 (02:29 +0000)]
[merge] make sure to updatre print queue cache during timeout_processing() to send notify events; CR 1491
(This used to be commit 142c5029c701e7a82074e301278846c02843f46f)

18 years agoAdded new message_send_pid() code that uses tdb append to reduce locking
Jeremy Allison [Sat, 11 Jan 2003 00:17:37 +0000 (00:17 +0000)]
Added new message_send_pid() code that uses tdb append to reduce locking
contention on the messaging tdb.
(This used to be commit 5b8cf0810a7297f239b35c93ec50d20f1eed793b)

18 years agoAdded tdb_append() call. Efficiently adds to an entry. Used by new messaging
Jeremy Allison [Sat, 11 Jan 2003 00:07:40 +0000 (00:07 +0000)]
Added tdb_append() call. Efficiently adds to an entry. Used by new messaging
code. Also added torture tests for it.
(This used to be commit b515525a060a388c6ae0a03006a882c9be2e42b6)

18 years agoFirst part of efficiency fixes for message sending to pid's (cutting down
Jeremy Allison [Fri, 10 Jan 2003 20:17:06 +0000 (20:17 +0000)]
First part of efficiency fixes for message sending to pid's (cutting down
the amount of time we hold tdb locks). Gulp down all messages at once rather
than reading/re-writing one at a time. NOTE: All dispatch routines *must*
be able to cope with incoming message on *odd* byte boundaries (all current
handlers do).
(This used to be commit 04243e39cf4e11dd20e6035f553722a9720f00ae)

18 years agoFix lpq_cache time check (missed from yesterday).
Jeremy Allison [Fri, 10 Jan 2003 19:59:18 +0000 (19:59 +0000)]
Fix lpq_cache time check (missed from yesterday).
(This used to be commit 21c8acd25ac93f7ea5b77ef6005e3789a71ca50f)

18 years agoa 0 length printer data value is not a memory allocation error; fix CR601
Gerald Carter [Thu, 9 Jan 2003 19:51:28 +0000 (19:51 +0000)]
a 0 length printer data value is not a memory allocation error; fix CR601
(This used to be commit 3442c270f1bc67890f4e2de3386fcfdec610170d)

18 years agotdb_chainlock_with_timeout: Add TODO: If we time out waiting for a
Martin Pool [Thu, 9 Jan 2003 07:23:23 +0000 (07:23 +0000)]
tdb_chainlock_with_timeout: Add TODO: If we time out waiting for a
lock, it might be nice to use F_GETLK to get the pid of the process
currently holding the lock and print that as part of the debugging

I'd like to have this in appliance_head, but the code is too different
so I won't worry for now.
(This used to be commit 575908cb06a653225a2fa79ecd025af0e3dafc05)

18 years agoRemove read_with_timeout() and replaced its only caller (the passwd chat
Tim Potter [Thu, 9 Jan 2003 06:58:07 +0000 (06:58 +0000)]
Remove read_with_timeout() and replaced its only caller (the passwd chat
stuff) with a call to read_socket_with_timeout() which does the same thing.

Passwd chat still works but I couldn't figure out the right arguments to
passwd chat to get it to work right but data was definitely getting
(This used to be commit 88eb9e9486bca55a38e40ae53aed35ee338a68d7)

18 years agoRemove dead function.
Tim Potter [Thu, 9 Jan 2003 05:50:15 +0000 (05:50 +0000)]
Remove dead function.
(This used to be commit 6ed4d80baa5ff529bb0a06d7e52528b307ca4a0c)

18 years agoMoved smbd process counting functions from smbd/server.c to smbd/process.c
Tim Potter [Thu, 9 Jan 2003 05:49:51 +0000 (05:49 +0000)]
Moved smbd process counting functions from smbd/server.c to smbd/process.c
so that bin/vfstest can link.
(This used to be commit 812ce0368c69922612ac001560a111016d0e568e)

18 years agoCorrect misleading comment: winbindd_lookupname gets the SID for a
Martin Pool [Thu, 9 Jan 2003 01:16:12 +0000 (01:16 +0000)]
Correct misleading comment: winbindd_lookupname gets the SID for a
name, not vice versa.
(This used to be commit be835d01e10a75aecfb1b166bc6e0ea796c60cce)

18 years agoEnsure we return disk full by default on short writes.
Jeremy Allison [Wed, 8 Jan 2003 23:49:37 +0000 (23:49 +0000)]
Ensure we return disk full by default on short writes.
(This used to be commit 6a2b7fd82c868d517301f8566cd86e9e4b31546f)

18 years agoEnsure we don't get an invalid number for total smbd's if the tdb update
Jeremy Allison [Wed, 8 Jan 2003 21:42:43 +0000 (21:42 +0000)]
Ensure we don't get an invalid number for total smbd's if the tdb update
(This used to be commit 99e69fd74d5a2e7396e7f24924d72374d5cb32c2)

18 years agoreran autoconf
Herb Lewis [Wed, 8 Jan 2003 18:33:16 +0000 (18:33 +0000)]
reran autoconf
(This used to be commit 947042007d541563958b054e66bc60e97984d122)

18 years agoSome fixes to editreg. Clientgen should not be touched, and an update to configure...
Richard Sharpe [Wed, 8 Jan 2003 17:59:52 +0000 (17:59 +0000)]
Some fixes to editreg. Clientgen should not be touched, and an update to configure that Herb needs.
(This used to be commit 490ff93bbfe38d92746693d5f9902f985de6bc12)

18 years agoFix erroneous free of SAM_ACCOUNT (make clearer when allocated
Jeremy Allison [Wed, 8 Jan 2003 07:02:18 +0000 (07:02 +0000)]
Fix erroneous free of SAM_ACCOUNT (make clearer when allocated
memory is being returned).
(This used to be commit b0d547b7396beff861bb116051ed06b7b9749005)

18 years agoRemoved pointless null statement in signal handler.
Tim Potter [Wed, 8 Jan 2003 04:14:12 +0000 (04:14 +0000)]
Removed pointless null statement in signal handler.
(This used to be commit db24489eb4304f1fb0e47a5b6bd77ff3871b757e)

18 years agoDisplay an error message when the server cannot be resolved when running at
Tim Potter [Wed, 8 Jan 2003 02:54:42 +0000 (02:54 +0000)]
Display an error message when the server cannot be resolved when running at
debug level 0.
(This used to be commit 451286febd251d25b8beeae9b41a09102240c219)

18 years agoFix open problem with changing attributes on an existing file - based
Jeremy Allison [Wed, 8 Jan 2003 02:09:14 +0000 (02:09 +0000)]
Fix open problem with changing attributes on an existing file - based
on work by  <steve@griffin.sio2.nl>.
(This used to be commit 465d86d95fbdeda423d1f4b06cee46c119a31447)

18 years agoFix memory leak. Thanks, Herb!
Volker Lendecke [Tue, 7 Jan 2003 20:54:31 +0000 (20:54 +0000)]
Fix memory leak. Thanks, Herb!

(This used to be commit 8915d59a5939b78a177dcd3e075a122e68e8c64a)

18 years agothis makes it compile, but I'm not sure if it is correct. Are we really
Herb Lewis [Tue, 7 Jan 2003 17:55:14 +0000 (17:55 +0000)]
this makes it compile, but I'm not sure if it is correct. Are we really
testing a pointer value to be equal to 0x19 ???
(This used to be commit 15b2b91f4b77a62163c0f79592111d4809317b9f)

18 years agocannot make assignments to const values.
Herb Lewis [Tue, 7 Jan 2003 17:43:37 +0000 (17:43 +0000)]
cannot make assignments to const values.
(This used to be commit e3b1e64d9f23347a5ecefeb15329b6ec8971a55e)

18 years agoadd and escape before $( in regex string so it is not interpreted as the
Herb Lewis [Tue, 7 Jan 2003 17:33:30 +0000 (17:33 +0000)]
add and escape before $( in regex string so it is not interpreted as the
perl variable for "real gid of this process"
(This used to be commit cfe2d01b7de846229e87c151059d80756929d129)

18 years agoCreate a machine account correctly if the unix account exists.
Volker Lendecke [Tue, 7 Jan 2003 10:38:33 +0000 (10:38 +0000)]
Create a machine account correctly if the unix account exists.

With this, my test for W2kSP3 join after pdbedit -a -m works fine.

(This used to be commit c9d0c5254c7d4ddb343f405652c609a0128e60f9)

18 years agoAdded code to the handling of the -M option to ensure that we default to
Christopher R. Hertel [Tue, 7 Jan 2003 04:33:43 +0000 (04:33 +0000)]
Added code to the handling of the -M option to ensure that we default to
port 139 for that option.  The NetBIOS Messenger Service doesn't run on
a non-NBT port.
(This used to be commit 02986f3e3a8b0411f7cfbfe11015602fe685a440)

18 years agoRename a local variable to avoid a warning.
Tim Potter [Tue, 7 Jan 2003 03:39:22 +0000 (03:39 +0000)]
Rename a local variable to avoid a warning.
(This used to be commit 232116d2db9f24d64b3fa7a6e11191599590107a)

18 years ago'index' is the name of a libc function. Rename to 'ndx' to avoid compiler
Tim Potter [Tue, 7 Jan 2003 03:36:39 +0000 (03:36 +0000)]
'index' is the name of a libc function.  Rename to 'ndx' to avoid compiler
(This used to be commit 431ac28b5b7ea688ec342b5834c25eca059e7a16)

18 years agoRemove unused variable.
Tim Potter [Tue, 7 Jan 2003 03:31:52 +0000 (03:31 +0000)]
Remove unused variable.
(This used to be commit 4bc82624f6f2d3745a1528c56b9dcf04613a6a1d)

18 years agoFix memory leaks in pdb_ code.
Jeremy Allison [Mon, 6 Jan 2003 21:48:43 +0000 (21:48 +0000)]
Fix memory leaks in pdb_ code.
(This used to be commit ddf741c7178e33914dea6031f1a32800af402630)

18 years agoadd $(LDFLAGS) to libsmbclient
Gerald Carter [Mon, 6 Jan 2003 18:00:18 +0000 (18:00 +0000)]
add $(LDFLAGS) to libsmbclient
(This used to be commit 0f8ba688d427febecfd94e02f1779f4a699a0df2)

18 years agoFix from "Ken Cross" <kcross@nssolutions.com> for enumerating
Jeremy Allison [Mon, 6 Jan 2003 07:29:34 +0000 (07:29 +0000)]
Fix from "Ken Cross" <kcross@nssolutions.com> for enumerating
(This used to be commit cde517cedf3521b815faf2bdaf7940a611a28650)

18 years agoFix a segfault when we don't correctly load a VFS module (don't keep it in
Andrew Bartlett [Mon, 6 Jan 2003 06:15:34 +0000 (06:15 +0000)]
Fix a segfault when we don't correctly load a VFS module (don't keep it in
the loaded list on error).  Also change some of the error returns, becouse
NT_STATUS_UNSUCCESSFUL gives a most useless error message on the client.

As for which error, my logic is that a share without a valid VFS module is
not a valid share, and therefore should return the same error as a non-existant

Andrew Bartlett
(This used to be commit 41178afdbd2b3de94cf272ce32764a1947e73ea8)

18 years agoClear up the auth_sam password checking code (the core of our password checking
Andrew Bartlett [Sun, 5 Jan 2003 07:32:08 +0000 (07:32 +0000)]
Clear up the auth_sam password checking code (the core of our password checking
routines).  In particular, we now better support the NT# in LM feild, and the
LMv2 password scheme.  (LMv2 is basicly NTLMv2 capped at 24 bytes, slightly
more secure, and in the LM feild for compatiblity).

Thanks to the Samba-TNG team and Luke Leighton for various descriptions of this
algorithm, and to MS for a solution that seems to actually make sense for once

Andrew Bartlett
(This used to be commit 5c2e34b5b6a2241b8d2fd68458eb73bb65ade6fd)

18 years agoEven when I can't manage to do QA, at least the build farm will catch some of
Andrew Bartlett [Sun, 5 Jan 2003 04:59:42 +0000 (04:59 +0000)]
Even when I can't manage to do QA, at least the build farm will catch some of
the silly stuff.

(fixes password changes from RAP based clients like smbpasswd)

Andrew Bartlett
(This used to be commit 066e4f9a4bdd432b3b2b7830c0ac1421f6086df4)

18 years agoFix problem with "hide unreadable". stat file opens are baaack :-).
Jeremy Allison [Fri, 3 Jan 2003 19:07:26 +0000 (19:07 +0000)]
Fix problem with "hide unreadable". stat file opens are baaack :-).
(This used to be commit 6e0cfec16594ade6e6c499f521781348fee25040)

18 years agoregenerate man pages
Gerald Carter [Fri, 3 Jan 2003 17:35:18 +0000 (17:35 +0000)]
regenerate man pages
(This used to be commit 4461cd3adb4051383d052fb38c357d85ee473a74)

18 years agopatch to include support for daemontools from Michael Handler
Gerald Carter [Fri, 3 Jan 2003 17:32:11 +0000 (17:32 +0000)]
patch to include support for daemontools from Michael Handler
(This used to be commit 4c48c475a28450ad4fd8dcc8263e841c0c39a80e)

18 years agomake sure we create the PIDDIR and LOCKDIR from installdirs
Gerald Carter [Fri, 3 Jan 2003 15:31:46 +0000 (15:31 +0000)]
make sure we create the PIDDIR and LOCKDIR from installdirs
(This used to be commit 63d057fc7880d2522202451288087306e8fa3806)

18 years agooops. Use -r, not -f
Gerald Carter [Fri, 3 Jan 2003 15:21:01 +0000 (15:21 +0000)]
oops.  Use -r, not -f
(This used to be commit 33686a2a7d796d782f39da752a4af4b960bb1b59)

18 years agopatch from Andrew Bird to correct a few file/directory checks when building
Gerald Carter [Fri, 3 Jan 2003 15:19:51 +0000 (15:19 +0000)]
patch from Andrew Bird to correct a few file/directory checks when building
(This used to be commit 8a0fb1a60d923f4392ef1d797f570f7eb990011f)

18 years agoFixed some simple typos, including one that would have resulted in a
Christopher R. Hertel [Fri, 3 Jan 2003 04:32:23 +0000 (04:32 +0000)]
Fixed some simple typos, including one that would have resulted in a
DEBUG() message printing the wrong value.
(This used to be commit 42a4e5b851aa7c9fd9dca5a6f8f42e5d91246c76)

18 years agopstring/fstring missmatches found by Andrew Bartlett.
Jeremy Allison [Thu, 2 Jan 2003 20:43:27 +0000 (20:43 +0000)]
pstring/fstring missmatches found by Andrew Bartlett.
(This used to be commit 585a73b810389129f380cfab1b1b52700b350055)

18 years agoWITH_SENDFILE #ifdef merged from SAMBA_2_2
Gerald Carter [Thu, 2 Jan 2003 18:20:42 +0000 (18:20 +0000)]
WITH_SENDFILE #ifdef merged from SAMBA_2_2
(This used to be commit 5023aec5ada4a0d84878440ed67411b6a6b97ca2)

18 years agoWe still have 'ldap server' and 'ldap port'. Could somebody please
Volker Lendecke [Thu, 2 Jan 2003 16:12:39 +0000 (16:12 +0000)]
We still have 'ldap server' and 'ldap port'. Could somebody please
regen the docs?


(This used to be commit 0c04c660c5eff282e8bc44de58fa5dcf90201148)

18 years agoWe already have one function to move unistr2 -> multibyte-static, so we
Andrew Bartlett [Thu, 2 Jan 2003 13:10:25 +0000 (13:10 +0000)]
We already have one function to move unistr2 -> multibyte-static, so we
don't need a second just for pdb.

Also, remove magic 'is lp_guest_account' test - the magic RID should be
up to the passdb backend to set.

Andrew Bartlett
(This used to be commit f71c8338d35a2e8c73c3d8006ea6858cb522c715)

18 years agoBecouse these functions return a size_t, they can't return negitive numbers.
Andrew Bartlett [Thu, 2 Jan 2003 13:01:44 +0000 (13:01 +0000)]
Becouse these functions return a size_t, they can't return negitive numbers.
So a < 0 check is pointless, instead check against -1, which will be cast to

Andrew Bartlett
(This used to be commit c7e5797a95804d5779cdfc93795adcdf2fe82a59)

18 years agodebugparse is a seperate utility, no need to include it in the main ubiqx
Andrew Bartlett [Thu, 2 Jan 2003 12:58:23 +0000 (12:58 +0000)]
debugparse is a seperate utility, no need to include it in the main ubiqx

Andrew Bartlett
(This used to be commit 23abf75adef2f400414dfafa1248f5f886ae27c0)

18 years agoAdd PRINTF_ATTRIBUTE() to a few more printf() style functions. Aids in
Andrew Bartlett [Thu, 2 Jan 2003 12:54:02 +0000 (12:54 +0000)]
Add PRINTF_ATTRIBUTE() to a few more printf() style functions.  Aids in
compiler-based argument checking.
(This used to be commit 16fe928e68623a878b125910ff83df500a29d0ce)

18 years agoCall me parinoid, but I don't like the idea that we could ever have dbf point
Andrew Bartlett [Thu, 2 Jan 2003 12:53:04 +0000 (12:53 +0000)]
Call me parinoid, but I don't like the idea that we could ever have dbf point
to a closed file.  Swap the assign and the close around.

Andrew Bartlett
(This used to be commit ceb2a7984910533187d3345440c24b605306e3cb)

18 years agoAdd a dash of static.
Andrew Bartlett [Thu, 2 Jan 2003 12:39:36 +0000 (12:39 +0000)]
Add a dash of static.
(This used to be commit 6d201c9616c5c30234c0d0d6cd9e2ca60bf736c5)

18 years agoOne more const. Andrew, you seem to have krb5 :-)
Volker Lendecke [Thu, 2 Jan 2003 09:40:10 +0000 (09:40 +0000)]
One more const. Andrew, you seem to have krb5 :-)

(This used to be commit f5494f5ef6a14020bd31541b1f87d48111f60ad8)