20 years agoAdd SuSE 7.1 packaging (from SAMBA_2_2).
David O'Neill [Fri, 5 Jan 2001 18:05:52 +0000 (18:05 +0000)]
Add SuSE 7.1 packaging (from SAMBA_2_2).
(This used to be commit 69f28a868a7e78b8b93bbf7dcf21bf6fd813c12d)

20 years agoSync up packaging updates that didn't make it to HEAD.
David O'Neill [Fri, 5 Jan 2001 17:59:31 +0000 (17:59 +0000)]
Sync up packaging updates that didn't make it to HEAD.
(This used to be commit c6f7358535eb96112e055d60d39c1595601d3056)

20 years agoMerge of documentation updates to HEAD. These got missed somewhere along
David O'Neill [Fri, 5 Jan 2001 17:50:50 +0000 (17:50 +0000)]
Merge ... documentation updates to HEAD.  These got missed somewhere along
the way.
(This used to be commit afad150bacfd02ec83c57ea9ba9152ff59fb7eee)

20 years agoThe latest changes to libsmbclient ...
Richard Sharpe [Fri, 5 Jan 2001 13:43:19 +0000 (13:43 +0000)]
The latest changes to libsmbclient ...

It can now do a directory listing for workgroups, servers, and shares, and,
with a bit more effort, it will be able to list directories and files.

I also does not request a username and password for the IPC$ share, but it
should if the first attempt to connect fails.
(This used to be commit 38ff91c5059a32c7ad2fd6074697c7c7f68a878c)

20 years agoNeeded a callback arg on cli_list ...
Richard Sharpe [Fri, 5 Jan 2001 13:11:29 +0000 (13:11 +0000)]
Needed a callback arg on cli_list ...
(This used to be commit d45e667a74fc2fcbf69c4819d480269c03dbfae4)

20 years agoAdded extra argument to calls to smbw_share_add()
Tim Potter [Fri, 5 Jan 2001 00:17:36 +0000 (00:17 +0000)]
Added extra argument to calls to smbw_share_add()
(This used to be commit d006e6adca0548dad334d871c5d440b1d32ac879)

20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Thu, 4 Jan 2001 19:27:08 +0000 (19:27 +0000)]
Changes from APPLIANCE_HEAD:
        - changes to ctags and etags rules that somehow got lost along the way.

        - make proto

        - merge debugs for debugging user groups and NT token stuff.

        - capitalise domain name returned from parse_domain_user()

        - fix broken conditional in debug statement.

        - fix printer permission bugs related to ACE masks for printers.
          This adds mapping of generic access rights to object specific
          rights for NT printers.  Still need to work out whether or not to
          ignore ACEs with certain flags set, though. See comments in
          util_seaccess.c:check_ace() for details.

          until we sort out printer/printjob permission stuff.
(This used to be commit 1dba9c5cd1e6389734c648f6903abcb7c8d5b2f0)

20 years agoI need a callback arg for cli_NetServerEnum and cli_RNetShareEnum, so I had
Richard Sharpe [Thu, 4 Jan 2001 11:35:55 +0000 (11:35 +0000)]
I need a callback arg for cli_NetServerEnum and cli_RNetShareEnum, so I had
to modifiy any routine that calls it to pass NULL and so forth.

Should have no impact. It compiles OK.
(This used to be commit 7f862e387f935a2125481338eee850afcb8d82ba)

20 years agoAdd a new file clidgram with routines that are used by the libsmbclient code.
Richard Sharpe [Wed, 3 Jan 2001 05:19:21 +0000 (05:19 +0000)]
Add a new file clidgram with routines that are used by the libsmbclient code.

These routines handle the sending of dgrams in ways that don't bind us to
the nmbd code, but we may merge the two routines at some stage.

Also fix Makefile.in so the new code is compiled ...

Let's see whether or not it compiles on other architectures ...

Seems OK under Linux.
(This used to be commit f7466ba67cb6f863ee495e6de884e9b7a2e49430)

20 years agoWe only want to mark mailslot packets as loopback packets if they are to
Richard Sharpe [Wed, 3 Jan 2001 01:25:05 +0000 (01:25 +0000)]
We only want to mark mailslot packets as loopback packets if they are to
the DGRAM_PORT, since we want to actually send those to other ports.

They might be for the client library running on the Samba server!
(This used to be commit 05e2dd5e85d4aca1ccb9f6991e1415f85cbbdc1a)

20 years agoReturn an empty directory for a stat on a share we aren't allowed to
Tim Potter [Tue, 2 Jan 2001 23:42:36 +0000 (23:42 +0000)]
Return an empty directory for a stat on a share we aren't allowed to
connect to.  This gives a permission denied when a cd is attempted, but
not a permission denied in the directory listing one level up.
(This used to be commit 9255e526244578e092abc306491d5862469da775)

20 years agoReturn EACCES for bad password.
Tim Potter [Tue, 2 Jan 2001 23:41:15 +0000 (23:41 +0000)]
Return EACCES for bad password.
(This used to be commit 143006d32f0a0d339b870741b811ec49795b7099)

20 years agoMake the use of generate_name_trn_id conform to the usage elsewhere ...
Richard Sharpe [Tue, 2 Jan 2001 14:24:46 +0000 (14:24 +0000)]
Make the use of generate_name_trn_id conform to the usage elsewhere ...
(This used to be commit 46a3a56ecf411eb885aee2892e12d3846ce32ad6)

20 years agoComment out unused generate_name_trn_id ...
Richard Sharpe [Tue, 2 Jan 2001 14:00:27 +0000 (14:00 +0000)]
Comment out unused generate_name_trn_id ...
(This used to be commit fb5798e1d9eb518f85e30680883c0460141b245d)

20 years agoFixed -d option for rpcclient.
Tim Potter [Tue, 2 Jan 2001 04:23:17 +0000 (04:23 +0000)]
Fixed -d option for rpcclient.
(This used to be commit 44c5eb4def9a264f660b2398d28b72f54e6547e6)

20 years agoThe line was:
Christopher R. Hertel [Sat, 30 Dec 2000 23:17:30 +0000 (23:17 +0000)]
The line was:

        struct tdb_traverse_lock tl = { tdb->travlocks.next, 0, 0 };

The IRIX compiler complained that the first initialization value was not a
constant and errored out.  Here's what it looks like now:

        struct tdb_traverse_lock tl = { NULL, 0, 0 };
        int ret, count = 0;

        /* This was in the initializaton, above, but the IRIX compiler
         * did not like it.  crh
        tl.next = tdb->travlocks.next;

That worked.

Chris -)-----
(This used to be commit e651d1d642cd1bfac11bec81a30915b95d4424c8)

20 years agoFirst pass at the libsmbclient code ...
Richard Sharpe [Tue, 26 Dec 2000 05:57:10 +0000 (05:57 +0000)]
First pass at the libsmbclient code ...

This code handles the basic stuff and compiles and links under Linux, but
I do not know about any other operating systems. Now onto directory
listing routines, including those that list workgroups, servers, etc.

Nothing is built automatically yet, you have to make client/testsmbc to build
the library and test program. Also, no make install targets are defined for
libsmbclient.so as yet, either.

Would be good if people test on operating systems other than Linux.
(This used to be commit 51c0436a50e9f9274cee9de043bbefc93aff8011)

20 years agomerge from appliance head
Gerald Carter [Thu, 21 Dec 2000 23:38:47 +0000 (23:38 +0000)]
merge from appliance head
(This used to be commit 393c5f14e0858dcb3d6cb26eb5643b520c2c9686)

20 years agoReturn appropriate exit codes for various situations:
Tim Potter [Thu, 21 Dec 2000 23:36:25 +0000 (23:36 +0000)]
Return appropriate exit codes for various situations:

    0 for success
    1 if operation failed
    2 command line parse error
(This used to be commit b4773618acb60b62b20b01ff7ba749984c1379fb)

20 years agoDocumentation updates for smbcacls program.
Tim Potter [Thu, 21 Dec 2000 23:33:57 +0000 (23:33 +0000)]
Documentation updates for smbcacls program.
(This used to be commit f9450cd7b7352a206dc05d8ad2a7b86a2586b892)

20 years agoIf extra arguments passed make yodl docs for these files rather than *.yo
Tim Potter [Thu, 21 Dec 2000 23:27:51 +0000 (23:27 +0000)]
If extra arguments passed make yodl docs for these files rather than *.yo
(This used to be commit b57fbcca06c7a69863f69628745f8fcbc13419bd)

20 years agomerge from appliance head
Gerald Carter [Thu, 21 Dec 2000 23:23:34 +0000 (23:23 +0000)]
merge from appliance head
(This used to be commit 4671a313775f052ae949ba441db7e0060bed0b75)

20 years agomake proto
Tim Potter [Thu, 21 Dec 2000 22:58:26 +0000 (22:58 +0000)]
make proto
(This used to be commit a1ea59c9afb930b2084f175e72ac99ef314314a2)

20 years agoDon't call string_to_sid after cli_lsa_lookup_names() fails.
Tim Potter [Thu, 21 Dec 2000 06:21:26 +0000 (06:21 +0000)]
Don't call string_to_sid after cli_lsa_lookup_names() fails.

Can't use space as a ACL separator as it breaks NT user/group names that
contain spaces (i.e most of the default ones).

The MSDN is contradictory over the exact ordering of ACE entries in an ACL.
However NT4 gives a "The information may have been modified by a computer
running Windows NT 5.0" if denied ACEs do not appear before allowed ACEs.
Sort ACE list before calling cli_set_secdesc().
(This used to be commit 01a89978ff4b9fcc813c4f251ddfe23c0485a696)

20 years agoSome systems seem to only accept a ntcreate&x with a unicode filename
Tim Potter [Thu, 21 Dec 2000 05:28:39 +0000 (05:28 +0000)]
Some systems seem to only accept a ntcreate&x with a unicode filename
despite samba negotiating ascii filenames.  Retry with unicode pathnames
if the ascii version fails.

Convert all forward slashes to backslashes in the filename argument.
(This used to be commit 935b77573ec82bece6211a9f61c800ef1c8c9aa4)

20 years agoAdded a cli_nt_create_uni() to do a ntcreate&x with a unicode filename,
Tim Potter [Thu, 21 Dec 2000 05:22:15 +0000 (05:22 +0000)]
Added a cli_nt_create_uni() to do a ntcreate&x with a unicode filename,
regardless of the settings negotiated in the flags2 smb field.
(This used to be commit c4476c6315a6e99dd4a1d0e3185a0d17c073205d)

20 years agoReplace magic number with constant.
Tim Potter [Thu, 21 Dec 2000 00:30:32 +0000 (00:30 +0000)]
Replace magic number with constant.
(This used to be commit 1a228868cf14418894b798f19955df3276bd1089)

20 years agoCleaned up SidToString() and StringToSid() exit paths.
Tim Potter [Thu, 21 Dec 2000 00:12:59 +0000 (00:12 +0000)]
Cleaned up SidToString() and StringToSid() exit paths.

Can now use user%password format in $USER environment variable.  -U option
is now optional.
(This used to be commit e21f2ef4fbfae1451d77b53291a78646dee9cfce)

20 years agoRemoved uninitialised variable.
Jeremy Allison [Wed, 20 Dec 2000 20:43:48 +0000 (20:43 +0000)]
Removed uninitialised variable.
(This used to be commit 56a93567a106f25e87df093e1861f6bdd1d3196a)

20 years agoimplemented a much nicer name_status() interface. It now returns a
Andrew Tridgell [Wed, 20 Dec 2000 03:22:51 +0000 (03:22 +0000)]
implemented a much nicer name_status() interface. It now returns a
list of structures rather than the dodgy parsing code we had before

this also gets smbw working correctly with no initial workgroup (using
name_status_find on __MSBROWSE__ returns)
(This used to be commit f2be88a8738a39ca5c98936edb7537cd701348a1)

20 years agoFixed bug found by Gerald. If a Samba server joins a domain and is set
Jeremy Allison [Tue, 19 Dec 2000 23:57:48 +0000 (23:57 +0000)]
Fixed bug found by Gerald. If a Samba server joins a domain and is set
to search for a DC to authenticate to using the "*" syntax than ensure
that for the first hour after the password change is searches for the
PDC using the 1B name not the 1C name as domain replication may not
have occured.
(This used to be commit c25533de9918ed9b0c79fd039e11d1b79f513db0)

20 years agoSplit set_nt_acls into owner set (which uses chown) and permission set
Jeremy Allison [Tue, 19 Dec 2000 20:00:28 +0000 (20:00 +0000)]
Split set_nt_acls into owner set (which uses chown) and permission set
(which currently uses chmod) in preparation for ACL creation.
(This used to be commit 0f39895ab007a7300aed6c011c487593ee8c91f0)

20 years agoSplit the one sys_acl_free call into sys_acl_free_TYPE calls, to allow
Jeremy Allison [Tue, 19 Dec 2000 18:41:51 +0000 (18:41 +0000)]
Split the one sys_acl_free call into sys_acl_free_TYPE calls, to allow
easier wrapping of non-POSIX ACL interfaces.
(This used to be commit 1a31b4eb082b23d60e3d9040b3c0110eef1f9385)

20 years agoA couple more UMR fixes.
Jeremy Allison [Mon, 18 Dec 2000 20:03:15 +0000 (20:03 +0000)]
A couple more UMR fixes.
(This used to be commit a83702c99f1ecd6e68f8c178b20823fce6d4c6c6)

20 years agoCast prs_alloc_mem to correct type.
Jeremy Allison [Mon, 18 Dec 2000 07:24:48 +0000 (07:24 +0000)]
Cast prs_alloc_mem to correct type.
(This used to be commit e0931cda809e4bb48bd97cad6d7ab5fb6dc53eb2)

20 years agoFix typos in new group sid check.
Jeremy Allison [Mon, 18 Dec 2000 07:22:10 +0000 (07:22 +0000)]
Fix typos in new group sid check.
(This used to be commit c48e95297e63c8b6f0c6686e5bcfa52229710dbc)

20 years agoAdded query info policy call.
Tim Potter [Mon, 18 Dec 2000 06:09:40 +0000 (06:09 +0000)]
Added query info policy call.
(This used to be commit dcea2a4bc0503822667b73d19c4f0a59b15715a5)

20 years agoMerged Tim's fixes from appliance-head.
Jeremy Allison [Mon, 18 Dec 2000 06:02:31 +0000 (06:02 +0000)]
Merged Tim's fixes from appliance-head.
(This used to be commit 26f873540c2299600cb80eb059fcdaf70ec82473)

20 years agoStreamlined exit path.
Tim Potter [Mon, 18 Dec 2000 05:27:44 +0000 (05:27 +0000)]
Streamlined exit path.

Allow NULL to be passed to cli_lsa_initialise() which creates an anonymous
connection to the server.
(This used to be commit 8ccd06ee9635e81bdefa8ae58a88c39f132b371c)

20 years agoFixed chown/chgrp setting from smbcacls.
Jeremy Allison [Sat, 16 Dec 2000 00:34:58 +0000 (00:34 +0000)]
Fixed chown/chgrp setting from smbcacls.
(This used to be commit 43ca0d991cc6489be16722a7ea89e01a42f2ca2f)

20 years agoAdded -C username and -G username that allow a user (usually Administrator)
Jeremy Allison [Sat, 16 Dec 2000 00:08:05 +0000 (00:08 +0000)]
Added -C username and -G username that allow a user (usually Administrator)
to change the ownership or group ownership of a file to any arbitrary user
from the UNIX command line.
This will show the people who quote NT manuals at us about how this is
"impossible" how their operating system really works :-).
(This used to be commit 12f88c9ba731bdded626b9d011cfc8d2ba09010e)

20 years agoDocumented -C and -G options to smbcacls.
Jeremy Allison [Sat, 16 Dec 2000 00:06:05 +0000 (00:06 +0000)]
Documented -C and -G options to smbcacls.
(This used to be commit 89708be73ad8829ee2e9637db2e2be6493493396)

20 years agoNever free anything in the rpc_parse/prs_XXX functions. Do it in the enclosing
Jeremy Allison [Fri, 15 Dec 2000 23:02:01 +0000 (23:02 +0000)]
Never free anything in the rpc_parse/prs_XXX functions. Do it in the enclosing
lib/util_unistr.c: Check lengths *before* reading source - prevent uninitialised
memory reads.
(This used to be commit ce4f461965c872fbfc9fe5f6b98aed58bb3dd67a)

20 years agoAdded lock backouts on fail.
Jeremy Allison [Fri, 15 Dec 2000 21:29:06 +0000 (21:29 +0000)]
Added lock backouts on fail.
When chaining together long lines of bloody "if" statements, which should
logically be separated, and one of them allocates memory, remember to
Yes I do consider this a bug in the coding style of Tridge, Rusty, Tim et al. :-).
I'm just pissed 'cos this took 4 hours to track down even with an insure error report
stating me in the face and also Ben Woodward looking over the code with me :-).
(This used to be commit 506b5e34c3ba16768dbc82ba21044787de160c45)

20 years agolib/util_unistr.c:
Jean-Fran├žois Micouleau [Fri, 15 Dec 2000 09:31:56 +0000 (09:31 +0000)]
        rewrote unistr2_to_ascii() to correct a bug seen on SGI boxes.

        rewrote of BUFFER5 handling to NOT byteswap when it was already in
        network byte order.

        cleanup of samr_io_q_lookup_domain(), remove the over-parsing by 2

        UNISTR2 strings need to be NULL terminated to pleased W2K.

        use snprintf instead of safe_strcpy as we want the string
        truncated at 32 chars.

That should fix SUN and SGI box not able to act as printserver and the
problem with joining from a W2K wks.

(This used to be commit 69fe739303b105f2c488f266f13977da1b6b201d)

20 years agoFixed memory leak in JOB_INFO_2 code.
Jeremy Allison [Fri, 15 Dec 2000 01:47:37 +0000 (01:47 +0000)]
Fixed memory leak in JOB_INFO_2 code.
(This used to be commit d0d31eead3367485bbac684d881839029010975d)

20 years agoFixed memory leaks in lsa_XX calls. Fixed memory leaks in smbcacls. Merged
Jeremy Allison [Fri, 15 Dec 2000 01:02:11 +0000 (01:02 +0000)]
Fixed memory leaks in lsa_XX calls. Fixed memory leaks in smbcacls. Merged
in fixes from appliance-head and 2.2. Fixed multiple connection.tdb open
(This used to be commit 0a40bc83e14c69a09948ec09bb6fc5026c4f4c14)

20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Thu, 14 Dec 2000 19:31:24 +0000 (19:31 +0000)]
Changes from APPLIANCE_HEAD:
    - add some debugs for comparing two security descriptors.
(This used to be commit 505a8a2277f2bc761bd2b170fafbcb3afd982d92)

20 years agoUpdates from appliance-head.
Jeremy Allison [Thu, 14 Dec 2000 18:37:01 +0000 (18:37 +0000)]
Updates from appliance-head.
(This used to be commit 15ae2c335b52e34c06d8f4f9ebad28078292b208)

20 years agoRenamed parameters and variables called acl to the_acl as it conflicts
Tim Potter [Thu, 14 Dec 2000 05:38:05 +0000 (05:38 +0000)]
Renamed parameters and variables called acl to the_acl as it conflicts
with a Solaris system call.
(This used to be commit 5e547ddcb526be5562db9213c5b36e505e735a2e)

20 years agoUpdated smbcacls documentation.
Tim Potter [Thu, 14 Dec 2000 04:57:14 +0000 (04:57 +0000)]
Updated smbcacls documentation.
(This used to be commit bd87398b5a9421add8db8b455d02ccd6b2624f58)

20 years agoCache lsa connection and policy handle for resolving names and sids.
Tim Potter [Thu, 14 Dec 2000 03:27:53 +0000 (03:27 +0000)]
Cache lsa connection and policy handle for resolving names and sids.
(This used to be commit 09d2d972fd6f70bdf62f25936494968ef597b98b)

20 years agoinverted dword value
Gerald Carter [Wed, 13 Dec 2000 21:49:31 +0000 (21:49 +0000)]
inverted dword value

(This used to be commit 0e5c1df2841ee0dd44bb5c52af90ca98649a4d55)

20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Wed, 13 Dec 2000 21:24:06 +0000 (21:24 +0000)]
Changes from APPLIANCE_HEAD:
- trivial typo in definition of enum_printing[]
- fixed printer status display bug.  When no jobs existed in queue, the
  clients were not properly notified of printer status.  This caused
  native tools for pausing/unpausing a print queue to not work.
(This used to be commit c533e77f1912618230a938458980a9339924fe06)

20 years agoAdded proto definition for new RPC calls.
Jeremy Allison [Wed, 13 Dec 2000 19:55:48 +0000 (19:55 +0000)]
Added proto definition for new RPC calls.
Added printing fix from appliance-head.
(This used to be commit f4c7f9ddb906b67ee4397e7707309356085476d1)

20 years agoI think it's time to go home.
Tim Potter [Wed, 13 Dec 2000 13:10:22 +0000 (13:10 +0000)]
I think it's time to go home.
(This used to be commit fde66badf143cde40af35e86d55acb48dc754cdd)

20 years agoOK so I shouldn't have added cli_pipe.o to LIBSMB_OBJ.
Tim Potter [Wed, 13 Dec 2000 13:04:49 +0000 (13:04 +0000)]
OK so I shouldn't have added cli_pipe.o to LIBSMB_OBJ.
(This used to be commit a724850eb83e61450f112c0b2e6e3492c2a72863)

20 years agoAdd libsmb/cli_lsarpc.o and rpc_client/cli_pipe.o to LIBSMB_OBJ. Not so
Tim Potter [Wed, 13 Dec 2000 12:54:57 +0000 (12:54 +0000)]
Add libsmb/cli_lsarpc.o and rpc_client/cli_pipe.o to LIBSMB_OBJ.  Not so
sure about the latter...

(This used to be commit c130d5b0f6a23b4fe19accad8a49ac58a1a8b0b1)

20 years agoConvert names to sids when modifying ACLs. Convert sids to names when
Tim Potter [Wed, 13 Dec 2000 12:53:42 +0000 (12:53 +0000)]
Convert names to sids when modifying ACLs.  Convert sids to names when
displaying ACLs.
(This used to be commit 5001bbc64be62af1597eb334e5b530b415d62a6b)

20 years agoLightweight rpc client library. Uses only routines in libsmb and
Tim Potter [Wed, 13 Dec 2000 12:52:21 +0000 (12:52 +0000)]
Lightweight rpc client library.  Uses only routines in libsmb and

Only cli_lsa_open_policy(), cli_lsa_close(), cli_lsa_lookup_names()
and cli_lsa_lookup_sids() implemented so far.
(This used to be commit 129d5a155a73d926868d74f8447c1e93b429388d)

20 years agoServer side changes for dynamic names in lsa_lookup_names
Tim Potter [Wed, 13 Dec 2000 12:39:55 +0000 (12:39 +0000)]
Server side changes for dynamic names in lsa_lookup_names
(This used to be commit 5c5c3a8a08efe8c2f36a55b1383e9d3dd9eca4a5)

20 years agomake proto
Tim Potter [Wed, 13 Dec 2000 12:13:22 +0000 (12:13 +0000)]
make proto

Updates for dynamic sized lookup names/sids
(This used to be commit 34743c157632b1784bd15e3ca97380b1f9754e46)

20 years agoWrong length for unistr2 in init_q_lookup_names()
Tim Potter [Wed, 13 Dec 2000 11:53:37 +0000 (11:53 +0000)]
Wrong length for unistr2 in init_q_lookup_names()

Removed some more static arrays and replaced with tallocated memory
(This used to be commit 1db0f31ae00bf9c91eb7d02c96bf766d04c7bdef)

20 years agoTwo tdb bugfixes. First one - ensure that traverse lock is moved before deleting
Jeremy Allison [Wed, 13 Dec 2000 06:33:53 +0000 (06:33 +0000)]
Two tdb bugfixes. First one - ensure that traverse lock is moved before deleting
dead records, else the record is just marked for deletion, not actually deleted.
Second, ensure allocated record is marked as "in use" before free list lock is
released, else other processes in the freelist merge code may try and merge it.
(This used to be commit dd959fa325c5df8ce0407d8debea76602c8e71cf)

20 years agoAdded support for SERVICESF shared variable to change configuration file
Tim Potter [Wed, 13 Dec 2000 04:19:48 +0000 (04:19 +0000)]
Added support for SERVICESF shared variable to change configuration file
used in lp_load().
(This used to be commit 4d80ee4f41ac3d61579c9cf23cb815d7fe5da5db)

20 years agoFixed bug noticed by JF. se_access_check needs user SID as first in token.
Jeremy Allison [Tue, 12 Dec 2000 20:41:02 +0000 (20:41 +0000)]
Fixed bug noticed by JF. se_access_check needs user SID as first in token.
(This used to be commit f0d7867801e3f78bfc55fdb36ca965e35457f51b)

20 years agoFixed processing of dfree script (was truncating).
Jeremy Allison [Tue, 12 Dec 2000 19:44:50 +0000 (19:44 +0000)]
Fixed processing of dfree script (was truncating).
(This used to be commit 1e719a807669876b4d11f4653e9712f25fcba20b)

20 years agoBrief documentation on using the virtual printer code
David O'Neill [Tue, 12 Dec 2000 18:03:50 +0000 (18:03 +0000)]
Brief documentation on using the virtual printer code
(This used to be commit 03dd90ab923ec88cdada8c5d725d9482bd9826f2)

20 years agomore fixes from Simo. Also fixed the password expiration field
Gerald Carter [Tue, 12 Dec 2000 16:50:23 +0000 (16:50 +0000)]
more fixes from Simo.  Also fixed the password expiration field
in the tdbsam to never expire (we don't support this yet).

(This used to be commit 3b7d0fe7eb3a9275d2713d7b3325de0ab510ea62)

20 years agoDon't print out the security descriptor type as it is automatically
Tim Potter [Tue, 12 Dec 2000 06:14:01 +0000 (06:14 +0000)]
Don't print out the security descriptor type as it is automatically
calculated by the new make_sec_desc() function.
(This used to be commit 6fd5dc81458317e106f5ea24958cefe4146c90a6)

20 years agoBetter error checking for ACL parsing.
Tim Potter [Tue, 12 Dec 2000 06:06:10 +0000 (06:06 +0000)]
Better error checking for ACL parsing.

Print an error when attempting to delete a non-existent ACL.
(This used to be commit d119782d0d8d2738650da47fa11134d26134ce17)

20 years agoFix error string.
Tim Potter [Tue, 12 Dec 2000 06:05:13 +0000 (06:05 +0000)]
Fix error string.
(This used to be commit 73b237e639717019c596954c745b7e4d038ddc8c)

20 years agoFixed some accidentally reversed patches.
Tim Potter [Tue, 12 Dec 2000 05:58:34 +0000 (05:58 +0000)]
Fixed some accidentally reversed patches.
(This used to be commit fa604bc85ea6989c794747f668be8a4e62527b79)

20 years agoCompile fix for new arg to create_nt_token()
Tim Potter [Tue, 12 Dec 2000 05:29:47 +0000 (05:29 +0000)]
Compile fix for new arg to create_nt_token()
(This used to be commit 806185ca8cc8d28f16745a1db9427f52eb8d22e4)

20 years agoMerged in Tim's changes : Removed static limit of MAX_LOOKUP_SIDS in rpc server and...
Jeremy Allison [Tue, 12 Dec 2000 02:45:11 +0000 (02:45 +0000)]
Merged in Tim's changes : Removed static limit of MAX_LOOKUP_SIDS in rpc server and client
lsa_lookup_names() and lsa_lookup_sids().
(This used to be commit 9e9c71c8b3194b7cd02fea0b6a000d4f2940d905)

20 years agoRemoved the special casing of SIDs in se_access_check. This is now done (correctly)
Jeremy Allison [Tue, 12 Dec 2000 02:36:14 +0000 (02:36 +0000)]
Removed the special casing of SIDs in se_access_check. This is now done (correctly)
when the NT_USER_TOKEN is *created*.
(This used to be commit 27d72ed1cf8ece2bede812341279ba5a7262ace4)

20 years agoOwner always has READ_CONTROL and WRITE_DAC access.
Jeremy Allison [Tue, 12 Dec 2000 00:42:55 +0000 (00:42 +0000)]
Owner always has READ_CONTROL and WRITE_DAC access.
(This used to be commit 05fcb124dfbb1a257828e9dc6a7793fc3dc73c4b)

20 years agoSorry Gerald, I think the original code was better (plus safer as I'm sure
Jeremy Allison [Tue, 12 Dec 2000 00:11:34 +0000 (00:11 +0000)]
Sorry Gerald, I think the original code was better (plus safer as I'm sure
it's working :-).
(This used to be commit e18c104ee35d00dcbe2e73e6c9699300a3947364)

20 years agoExtra part of fix that Gerald missed (sorry).
Jeremy Allison [Tue, 12 Dec 2000 00:05:02 +0000 (00:05 +0000)]
Extra part of fix that Gerald missed (sorry).
(This used to be commit ebf754400f443452948020d68e29f597f1b2d60c)

20 years agosubtle bug where files which missed the stat_cache but were added
Gerald Carter [Mon, 11 Dec 2000 22:51:57 +0000 (22:51 +0000)]
subtle bug where files which missed the stat_cache but were added
to the cache during the look returned a blank stat struct.  Made
weird occurrences such as...

   $ smbclient //pogo/print$
   smb:\ > cd w32x86
     ERROR: Invalid path
   smb:\ > cd w32x86

   smb:\w32x86\ >
(This used to be commit 8938dc183112b039c21a5a0beadb60068a8c5b00)

20 years agoFix for short names not being returned correctly with non-mangled shares.
Jeremy Allison [Mon, 11 Dec 2000 22:31:25 +0000 (22:31 +0000)]
Fix for short names not being returned correctly with non-mangled shares.
(This used to be commit bcf0a5c316ee8cf333d9d838b041e44a11cb5f1b)

20 years agoFixed very subtle bug returning correct error on an open, when we have
Jeremy Allison [Mon, 11 Dec 2000 21:09:48 +0000 (21:09 +0000)]
Fixed very subtle bug returning correct error on an open, when we have
a choice of invalid share mode and access denied. We must return the
access denied by preference, but also remember to break the oplocks...
This is needed for multi-user MS-Access.
(This used to be commit 7eb7241442ea0f1e065b009c3cccd5821b89a8b6)

20 years agoAdding in debug for SD's.
Jeremy Allison [Mon, 11 Dec 2000 19:24:59 +0000 (19:24 +0000)]
Adding in debug for SD's.
(This used to be commit a19f936b644fedc4c59ada5f12172abed9894910)

20 years agocode review of rpcclient
Gerald Carter [Mon, 11 Dec 2000 18:13:19 +0000 (18:13 +0000)]
code review of rpcclient

  o added some comments
  o abstracted a few code bits
  o cleaned up some code by removing unused code paths

-- jerry
(This used to be commit 679453af36c06ae9c82dd20742a56272ec73f427)

20 years agotype for client_info struct
Gerald Carter [Mon, 11 Dec 2000 17:51:05 +0000 (17:51 +0000)]
type for client_info struct
(This used to be commit 2c03b91d6041082bba6ba4322ed41b4378af7ef3)

20 years agonew version of Get_Pwnam()
Gerald Carter [Mon, 11 Dec 2000 17:48:26 +0000 (17:48 +0000)]
new version of Get_Pwnam()

  o check the username in all lowercase
  o check the username as transmitted if this would be a different case
  o check the username in all upper case if this is a new version

-- jerry
(This used to be commit 059f4fee5d8ad72cd699995c660263ed2cc4f25f)

20 years agoreturn NULL instead of return False in char *prs_mem_get();
Tim Potter [Mon, 11 Dec 2000 06:34:12 +0000 (06:34 +0000)]
return NULL instead of return False in char *prs_mem_get();
(This used to be commit 71e5e802b78b22af9be7d3e84e869f311937e542)

20 years agoAdded Tim's fix for read-only crashes.
Jeremy Allison [Mon, 11 Dec 2000 06:10:32 +0000 (06:10 +0000)]
Added Tim's fix for read-only crashes.
(This used to be commit cfc62fecdf4c5579ee643df3e701cf6f1fe553ee)

20 years agonew prototypes
Andrew Tridgell [Mon, 11 Dec 2000 00:10:06 +0000 (00:10 +0000)]
new prototypes
(This used to be commit 2258a62365e6fa3f08fd3b911e13b391515eaa46)

20 years agoadded support for browsing the list of workgroups at the top level in
Andrew Tridgell [Mon, 11 Dec 2000 00:09:06 +0000 (00:09 +0000)]
added support for browsing the list of workgroups at the top level in
(This used to be commit 8f97d59186ee3b52f623d30dfb7b195ec721ec0c)

20 years agoexposed the broadcast name resolution routine outside namequery.c
Andrew Tridgell [Mon, 11 Dec 2000 00:08:17 +0000 (00:08 +0000)]
exposed the broadcast name resolution routine outside namequery.c
(This used to be commit 7d1d867acdc0f316d8de787e1f7fa27667ec4a6a)

20 years agogroup rid assignment cut and paste error
Gerald Carter [Sat, 9 Dec 2000 20:45:04 +0000 (20:45 +0000)]
group rid assignment cut and paste error

(This used to be commit bb48b02d5f2118470a415d5f1f92305688e6b432)

20 years agoFixed typo causing coredump in file_lines_parse.
Jeremy Allison [Sat, 9 Dec 2000 06:34:59 +0000 (06:34 +0000)]
Fixed typo causing coredump in file_lines_parse.
(This used to be commit f575f4d67a5b45e47c29de30f02901c55cef4621)

20 years agoFixed compiler warning.
Jeremy Allison [Fri, 8 Dec 2000 19:59:22 +0000 (19:59 +0000)]
Fixed compiler warning.
(This used to be commit e6a1a1e444631f0d674f33b5b8d1d71435de0511)

20 years agoAdded OLD_NTDOMAIN to remove warnings about undefined functions.
Jeremy Allison [Fri, 8 Dec 2000 19:35:58 +0000 (19:35 +0000)]
Added OLD_NTDOMAIN to remove warnings about undefined functions.
(This used to be commit f4c32a75e6e60eae6078449478d04ff22373d817)

20 years agoRemoved unused auto (IRIX compiler warning).
Jeremy Allison [Fri, 8 Dec 2000 19:21:09 +0000 (19:21 +0000)]
Removed unused auto (IRIX compiler warning).
(This used to be commit 63e2ebc4272cd8bc52ea80e1e12996ab273b8ea4)

20 years agoRemoved a dead function.
Tim Potter [Fri, 8 Dec 2000 03:57:50 +0000 (03:57 +0000)]
Removed a dead function.
(This used to be commit 4c8ce7af4625bd2a47006fa4b3cf9cb40d62841a)

20 years agoCosmetic fixups for large file support message.
Tim Potter [Fri, 8 Dec 2000 03:44:52 +0000 (03:44 +0000)]
Cosmetic fixups for large file support message.
(This used to be commit 671be482212634b9c1de40891032180fbc1d49ba)

20 years agoPort of lsa_lookup_sids() and lsa_lookup_names() rpc client functions from
Tim Potter [Fri, 8 Dec 2000 03:34:00 +0000 (03:34 +0000)]
Port of lsa_lookup_sids() and lsa_lookup_names() rpc client functions from
TNG branch.

Re-instated lsa_lookup_sids and lsa_lookup_names functions in rpcclient.

This requires most samba binaries to link in another handful of object
files due to uncessary coupling between modules.  )-:
(This used to be commit 817819d0cc3ecf642be5a1656be3b71bed260ee4)

20 years agoModified argc passed to rpc_client cmd_* functions to include argv[0].
Tim Potter [Fri, 8 Dec 2000 03:24:38 +0000 (03:24 +0000)]
Modified argc passed to rpc_client cmd_* functions to include argv[0].

Gerald, could you check to see I haven't introduced any bugs into
(This used to be commit 77b0bda4df3217cd186d5b8f902a50f35346d98d)