13 years agoEINVAL is also a valid error return, meaning "this filesystem
Andrew Tridgell [Tue, 26 Aug 2008 04:06:42 +0000 (14:06 +1000)]
EINVAL is also a valid error return, meaning "this filesystem
cannot do sendfile for this file"
(This used to be commit 737f664604b28f230be63bfc2f3d516fd9eb1c63)

13 years agobecome root for AIO operations
Andrew Tridgell [Sun, 24 Aug 2008 03:58:05 +0000 (13:58 +1000)]
become root for AIO operations

We need to become root for AIO read and write to allow the AIO thread
to send a completion signal to the parent process when the IO
(This used to be commit c548e5c69f9d8bc85a654f4d29d64c735a5e780b)

13 years agoAvoid a race condition in glibc between AIO and setresuid().
Andrew Tridgell [Sun, 24 Aug 2008 03:56:59 +0000 (13:56 +1000)]
Avoid a race condition in glibc between AIO and setresuid().

See this test: http://samba.org/~tridge/junkcode/aio_uid.c

The problem is that setresuid() tries to be clever about threads, and
tries to change the euid of any threads that are running. If a AIO read
or write completes while this is going on then the signal from the thread
where the IO completed is lost, as it gets -1/EPERM from rt_sigqueueinfo()

The simplest fix is to try to use setreuid() instead of setresuid(),
as setreuid() doesn't try to be clever. Unfortunately this also means
we must use become_root()/unbecome_root() in the aio code.
(This used to be commit 56c5a6f024875bb79b0104beb36f6b0ec1e1e9f9)

13 years agofixed an errno handling bug that could lead to an infinite loop
Andrew Tridgell [Sun, 24 Aug 2008 03:53:19 +0000 (13:53 +1000)]
fixed an errno handling bug that could lead to an infinite loop
(This used to be commit 5ccdc58ce91ee40ca7171dd040191291aeb7fe02)

13 years agofixed tsmsm_sendfile(). The logic was totally broken.
Andrew Tridgell [Sat, 23 Aug 2008 01:36:27 +0000 (11:36 +1000)]
fixed tsmsm_sendfile(). The logic was totally broken.
(This used to be commit 794e48b809036871287df8416a2c669b7e26f216)

13 years agobuild: make sure to create CODEPAGEDIR and MODULESDIR.
Günther Deschner [Tue, 26 Aug 2008 11:47:43 +0000 (13:47 +0200)]
build: make sure to create CODEPAGEDIR and MODULESDIR.

(This used to be commit d31683cdc877b468e7443216ab9e6edff844c131)

13 years agoFix bug 4516, no IPv6 on Solaris 2.6.
David Leonard [Mon, 25 Aug 2008 22:17:53 +0000 (15:17 -0700)]
Fix bug 4516, no IPv6 on Solaris 2.6.
(This used to be commit b5d0f751e4bf19c2ad306ebb3baeb5e9e83e49ee)

13 years agowinbindd: use set_auth_errors() in winbindd_dual_check_machine_acct as well.
Günther Deschner [Mon, 25 Aug 2008 11:03:15 +0000 (13:03 +0200)]
winbindd: use set_auth_errors() in winbindd_dual_check_machine_acct as well.

(This used to be commit bb9c59e892cc9d3047bde89a15cc341e2bd21bc5)

13 years agowinbindd: move set_auth_errors to util functions.
Günther Deschner [Mon, 25 Aug 2008 11:15:41 +0000 (13:15 +0200)]
winbindd: move set_auth_errors to util functions.

(This used to be commit ae3fa60c4546c7420722d8f422c22bbfd623ff5b)

13 years agowinbindd: only create machine pwd change event when in primary domain child.
Günther Deschner [Mon, 25 Aug 2008 09:37:57 +0000 (11:37 +0200)]
winbindd: only create machine pwd change event when in primary domain child.

(This used to be commit 543dfdc1cf6baf60bffc23c6aebc542fd58d2d2e)

13 years agoauth: Fix build warning.
Günther Deschner [Mon, 25 Aug 2008 09:36:56 +0000 (11:36 +0200)]
auth: Fix build warning.

(This used to be commit 4661ef625a6522d6f859b83e3e3702f01d0b952f)

13 years agoFix some nonempty blank lines
Volker Lendecke [Sun, 24 Aug 2008 10:46:26 +0000 (12:46 +0200)]
Fix some nonempty blank lines
(This used to be commit 010c7101e59477f0d5f3bf11c17f474ec6f79cc1)

13 years agoFix some C++ warnings
Volker Lendecke [Sun, 24 Aug 2008 10:43:36 +0000 (12:43 +0200)]
Fix some C++ warnings
(This used to be commit dd9e4e6db04acf20f6ef7705955358c7ca442bbd)

13 years agoRevert "Protect against short read&x replies"
Volker Lendecke [Sat, 23 Aug 2008 13:40:43 +0000 (15:40 +0200)]
Revert "Protect against short read&x replies"

This reverts commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1.

... how did this end up here??

(This used to be commit 7dd9fd0956bd1c46105d1072c4774972933ab9ec)

13 years agoProtect against short read&x replies
Volker Lendecke [Wed, 13 Aug 2008 17:57:19 +0000 (19:57 +0200)]
Protect against short read&x replies
(This used to be commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1)

13 years agoFix some nonempty blank lines
Volker Lendecke [Tue, 19 Aug 2008 08:14:59 +0000 (10:14 +0200)]
Fix some nonempty blank lines
(This used to be commit 541e088656773d2b3b56a5a8bdc8dea6c9edec86)

13 years agoUse talloc_stackframe() in machine_password_change_handler
Volker Lendecke [Sat, 23 Aug 2008 11:12:36 +0000 (13:12 +0200)]
Use talloc_stackframe() in machine_password_change_handler
(This used to be commit 79103000b13c95325534db749a0da638a3eb1807)

13 years agoFix a memleak in calculate_next_machine_pwd_change
Volker Lendecke [Sat, 23 Aug 2008 11:12:05 +0000 (13:12 +0200)]
Fix a memleak in calculate_next_machine_pwd_change
(This used to be commit 5314f06dcdf14ce5e038a03a3e4dfded227bd00c)

13 years agowinbindd: add event based machine password change.
Günther Deschner [Wed, 20 Aug 2008 23:20:22 +0000 (01:20 +0200)]
winbindd: add event based machine password change.

(This used to be commit 15b72d44cbde0b8a375d8ed3d045c40ae97ec05a)

13 years agoDon't re-initialize a token when we already have one. This fixes the build farm failu...
Jeremy Allison [Fri, 22 Aug 2008 20:49:46 +0000 (13:49 -0700)]
Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest.
This one took a *lot* of tracking down :-).
(This used to be commit dca827791276906436452c650062164eb819dfe0)

13 years agoidmap_gid_to_sid: Fix a cut-a-npaste error.
Gerald (Jerry) Carter [Fri, 22 Aug 2008 19:54:50 +0000 (14:54 -0500)]
idmap_gid_to_sid: Fix a cut-a-npaste error.

The call was looking up a uid and not gid in the cache.
(This used to be commit 25293ba1507f8f8fa7e33c302200184e980bb123)

13 years agowinbindd: Fix crash in cm_connect_sam()
Gerald (Jerry) Carter [Fri, 22 Aug 2008 15:17:04 +0000 (10:17 -0500)]
winbindd: Fix crash in cm_connect_sam()

Fix segv when talking to parent DC (joined to child domain).

The root cause was

(a) storing the parent domain in the cli_state struct caused
    the NTLMSSP pipe bind to fail which made us fallover to
    the schannel code path
(b) the dcinfo pointer in cm_get_schannel_dcinfo() was returning
    NULL even though the function indicated success.
(This used to be commit 5ce4a2ae6697970ea37d0078a506615b4b7a9a9c)

13 years agocifs.upcall: bump SPNEGO msg version number and don't reject old versions
Jeff Layton [Fri, 22 Aug 2008 17:29:16 +0000 (13:29 -0400)]
cifs.upcall: bump SPNEGO msg version number and don't reject old versions

When we added the ability for the kernel to send sec=mskrb5 to the
upcall, we subtly broke old cifs.upcall versions that don't understand
it. Bump the spnego message version to 2 to make this clear. Also,
change cifs.upcall to not reject requests with a version that's lower
than the current one, and to send the reply with the same version that
the request sent. The idea is to try and keep cifs.upcall backward
compatible with old kernels.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(This used to be commit b868463015dedc684eb13d12118a98ccca71250a)

13 years agomanpages: Add documentation for new 'net rpc vampire' subcommands.
Karolin Seeger [Fri, 22 Aug 2008 15:23:36 +0000 (17:23 +0200)]
manpages: Add documentation for new 'net rpc vampire' subcommands.

(This used to be commit 8d0a16d8034cd07037b3c7711867280d5fa5b2c8)

13 years agonet: Add missing colon to unify usage messages.
Karolin Seeger [Fri, 22 Aug 2008 14:47:19 +0000 (16:47 +0200)]
net: Add missing colon to unify usage messages.

(This used to be commit c7aef4b38bd2b152b316d8d76b45be4b73ca315f)

13 years agomanpages: Add manpage for "init logon delayed hosts".
Karolin Seeger [Fri, 22 Aug 2008 09:04:49 +0000 (11:04 +0200)]
manpages: Add manpage for "init logon delayed hosts".

(This used to be commit a415244365e32ba18919042ec72b3a281d8c1b0a)

13 years agomanpages: Add manpage for "init logon delay".
Karolin Seeger [Fri, 22 Aug 2008 09:04:16 +0000 (11:04 +0200)]
manpages: Add manpage for "init logon delay".

(This used to be commit fc5010e6d988939779bcb44e8a460b7b05e7ba9a)

13 years agoloadparm: idmap backend is not depracated any longer.
Karolin Seeger [Fri, 22 Aug 2008 08:05:42 +0000 (10:05 +0200)]
loadparm: idmap backend is not depracated any longer.

(This used to be commit fcfab4703628e19902c140a7ad9531d4be0de01d)

13 years agocifs.upcall: fix build warning
Jeff Layton [Fri, 22 Aug 2008 01:21:48 +0000 (21:21 -0400)]
cifs.upcall: fix build warning

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(This used to be commit aa3443492c58a7c109fe159e15d763dbafc66f2a)

13 years agocifs.upcall: enable building by default on linux
Jeff Layton [Mon, 18 Aug 2008 17:49:59 +0000 (13:49 -0400)]
cifs.upcall: enable building by default on linux

When building on linux, default to building cifs.upcall. Throw a
warning if ADS support is disabled or keyutils isn't installed.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(This used to be commit d8018d15f013b8d7be8618b75dac5112711193b7)

13 years agocifs.upcall: move default install location to EPREFIX/sbin
Jeff Layton [Mon, 18 Aug 2008 17:49:59 +0000 (13:49 -0400)]
cifs.upcall: move default install location to EPREFIX/sbin

cifs.upcall links to libraries that live under /usr, so installing it
in /sbin doesn't seem appropriate. Move it to EPREFIX/sbin instead
(i.e. /usr/sbin).

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(This used to be commit 5c9a1b2c98cc712fc519225e62fba4e5088631a3)

13 years agocifs.upcall: handle MSKRB5 OID properly
Jeff Layton [Wed, 20 Aug 2008 01:29:41 +0000 (21:29 -0400)]
cifs.upcall: handle MSKRB5 OID properly

When the kernel sends the upcall a sec=mskrb5 parameter, that means
the the MSKRB5 OID is preferred by the server. This patch fixes the
upcall to use that OID in place of the "normal" krb5 OID when it
gets a sec=mskrb5 parameter.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <smfrench@gmail.com>
(This used to be commit 6287e13b34efeaa8fd94c7c6d99468350ce6172e)

13 years agomount.cifs: don't prompt for password on krb5 mounts
Jeff Layton [Sat, 16 Aug 2008 10:09:29 +0000 (06:09 -0400)]
mount.cifs: don't prompt for password on krb5 mounts

krb5 mounts require that the user already have a valid krb5 ticket.
Since we can't currently use the password entered, don't prompt for it.

Also, switch to using strncmp instead of strcmp here.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(This used to be commit c75791c34abebe23c6f6a5534b0358514ec4eabc)

13 years agoFix broken net rpc join message when DC can't be found. Ensure we pass in a domain...
Jeremy Allison [Thu, 21 Aug 2008 22:27:22 +0000 (15:27 -0700)]
Fix broken net rpc join message when DC can't be found. Ensure we pass in a domain name.
(This used to be commit 33019fe2b5f521c143fc79edb915eca69b9ed98d)

13 years agorpc_server: make it a little more obvious what flags we send to a client.
Günther Deschner [Thu, 21 Aug 2008 22:20:46 +0000 (00:20 +0200)]
rpc_server: make it a little more obvious what flags we send to a client.

(This used to be commit f3791e03ab09cadb1f54e32e67f4dfb3cf42e708)

13 years agoFix Bug #5710 and make machine account password changing work again.
Günther Deschner [Thu, 21 Aug 2008 13:05:35 +0000 (15:05 +0200)]
Fix Bug #5710 and make machine account password changing work again.

When we negotiated NETLOGON_NEG_PASSWORD_SET2 we need to use
NetrServerPasswordSet2 to change the machine password.

Tested with NT4, W2k, W2k3 and W2k8.

(This used to be commit 5820360451e4db0fad0472f814cae667b2ea51fd)

13 years agoFix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegsch...
Jeremy Allison [Thu, 21 Aug 2008 17:25:02 +0000 (10:25 -0700)]
Fix bug 5698 - mixup of TALLOC/malloc. Spotted by Douglas Wegscheid <Douglas_E_Wegscheid@whirlpool.com>.
(This used to be commit 1295bb9787dde69b4be4acee7b66eb782afe9c42)

13 years agore-run make idl.
Günther Deschner [Thu, 21 Aug 2008 13:02:03 +0000 (15:02 +0200)]
re-run make idl.

(This used to be commit f24cef9fa7be45212744d39b7c66804e64147afd)

13 years agoIDL: fix IDL for netr_ServerPasswordSet2().
Günther Deschner [Thu, 21 Aug 2008 13:01:36 +0000 (15:01 +0200)]
IDL: fix IDL for netr_ServerPasswordSet2().

(This used to be commit 7b312a0abc6de5a51555ccfbde7f8f78fc11d043)

13 years agogitignore: add examples/libsmbclient/Makefile.internal - a generated file
Michael Adam [Thu, 21 Aug 2008 08:57:36 +0000 (10:57 +0200)]
gitignore: add examples/libsmbclient/Makefile.internal - a generated file

(This used to be commit 25fed055c0ee1d892b902caae2a1188977316f14)

13 years agobuild: add [clean_]libsmbclient_examples targets to top level Makefile
Michael Adam [Thu, 21 Aug 2008 08:50:49 +0000 (10:50 +0200)]
build: add [clean_]libsmbclient_examples targets to top level Makefile

(This used to be commit b476400f0afcaf4e1a37b9f0b358f01dc7a194be)

13 years agolibsmbclient examples: source/bin to the library search path for smbwrapper build
Michael Adam [Thu, 21 Aug 2008 08:49:57 +0000 (10:49 +0200)]
libsmbclient examples: source/bin to the library search path for smbwrapper build

(This used to be commit fe62098666a16b31b025867f273d407e77152c4c)

13 years agolibsmbclient examples: add Makefile.internal.in for building from a samba source
Michael Adam [Thu, 21 Aug 2008 08:48:44 +0000 (10:48 +0200)]
libsmbclient examples: add Makefile.internal.in for building from a samba source

Without needing to install libsmbclient to /usr/local/samba first.

(This used to be commit f0e47bce2e98131812e96fb88cc3d1fe939e8d6c)

13 years agolibsmbclient examples: fix prototype for readlink
Michael Adam [Thu, 21 Aug 2008 08:41:11 +0000 (10:41 +0200)]
libsmbclient examples: fix prototype for readlink

(This used to be commit 28688cfd57c322937f2c63087380c377bd961018)

13 years agoHere is a re-working of the winbindd
Jeremy Allison [Wed, 20 Aug 2008 23:24:22 +0000 (16:24 -0700)]
Here is a re-working of the winbindd
reconnect code to cope with rebooting a DC. This
replaces the code I asked Volker to revert.
The logic is pretty simple. It adds a new parameter,
"winbind reconnect delay", set to 30 seconds by
default, which determines how long to wait between
connection attempts.
To avoid overwhelming the box with DC-probe
forked children, the code now keeps track of
the DC probe child per winbindd_domain struct
and only starts a new one if the existing one
has died.
I also added a little logic to make sure the
dc probe child always sends a message whatever
the reason for exit so we will always reschedule
another connect attempt.
Also added documentation.
(This used to be commit 8027197635b988b3dcf9d3d00126a024e768fa62)

13 years agogitignore: add examples/libsmbclient/tree
Michael Adam [Wed, 20 Aug 2008 20:31:53 +0000 (22:31 +0200)]
gitignore: add examples/libsmbclient/tree

(This used to be commit e5c4cbbf5a4b3e5db1732043a74cd1f4a5eec136)

13 years agogitignore: add lib/netapi/tests/Makefile
Michael Adam [Wed, 20 Aug 2008 20:31:07 +0000 (22:31 +0200)]
gitignore: add lib/netapi/tests/Makefile

(This used to be commit fdf29c1cdf6b9bd1c6fb7a9f070084e0df5470bb)

13 years agogitignore: add libsmbsharemodes.syms - this is now generated
Michael Adam [Wed, 20 Aug 2008 20:34:26 +0000 (22:34 +0200)]
gitignore: add libsmbsharemodes.syms - this is now generated

(This used to be commit 11458f9a9ac17c68aa0496d2ade4b93d02e7ebcc)

13 years agobuild: auto-generate symbols for libsmbsharemodes.
Michael Adam [Wed, 20 Aug 2008 13:09:27 +0000 (15:09 +0200)]
build: auto-generate symbols for libsmbsharemodes.

(This used to be commit f1d84e76bb6935e80b01d13414980f8de1f71824)

13 years agogitignore: add libsmbclient.syms - this is now generated
Michael Adam [Wed, 20 Aug 2008 20:33:17 +0000 (22:33 +0200)]
gitignore: add libsmbclient.syms - this is now generated

(This used to be commit 02d4b820fccfef1387f47db4bb5ade3dfd0d25bb)

13 years agobuild: autogenerate symbols for libsmbclient.so
Michael Adam [Wed, 20 Aug 2008 13:06:02 +0000 (15:06 +0200)]
build: autogenerate symbols for libsmbclient.so

(This used to be commit d6fb6348a3672e915556dcb36c1a4999d4abae18)

13 years agobuild: fix bug #5590 by not linking in the static libs but the objects.
Michael Adam [Wed, 20 Aug 2008 12:56:18 +0000 (14:56 +0200)]
build: fix bug #5590 by not linking in the static libs but the objects.

(This used to be commit 6ad2090391a92ebe822b2d7b80e180c251dc8e7a)

13 years agobuild: fall down to the same place when using an internal lib statically.
Michael Adam [Wed, 20 Aug 2008 12:55:24 +0000 (14:55 +0200)]
build: fall down to the same place when using an internal lib statically.

(This used to be commit 702c0bc04668117e3521d687b9b5a87fd7e0f1b1)

13 years agobuild: remove duplicated and hardcoded definition of LIBSMBSHAREMODES
Michael Adam [Wed, 20 Aug 2008 12:47:26 +0000 (14:47 +0200)]
build: remove duplicated and hardcoded definition of LIBSMBSHAREMODES

(This used to be commit c3c3dadcab81f0a1ae8834e85e7e80a3da6601fb)

13 years agobuild: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.
Michael Adam [Wed, 20 Aug 2008 11:22:13 +0000 (13:22 +0200)]
build: rename LIBNETAPI_OBJ1 to LIBNETAPI_OBJ0 for consistency.

(This used to be commit ead9b9d7167d999d73cf4111f3b321236aac2a15)

13 years agofix build warning.
Günther Deschner [Wed, 20 Aug 2008 16:40:58 +0000 (18:40 +0200)]
fix build warning.

(This used to be commit a75055be5ff7ebe3476cfac86c6597a56a843c23)

13 years agolibads: remove unused vars.
Günther Deschner [Wed, 20 Aug 2008 19:17:35 +0000 (21:17 +0200)]
libads: remove unused vars.

(This used to be commit ea9fc3bea31b11e715d9524defc18b75e5943842)

13 years agofix another build warning.
Günther Deschner [Wed, 20 Aug 2008 18:24:45 +0000 (20:24 +0200)]
fix another build warning.

(This used to be commit 43693ce6c678b961fa516bbf502af92f87cd5346)

13 years agonss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT
Gerald (Jerry) Carter [Wed, 20 Aug 2008 18:00:40 +0000 (13:00 -0500)]
nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT

According to the GNU libc nss guide, we should always set
errno to ENOENT when returning NSS_UNAVAIL.


At least the MQ Series message queing service that runs
on WebSphere will fail if you return any other errno in this case.
(This used to be commit ee26664602445fa7798e2061f6bcbef0756d6528)

13 years agosmbd: fix the handling of create_options to pass RAW-OPEN
Stefan Metzmacher [Tue, 19 Aug 2008 14:34:50 +0000 (16:34 +0200)]
smbd: fix the handling of create_options to pass RAW-OPEN

Some of the bits generate INVALID_PARAMETER and some bits
are ignored when they come from a client, that's why we need
to use bits from the ignored range for our internal usage.

(This used to be commit 7b4c8a4e39f310eb450918fa841b0ea1b4af19f7)

13 years agoUpdated Doxyfile conf to doxygen version 1.5.3
Steven Danneman [Tue, 19 Aug 2008 18:05:07 +0000 (11:05 -0700)]
Updated Doxyfile conf to doxygen version 1.5.3

* Removed deprecated configuration parameters
* Silenced all warnings due to lack of doxygen comments
* Reordered config parameters to match doxygen's canonical ordering
(This used to be commit d3295d13aeb396377cb7fd46dcdb1f504f18efef)

13 years agoFix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
Jeremy Allison [Wed, 20 Aug 2008 00:30:30 +0000 (17:30 -0700)]
Fix bug 5697 nmbd spins in reload_interfaces when only loopback has an IPv4 address
reported by Ted Percival <ted@midg3t.net>.
(This used to be commit ab06efccf31fbc899536d2681a2076e6dfd65b9e)

13 years agowinbindd: consistently use false/true.
Günther Deschner [Tue, 19 Aug 2008 16:03:13 +0000 (18:03 +0200)]
winbindd: consistently use false/true.

(This used to be commit e8619121d16d086f1ab186051d0ecdc83c02e5b5)

13 years agowinbindd: use set_auth_errors (avoid code duplication).
Günther Deschner [Tue, 19 Aug 2008 16:31:35 +0000 (18:31 +0200)]
winbindd: use set_auth_errors (avoid code duplication).

(This used to be commit ae35a5110ea03d8ff27f320cdc685e5623715a2a)

13 years agowinbindd: fill_in_password_policy (to avoid redundant code).
Günther Deschner [Tue, 19 Aug 2008 16:31:10 +0000 (18:31 +0200)]
winbindd: fill_in_password_policy (to avoid redundant code).

(This used to be commit dbfa7ba14c9f1a4d7a1e7205dd0b3ea2fc2e6131)

13 years agopam_winbind: some doxygen fixes.
Günther Deschner [Tue, 19 Aug 2008 14:19:54 +0000 (16:19 +0200)]
pam_winbind: some doxygen fixes.

(This used to be commit f2a2ed315e393353110aa7760b4eca4f1f49ca21)

13 years agowbinfo: use wbinfo_prompt_pass() everywhere.
Günther Deschner [Tue, 19 Aug 2008 13:09:12 +0000 (15:09 +0200)]
wbinfo: use wbinfo_prompt_pass() everywhere.

(This used to be commit 687ef28874eb311b3e3919c3a38a22e5186d4c1b)

13 years agowbinfo: add wbinfo_prompt_pass.
Günther Deschner [Tue, 19 Aug 2008 13:32:37 +0000 (15:32 +0200)]
wbinfo: add wbinfo_prompt_pass.

(This used to be commit 7cf6ed68236e7dd64657cb1087a5a687d6f59ad1)

13 years agopam_winbind: use pam error string function to display result.
Günther Deschner [Thu, 14 Aug 2008 18:56:47 +0000 (20:56 +0200)]
pam_winbind: use pam error string function to display result.

(This used to be commit 8504a92ac55d6936df051be66207a59a76bf32a3)

13 years agopam_winbind: add _pam_error_code_str().
Günther Deschner [Thu, 14 Aug 2008 15:40:26 +0000 (17:40 +0200)]
pam_winbind: add _pam_error_code_str().

(This used to be commit 693f90fd2394309ce40d3ca5fc007543058b342a)

13 years agopam_winbind: use integer constants.
Günther Deschner [Thu, 14 Aug 2008 11:07:51 +0000 (13:07 +0200)]
pam_winbind: use integer constants.

(This used to be commit 8d19b2ceb131ca2a0fd983cdb4fd17acdad9c26e)

13 years agowinbindd: kill some trailing/leading whitespace.
Günther Deschner [Mon, 18 Aug 2008 23:18:24 +0000 (01:18 +0200)]
winbindd: kill some trailing/leading whitespace.

(This used to be commit b5bb7844952a87b123551b478b60bfe232afc308)

13 years agobuild: fix linking cifs.upcall when nscd_flush_cache() is found.
Michael Adam [Tue, 19 Aug 2008 11:29:24 +0000 (13:29 +0200)]
build: fix linking cifs.upcall when nscd_flush_cache() is found.

(This used to be commit 661b7fdffda40a9ca7cb36627dbaf91cb4357cd0)

13 years agoMake the change to smbcontrol for "all" to mean broadcast,
Jeremy Allison [Mon, 18 Aug 2008 23:18:34 +0000 (16:18 -0700)]
Make the change to smbcontrol for "all" to mean broadcast,
and "smbd" to mean the main smb daemon. Update docs to match.
(This used to be commit e415420b086a236be6bcc1e7584bec276a74e457)

13 years agoFix length error in wrapping spnego blob
Igor Mammedov [Mon, 18 Aug 2008 16:55:11 +0000 (09:55 -0700)]
Fix length error in wrapping spnego blob
(This used to be commit 16ee95494ba495c5f5ff8779206f380db1067b2d)

13 years agoFix bug 5696. The problem was when smbd
Jeremy Allison [Sun, 17 Aug 2008 02:23:38 +0000 (19:23 -0700)]
Fix bug 5696. The problem was when smbd
was asking for a winbindd name to SID lookup of
"Unix Group\name" where "name" was also a valid username,
the winbindd passdb lookup of that name was losing the
domain string info before calling lookup name (ie. lookup_name()
was being called with just the string "name", not the
full string "Unix Group\name").

The passdb backend of winbindd has to cope with
not only names from it's own global SAM domain,
but it does lookups for BUILTIN and "Unix User"
and "Unix Group" also, so making it guess by
losing the domain string is "A Bad Idea" (tm) :-).

Note that as winbind globally calls winbind_off()
at startup, it's safe for winbind to call sys_getgrnam()
to do the "Unix Group" lookup from inside lookup_name().

(This used to be commit 5293af6c3cbfdde340e6add47b914b6ee6fd7b6f)

13 years agoAttempt to fix Coverity ID 596
Volker Lendecke [Sat, 16 Aug 2008 09:12:35 +0000 (11:12 +0200)]
Attempt to fix Coverity ID 596

Jeremy, please check & push if it's ok.
(This used to be commit f06070c188d6d2efed3205bbc9c3c290718397b1)

13 years agoAttempt to fix Coverity ID 595
Volker Lendecke [Sat, 16 Aug 2008 09:17:09 +0000 (11:17 +0200)]
Attempt to fix Coverity ID 595

is_ipaddress already dereferences "name", so the NULL check is pointless after
calling it.
(This used to be commit 31ca7b2dbbbfbb3a55670b58c08ebda68888af7e)

13 years agoI think the problem with these functions is that lookup_usergroups
Herb Lewis [Fri, 15 Aug 2008 22:28:23 +0000 (15:28 -0700)]
I think the problem with these functions is that lookup_usergroups
should never include the user SID.
The comment for the function in winbindd/winbindd_ads.c says
/* Lookup groups a user is a member of. */
The following patch makes the wbinfo calls return the correct data
before and after a login.
wbinfo --user-domgroups and --user-sids
(This used to be commit 7849938906a9c859805cbaeca66fae9d3c515aad)

13 years agoconfigure: use libdir=${prefix}/lib and modules=${libdir}/samba as default with-fhs.
Michael Adam [Fri, 15 Aug 2008 13:55:17 +0000 (15:55 +0200)]
configure: use libdir=${prefix}/lib and modules=${libdir}/samba as default with-fhs.

This is what one actually wants:
Shared/static libs in /usr/lib, shared modules and so on in /usr/lib/samba.

(This used to be commit 03de8c1955a85f2e3e9f947309e09023138a1591)

13 years agoconfigure: use ${libdir} instead of \${LIBDIR}.
Michael Adam [Fri, 15 Aug 2008 12:38:41 +0000 (14:38 +0200)]
configure: use ${libdir} instead of \${LIBDIR}.

Now after removing --with-libdir, the value of ${libdir} won't change
anymore at that stage, so there is no need to have the variable expansion
deferred to "make".

(This used to be commit 256977cf05cb4c4073ece1389a7e4939b18f5f13)

13 years agoconfigure: remove the --with-libdir parameter.
Michael Adam [Fri, 15 Aug 2008 12:35:46 +0000 (14:35 +0200)]
configure: remove the --with-libdir parameter.

This is redundant: use the autoconf-provided --libdir instead.
This will also make the new distinction between libdir and modulesdir
more visible.

(This used to be commit c1d53b7c767275b39dc8ecfcd5b6129ee2cabb6d)

13 years agopopt: add support for setting MODULESDIR via popt_common_dynconfig.
Michael Adam [Thu, 14 Aug 2008 22:45:57 +0000 (00:45 +0200)]
popt: add support for setting MODULESDIR via popt_common_dynconfig.

(This used to be commit 81030e49ce344260d279a3112b13a21ce3520748)

13 years agosvcctl: use MODULESDIR instead of LIBDIR for the svcctl script directory.
Michael Adam [Thu, 14 Aug 2008 22:50:56 +0000 (00:50 +0200)]
svcctl: use MODULESDIR instead of LIBDIR for the svcctl script directory.

(This used to be commit bb19634138cfd1f527c44e16a44aa21ebee50c1c)

13 years agolibgpo: use MODULESDIR instead of LIBDIR for the group policy extensions.
Michael Adam [Thu, 14 Aug 2008 22:49:19 +0000 (00:49 +0200)]
libgpo: use MODULESDIR instead of LIBDIR for the group policy extensions.

(This used to be commit 3346dd40832e8d61edfe4c56dce6fe85031f20f1)

13 years agoUse module_path() instead of lib_path() for loading shared modules.
Michael Adam [Thu, 14 Aug 2008 22:47:30 +0000 (00:47 +0200)]
Use module_path() instead of lib_path() for loading shared modules.

(This used to be commit 22fb3ef1bb4abb33b49d275f9a5d85a1924c22ea)

13 years agoAdd modules_path() to construct paths to files in MODULESDIR.
Michael Adam [Thu, 14 Aug 2008 22:44:14 +0000 (00:44 +0200)]
Add modules_path() to construct paths to files in MODULESDIR.

(This used to be commit 5ef9da6f4f04b07804b389902862fae0fbbfed13)

13 years agobuildoptions: output MODULESDIR.
Michael Adam [Thu, 14 Aug 2008 22:46:46 +0000 (00:46 +0200)]
buildoptions: output MODULESDIR.

(This used to be commit bcb868e4340a856c4009450479628088a8a1628c)

13 years agodynconfig: add support for MODULESDIR.
Michael Adam [Thu, 14 Aug 2008 22:43:31 +0000 (00:43 +0200)]
dynconfig: add support for MODULESDIR.

(This used to be commit 34309f097f5c7321930bf6c2ea2447de1008130c)

13 years agoconfigure: Add --with-modulesdir to accompany --with-libdir.
Michael Adam [Thu, 14 Aug 2008 22:36:49 +0000 (00:36 +0200)]
configure: Add --with-modulesdir to accompany --with-libdir.

This starts the seplitting of libdir in to libdir and modulesdir.
Our shared libs should go into libdir, the internal shared modules,
codepages, and other stuff that was originally in libdir, should
go into modulesdir.

The idea behind this is, that in a typical installation,
the shared (and static) libraries (as libtalloc, libsmbclient,
libwbclient and others) should be put into /usr/lib, while
the e.g. the vfs modules should reside in /usr/lib/samba.

This is meant to ease the work of packagers and reduce
the needs for manual interaction and workarounds.

(This used to be commit b17d1ff646e22c3e979224d119b283fc3af780a8)

13 years agodynconfig: remove commented-out old stuff from dynconfig.c and dynconfig.h
Michael Adam [Thu, 14 Aug 2008 22:58:47 +0000 (00:58 +0200)]
dynconfig: remove commented-out old stuff from dynconfig.c and dynconfig.h

(This used to be commit 85a781fa0248fcd0cefcc4de25b3dea3e37d5844)

13 years agodynconfig: remove unused prototypes.
Michael Adam [Thu, 14 Aug 2008 21:44:06 +0000 (23:44 +0200)]
dynconfig: remove unused prototypes.

set_dyn_STATEDIR, is_default_dyn_STATEDIR,
set_dyn_CACHEDIR, is_default_dyn_CACHEDIR
are neither used nor implemented.

(This used to be commit f30b70b2c3a49bc962848039953a565a040b563d)

13 years agoproto.h: remove prototypes from dynconfig.c
Michael Adam [Thu, 14 Aug 2008 21:14:42 +0000 (23:14 +0200)]
proto.h: remove prototypes from dynconfig.c

These are also in dynconfig.h and were originally added
by "make proto" by accident.

(This used to be commit 4fb69fe1eeebc466944f3daacfacec60ad043b0c)

13 years agoMakefile: print codepagedir in "make showlayout".
Michael Adam [Thu, 14 Aug 2008 21:18:28 +0000 (23:18 +0200)]
Makefile: print codepagedir in "make showlayout".

(This used to be commit a823733b91958adf938214113e6875315c6ae5b2)

13 years agobuild: fix a typo in the installlibtalloc rule.
Michael Adam [Fri, 15 Aug 2008 21:17:48 +0000 (23:17 +0200)]
build: fix a typo in the installlibtalloc rule.

The symlink liballoc.so -> libtalloc.so.1 would have been
created unconditionally, independent of the existence of

(This used to be commit 04974818bda75c4315ad09b623e5df55c87dbc87)

13 years agoFix show-stopper for 3.2. Smbd depends on group SID
Jeremy Allison [Fri, 15 Aug 2008 04:52:11 +0000 (21:52 -0700)]
Fix show-stopper for 3.2. Smbd depends on group SID
position zero being the primary group sid. Authenicating
via winbindd call returned a non-sorted sid list. This
fixes is for both a winbindd call and a pac list from
an info3 struct. Without this we mess up the
primary group associated with created files. Found by
(This used to be commit cb925dec85cfc4cfc194c3ff76dbeba2bd2178d7)

13 years agoMake it clear that this is a temporary context byusing a talloc stackframe instead.
Jeremy Allison [Thu, 14 Aug 2008 21:36:02 +0000 (14:36 -0700)]
Make it clear that this is a temporary context byusing a talloc stackframe instead.
(This used to be commit 7f7dd5e8883e23d7fe3f9cb804905c5b23a5a41c)

13 years agoFix bug #5692 - Core dump in full_audit.so.
Jeremy Allison [Thu, 14 Aug 2008 17:58:50 +0000 (10:58 -0700)]
Fix bug #5692 - Core dump in full_audit.so.
There were some function mismatches in the various GET_NT_ACL modules (some places the fsp parameter has not been removed).
(This used to be commit 221cc5e21eb27cdad51f34ec6832467a7bd89213)

13 years agoRevert "Add a gpfs_prefetch module"
Michael Adam [Thu, 14 Aug 2008 15:46:28 +0000 (17:46 +0200)]
Revert "Add a gpfs_prefetch module"

This reverts commit fc9b30bed2d774dca6660b497cb50f982b23b885.

Sorry, this got pushed by accident:

"This can not go upstream yet because it uses the non-GPL libgpfs."

(This used to be commit 26a3cf0be918fe577a979f3e358d58359e42b2f1)

13 years agosmbspool: Fix printing on port 139.
Karolin Seeger [Wed, 13 Aug 2008 19:27:55 +0000 (21:27 +0200)]
smbspool: Fix printing on port 139.

This one was introduced with 8eff35bc.
Thanks to Noèl Köthe for tracking that down!

(This used to be commit 250f5a40d6e80305220d7cdc6a8f8459d8d0de74)