kai/samba.git
7 years agos3:smbd:durable: remove a TODO comment about write time updates
Michael Adam [Tue, 23 Oct 2012 15:18:47 +0000 (17:18 +0200)]
s3:smbd:durable: remove a TODO comment about write time updates

This has been done.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Oct 29 20:12:18 CET 2012 on sn-devel-104

7 years agoBUG 9326: Fix net ads join message for the dns domain.
Andreas Schneider [Tue, 23 Oct 2012 15:12:59 +0000 (17:12 +0200)]
BUG 9326: Fix net ads join message for the dns domain.

We don't get a realm back from the server which is useable as a realm on
Unix. On Unix they are case sensitive and on Windows they aren't. This
confuses uses and if we write realm they try to use it as it came back
in lowercase.

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Oct 29 18:26:19 CET 2012 on sn-devel-104

7 years agoFix bug #9329 - Directory listing with SeBackup can crash smbd.
Jeremy Allison [Fri, 26 Oct 2012 00:07:29 +0000 (17:07 -0700)]
Fix bug #9329 - Directory listing with SeBackup can crash smbd.

When we do a become_root()/unbecome_root() pair to temporarily
raise privilege, this NULLs out the NT token. If we're within
a become_root()/unbecome_root() pair then return the previous
token on the stack as our NT token. This is what we should be
using to check against NT ACLs in the file server. This copes
with security context changing when removing a file on close
under the context of another user (when 2 users have a file
open, one sets delete on close and then the other user has
to actually do the delete).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Oct 29 16:26:20 CET 2012 on sn-devel-104

7 years agopackaging: Move smbprint to a comman location.
Andreas Schneider [Wed, 17 Oct 2012 16:25:41 +0000 (18:25 +0200)]
packaging: Move smbprint to a comman location.

This also removes all the duplicate smbprint scripts.

This fixes bug #9301.

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 29 14:08:37 CET 2012 on sn-devel-104

7 years agopidl: Remove depends_on=PIDL_MISC as it sets -I/ into CFLAGS
Andrew Bartlett [Sun, 28 Oct 2012 08:57:58 +0000 (19:57 +1100)]
pidl: Remove depends_on=PIDL_MISC as it sets -I/ into CFLAGS

This in turn causes an include of <net/if.h> to hang on some systems, as
/net/ means to run the automounter!

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Oct 29 01:23:39 CET 2012 on sn-devel-104

7 years agobuild: Remove support for IDL-generated files in git tree
Andrew Bartlett [Sun, 28 Oct 2012 08:38:10 +0000 (19:38 +1100)]
build: Remove support for IDL-generated files in git tree

This was added in a9ea3d6fa510286b83c4bda42c9a857da3625451 but is no
longer required, as we do not store IDL-generated files in GIT.

Andrew Bartlett

7 years agolib/replace: Return size of xattr if size argument is 0
Andrew Bartlett [Sat, 27 Oct 2012 08:15:58 +0000 (19:15 +1100)]
lib/replace: Return size of xattr if size argument is 0

This makes rep_{f,}getxattr a more complete replacement for the linux function.

Andrew Bartlett

7 years agosource3.selftest: Move last variables to selftesthelpers.
Jelmer Vernooij [Sat, 27 Oct 2012 13:31:06 +0000 (05:31 -0800)]
source3.selftest: Move last variables to selftesthelpers.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat Oct 27 19:08:42 CEST 2012 on sn-devel-104

7 years agosource3.selftest: Move more variables to be in common.
Jelmer Vernooij [Sat, 27 Oct 2012 13:23:57 +0000 (05:23 -0800)]
source3.selftest: Move more variables to be in common.

7 years agoselftesthelpers: Fix detection of tap2subunit.
Jelmer Vernooij [Sat, 27 Oct 2012 01:31:40 +0000 (17:31 -0800)]
selftesthelpers: Fix detection of tap2subunit.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat Oct 27 16:57:49 CEST 2012 on sn-devel-104

7 years agoTestCaseInTempDir: Use addCleanup rather than tearDown.
Jelmer Vernooij [Fri, 26 Oct 2012 23:58:06 +0000 (15:58 -0800)]
TestCaseInTempDir: Use addCleanup rather than tearDown.

7 years agoselftest: Add --random-order option.
Jelmer Vernooij [Fri, 26 Oct 2012 23:53:57 +0000 (15:53 -0800)]
selftest: Add --random-order option.

7 years agosource4.selftest.tests: Add FIXME about database verification.
Jelmer Vernooij [Fri, 26 Oct 2012 22:40:09 +0000 (14:40 -0800)]
source4.selftest.tests: Add FIXME about database verification.

7 years agoselftesthelpers: Simplify detection of tap2subunit.
Jelmer Vernooij [Fri, 26 Oct 2012 22:14:42 +0000 (14:14 -0800)]
selftesthelpers: Simplify detection of tap2subunit.

7 years agosource3.selftests.tests: Use common plansmbtorture4testsuite() function.
Jelmer Vernooij [Fri, 26 Oct 2012 22:06:47 +0000 (14:06 -0800)]
source3.selftests.tests: Use common plansmbtorture4testsuite() function.

7 years agosource3.selftest.tests: Add suffix for smbclient3/ntlm_auth3.
Jelmer Vernooij [Fri, 26 Oct 2012 22:00:07 +0000 (14:00 -0800)]
source3.selftest.tests: Add suffix for smbclient3/ntlm_auth3.

7 years agosource3.selftest.tests: Remove tabs.
Jelmer Vernooij [Fri, 26 Oct 2012 21:56:30 +0000 (13:56 -0800)]
source3.selftest.tests: Remove tabs.

7 years agosource4.selftest.tests: Add suffix for smbclient4/nmblookup4.
Jelmer Vernooij [Fri, 26 Oct 2012 21:52:55 +0000 (13:52 -0800)]
source4.selftest.tests: Add suffix for smbclient4/nmblookup4.

7 years agoselftesthelpers: Add function for printing smbtorture4 version.
Jelmer Vernooij [Fri, 26 Oct 2012 21:51:54 +0000 (13:51 -0800)]
selftesthelpers: Add function for printing smbtorture4 version.

7 years agoselftest: Move determining of smbtorture4 options to selftesthelpers.
Jelmer Vernooij [Fri, 26 Oct 2012 21:38:32 +0000 (13:38 -0800)]
selftest: Move determining of smbtorture4 options to selftesthelpers.

7 years agoselftest/selftesthelpers: Share environment handling for extra smbtorture options.
Jelmer Vernooij [Fri, 26 Oct 2012 21:12:54 +0000 (13:12 -0800)]
selftest/selftesthelpers: Share environment handling for extra smbtorture options.

7 years agoselftest/selftesthelpers.py: Share configuration variable, strip whitespace.
Jelmer Vernooij [Fri, 26 Oct 2012 21:09:45 +0000 (13:09 -0800)]
selftest/selftesthelpers.py: Share configuration variable, strip whitespace.

7 years agoselftesthelpers: Share code for listing smbtorture4 tests.
Jelmer Vernooij [Fri, 26 Oct 2012 21:03:32 +0000 (13:03 -0800)]
selftesthelpers: Share code for listing smbtorture4 tests.

7 years agosource4.selftest.tests: Rename plansmbtorturesuite() to plansmbtorture4suite().
Jelmer Vernooij [Fri, 26 Oct 2012 19:51:19 +0000 (11:51 -0800)]
source4.selftest.tests: Rename plansmbtorturesuite() to plansmbtorture4suite().

7 years agosource4.selftest.tests: Consistent naming of smbtorture binary.
Jelmer Vernooij [Fri, 26 Oct 2012 19:50:41 +0000 (11:50 -0800)]
source4.selftest.tests: Consistent naming of smbtorture binary.

7 years agolibcli/smb: fix unitialized padding in smb2_create_blob_push_one() (bug #9209)
Stefan Metzmacher [Sat, 27 Oct 2012 06:11:14 +0000 (08:11 +0200)]
libcli/smb: fix unitialized padding in smb2_create_blob_push_one() (bug #9209)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Oct 27 10:05:22 CEST 2012 on sn-devel-104

7 years agosefltest: use TestCaseInTempDir and setUp/tearDown for posixacl.py temp file
Andrew Bartlett [Fri, 26 Oct 2012 23:59:43 +0000 (10:59 +1100)]
sefltest: use TestCaseInTempDir and setUp/tearDown for posixacl.py temp file

This manages the temp file more reliably, and reduces the repeated
code in each test case.

Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Oct 27 04:37:58 CEST 2012 on sn-devel-104

7 years agoprovision: Fix comments in checksysvolacl
Andrew Bartlett [Fri, 26 Oct 2012 22:20:52 +0000 (09:20 +1100)]
provision: Fix comments in checksysvolacl

7 years agopam_winbind: fix segfault in pam_sm_authenticate()
David Disseldorp [Wed, 2 Nov 2011 17:39:03 +0000 (18:39 +0100)]
pam_winbind: fix segfault in pam_sm_authenticate()

Ensure the potentially null winbind context is not dereferenced on
cleanup.

https://bugzilla.samba.org/show_bug.cgi?id=8564

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 22:40:57 CEST 2012 on sn-devel-104

7 years agontlm_auth: Increase debug level if we use config domain name.
Andreas Schneider [Fri, 26 Oct 2012 16:07:59 +0000 (18:07 +0200)]
ntlm_auth: Increase debug level if we use config domain name.

If an application like evolution-ews is using ntlm_auth it will alwys
get this message cause the is no winbind running and it is not needed.

Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 20:13:45 CEST 2012 on sn-devel-104

7 years agovfstest: set umask(0) in vfstest
Andrew Bartlett [Fri, 26 Oct 2012 03:23:39 +0000 (14:23 +1100)]
vfstest: set umask(0) in vfstest

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Oct 26 10:07:03 CEST 2012 on sn-devel-104

7 years agopysmbd: Set umask to 0 during smbd operations
Andrew Bartlett [Fri, 26 Oct 2012 03:22:07 +0000 (14:22 +1100)]
pysmbd: Set umask to 0 during smbd operations

7 years agopysmbd: Remember to close files after setting the NT ACL
Andrew Bartlett [Thu, 25 Oct 2012 23:07:02 +0000 (10:07 +1100)]
pysmbd: Remember to close files after setting the NT ACL

7 years agopysmbd: Add hook for unlink() so python scripts can remove xattr.tdb entries
Andrew Bartlett [Fri, 26 Oct 2012 06:25:53 +0000 (17:25 +1100)]
pysmbd: Add hook for unlink() so python scripts can remove xattr.tdb entries

If we do not provide a way to remove files from xattr.tdb, we can re-use the inode.

Andrew Bartlett

7 years agos3:smbd:durable: factor stat checks out into vfs_default_durable_reconnect_check_stat()
Michael Adam [Tue, 23 Oct 2012 11:00:02 +0000 (13:00 +0200)]
s3:smbd:durable: factor stat checks out into vfs_default_durable_reconnect_check_stat()

This makes vfs_default_durable_reconnect() simpler to read
and it reduces code duplication in the failure case handling.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 25 23:03:13 CEST 2012 on sn-devel-104

7 years agopython-ntacls: Cope with ACL revision 4
Andrew Bartlett [Wed, 24 Oct 2012 07:24:12 +0000 (18:24 +1100)]
python-ntacls: Cope with ACL revision 4

This is the new revision with the hash of the posix or system ACL.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 25 15:04:39 CEST 2012 on sn-devel-104

7 years agodbwrap: use talloc_stackframe() in db_tdb_log_key()
Andrew Bartlett [Wed, 24 Oct 2012 07:23:04 +0000 (18:23 +1100)]
dbwrap: use talloc_stackframe() in db_tdb_log_key()

We can not be sure that there is already a talloc_stackframe() in place
so we must create one.

Andrew Bartlett

7 years agoselftest: Always unlink the tempf in posixacl test
Andrew Bartlett [Thu, 25 Oct 2012 09:18:28 +0000 (20:18 +1100)]
selftest: Always unlink the tempf in posixacl test

7 years agoselftest: Cover the important non-Samba invalidation of the NT ACL
Andrew Bartlett [Thu, 25 Oct 2012 09:17:55 +0000 (20:17 +1100)]
selftest: Cover the important non-Samba invalidation of the NT ACL

This covers the case where we have a valid hash of the posix ACL (or the NT ACL from the
POSIX ACL) and we notice it no longer matches.

Andrew Bartlett

7 years agoselftest: Cover one more NT ACL invalidation case and improve comments
Andrew Bartlett [Thu, 25 Oct 2012 08:58:15 +0000 (19:58 +1100)]
selftest: Cover one more NT ACL invalidation case and improve comments

This tries to show the difference between the cases where we trap
the POSIX ACL change and where we actually detect an OS-level change.

Andrew Bartlett

7 years agoselftest: Add many more tests for our posix ACL handling
Andrew Bartlett [Thu, 25 Oct 2012 05:27:19 +0000 (16:27 +1100)]
selftest: Add many more tests for our posix ACL handling

This tests the mapping of posix ACLs to NT ACLs, the invalidation of
NT ACLs stored as an xattr and ensures this security-critical code
continues to work in the long term.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 25 10:05:16 CEST 2012 on sn-devel-104

7 years agopysmbd: Fix pysmbd octal mode handling
Andrew Bartlett [Thu, 25 Oct 2012 05:25:22 +0000 (16:25 +1100)]
pysmbd: Fix pysmbd octal mode handling

It is clearly too long since Computer Science 101... ;-)

Andrew Bartlett

7 years agodsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING when there is no SID
Andrew Bartlett [Wed, 24 Oct 2012 05:41:52 +0000 (16:41 +1100)]
dsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING when there is no SID

If there is no SID for an object being mapped, then there is no NT4 name.

We need to return DRSUAPI_DS_NAME_STATUS_NO_MAPPING rather than
error out with anything other than WERR_OK as the return value.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 25 04:43:25 CEST 2012 on sn-devel-104

7 years agos4:dns_server: fix formatting difference compared to v4-0-test
Stefan Metzmacher [Tue, 23 Oct 2012 13:00:27 +0000 (15:00 +0200)]
s4:dns_server: fix formatting difference compared to v4-0-test

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Oct 24 10:12:51 CEST 2012 on sn-devel-104

7 years agodsdb-cracknames: Always use talloc_zero()
Andrew Bartlett [Wed, 24 Oct 2012 00:56:02 +0000 (11:56 +1100)]
dsdb-cracknames: Always use talloc_zero()

Otherwise, we will return un-initialised values to the caller, which will
attempt to push them onto the wire.

Found by Greg Dickie <greg@justaguy.ca>.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct 24 05:12:04 CEST 2012 on sn-devel-104

7 years agobuild(waf): Fix the --with-cluster build
Michael Adam [Tue, 23 Oct 2012 13:53:17 +0000 (15:53 +0200)]
build(waf): Fix the --with-cluster build

The problem with the cluster/ctdb configure checks in Samba
currently is, that the headers need to include <tdb.h>.
If there are no system tdb headers, configure fails to find
tdb headers at this stage. Since the include is only required
for some defines (TDB_DATA), the workaround is to temporarily
add the included tdb copy's include path to the include search
path in the configure test. The ctdb we run against will most
likely have been compiled against a different version of TDB
anyways...

To properly fix this, we might need to change ctdb to rely
on an external tdb library. Or to incorporate ctdb into samba
as a component that uses the same shipped tdb version.

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Oct 23 18:29:26 CEST 2012 on sn-devel-104

7 years agolib/tsocket: fix loop in tdgram_bsd_recvfrom() (bug #9184)
Stefan Metzmacher [Tue, 2 Oct 2012 10:20:26 +0000 (12:20 +0200)]
lib/tsocket: fix loop in tdgram_bsd_recvfrom() (bug #9184)

If the socket is not readable yet, we need to retry
if tsocket_bsd_pending() returns 0.

See also
https://lists.samba.org/archive/samba-technical/2012-October/087164.html

metze

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 23 14:44:21 CEST 2012 on sn-devel-104

7 years agobuild: Add #define FREEBSD on FreeBSD
Andrew Bartlett [Tue, 23 Oct 2012 06:53:58 +0000 (17:53 +1100)]
build: Add #define FREEBSD on FreeBSD

This makes waf match autoconf

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 23 11:11:44 CEST 2012 on sn-devel-104

7 years agolib/replace: Fix configure on FreeBSD: define_ret is not correct here
Andrew Bartlett [Tue, 23 Oct 2012 06:31:03 +0000 (17:31 +1100)]
lib/replace: Fix configure on FreeBSD: define_ret is not correct here

define_ret is for when the output of the compiled and run program
should be put into the configure define.  This is not the case
here.

Andrew Bartlett

7 years agolib/replace: Fix detection of prctl
Andrew Bartlett [Tue, 23 Oct 2012 06:14:55 +0000 (17:14 +1100)]
lib/replace: Fix detection of prctl

7 years agolib/replace: Fix detection of rpcsrv/yp_prot.h on FreeBSD
Andrew Bartlett [Tue, 23 Oct 2012 06:14:43 +0000 (17:14 +1100)]
lib/replace: Fix detection of rpcsrv/yp_prot.h on FreeBSD

7 years agovfs: Fix compilation of ACL support on solaris
Andrew Bartlett [Tue, 23 Oct 2012 05:13:28 +0000 (16:13 +1100)]
vfs: Fix compilation of ACL support on solaris

7 years agowaf: Create a libnss_wins.so symlink.
Andreas Schneider [Wed, 17 Oct 2012 16:17:27 +0000 (18:17 +0200)]
waf: Create a libnss_wins.so symlink.

The last 3 patches fixe bug #9299 - nsswitch modules under Linux need a symbolic
to their so version library.

https://bugzilla.samba.org/show_bug.cgi?id=9299

Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Oct 22 10:48:16 CEST 2012 on sn-devel-104

7 years agowaf: Create a libnss_winbind.so symlink.
Andreas Schneider [Wed, 17 Oct 2012 16:16:15 +0000 (18:16 +0200)]
waf: Create a libnss_winbind.so symlink.

This fixes bug #9299.

7 years agowafsamba: If we define a realname and a soname create a symlink.
Andreas Schneider [Wed, 17 Oct 2012 16:03:55 +0000 (18:03 +0200)]
wafsamba: If we define a realname and a soname create a symlink.

This is needed that libnss_winbind.so.2 and libnss_wins.so.2 will get a
corresponding symlinks.

7 years agopyglue: Make all_interfaces argumen to interface_ips() optional.
Jelmer Vernooij [Thu, 27 Sep 2012 22:19:03 +0000 (15:19 -0700)]
pyglue: Make all_interfaces argumen to interface_ips() optional.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sun Oct 21 21:26:01 CEST 2012 on sn-devel-104

7 years agopyglue: Mention parameters in interface_ips() docstring.
Jelmer Vernooij [Thu, 27 Sep 2012 22:13:37 +0000 (15:13 -0700)]
pyglue: Mention parameters in interface_ips() docstring.

7 years agos3:rpc_server: avoid a level 0 DEBUG if tstream_npa_connect_recv fails (bug #9309)
Stefan Metzmacher [Sat, 20 Oct 2012 09:08:19 +0000 (11:08 +0200)]
s3:rpc_server: avoid a level 0 DEBUG if tstream_npa_connect_recv fails (bug #9309)

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Oct 20 12:56:23 CEST 2012 on sn-devel-104

7 years agos3: Fix some blank line endings
Volker Lendecke [Fri, 19 Oct 2012 19:48:20 +0000 (21:48 +0200)]
s3: Fix some blank line endings

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Oct 20 09:06:12 CEST 2012 on sn-devel-104

7 years agos3: Use talloc_stackframe in token_contains_name_in_list
Volker Lendecke [Sat, 20 Oct 2012 05:20:39 +0000 (07:20 +0200)]
s3: Use talloc_stackframe in token_contains_name_in_list

7 years agos3: Remove a call to procid_self()
Volker Lendecke [Fri, 19 Oct 2012 16:10:22 +0000 (18:10 +0200)]
s3: Remove a call to procid_self()

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Oct 19 23:15:04 CEST 2012 on sn-devel-104

7 years agos3: Add "msg_ctx" param to winbindd_register_handlers()
Volker Lendecke [Fri, 19 Oct 2012 16:09:21 +0000 (18:09 +0200)]
s3: Add "msg_ctx" param to winbindd_register_handlers()

7 years agos3: Make winbindd_register_handlers static
Volker Lendecke [Fri, 19 Oct 2012 16:06:46 +0000 (18:06 +0200)]
s3: Make winbindd_register_handlers static

7 years agos3: Fix a typo
Volker Lendecke [Fri, 19 Oct 2012 15:46:14 +0000 (17:46 +0200)]
s3: Fix a typo

7 years agos3: Remove some calls to procid_self
Volker Lendecke [Fri, 19 Oct 2012 05:15:31 +0000 (07:15 +0200)]
s3: Remove some calls to procid_self

The goal is to have procid_self handling completely in the messaging_context.

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 19 20:39:56 CEST 2012 on sn-devel-104

7 years agos3:smbd:durable: store stat info for disconnected durables and check at reconnect.
Michael Adam [Fri, 19 Oct 2012 14:00:05 +0000 (16:00 +0200)]
s3:smbd:durable: store stat info for disconnected durables and check at reconnect.

At durable reconnect, we check the stat info stored in the cookie against the
current stat data from the file we just opened.  If any detail differs, we deny
the durable reconnect, because in that case it is very likely that someone
opened the file while the handle was disconnected, which has to be interpreted
as an oplock break.

Pair-programmed-with: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Oct 19 18:56:19 CEST 2012 on sn-devel-104

7 years agos3:open_files.idl: add stat-info to vfs_default_durable_cookie.
Michael Adam [Fri, 19 Oct 2012 13:57:24 +0000 (15:57 +0200)]
s3:open_files.idl: add stat-info to vfs_default_durable_cookie.

Pair-programmed-with: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd/durable: remove an extra blank line from vfs_default_durable_reconnect()
Michael Adam [Fri, 19 Oct 2012 13:53:50 +0000 (15:53 +0200)]
s3:smbd/durable: remove an extra blank line from vfs_default_durable_reconnect()

Pair-programmed-with: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:smbd/durable: add write_time specific stuff to vfs_default_durable_cookie
Stefan Metzmacher [Fri, 19 Oct 2012 09:12:05 +0000 (11:12 +0200)]
s3:smbd/durable: add write_time specific stuff to vfs_default_durable_cookie

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Oct 19 17:12:29 CEST 2012 on sn-devel-104

7 years agos3:open_files.idl: add write_time specific stuff to vfs_default_durable_cookie
Stefan Metzmacher [Fri, 19 Oct 2012 09:12:05 +0000 (11:12 +0200)]
s3:open_files.idl: add write_time specific stuff to vfs_default_durable_cookie

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd/durable: update the low level write_time before disconnecting the file.
Stefan Metzmacher [Fri, 19 Oct 2012 08:58:47 +0000 (10:58 +0200)]
s3:smbd/durable: update the low level write_time before disconnecting the file.

If we close the low level FD, we should better update the write_time
if needed.

It's not unlikely that the client doesn't reclaim the durable handle,
in that case we may not close the after the durable timeout.

In such a case we should make sure that we at least update the write time
on disconnect, this makes sure backup applications notice that
the file was changed.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd/durable: trigger pending write_time updates before disconnecting the file
Stefan Metzmacher [Fri, 19 Oct 2012 08:54:27 +0000 (10:54 +0200)]
s3:smbd/durable: trigger pending write_time updates before disconnecting the file

We need to call the pending write time update handler immediately.
Which means we don't wait exactly 2 seconds before updating the write time
after the first write.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
7 years agodocs-xml:smbd.8: document new smbXsrv_*_global.tdb files
Stefan Metzmacher [Thu, 18 Oct 2012 13:35:39 +0000 (15:35 +0200)]
docs-xml:smbd.8: document new smbXsrv_*_global.tdb files

metze

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Oct 19 14:00:39 CEST 2012 on sn-devel-104

7 years agos3:lib: remove unused connections_fetch_entry*() and connections_init()
Stefan Metzmacher [Fri, 5 Oct 2012 17:05:32 +0000 (19:05 +0200)]
s3:lib: remove unused connections_fetch_entry*() and connections_init()

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: remove unused claim_connection/yield_connection
Stefan Metzmacher [Fri, 5 Oct 2012 17:13:39 +0000 (19:13 +0200)]
s3:smbd: remove unused claim_connection/yield_connection

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: don't call claim/yield_connection() in make_connection_snum/close_cnum()
Stefan Metzmacher [Fri, 5 Oct 2012 17:11:31 +0000 (19:11 +0200)]
s3:smbd: don't call claim/yield_connection() in make_connection_snum/close_cnum()

This was used to maintain the connections.tdb database which is being removed.
We use info from the smbXsrv_tcon instead.

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:lib/conn_tdb: implement connections_forall_read() based on smbXsrv_*_global_traverse()
Gregor Beck [Mon, 3 Sep 2012 09:13:16 +0000 (11:13 +0200)]
s3:lib/conn_tdb: implement connections_forall_read() based on smbXsrv_*_global_traverse()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: fill tcon->global->session_global_id
Stefan Metzmacher [Thu, 18 Oct 2012 11:40:08 +0000 (13:40 +0200)]
s3:smbd: fill tcon->global->session_global_id

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbXsrv.idl: add session_global_id to smbXsrv_tcon_global
Stefan Metzmacher [Thu, 18 Oct 2012 11:38:34 +0000 (13:38 +0200)]
s3:smbXsrv.idl: add session_global_id to smbXsrv_tcon_global

This is required for some debugging tools like smbstatus.

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:lib: remove function connections_forall()
Gregor Beck [Mon, 27 Aug 2012 13:21:42 +0000 (15:21 +0200)]
s3:lib: remove function connections_forall()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agodoc-xml: remove "net connections" documentation
Stefan Metzmacher [Thu, 18 Oct 2012 08:13:59 +0000 (10:13 +0200)]
doc-xml: remove "net connections" documentation

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:utils/net: remove unused "net connections"
Stefan Metzmacher [Fri, 5 Oct 2012 17:20:45 +0000 (19:20 +0200)]
s3:utils/net: remove unused "net connections"

The connections.tdb will go away.

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:net_serverid: remove connections_forall from "net serverid wipedbs"
Gregor Beck [Thu, 23 Aug 2012 12:02:22 +0000 (14:02 +0200)]
s3:net_serverid: remove connections_forall from "net serverid wipedbs"

This tdb will go away.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:lib: remove unused sessionid_*() functions
Gregor Beck [Thu, 23 Aug 2012 08:36:59 +0000 (10:36 +0200)]
s3:lib: remove unused sessionid_*() functions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:net_serverid: remove sessionid_traverse from "net serverid wipedbs"
Gregor Beck [Thu, 23 Aug 2012 12:02:22 +0000 (14:02 +0200)]
s3:net_serverid: remove sessionid_traverse from "net serverid wipedbs"

This tdb will go away.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: don't use (fill) sessionid.tdb in session_claim/yield any more.
Gregor Beck [Thu, 23 Aug 2012 14:15:25 +0000 (16:15 +0200)]
s3:smbd: don't use (fill) sessionid.tdb in session_claim/yield any more.

We use data from new smbXsrv_session instead.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:lib: implement sessionid_traverse_read with smb2srv_session_traverse_read
Gregor Beck [Thu, 23 Aug 2012 08:36:59 +0000 (10:36 +0200)]
s3:lib: implement sessionid_traverse_read with smb2srv_session_traverse_read

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd/connection: use smbXsrv_tcon_traverse to count connections
Gregor Beck [Tue, 28 Aug 2012 13:53:28 +0000 (15:53 +0200)]
s3:smbd/connection: use smbXsrv_tcon_traverse to count connections

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd:setup_new_vc_session: traverse sessions instead of connections to shutdown...
Gregor Beck [Tue, 28 Aug 2012 12:29:51 +0000 (14:29 +0200)]
s3:smbd:setup_new_vc_session: traverse sessions instead of connections to shutdown other smbds

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:build: move sessionid_tdb.o and conn_tdb.o to SMBD_OBJ_BASE
Gregor Beck [Fri, 7 Sep 2012 13:18:39 +0000 (15:18 +0200)]
s3:build: move sessionid_tdb.o and conn_tdb.o to SMBD_OBJ_BASE

and use SMBD_OBJ_BASE for a couple of targets where sessionid_tdb and conn_tdb
were used.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbXsrv_tcon: add smbXsrv_tcon_global_traverse()
Gregor Beck [Tue, 28 Aug 2012 13:35:58 +0000 (15:35 +0200)]
s3:smbXsrv_tcon: add smbXsrv_tcon_global_traverse()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbXsrv_session: add smbXsrv_session_global_traverse()
Gregor Beck [Wed, 22 Aug 2012 12:28:31 +0000 (14:28 +0200)]
s3:smbXsrv_session: add smbXsrv_session_global_traverse()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: use session_global_id as session number for pam and utmp
Gregor Beck [Thu, 23 Aug 2012 13:21:06 +0000 (15:21 +0200)]
s3:smbd: use session_global_id as session number for pam and utmp

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:configure: check that struct utmp.ut_line is large enough for our use case
Stefan Metzmacher [Mon, 8 Oct 2012 09:15:50 +0000 (11:15 +0200)]
s3:configure: check that struct utmp.ut_line is large enough for our use case

We use "smb/%u" with a 32-bit number, "smb/4294967295\0" requires
15 chars (including the '\0').

metze

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: initialize session->global before calling session_claim
Gregor Beck [Mon, 27 Aug 2012 09:03:25 +0000 (11:03 +0200)]
s3:smbd: initialize session->global before calling session_claim

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: remove smbd_server_connection argument from session_claim()
Gregor Beck [Mon, 27 Aug 2012 07:21:58 +0000 (09:21 +0200)]
s3:smbd: remove smbd_server_connection argument from session_claim()

retrieve the server connection from the smbXsrv_session  argument instead.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbd: pass smbXsrv_session instead of user_struct to session_claim() and session_y...
Gregor Beck [Thu, 23 Aug 2012 12:47:33 +0000 (14:47 +0200)]
s3:smbd: pass smbXsrv_session instead of user_struct to session_claim() and session_yield()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:net_status_shares: use connections_forall_read for a read only traversal
Gregor Beck [Mon, 27 Aug 2012 13:18:07 +0000 (15:18 +0200)]
s3:net_status_shares: use connections_forall_read for a read only traversal

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:count_current_connections: do not clear orphaned entries from connections.tdb
Gregor Beck [Mon, 27 Aug 2012 13:12:36 +0000 (15:12 +0200)]
s3:count_current_connections: do not clear orphaned entries from connections.tdb

This removes one of the last callers of connetions_forall.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:smbcontrol: don't do stack_trace by connection but by server_id.
Gregor Beck [Tue, 28 Aug 2012 07:31:59 +0000 (09:31 +0200)]
s3:smbcontrol: don't do stack_trace by connection but by server_id.

Inparticular use serverid_traverse_read instead of connections_foralli
to enumerate processes.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>