Jeremy Allison [Fri, 29 Jun 2012 19:41:47 +0000 (12:41 -0700)]
Add uint64_t mid field to the files_struct.
Ensure it is initialized so we know what mid created this file.
Björn Jacke [Fri, 29 Jun 2012 21:43:56 +0000 (23:43 +0200)]
s3:waf add sendfile support for Tru64, which is the same as HP-UX's
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Sat Jun 30 02:22:21 CEST 2012 on sn-devel-104
Björn Jacke [Fri, 29 Jun 2012 21:36:24 +0000 (23:36 +0200)]
s3: add sendfile support for Tru64, which is the same as HP-UX's
Jeremy Allison [Fri, 29 Jun 2012 20:46:23 +0000 (13:46 -0700)]
Try and fix the autoconf build on Solaris/Nexenta/etc.
Their AC_TRY_RUN doesn't include any current CPPFLAGS. Make
the set[res]uid checks independent of this. Needs a small
change to the waf build in order to code with the change.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Jun 30 00:32:36 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 29 Jun 2012 18:15:49 +0000 (11:15 -0700)]
Fix typo in configure.in check for USE_LINUX_THREAD_CREDENTIALS.
Stefan Metzmacher [Fri, 8 Jun 2012 15:51:47 +0000 (17:51 +0200)]
s3:smbd: make use of smbXsrv_open for smb1/2/3
This makes sure we generate unique persistent file ids,
which are stored in smbXsrv_open_global.tdb.
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun 29 21:01:11 CEST 2012 on sn-devel-104
Stefan Metzmacher [Mon, 6 Feb 2012 22:06:41 +0000 (23:06 +0100)]
s3:smbd: add smbXsrv_open* infrastructure
Pair-Programmed-With: Michael Adam <obnox@samba.org>
metze
Stefan Metzmacher [Mon, 12 Mar 2012 17:38:07 +0000 (18:38 +0100)]
s3:smbXsrv.idl: add smbXsrv_open* structures
struct smbXsrv_open will represent a SMB 1 or SMB 2
open file handle, while 'files_struct' will be changed
to handle just the protocol independent glue for the SMB_VFS layer.
Note: the format is not stable yet, we need to add more things
when we start to support durable handles.
metze
Björn Jacke [Fri, 29 Jun 2012 15:16:11 +0000 (17:16 +0200)]
s3:configure: fix numerous compile warnings about implicit declaration of 'exit'
use return instead of exit in configure tests to fix those warnings:
warning: incompatible implicit declaration of built-in function 'exit'
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri Jun 29 19:08:54 CEST 2012 on sn-devel-104
Björn Jacke [Fri, 29 Jun 2012 15:01:47 +0000 (17:01 +0200)]
s3: fix the logic in bsd_statvfs
Gregor Beck [Fri, 29 Jun 2012 09:42:34 +0000 (11:42 +0200)]
s3:cclean avoid segfault in case of ctdb missbehaviour
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Jun 29 17:06:05 CEST 2012 on sn-devel-104
Gregor Beck [Fri, 29 Jun 2012 09:36:54 +0000 (11:36 +0200)]
s3:cclean: fix memory allocation
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Wed, 27 Jun 2012 13:07:15 +0000 (15:07 +0200)]
packaging(RHEL-CTDB): package cclean tool
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Wed, 27 Jun 2012 12:11:23 +0000 (14:11 +0200)]
packaging(RHEL-CTDB): make makespec.sh aware of new location of version.h
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Fri, 29 Jun 2012 08:55:32 +0000 (10:55 +0200)]
s3_dbrwap_ctdb: improve a comment in db_ctdb_can_use_local_record()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 29 Jun 2012 08:52:33 +0000 (10:52 +0200)]
s3:dbwrap_ctdb: fix a comment in db_ctdb_fetch()
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 29 Jun 2012 08:51:37 +0000 (10:51 +0200)]
s3:dbwrap_ctdb: expand the comment for the db_ctdb_can_use_local_copy() function
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 29 Jun 2012 08:47:56 +0000 (10:47 +0200)]
s3:dbwrap_ctdb: rename db_ctdb_own_record() -> db_ctdb_can_use_local_copy()
This matches the function's intention much closer, since it
also tests whether we have a valid local read only copy.
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Fri, 29 Jun 2012 08:43:11 +0000 (10:43 +0200)]
s3:dbrwap_ctdb: remove commented out legacy code
Michael Adam [Fri, 29 Jun 2012 08:39:07 +0000 (10:39 +0200)]
s3:dbwrap_ctdb: fix fetch/fetch_locked when samba is built against old ctdb
The introduction of read only copies has broken the algorithm for
deteting whether we can use the local record copy for fetch_locked
and fetch: For fetch locked the new code always uses the local copy
if there is one...
This patch re-establish the original algorithm for the build against
a ctdb without read only record copies.
Reported-by: Gregor Beck <gbeck@sernet.de>
Stefan Metzmacher [Fri, 29 Jun 2012 13:06:02 +0000 (15:06 +0200)]
lib/ccan: readd execinfo dependency to failtest
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 26 Jun 2012 12:47:58 +0000 (14:47 +0200)]
libcli/smb: add SMB2_CAP_DIRECTORY_LEASING to SMB2_CAP_ALL
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 26 Jun 2012 11:48:36 +0000 (13:48 +0200)]
lib/util: fix fd leak in anonymous_shared_allocate() if MAP_ANON is not available
metze
Stefan Metzmacher [Fri, 29 Jun 2012 11:16:11 +0000 (13:16 +0200)]
s3:smb2_server: remove max_charge check in smbd_smb2_request_verify_creditcharge()
The client can send any credit charge value, it's ok to send more than needed.
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Björn Jacke [Fri, 29 Jun 2012 10:49:21 +0000 (12:49 +0200)]
s3:build: tell linker to use corefoundation on all darwin releases
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri Jun 29 14:43:39 CEST 2012 on sn-devel-104
Björn Jacke [Thu, 28 Jun 2012 19:34:40 +0000 (21:34 +0200)]
s3: merge bsd_statvfs and darwin_statvfs
Rusty Russell [Fri, 29 Jun 2012 02:39:06 +0000 (12:09 +0930)]
ccan: we're subsystems, not a library.
Don't expose a libccan.so; it would produce clashes if someone else
does the same thing. Unfortunately, if we just change it from a
SAMBA_LIBRARY to a SAMBA_SUBSYSTEM, it doesn't create a static library
as we'd like, but links all the object files in. This means we get
many duplicates (eg. everyone gets a copy of tally, even though only
ntdb wants it).
So, the solution is twofold:
1) Make the ccan modules separate.
2) Make the ccan modules SAMBA_SUBSYSTEMs not SAMBA_LIBRARYs so we don't
build shared libraries which we can't share.
3) Make the places which uses ccan explicit.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date(master): Fri Jun 29 06:22:44 CEST 2012 on sn-devel-104
Jeremy Allison [Thu, 28 Jun 2012 20:41:19 +0000 (13:41 -0700)]
Move back to using per-thread credentials on Linux. Fixes the glibc native AIO lost wakeup problem.
See this post:
https://lists.samba.org/archive/samba-technical/2012-June/085101.html
for details.
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jun 29 03:57:45 CEST 2012 on sn-devel-104
Jeremy Allison [Thu, 28 Jun 2012 18:59:51 +0000 (11:59 -0700)]
Replace all uses of setXX[ug]id() and setgroups with samba_setXX[ug]id() calls.
Will allow thread-specific credentials to be added by modifying
the central definitions. Deliberately left the setXX[ug]id()
call in popt as this is not used in Samba.
Jeremy Allison [Tue, 26 Jun 2012 01:08:36 +0000 (18:08 -0700)]
Add missing setresgid() wrapper.
Stefan Metzmacher [Sun, 3 Jun 2012 21:09:33 +0000 (23:09 +0200)]
docs-xml: document "server max protocol" "SMB2" selects PROTOCOL_SMB2_10
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Jun 29 02:07:17 CEST 2012 on sn-devel-104
Stefan Metzmacher [Sun, 3 Jun 2012 21:04:44 +0000 (23:04 +0200)]
s3:param: change "server max protocol" to "SMB2" (SMB2_10)
metze
Stefan Metzmacher [Sun, 3 Jun 2012 21:02:56 +0000 (23:02 +0200)]
lib/param: let "SMB2" select PROTOCOL_SMB2_10
metze
Stefan Metzmacher [Mon, 25 Jun 2012 21:35:46 +0000 (23:35 +0200)]
s3:smb2_server: make the logic in smbd_smb2_request_verify_creditcharge() simpler
We just need a max_charge variable to make the algorithm independent
of multi_credit support.
metze
Stefan Metzmacher [Mon, 25 Jun 2012 19:14:43 +0000 (21:14 +0200)]
s3:smb2_server: simplify smbd_smb2_request_verify_creditcharge() a bit.
A credit charge of 0 is really not a special case, it just means the same
as 1.
metze
Stefan Metzmacher [Mon, 25 Jun 2012 19:40:00 +0000 (21:40 +0200)]
s3:smb2_negprot: support SMB2_CAP_LARGE_MTU on everything but port 139
In future we'll have other transports like RDMA.
This makes NBT (tcp port 139) special instead of port 445.
metze
Stefan Metzmacher [Mon, 25 Jun 2012 19:45:54 +0000 (21:45 +0200)]
s3:smb2_server: grant extra credits for multi-credit requests
metze
Stefan Metzmacher [Wed, 27 Jun 2012 13:33:43 +0000 (15:33 +0200)]
s3:smb2_server: implement credit granting similar to windows
This makes it much easier to compare traces.
metze
Stefan Metzmacher [Wed, 27 Jun 2012 13:33:43 +0000 (15:33 +0200)]
s3:smb2_server: make sure sequence numbers don't wrap at UINT64_MAX
metze
Stefan Metzmacher [Wed, 27 Jun 2012 13:33:43 +0000 (15:33 +0200)]
s3:smb2_server: make sure we don't grant more credits than we allow
If the client hasn't consumed the lowest seqnum, but the distance
between lowest and highest seqnum has reached max credits.
In that case we should stop granting credits.
metze
Stefan Metzmacher [Tue, 26 Jun 2012 12:28:07 +0000 (14:28 +0200)]
s3:smb2_server: check the credit_charge against the already granted credits
metze
Stefan Metzmacher [Mon, 25 Jun 2012 21:17:55 +0000 (23:17 +0200)]
s3:smb2_server: split out a smb2_validate_sequence_number() function
metze
Stefan Metzmacher [Tue, 26 Jun 2012 06:08:37 +0000 (08:08 +0200)]
s3:smb2_server: clear sequence window if we got the lowest sequence id
Otherwise we'll never consume sequence id '0'.
metze
Stefan Metzmacher [Mon, 25 Jun 2012 21:39:37 +0000 (23:39 +0200)]
s3:smb2_server: fix calculation of the next bitmap_offset
metze
Stefan Metzmacher [Mon, 25 Jun 2012 21:38:32 +0000 (23:38 +0200)]
s3:smb2_server: remove unused and confusing DEFAULT_SMB2_MAX_CREDIT_BITMAP_FACTOR
metze
Stefan Metzmacher [Mon, 25 Jun 2012 21:14:24 +0000 (23:14 +0200)]
s3:smb2_server: call smbd_smb2_request_validate() also in smbd_smb2_first_negprot()
We need to consume message_id 0, for SMB1 negprot starts.
metze
Stefan Metzmacher [Tue, 26 Jun 2012 12:23:12 +0000 (14:23 +0200)]
s3:smb2_server: start the connection with one credit granted to the client
metze
Björn Jacke [Thu, 28 Jun 2012 19:17:28 +0000 (21:17 +0200)]
s3: fine tune and clean up statvfs tests
This should also fix the build on Tru64. Tru64 has a POSIX compliant statvfs()
function while most *BSD systems ignore POSIX.
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Thu Jun 28 23:07:23 CEST 2012 on sn-devel-104
Björn Baumbach [Wed, 27 Jun 2012 11:06:50 +0000 (13:06 +0200)]
docs-xml: fix typos and format in smb.conf server max protocol man
Björn Baumbach [Thu, 3 May 2012 12:11:42 +0000 (14:11 +0200)]
packaging(RHEL-CTDB): fix build dependencies
Building manual pages needs rsync for copying built mans.
source3/script/installmo.sh calls msgfmt, thats part of gettext.
Andrew Bartlett [Thu, 28 Jun 2012 11:21:23 +0000 (21:21 +1000)]
selftest: run pdbtest against s3dc as well
This validates the password expiry, account disable in the s3 auth code
and the save/restore of values in tdbsam.
It also provides the first test of some net sam set subcommands.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Jun 28 20:39:38 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 28 Jun 2012 10:42:31 +0000 (20:42 +1000)]
selftest: use a loop rather than declare tests for both dc and s3dc
Andrew Bartlett [Tue, 26 Jun 2012 10:07:32 +0000 (20:07 +1000)]
librpc/ndr: Initilaise the remainder of struct dom_sid after a pull
This copes with the fact that r->sub_auths is a fixed-size array, not
an allocated pointer, and so will still have some bytes no filled in
if the sid did not have a MAX_SUB_AUTHS sub-authorities.
Andrew Bartlett
Günther Deschner [Thu, 28 Jun 2012 12:57:17 +0000 (14:57 +0200)]
s4-torture: fix typo in samlogon test.
Guenther
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu Jun 28 18:43:46 CEST 2012 on sn-devel-104
Günther Deschner [Thu, 28 Jun 2012 11:59:50 +0000 (13:59 +0200)]
s4-torture: use torture context for printing debug output.
Guenther
Volker Lendecke [Thu, 28 Jun 2012 09:19:31 +0000 (11:19 +0200)]
s3: Fix compilation of pthreadpool_sync.c on platforms without pthread.h
Signed-off-by: Bjoern Jacke <bj@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Thu Jun 28 16:43:13 CEST 2012 on sn-devel-104
Stefan Metzmacher [Thu, 28 Jun 2012 10:22:07 +0000 (12:22 +0200)]
s3:smbd: change nt_open_pipe() to uint16_t pnum/fnum
This is SMB1 code...
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 28 14:47:45 CEST 2012 on sn-devel-104
Stefan Metzmacher [Thu, 28 Jun 2012 08:02:01 +0000 (10:02 +0200)]
s3:smb2_create: add usefull DEBUG() message
All calls which take an file handle have the same,
so we should also log it, when we create a handle.
metze
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jun 28 12:41:49 CEST 2012 on sn-devel-104
Stefan Metzmacher [Thu, 28 Jun 2012 08:00:37 +0000 (10:00 +0200)]
s3:smbd/files: fsp->fnum is uint64_t not int!
metze
Stefan Metzmacher [Thu, 28 Jun 2012 07:54:41 +0000 (09:54 +0200)]
s3:brlock: s/int/uint64_t for fnum
fsp->fnum and lock->fnum are uint64_t already and we should not truncate the value here.
Currently this doesn't matter as we only use 16-bit.
But as 'int' is int32_t and we later compare fnum with lock->fnum == fnum,
the cast from int32_t to uint64_t goes via int64_t instead of uint32_t.
This means even if fsp->fnum just uses 32-bit of the uint64_t
we'll get the wrong result, as the implicit cast from a negative int32_t
value to uint64_t adds 0xFFFFFFFF00000000.
metze
Stefan Metzmacher [Thu, 28 Jun 2012 07:54:14 +0000 (09:54 +0200)]
s3:brlock: add some const to print_lock_struct()
metze
Stefan Metzmacher [Wed, 27 Jun 2012 22:51:45 +0000 (00:51 +0200)]
s3:wscript: use LOCKING subsystem for smbtorture3
metze
Rusty Russell [Thu, 28 Jun 2012 01:34:25 +0000 (11:04 +0930)]
source4/smbd/pidfile: don't panic if pid file is corrupt.
In particular, on a virtual machine after a forced reboot, it
contained "Ille" instead of a valid PID. Given it was the right
length, I'm assuming it was filesystem corruption.
process_exists_by_pid() then panics, when given a pid < 1.
Reported-by: lostogre on #samba-technical
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date(master): Thu Jun 28 05:19:24 CEST 2012 on sn-devel-104
Björn Jacke [Wed, 27 Jun 2012 17:23:15 +0000 (19:23 +0200)]
replace: define INT64_MAX when not defined
Tru64 doesn't have any stdint.h
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Thu Jun 28 00:45:58 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 27 Jun 2012 13:24:39 +0000 (23:24 +1000)]
s3-param: Rename loadparm_s3_context -> loadparm_s3_helpers
This helps clarify the role of this structure and wrapper function.
The purpose here is to provide helper functions to the lib/param
loadparm_context that point back at the s3 lp_ functions. This allows
a struct loadparm_context to be passed to any point in the code, and
always refer to the correct loadparm system. If this has not been
set, the variables loaded in the lib/param code will be returned.
As requested by Michael Adam.
Andrew Bartlett
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 27 17:11:16 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 27 Jun 2012 09:23:05 +0000 (19:23 +1000)]
s3-pdb_samba4: Remove dupliate profilePath handling
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jun 27 13:16:26 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 26 Jun 2012 10:59:25 +0000 (20:59 +1000)]
s4-selftest: expand passdb testing
This tests pdb_samba4 in the first instance
Andrew Bartlett [Wed, 27 Jun 2012 04:36:31 +0000 (14:36 +1000)]
s3-pdbtest: Initialise more elements for testing
If these were left as defaults, they cause issues when the backend (pdb_samba4)
returns the internal defaults from the directory, not the defaults from samu_new()
Andrew Bartlett
Andrew Bartlett [Wed, 27 Jun 2012 04:34:47 +0000 (14:34 +1000)]
s3-pdb_samba4: Add support for lastLogon and lastLogoff
Andrew Bartlett [Wed, 27 Jun 2012 04:56:04 +0000 (14:56 +1000)]
s3-pdb_samba4: Fix time handling, use nt_time_to_unix()
This matches
478d74fe1447c4588b14ef7040c8c13339d54026 which I failed to
merge from pdb_ads.
Andrew Bartlett
Andrew Bartlett [Wed, 27 Jun 2012 04:33:42 +0000 (14:33 +1000)]
lib/ldb: Print trace messages for modify correctly
Andrew Bartlett [Wed, 27 Jun 2012 02:47:59 +0000 (12:47 +1000)]
s4-selftest: Test login with a password expired user
This uses rkpty to test changing an expired password.
Andrew Bartlett
Andrew Bartlett [Wed, 27 Jun 2012 02:45:37 +0000 (12:45 +1000)]
s4-dsdb when setting DSDB_CONTROL_PASSWORD_BYPASS_LAST_SET_OID make it non-critical
Andrew Bartlett [Wed, 27 Jun 2012 02:42:31 +0000 (12:42 +1000)]
s4-dsdb: Remove hooks for non-directory password handling
This was an interesting hack, and the local_password module still exists, but
until it has a use case and a test case, remove the bypass of password_hash.
Andrew Bartlett
Andrew Bartlett [Wed, 27 Jun 2012 02:40:59 +0000 (12:40 +1000)]
selftest: allow NSS_WRAPPER_* vars to be exported to the environment
Andrew Bartlett [Wed, 27 Jun 2012 07:51:55 +0000 (17:51 +1000)]
selftest: Add extra users to nss_wrapper
These will be used for a test using pdbtest and to run the client
test environment under nss_wrapper.
Andrew Bartlett
Andrew Bartlett [Tue, 26 Jun 2012 23:04:46 +0000 (09:04 +1000)]
s3-pdbtest: show mis-matching times
Michael Adam [Wed, 27 Jun 2012 06:20:59 +0000 (08:20 +0200)]
s3:registry: change reg_import.c according to coding guidelines.
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Jun 27 10:07:54 CEST 2012 on sn-devel-104
Michael Adam [Wed, 27 Jun 2012 06:20:31 +0000 (08:20 +0200)]
s3:registry: use TALLOC_CTX * instead of const void * in reg_import_adapter()
Gregor Beck [Thu, 7 Jun 2012 11:34:35 +0000 (13:34 +0200)]
s3: add a tool "cclean" to cleanup orphaned entries from connections.tdb
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Thu, 7 Jun 2012 11:25:17 +0000 (13:25 +0200)]
s3:conn_tdb: add a function connections_fetch_entry_ext() that also takes the cnum
and have connections_fetch_entry() call connections_fetch_entry_ext().
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Tue, 12 Jun 2012 08:10:36 +0000 (10:10 +0200)]
s3:lib:dbwrap: fix return value of db_ctdb_traverse[_read] for non-persistent dbs
to return the number of traversed records upon successful traverse.
Signed-off-by: Michael Adam <obnox@samba.org>
David Disseldorp [Tue, 26 Jun 2012 23:23:57 +0000 (01:23 +0200)]
s3-printing: fix broken print_job_get_name() return
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Jun 27 04:04:56 CEST 2012 on sn-devel-104
Björn Jacke [Tue, 26 Jun 2012 22:25:53 +0000 (00:25 +0200)]
s3:test_net_registry_check.sh: grep -E isn't portable, use egrep
grep -E doesn't work on Solaris /usr/bin/grep e.g.
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Jun 27 02:18:07 CEST 2012 on sn-devel-104
Björn Jacke [Tue, 26 Jun 2012 10:23:41 +0000 (12:23 +0200)]
tests: make test_ldb portable, eliminate "local" keyword
this is BASH only, don't use it.
Michael Adam [Tue, 26 Jun 2012 13:35:32 +0000 (15:35 +0200)]
s3:net registry import: implement dry-run with "--test"
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Jun 26 21:43:49 CEST 2012 on sn-devel-104
Michael Adam [Tue, 26 Jun 2012 13:13:28 +0000 (15:13 +0200)]
s3:net registry import: add an assert
Pair-Programmed-With: Gergor Beck <gbeck@sernet.de>
Michael Adam [Tue, 26 Jun 2012 13:12:28 +0000 (15:12 +0200)]
s3:net registry import: reduce indentation
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Tue, 26 Jun 2012 13:11:22 +0000 (15:11 +0200)]
s3:net registry import: fix the return code when transaction commit fails
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Tue, 26 Jun 2012 13:02:41 +0000 (15:02 +0200)]
s3:net registry import: improve regdb_open/close layering
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Michael Adam [Tue, 26 Jun 2012 11:37:46 +0000 (13:37 +0200)]
s3:net registry import: untangle nested function calls
Michael Adam [Tue, 26 Jun 2012 11:32:40 +0000 (13:32 +0200)]
s3:net registry import: reduce indentation and untangle assignment from check
in import_with_precheck_action().
Michael Adam [Tue, 26 Jun 2012 11:29:50 +0000 (13:29 +0200)]
s3:net registry import: move precheck-and-import code to its own function
This is the code that is executed in a registry transaction.
The purpose of the refactoring is to be able to simplify and
untangle the code structure in the sequel.
Gregor Beck [Wed, 13 Jun 2012 12:32:55 +0000 (14:32 +0200)]
s3:net registry: fix violation of coding conventions
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Fri, 4 May 2012 11:51:01 +0000 (13:51 +0200)]
s3:net registry import: add option --precheck
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 7 May 2012 13:43:27 +0000 (15:43 +0200)]
s3:registry: add function registry_value_cmp()
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Fri, 4 May 2012 07:35:37 +0000 (09:35 +0200)]
s3:net registry import: check return values + codecleanup
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 7 May 2012 13:48:16 +0000 (15:48 +0200)]
s3:net registry: fix output of dwords with sign bit set
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 7 May 2012 13:44:21 +0000 (15:44 +0200)]
s3:registry: fix possible double free in import
Signed-off-by: Michael Adam <obnox@samba.org>
Gregor Beck [Mon, 7 May 2012 13:46:41 +0000 (15:46 +0200)]
s3:registry: improve debug output in reg_parse
Signed-off-by: Michael Adam <obnox@samba.org>