kai/samba.git
8 years agos4/wintest New ESXi configuration file
Zahari Zahariev [Thu, 20 Jan 2011 13:26:18 +0000 (15:26 +0200)]
s4/wintest New ESXi configuration file

This is a way to use wintest as it is unchanged and work with
ESXi virtualization solution instead of VirtualBox or KVM. As the
virtualization server is a remote Linux like machine I use 'sshpass'
wrapper SSH to execute stop/reset/revert commands.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Jan 21 00:29:15 CET 2011 on sn-devel-104

8 years agos4-auth Remove special case for account_sid from auth_serversupplied_info
Andrew Bartlett [Thu, 20 Jan 2011 12:39:37 +0000 (23:39 +1100)]
s4-auth Remove special case for account_sid from auth_serversupplied_info

This makes everything reference a server_info->sids list, which is now
a struct dom_sid *, not a struct dom_sid **.  This is in keeping with
the other sid lists in the security_token etc.

In the process, I also tidy up the talloc tree (move more structures
under their logical parents) and check for some possible overflows in
situations with a pathological number of sids.

Andrew Bartlett

8 years agos4-gensec Add prototype for gensec_ntlmssp_init()
Andrew Bartlett [Thu, 20 Jan 2011 05:38:08 +0000 (16:38 +1100)]
s4-gensec Add prototype for gensec_ntlmssp_init()

Andrew Bartlett

8 years agolibcli/auth move ntlmssp_wrap() and ntlmssp_unwrap() into common code.
Andrew Bartlett [Thu, 20 Jan 2011 05:37:04 +0000 (16:37 +1100)]
libcli/auth move ntlmssp_wrap() and ntlmssp_unwrap() into common code.

The idea here is to allow the source3/libads/sasl.c code to call this
instead of the lower level ntlmssp_* functions.

Andrew Bartlett

8 years agos4:selftest: mark samba4.nbt.winsreplication.owned as knownfail
Stefan Metzmacher [Thu, 20 Jan 2011 07:43:27 +0000 (08:43 +0100)]
s4:selftest: mark samba4.nbt.winsreplication.owned as knownfail

This sometimes fails on a busy server.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 09:29:12 CET 2011 on sn-devel-104

8 years agos4:selftest/skip: remove samba4.tokengroups.python
Stefan Metzmacher [Thu, 20 Jan 2011 07:34:28 +0000 (08:34 +0100)]
s4:selftest/skip: remove samba4.tokengroups.python

metze

8 years agos3:smbd: use anonymous_shared_free() for shared memory signing state
Stefan Metzmacher [Tue, 26 Oct 2010 20:49:46 +0000 (22:49 +0200)]
s3:smbd: use anonymous_shared_free() for shared memory signing state

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 07:48:29 CET 2011 on sn-devel-104

8 years agolib/util: add tests for anonymous_shared_allocate/free()
Stefan Metzmacher [Tue, 18 Jan 2011 16:00:26 +0000 (17:00 +0100)]
lib/util: add tests for anonymous_shared_allocate/free()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 06:25:03 CET 2011 on sn-devel-104

8 years agolib/util: add anonymous_shared_free()
Stefan Metzmacher [Tue, 26 Oct 2010 20:45:19 +0000 (22:45 +0200)]
lib/util: add anonymous_shared_free()

metze

8 years agolib/util: s/allocate_anonymous_shared/anonymous_shared_allocate/
Stefan Metzmacher [Tue, 26 Oct 2010 20:41:46 +0000 (22:41 +0200)]
lib/util: s/allocate_anonymous_shared/anonymous_shared_allocate/

metze

8 years agolib/util: fix rounding to page size in allocate_anonymous_shared()
Stefan Metzmacher [Wed, 19 Jan 2011 16:55:13 +0000 (17:55 +0100)]
lib/util: fix rounding to page size in allocate_anonymous_shared()

metze

8 years agos4-selftest Remove knownfail for tokengroups test
Andrew Bartlett [Wed, 19 Jan 2011 21:28:04 +0000 (08:28 +1100)]
s4-selftest Remove knownfail for tokengroups test

The problem with this test (use of None rather than "" has been fixed)

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jan 19 23:56:31 CET 2011 on sn-devel-104

8 years agos4-dsdb Don't use None as the input to the GENSEC loop in tokengroups test
Andrew Bartlett [Wed, 19 Jan 2011 20:20:06 +0000 (07:20 +1100)]
s4-dsdb Don't use None as the input to the GENSEC loop in tokengroups test

The input to gensec.update() should always be a string.

Andrew Bartlett

8 years agos3-param: Fixed code block in max_open_files().
Andreas Schneider [Wed, 19 Jan 2011 15:13:42 +0000 (16:13 +0100)]
s3-param: Fixed code block in max_open_files().

When the HAVE_GETRLIMIT and RLIMIT_NOFILE macros are defined the block
isn't closed.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 23:10:50 CET 2011 on sn-devel-104

8 years agos3-smbd: Fixed a possible null pointer dereference.
Andreas Schneider [Wed, 19 Jan 2011 15:22:28 +0000 (16:22 +0100)]
s3-smbd: Fixed a possible null pointer dereference.

8 years agowafsamba: quote CPP and CC values when calling pidl
Stefan Metzmacher [Wed, 19 Jan 2011 15:53:39 +0000 (16:53 +0100)]
wafsamba: quote CPP and CC values when calling pidl

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 19 20:23:50 CET 2011 on sn-devel-104

8 years agos4:selftest/skip: add samba4.tokengroups.python
Stefan Metzmacher [Wed, 19 Jan 2011 16:33:59 +0000 (17:33 +0100)]
s4:selftest/skip: add samba4.tokengroups.python

This fails randomly like this with an error (not a failure):

[651/695 in 27m37s] samba4.tokengroups.python(dc)
running client gensec_update
UNEXPECTED(error): samba4.tokengroups.python(dc).__main__.TokenTest.test_pac_groups
REASON: _StringException: _StringException: Content-Type: text/x-traceback;charset=utf8,language=python
traceback
1E2
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/memdisk/tridge/flakey/b2413/source4/source4/dsdb/tests/python/token_group.py", line 142, in test_pac_groups
    (client_finished, client_to_server) = gensec_client.update(server_to_client)
TypeError: expected a string
0

FAILED (0 failures and 1 errors in 0 testsuites)

A summary with detailed information can be found in:
  ./st/summary
test: running (/usr/bin/perl /memdisk/tridge/flakey/b2413/source4/source4/../selftest/selftest.pl --prefix=./st --builddir=. --srcdir=. --exclude=./selftest/skip --testlist="/usr/bin/python ./selftest/tests.py|"  --exclude=./selftest/slow --socket-wrapper  && touch ./st/st_done) | /usr/bin/python -u ../selftest/filter-subunit --expected-failures=./selftest/knownfail --fail-immediately | tee ./st/subunit | /usr/bin/python -u ../selftest/format-subunit --prefix=./st --immediate
ERROR: test failed with exit code 1

metze

8 years agos4-dsdb Add PAC validation test to tokengroups test.
Andrew Bartlett [Wed, 19 Jan 2011 11:29:49 +0000 (22:29 +1100)]
s4-dsdb Add PAC validation test to tokengroups test.

This confirms that the groups obtained from a Kerberos PAC match those
that a manual search of a target LDAP server would reveal.

This should allow mixing of a KDC specified by krb5.conf to test Samba
or Windows alternatly.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jan 19 13:13:48 CET 2011 on sn-devel-104

8 years agos4-pyauth Fix AuthContext wrapper
Andrew Bartlett [Wed, 19 Jan 2011 11:29:08 +0000 (22:29 +1100)]
s4-pyauth Fix AuthContext wrapper

8 years agos4-auth Allow NULL methods to be specified to auth_context_create_methods()
Andrew Bartlett [Wed, 19 Jan 2011 11:27:51 +0000 (22:27 +1100)]
s4-auth Allow NULL methods to be specified to auth_context_create_methods()

This allows us to init an auth context that isn't going to do any NTLM
authentication, but is used by other subsystems.

Andrew Bartlett

8 years agos4-dsdb Add a test of the tokenGroups behaviour on the user's DN.
Andrew Bartlett [Wed, 19 Jan 2011 03:55:36 +0000 (14:55 +1100)]
s4-dsdb Add a test of the tokenGroups behaviour on the user's DN.

Andrew Bartlett

8 years agos4-gensec Remove special case 'for SASL' that is not required any more.
Andrew Bartlett [Wed, 19 Jan 2011 03:54:36 +0000 (14:54 +1100)]
s4-gensec Remove special case 'for SASL' that is not required any more.

I've examined the code paths involved, and it appears an alternative
fix has been made in the ldap_server/ldap_bind.c code, and there is no
code path that uses this behaviour.

Andrew Bartlett

8 years agotdb: Added doxygen documentation.
Andreas Schneider [Thu, 13 Jan 2011 16:30:52 +0000 (17:30 +0100)]
tdb: Added doxygen documentation.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 11:26:34 CET 2011 on sn-devel-104

8 years agos3: Add wbinfo --dc-info
Volker Lendecke [Mon, 10 Jan 2011 16:25:00 +0000 (17:25 +0100)]
s3: Add wbinfo --dc-info

wbinfo --dc-info prints the current DC name and IP address. This helps
diagnosing problems that might happen when a later wbinfo --ping-dc fails.

This patch started out by using the SAF and NBT cache entires, but those are
relatively short-lived. So I decided to invent a new gencache entry with a very
long timeout. We need to go via the gencache because when for some reason a
winbind child process is stuck, we can't query it for the current DC it's
connected to. This must eventually go away again when we have a fully async
winbind.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 19 08:40:28 CET 2011 on sn-devel-104

8 years agoAdd DELETE-LN test to show bug #7863 - Unlink may unlink wrong file when hardlinks...
Jeremy Allison [Wed, 19 Jan 2011 00:57:25 +0000 (16:57 -0800)]
Add DELETE-LN test to show bug #7863 - Unlink may unlink wrong file when hardlinks are involved

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 03:06:32 CET 2011 on sn-devel-104

8 years agowaf: change private libraries to use the same soname as public libraries
Andrew Tridgell [Wed, 19 Jan 2011 00:04:05 +0000 (11:04 +1100)]
waf: change private libraries to use the same soname as public libraries

See
http://lists.samba.org/archive/samba-technical/2011-January/075816.html
for a description of the reason behind this change

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Jan 19 02:21:06 CET 2011 on sn-devel-104

8 years agopygensec: remove special case handling for None for buffers
Andrew Tridgell [Tue, 18 Jan 2011 23:31:28 +0000 (10:31 +1100)]
pygensec: remove special case handling for None for buffers

always returning a buffer makes life easier for callers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agoFix "net usersidlist" not to skip every other user
Olly Betts [Tue, 18 Jan 2011 10:07:13 +0000 (10:07 +0000)]
Fix "net usersidlist" not to skip every other user

Remove double increment from for loop over users in get_user_tokens(),
left over from when this used to be a while loop.  Bug was introduced
in 1e39a619.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 01:34:29 CET 2011 on sn-devel-104

8 years agos3-winbind: no need to include ../librpc/gen_ndr/cli_lsa.h in
Günther Deschner [Tue, 18 Jan 2011 17:05:29 +0000 (18:05 +0100)]
s3-winbind: no need to include ../librpc/gen_ndr/cli_lsa.h in
winbindd/winbindd_msrpc.c.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 19 00:37:46 CET 2011 on sn-devel-104

8 years agos3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
Günther Deschner [Tue, 18 Jan 2011 15:32:20 +0000 (16:32 +0100)]
s3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.

Guenther

8 years agos3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
Günther Deschner [Tue, 18 Jan 2011 15:32:05 +0000 (16:32 +0100)]
s3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.

Guenther

8 years agos3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore.
Günther Deschner [Tue, 18 Jan 2011 13:27:17 +0000 (14:27 +0100)]
s3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore.

Guenther

8 years agos3-net: use correct spoolss header in net rpc.
Günther Deschner [Tue, 18 Jan 2011 21:53:59 +0000 (22:53 +0100)]
s3-net: use correct spoolss header in net rpc.

Guenther

8 years agos3-net: use correct spoolss header in net_ads.c.
Günther Deschner [Tue, 18 Jan 2011 21:35:17 +0000 (22:35 +0100)]
s3-net: use correct spoolss header in net_ads.c.

Guenther

8 years agoFix error where Windows client spoolss returns WERR_INVALID_DATA W_ERROR(0x0000...
Jeremy Allison [Tue, 18 Jan 2011 22:00:44 +0000 (14:00 -0800)]
Fix error where Windows client spoolss returns WERR_INVALID_DATA       W_ERROR(0x0000000D)
on opening a printer. We can't return zero for devmode->size. Guenther please check !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jan 18 23:45:33 CET 2011 on sn-devel-104

8 years agos4:tls_tstream: also use a dynamic buffer for the pull side
Stefan Metzmacher [Tue, 14 Dec 2010 14:24:22 +0000 (15:24 +0100)]
s4:tls_tstream: also use a dynamic buffer for the pull side

Maybe that fixes the remaining issues with some gnutls versions.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 18 17:26:08 CET 2011 on sn-devel-104

8 years agos4:tls_tstream: fix partial reads, so that the gnutls layer doesn't read the same...
Stefan Metzmacher [Tue, 14 Dec 2010 14:00:15 +0000 (15:00 +0100)]
s4:tls_tstream: fix partial reads, so that the gnutls layer doesn't read the same data twice

metze

8 years agos4-tests: Added a test for correct inheritance of IO flagged ACEs.
Nadezhda Ivanova [Tue, 18 Jan 2011 13:58:18 +0000 (15:58 +0200)]
s4-tests: Added a test for correct inheritance of IO flagged ACEs.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Tue Jan 18 15:53:46 CET 2011 on sn-devel-104

8 years agos4-security: Fixed incorrect inheritance of IO flagged ACES
Nadezhda Ivanova [Tue, 18 Jan 2011 13:56:19 +0000 (15:56 +0200)]
s4-security: Fixed incorrect inheritance of IO flagged ACES

They should be inherited without the IO flag unless they contain generic information.

8 years agorelease-scripts: add build-htmlman-nogit
Michael Adam [Tue, 18 Jan 2011 13:20:12 +0000 (14:20 +0100)]
release-scripts: add build-htmlman-nogit

non-git version of a script to ease building of html version of manpages

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Jan 18 15:07:09 CET 2011 on sn-devel-104

8 years agorelease-scripts: add build-htmlman-git
Michael Adam [Tue, 18 Jan 2011 13:20:12 +0000 (14:20 +0100)]
release-scripts: add build-htmlman-git

git version of a script to ease building of html version of manpages

8 years agorelease-scripts: add gpl header comment to build-manpages-nogit
Michael Adam [Tue, 18 Jan 2011 13:17:15 +0000 (14:17 +0100)]
release-scripts: add gpl header comment to build-manpages-nogit

8 years agorelease-scripts: add gpl header comment to build-manpages-git
Michael Adam [Tue, 18 Jan 2011 13:18:08 +0000 (14:18 +0100)]
release-scripts: add gpl header comment to build-manpages-git

8 years agorelease-scripts: remove commented out line from git-version
Michael Adam [Tue, 18 Jan 2011 13:17:15 +0000 (14:17 +0100)]
release-scripts: remove commented out line from git-version

8 years agopackaging/RHEL-CTDB: add the smbta-util manpage
Michael Adam [Tue, 18 Jan 2011 00:06:32 +0000 (01:06 +0100)]
packaging/RHEL-CTDB: add the smbta-util manpage

8 years agopackaging/RHEL-CTDB: add the pam_winbind.conf manpage
Michael Adam [Tue, 18 Jan 2011 00:06:18 +0000 (01:06 +0100)]
packaging/RHEL-CTDB: add the pam_winbind.conf manpage

8 years agopackaging/RHEL-CTDB: do not use an external docs tarball but build the manpages
Michael Adam [Thu, 9 Sep 2010 15:56:03 +0000 (17:56 +0200)]
packaging/RHEL-CTDB: do not use an external docs tarball but build the manpages

8 years agopackaging/RHEL-CTDB: untangle the various %doc entries to single lines
Michael Adam [Thu, 9 Sep 2010 15:14:20 +0000 (17:14 +0200)]
packaging/RHEL-CTDB: untangle the various %doc entries to single lines

8 years agodocs: Remove template "itemizedlist/listitem" from man.xsl
Michael Adam [Tue, 18 Jan 2011 12:00:51 +0000 (13:00 +0100)]
docs: Remove template "itemizedlist/listitem" from man.xsl

This seems to have been basically taken from the manpages/lists.xls
from the docbook-xsl stylesheets. But it references a variable list-indent
that older versions of docbook-xsl (e.g. 1.69) do not provide.
This makes the manpage build break on older systems. Removing
the definition lets the build succeed, using the system-definition
of the itemizedlist/listitem.

The diff between the docbook's (version 1.75.1) definition of
itemizedlist/listitem and the definition in our man.xls is this:

-- with this patch
-- without this patch
@@ -53,5 +53,7 @@
   <!-- * seems to require the extra space. -->
   <xsl:call-template name="roff-if-end"/>
   <xsl:apply-templates/>
-  <xsl:text>.RE&#10;</xsl:text>
+  <xsl:if test=" following-sibling::listitem">
+        <xsl:text>&#10;.RE&#10;</xsl:text>
+  </xsl:if>
 </xsl:template>

I.e. the version of man.xsl made insertion if ".RE" conditional.
I hope this does not break anything severely.
The diff for e.g. the resulting winbindd.8 manpage is this:

--- with this patch
+++ witout this patch:
@@ -375,7 +375,6 @@

 \m[blue]\fBwinbind: rpc only\fR\m[]
 Setting this parameter forces winbindd to use RPC instead of LDAP to retrieve information from Domain Controllers\&.
-.RE
 .SH "EXAMPLE SETUP"
 .PP
 To setup winbindd for user and group lookups plus authentication from a domain controller use something like the following setup\&. This was tested on an early Red Hat Linux box\&.

Cheers

8 years agos4-gensec Extend python bindings for GENSEC and the associated test
Andrew Bartlett [Tue, 18 Jan 2011 08:14:45 +0000 (19:14 +1100)]
s4-gensec Extend python bindings for GENSEC and the associated test

This now tests a real GENSEC exchange, including wrap and unwrap,
using GSSAPI.  Therefore, it now needs to access a KDC.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jan 18 11:41:26 CET 2011 on sn-devel-104

8 years agos4-auth Extend python bindings to allow ldb and message to be specified
Andrew Bartlett [Tue, 18 Jan 2011 08:13:19 +0000 (19:13 +1100)]
s4-auth Extend python bindings to allow ldb and message to be specified

This will allow for some more tokenGroups tests in future.

Andrew Bartlett

8 years agos4-pygensec Fix indentation of py_gensec_start_mech_by_name()
Andrew Bartlett [Mon, 17 Jan 2011 05:26:21 +0000 (16:26 +1100)]
s4-pygensec Fix indentation of py_gensec_start_mech_by_name()

8 years agos4-torture Remove unused temp dirs from the RPC-PAC test.
Andrew Bartlett [Mon, 17 Jan 2011 05:24:16 +0000 (16:24 +1100)]
s4-torture Remove unused temp dirs from the RPC-PAC test.

The code previously required the creation of a messaging context, but
this isn't done any more, so we don't need the tmp dir to put it in.

Andrew Bartlett

8 years agos4-pyldb Fix tp_basicsize for PyLdbDn
Andrew Bartlett [Mon, 17 Jan 2011 05:23:23 +0000 (16:23 +1100)]
s4-pyldb Fix tp_basicsize for PyLdbDn

This wasn't actually causing problems before, as the structures were
the same size.

Andrew Bartlett

8 years agos4-pygensec Add bindings for server_start() and update()
Andrew Bartlett [Mon, 17 Jan 2011 05:23:02 +0000 (16:23 +1100)]
s4-pygensec Add bindings for server_start() and update()

8 years agos4-pyauth Add bindings for auth_context_create() as AuthContext()
Andrew Bartlett [Mon, 17 Jan 2011 05:22:31 +0000 (16:22 +1100)]
s4-pyauth Add bindings for auth_context_create() as AuthContext()

8 years agos4-pyauth Use py_talloc_get_type() for greater talloc binding safety
Andrew Bartlett [Mon, 17 Jan 2011 05:21:28 +0000 (16:21 +1100)]
s4-pyauth Use py_talloc_get_type() for greater talloc binding safety

This does a talloc check of the returned pointer before casting it.

Andrew Bartlett

8 years agos4-gensec Don't steal the auth_context, reference it.
Andrew Bartlett [Mon, 17 Jan 2011 05:20:09 +0000 (16:20 +1100)]
s4-gensec Don't steal the auth_context, reference it.

We don't want to steal this pointer away from the caller if it's been
set up from python.

Andrew Bartlett

8 years agopidl:wscript: don't warn about pidl gammar file changes for now
Stefan Metzmacher [Tue, 18 Jan 2011 06:20:26 +0000 (07:20 +0100)]
pidl:wscript: don't warn about pidl gammar file changes for now

We may add some logic that uses git diff HEAD to detect this changes
in developer mode later again.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jan 18 08:10:06 CET 2011 on sn-devel-104

8 years agos4-ldb_ldif: Take into account LDB_FLG_SHOW_BINARY
Kamen Mazdrashki [Mon, 17 Jan 2011 22:51:30 +0000 (00:51 +0200)]
s4-ldb_ldif: Take into account LDB_FLG_SHOW_BINARY

when user requires binary data to be displayed
using samba user-friendly ldif handlers

Found using following test search:
bin/ldbsearch -H st/dc/private/sam.ldb -b "CN=Deleted Objects,DC=samba,DC=example,DC=com" \
 "(objectGUID=97b52eac-6d89-434d-b935-1e5f2e086ffc)" replPropertyMetaData --show-deleted --show-binary

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Jan 18 00:40:01 CET 2011 on sn-devel-104

8 years agos4-ldb_ldif: Don't check for LDB_FLG_SHOW_BINARY in ldb_should_b64_encode
Kamen Mazdrashki [Mon, 17 Jan 2011 22:49:17 +0000 (00:49 +0200)]
s4-ldb_ldif: Don't check for LDB_FLG_SHOW_BINARY in ldb_should_b64_encode

LDB_FLG_SHOW_BINARY is data representation flag and should
not modify behavior of data checking functions.

This lead to a bug in lib/ldb/ldb_tdb/ldb_index.c as ltdb_index_key()
function relies on ldb_should_b64_encode function to determine
how to process index keys.

Found using following test search:
bin/ldbsearch -H st/dc/private/sam.ldb -b "CN=Deleted Objects,DC=samba,DC=example,DC=com" \
 "(objectGUID=97b52eac-6d89-434d-b935-1e5f2e086ffc)" replPropertyMetaData --show-deleted --show-binary

8 years agos4-provision: Fixed owner/group for hard-coded Sites descriptor.
Nadezhda Ivanova [Mon, 17 Jan 2011 15:48:36 +0000 (17:48 +0200)]
s4-provision: Fixed owner/group for hard-coded Sites descriptor.

We must not specify explicitly owner and group. As there is a difference between WIN_2003 and WIN_2008, we should let descriptor
module compute the correct default ones. Also removed inherited ACEs, they are ignored during SD creation anyway.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Jan 17 18:23:24 CET 2011 on sn-devel-104

8 years agos4-tools: Fixed a bug in ldapcmp - DACL was not retrieved correctly if the object...
Nadezhda Ivanova [Mon, 17 Jan 2011 15:44:10 +0000 (17:44 +0200)]
s4-tools: Fixed a bug in ldapcmp - DACL was not retrieved correctly if the object had no SACL.

--Pair-Programmed-With: Zahari Zahariev

8 years agos3-rpc_client: Fixed status check of dcerpc_lsa_lookup_sids_noalloc.
Andreas Schneider [Mon, 17 Jan 2011 12:40:12 +0000 (13:40 +0100)]
s3-rpc_client: Fixed status check of dcerpc_lsa_lookup_sids_noalloc.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Jan 17 17:35:50 CET 2011 on sn-devel-104

8 years agos3-rpc_client: Fixed return values of dcerpc_lsa_lookup_sids_generic.
Andreas Schneider [Mon, 17 Jan 2011 12:39:21 +0000 (13:39 +0100)]
s3-rpc_client: Fixed return values of dcerpc_lsa_lookup_sids_generic.

8 years agos3-auth: Fixed account lockout check.
Andreas Schneider [Mon, 17 Jan 2011 11:53:40 +0000 (12:53 +0100)]
s3-auth: Fixed account lockout check.

8 years agos3: Make sure we call wbcAuthenticateUserEx correctly
Volker Lendecke [Fri, 14 Jan 2011 12:14:22 +0000 (05:14 -0700)]
s3: Make sure we call wbcAuthenticateUserEx correctly

There are cases where we fill in params.password.response.lm_data with non-NULL
where params.password.response.lm_length is 0. wbcAuthenticateUserEx does not
like that.

I haven't been able to reproduce this with smbclient yet, I've seen it with a
proprietary smb client implementation.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 16:30:11 CET 2011 on sn-devel-104

8 years agos4-tools: Added a --sort-aces option to ldapcmp
Nadezhda Ivanova [Mon, 17 Jan 2011 12:22:22 +0000 (14:22 +0200)]
s4-tools: Added a --sort-aces option to ldapcmp

This option sorts the ACE lists during SD comparison in collision view to make it easier to
determine of a difference is only in ACE order, and if not, where do differences start.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Jan 17 14:09:09 CET 2011 on sn-devel-104

8 years agos3:build: don't use librpc/gen_ndr/cli_echo.[ch] anymore
Stefan Metzmacher [Sat, 15 Jan 2011 08:17:55 +0000 (09:17 +0100)]
s3:build: don't use librpc/gen_ndr/cli_echo.[ch] anymore

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 17 09:34:12 CET 2011 on sn-devel-104

8 years agos3:torture: use dcerpc_echo_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 08:15:34 +0000 (09:15 +0100)]
s3:torture: use dcerpc_echo_X() functions

metze

8 years agos3:rpcclient: use dcerpc_echo_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 08:14:56 +0000 (09:14 +0100)]
s3:rpcclient: use dcerpc_echo_X() functions

metze

8 years agos3: Avoid a few calls to cli_errstr
Volker Lendecke [Sun, 16 Jan 2011 20:13:29 +0000 (21:13 +0100)]
s3: Avoid a few calls to cli_errstr

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 17 08:47:25 CET 2011 on sn-devel-104

8 years agos3: Remove some unused code
Volker Lendecke [Sun, 16 Jan 2011 19:16:25 +0000 (20:16 +0100)]
s3: Remove some unused code

8 years agos3: Convert cli_lock64 to cli_smb
Volker Lendecke [Sun, 16 Jan 2011 19:09:17 +0000 (20:09 +0100)]
s3: Convert cli_lock64 to cli_smb

8 years agos3: Convert cli_lock to use cli_locktype
Volker Lendecke [Sun, 16 Jan 2011 19:04:17 +0000 (20:04 +0100)]
s3: Convert cli_lock to use cli_locktype

8 years agos3: Convert cli_locktype to cli_smb
Volker Lendecke [Sun, 16 Jan 2011 18:50:46 +0000 (19:50 +0100)]
s3: Convert cli_locktype to cli_smb

8 years agos3: Make passing up "result_parent" from cli_smb optional
Volker Lendecke [Sun, 16 Jan 2011 18:20:43 +0000 (19:20 +0100)]
s3: Make passing up "result_parent" from cli_smb optional

8 years agos3: Remove unused cli_send_keepalive
Volker Lendecke [Sun, 16 Jan 2011 18:11:45 +0000 (19:11 +0100)]
s3: Remove unused cli_send_keepalive

8 years agos3: Remove unused cli_send/receive_trans
Volker Lendecke [Sun, 16 Jan 2011 12:13:20 +0000 (13:13 +0100)]
s3: Remove unused cli_send/receive_trans

8 years agos3: Convert try_trans2 to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 12:12:16 +0000 (13:12 +0100)]
s3: Convert try_trans2 to cli_trans

8 years agos3: Convert cli_api to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 12:07:35 +0000 (13:07 +0100)]
s3: Convert cli_api to cli_trans

8 years agos3: Make cli_setpathinfo_basic use cli_setpathinfo
Volker Lendecke [Sun, 16 Jan 2011 11:56:09 +0000 (12:56 +0100)]
s3: Make cli_setpathinfo_basic use cli_setpathinfo

8 years agos3: Add cli_setpathinfo
Volker Lendecke [Sun, 16 Jan 2011 11:49:59 +0000 (12:49 +0100)]
s3: Add cli_setpathinfo

8 years agos3: Rename cli_setpathinfo->cli_setpathinfo_basic
Volker Lendecke [Sun, 16 Jan 2011 11:45:22 +0000 (12:45 +0100)]
s3: Rename cli_setpathinfo->cli_setpathinfo_basic

8 years agos3: Remove unused cli_send/receive_nt_trans
Volker Lendecke [Sun, 16 Jan 2011 11:34:43 +0000 (12:34 +0100)]
s3: Remove unused cli_send/receive_nt_trans

8 years agos3: Convert try_nttrans to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 11:33:24 +0000 (12:33 +0100)]
s3: Convert try_nttrans to cli_trans

8 years agos3: Move dump_ntquota* to smbcquotas.c
Volker Lendecke [Sun, 16 Jan 2011 11:26:45 +0000 (12:26 +0100)]
s3: Move dump_ntquota* to smbcquotas.c

8 years agos3: Convert cli_set_fs_quota_info to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 11:14:26 +0000 (12:14 +0100)]
s3: Convert cli_set_fs_quota_info to cli_trans

8 years agos3: Convert cli_get_fs_quota_info to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 11:03:07 +0000 (12:03 +0100)]
s3: Convert cli_get_fs_quota_info to cli_trans

8 years agos3: Convert cli_list_user_quota to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 10:53:03 +0000 (11:53 +0100)]
s3: Convert cli_list_user_quota to cli_trans

8 years agos3: Convert cli_set_user_quota to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 10:33:35 +0000 (11:33 +0100)]
s3: Convert cli_set_user_quota to cli_trans

8 years agos3: Convert cli_get_user_quota to cli_trans
Volker Lendecke [Sun, 16 Jan 2011 07:34:58 +0000 (08:34 +0100)]
s3: Convert cli_get_user_quota to cli_trans

8 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 15 Jan 2011 15:07:31 +0000 (16:07 +0100)]
s3: Fix some nonempty blank lines

8 years agos3: Fix a C++ warning
Volker Lendecke [Sun, 9 Jan 2011 18:54:33 +0000 (19:54 +0100)]
s3: Fix a C++ warning

8 years agos3: Remove cli_send_trans from cli_qpathinfo_alt_name
Volker Lendecke [Sun, 9 Jan 2011 18:44:13 +0000 (19:44 +0100)]
s3: Remove cli_send_trans from cli_qpathinfo_alt_name

8 years agos3: Remove cli_send_trans from cli_oem_change_password
Volker Lendecke [Sun, 9 Jan 2011 18:13:15 +0000 (19:13 +0100)]
s3: Remove cli_send_trans from cli_oem_change_password

8 years agoldb: new ABI sigs file
Andrew Tridgell [Mon, 17 Jan 2011 04:24:52 +0000 (15:24 +1100)]
ldb: new ABI sigs file

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Jan 17 06:09:23 CET 2011 on sn-devel-104

8 years agos4-dsdb: replaced the calls to ldb_search() in dsdb modules with dsdb_module_search()
Andrew Tridgell [Mon, 17 Jan 2011 02:39:46 +0000 (13:39 +1100)]
s4-dsdb: replaced the calls to ldb_search() in dsdb modules with dsdb_module_search()

this ensures we follow the module stack, and set the parent on child
requests

8 years agos4-dsdb: pass parent request to dsdb_module_*() functions
Andrew Tridgell [Mon, 17 Jan 2011 02:12:15 +0000 (13:12 +1100)]
s4-dsdb: pass parent request to dsdb_module_*() functions

this preserves the request hierarchy for dsdb_module_*() calls inside
dsdb ldb modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agoldb: added ldb_req_mark_trusted()
Andrew Tridgell [Mon, 17 Jan 2011 02:11:08 +0000 (13:11 +1100)]
ldb: added ldb_req_mark_trusted()

this is used to mark a ldb child request trusted, if the caller has
validated all inputs. This will be used when creating new child
requests with trusted inputs.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>