Michael Adam [Thu, 26 Feb 2009 01:57:59 +0000 (02:57 +0100)]
s3:registry: use delete_reg_subkey() in reg_deletekey()
This further speeds up net conf drop.
Michael
Michael Adam [Thu, 26 Feb 2009 01:56:50 +0000 (02:56 +0100)]
s3:registry: implement delete_subkey in the smbconf backend
delegating the call to the db backend
Michael
Michael Adam [Thu, 26 Feb 2009 01:56:00 +0000 (02:56 +0100)]
s3:registry: implement delete_subkey in the db backend
Michael
Michael Adam [Thu, 26 Feb 2009 01:54:50 +0000 (02:54 +0100)]
s3:registry: add a delete_subkey method to the backend ops.
This is to provide a more atomic means of deleting a subkey of a key.
Michael
Michael Adam [Thu, 26 Feb 2009 00:43:58 +0000 (01:43 +0100)]
s3:registry: refactor deletion of various subkey lists out of regdb_store_keys()
Micheal
Michael Adam [Thu, 26 Feb 2009 00:22:03 +0000 (01:22 +0100)]
s3:registry: streamline and cleanup regdb_set_secdesc() somewhat.
Michael
Michael Adam [Thu, 26 Feb 2009 00:16:07 +0000 (01:16 +0100)]
s3:registry: refactor deletion of value/secdesc/subkey list tdb records out
of regdb_store_values().
Michael
Michael Adam [Wed, 25 Feb 2009 22:13:07 +0000 (23:13 +0100)]
s3:registry: streamline reg_deletekey() somewhat.
use W_ERROR_... macros and separate assignments from checks
Michael
Michael Adam [Wed, 25 Feb 2009 21:06:47 +0000 (22:06 +0100)]
s3:registry: use create_reg_subkey() in reg_createkey().
Instead of calling store_reg_keys()
On my box, importing 2000 shares into an empty smbconf key
now takes some 32 seconds.
Michael
Michael Adam [Wed, 25 Feb 2009 21:04:58 +0000 (22:04 +0100)]
s3:registry: implement create_subkey for the smbconf backend
by delegating to the db backend
Michael
Michael Adam [Wed, 25 Feb 2009 21:04:07 +0000 (22:04 +0100)]
s3:registry: implement create_subkey for the db backend.
Michael
Michael Adam [Wed, 25 Feb 2009 20:59:54 +0000 (21:59 +0100)]
s3:registry: add a create_subkey method to the backend ops.
This is to provide a more atomic means of adding a subkey of a key.
Michael
Michael Adam [Wed, 25 Feb 2009 15:55:28 +0000 (16:55 +0100)]
libcli/util/werror.h: add macro W_ERROR_NOT_OK_GOTO(x, y)
a goto destination can be specified as a second parameter.
Michael
Michael Adam [Wed, 25 Feb 2009 15:53:05 +0000 (16:53 +0100)]
s3: move definition of W_ERROR_NOT_OK_GOTO_DONE down to libcli/util/werror.h
Michael
Michael Adam [Wed, 25 Feb 2009 13:49:30 +0000 (14:49 +0100)]
s3:net rpc registry: use regsubkey_ctr_init() instead of using talloc directly.
Michael
Michael Adam [Wed, 25 Feb 2009 08:53:16 +0000 (09:53 +0100)]
s3:registry: hash the list of subkeys in the regsubkey_ctr
This removes many loops over all the arrays
(from regsubkey_ctr_key_exists) and thus
reduces "net conf drop" from 1m55 to 48seconds
and "net conf import" from 1m55 to 58 seconds
for 2000 shares on my box.
Michael
Michael Adam [Tue, 24 Feb 2009 23:33:24 +0000 (00:33 +0100)]
s3:registry: remove definition of regsubkey_ctr from the surface.
All access is now through accessor functions in reg_objects.c
This allows for performance tuning under the hood in the next step.
Michael
Michael Adam [Tue, 24 Feb 2009 23:32:21 +0000 (00:32 +0100)]
s3:profiles: use regsubkey_ctr_init() instead of using talloc directly.
Michael
Michael Adam [Tue, 24 Feb 2009 22:28:48 +0000 (23:28 +0100)]
s3:registry: use regsubkey_ctr_init() in reg_eventlog.c
Michael
Michael Adam [Tue, 24 Feb 2009 22:23:04 +0000 (23:23 +0100)]
s3:services_db: use regsubkey_ctr_init() instead of using talloc directly
Michael
Michael Adam [Tue, 24 Feb 2009 22:19:35 +0000 (23:19 +0100)]
s3:registry: use regsubkey_ctr_get_seqnum() in reg_backend_db.c
Michael
Michael Adam [Tue, 24 Feb 2009 22:19:08 +0000 (23:19 +0100)]
s3:registry: use regsubkey_ctr_set_seqnum() in reg_backend_db.c
Michael
Michael Adam [Tue, 24 Feb 2009 22:18:20 +0000 (23:18 +0100)]
s3:registry: use regsubkey_ctr_init() in reg_backend_db.c
instead of using talloc directly.
Michael
Michael Adam [Tue, 24 Feb 2009 22:17:05 +0000 (23:17 +0100)]
s3:registry: use regsubkey_ctr_init() in reg_api.c
instead of using talloc on struct regsubkey_ctr.
Michael
Michael Adam [Tue, 24 Feb 2009 22:15:55 +0000 (23:15 +0100)]
s3:registry: add regsubkey_ctr_get_seqnum() to hide implementation
Michael
Michael Adam [Tue, 24 Feb 2009 22:10:35 +0000 (23:10 +0100)]
s3:registry: add regsubkey_ctr_set_seqnum to hide implementation from caller.
Michael
Michael Adam [Tue, 24 Feb 2009 21:43:47 +0000 (22:43 +0100)]
s3:registry: add a regsubkey_ctr_init function for allocating a regsubkey_ctr
Michael
Michael Adam [Tue, 24 Feb 2009 21:41:40 +0000 (22:41 +0100)]
s3:registry: fix a comment
Michael
Michael Adam [Tue, 24 Feb 2009 21:16:40 +0000 (22:16 +0100)]
s3:registry: don't directly access key->subkeys->subkeys[] in reg_backend_db.c
Use the reg_objects accessor regsubkey_ctr_specific_key() instead.
Michael
Michael Adam [Tue, 24 Feb 2009 20:12:26 +0000 (21:12 +0100)]
s3:registry: don't directly access key->subkeys->subkeys[] in reg_api.c
Use the reg_objects accessor regsubkey_ctr_specific_key() instead.
Michael
Michael Adam [Tue, 24 Feb 2009 16:42:50 +0000 (17:42 +0100)]
s3:registry: don't directly access key->subkeys->num_subkeys in reg_backend_db.
Use the reg_objects api instead.
Michael
Michael Adam [Tue, 24 Feb 2009 16:30:23 +0000 (17:30 +0100)]
s3:registry: don't directly access key->subkeys->num_subkeys in reg_api.c
Use the reg_objects api instead.
Michael
Michael Adam [Tue, 24 Feb 2009 14:19:18 +0000 (15:19 +0100)]
s3:registry: replace typedef "REGSUBKEY_CTR" by "struct regsubkey_ctr"
This paves the way for hiding the typedef and the implementation from the
surface.
Michael
Michael Adam [Tue, 24 Feb 2009 16:51:09 +0000 (17:51 +0100)]
Revert "Fix a O(n^2) algorithm in regdb_fetch_keys()"
This reverts commit
a13f065bad0f4d21a67e68b743f17f45bf0a4691.
This fix is reverted, because the speedup is going to move
further down into reg_objects.c. The unsorted list of subkey names
is going to be indexed: This O(n^2) search bites us in more places.
This re-establishes the abstraction of reg_objects.c.
Michael
Volker Lendecke [Thu, 26 Feb 2009 12:24:59 +0000 (13:24 +0100)]
Remove a temporary debug message -- sorry
Günther Deschner [Thu, 26 Feb 2009 12:19:24 +0000 (13:19 +0100)]
s3-spoolss: fix search_notify(). sorry...
Guenther
Günther Deschner [Thu, 26 Feb 2009 12:15:47 +0000 (13:15 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 26 Feb 2009 00:10:58 +0000 (01:10 +0100)]
s3-spoolss: job status defines moved to IDL.
Guenther
Günther Deschner [Thu, 26 Feb 2009 00:10:37 +0000 (01:10 +0100)]
spoolss: add spoolss_JobStatus.
Guenther
Günther Deschner [Wed, 25 Feb 2009 23:49:02 +0000 (00:49 +0100)]
s3-spoolss: remove some unused defines and structs.
Guenther
Stefan Metzmacher [Thu, 26 Feb 2009 12:12:54 +0000 (13:12 +0100)]
s4:heimdal_build: correrctly switch closefrom() and get/setprogname() replacements on and off
metze
Volker Lendecke [Thu, 26 Feb 2009 11:34:39 +0000 (12:34 +0100)]
Convert open_socket_out to tevent_req
Volker Lendecke [Thu, 26 Feb 2009 11:34:14 +0000 (12:34 +0100)]
Add tevent_req helpers to includes.h
Volker Lendecke [Thu, 26 Feb 2009 09:48:41 +0000 (10:48 +0100)]
Add tevent_ntstatus
Michael Adam [Tue, 24 Feb 2009 09:54:13 +0000 (10:54 +0100)]
s3:net: wrap net conf import into one big transaction
This speeds up "net conf import" of a file with 2000 shares
from 11 minutest to 1m50s on my box.
Michael
Michael Adam [Tue, 24 Feb 2009 09:52:30 +0000 (10:52 +0100)]
s3:libsmbconf: add transactions to the libsmbconf api
This is useful for wrapping higher level aggregate operations
in transactions. The text backend implementations just return
WERR_OK, the registry backend implementatoins use the
regdb_transaction_start|commit|cancel routines just added.
Michael
Michael Adam [Tue, 24 Feb 2009 14:40:05 +0000 (15:40 +0100)]
s3:registry: wrap deletekey_recursive in one big transaction.
This speeds up "net conf drop" with 2000 shares on my box from
4m40s to 1m50s, leaving virtually only cpu load.
Michael
Michael Adam [Tue, 24 Feb 2009 09:44:48 +0000 (10:44 +0100)]
s3:registry: provide transaction_start|commit|cancel fns for the registry tdb
Michael
Volker Lendecke [Sun, 22 Feb 2009 09:11:29 +0000 (10:11 +0100)]
Wrap creating the sorted subkey cache in a transaction
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sun, 22 Feb 2009 00:11:51 +0000 (01:11 +0100)]
Add a comment describing the sorted subkeys
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Fri, 20 Feb 2009 05:01:16 +0000 (06:01 +0100)]
Add sorted subkey cache
On my box this gets net conf list for 1000 records down to .1 seconds
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 21 Feb 2009 23:47:54 +0000 (00:47 +0100)]
Add db_tdb_parse
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 21 Feb 2009 23:18:05 +0000 (00:18 +0100)]
Add dbwrap->parse_record
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 21 Feb 2009 17:00:42 +0000 (18:00 +0100)]
Speed up "net conf list"
For 1000 shares this speeds up net conf list from .6 to .25 seconds on my box
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 21 Feb 2009 16:01:58 +0000 (17:01 +0100)]
Speed up "net conf list"
With 1000 shares in the registry, this changed the time of "net conf list" from
1.1 seconds to .6 seconds.
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Thu, 26 Feb 2009 09:55:00 +0000 (10:55 +0100)]
s4:Makefile: try to fix 'make installheaders' on *BSD systems
metze
Stefan Metzmacher [Thu, 26 Feb 2009 09:05:58 +0000 (10:05 +0100)]
s4:heimdal_build: don't always build setprogname.o
This hopefully fixes the build on Mac OS 10, where setprogname()
is available via libc.
asn1_compile and compile_et use only .ho files again
and don't use socket_wrapper anymore.
metze
Stefan Metzmacher [Thu, 26 Feb 2009 09:29:55 +0000 (10:29 +0100)]
libreplace: make it possible to disable socket_wrapper via -DSOCKET_WRAPPER_DISABLE=1
metze
Stefan Metzmacher [Thu, 26 Feb 2009 08:42:29 +0000 (09:42 +0100)]
s4:ldb_map: include ldb_includes.h first to get replace.h as first header
This should bring the build on AIX one step further.
metze
Stefan Metzmacher [Thu, 26 Feb 2009 08:10:23 +0000 (09:10 +0100)]
s4:VERSION: mark as 4.0.0-alpha8 gitsnapshot
metze
Andrew Bartlett [Thu, 26 Feb 2009 02:21:08 +0000 (13:21 +1100)]
Mark as the Samba 4.0 alpha7 release
Andrew Bartlett [Thu, 26 Feb 2009 02:12:07 +0000 (13:12 +1100)]
A simple hack to avoid the segfault in #6138
Thanks to Andrew Kroeger <andrew@id10ts.net> for reporting this. This
fix just for the release. A better fix will make it into the master
branch soon.
Andrew Bartlett
Jeremy Allison [Wed, 25 Feb 2009 22:57:16 +0000 (14:57 -0800)]
Fix more POSIX path lstat calls. Fix bug where close can return
failure if we have a pending modtime and the containing directory
of the file has been renamed (there is no POSIX "update time by
fd" call). This can't happen on Windows as the rename will fail
if there are open files beneath it. Will add a torture test
for this.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 22:50:19 +0000 (14:50 -0800)]
Use fsp->posix_open in preference if we have it.
Jeremy.
Günther Deschner [Wed, 25 Feb 2009 22:43:55 +0000 (23:43 +0100)]
s3-spoolss: fix _spoolss_AddJob behaviour.
Guenther
Günther Deschner [Wed, 25 Feb 2009 22:42:03 +0000 (23:42 +0100)]
s4-spoolss: implement dcesrv_spoolss_AddJob which always is a dummy.
Guenther
Günther Deschner [Mon, 9 Feb 2009 21:22:45 +0000 (22:22 +0100)]
s4-smbtorture: add test_AddJob test to RPC-SPOOLSS test.
Guenther
Jeremy Allison [Wed, 25 Feb 2009 22:12:51 +0000 (14:12 -0800)]
Ensure ACL modules work with POSIX paths.
Jeremy.
Günther Deschner [Wed, 25 Feb 2009 22:04:52 +0000 (23:04 +0100)]
s4-spoolss: implement dcesrv_spoolss_GetPrintProcessorDirectory.
Guenther
Stefan Metzmacher [Thu, 22 Jan 2009 09:54:12 +0000 (10:54 +0100)]
lib/tdb: if we know pwrite and pread are thread/fork safe tdb_reopen_all() should be a noop
The reason for tdb_reopen_all() is that the seek pointer on fds are shared between
parent and child.
metze
Tim Prouty [Wed, 25 Feb 2009 00:42:18 +0000 (16:42 -0800)]
s3: Report the correct path when dumping core on FreeBSD
Utilize the kern.corefile sysctl value on FreeBSD
Tim Prouty [Tue, 24 Feb 2009 22:45:46 +0000 (14:45 -0800)]
s3: Refactor and cleanup the error paths in dump_core_setup
Tim Prouty [Mon, 23 Feb 2009 22:51:17 +0000 (14:51 -0800)]
s3 OneFS: Add .snapshot directory configuration handling
Jeremy Allison [Wed, 25 Feb 2009 21:46:21 +0000 (13:46 -0800)]
Fix use of streams modules with CIFSFS client.
Jeremy.
Günther Deschner [Wed, 25 Feb 2009 21:10:21 +0000 (22:10 +0100)]
s3-rpcclient: add test command to call netr_LogonGetCapabilities (for bug #6100).
Guenther
Jeremy Allison [Wed, 25 Feb 2009 21:00:44 +0000 (13:00 -0800)]
Make test for open modes more robust against other bits.
Jeremy.
Jeremy Allison [Wed, 25 Feb 2009 20:53:45 +0000 (12:53 -0800)]
Fix bug in processing of open modes in POSIX open.
Was missing case of "If file exists open. If file doesn't exist error."
Damn damn damn. CIFSFS client will have to have fallback cases
for this error for a long time.
Jeremy.
Günther Deschner [Wed, 25 Feb 2009 19:50:34 +0000 (20:50 +0100)]
s3-rpcclient: support level 2 in spoolss_addform.
Guenther
Günther Deschner [Wed, 25 Feb 2009 20:08:13 +0000 (21:08 +0100)]
s3-spoolss: make us pass the RPC-SPOOLSS torture test w.r.t. directory calls.
Guenther
Günther Deschner [Wed, 25 Feb 2009 19:48:55 +0000 (20:48 +0100)]
s3-spoolss: JOB_ACCESS_READ has moved to idl.
Guenther
Günther Deschner [Wed, 25 Feb 2009 20:10:44 +0000 (21:10 +0100)]
s4-smbtorture: expand RPC-SPOOLSS enumform and getform tests for level 2 forms.
Guenther
Günther Deschner [Wed, 25 Feb 2009 15:17:44 +0000 (16:17 +0100)]
s4-smbtorture: add test_GetPrintProcessorDirectory to RPC-SPOOLSS.
Guenther
Günther Deschner [Wed, 25 Feb 2009 20:16:45 +0000 (21:16 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 25 Feb 2009 19:48:43 +0000 (20:48 +0100)]
spoolss: add JOB_ACCESS_READ.
Guenther
Günther Deschner [Wed, 25 Feb 2009 19:48:16 +0000 (20:48 +0100)]
spoolss: add spoolss_AddFormInfo2.
Guenther
Günther Deschner [Wed, 25 Feb 2009 19:46:35 +0000 (20:46 +0100)]
spoolss: fix spoolss_FormInfo2 (new in vista).
keyword is an astring, not an nstring.
Guenther
Günther Deschner [Wed, 25 Feb 2009 15:17:08 +0000 (16:17 +0100)]
spoolss: windows ignores level in a spoolss_GetPrintProcessorDirectory query.
Guenther
Tim Prouty [Wed, 25 Feb 2009 19:27:37 +0000 (11:27 -0800)]
s4: make libintl a build dependency of heimdal_krb5 so all dependent binaries are linked properly
Jeremy Allison [Wed, 25 Feb 2009 17:59:53 +0000 (09:59 -0800)]
Fix some NetBSD warnings.
Jeremy.
Jelmer Vernooij [Wed, 25 Feb 2009 15:54:35 +0000 (16:54 +0100)]
Only define _GNU_SOURCE if it's not defined yet.
Simo Sorce [Wed, 25 Feb 2009 15:02:41 +0000 (10:02 -0500)]
Use stdbool.h instead of manually defining bool
Jelmer Vernooij [Wed, 25 Feb 2009 14:22:31 +0000 (15:22 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Wed, 25 Feb 2009 14:22:08 +0000 (15:22 +0100)]
Rerun pidl.
Jelmer Vernooij [Wed, 25 Feb 2009 14:21:36 +0000 (15:21 +0100)]
Include header with NTSTATUS, as some IDL files use it.
Günther Deschner [Wed, 25 Feb 2009 13:27:30 +0000 (14:27 +0100)]
s3-spoolss: remove unused decode_printer_info_7.
Guenther
Stefan Metzmacher [Wed, 25 Feb 2009 14:05:24 +0000 (15:05 +0100)]
s4:lib/events: map TEVENT_DEBUG_TRACE to debug level 10
metze
Stefan Metzmacher [Wed, 25 Feb 2009 14:04:55 +0000 (15:04 +0100)]
s3:events: map TEVENT_DEBUG_TRACE to debug level 10
metze
Jelmer Vernooij [Wed, 25 Feb 2009 14:05:43 +0000 (15:05 +0100)]
Don't define _GNU_SOURCE if it's already defined on the command-line.
Stefan Metzmacher [Wed, 25 Feb 2009 13:29:31 +0000 (14:29 +0100)]
tevent: add private_print function feature to tevent_req
metze
Günther Deschner [Wed, 25 Feb 2009 12:46:08 +0000 (13:46 +0100)]
s3-rpcclient: allow to set level in spoolss getform query and display all levels.
Guenther