kai/samba.git
11 years agos3-smbldap: use smbldap_ prefixed functions
Alexander Bokovoy [Thu, 6 Sep 2012 15:53:00 +0000 (18:53 +0300)]
s3-smbldap: use smbldap_ prefixed functions

11 years agos3-smbldap: use smbldap_ prefix for all functions
Alexander Bokovoy [Thu, 6 Sep 2012 15:52:03 +0000 (18:52 +0300)]
s3-smbldap: use smbldap_ prefix for all functions

11 years agos3-waf: avoid exporting init symbols from statically linked modules
Alexander Bokovoy [Thu, 30 Aug 2012 16:09:14 +0000 (19:09 +0300)]
s3-waf: avoid exporting init symbols from statically linked modules

WAF builds with and without AD DC affect list of statically linked
modules that are added into libpdb. This makes impossible to have
ABI for libpdb that does not depend on configured features.

By making init functions from statically linked modules to have local
scope in shared libraries, we avoid unwarranted ABI changes.

Additionally, pdb_samba_dsdb imports IDMAP subsystem of source4/ as
it is not a shared library. Making its symbols private as well.

Finally, in order to have the filtering of symbols work, libpdb
has to be public library.

11 years agos4-torture: dns torture test depends on AD DC build
Alexander Bokovoy [Thu, 6 Sep 2012 12:29:13 +0000 (15:29 +0300)]
s4-torture: dns torture test depends on AD DC build

11 years agos3-passdb: convert pdb_ipa to use secrets wrappers
Alexander Bokovoy [Wed, 5 Sep 2012 15:50:08 +0000 (18:50 +0300)]
s3-passdb: convert pdb_ipa to use secrets wrappers

11 years agos3-passdb: convert pdb_ldap to use secrets wrappers
Alexander Bokovoy [Wed, 5 Sep 2012 15:49:39 +0000 (18:49 +0300)]
s3-passdb: convert pdb_ldap to use secrets wrappers

11 years agos3-passdb: wrap secrets.tdb accessors used by PDB modules
Alexander Bokovoy [Wed, 5 Sep 2012 12:56:37 +0000 (15:56 +0300)]
s3-passdb: wrap secrets.tdb accessors used by PDB modules

PDB modules store domain sid and guid in secrets.tdb to cooperate
with other parts of smbd. If PDB module is built outside Samba
source code it has to be linked against internal libsecrets.

Wrap required secrets_* calls to avoid direct linking. libpdb
is linked against libsecrets by itself and this is enough.

11 years agowafsamba/samba_abi: allow negative matches in abi_match
Alexander Bokovoy [Thu, 30 Aug 2012 15:46:23 +0000 (18:46 +0300)]
wafsamba/samba_abi: allow negative matches in abi_match

abi_match keyword for samba libraries allows to selectively
apply ABI versions. samba_abi.py implied !sym to be used to
say 'all symbols but this one' but the actual demotion
of !sym to the local scope was not implemented.

Now abi_match='!sym' properly moves symbol to a local scope.

11 years agogen_abi.sh: filter out symbols not needed for ABI
Alexander Bokovoy [Thu, 23 Aug 2012 15:45:54 +0000 (18:45 +0300)]
gen_abi.sh: filter out symbols not needed for ABI

gdb does not allow to print definitions of certain section names
and special symbols used for dynamic loading machinery:

__bss_start
_edata
_init
_fini
_end

Please note the space before the pattern, it is needed to avoid
hungry matches of valid symbols with these as substrings (foo_init,
for example).

Without this patch gdb on Fedora 18 breaks when attempting to print
function and struct signature.

11 years agowafsamba/samba_abi: fix signature parsing for structures
Alexander Bokovoy [Thu, 23 Aug 2012 15:44:01 +0000 (18:44 +0300)]
wafsamba/samba_abi: fix signature parsing for structures

Signature parsing for structure objects was broken. Existing regexp
was greedingly cutting off additional curly brackets that belonged to
the first and last structure member.

11 years agowaf: Fix bug #8801 - build s3fs manpages.
Andreas Schneider [Thu, 6 Sep 2012 14:10:08 +0000 (16:10 +0200)]
waf: Fix bug #8801 - build s3fs manpages.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Sep  7 12:30:08 CEST 2012 on sn-devel-104

11 years agowaf: Rename nmblookup manpage to nmblookup4.
Andreas Schneider [Thu, 6 Sep 2012 13:26:37 +0000 (15:26 +0200)]
waf: Rename nmblookup manpage to nmblookup4.

11 years agodocs: Remove old tdb manpages.
Andreas Schneider [Thu, 6 Sep 2012 14:18:01 +0000 (16:18 +0200)]
docs: Remove old tdb manpages.

They are part of lib/tdb/manpages/ now.

11 years agodocs: Remove old ldb manpages.
Andreas Schneider [Wed, 5 Sep 2012 18:46:05 +0000 (20:46 +0200)]
docs: Remove old ldb manpages.

The ldb manpages can be found in lib/ldb/man/.

11 years agowaf: Create catalog file for manpage generation.
Andreas Schneider [Thu, 6 Sep 2012 10:14:46 +0000 (12:14 +0200)]
waf: Create catalog file for manpage generation.

11 years agowafsamba: Add a CONFIGURE_FILE option.
Andreas Schneider [Thu, 6 Sep 2012 10:14:34 +0000 (12:14 +0200)]
wafsamba: Add a CONFIGURE_FILE option.

11 years agowafsamba: Add support for manpages in SAMBA_MODULE.
Andreas Schneider [Wed, 5 Sep 2012 15:37:19 +0000 (17:37 +0200)]
wafsamba: Add support for manpages in SAMBA_MODULE.

11 years agoselftest/knownfail: samba3.smb2.durable-open.alloc-size fails currently
Stefan Metzmacher [Fri, 7 Sep 2012 06:54:08 +0000 (08:54 +0200)]
selftest/knownfail: samba3.smb2.durable-open.alloc-size fails currently

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Sep  7 10:47:29 CEST 2012 on sn-devel-104

11 years agos4:torture:smb2: add a test for alloc size behaviour under durable reconnect
Michael Adam [Thu, 6 Sep 2012 22:53:38 +0000 (00:53 +0200)]
s4:torture:smb2: add a test for alloc size behaviour under durable reconnect

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

11 years agoparam: remove unused define FN_LOCAL_PARM_CHAR()
Michael Adam [Thu, 6 Sep 2012 10:43:47 +0000 (12:43 +0200)]
param: remove unused define FN_LOCAL_PARM_CHAR()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoFree protect_ids in secret_store_domain_guid() as the caller of fetch_secrets() must...
Michele Baldessari [Fri, 7 Sep 2012 00:32:11 +0000 (17:32 -0700)]
Free protect_ids in secret_store_domain_guid() as the caller of fetch_secrets() must free the result in order to not leak memory.

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Sep  7 04:11:43 CEST 2012 on sn-devel-104

11 years agoselftest/knownfail: samba3.smb2.durable-v2-open.reopen{1,2} fails currently
Stefan Metzmacher [Thu, 6 Sep 2012 10:18:05 +0000 (12:18 +0200)]
selftest/knownfail: samba3.smb2.durable-v2-open.reopen{1,2} fails currently

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Sep  7 02:12:22 CEST 2012 on sn-devel-104

11 years agos4:torture/smb2: add smb2.durable-v2-open.reopen{1,2} tests
Stefan Metzmacher [Thu, 6 Sep 2012 09:51:12 +0000 (11:51 +0200)]
s4:torture/smb2: add smb2.durable-v2-open.reopen{1,2} tests

They show that only the content of the DH2C request matches and
all other values in the SMB2 Create request are ignored.

metze

11 years agos4:torture/smb2: check that the server should ignore the fname in a DHnC request
Stefan Metzmacher [Thu, 6 Sep 2012 10:38:54 +0000 (12:38 +0200)]
s4:torture/smb2: check that the server should ignore the fname in a DHnC request

metze

11 years agos4:torture/smb2: don't expect a DHnQ response in a DHnC request
Stefan Metzmacher [Thu, 6 Sep 2012 09:49:42 +0000 (11:49 +0200)]
s4:torture/smb2: don't expect a DHnQ response in a DHnC request

This is fixed in Windows 2012 and matches the [MS-SMB2] documentation
now.

metze

11 years agos4 dns: Make debug output less noisy
Kai Blin [Thu, 6 Sep 2012 20:53:32 +0000 (22:53 +0200)]
s4 dns: Make debug output less noisy

Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Fri Sep  7 00:31:56 CEST 2012 on sn-devel-104

11 years agos4 dns: Check if signing user is allowed to update records
Kai Blin [Thu, 6 Sep 2012 20:40:56 +0000 (22:40 +0200)]
s4 dns: Check if signing user is allowed to update records

This should fix bug #9142

11 years agofileserver:sysquotas: remove wrong cast
Björn Jacke [Thu, 6 Sep 2012 12:17:25 +0000 (14:17 +0200)]
fileserver:sysquotas: remove wrong cast

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Thu Sep  6 17:16:30 CEST 2012 on sn-devel-104

11 years agos3:quota: don't force the block size to 512
Björn Jacke [Thu, 6 Sep 2012 08:23:50 +0000 (10:23 +0200)]
s3:quota: don't force the block size to 512

there is no point in forcing the block size to 512 when curblocks is 1. This
will only lead to false quota reporting. See bug #3272

11 years agos3-smbd: Remove remaining references to removed OS support in old-style quota code
Andrew Bartlett [Mon, 3 Sep 2012 03:16:38 +0000 (13:16 +1000)]
s3-smbd: Remove remaining references to removed OS support in old-style quota code

Signed-off-by: Björn Jacke <bj@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Thu Sep  6 10:47:18 CEST 2012 on sn-devel-104

11 years agos3-smbd: Remove IRIX support from old (pre-sysquotas) code
Andrew Bartlett [Mon, 3 Sep 2012 02:20:53 +0000 (12:20 +1000)]
s3-smbd: Remove IRIX support from old (pre-sysquotas) code

This should be essentially dead code, as while it is possible to disable sysquotas, the sysquotas has since 2003 supported the 4A varient used on IRIX.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agos3-smbd: Remove HPUX support from old (pre-sysquotas) code
Andrew Bartlett [Sun, 2 Sep 2012 16:20:05 +0000 (02:20 +1000)]
s3-smbd: Remove HPUX support from old (pre-sysquotas) code

This should be essentially dead code, as while it is possible to disable sysquotas, the sysquotas has since 2003 supported the 4A varient used on HPUX.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agos3-smbd: Remove BSD support from old (pre-sysquotas) code
Andrew Bartlett [Sun, 2 Sep 2012 15:51:59 +0000 (01:51 +1000)]
s3-smbd: Remove BSD support from old (pre-sysquotas) code

This is essentially dead code, as while it is possible to disable
sysquotas, the default for BSD is now to use sysquotas with the
addition of 4B support via the recent Darwin patch by James Peach.

NFS support has been in sysquotas for quite some time now.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agos3-smbd: Remove Linux support from old (pre-sysquotas) code
Andrew Bartlett [Sun, 2 Sep 2012 15:41:27 +0000 (01:41 +1000)]
s3-smbd: Remove Linux support from old (pre-sysquotas) code

This is essentially dead code, as while it is possible to disable sysquotas, the default
for Linux has been to use sysquotas for quite some time now.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agos3-configure: Only use sysquotas by default
Andrew Bartlett [Sun, 2 Sep 2012 17:08:54 +0000 (03:08 +1000)]
s3-configure: Only use sysquotas by default

We now only use old quota code if --with-quotas=yes and there is no
sysquotas support for this platform.

This also removes --with-sys-quotas as an option, instead being the
first choice if --with-quotas=yes or --with-quotas=auto

sysquotas have been our preferred quota mechanism since 2003.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agobuild: Remove Unicos support (quota in particular)
Andrew Bartlett [Wed, 13 Jun 2012 02:20:07 +0000 (12:20 +1000)]
build: Remove Unicos support (quota in particular)

Unicos machines are long gone now (Cray now make Linux compute nodes),
so remove the quota support.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agobuild: Do not compile lib/sysquotas*.c files as part of configure
Andrew Bartlett [Mon, 4 Jun 2012 20:39:28 +0000 (06:39 +1000)]
build: Do not compile lib/sysquotas*.c files as part of configure

Instead, use the tests in tests/sysquotas.c.

It is better that we see any compile failures, and then expand the
tests than 'automatically' disable the support.  Users can always use
--without-quotas if the quotas code does not work on their system.

Andrew Bartlett

Signed-off-by: Björn Jacke <bj@sernet.de>
11 years agos3: Fix 64-bit warnings in vfs_media_harmony
Volker Lendecke [Wed, 5 Sep 2012 08:15:48 +0000 (10:15 +0200)]
s3: Fix 64-bit warnings in vfs_media_harmony

11 years agosysquota: we need to list nfs4 as a separate fs name for the sys_get_nfs_quota backend
Björn Jacke [Thu, 6 Sep 2012 05:58:00 +0000 (07:58 +0200)]
sysquota: we need to list nfs4 as a separate fs name for the sys_get_nfs_quota backend

at least the Linux kernel up to 3.5.0 lists NFSv4 aѕ nfs4 and not as nfs

11 years agoselftest: Test configure stage of dlz_bind9
Andrew Bartlett [Thu, 6 Sep 2012 05:22:17 +0000 (15:22 +1000)]
selftest: Test configure stage of dlz_bind9

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep  6 09:07:11 CEST 2012 on sn-devel-104

11 years agoselftest: Add tests for the dlz_bind9 module
Andrew Bartlett [Thu, 6 Sep 2012 04:26:57 +0000 (14:26 +1000)]
selftest: Add tests for the dlz_bind9 module

This will help ensure that we do not break the fundemental loading etc.

From here, it should be easy to extend this to more comprehensive tests.

Andrew Bartlett

11 years agojoin.py: Only replicate DNS zones if the source DC had DNS zones
Andrew Bartlett [Thu, 6 Sep 2012 00:37:18 +0000 (10:37 +1000)]
join.py: Only replicate DNS zones if the source DC had DNS zones

This avoid folks needing to specify --dns-backend=NONE

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep  6 04:48:55 CEST 2012 on sn-devel-104

11 years agos3-printing: Restrict printing=cups to systems with cups development headers at build...
Andrew Bartlett [Wed, 5 Sep 2012 05:03:31 +0000 (15:03 +1000)]
s3-printing: Restrict printing=cups to systems with cups development headers at build time

This means that instead of failing due to the default commandline values not being quite correct
that we clearly fail at loadparm and testparm time when parsing the printing= line.

Andrew Bartlett

11 years agoFree protect_ids in secret_store_domain_sid() as the caller of fetch_secrets() must...
Michele Baldessari [Wed, 5 Sep 2012 17:56:06 +0000 (10:56 -0700)]
Free protect_ids in secret_store_domain_sid() as the caller of fetch_secrets() must free the result in order to not leak memory.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep  5 22:20:45 CEST 2012 on sn-devel-104

11 years agoAdd "backup_intent" bool to files_struct.
Jeremy Allison [Wed, 5 Sep 2012 17:46:51 +0000 (10:46 -0700)]
Add "backup_intent" bool to files_struct.

Not used right now but I need this in the VFS to implement open for
backup/restore later and don't want to break the ABI once 4.0.0
ships.

11 years agoRemove an unncessary FTRUNCATE call in the open path. We can rely on O_TRUC.
Jeremy Allison [Wed, 5 Sep 2012 17:46:16 +0000 (10:46 -0700)]
Remove an unncessary FTRUNCATE call in the open path. We can rely on O_TRUC.

Suggested by Volker.

11 years agos4 dns: Allow configuring signed updates
Kai Blin [Tue, 4 Sep 2012 23:27:00 +0000 (01:27 +0200)]
s4 dns: Allow configuring signed updates

Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Wed Sep  5 20:42:46 CEST 2012 on sn-devel-104

11 years agos4 dns: Make sure to remember incoming tkey name
Kai Blin [Tue, 4 Sep 2012 23:26:16 +0000 (01:26 +0200)]
s4 dns: Make sure to remember incoming tkey name

11 years agos4 dns: Verify incoming TSIG signatures
Kai Blin [Wed, 5 Sep 2012 06:34:49 +0000 (08:34 +0200)]
s4 dns: Verify incoming TSIG signatures

11 years agos4 dns: Handle GSS-TSIG signature creation
Kai Blin [Wed, 5 Sep 2012 06:34:04 +0000 (08:34 +0200)]
s4 dns: Handle GSS-TSIG signature creation

11 years agos4 dns: When we got a TKEY, we need to remember which key to use for signing
Kai Blin [Wed, 5 Sep 2012 06:29:38 +0000 (08:29 +0200)]
s4 dns: When we got a TKEY, we need to remember which key to use for signing

11 years agos4 dns: TKEY record needs to remember incoming algorithm
Kai Blin [Wed, 5 Sep 2012 06:27:28 +0000 (08:27 +0200)]
s4 dns: TKEY record needs to remember incoming algorithm

Samba3 (and older windows versions) use gss.microsoft.com, win7 (and the RFC) use gss-tsig

11 years agos4 dns: Move dns_find_tkey to an extra file
Kai Blin [Wed, 5 Sep 2012 06:24:52 +0000 (08:24 +0200)]
s4 dns: Move dns_find_tkey to an extra file

11 years agos4 dns: Create IDL entry for TSIG-like record needed for signature check
Kai Blin [Wed, 5 Sep 2012 06:16:43 +0000 (08:16 +0200)]
s4 dns: Create IDL entry for TSIG-like record needed for signature check

11 years agos4-dns: Fix linking the dns service.
Andreas Schneider [Wed, 5 Sep 2012 14:54:47 +0000 (16:54 +0200)]
s4-dns: Fix linking the dns service.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Sep  5 18:40:00 CEST 2012 on sn-devel-104

11 years agoselftest: Add python blackbox tests for samba-tool ntacl get/set
Andrew Bartlett [Wed, 5 Sep 2012 08:13:53 +0000 (18:13 +1000)]
selftest: Add python blackbox tests for samba-tool ntacl get/set

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 15:47:55 CEST 2012 on sn-devel-104

11 years agosamba_tool: Improve samba-tool ntacl get/set to use the local sam.ldb SID
Andrew Bartlett [Wed, 5 Sep 2012 08:12:52 +0000 (18:12 +1000)]
samba_tool: Improve samba-tool ntacl get/set to use the local sam.ldb SID

This gets the SID for the local machine correctly.

We also add options for --use-ntvfs and --use-s3fs to help control
exactly which database is being read and written.

Andrew Bartlett

11 years agosamba_tool: Fix ntacl get to correctly output in sddl
Andrew Bartlett [Wed, 5 Sep 2012 07:06:33 +0000 (17:06 +1000)]
samba_tool: Fix ntacl get to correctly output in sddl

11 years agos4-provision: Fix error message to contain the string SSDL of the failed-to-match ACL
Andrew Bartlett [Wed, 5 Sep 2012 05:16:40 +0000 (15:16 +1000)]
s4-provision: Fix error message to contain the string SSDL of the failed-to-match ACL

11 years agos4 dns: Revert erroneous push from wrong branch
Kai Blin [Wed, 5 Sep 2012 09:07:55 +0000 (11:07 +0200)]
s4 dns: Revert erroneous push from wrong branch

I've pushed the wrong branch for this, sorry about that.

Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Wed Sep  5 14:10:54 CEST 2012 on sn-devel-104

11 years agos3:smb2_create: check for SMB2_CREATE_TAG_DHNC first
Stefan Metzmacher [Tue, 28 Aug 2012 07:33:51 +0000 (09:33 +0200)]
s3:smb2_create: check for SMB2_CREATE_TAG_DHNC first

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Sep  5 12:27:25 CEST 2012 on sn-devel-104

11 years agos3:locking: fix trailing space in brl_close_fnum()
Michael Adam [Tue, 4 Sep 2012 09:56:15 +0000 (11:56 +0200)]
s3:locking: fix trailing space in brl_close_fnum()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4 dns: Allow configuring signed updates
Kai Blin [Tue, 4 Sep 2012 23:27:00 +0000 (01:27 +0200)]
s4 dns: Allow configuring signed updates

Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Wed Sep  5 10:45:22 CEST 2012 on sn-devel-104

11 years agos4 dns: Make sure to remember incoming tkey name
Kai Blin [Tue, 4 Sep 2012 23:26:16 +0000 (01:26 +0200)]
s4 dns: Make sure to remember incoming tkey name

11 years agomore tsig_verify stuff
Kai Blin [Wed, 5 Sep 2012 06:09:22 +0000 (08:09 +0200)]
more tsig_verify stuff

11 years agodrop me
Kai Blin [Wed, 5 Sep 2012 06:08:49 +0000 (08:08 +0200)]
drop me

11 years agohack: dns_sign_tsig correct memcpy
Kai Blin [Wed, 5 Sep 2012 06:08:24 +0000 (08:08 +0200)]
hack: dns_sign_tsig correct memcpy

11 years agoHACK remove debug statement
Kai Blin [Wed, 5 Sep 2012 06:07:45 +0000 (08:07 +0200)]
HACK remove debug statement

11 years agos4 dns: Verify incoming TSIG signatures
Kai Blin [Mon, 3 Sep 2012 06:06:55 +0000 (08:06 +0200)]
s4 dns: Verify incoming TSIG signatures

11 years agos4 dns: Handle GSS-TSIG signatures
Kai Blin [Sun, 2 Sep 2012 19:43:52 +0000 (21:43 +0200)]
s4 dns: Handle GSS-TSIG signatures

11 years agobuild: Remove unused deps from vfs modules
Andrew Bartlett [Tue, 4 Sep 2012 22:55:41 +0000 (08:55 +1000)]
build: Remove unused deps from vfs modules

Both these modules are just implemented in terms of other modules.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 03:34:08 CEST 2012 on sn-devel-104

11 years agos3: Slightly simplify fd_open_atomic
Volker Lendecke [Mon, 3 Sep 2012 10:57:18 +0000 (12:57 +0200)]
s3: Slightly simplify fd_open_atomic

Replace an if-statement by a direct assignment

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep  5 01:56:46 CEST 2012 on sn-devel-104

11 years agos3: Put a comment into the right place
Volker Lendecke [Sun, 2 Sep 2012 10:42:59 +0000 (12:42 +0200)]
s3: Put a comment into the right place

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Fix a typo
Volker Lendecke [Wed, 29 Aug 2012 15:19:04 +0000 (17:19 +0200)]
s3: Fix a typo

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Factor out disposition_to_open_flags
Volker Lendecke [Sun, 2 Sep 2012 18:47:46 +0000 (20:47 +0200)]
s3: Factor out disposition_to_open_flags

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Factor out calculation of clear_ads
Volker Lendecke [Sun, 2 Sep 2012 11:06:22 +0000 (13:06 +0200)]
s3: Factor out calculation of clear_ads

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Slightly simplify open_file_ntcreate
Volker Lendecke [Sun, 2 Sep 2012 10:53:04 +0000 (12:53 +0200)]
s3: Slightly simplify open_file_ntcreate

We have not set flags2 before, so do direct assignment and not |=

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Fix a comment
Volker Lendecke [Sun, 2 Sep 2012 05:35:43 +0000 (07:35 +0200)]
s3: Fix a comment

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Make "open_match_attributes" static
Volker Lendecke [Fri, 31 Aug 2012 12:52:21 +0000 (14:52 +0200)]
s3: Make "open_match_attributes" static

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Fix some nonempty blank lines
Volker Lendecke [Fri, 31 Aug 2012 12:41:44 +0000 (14:41 +0200)]
s3: Fix some nonempty blank lines

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: Fix memleaks in pylibsmb.c
Volker Lendecke [Mon, 20 Aug 2012 11:43:41 +0000 (13:43 +0200)]
s3: Fix memleaks in pylibsmb.c

Cut&Paste errors from the read&x routine

Signed-off-by: Jeremy Allison <jra@samba.org>
11 years agos3: in sys_popen(), add a debug message for failed fork
Michael Adam [Tue, 4 Sep 2012 13:25:42 +0000 (15:25 +0200)]
s3: in sys_popen(), add a debug message for failed fork

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep  4 22:17:30 CEST 2012 on sn-devel-104

11 years agos3: in sys_popen(), add a debug message for failed extract_args()
Michael Adam [Tue, 4 Sep 2012 13:24:46 +0000 (15:24 +0200)]
s3: in sys_popen(), add a debug message for failed extract_args()

11 years agos3: in sys_popen(), untangle function call from result check
Michael Adam [Tue, 4 Sep 2012 13:23:01 +0000 (15:23 +0200)]
s3: in sys_popen(), untangle function call from result check

11 years agos3: in sys_popen(), untangle assigment from check and add a debug message in failure...
Michael Adam [Tue, 4 Sep 2012 13:19:46 +0000 (15:19 +0200)]
s3: in sys_popen(), untangle assigment from check and add a debug message in failure case

11 years agos3: in sys_popen(), improve call to pipe and report error to debug
Michael Adam [Tue, 4 Sep 2012 13:17:37 +0000 (15:17 +0200)]
s3: in sys_popen(), improve call to pipe and report error to debug

11 years agos3: in sys_popen(), validate input before opening the pipe.
Michael Adam [Tue, 4 Sep 2012 13:15:42 +0000 (15:15 +0200)]
s3: in sys_popen(), validate input before opening the pipe.

11 years agos3: in sys_popen(), fix a debug message
Michael Adam [Tue, 4 Sep 2012 12:21:37 +0000 (14:21 +0200)]
s3: in sys_popen(), fix a debug message

11 years agos3:smbd: in sys_disk_free(), improve a debug message
Michael Adam [Tue, 4 Sep 2012 13:02:40 +0000 (15:02 +0200)]
s3:smbd: in sys_disk_free(), improve a debug message

11 years agos3:smbd: in sys_disk_free(), improve a debug message
Michael Adam [Tue, 4 Sep 2012 13:01:18 +0000 (15:01 +0200)]
s3:smbd: in sys_disk_free(), improve a debug message

11 years agos3:smbd: in sys_disk_free(), fix line length and indentation of debug statement
Michael Adam [Tue, 4 Sep 2012 12:50:53 +0000 (14:50 +0200)]
s3:smbd: in sys_disk_free(), fix line length and indentation of debug statement

11 years agos3:smbd: in sys_disk_free(), fix a debug message
Michael Adam [Tue, 4 Sep 2012 12:50:15 +0000 (14:50 +0200)]
s3:smbd: in sys_disk_free(), fix a debug message

11 years agos3-winbind: DON'T PANIC if we couldn't find the domain.
Andreas Schneider [Tue, 4 Sep 2012 12:30:38 +0000 (14:30 +0200)]
s3-winbind: DON'T PANIC if we couldn't find the domain.

If we don't have a connection to a trusted domain but still try to do a
lookup we shouldn't segfault.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Sep  4 18:16:06 CEST 2012 on sn-devel-104

11 years agofile_server: Remove explicit set of passdb backend in fileserver.conf
Andrew Bartlett [Tue, 4 Sep 2012 10:31:03 +0000 (20:31 +1000)]
file_server: Remove explicit set of passdb backend in fileserver.conf

The default is now set during smb.conf loading based on the server role
or during provision.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Sep  4 14:05:34 CEST 2012 on sn-devel-104

11 years agobuild: sync the waf ACL checks with configure.in
Andrew Bartlett [Tue, 4 Sep 2012 10:15:28 +0000 (20:15 +1000)]
build: sync the waf ACL checks with configure.in

This should give us full ACLs on the same set of hosts that the autoconf build supports.

Andrew Bartlett

11 years agobuild: Remove references to charset modules - we no longer have these
Andrew Bartlett [Tue, 4 Sep 2012 10:06:12 +0000 (20:06 +1000)]
build: Remove references to charset modules - we no longer have these

11 years agobuild: vfs_fake_acls does not need the acl lib
Andrew Bartlett [Tue, 4 Sep 2012 09:41:38 +0000 (19:41 +1000)]
build: vfs_fake_acls does not need the acl lib

11 years agofile_server: Run task_server_terminate when smbd exists
Andrew Bartlett [Tue, 4 Sep 2012 09:06:15 +0000 (11:06 +0200)]
file_server: Run task_server_terminate when smbd exists

This will help us shut down when smbd cannot bind to ports or perform
some other critical startup operation.

Based on a patch by Stefan Metzmacher <metze@samba.org>

Andrew Bartlett

11 years agofile_server: use 'subreq' as variable instead of 'req'
Stefan Metzmacher [Tue, 4 Sep 2012 09:04:16 +0000 (11:04 +0200)]
file_server: use 'subreq' as variable instead of 'req'

This matches the style of all other tevent_req users.

metze

11 years agobuild: remove unused HAVE_NO_ACLS define
Andrew Bartlett [Tue, 4 Sep 2012 08:58:53 +0000 (18:58 +1000)]
build: remove unused HAVE_NO_ACLS define