kai/samba.git
15 years agopython: Use relative paths for registry.
Jelmer Vernooij [Sat, 26 Jan 2008 03:22:42 +0000 (04:22 +0100)]
python: Use relative paths for registry.

15 years agopython: Load smb.conf file for the provision tests.
Jelmer Vernooij [Sat, 26 Jan 2008 01:55:03 +0000 (02:55 +0100)]
python: Load smb.conf file for the provision tests.

15 years agoFix netlogon rpc-server build.
Günther Deschner [Fri, 25 Jan 2008 21:42:14 +0000 (22:42 +0100)]
Fix netlogon rpc-server build.

Guenther

15 years agoAdd IDL for netr_DsrDeregisterDNSHostRecords (just for completion).
Günther Deschner [Fri, 25 Jan 2008 16:43:15 +0000 (17:43 +0100)]
Add IDL for netr_DsrDeregisterDNSHostRecords (just for completion).

Guenther

15 years agoNET-BECOME-DC: always try to build ejs and python code
Stefan Metzmacher [Fri, 25 Jan 2008 14:45:18 +0000 (15:45 +0100)]
NET-BECOME-DC: always try to build ejs and python code

We let getenv("PROVISION_PYTHON") decide what we want
at runtime.

metze

15 years agotorture: the libnet torture test depend on python
Stefan Metzmacher [Fri, 25 Jan 2008 14:41:51 +0000 (15:41 +0100)]
torture: the libnet torture test depend on python

metze

15 years agoconfigure: define HAVE_WORKING_PYTHON
Stefan Metzmacher [Fri, 25 Jan 2008 14:40:55 +0000 (15:40 +0100)]
configure: define HAVE_WORKING_PYTHON

metze

15 years agoMerge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-test
Andrew Tridgell [Fri, 25 Jan 2008 12:16:34 +0000 (23:16 +1100)]
Merge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-test

15 years agopython: Give precedence to Samba's syspath over the already set system one.
Jelmer Vernooij [Fri, 25 Jan 2008 11:16:13 +0000 (12:16 +0100)]
python: Give precedence to Samba's syspath over the already set system one.

15 years agoMerge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-trivial
Jelmer Vernooij [Fri, 25 Jan 2008 10:50:00 +0000 (11:50 +0100)]
Merge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-trivial

Conflicts:

source/scripting/python/samba/provision.py

15 years agopython/provision: Reload secrets when necessary, fix unix names in mappings.
Jelmer Vernooij [Fri, 25 Jan 2008 10:47:44 +0000 (11:47 +0100)]
python/provision: Reload secrets when necessary, fix unix names in mappings.

Pair programmed with Andrew.

15 years agopidl/Samba4::Header: fix typedefs of unions and structs without elements
Stefan Metzmacher [Fri, 25 Jan 2008 09:07:43 +0000 (10:07 +0100)]
pidl/Samba4::Header: fix typedefs of unions and structs without elements

metze

15 years agoconfigure.ac: we should use AC_CONFIG_FILES() in order to use AC_OUTPUT only once
Stefan Metzmacher [Fri, 25 Jan 2008 07:42:30 +0000 (08:42 +0100)]
configure.ac: we should use AC_CONFIG_FILES() in order to use AC_OUTPUT only once

metze

15 years agoconfigure.ac: we should only create ldb.pc when use the internal ldb
Stefan Metzmacher [Fri, 25 Jan 2008 07:40:03 +0000 (08:40 +0100)]
configure.ac: we should only create ldb.pc when use the internal ldb

metze

15 years agorepl_meta_data: add some TODOs to replmd_modify_originating()
Stefan Metzmacher [Fri, 25 Jan 2008 07:08:33 +0000 (08:08 +0100)]
repl_meta_data: add some TODOs to replmd_modify_originating()

metze

15 years agoadded latency reporting
Andrew Tridgell [Fri, 25 Jan 2008 06:27:36 +0000 (17:27 +1100)]
added latency reporting

15 years agothis is in seconds
Andrew Tridgell [Fri, 25 Jan 2008 06:27:17 +0000 (17:27 +1100)]
this is in seconds

15 years agoTidy up the last regresesions on the python smbscript, from my work
Andrew Bartlett [Fri, 25 Jan 2008 06:11:20 +0000 (17:11 +1100)]
Tidy up the last regresesions on the python smbscript, from my work
with Jelmer today.

The only remaining issue is that for the build farm, we will need to
manually specify the users and groups from the NSS_WRAPPPER, as python
isn't compiled with this.

Andrew Bartlett

15 years agomore useful output
Andrew Tridgell [Fri, 25 Jan 2008 04:00:45 +0000 (15:00 +1100)]
more useful output

15 years agoadded a offline file torture test BASE-OFFLINE
Andrew Tridgell [Fri, 25 Jan 2008 04:00:11 +0000 (15:00 +1100)]
added a offline file torture test BASE-OFFLINE

15 years agopython: Fix representation of UUIDs as strings in zone files rather than binary blobs...
Jelmer Vernooij [Fri, 25 Jan 2008 02:54:33 +0000 (03:54 +0100)]
python: Fix representation of UUIDs as strings in zone files rather than binary blobs, fix escaping of LDAP URL's in PHP LDAP admin configuration.

Pair-programmed with Andrew, but git doesn't appear to support multiple --author arguments. :-(

15 years agoldb/python: Add bindings for schema functions.
Jelmer Vernooij [Fri, 25 Jan 2008 02:46:47 +0000 (03:46 +0100)]
ldb/python: Add bindings for schema functions.

15 years agopython/provision: Create private dir if it didn't exist yet.
Jelmer Vernooij [Fri, 25 Jan 2008 00:41:06 +0000 (01:41 +0100)]
python/provision: Create private dir if it didn't exist yet.

15 years agopython: Add test for secretsdb_become_dc
Jelmer Vernooij [Fri, 25 Jan 2008 00:37:47 +0000 (01:37 +0100)]
python: Add test for secretsdb_become_dc

15 years agopython: fix tests for check_all_substituted.
Jelmer Vernooij [Fri, 25 Jan 2008 00:30:43 +0000 (01:30 +0100)]
python: fix tests for check_all_substituted.

15 years agoMerge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-trivial
Jelmer Vernooij [Fri, 25 Jan 2008 00:03:13 +0000 (01:03 +0100)]
Merge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-trivial

15 years agopython/provision: Reconcile code partitions-only provisioning and generic provisionin...
Jelmer Vernooij [Fri, 25 Jan 2008 00:02:13 +0000 (01:02 +0100)]
python/provision: Reconcile code partitions-only provisioning and generic provisioning, some other minor refactoring of the provisioning.

Pair-programmed by Andrew and me using obby :-)

15 years agopython: Make SamDB.set_ntds_invocation_id take a string.
Jelmer Vernooij [Thu, 24 Jan 2008 23:51:09 +0000 (00:51 +0100)]
python: Make SamDB.set_ntds_invocation_id take a string.

15 years agoFix netlogon rpc-server build.
Günther Deschner [Thu, 24 Jan 2008 23:04:24 +0000 (00:04 +0100)]
Fix netlogon rpc-server build.

Guenther

15 years agoAdd IDL for netr_LogonGetTrustRid.
Günther Deschner [Thu, 24 Jan 2008 22:35:02 +0000 (23:35 +0100)]
Add IDL for netr_LogonGetTrustRid.

Guenther

15 years agoRename samr_*AccessMask bitfields to start with SAMR_.
Günther Deschner [Thu, 24 Jan 2008 22:52:16 +0000 (23:52 +0100)]
Rename samr_*AccessMask bitfields to start with SAMR_.

Guenther

15 years agoRevert "Add pidl --samba3-libnetapi option."
Günther Deschner [Thu, 24 Jan 2008 22:55:40 +0000 (23:55 +0100)]
Revert "Add pidl --samba3-libnetapi option."

This reverts commit fe299e0336fcff780ef69a6b4f56cd1e0d0c50a8.

15 years agopython: Add function to look for unsubsituted variables.
Jelmer Vernooij [Thu, 24 Jan 2008 21:18:27 +0000 (22:18 +0100)]
python: Add function to look for unsubsituted variables.

15 years agopython: Add bindings for SamDB.set_invocation_id().
Jelmer Vernooij [Thu, 24 Jan 2008 21:08:39 +0000 (22:08 +0100)]
python: Add bindings for SamDB.set_invocation_id().

15 years agoMerge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-trivial
Jelmer Vernooij [Thu, 24 Jan 2008 21:00:07 +0000 (22:00 +0100)]
Merge branch 'v4-0-test' of ssh://git.samba.org/data/git/samba into v4-0-trivial

15 years agoAdd pidl --samba3-libnetapi option.
Günther Deschner [Thu, 24 Jan 2008 16:43:38 +0000 (17:43 +0100)]
Add pidl --samba3-libnetapi option.

Guenther

15 years agopidl: get rid of stupid ';' char to terminate bitmap defines
Stefan Metzmacher [Thu, 24 Jan 2008 14:04:58 +0000 (15:04 +0100)]
pidl: get rid of stupid ';' char to terminate bitmap defines

metze

15 years agopidl/Samba4::Header: we don't need to check if (defined($enum->{ELEMENTS})) twice
Stefan Metzmacher [Thu, 24 Jan 2008 13:57:30 +0000 (14:57 +0100)]
pidl/Samba4::Header: we don't need to check if (defined($enum->{ELEMENTS})) twice

metze

15 years agonetlogon.idl: add some MSV1_0_ values from samba3 and use a bitmap32
Stefan Metzmacher [Thu, 24 Jan 2008 12:52:47 +0000 (13:52 +0100)]
netlogon.idl: add some MSV1_0_ values from samba3 and use a bitmap32

metze

15 years agonetlogon.idl: make use of bitmap samr_GroupAttrs
Stefan Metzmacher [Thu, 24 Jan 2008 09:24:41 +0000 (10:24 +0100)]
netlogon.idl: make use of bitmap samr_GroupAttrs

metze

15 years agonetlogon.idl: remove unused netr_GroupsMembership structure
Stefan Metzmacher [Thu, 24 Jan 2008 09:22:45 +0000 (10:22 +0100)]
netlogon.idl: remove unused netr_GroupsMembership structure

We have samr_RidWithAttribute and use that in all cases.

metze

15 years agoEnsure we set subobj.BACKEND_MOD for the 'partitions only' case.
Andrew Bartlett [Thu, 24 Jan 2008 05:25:35 +0000 (16:25 +1100)]
Ensure we set subobj.BACKEND_MOD for the 'partitions only' case.

Andrew Bartlett

15 years agoMake the repl_meta_data module the default for domain controllers.
Andrew Bartlett [Thu, 24 Jan 2008 05:17:45 +0000 (16:17 +1100)]
Make the repl_meta_data module the default for domain controllers.

Andrew Bartlett

15 years agoUse the repl_meta_data module by default.
Andrew Bartlett [Thu, 24 Jan 2008 03:28:25 +0000 (14:28 +1100)]
Use the repl_meta_data module by default.

This means that, except when we back onto LDAP, when it will be
replaced with the mapping backend, we will keep this codepath tested.

Andrew Bartlett

15 years agoKill another sub that the modules will handle for us.
Andrew Bartlett [Thu, 24 Jan 2008 00:33:37 +0000 (11:33 +1100)]
Kill another sub that the modules will handle for us.

15 years agoRemove useless subs from the ejs provision
Andrew Bartlett [Thu, 24 Jan 2008 00:26:21 +0000 (11:26 +1100)]
Remove useless subs from the ejs provision

The less things we manually place into the templates, the easier the
conversion to python will be.

Andrew Bartlett

15 years agoPython: add some docstrings.
Jelmer Vernooij [Thu, 24 Jan 2008 00:06:19 +0000 (01:06 +0100)]
Python: add some docstrings.

15 years agopython: Support --no-pass.
Jelmer Vernooij [Thu, 24 Jan 2008 00:05:57 +0000 (01:05 +0100)]
python: Support --no-pass.

15 years agopython: Add bindings for cli_credentials_set_cmdline_callbacks().
Jelmer Vernooij [Thu, 24 Jan 2008 00:05:19 +0000 (01:05 +0100)]
python: Add bindings for cli_credentials_set_cmdline_callbacks().

15 years agoDefault to creating anonymous credentials.
Jelmer Vernooij [Wed, 23 Jan 2008 22:38:21 +0000 (23:38 +0100)]
Default to creating anonymous credentials.

15 years agopython: Add convenience function for getting command line loadparm context
Jelmer Vernooij [Wed, 23 Jan 2008 22:33:36 +0000 (23:33 +0100)]
python: Add convenience function for getting command line loadparm context
and default to using system smb.conf.

15 years agoAdd bindings for lp_load_default().
Jelmer Vernooij [Wed, 23 Jan 2008 22:15:39 +0000 (23:15 +0100)]
Add bindings for lp_load_default().

15 years agoGet more information from ldb when reporting a failed replication.
Andrew Bartlett [Wed, 23 Jan 2008 04:44:02 +0000 (15:44 +1100)]
Get more information from ldb when reporting a failed replication.

Andrew Bartlett

15 years agoFix DRSUAPI replication test - NET-API-BECOME-DC.
Andrew Bartlett [Wed, 23 Jan 2008 04:43:14 +0000 (15:43 +1100)]
Fix DRSUAPI replication test - NET-API-BECOME-DC.

The main change here is to work with the current module stack,
replacing only the objectGUID module, rather than a number of modules.

However, two changes were key:
 - Fixing a typo search_req->handle -> change_req->handle
 - Allowing an error of NO_SUCH_OBJECT - it is quite valid
   for the object not to exist when being replicated in.

Other small changes were required to the ejs provision to match
changes in that code.

Andrew Bartlett

15 years agoFix segfaults in codepaths only tested by the NET-API-BECOME-DC test.
Andrew Bartlett [Wed, 23 Jan 2008 04:34:44 +0000 (15:34 +1100)]
Fix segfaults in codepaths only tested by the NET-API-BECOME-DC test.

(I presume this has resulted from the global variable elimination)

Perhaps the iconv handle argument to ndr_push_struct needs to be
marked as 'not NULL' or similar?

Andrew Bartlett

15 years agoMerge branch 'v4-0-test' of git://git.samba.org/samba into 4-0-local
Andrew Bartlett [Wed, 23 Jan 2008 04:09:55 +0000 (15:09 +1100)]
Merge branch 'v4-0-test' of git://git.samba.org/samba into 4-0-local

15 years agoAdded PFIF notice to Samba 4.0 tree
Andrew Tridgell [Wed, 23 Jan 2008 02:09:37 +0000 (13:09 +1100)]
Added PFIF notice to Samba 4.0 tree

15 years agoMake ranged results tests in ldap.js easier to debug.
Andrew Bartlett [Tue, 22 Jan 2008 22:00:00 +0000 (09:00 +1100)]
Make ranged results tests in ldap.js easier to debug.

This adds some extra information to the failure message, to chase down
which test is failing.

Andrew Bartlett

15 years agoranged_results: fix use of uninitialised variable (end)
Andrew Bartlett [Tue, 22 Jan 2008 21:57:16 +0000 (08:57 +1100)]
ranged_results: fix use of uninitialised variable (end)

This matches the range parsing in the search and callback - end was
uninitilaised, causing occasional failures in make test.

Andrew Bartlett

15 years agobuild: Remove support for DESCRIPTION setting that is now unused.
Jelmer Vernooij [Tue, 22 Jan 2008 17:49:51 +0000 (18:49 +0100)]
build: Remove support for DESCRIPTION setting that is now unused.

15 years agobuild: remove support for automatically building .pc files.
Jelmer Vernooij [Tue, 22 Jan 2008 17:47:18 +0000 (18:47 +0100)]
build: remove support for automatically building .pc files.

15 years agodcerpc_samr: Use manually written .pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:43:07 +0000 (18:43 +0100)]
dcerpc_samr: Use manually written .pc file.

15 years agoparam: Use manually written .pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:41:30 +0000 (18:41 +0100)]
param: Use manually written .pc file.

15 years agogensec: Use manually written .pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:39:54 +0000 (18:39 +0100)]
gensec: Use manually written .pc file.

15 years agotorture: Use manually written .pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:38:14 +0000 (18:38 +0100)]
torture: Use manually written .pc file.

15 years agodcerpc: Use manually written .pc files for dcerpc and ndr.
Jelmer Vernooij [Tue, 22 Jan 2008 17:36:14 +0000 (18:36 +0100)]
dcerpc: Use manually written .pc files for dcerpc and ndr.

15 years agoregistry: Use manually written .pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:28:51 +0000 (18:28 +0100)]
registry: Use manually written .pc file.

15 years agoldb/talloc/tdb: Use manually written pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:24:00 +0000 (18:24 +0100)]
ldb/talloc/tdb: Use manually written pc file.

15 years agobuild: Allow manually written pkg-config files.
Jelmer Vernooij [Tue, 22 Jan 2008 17:21:48 +0000 (18:21 +0100)]
build: Allow manually written pkg-config files.

15 years agotdb: Add URL in pc file.
Jelmer Vernooij [Tue, 22 Jan 2008 17:14:12 +0000 (18:14 +0100)]
tdb: Add URL in pc file.

15 years agoldb: Fix typo.
Jelmer Vernooij [Tue, 22 Jan 2008 16:34:44 +0000 (17:34 +0100)]
ldb: Fix typo.

15 years agoldb: Increase version number to make it easier to create new Debian snapshots.
Jelmer Vernooij [Tue, 22 Jan 2008 16:13:39 +0000 (17:13 +0100)]
ldb: Increase version number to make it easier to create new Debian snapshots.

15 years agopython: Avoid duplicate copies of some objects in different packages.
Jelmer Vernooij [Tue, 22 Jan 2008 15:21:54 +0000 (16:21 +0100)]
python: Avoid duplicate copies of some objects in different packages.

15 years agolibreplace: getpwent_r/getgrent_r on IRIX are similar to solaris but use size_t
Stefan Metzmacher [Tue, 22 Jan 2008 11:21:55 +0000 (12:21 +0100)]
libreplace: getpwent_r/getgrent_r on IRIX are similar to solaris but use size_t

metze
(cherry picked from commit 2f460915111066d79f5dc9b4ae4d003918d06852)

15 years agoMerge branch 'v4-0-test' of git://git.samba.org/samba into 4-0-local
Andrew Bartlett [Mon, 21 Jan 2008 11:01:32 +0000 (22:01 +1100)]
Merge branch 'v4-0-test' of git://git.samba.org/samba into 4-0-local

15 years agoBe sure to pass iconv handle down to compression subcontexts (fixes
Andrew Bartlett [Mon, 21 Jan 2008 09:56:27 +0000 (20:56 +1100)]
Be sure to pass iconv handle down to compression subcontexts (fixes
segfaults in NET-API-BECOME-DC)

Andrew Bartlett

15 years agobuild: Don't build heimdal as library.
Jelmer Vernooij [Sun, 20 Jan 2008 23:50:04 +0000 (00:50 +0100)]
build: Don't build heimdal as library.

15 years agopython: Fix init functions.
Jelmer Vernooij [Sun, 20 Jan 2008 17:04:19 +0000 (18:04 +0100)]
python: Fix init functions.

15 years agobuild: Demote a bunch of libraries to subsystems. This makes packaging easier and...
Jelmer Vernooij [Sun, 20 Jan 2008 15:28:43 +0000 (16:28 +0100)]
build: Demote a bunch of libraries to subsystems. This makes packaging easier and should also make it easier
to migrate to a new build system.

15 years agopython: Reenable modules for libcli_nbt and libcli_smb.
Jelmer Vernooij [Sun, 20 Jan 2008 15:24:11 +0000 (16:24 +0100)]
python: Reenable modules for libcli_nbt and libcli_smb.

15 years agoldb: Fix building python modules against system-provided ldb.
Jelmer Vernooij [Sun, 20 Jan 2008 15:10:43 +0000 (16:10 +0100)]
ldb: Fix building python modules against system-provided ldb.

15 years agobuild: Allow overriding CFLAGS for python packages.
Jelmer Vernooij [Sun, 20 Jan 2008 15:10:14 +0000 (16:10 +0100)]
build: Allow overriding CFLAGS for python packages.

15 years agoAdd an exception for S3
Volker Lendecke [Sun, 20 Jan 2008 14:51:02 +0000 (15:51 +0100)]
Add an exception for S3

Doing this correctly would involve a create_file call for qpathinfo

15 years agobuild: Fix handling of external pkg-config dependencies when generating pkg-config...
Jelmer Vernooij [Sun, 20 Jan 2008 00:19:59 +0000 (01:19 +0100)]
build: Fix handling of external pkg-config dependencies when generating pkg-config files.

15 years agohowto: Update instructions for git, and use ReST formatting.
Jelmer Vernooij [Sat, 19 Jan 2008 20:16:56 +0000 (21:16 +0100)]
howto: Update instructions for git, and use ReST formatting.

15 years agopidl: Add --version argument.
Julien Kerihuel [Fri, 18 Jan 2008 17:30:00 +0000 (18:30 +0100)]
pidl: Add --version argument.

15 years agoRemove default 'showInAdvancedViewOnly' values.
Andrew Bartlett [Fri, 18 Jan 2008 07:10:18 +0000 (18:10 +1100)]
Remove default 'showInAdvancedViewOnly' values.

This means we only show and set the values when they are not the
values the schema and objectclass module would impose.

Andrew Bartlett

15 years agoOnly set showOnlyInAdvancedView: TRUE when adding default values.
Andrew Bartlett [Fri, 18 Jan 2008 07:08:49 +0000 (18:08 +1100)]
Only set showOnlyInAdvancedView: TRUE when adding default values.

False is the default, so only set this when the schema requires the
hiding behaviour.

Andrew Bartlett

15 years agoDon't set 'name' in the LDIF, this is handled by the rdn_name module.
Andrew Bartlett [Fri, 18 Jan 2008 06:08:34 +0000 (17:08 +1100)]
Don't set 'name' in the LDIF, this is handled by the rdn_name module.

Andrew Bartlett

15 years agoMerge commit 'origin/v4-0-test' into 4-0-local
Andrew Bartlett [Fri, 18 Jan 2008 06:05:17 +0000 (17:05 +1100)]
Merge commit 'origin/v4-0-test' into 4-0-local

15 years agoAdd showInAdvancedViewOnly to every new object
Andrew Bartlett [Fri, 18 Jan 2008 05:56:41 +0000 (16:56 +1100)]
Add showInAdvancedViewOnly to every new object

Unless already set, the default value for this comes from the
defaultHidingValue in the schema.

Andrew Bartlett

15 years agomerged changes from v3-2-test
Andrew Tridgell [Fri, 18 Jan 2008 04:45:22 +0000 (15:45 +1100)]
merged changes from v3-2-test

15 years agomerged tdb changes from ctdb
Andrew Tridgell [Fri, 18 Jan 2008 04:33:57 +0000 (15:33 +1100)]
merged tdb changes from ctdb

15 years agoregistry: Use correct return values.
Jelmer Vernooij [Fri, 18 Jan 2008 02:37:06 +0000 (03:37 +0100)]
registry: Use correct return values.

15 years agoregistry: Avoid mapping registry return codes: return the right value in the first...
Jelmer Vernooij [Fri, 18 Jan 2008 02:00:00 +0000 (03:00 +0100)]
registry: Avoid mapping registry return codes: return the right value in the first place.

15 years agoWhen Windows attempts to create a new key, it looks for an available key name
Andrew Kroeger [Fri, 18 Jan 2008 01:51:51 +0000 (02:51 +0100)]
When Windows attempts to create a new key, it looks for an available key name
starting with "New Key #1" and iterating up to "New Key #99" before giving up.
ldb_open_key() calls reg_path_to_ldb() to build the appropriate dn from the key
name.  reg_path_to_ldb() was not catching the error returned by
ldb_dn_add_base_fmt() due to the unescaped '#' character, causing the returned
dn to be that of the parent key, not the potential new key.  Additionally,
Windows expects a return value of WERR_BADFILE when a key does not exist, but
WERR_NOT_FOUND was being returned instead.  Correcting the building of the dn
and the providing the expected return value allows new key creation to succeed.

When attempting to delete a key, Windows passes the complete path to the key,
not just the name of the child key to be deleted.  Using reg_path_to_ldb() to
build the correct dn allows key deletion to succeed.

15 years agoregistry: Improve error codes and update tests.
Jelmer Vernooij [Fri, 18 Jan 2008 01:45:00 +0000 (02:45 +0100)]
registry: Improve error codes and update tests.

Rather than map the error returned by the registry to the correct error,
return the correct error in the first place.

Also deal with the fact that the right error code is now returned in a
couple of places.

15 years agoWhen Windows initially creates a new value, the value name is "New Value #1".
Andrew Kroeger [Fri, 18 Jan 2008 00:50:33 +0000 (01:50 +0100)]
When Windows initially creates a new value, the value name is "New Value #1".
The '#' character was causing problems, as it was not being escaped for the dn,
but the failure returned by ldb_dn_add_child_fmt() was not being caught.  This
was causing the new value to be added on the parent key, not the current key.
When attempting to delete the new value (now on the parent key) the same
escaping error was returned by ldb_dn_add_child_fmt(), causing the delete to
delete the key and not the value.

When attempting to rename a value, Windows first tries to ensure the new name
does not already exist.  When a value does not exist, Windows expects a return
value of WERR_BADFILE, but WERR_NOT_FOUND was being returned instead.
Providing the WERR_BADFILE that Windows expects allows values to be renamed.

15 years agoregistry: Properly check return values from ldb_*() functions.
Andrew Kroeger [Fri, 18 Jan 2008 00:48:48 +0000 (01:48 +0100)]
registry: Properly check return values from ldb_*() functions.

There were a few cases left that attempted to detect errors from ldb_*()
function calls using "(ret < 0)".  As all LDB_* error codes are greater than
zero, there was no chance any errors would be detected.  Changed all such tests
to use "(ret != LDB_SUCCESS)".

15 years agoregistry: Check for more specific LDB return codes, handle changing existing values...
Jelmer Vernooij [Fri, 18 Jan 2008 00:47:10 +0000 (01:47 +0100)]
registry: Check for more specific LDB return codes, handle changing existing values better.