kai/samba.git
12 years agopy-ldb: allow dictionnary like usage (ie. e.get("myattribute", defVal)
Matthieu Patou [Sat, 11 Jun 2011 12:57:02 +0000 (16:57 +0400)]
py-ldb: allow dictionnary like usage (ie. e.get("myattribute", defVal)

12 years agos3: Fix Coverity ID 2582: FORWARD_NULL
Volker Lendecke [Sun, 19 Jun 2011 17:23:47 +0000 (19:23 +0200)]
s3: Fix Coverity ID 2582: FORWARD_NULL

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 20:46:43 CEST 2011 on sn-devel-104

12 years agos3: Fix Coverity ID 2583: RESOURCE_LEAK
Volker Lendecke [Sun, 19 Jun 2011 17:23:47 +0000 (19:23 +0200)]
s3: Fix Coverity ID 2583: RESOURCE_LEAK

12 years agos3: Remove unused name_queries
Volker Lendecke [Sun, 19 Jun 2011 11:06:11 +0000 (13:06 +0200)]
s3: Remove unused name_queries

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 15:14:38 CEST 2011 on sn-devel-104

12 years agos3: Fix some type-punned warnings
Volker Lendecke [Sun, 19 Jun 2011 11:06:00 +0000 (13:06 +0200)]
s3: Fix some type-punned warnings

12 years agos3: Add name_resolve_bcast_send/recv
Volker Lendecke [Sun, 19 Jun 2011 11:05:29 +0000 (13:05 +0200)]
s3: Add name_resolve_bcast_send/recv

12 years agos3: Fix a memleak in name_resolve_bcast
Volker Lendecke [Sun, 19 Jun 2011 09:26:55 +0000 (11:26 +0200)]
s3: Fix a memleak in name_resolve_bcast

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 19 12:40:55 CEST 2011 on sn-devel-104

12 years agos3: Test nttrans_create
Volker Lendecke [Sat, 18 Jun 2011 07:56:12 +0000 (09:56 +0200)]
s3: Test nttrans_create

This is a test for the share security descriptor exception for nttrans_create

12 years agos3: Add incomplete cli_nttrans_create
Volker Lendecke [Sat, 18 Jun 2011 07:10:30 +0000 (09:10 +0200)]
s3: Add incomplete cli_nttrans_create

secdesc only at this moment

12 years agos3: Correctly align even
Volker Lendecke [Sat, 18 Jun 2011 17:30:52 +0000 (19:30 +0200)]
s3: Correctly align even

12 years agos3: Allow NULL sd_size in make_sec_desc
Volker Lendecke [Sat, 18 Jun 2011 07:55:05 +0000 (09:55 +0200)]
s3: Allow NULL sd_size in make_sec_desc

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jun 18 22:26:15 CEST 2011 on sn-devel-104

12 years agos3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share
Christian Ambach [Fri, 17 Jun 2011 19:54:30 +0000 (21:54 +0200)]
s3:modules fix Bug 8244 - Cannot copy files larger than 2 GB to Samba share

the time_audit module uses int instead of uint64 as return value
in get_alloc_size so that sizes of files larger than 2 GB are
cut of leading to wrong replies to NtCreateAndX and Windows
clients giving up

While checking the types of all functions, I found two more wrong
return value types that needed correction

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Jun 17 23:11:10 CEST 2011 on sn-devel-104

12 years agos4-errors: Import error maps from the source3/ unix -> ntstatus mapping
Andrew Bartlett [Fri, 17 Jun 2011 07:07:26 +0000 (17:07 +1000)]
s4-errors: Import error maps from the source3/ unix -> ntstatus mapping

We need to syncronise these mappings, as the duplication of this
symobol in the build means that either may be called based only on
library link orders.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Jun 17 10:22:07 CEST 2011 on sn-devel-104

12 years agoerrors: reorder error codes for easier s3/s4 comparison
Andrew Bartlett [Fri, 17 Jun 2011 06:06:34 +0000 (16:06 +1000)]
errors: reorder error codes for easier s3/s4 comparison

12 years agos4-util: removed the s4 nterr.c
Andrew Tridgell [Fri, 17 Jun 2011 04:40:26 +0000 (14:40 +1000)]
s4-util: removed the s4 nterr.c

this is now in common code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agos3-util: remove the s3 nterr.c
Andrew Tridgell [Fri, 17 Jun 2011 04:40:07 +0000 (14:40 +1000)]
s3-util: remove the s3 nterr.c

this is now in common code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agoutil: moved nt_errstr() into common code
Andrew Tridgell [Fri, 17 Jun 2011 04:39:37 +0000 (14:39 +1000)]
util: moved nt_errstr() into common code

this brings nt_errstr() into common code, using the new
talloc_stackframe_exists() to ensure that we only allocate an error
string using talloc_tos() if a talloc stackframe does currently
exists. This makes it safe to use in external libraries

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agolibclu/util: Move get_friendly_nt_error_msg() in common.
Andrew Bartlett [Thu, 16 Jun 2011 03:00:09 +0000 (13:00 +1000)]
libclu/util: Move get_friendly_nt_error_msg() in common.

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agobuild: only use the git version on install, not in the build tree
Andrew Tridgell [Fri, 17 Jun 2011 05:21:39 +0000 (15:21 +1000)]
build: only use the git version on install, not in the build tree

having the git version in our version.h in the build tree is annoying
for developers, as every time you commit or rebase you need to spend
several minutes re-linking. This changes it to use the git version
only on install, which is much more useful as when you actually
install the binaries you may be using them in a way that reporting the
version is useful

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jun 17 08:37:06 CEST 2011 on sn-devel-104

12 years agosamba-tool: exit with non-zero status on dbcheck failure
Andrew Tridgell [Fri, 17 Jun 2011 04:40:48 +0000 (14:40 +1000)]
samba-tool: exit with non-zero status on dbcheck failure

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agotalloc: added talloc_stackframe_exists()
Andrew Tridgell [Fri, 17 Jun 2011 04:22:28 +0000 (14:22 +1000)]
talloc: added talloc_stackframe_exists()

This can be used to tell if a talloc stackframe is currently
available. Callers can use this to decide if they will use
talloc_tos() or instead use an alternative strategy. This gives us a
way to safely have calls to talloc_tos() in common code that may end
up in external libraries, as long as all talloc_tos() calls in these
pieces of common code check first that a stackframe is available.

12 years agos4-auth: quiet down the krb5 warnings when kerberos is not set to 'MUST'
Andrew Tridgell [Fri, 17 Jun 2011 03:47:14 +0000 (13:47 +1000)]
s4-auth: quiet down the krb5 warnings when kerberos is not set to 'MUST'

this prevents spurious error messages on client commands when when we
will fallback to NTLM authentication

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

12 years agosamba-tool: show success message on group operations
Andrew Tridgell [Fri, 17 Jun 2011 03:35:52 +0000 (13:35 +1000)]
samba-tool: show success message on group operations

12 years agos4-pysamdb: fixed the normalisation of grouptype in group add
Andrew Tridgell [Fri, 17 Jun 2011 02:02:23 +0000 (12:02 +1000)]
s4-pysamdb: fixed the normalisation of grouptype in group add

ldap integers are signed

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jun 17 05:43:18 CEST 2011 on sn-devel-104

12 years agosamba-tool: report total error count and suggest --fix if needed
Andrew Tridgell [Fri, 17 Jun 2011 01:34:19 +0000 (11:34 +1000)]
samba-tool: report total error count and suggest --fix if needed

12 years agosamba-tool: added attribute normalisation checks
Andrew Tridgell [Fri, 17 Jun 2011 01:31:25 +0000 (11:31 +1000)]
samba-tool: added attribute normalisation checks

this checks that all attributes have the right normalisation, and
offers to fix the ones that don't

12 years agos4-dsdb: if we don't have a remote schema, then use the local one
Andrew Tridgell [Fri, 17 Jun 2011 01:30:41 +0000 (11:30 +1000)]
s4-dsdb: if we don't have a remote schema, then use the local one

this allows the use of drsuapi_to_ldb() on all attributes for the
local database

12 years agos4-pydsdb: added dsdb_normalise_attributes() call
Andrew Tridgell [Fri, 17 Jun 2011 01:29:44 +0000 (11:29 +1000)]
s4-pydsdb: added dsdb_normalise_attributes() call

this call converts a set of attributes to DRSUAPI format and back to
ldb format. This has the effect of normalising the attributes using
the schema syntax rules

12 years agos3:wb_lookupsids: add some paranoia checks to wb_lookupsids_recv()
Stefan Metzmacher [Thu, 16 Jun 2011 16:25:15 +0000 (18:25 +0200)]
s3:wb_lookupsids: add some paranoia checks to wb_lookupsids_recv()

This hopefully catches future bugs.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 19:50:16 CEST 2011 on sn-devel-104

12 years agos3:wb_lookupsids: don't ignore 'result' and check if we got useable values
Stefan Metzmacher [Thu, 16 Jun 2011 16:16:15 +0000 (18:16 +0200)]
s3:wb_lookupsids: don't ignore 'result' and check if we got useable values

The wrong fix for bug #8215 discovered this bug, as it caused
sam_rids_to_names() to always return NT_STATUS_NONE_MAPPED.

metze

12 years agoRevert "s3-winbind: Fix paranoia checks in winbindd_samr.c."
Stefan Metzmacher [Thu, 16 Jun 2011 16:40:04 +0000 (18:40 +0200)]
Revert "s3-winbind: Fix paranoia checks in winbindd_samr.c."

This reverts commit 207a84d725b905c2b119d2ef0f4f4d4eb391140d.

This is the wrong fix for the problem, see bug #8215.

metze

12 years agos3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()
Stefan Metzmacher [Thu, 16 Jun 2011 10:47:22 +0000 (12:47 +0200)]
s3:rpc_server/svcctl: fix valgrind bug in _svcctl_QueryServiceObjectSecurity()

r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it, even if it's smaller than the offered buffer size.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 14:15:47 CEST 2011 on sn-devel-104

12 years agos3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()
Stefan Metzmacher [Thu, 16 Jun 2011 10:34:42 +0000 (12:34 +0200)]
s3:rpc_server/svcctl: fix valgrind bugs in _svcctl_QueryServiceConfig2W()

r->out.buffer needs to stay in its size, as it will be marshalled completely.
As it's preallocated and initialized with zeros, we just need to copy
the payload into it.

If we always marshall the return buffer, we already have the needed
buffer size and don't need to call ndr_size_* functions.

metze

12 years agos3:rpc_server/svcctl: don't allocate return values on a temporary stackframe
Stefan Metzmacher [Thu, 16 Jun 2011 06:33:09 +0000 (08:33 +0200)]
s3:rpc_server/svcctl: don't allocate return values on a temporary stackframe

And always initialize the whole return structure.

This caused samba3.posix_s3.rpc.svcctl to be flakey.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jun 16 11:34:34 CEST 2011 on sn-devel-104

12 years agos4:winbind/wb_samba3_protocol.c - rework it using concrete enum values
Matthias Dieter Wallnöfer [Thu, 16 Jun 2011 07:01:04 +0000 (09:01 +0200)]
s4:winbind/wb_samba3_protocol.c - rework it using concrete enum values

This changes commit 49352cafb4259503e6afb44d38db9bfd525d5e0d to comply
with kblin's plans.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Jun 16 10:14:52 CEST 2011 on sn-devel-104

12 years agos4:ntvfs subsystems - rework it using concrete enum values
Matthias Dieter Wallnöfer [Thu, 16 Jun 2011 06:39:03 +0000 (08:39 +0200)]
s4:ntvfs subsystems - rework it using concrete enum values

This changes commit 260bc987b00b3fff6c9b99211627b14e9bd0789a to comply
with metze's plans.

12 years agoauth/kerberos/gssapi_pac: fix compiler warnings
Stefan Metzmacher [Sat, 30 Apr 2011 15:39:48 +0000 (17:39 +0200)]
auth/kerberos/gssapi_pac: fix compiler warnings

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jun 15 19:06:24 CEST 2011 on sn-devel-104

12 years agos4:libcli/smb_composite: convert smb2_composite_setpathinfo_send/rev to tevent_req
Stefan Metzmacher [Sun, 1 May 2011 16:10:20 +0000 (18:10 +0200)]
s4:libcli/smb_composite: convert smb2_composite_setpathinfo_send/rev to tevent_req

metze

12 years agolibrpc: fix buildwarning in NDR_WMI.
Günther Deschner [Tue, 14 Jun 2011 09:31:43 +0000 (11:31 +0200)]
librpc: fix buildwarning in NDR_WMI.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jun 15 17:23:49 CEST 2011 on sn-devel-104

12 years agos3: Add debug level 0 warnings to make_new_server_info_guest
Volker Lendecke [Wed, 15 Jun 2011 12:08:23 +0000 (14:08 +0200)]
s3: Add debug level 0 warnings to make_new_server_info_guest

I've got a backtrace where this must have failed, but it is not clear why. If
this fails, we should really complain because we can't start up.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jun 15 15:20:49 CEST 2011 on sn-devel-104

12 years agos3: Fix the return of make_new_server_info_guest
Volker Lendecke [Wed, 15 Jun 2011 12:09:50 +0000 (14:09 +0200)]
s3: Fix the return of make_new_server_info_guest

12 years agos3-winbind: Fix paranoia checks in winbindd_samr.c.
Andreas Schneider [Fri, 20 May 2011 13:42:46 +0000 (15:42 +0200)]
s3-winbind: Fix paranoia checks in winbindd_samr.c.

This fixes looking up the correct unix user instead of allocation a new
uid and creating it.

Fix bug #8215 (winbind unix username lookup doesn't work correctly).
(cherry picked from commit 531edfdd1924bfb2ef486820f7f5787098bd953a)

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Jun 15 09:56:01 CEST 2011 on sn-devel-104

12 years agobuild: fixed development symlinks for libraries in subdirectories
Andrew Tridgell [Wed, 15 Jun 2011 04:13:04 +0000 (14:13 +1000)]
build: fixed development symlinks for libraries in subdirectories

this fixes the symlink for libsmbclient.so

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Jun 15 07:23:10 CEST 2011 on sn-devel-104

12 years agobuild: fixed dependencies on install prefix for pc files and python scripts
Andrew Tridgell [Wed, 15 Jun 2011 03:53:19 +0000 (13:53 +1000)]
build: fixed dependencies on install prefix for pc files and python scripts

waf can't automatically determine these dependencies as the
construction of the files is via a python function

thanks to Andrew for noticing this bug

12 years agos3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95...
Stefan Metzmacher [Wed, 15 Jun 2011 00:34:53 +0000 (02:34 +0200)]
s3:utils/net_*registry: use c99 initializers which are supported by old gcc 2.95 compilers (bug #8226)

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jun 15 03:48:41 CEST 2011 on sn-devel-104

12 years agos3: Fix connecting to ctdb as non-root
Volker Lendecke [Tue, 14 Jun 2011 15:52:42 +0000 (17:52 +0200)]
s3: Fix connecting to ctdb as non-root

This is at least one instance which I could identify

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jun 14 19:06:39 CEST 2011 on sn-devel-104

12 years agos3: Fix count_current_connections
Volker Lendecke [Tue, 14 Jun 2011 15:50:41 +0000 (17:50 +0200)]
s3: Fix count_current_connections

"False" is not really a valid return value for "int"..

12 years agos3-docs: Fix a typo found by Samba-JP oota <ribbon@samba.gr.jp>
Volker Lendecke [Tue, 14 Jun 2011 10:53:42 +0000 (12:53 +0200)]
s3-docs: Fix a typo found by Samba-JP oota <ribbon@samba.gr.jp>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jun 14 14:06:22 CEST 2011 on sn-devel-104

12 years agos3-docs: Fix a duplicate list entry
Volker Lendecke [Tue, 14 Jun 2011 10:50:57 +0000 (12:50 +0200)]
s3-docs: Fix a duplicate list entry

Thanks to Samba-JP oota <ribbon@samba.gr.jp>

12 years agos3-utils: fix crash in net cache get
Christian Ambach [Tue, 14 Jun 2011 07:09:07 +0000 (09:09 +0200)]
s3-utils: fix crash in net cache get

free the blob correctly

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue Jun 14 12:01:59 CEST 2011 on sn-devel-104

12 years agosamba-tool: disable validation on removing an empty attribute in dbcheck
Andrew Tridgell [Tue, 14 Jun 2011 06:43:10 +0000 (16:43 +1000)]
samba-tool: disable validation on removing an empty attribute in dbcheck

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Jun 14 10:49:34 CEST 2011 on sn-devel-104

12 years agopyldb: make ldb operations more consistent
Andrew Tridgell [Tue, 14 Jun 2011 06:41:35 +0000 (16:41 +1000)]
pyldb: make ldb operations more consistent

This changes the controls option on ldb operations to be a keyword
argument, which is more consistent with general python
conventions. This also fixes the pydoc output to include the controls
option.

12 years agopyldb: added validate option to ldb.modify()
Andrew Tridgell [Tue, 14 Jun 2011 06:39:49 +0000 (16:39 +1000)]
pyldb: added validate option to ldb.modify()

This allows validation of ldb messages in a ldb modify operation to be
bypassed, by setting validate=False. This is useful in the dbcheck
tool to allow for removing invalid empty attributes from the database

12 years agos3:smbd/quotas: add #include "system/filesys.h" (bug #8224)
Stefan Metzmacher [Tue, 14 Jun 2011 06:27:34 +0000 (08:27 +0200)]
s3:smbd/quotas: add #include "system/filesys.h" (bug #8224)

This should fix the build on FreeBSD

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jun 14 09:38:49 CEST 2011 on sn-devel-104

12 years agos3:proto.h: remove prototypes of error functions moved to common code.
Michael Adam [Sun, 12 Jun 2011 23:56:09 +0000 (01:56 +0200)]
s3:proto.h: remove prototypes of error functions moved to common code.

ntstatus_to_dos, werror_to_ntstatus, ntstatus_to_werror

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Jun 13 03:31:58 CEST 2011 on sn-devel-104

12 years agos3: Use resolve_wins_send/recv in resolve_wins
Volker Lendecke [Fri, 3 Jun 2011 14:11:17 +0000 (16:11 +0200)]
s3: Use resolve_wins_send/recv in resolve_wins

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun 12 18:19:41 CEST 2011 on sn-devel-104

12 years agos3: Add resolve_wins_send/recv
Volker Lendecke [Thu, 2 Jun 2011 12:12:06 +0000 (14:12 +0200)]
s3: Add resolve_wins_send/recv

12 years agos3: Add wins_server_tag_ips()
Volker Lendecke [Sun, 12 Jun 2011 12:07:22 +0000 (14:07 +0200)]
s3: Add wins_server_tag_ips()

For a given tag, return the list of all wins servers

12 years agos3: Add query_wins_list_send/recv
Volker Lendecke [Sat, 14 May 2011 16:24:03 +0000 (18:24 +0200)]
s3: Add query_wins_list_send/recv

12 years agos3: Fix IO_TIMEOUT handling for wins queries
Volker Lendecke [Sun, 12 Jun 2011 13:44:19 +0000 (15:44 +0200)]
s3: Fix IO_TIMEOUT handling for wins queries

12 years agos3: Remove "struct ip_service" from resolve_wins
Volker Lendecke [Fri, 3 Jun 2011 13:49:55 +0000 (15:49 +0200)]
s3: Remove "struct ip_service" from resolve_wins

12 years agonsswitch: Remove some refs to the global winbindd_fd
Volker Lendecke [Sun, 5 Jun 2011 14:39:36 +0000 (16:39 +0200)]
nsswitch: Remove some refs to the global winbindd_fd

12 years agos3-passdb: Implement new pdb trust calls for the default backend
Sumit Bose [Tue, 31 May 2011 13:32:29 +0000 (15:32 +0200)]
s3-passdb: Implement new pdb trust calls for the default backend

Signed-off-by: Simo Sorce <idra@samba.org>
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Sun Jun 12 06:45:25 CEST 2011 on sn-devel-104

12 years agos4:libcli/raw/raw*.c - add unhandled enum values
Matthias Dieter Wallnöfer [Sat, 11 Jun 2011 14:55:16 +0000 (16:55 +0200)]
s4:libcli/raw/raw*.c - add unhandled enum values

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Jun 11 18:46:13 CEST 2011 on sn-devel-104

12 years agos4:torture/ndr/string.c - fix type-punned warning and remove unused variables
Matthias Dieter Wallnöfer [Sat, 11 Jun 2011 13:25:11 +0000 (15:25 +0200)]
s4:torture/ndr/string.c - fix type-punned warning and remove unused variables

Reviewed-by: Jelmer
12 years agos4:ntvfs/smb2/vfs_smb2.c - remove unused variable
Matthias Dieter Wallnöfer [Sat, 11 Jun 2011 13:22:34 +0000 (15:22 +0200)]
s4:ntvfs/smb2/vfs_smb2.c - remove unused variable

Reviewed-by: Jelmer
12 years agos4:auth/ntlm/auth_unix.c - remove unused variables
Matthias Dieter Wallnöfer [Sat, 11 Jun 2011 13:07:50 +0000 (15:07 +0200)]
s4:auth/ntlm/auth_unix.c - remove unused variables

Relicts from commit 323c7445713d17989452b99bbb541248bb2388eb

Reviewed-by: Jelmer
12 years agoRevert "s3:idmap_autorid: add a talloc_stackframe() to idmap_autorid_initialize()"
Michael Adam [Thu, 9 Jun 2011 22:36:38 +0000 (00:36 +0200)]
Revert "s3:idmap_autorid: add a talloc_stackframe() to idmap_autorid_initialize()"

This reverts commit 65490ea4e67bf82cf8fb0b8e4e74047c3f63c509.

This sequence of patches needs to be done differently.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Jun 11 12:55:11 CEST 2011 on sn-devel-104

12 years agoRevert "s3:idmap_autorid: use "idmap config <DOMAIN> : rangesize" instead of "autorid...
Michael Adam [Thu, 9 Jun 2011 22:36:27 +0000 (00:36 +0200)]
Revert "s3:idmap_autorid: use "idmap config <DOMAIN> : rangesize" instead of "autorid:rangesize""

This reverts commit b0b0b625b588057c8c97371934bf21eb1fd985d8.

This sequence of patches needs to be done differently.

12 years agoRevert "s3:idmap_autorid: fail initialization if the domain is not "*""
Michael Adam [Thu, 9 Jun 2011 22:36:17 +0000 (00:36 +0200)]
Revert "s3:idmap_autorid: fail initialization if the domain is not "*""

This reverts commit cd8dc47bf17d2cdb1558dc6ab49320ba12af8f34.

This sequence of patches needs to be done differently.

12 years agos3:registry/reg_parse_internal.c: add copyright information
Michael Adam [Fri, 10 Jun 2011 22:20:57 +0000 (00:20 +0200)]
s3:registry/reg_parse_internal.c: add copyright information

12 years agos3:registry/reg_parse_internal.h: add copyright information
Michael Adam [Fri, 10 Jun 2011 22:20:32 +0000 (00:20 +0200)]
s3:registry/reg_parse_internal.h: add copyright information

12 years agos3-param Remove 'time offset' from smb.conf
Andrew Bartlett [Fri, 10 Jun 2011 23:49:12 +0000 (09:49 +1000)]
s3-param Remove 'time offset' from smb.conf

This strange parameter is apparently very rarely used, and it seems to
me that on modern networks, if clients don't have correct clocks and
DST offsets, that many other things (Kerberos) start to fail pretty
quickly, and time and DST tables tend to be internet delivered anyway.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Jun 11 03:54:45 CEST 2011 on sn-devel-104

12 years agos3: Update .clang_complete
Andreas Schneider [Fri, 10 Jun 2011 21:11:59 +0000 (23:11 +0200)]
s3: Update .clang_complete

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Sat Jun 11 00:40:01 CEST 2011 on sn-devel-104

12 years agos3:libsmb: remove unused cli_state_seqnum infrastructure
Stefan Metzmacher [Thu, 9 Jun 2011 09:59:58 +0000 (11:59 +0200)]
s3:libsmb: remove unused cli_state_seqnum infrastructure

metze

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jun 10 20:37:54 CEST 2011 on sn-devel-104

12 years agos3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit
Stefan Metzmacher [Wed, 8 Jun 2011 17:01:13 +0000 (19:01 +0200)]
s3:libsmb/clireadwrite: calculate cli_write_max_bufsize() correct based on max_xmit

This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.

metze

12 years agos3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit
Stefan Metzmacher [Wed, 8 Jun 2011 16:59:39 +0000 (18:59 +0200)]
s3:libsmb/clireadwrite: calculate cli_read_max_bufsize() correct based on max_xmit

This is important in order to support DCERPC over ncacn_np against NT4 servers,
where max_xmit is just 4356.

metze

12 years agos3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests
Stefan Metzmacher [Thu, 9 Jun 2011 09:57:55 +0000 (11:57 +0200)]
s3:libsmb/clitrans: correctly transfer the seqnum between secondary and primary requests

This is needed to implement SMB signing correct.

metze

12 years agos3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls
Stefan Metzmacher [Wed, 8 Jun 2011 08:31:23 +0000 (10:31 +0200)]
s3:libsmb/clitrans: fix handling of multi pdu [nt]trans[s][2] calls

We now keep the primary request open for the whole logical request.
The primary request is the one that gets all incoming replies.
While secondary requests are handled as separate one-way requests.

metze

12 years agos3:libsmb/clitrans: use subreq2 as variable for the secondary requests
Stefan Metzmacher [Wed, 8 Jun 2011 14:41:11 +0000 (16:41 +0200)]
s3:libsmb/clitrans: use subreq2 as variable for the secondary requests

metze

12 years agos3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment
Stefan Metzmacher [Wed, 8 Jun 2011 14:11:00 +0000 (16:11 +0200)]
s3:libsmb/clitrans: move MID handling to the end of cli_trans_send() and add a comment

metze

12 years agos3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests
Stefan Metzmacher [Tue, 7 Jun 2011 22:44:34 +0000 (00:44 +0200)]
s3:libsmb/clitrans: correctly marshall [nt]trans[s][2] requests

We need to align params and data to 4 byte offsets.

This also correctly recalculates the useable space after each step.

metze

12 years agos3:libsmb/clitrans: marshall SMBnttrans[2] as the others
Stefan Metzmacher [Thu, 9 Jun 2011 10:22:59 +0000 (12:22 +0200)]
s3:libsmb/clitrans: marshall SMBnttrans[2] as the others

This is just to make the code more readable
and easier to notice how many words we're using in vwv.

metze

12 years agos3:libsmb/clitrans: use uint32_t for param and data variables
Stefan Metzmacher [Wed, 8 Jun 2011 15:08:00 +0000 (17:08 +0200)]
s3:libsmb/clitrans: use uint32_t for param and data variables

SMBnttrans uses 32-bit values there.

metze

12 years agos3:libsmb/clitrans: remove unused secondary_request_ctx
Stefan Metzmacher [Tue, 7 Jun 2011 22:37:24 +0000 (00:37 +0200)]
s3:libsmb/clitrans: remove unused secondary_request_ctx

metze

12 years agos3:libsmb/async_smb: add helpers to get and set the seqnum for signing
Stefan Metzmacher [Thu, 9 Jun 2011 09:49:48 +0000 (11:49 +0200)]
s3:libsmb/async_smb: add helpers to get and set the seqnum for signing

This will be used for correct signing in [nt]trans[2][s] requests.

metze

12 years agos3:libsmb/async_smb: don't remove pending requests if the mid is set
Stefan Metzmacher [Wed, 8 Jun 2011 08:20:25 +0000 (10:20 +0200)]
s3:libsmb/async_smb: don't remove pending requests if the mid is set

If the mid was set explicitly, it means the request expects more than
one reply, so leave it in the pending array.

metze

12 years agos3:libsmb/async_smb: call cli_smb_req_unset_pending() instead of destructor directly
Stefan Metzmacher [Wed, 8 Jun 2011 12:14:24 +0000 (14:14 +0200)]
s3:libsmb/async_smb: call cli_smb_req_unset_pending() instead of destructor directly

metze

12 years agos3:libsmb/async_smb: let cli_smb_recv() initialize output values for one way requests
Stefan Metzmacher [Tue, 7 Jun 2011 22:40:54 +0000 (00:40 +0200)]
s3:libsmb/async_smb: let cli_smb_recv() initialize output values for one way requests

metze

12 years agoBump the smbd vfs interface version to 29. Samba 3.6.0 will ship
Jeremy Allison [Wed, 1 Jun 2011 04:03:22 +0000 (21:03 -0700)]
Bump the smbd vfs interface version to 29. Samba 3.6.0 will ship
with interface 28.

12 years agos3:net conf addshare: do not stat-check the share path.
Michael Adam [Fri, 10 Jun 2011 11:51:06 +0000 (13:51 +0200)]
s3:net conf addshare: do not stat-check the share path.

Allow paths with % macros and paths that do not (yet...) exist.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jun 10 17:38:07 CEST 2011 on sn-devel-104

12 years agosource3/rpc_client/util_netlogon.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:08:17 +0000 (15:08 +0200)]
source3/rpc_client/util_netlogon.h: fix licence/copyright

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jun 10 16:27:24 CEST 2011 on sn-devel-104

12 years agosource3/rpc_client/init_spoolss.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:08:07 +0000 (15:08 +0200)]
source3/rpc_client/init_spoolss.h: fix licence/copyright

Guenther

12 years agosource3/rpc_client/init_samr.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:57 +0000 (15:07 +0200)]
source3/rpc_client/init_samr.h: fix licence/copyright

Guenther

12 years agosource3/rpc_client/init_netlogon.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:48 +0000 (15:07 +0200)]
source3/rpc_client/init_netlogon.h: fix licence/copyright

Guenther

12 years agosource3/rpc_client/init_lsa.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:39 +0000 (15:07 +0200)]
source3/rpc_client/init_lsa.h: fix licence/copyright

Guenther

12 years agosource3/rpc_client/cli_spoolss.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:27 +0000 (15:07 +0200)]
source3/rpc_client/cli_spoolss.h: fix licence/copyright

Guenther

12 years agosource3/rpc_client/cli_netlogon.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:16 +0000 (15:07 +0200)]
source3/rpc_client/cli_netlogon.h: fix licence/copyright

Guenther

12 years agosource3/printing/pcap.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:07:03 +0000 (15:07 +0200)]
source3/printing/pcap.h: fix licence/copyright

Guenther

12 years agosource3/printing/load.h: fix licence/copyright
Günther Deschner [Fri, 10 Jun 2011 13:06:49 +0000 (15:06 +0200)]
source3/printing/load.h: fix licence/copyright

Guenther