22 years agocatch signals in the async dns daemon and allow it to auto-restart if
Andrew Tridgell [Thu, 4 Dec 1997 10:58:40 +0000 (10:58 +0000)]
catch signals in the async dns daemon and allow it to auto-restart if
(This used to be commit fa599067f074647a5bad2ffd0fce12ae0a4e43d2)

22 years agoallow for zero size reads in asyncdns. These can happen after a signal
Andrew Tridgell [Thu, 4 Dec 1997 08:10:49 +0000 (08:10 +0000)]
allow for zero size reads in asyncdns. These can happen after a signal
(This used to be commit 8bac91a6e7a3601b093cb64e9cb3bcc1663fb4d4)

22 years agogot rid of the WRAP_MALLOC code - mem_man does it better
Andrew Tridgell [Thu, 4 Dec 1997 07:49:37 +0000 (07:49 +0000)]
got rid of the WRAP_MALLOC code - mem_man does it better
(This used to be commit d9bb3a4eba9c630370fea0fa297b176fd2afb532)

22 years agoadded optonal MEM_MAN code
Andrew Tridgell [Thu, 4 Dec 1997 07:48:06 +0000 (07:48 +0000)]
added optonal MEM_MAN code
(This used to be commit b524c8da5141e3e030e14b3a0167fa5c7ae91396)

22 years agodon't use free and alloc as structure elements
Andrew Tridgell [Thu, 4 Dec 1997 07:41:48 +0000 (07:41 +0000)]
don't use free and alloc as structure elements
(This used to be commit f7066355b00a169423b4f64f58567e19b52abc1b)

22 years agoMakefile.lib does nothing, so remove it
Andrew Tridgell [Wed, 3 Dec 1997 14:17:38 +0000 (14:17 +0000)]
Makefile.lib does nothing, so remove it
(This used to be commit 4800a02a92d9451d3bd51e7b9e366e4e60a3789e)

22 years agoslight cleanup to the linked list handling
Andrew Tridgell [Wed, 3 Dec 1997 05:54:51 +0000 (05:54 +0000)]
slight cleanup to the linked list handling
(This used to be commit 97b62b347648411d034ab91845ae607eca4dfad6)

22 years agoput the default PRINTCAP_NAME def in includes.h not local.h so that
Andrew Tridgell [Wed, 3 Dec 1997 05:22:24 +0000 (05:22 +0000)]
put the default PRINTCAP_NAME def in includes.h not local.h so that
it can see the SYSV definitions
(This used to be commit e439115366804982af6faba75714dbe2626edead)

22 years agoapplied a patch from Norm Jacobs to allow "printcap name = lpstat"
Andrew Tridgell [Wed, 3 Dec 1997 05:08:07 +0000 (05:08 +0000)]
applied a patch from Norm Jacobs to allow "printcap name = lpstat"
to use lpstat to obtain the printer list on systemV systems.

I've now made this the default on all SYSV systems.

Jeremy, you were a little worried about the security of this patch. I
believe it's OK as the user has no control over the options given to
popen() and the pipe is only open for reading.
(This used to be commit 6a83de0ae954bb18d3f15382f2b0b3259fedff09)

22 years agochange the "username map" option to allow the user to stop the
Andrew Tridgell [Wed, 3 Dec 1997 04:20:39 +0000 (04:20 +0000)]
change the "username map" option to allow the user to stop the
processing part way through the file if a match is found. If a line
starts with ! and a match is made by that line then processing
stops. This allows better wildcard handling.

(patch from Anselm.Kruis@Physik.Uni-Muenchen.DE)
(This used to be commit af57bc05fe0f248aaef329358c583abcffe1657c)

22 years agoallow local_machine and remote_machine (%L and %m macros) to contain
Andrew Tridgell [Wed, 3 Dec 1997 03:57:29 +0000 (03:57 +0000)]
allow local_machine and remote_machine (%L and %m macros) to contain
(This used to be commit 93f0619e049d1598db0c3022aeccf33910b0550f)

22 years agoloadparm.c: Added lp_we_are_a_wins_server as an alias for lp_wins_support.
Jeremy Allison [Wed, 3 Dec 1997 03:50:05 +0000 (03:50 +0000)]
loadparm.c: Added lp_we_are_a_wins_server as an alias for lp_wins_support.
Used by the new nmbd and just makes more sense :-).
(This used to be commit 7a2a45eae2e9a930d3243498d4e66cc2f5e4d370)

22 years agoadd a warning if the timezone is not a multiple of 1 minute. This
Andrew Tridgell [Wed, 3 Dec 1997 03:46:43 +0000 (03:46 +0000)]
add a warning if the timezone is not a multiple of 1 minute. This
should catch broken timezone files in slackware linux.
(This used to be commit ce37bd9dcaeaf0c5e97845954342762ebaf43b10)

22 years agoallow users to disable the NetWkstaUserLogon call in server level
Andrew Tridgell [Wed, 3 Dec 1997 03:43:05 +0000 (03:43 +0000)]
allow users to disable the NetWkstaUserLogon call in server level
security by changing a setting in local.h or adding it to their
Makefile. See comment in local.h
(This used to be commit cc10fdf7583ec644850445ad96afd8b22b71e86f)

22 years agomake the "printing" option a per share option rather than global. When
Andrew Tridgell [Wed, 3 Dec 1997 03:37:02 +0000 (03:37 +0000)]
make the "printing" option a per share option rather than global. When
printing to lots of different sorts of remote printers this is useful
(This used to be commit 7a88bed4a5ca8afe1f2836f7f9a019db01bf998e)

22 years agoI'm slowly getting though the todo list :-)
Andrew Tridgell [Wed, 3 Dec 1997 03:21:25 +0000 (03:21 +0000)]
I'm slowly getting though the todo list :-)

This change allows people to select the SYSLOG_FACILITY in local.h, or
add it to the Makefile if they want to.
(This used to be commit afe88facbfb85113105bf516e066b6c1e971f6b7)

22 years agohopefully handle "ready and waiting" messages in print queue output a
Andrew Tridgell [Wed, 3 Dec 1997 03:00:49 +0000 (03:00 +0000)]
hopefully handle "ready and waiting" messages in print queue output a
little better
(This used to be commit 465edceecf86cafd225e5662b01242f87f0bd603)

22 years agofix toupper(c) on a already uppercase char and tolower(c) on an
Andrew Tridgell [Wed, 3 Dec 1997 02:27:50 +0000 (02:27 +0000)]
fix toupper(c) on a already uppercase char and tolower(c) on an
already lowercase char when using code pages. Jeremy, can you confirm
that this looks right?  It comes from PR#1992
(This used to be commit 157fde339695d3185ecf857187e981edd06a8b65)

22 years agofixed the help message for -p (someone complained!)
Andrew Tridgell [Tue, 2 Dec 1997 23:32:03 +0000 (23:32 +0000)]
fixed the help message for -p (someone complained!)
(This used to be commit c779ed654ec7d9f1fc870476a05d2294e8c0faea)

22 years agoadd the null string to SMBsetatr calls
Andrew Tridgell [Tue, 2 Dec 1997 23:30:43 +0000 (23:30 +0000)]
add the null string to SMBsetatr calls
(This used to be commit fbb2be050ded099741345a101ba13e6b12ebc823)

22 years agochanging the comment in find_new_file() to say why a base of 1 is used
Andrew Tridgell [Tue, 2 Dec 1997 23:29:57 +0000 (23:29 +0000)]
changing the comment in find_new_file() to say why a base of 1 is used
(This used to be commit 2b0f3fd14908411472be032ad09144cb71c55479)

22 years agothe default GUEST_ACCOUNT should be here not in smb.h
Andrew Tridgell [Tue, 2 Dec 1997 23:28:14 +0000 (23:28 +0000)]
the default GUEST_ACCOUNT should be here not in smb.h
(This used to be commit 13c2f432d61381a055378d303dfc8806ea4eea42)

22 years agoHPUX trusted systems need to use bigcrypt() not crypt()
Andrew Tridgell [Tue, 2 Dec 1997 23:27:40 +0000 (23:27 +0000)]
HPUX trusted systems need to use bigcrypt() not crypt()
(This used to be commit 979eaf9e9c4dd58f1371597585d4cd64841febd0)

22 years agoget rid of some things out of smb.h that are already in local.h
Andrew Tridgell [Tue, 2 Dec 1997 23:26:42 +0000 (23:26 +0000)]
get rid of some things out of smb.h that are already in local.h
(This used to be commit d55df52487ca6786f1635276b2787857a772219a)

22 years agodont try getpeername() when Client isn't initialised
Andrew Tridgell [Tue, 2 Dec 1997 23:24:26 +0000 (23:24 +0000)]
dont try getpeername() when Client isn't initialised
(This used to be commit a32ca542ad294ecc3848ca511337a8cc994d67be)

22 years agoDocumented the 'veto oplock files' parameter.
Jeremy Allison [Tue, 2 Dec 1997 19:55:44 +0000 (19:55 +0000)]
Documented the 'veto oplock files' parameter.
(This used to be commit 0263f333f22d2f7f90a155ff19915ff58929bba0)

22 years agoasyncdns.c: Removed warning when compiling with -DSYNC_DNS.
Jeremy Allison [Tue, 2 Dec 1997 19:00:18 +0000 (19:00 +0000)]
asyncdns.c: Removed warning when compiling with -DSYNC_DNS.
nameelect.c: Tidied up settings of work->ServerType when unbecoming things.
nmbd.c: Fixed pidFile warning.
server.c: Fixed pidFile warning.
(This used to be commit 94d53dcac5d06e48be5cea9d54625da795f62d20)

22 years agofix for systems that don't have PWD environment variable defined
Herb Lewis [Mon, 1 Dec 1997 22:49:09 +0000 (22:49 +0000)]
fix for systems that don't have PWD environment variable defined
(This used to be commit f67e21f73ffa3bbb1f3bffae709219c86be236f6)

22 years agoremove stutter from closing instructions
Herb Lewis [Mon, 1 Dec 1997 15:21:23 +0000 (15:21 +0000)]
remove stutter from closing instructions
(This used to be commit 358fcbf2e4ca274d7ef34e3cac0bc7fd72732ec5)

22 years agodded error checking to scripts
Herb Lewis [Mon, 1 Dec 1997 14:50:52 +0000 (14:50 +0000)]
dded error checking to scripts
(This used to be commit b7e1265f106010e03d92575f4578162ec659994b)

22 years agothe logon script example should use %U.bat not %u.bat
Andrew Tridgell [Sun, 30 Nov 1997 05:46:33 +0000 (05:46 +0000)]
the logon script example should use %U.bat not %u.bat
(This used to be commit e57275dd193d648458293b25f0cc3c7179f26536)

22 years agoclientgen.c: Added cli_mv() (used in a recent torture test).
Jeremy Allison [Sun, 30 Nov 1997 02:58:34 +0000 (02:58 +0000)]
clientgen.c: Added cli_mv() (used in a recent torture test).
reply.c: Changed reply_open_and_X to split out the oplock
request bits from core and extended and if an oplock was granted only set
the corresponding bit on reply.
server.c: Added code to dynamically allocate i/o buffers in oplock_break
(prevents recursion problems) , also made reset of sent_oplock_break
(This used to be commit 16e55ee2b8be9a4210d8cf87691cdf42373759d2)

22 years agodon't display locks for dead processes in smbstatus
Andrew Tridgell [Sat, 29 Nov 1997 13:35:09 +0000 (13:35 +0000)]
don't display locks for dead processes in smbstatus
(This used to be commit c7df484ef6d746fb1f5b53007ee04fa54e5f2223)

22 years agouse -1 not 0xffffffff in SIVALS() macros
Andrew Tridgell [Sat, 29 Nov 1997 13:29:13 +0000 (13:29 +0000)]
use -1 not 0xffffffff in SIVALS() macros

use the same process_exists() code on all systems (it's probably
faster anyway)
(This used to be commit 901b95aa77ac1ecc45823c23fb4e1d9da8dc8318)

22 years agoadded a sent_oplock_break element to Files[] as a paranoia check so we
Andrew Tridgell [Sat, 29 Nov 1997 02:40:31 +0000 (02:40 +0000)]
added a sent_oplock_break element to Files[] as a paranoia check so we
can't sent a oplock break twice on the same file.

changed some debug levels in the oplock code to level 0 so we can
track down a bug

zero the returned Files[] entry in find_free_file()

don't try to overcome client bugs in the handling of non-encrypted
passwords if in server level security mode

added paranoid null termination of password buffers

slight change to my ajt_panic() routine
(This used to be commit e360c79c9cec681c4609783019749773d3e79386)

22 years agopass the mailslot name to process_logon_packet()
Andrew Tridgell [Fri, 28 Nov 1997 05:52:31 +0000 (05:52 +0000)]
pass the mailslot name to process_logon_packet()

- fixed process_logon_packet() to always send the reply to/from the
correct netbios name (it should match the query)

- only do a NT style QUERYFORPDC if the query came in on a

Luke, can you check to see if these changes work in your branch with
NT logons?
(This used to be commit e89611985b35155770648c8f16ddd19acfb5ee13)

22 years agoget_entries is an int not a bool
Andrew Tridgell [Fri, 28 Nov 1997 05:48:48 +0000 (05:48 +0000)]
get_entries is an int not a bool
(This used to be commit 84215c9b91f3c5130b172a3bbc83c7ddd66c5cb8)

22 years agopreparing for release of 1.9.18alpha12
Samba Release Account [Fri, 28 Nov 1997 03:46:03 +0000 (03:46 +0000)]
preparing for release of 1.9.18alpha12
(This used to be commit 9cac33a13dc7c4890628436b80f6cbd8361deab2)

22 years agothere was a bug in my oplock bugfix :-)
Andrew Tridgell [Fri, 28 Nov 1997 03:39:04 +0000 (03:39 +0000)]
there was a bug in my oplock bugfix :-)

It's fixed properly now :-)
(This used to be commit a6a04b5c6cd35e4b5f4dd4522775961e6315c658)

22 years agofixed a very nasty oplock bug. We could send oplock break requests on
Andrew Tridgell [Fri, 28 Nov 1997 03:30:24 +0000 (03:30 +0000)]
fixed a very nasty oplock bug. We could send oplock break requests on
files that aren't open if the file happened to close while the oplock
was in transit. We would end up sending a oplock break request on
another random file (actually the open file that happened to have the
highest fnum). Then we wouldn't get a response, so smbd would keep
sending and would actually flood the net with an infinite number of
oplock break requests!
(This used to be commit 0da20e0aecbf3e59bdc649c489a18832403dc9b2)

22 years agooh no! my favourite hack is broken. You can't do:
Andrew Tridgell [Wed, 26 Nov 1997 23:43:06 +0000 (23:43 +0000)]
oh no! my favourite hack is broken. You can't do:

path = %H

to get a new homes area. I wonder when it broke?

Anyway, I've fixed it. We can all rest easy now, knowing that you
really can produce an incomprehensible smb.conf and get it to work.
(This used to be commit 2245da4ad6674aa373e3057c661f5bc0315e191f)

22 years agoget rid of stat command (it is a hangover from an old experiment)
Andrew Tridgell [Tue, 25 Nov 1997 12:20:55 +0000 (12:20 +0000)]
get rid of stat command (it is a hangover from an old experiment)
(This used to be commit 8ced76c4c71c67c54bf0deedff5a7adfca04e4f3)

22 years agoRemind them to read the man page about needing to be root.
Dan Shearer [Mon, 24 Nov 1997 19:10:40 +0000 (19:10 +0000)]
Remind them to read the man page about needing to be root.
(This used to be commit 9ccd76e64d396c5c7f1da7346196476ca9a21eb8)

22 years agoadded cli_rmdir and cli_mkdir
Andrew Tridgell [Mon, 24 Nov 1997 13:44:52 +0000 (13:44 +0000)]
added cli_rmdir and cli_mkdir

added test in smbtorture for the server updating the directory modify
time when a file is added to a directory

cleanup in smbtorture so no garbage files are left on the server
(This used to be commit 3a5e07f1e994396853e6340e8ef3f4d12bb0243e)

22 years agoadded a SMB_QUERY_FILE_ALL_INFO test into smbtorture
Andrew Tridgell [Sun, 23 Nov 1997 07:26:42 +0000 (07:26 +0000)]
added a SMB_QUERY_FILE_ALL_INFO test into smbtorture

W95 doesn't seem to support this call.
(This used to be commit 162947c6e672580216c6223a44d25b874f0487ab)

22 years agoadded some QPATHINFO and QFILEINFO tests into smbtorture.
Andrew Tridgell [Sun, 23 Nov 1997 05:55:44 +0000 (05:55 +0000)]
added some QPATHINFO and QFILEINFO tests into smbtorture.

This tests for things like midnight access times, sticky create times
and word reversed INFO_STANDARD returns
(This used to be commit 89141de14edf9e46ab279d2a74a9b026716a0ba8)

22 years agotest SMBsetatr as well
Andrew Tridgell [Sun, 23 Nov 1997 03:09:59 +0000 (03:09 +0000)]
test SMBsetatr as well
(This used to be commit 2f29c24ba721e417828efca57011ed45892191a5)

22 years agominor wsmbconf and cgi changes
Andrew Tridgell [Sun, 23 Nov 1997 02:42:22 +0000 (02:42 +0000)]
minor wsmbconf and cgi changes
(This used to be commit bca9c49e6f24c2ee79cbb9b6ebf69d6647146fc1)

22 years agoadded a test for the NT SMBgetatr bug in smbtorture
Andrew Tridgell [Sun, 23 Nov 1997 02:41:22 +0000 (02:41 +0000)]
added a test for the NT SMBgetatr bug in smbtorture

added support for choosing the protocol level in smbtorture (-m option)

use -1 for null date in cli_close()

get the attributes right in cli_open()
(This used to be commit d64d40a6ec57a4a999ae1f39175bcfd86ccb196e)

22 years agothis new cgi code includes the ability to act as a mini web server,
Andrew Tridgell [Sat, 22 Nov 1997 07:51:23 +0000 (07:51 +0000)]
this new cgi code includes the ability to act as a mini web server,
allowing people to use web configuration of Samba without installing a
web server
(This used to be commit b4e05c360e77cbf27a95920b613bfe6bc874ea1b)

22 years agofixed some typecasts of (char *) to (unsigned char *)
Andrew Tridgell [Sat, 22 Nov 1997 07:17:32 +0000 (07:17 +0000)]
fixed some typecasts of (char *) to (unsigned char *)
(This used to be commit c98ba8c748bd852ff609cec5510cd5a013f51fd2)

22 years agothe usual :-)
Andrew Tridgell [Sat, 22 Nov 1997 07:10:22 +0000 (07:10 +0000)]
the usual :-)
(This used to be commit d6467d44b14f4bc683b839d520b4df38719bf2c0)

22 years agoadded true enumerated types in loadparm.c. Now we don't need all those
Andrew Tridgell [Sat, 22 Nov 1997 07:09:12 +0000 (07:09 +0000)]
added true enumerated types in loadparm.c. Now we don't need all those
"interpret_security" and similar functions. This also means that
testparm produces string values for these enumerated types rather than
an integer. This was done to make the web interface much cleaner.

While I was doing this I found a couple of very nasty bugs in the
parm_table code. Someone had added a handle_character_set() function
that treated the char** pointer for a P_STRING as an integer! This
would have caused memory corruption for anyone using the "character
set" option. The loadparm code is delicate - please be careful about
using it's more esoteric features!

I've also removed the "coding system" global and made it a
P_STRING. The integer value was never used anywhere in Samba.
(This used to be commit bac6b0daa288e879330e3d585582122bb93a1ffb)

22 years agoJust fixed a *serious* bug in nameelect.c to do with local
Jeremy Allison [Fri, 21 Nov 1997 21:06:40 +0000 (21:06 +0000)]
Just fixed a *serious* bug in nameelect.c to do with local
master browsers. Once we have become a local master, we would
*NEVER* stop announcing ourselves as such. This has serious
implications for the new nmbd code.
(This used to be commit 8e8d239d9e112bf1eb32f4ec1657ff505a34d934)

22 years agoAdded in mods for new smb.conf "remote browse sync" option as posted to
John Terpstra [Fri, 21 Nov 1997 14:01:23 +0000 (14:01 +0000)]
Added in mods for new smb.conf "remote browse sync" option as posted to
the samba-1.9.17 tree moments ago.
(This used to be commit 2ee25cd117a116d0304960780d6c197f39d25a3d)

22 years agouse LocTimeDiff() not TimeDiff() to ensure that longdate conversion is
Andrew Tridgell [Fri, 21 Nov 1997 04:57:37 +0000 (04:57 +0000)]
use LocTimeDiff() not TimeDiff() to ensure that longdate conversion is
consistent (this is really just a cosmetic change)
(This used to be commit 30b84bb68bfbfb022decc36c1b4869a39a06e556)

22 years agoadded some debug lines to the rename code
Andrew Tridgell [Thu, 20 Nov 1997 01:36:36 +0000 (01:36 +0000)]
added some debug lines to the rename code
(This used to be commit ee3042eefb47bbdbefc83ab3f0f407c7dea4d8a0)

22 years agochanged nmblookup to only set recursion_desired in queries if the -R
Andrew Tridgell [Wed, 19 Nov 1997 23:50:02 +0000 (23:50 +0000)]
changed nmblookup to only set recursion_desired in queries if the -R
option is used.
(This used to be commit 4561b8242e12c63401d008e7fdb2442457bd366d)

22 years agofixed typo
Andrew Tridgell [Wed, 19 Nov 1997 04:12:37 +0000 (04:12 +0000)]
fixed typo
(This used to be commit 02721a9f1be6aed11a68b70c910056f054c64f67)

22 years agoipc.c: Changed reply_trans to use receive_next_smb() to cope
Jeremy Allison [Tue, 18 Nov 1997 23:30:49 +0000 (23:30 +0000)]
ipc.c: Changed reply_trans to use receive_next_smb() to cope
       with local message processing.
reply.c: Added check to reply_lockingX for chain after oplock break.
server.c: Added receive_next_smb().
trans2.c: Changed reply_trans2 to use receive_next_smb() to cope
       with local message processing.
(This used to be commit f4ae644e13f2c4479dfc94c77c0a8295edf54086)

22 years agodon't do the mapping for group names if the name type
Andrew Tridgell [Tue, 18 Nov 1997 04:12:54 +0000 (04:12 +0000)]
don't do the mapping for group names if the name type
is 0x1c. This allows remote logon servers when using a Samba WINS server.

I did some experiments with a real NT WINS server and this behaviour
is much closer to being correct. It will only be totally correct when
we add proper group name support.
(This used to be commit c43b7e29baea84e18b07f2d8bfdb2628b86fd59c)

22 years agoloadparm.c : Added "veto oplock files" parameter.
Jeremy Allison [Mon, 17 Nov 1997 19:16:38 +0000 (19:16 +0000)]
loadparm.c : Added "veto oplock files" parameter.
make_printerdef.c: Fixed warning.
quotas.c: Fixed irix root errors.
server.c: Fixed oplock reference count bug.
smb.h: Added IS_VETO_OPLOCK_PATH().
(This used to be commit c28487df63e29bc0f8d2ece876a07a2a076d4c73)

22 years agoadded code to test the cli_NetServerEnum() function in clientgen.c
Andrew Tridgell [Tue, 11 Nov 1997 02:51:20 +0000 (02:51 +0000)]
added code to test the cli_NetServerEnum() function in clientgen.c
(This used to be commit 4933ba49b55a9a438b006c977c7ab6f5960065a3)

22 years agofixed a bug which caused nmbd to core dump. The problem was incorrect
Andrew Tridgell [Tue, 11 Nov 1997 02:38:54 +0000 (02:38 +0000)]
fixed a bug which caused nmbd to core dump.  The problem was incorrect
parameters to cli_NetServerEnum()
(This used to be commit 628d5895aa8a6add1a76bcf2561d01881b7c8c63)

22 years agoLeft global_oplock_break set while request to break oplock is
Jeremy Allison [Tue, 11 Nov 1997 01:19:32 +0000 (01:19 +0000)]
Left global_oplock_break set while request to break oplock is
outstanding to client. Done to allay Andrews' fears about
readbraw crossing on the wire :-).
(This used to be commit 2fe8a730d9eeadca22ed1424014181e193ce3d52)

22 years agoauto-create the locks directory on startup
Andrew Tridgell [Tue, 11 Nov 1997 00:48:42 +0000 (00:48 +0000)]
auto-create the locks directory on startup
(This used to be commit a0ab8fe54c27d9f25266c5abfd60458827500dfd)

22 years agoRemoved pwd_validate.c as no longer in main branch.
Jeremy Allison [Mon, 10 Nov 1997 19:38:17 +0000 (19:38 +0000)]
Removed pwd_validate.c as no longer in main branch.
(This used to be commit 5a4a936b2c1eb6659980c69f6d05b45b14e63735)

22 years agoRolled back tree state to 11:59pm 8th November 1997 EST to
Jeremy Allison [Mon, 10 Nov 1997 19:23:17 +0000 (19:23 +0000)]
Rolled back tree state to 11:59pm 8th November 1997 EST to
remove problems.
(This used to be commit 4a36ac236c2ad634f05efcd0179875d09988614a)

22 years agobyteorder.h :
Luke Leighton [Sun, 9 Nov 1997 20:42:47 +0000 (20:42 +0000)]
byteorder.h :

typecasting for the debug messages of the data dump.  hm.


ntclient.c rpc_pipes/lsaparse.c rpc_pipes/ntclientnet.c rpc_pipes/smbparse.c :

adding "Net Server Password Set" functionality to smbclient.

(This used to be commit ad43183d2dd62a808c9fba03f81562362d4de713)

22 years agoattempting to mark up 32 bit error codes, needed for NT domains.
Luke Leighton [Sun, 9 Nov 1997 17:30:10 +0000 (17:30 +0000)]
attempting to mark up 32 bit error codes, needed for NT domains.
separated out smb server-mode password validation into a separate file.
added called and calling netbios names to client gen state: referenced
section in rfc1002.txt.
created workstation trust account checking code in ntclient.c

there might be a bug in reply_session_setup_andX.  i indented and added { }
around single-line if statements: the lm password checking code now doesn't
look right (around the GUEST_SESSSETUP bits).  *no code semantics have been
changed by the indentation process*.
(This used to be commit f27966957fa7f16d337a4a58719239d036deab4c)

22 years agomod_smbpasswd() was junking the smbpasswd file...
Luke Leighton [Sat, 8 Nov 1997 14:23:49 +0000 (14:23 +0000)]
mod_smbpasswd() was junking the smbpasswd file...
uninitialised variable warnings.
(This used to be commit 1b0bd98bb3bfd3d8cd02e8983e825199e839ec05)

22 years agoa few more tests added, including one that tests whether the server
Andrew Tridgell [Sat, 8 Nov 1997 05:33:45 +0000 (05:33 +0000)]
a few more tests added, including one that tests whether the server
understand the full range of byte offsets in locking requests. Samba
doesn't (due to the 31 bit limitation in fcntl locking)
(This used to be commit af1f408a05a42a7ec5c2f4cc5b67c08b3c6cf61f)

22 years agoadded two more sets of tests to the smbtorture test. The tests I added
Andrew Tridgell [Sat, 8 Nov 1997 04:02:05 +0000 (04:02 +0000)]
added two more sets of tests to the smbtorture test. The tests I added
are ones that I know Samba fails. They are:

  1) correct support for retaining locks over a close (ie. the server
     must not use posix semantics)
  2) support for lock timeouts
  3) the server supports multiple locking contexts on the one SMB
  connection, distinguished by PID.
  4) the server correctly fails overlapping locks made by the same PID (this
     goes against POSIX behaviour, which is why it is tricky to implement)
  5) the server denies unlock requests by an incorrect client PID

I've been discussing with Jeremy ways that we can re-implement the
locking code to handle these correctly. This test code will be useful
to see that we have got it right.
(This used to be commit 097781e2992f12c545170c82ada2f4023a9784f5)

22 years agolocal time discrepancies between the date on my computer and the date on
Luke Leighton [Fri, 7 Nov 1997 03:37:18 +0000 (03:37 +0000)]
local time discrepancies between the date on my computer and the date on
chris' computer (probably about four minutes) meant that chris' commits
didn't get downloaded when i did a cvs update.

therefore, i did a cvs update; make proto; cvs commit, and still got problems.

so, five minutes later, i do a cvs update, and _then_ chris' server.c and
mangle.c mods get downloaded, and i have to do another make proto.

this particular problem has hit us *really* badly in the past, because i
was taking files home (onto a portable that i hadn't reset the time on
since i went to the states) and then recopying them back onto the computer
here.  if i do this, i do a touch *.c *.h; cvs -t update.  *then* a cvs commit.
(This used to be commit edb9c52948159baa48d9decd253a401737bd5363)

22 years agoipc.c :
Luke Leighton [Fri, 7 Nov 1997 03:28:43 +0000 (03:28 +0000)]
ipc.c :

added a #define around the alignment thing: it's a way to stop
NetMonitor from decoding your packets!!!!

proto.h :


reply.c :

added what i believe to be the correct error messages for getting
correct domain joining.

smb.h :

some guesses at good names of the SAMR_XXXX functions.  sorting
out the SAMR_LOOKUP_RIDS function.  this is *not* the same as
the LSA_LOOKUP_RIDS function, unless paul accidentally put it
on the ntlsa pipe by mistake, instead of the samr pipe :-)

rpc_pipes/lsa_hnd.c rpc_pipes/pipe_hnd.c :

moved creation and allocation of unique policy handles into this module.

rpc_pipes/pipesamr.c rpc_pipes/samrparse.c rpc_pipes/smbparse.c :

SAMR_LOOKUP_RIDS is beginning to look _suspiciously_ like the
LSA_LOOKUP_RIDS function.  but i know that there are subtle
(This used to be commit 6bc07b0b4193e28b13a675fece8d9d6b365a7eb0)

22 years agoModified Files:
Christopher R. Hertel [Fri, 7 Nov 1997 03:06:24 +0000 (03:06 +0000)]
Modified Files:
mangle.c server.c proto.h

  I am planning to replace the mangled_stack array with a proper stack,
  but found many style inconsistencies (no, really).  As you might expect,
  I have standardized on my own preferences.  ;)

  I also found a potential problem in create_mangled_stack (which I've
  renamed as reset_mangled_stack).  If the stack size were passed into
  the function as 0 or less, there was the possibility that the array
  would have been freed twice.  I doubt that this ever happens, but I
  don't like to leave holes.

  Of course, the fix will be irrelevent once I replace the array with
  a linked-list-based stack.

  Changed the call to create_mangled_stack() to a call to reset_mangled_stack().

  Regenerated to match the above changes.  (A real comment!  How unusual!)
(This used to be commit 34d1b3e4fa7a1158f3a3c5c47adf0417c7144095)

22 years agoipc.c: Changing back arbitrary alignment change until I know *why*
Jeremy Allison [Thu, 6 Nov 1997 23:34:51 +0000 (23:34 +0000)]
ipc.c: Changing back arbitrary alignment change until I know *why*
luke changed it.
proto.h: The usual.
uid.c: Fix crash bug when attaching with smbclient -mCORE. A vuid
pointer was being used when it was null.
(This used to be commit ff94f97cf2b0f62cbbddbfd3d126df7f4d649334)

22 years agofollowing a cvs error, i am rewriting this monster-commit. with bad grace.
Luke Leighton [Thu, 6 Nov 1997 23:03:58 +0000 (23:03 +0000)]
following a cvs error, i am rewriting this monster-commit.  with bad grace.

Modified Files:


adding extra files

ipc.c :

send_trans_reply() - alignment issue.  this makes the alignment
the same as that in NT.  this should be looked at by people who
understand the SMB stuff better than i.

api_fd_commands[] - added samr and wkssvc pipes.

loadparm.c :

lp_domain_controller() changed to mean "samba is a domain controller".
it's a "yes/no" parameter, now.  no, it isn't used _anywhere_.

namedbwork.c nameelect.c :

if "domain controller = yes" then add SV_TYPE_DOMAIN_CTRL to the
host _and_ workgroup announcements.  yes, you must do both: nt does.

namelogon.c :

important NETLOGON bug in SAMLOGON request parsing, which may be
the source of some people's problems with logging on to the Samba PDC.

password.c :

get_smbpwnam() renamed to get_smbpwd_entry().

pipes.c :

added samr and wkssvc pipes.

proto.h :

usual.  can we actually _remove_ proto.h from the cvs tree, and
have it as one of the Makefile dependencies, or something?

reply.c :

get_smbpwnam() renamed to get_smbpwd_entry() - also changed response
error code when logging in from a WORKSTATION$ account.  yes, paul
is right: we need to know when to return the right error code, and why.

server.c :

added call to reset_chain_pnum().

#ifdef NTDOMAIN added call to init_lsa_policy_hnd() #endif.  jeremy,
you'd be proud: i did a compile without NTDOMAIN, and caught a link
error for this function.

smb.h :

defines and structures for samr and wkssvc pipes.

smbpass.c :

modified get_smbpwnam() to get_smbpwd_entry() and it now takes
two arguments.  one for the name; if this is null, it looks up
by smb_userid instead.

oh, by the way, smb_userids are actually domain relative ids
(RIDs).  concatenate a RID with the domain SID, and you have
an internet globally unique way of identifying a user.

we're using RIDs in the wrong way....

added mod_smbpwnam() function.  this was based on code in smbpasswd.c

rpc_pipes/lsaparse.c :

added enum trusted domain parsing.  this is incomplete: i need
a packet trace to write it properly.

rpc_pipes/pipe_hnd.c :

added reset_chain_pnum() function.

rpc_pipes/pipenetlog.c :

get_smbpwnam() function renamed to get_smbpwd_entry().

arcfour() issues.

removed capability of get_md4pw() function to automatically add
workstation accounts.  this should either be done using
smbpasswd -add MACHINE$, or by using \PIPE\samr.

rpc_pipes/pipe_util.c :

create_pol_hnd() - creates a unique LSA Policy Handle.  overkill
function: uses a 64 bit sequence number; current unix time and
the smbd pid.

rpc_pipes/smbparse.c :

arcfour() issues.

smb_io_unistr2() should advance by uni_str_len not uni_max_len.

smb_io_smb_hdr_rb() - request bind uses uint16 for the context
id, and uint8 for the num_syntaxes.  oops, i put these both as

Added Files:

rpc_pipes/lsa_hnd.c :

on the samr pipe, allocate and associate an LSA Policy Handle
with a SID.  you receive queries with the LSA Policy Handle,
and have to turn this back into a SID in order to answer the

rpc_pipes/pipesamr.c rpc_pipes/samrparse.c

\PIPE\samr processing.  samr i presume is the SAM Replication pipe.

rpc_pipes/pipewkssvc.c rpc_pipes/wksparse.c

\PIPE\wkssvc processing.  the Workstation Service pipe?

holy cow.
(This used to be commit 1bd084b3e690eb26a1006d616075e53d711ecd2f)

22 years agolocal.h: Added OPLOCK_BREAK_TIMEOUT_FUDGEFACTOR.
Jeremy Allison [Thu, 6 Nov 1997 19:11:16 +0000 (19:11 +0000)]
proto.h: The usual.
server.c: Added timestring() messages to oplock logs. Added fix
          to allow file open processing to continue is an oplock
          break message times out.
(This used to be commit c45369217169fac261b32db71469c007db4b4a03)

22 years agochange from %D to %m/%d/%Y in timestring(). This doesn't really matter
Andrew Tridgell [Thu, 6 Nov 1997 13:45:50 +0000 (13:45 +0000)]
change from %D to %m/%d/%Y in timestring(). This doesn't really matter
as it is only for logging but it will prevent people from writing in
to say that we are not y2k compliant after running auto-diagnostic
(This used to be commit b4e55cd4765085fc2465c6ff757094e05eabc51e)

22 years agono asm/signal.h for linux as this is not portable
Andrew Tridgell [Thu, 6 Nov 1997 06:50:21 +0000 (06:50 +0000)]
no asm/signal.h for linux as this is not portable

add auto username from LOGNAME for smbtorture

proto fix in ufc.c
(This used to be commit f13dbdf307ccffc15a74e2ffa72da666e53a72b6)

22 years agoChange to always register the WORKGROUP<1e> name as does Win95.
Jeremy Allison [Wed, 5 Nov 1997 22:09:15 +0000 (22:09 +0000)]
Change to always register the WORKGROUP<1e> name as does Win95.
(This used to be commit 313fdcd3e99e0fa2bd44b30545cf32e36cd13119)

22 years agoadd NO_SEMUN for HP
Andrew Tridgell [Wed, 5 Nov 1997 12:21:45 +0000 (12:21 +0000)]
add NO_SEMUN for HP

I really wish you could say

#ifndef "struct foo_struct"

in C :-)
(This used to be commit acffb39f1aea9816ece41d66e9369375e9aa7df4)

22 years agosmb.h :
Luke Leighton [Tue, 4 Nov 1997 20:27:08 +0000 (20:27 +0000)]
smb.h :

LSA_OPENSECRET and three other unknown #defines are commented as not
being the real defines for these!!!

rpc_pipes/pipenetlog.c :

USE_ARCFOUR for Server Password Set.  and then ignore the password (agh!)
this will *fail* to do logins, by the way.  i need to add a routine
to update the smb password (next job).
(This used to be commit b9d26344cc9b64ef3578931d099d52eab080fdd3)

22 years agoRolling back the files
Jeremy Allison [Mon, 3 Nov 1997 19:24:45 +0000 (19:24 +0000)]
Rolling back the files
loadparm.c : to equivalent to version 1.67
reply.c : to equivalent to version 1.69
server.c : to equivalent to version 1.122
util.c : to equivalent to version 1.98

to remove the incorrect changes.

proto.h: The usual.

rpc_pipes/smbparse.c : Backeting stuff that SHOULD NOT BE IN THE
                       none-NTDOMAIN build !

(This used to be commit 6064c9d80fd9fcc3ceec528494ba5e2591610098)

22 years agoadded code that _uses_ arcfour. arcfour itself, or anything remotely
Luke Leighton [Mon, 3 Nov 1997 15:47:03 +0000 (15:47 +0000)]
added code that _uses_ arcfour.  arcfour itself, or anything remotely
like it, has *not* been added.

this is the client and server side of the SAM Logon NT and LM OWF password
obfuscation (rc4 with the long-term session key).
(This used to be commit 4cf4dd696714492f8e51661cab4736d66ab2916b)

22 years agopreparing for release of 1.9.18alpha11
Samba Release Account [Sun, 2 Nov 1997 20:47:35 +0000 (20:47 +0000)]
preparing for release of 1.9.18alpha11
(This used to be commit cadd772df72aa13018ea6e909ed0d7e294f24b5e)

22 years agoChristian Lademann's contribution: new capabilities in smb.conf.
Luke Leighton [Sun, 2 Nov 1997 20:35:20 +0000 (20:35 +0000)]
Christian Lademann's contribution:  new capabilities in smb.conf.

'<' and '|' characters indicate read file and execute command respectively,
and feed the output into the parameter (!!!).

'<$' and '|$' means run standard_sub_basic() on them.

this is going to be fun to document in smb.conf.5....

also, Christian created a new "online" service parameter.  services can
be taken "off-line"....
(This used to be commit 15f44d28916cdc1432bffdbb999c7cf7efd8fb86)

22 years agoupdated
Luke Leighton [Sun, 2 Nov 1997 19:59:20 +0000 (19:59 +0000)]
(This used to be commit f39fe3b62dd869f218bd8a2c66de7b91c0044192)

22 years agoupdated
Luke Leighton [Sun, 2 Nov 1997 19:47:48 +0000 (19:47 +0000)]
(This used to be commit 34325448542e307198635a15d5ff3bc895c24413)

22 years agodocumented "domain hosts allow/deny" parameters
Luke Leighton [Sun, 2 Nov 1997 19:40:07 +0000 (19:40 +0000)]
documented "domain hosts allow/deny" parameters
(This used to be commit adf3119245148d517913efb549e8b88d5ba66b39)

22 years agoloadparm.c :
Luke Leighton [Sun, 2 Nov 1997 19:27:26 +0000 (19:27 +0000)]
loadparm.c :

added "domain hosts allow" and "domain hosts deny".  these are to be
used to specify which workstations can log in to a samba PDC from.
it is also used to check whether to add an initial machine password
into the smbpasswd database or not

smbpass.c :

added capability to add a machine password to the smbpasswd database.
***** the default uid is zero *****

rpc_pipes/pipenetlog.c :

use of "domain hosts allow/deny" parameters to allow login access.

proto.h :

(This used to be commit 2e7d3410306640aa6402e0506430a53988cc583e)

22 years agofix some uchar/char conflicts
Andrew Tridgell [Sun, 2 Nov 1997 04:11:05 +0000 (04:11 +0000)]
fix some uchar/char conflicts
(This used to be commit c164681dfe2ad9623a59f01eea914bf27d4801e5)

22 years agoconvert the credentials code back to uchar[8] from uint32[2]
Andrew Tridgell [Sun, 2 Nov 1997 04:01:57 +0000 (04:01 +0000)]
convert the credentials code back to uchar[8] from uint32[2]

This should fix the byte order problems (maybe!)
(This used to be commit 21878e7d8628d05786c3c76f2943e31df1096577)

22 years agogot rid of redundent rpc_pipes/rpc_proto.h
Andrew Tridgell [Sun, 2 Nov 1997 03:10:42 +0000 (03:10 +0000)]
got rid of redundent rpc_pipes/rpc_proto.h
(This used to be commit 1a454f818841bf016ff04fd70cd73a5964d56f2e)

22 years agofix comments
Andrew Tridgell [Sun, 2 Nov 1997 01:33:28 +0000 (01:33 +0000)]
fix comments
(This used to be commit b3fd976b6c5c8342d04d87a7523864b09918d260)

22 years agoto avoid any possibility of the pipe getting full and blocking we now
Andrew Tridgell [Sun, 2 Nov 1997 01:25:50 +0000 (01:25 +0000)]
to avoid any possibility of the pipe getting full and blocking we now
only allow one query in the async dns pipe at a time. The others are
queued in the parent.
(This used to be commit f1004dd52adb29d088f0725e2c940ed44d3a764f)

22 years agodon't print the progress so often - it slows down the client too much
Andrew Tridgell [Sat, 1 Nov 1997 23:43:12 +0000 (23:43 +0000)]
don't print the progress so often - it slows down the client too much
(This used to be commit cc6e7706635ba4bf044ebd5a525113c1b2fd93e3)

22 years agominor async DNS cleanups
Andrew Tridgell [Sat, 1 Nov 1997 23:42:28 +0000 (23:42 +0000)]
minor async DNS cleanups

- start it earlier
- set DEBUGLEVEL to -1 to prevent any debug calls in child
- exit with _exit() to prevent logfile corruption
(This used to be commit 21dd073a2003fa4707c1577a6b07bcef30eb6a50)

22 years agopreparing for release of 1.9.18alpha10
Samba Release Account [Sat, 1 Nov 1997 19:36:04 +0000 (19:36 +0000)]
preparing for release of 1.9.18alpha10
(This used to be commit fa251b7eba48c9ef2d8d3d798ce5b99c8508c243)