From: Volker Lendecke Date: Sat, 15 Mar 2008 21:16:42 +0000 (+0100) Subject: Fix Coverity ID 563 X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba.git;a=commitdiff_plain;h=e6787aa133a1b241987319486c3bc46ac6ad41af Fix Coverity ID 563 dirmask is always set here, we've dereferenced it before anyway --- diff --git a/source/client/client.c b/source/client/client.c index b0b3e8e19b6..a285bccfe74 100644 --- a/source/client/client.c +++ b/source/client/client.c @@ -4102,11 +4102,7 @@ static void completion_remote_filter(const char *mnt, TALLOC_CTX *ctx = talloc_stackframe(); char *tmp; - if (info->dirmask && info->dirmask[0] != 0) { - tmp = talloc_strdup(ctx,info->dirmask); - } else { - tmp = talloc_strdup(ctx,""); - } + tmp = talloc_strdup(ctx,info->dirmask); if (!tmp) { TALLOC_FREE(ctx); return;