From: Andrew Tridgell <tridge@samba.org>
Date: Tue, 30 Sep 2008 15:44:06 +0000 (-0700)
Subject: cope with NULL attr
X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba.git;a=commitdiff_plain;h=dab5d4abbce7fc54427e5eb130e36860ffa74685

cope with NULL attr
---

diff --git a/source4/rpc_server/lsa/lsa_init.c b/source4/rpc_server/lsa/lsa_init.c
index a95cb10f9fa..8d8417109f8 100644
--- a/source4/rpc_server/lsa/lsa_init.c
+++ b/source4/rpc_server/lsa/lsa_init.c
@@ -199,7 +199,7 @@ NTSTATUS dcesrv_lsa_OpenPolicy2(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 
 	ZERO_STRUCTP(r->out.handle);
 
-	if (r->in.attr == NULL ||
+	if (r->in.attr != NULL &&
 	    r->in.attr->root_dir != NULL) {
 		/* MS-LSAD 3.1.4.4.1 */
 		return NT_STATUS_INVALID_PARAMETER;
@@ -217,6 +217,8 @@ NTSTATUS dcesrv_lsa_OpenPolicy2(struct dcesrv_call_state *dce_call, TALLOC_CTX *
 
 	handle->data = talloc_steal(handle, state);
 
+	/* need to check the access mask against - need ACLs - fails
+	   WSPP test */
 	state->access_mask = r->in.access_mask;
 	state->handle = handle;
 	*r->out.handle = handle->wire_handle;