From: Karolin Seeger <kseeger@samba.org>
Date: Wed, 24 Mar 2010 13:55:15 +0000 (+0100)
Subject: s3-testparm: Throw warning when 'workgroup' and 'netbios name' are identical.
X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba.git;a=commitdiff_plain;h=a6bfc1a2d0270197ee34405f3ce028a5919f1aaa

s3-testparm: Throw warning when 'workgroup' and 'netbios name' are identical.

Address bug #7285 (NetBIOS Namespace Clash Handling).

Karolin
---

diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c
index 3204de27d43..73e173e2097 100644
--- a/source3/utils/testparm.c
+++ b/source3/utils/testparm.c
@@ -77,6 +77,12 @@ cannot be set in the smb.conf file. nmbd will abort with this setting.\n");
 		ret = 1;
 	}
 
+	if (strequal(lp_workgroup(), global_myname())) {
+		fprintf(stderr, "WARNING: 'workgroup' and 'netbios name' " \
+			"must differ.\n");
+		ret = 1;
+	}
+
 	if (!directory_exist_stat(lp_lockdir(), &st)) {
 		fprintf(stderr, "ERROR: lock directory %s does not exist\n",
 		       lp_lockdir());