From: Volker Lendecke Date: Sat, 19 Jul 2008 10:47:31 +0000 (+0200) Subject: Fix RAW-OPEN against Samba3 X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba.git;a=commitdiff_plain;h=853ef0d5ef79b3187bd706f08d842170bc625cfd;hp=3408a2d18fa61e2a7e3b3e05cc3c454e5e15f2ce Fix RAW-OPEN against Samba3 This test assumed that fnums are recycled immediately after a close. This is not true on Samba 3. Andrew B., I assume this is just a bug in the test. Assuming recycled fnums might be true on Windows and Samba 4, but I don't think we should assume this everywhere. Volker (This used to be commit a4c3a59d47b2b1c794eda556d252c61907be1b3c) --- diff --git a/source4/torture/raw/open.c b/source4/torture/raw/open.c index 1901338e21c..b6979fa0d98 100644 --- a/source4/torture/raw/open.c +++ b/source4/torture/raw/open.c @@ -983,6 +983,7 @@ static bool test_nttrans_create(struct smbcli_state *cli, struct torture_context io.ntcreatex.in.create_options = create_option; status = smb_raw_open(cli->tree, tctx, &io); CHECK_STATUS(status, NT_STATUS_OK); + fnum = io.ntcreatex.out.file.fnum; CHECK_VAL(io.ntcreatex.out.oplock_level, 0); CHECK_VAL(io.ntcreatex.out.create_action, NTCREATEX_ACTION_EXISTED);