From: Rusty Russell <rusty@rustcorp.com.au>
Date: Tue, 17 Jul 2012 19:36:31 +0000 (+0930)
Subject: source3/registry/reg_backend_db.c: fix stackframe leak
X-Git-Url: http://git.samba.org/samba.git/?p=kai%2Fsamba.git;a=commitdiff_plain;h=15faffc53752f27c550c305435a1d7e1ea58514f

source3/registry/reg_backend_db.c: fix stackframe leak

regdb_store_values_internal() doesn't always free its stackframe.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---

diff --git a/source3/registry/reg_backend_db.c b/source3/registry/reg_backend_db.c
index 8fe1b8e61c4..75ad507e2b0 100644
--- a/source3/registry/reg_backend_db.c
+++ b/source3/registry/reg_backend_db.c
@@ -1961,7 +1961,8 @@ static NTSTATUS regdb_store_values_internal(struct db_context *db,
 	if (regval_ctr_numvals(values) == 0) {
 		werr = regdb_delete_values(db, key);
 		if (!W_ERROR_IS_OK(werr)) {
-			return werror_to_ntstatus(werr);
+			status = werror_to_ntstatus(werr);
+			goto done;
 		}
 
 		/*
@@ -1969,7 +1970,8 @@ static NTSTATUS regdb_store_values_internal(struct db_context *db,
 		 * from going to disk
 		 */
 		werr = regval_ctr_set_seqnum(values, dbwrap_get_seqnum(db));
-		return werror_to_ntstatus(werr);
+		status = werror_to_ntstatus(werr);
+		goto done;
 	}
 
 	ZERO_STRUCT(data);