regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete...
authorMichael Adam <obnox@samba.org>
Thu, 27 Mar 2008 17:01:43 +0000 (18:01 +0100)
committerMichael Adam <obnox@samba.org>
Thu, 27 Mar 2008 17:14:57 +0000 (18:14 +0100)
Michael
(This used to be commit 7dcd0c1e539df9ff1768a9c878b6687b9e1bfeac)

source3/registry/reg_backend_db.c

index 44fb5caeb9e7cb383aba91be44eaa05b61989044..ad1706829559fdcbc45066bcaa44ac41534d3426 100644 (file)
@@ -986,10 +986,10 @@ static WERROR regdb_set_secdesc(const char *key,
                /* assuming a delete */
                tdb_ret = dbwrap_trans_delete(regdb,
                                              string_term_tdb_data(tdbkey));
-               if (tdb_ret == -1) {
-                       err = ntstatus_to_werror(map_nt_error_from_unix(errno));
-               } else {
+               if (tdb_ret == 0) {
                        err = WERR_OK;
+               } else {
+                       err = ntstatus_to_werror(map_nt_error_from_unix(errno));
                }
                goto done;
        }
@@ -1003,7 +1003,7 @@ static WERROR regdb_set_secdesc(const char *key,
 
        tdb_ret = dbwrap_trans_store(regdb, string_term_tdb_data(tdbkey),
                                     tdbdata, 0);
-       if (tdb_ret == -1) {
+       if (tdb_ret != 0) {
                err = ntstatus_to_werror(map_nt_error_from_unix(errno));
                goto done;
        }