Revert "Registry server LDB backend: Don't make copies of the same type"

The original data pointer may go away so we do want to make copies in
this case.

This reverts commit 625359b2e266105022309df8985720108ecd6f67.

diff --git a/source4/lib/registry/ldb.c b/source4/lib/registry/ldb.c
index 9c1f59c4df6f75e28b6a39de651c33c4ca5fcbc2..018ea86d85ddf0c355c4008d8ebccc07de463d7d 100644 (file)
--- a/source4/lib/registry/ldb.c
+++ b/source4/lib/registry/ldb.c
@@ -72,7 +72,7 @@ static void reg_ldb_unpack_value(TALLOC_CTX *mem_ctx,
 
        case REG_BINARY:
                if (val != NULL)
-                       *data = *val;
+                       *data = data_blob_talloc(mem_ctx, val->data, val->length);
                else {
                        data->data = NULL;
                        data->length = 0;
@@ -86,7 +86,7 @@ static void reg_ldb_unpack_value(TALLOC_CTX *mem_ctx,
                break;
 
        default:
-               *data = *val;
+               *data = data_blob_talloc(mem_ctx, val->data, val->length);
                break;
        }
 }