Two useful "regshell" improvements
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Tue, 9 Sep 2008 16:01:20 +0000 (18:01 +0200)
committerMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Tue, 9 Sep 2008 16:01:20 +0000 (18:01 +0200)
This patch corrects the "change key" command (Follow up isn't supported yet) and adds a newline in a error message.

source/lib/registry/tools/regshell.c

index 4e859df3f60c7f8effbe02700518983ed15f4dab..ee8f366e6e29a152bbc43d07184ee09e479af100 100644 (file)
@@ -162,9 +162,7 @@ static WERROR cmd_ck(struct regshell_context *ctx, int argc, char **argv)
        struct registry_key *new = NULL;
        WERROR error;
 
-       if(argc < 2) {
-               new = ctx->current;
-       } else {
+       if(argc == 2) {
                error = reg_open_key(ctx->registry, ctx->current, argv[1],
                                     &new);
                if(!W_ERROR_IS_OK(error)) {
@@ -172,11 +170,11 @@ static WERROR cmd_ck(struct regshell_context *ctx, int argc, char **argv)
                                win_errstr(error)));
                        return error;
                }
-       }
 
-       ctx->path = talloc_asprintf(ctx, "%s\\%s", ctx->path, argv[1]);
-       printf("Current path is: %s\n", ctx->path);
-       ctx->current = new;
+               ctx->path = talloc_asprintf(ctx, "%s\\%s", ctx->path, argv[1]);
+               ctx->current = new;
+       }
+       printf("New path is: %s\n", ctx->path);
 
        return WERR_OK;
 }
@@ -188,7 +186,7 @@ static WERROR cmd_print(struct regshell_context *ctx, int argc, char **argv)
        WERROR error;
 
        if (argc != 2) {
-               fprintf(stderr, "Usage: print <valuename>");
+               fprintf(stderr, "Usage: print <valuename>\n");
                return WERR_INVALID_PARAM;
        }