s3: add a debug message for failed execv in sys_popen()
authorMichael Adam <obnox@samba.org>
Wed, 1 Aug 2012 13:42:49 +0000 (15:42 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 17 Aug 2012 18:07:07 +0000 (20:07 +0200)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
source3/lib/system.c

index 270d0f52f4b98d0dd6971da0a7ba6facd8c8b2a0..2881fd664a76f02d8c06a8a8f69471aea8452bdf 100644 (file)
@@ -1159,6 +1159,7 @@ int sys_popen(const char *command)
        int pipe_fds[2];
        popen_list *entry = NULL;
        char **argl = NULL;
+       int ret;
 
        if (pipe(pipe_fds) < 0)
                return -1;
@@ -1213,7 +1214,11 @@ int sys_popen(const char *command)
                for (p = popen_chain; p; p = p->next)
                        close(p->fd);
 
-               execv(argl[0], argl);
+               ret = execv(argl[0], argl);
+               if (ret == -1) {
+                       DEBUG(0, ("sys_popen: ERROR executing dfree command "
+                                 "'%s': %s\n", command, strerror(errno)));
+               }
                _exit (127);
        }