Always free_conn() after all the DEBUG()s etc.
authorAndrew Bartlett <abartlet@samba.org>
Thu, 4 Jul 2002 08:39:06 +0000 (08:39 +0000)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 4 Jul 2002 08:39:06 +0000 (08:39 +0000)
(This used to be commit 06529c0433bf75790aad27dd3cecf7005612c694)

source3/smbd/service.c

index 0fec7b24a947b5f1c7b115abbbfe141f441abc15..222101faa079a27e7b47c82729386965510bdec7 100644 (file)
@@ -455,9 +455,9 @@ static connection_struct *make_connection_snum(int snum, user_struct *vuser,
                        conn->force_user = True;
                        DEBUG(3,("Forced user %s\n",user));       
                } else {
-                       conn_free(conn);
                        DEBUG(1,("Couldn't find user %s\n",fuser));
                        *status = NT_STATUS_NO_SUCH_USER;
+                       conn_free(conn);
                        return NULL;
                }
        }
@@ -508,9 +508,9 @@ static connection_struct *make_connection_snum(int snum, user_struct *vuser,
                                DEBUG(3,("Forced group %s\n",gname));
                        }
                } else {
-                       conn_free(conn);
-                       *status = NT_STATUS_NO_SUCH_GROUP;
                        DEBUG(1,("Couldn't find group %s\n",gname));
+                       *status = NT_STATUS_NO_SUCH_GROUP;
+                       conn_free(conn);
                }
        }
 #endif /* HAVE_GETGRNAM */