r20018: Fix a memleak in reg_createkey

(This used to be commit 281640823bfe25f513f44f6c6d7022a11b957fa5)

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 907d0236c70e56543fe1a341db68a85032b1dec5..7abf0538f8e2d6f71ea6cd8d4a9216febf97b69c 100644 (file)
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -334,8 +334,10 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key *parent,
 
        err = reg_openkey(ctx, key, path, desired_access, pkey);
        if (W_ERROR_IS_OK(err)) {
-               *paction = REG_OPENED_EXISTING_KEY;
-               return WERR_OK;
+               if (paction != NULL) {
+                       *paction = REG_OPENED_EXISTING_KEY;
+               }
+               goto done;
        }
 
        if (!W_ERROR_EQUAL(err, WERR_BADFILE)) {