Fix Coverity ID 478
authorVolker Lendecke <vl@samba.org>
Sun, 23 Mar 2008 16:57:01 +0000 (17:57 +0100)
committerVolker Lendecke <vl@samba.org>
Sun, 23 Mar 2008 17:28:23 +0000 (18:28 +0100)
(This used to be commit 5f77938dc4a280b654b8d08656f19a7d04cea8c7)

source3/registry/reg_backend_printing.c

index 582989d8d166ea0e0fac33639deda0adf4203cc1..b2cd5537068cead90faf67c1245cbe5c3ff5849f 100644 (file)
@@ -516,8 +516,7 @@ static int key_printers_fetch_values( const char *key, REGVAL_CTR *values )
        if ( (key_index = lookup_printerkey( p_data, printerdatakey )) == -1  ) {
                /* failure....should never happen if the client has a valid open handle first */
                DEBUG(10,("key_printers_fetch_values: Unknown keyname [%s]\n", printerdatakey));
-               if ( printer )
-                       free_a_printer( &printer, 2 );
+               free_a_printer( &printer, 2 );
                return -1;
        }